)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f5e3305469690bc4b179dff2775ca625ab9a738b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Port allowed address pairs to OVO"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I8d03528f8f45f5f50fa467b39245a513a37c5d89"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da6ed579_0534fcf8","line":9,"updated":"2016-01-18 17:04:21.000000000","message":"Obviously, commit message should be expanded.","commit_id":"e14ee0f14908ed6fce170503f2496231850c4bd1"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"a121312a202a4df8b0a41e2834e97289dbd07481","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch introduces Oslo VersionedObject for the"},{"line_number":10,"context_line":"port extension allowed address pairs."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I8d03528f8f45f5f50fa467b39245a513a37c5d89"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a5de9d1_83a9d47d","line":11,"updated":"2016-01-28 13:50:21.000000000","message":"Is there a BP/bug for all the OVO work going on? Would be good to collectively be able to track these efforts.","commit_id":"497ed88614858ce6614977b35e3b8a37faae06e2"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"ce6e38c58b231f9c3b60c4f49066c311908acfcb","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch introduces Oslo VersionedObject for the"},{"line_number":10,"context_line":"port extension allowed address pairs."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I8d03528f8f45f5f50fa467b39245a513a37c5d89"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a5de9d1_b5aeca96","line":11,"in_reply_to":"7a5de9d1_83a9d47d","updated":"2016-02-02 11:10:42.000000000","message":"Good idea. As discussed in yesterdays upgrade meeting: one RFE...we can then use the Partial-bug tag in the commit","commit_id":"497ed88614858ce6614977b35e3b8a37faae06e2"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"2f3edc6c1e69e345c8f957c1bff4f348b694cefa","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch introduces Oslo VersionedObject for the"},{"line_number":10,"context_line":"port extension allowed address pairs."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I8d03528f8f45f5f50fa467b39245a513a37c5d89"},{"line_number":13,"context_line":"Co-Authored-By: Martin Hickey \u003cmartin.hickey@ie.ibm.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5a5ae5dd_6bbd07d7","line":11,"updated":"2016-02-08 06:14:47.000000000","message":"a reference to bug or blueprint?","commit_id":"87133444c1d741e606d5d1f8cf08a0c6d65db1de"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"5acaef36372e4573d739b3876207e951d9f90b7a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch introduces Oslo VersionedObject for the"},{"line_number":10,"context_line":"port extension allowed address pairs."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I8d03528f8f45f5f50fa467b39245a513a37c5d89"},{"line_number":13,"context_line":"Co-Authored-By: Martin Hickey \u003cmartin.hickey@ie.ibm.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3a57f1b5_bfa63251","line":11,"in_reply_to":"5a5ae5dd_436d3ecb","updated":"2016-02-11 15:17:51.000000000","message":"Sure, thanks.","commit_id":"87133444c1d741e606d5d1f8cf08a0c6d65db1de"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"5acaef36372e4573d739b3876207e951d9f90b7a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch introduces Oslo VersionedObject for the"},{"line_number":10,"context_line":"port extension allowed address pairs."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I8d03528f8f45f5f50fa467b39245a513a37c5d89"},{"line_number":13,"context_line":"Co-Authored-By: Martin Hickey \u003cmartin.hickey@ie.ibm.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3a57f1b5_ffacaa36","line":11,"in_reply_to":"5a5ae5dd_6bbd07d7","updated":"2016-02-11 15:17:51.000000000","message":"Refer to Paul\u0027s comment below.","commit_id":"87133444c1d741e606d5d1f8cf08a0c6d65db1de"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"bf47170f198fbdf7ec68314a21c7bd43a04274c9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch introduces Oslo VersionedObject for the"},{"line_number":10,"context_line":"port extension allowed address pairs."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I8d03528f8f45f5f50fa467b39245a513a37c5d89"},{"line_number":13,"context_line":"Co-Authored-By: Martin Hickey \u003cmartin.hickey@ie.ibm.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5a5ae5dd_436d3ecb","line":11,"in_reply_to":"5a5ae5dd_6bbd07d7","updated":"2016-02-09 13:04:22.000000000","message":"We have 1541928 to use.","commit_id":"87133444c1d741e606d5d1f8cf08a0c6d65db1de"}],"neutron/db/allowed_address_pairs/models.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f5e3305469690bc4b179dff2775ca625ab9a738b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from neutron.db import models_v2"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class AllowedAddressPair(model_base.BASEV2):"},{"line_number":21,"context_line":"    port_id \u003d sa.Column(sa.String(36),"},{"line_number":22,"context_line":"                        sa.ForeignKey(\u0027ports.id\u0027, ondelete\u003d\"CASCADE\"),"},{"line_number":23,"context_line":"                        primary_key\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_e8fe5d04","line":20,"updated":"2016-01-18 17:04:21.000000000","message":"Should we import the file from neutron/db/migration/models/head.py ?","commit_id":"e14ee0f14908ed6fce170503f2496231850c4bd1"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"2e6e6da82c1a56d2f7510c3a3b983353f6a5bd5d","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from neutron.db import models_v2"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class AllowedAddressPair(model_base.BASEV2):"},{"line_number":21,"context_line":"    port_id \u003d sa.Column(sa.String(36),"},{"line_number":22,"context_line":"                        sa.ForeignKey(\u0027ports.id\u0027, ondelete\u003d\"CASCADE\"),"},{"line_number":23,"context_line":"                        primary_key\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_0435e2f5","line":20,"in_reply_to":"da6ed579_e8fe5d04","updated":"2016-01-21 18:19:54.000000000","message":"yep","commit_id":"e14ee0f14908ed6fce170503f2496231850c4bd1"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"04580428c9d112166e1b6fb395519a54b3345a91","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from neutron.db import models_v2"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class AllowedAddressPair(model_base.BASEV2):"},{"line_number":21,"context_line":"    port_id \u003d sa.Column(sa.String(36),"},{"line_number":22,"context_line":"                        sa.ForeignKey(\u0027ports.id\u0027, ondelete\u003d\"CASCADE\"),"},{"line_number":23,"context_line":"                        primary_key\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_71886423","line":20,"updated":"2016-02-15 13:24:45.000000000","message":"While I agree that moving models could be a noble goal, I am not sure there was a need to do it as part of this patch.","commit_id":"26d3390c8ce0507989ffba6fa1ea8b6cb3bcf246"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ee0cbd34f676461f6f20873055c3ba5c2f186522","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from neutron.db import models_v2"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class AllowedAddressPair(model_base.BASEV2):"},{"line_number":21,"context_line":"    port_id \u003d sa.Column(sa.String(36),"},{"line_number":22,"context_line":"                        sa.ForeignKey(\u0027ports.id\u0027, ondelete\u003d\"CASCADE\"),"},{"line_number":23,"context_line":"                        primary_key\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_91eb62b0","line":20,"in_reply_to":"bae84128_22987177","updated":"2016-02-25 09:13:11.000000000","message":"I prefer we don\u0027t move code in the same patch that introduces the object.","commit_id":"26d3390c8ce0507989ffba6fa1ea8b6cb3bcf246"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"82ca65514130cead20611e2f1e8b9e81bdf2d0a6","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from neutron.db import models_v2"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class AllowedAddressPair(model_base.BASEV2):"},{"line_number":21,"context_line":"    port_id \u003d sa.Column(sa.String(36),"},{"line_number":22,"context_line":"                        sa.ForeignKey(\u0027ports.id\u0027, ondelete\u003d\"CASCADE\"),"},{"line_number":23,"context_line":"                        primary_key\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_22987177","line":20,"in_reply_to":"bae84128_e5f46588","updated":"2016-02-24 17:25:22.000000000","message":"Sorry Ihar, unsure what you want to be done?","commit_id":"26d3390c8ce0507989ffba6fa1ea8b6cb3bcf246"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"af44ec46a30be2926514fe9d9a1bbd1fb6f325fd","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from neutron.db import models_v2"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class AllowedAddressPair(model_base.BASEV2):"},{"line_number":21,"context_line":"    port_id \u003d sa.Column(sa.String(36),"},{"line_number":22,"context_line":"                        sa.ForeignKey(\u0027ports.id\u0027, ondelete\u003d\"CASCADE\"),"},{"line_number":23,"context_line":"                        primary_key\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_d8e835b7","line":20,"in_reply_to":"dae33548_71886423","updated":"2016-02-16 17:04:09.000000000","message":"ok. Will I leave it as is now that is has been moved?","commit_id":"26d3390c8ce0507989ffba6fa1ea8b6cb3bcf246"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9a136b60a1cd10325be8f1a43921a5835a25f3aa","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from neutron.db import models_v2"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class AllowedAddressPair(model_base.BASEV2):"},{"line_number":21,"context_line":"    port_id \u003d sa.Column(sa.String(36),"},{"line_number":22,"context_line":"                        sa.ForeignKey(\u0027ports.id\u0027, ondelete\u003d\"CASCADE\"),"},{"line_number":23,"context_line":"                        primary_key\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_e5f46588","line":20,"in_reply_to":"dae33548_d8e835b7","updated":"2016-02-22 13:47:09.000000000","message":"I prefer we don\u0027t mix things.","commit_id":"26d3390c8ce0507989ffba6fa1ea8b6cb3bcf246"}],"neutron/db/allowedaddresspairs_db.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f5e3305469690bc4b179dff2775ca625ab9a738b","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":89,"context_line":"            query.filter(AllowedAddressPair.port_id \u003d\u003d id).delete()"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def _make_allowed_address_pairs_dict(self, allowed_address_pairs,"},{"line_number":92,"context_line":"                                         fields\u003dNone):"},{"line_number":93,"context_line":"        res \u003d {\u0027mac_address\u0027: allowed_address_pairs[\u0027mac_address\u0027],"},{"line_number":94,"context_line":"               \u0027ip_address\u0027: allowed_address_pairs[\u0027ip_address\u0027]}"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_4b96d995","side":"PARENT","line":91,"updated":"2016-01-18 17:04:21.000000000","message":"I guess you didn\u0027t mean to remove it.","commit_id":"75d93584499fbda07d9fc846992efb42aa74e881"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"2e6e6da82c1a56d2f7510c3a3b983353f6a5bd5d","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":89,"context_line":"            query.filter(AllowedAddressPair.port_id \u003d\u003d id).delete()"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def _make_allowed_address_pairs_dict(self, allowed_address_pairs,"},{"line_number":92,"context_line":"                                         fields\u003dNone):"},{"line_number":93,"context_line":"        res \u003d {\u0027mac_address\u0027: allowed_address_pairs[\u0027mac_address\u0027],"},{"line_number":94,"context_line":"               \u0027ip_address\u0027: allowed_address_pairs[\u0027ip_address\u0027]}"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_87d9d485","side":"PARENT","line":91,"in_reply_to":"ba63e191_4b96d995","updated":"2016-01-21 18:19:54.000000000","message":"indeed :)","commit_id":"75d93584499fbda07d9fc846992efb42aa74e881"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f5e3305469690bc4b179dff2775ca625ab9a738b","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        return allowed_address_pairs"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def get_allowed_address_pairs(self, context, port_id):"},{"line_number":52,"context_line":"        pairs \u003d obj_addr_pair.AllowedAddressPairs.get_by_port_id("},{"line_number":53,"context_line":"            context, port_id)"},{"line_number":54,"context_line":"        return pairs"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_4889ffc9","line":52,"updated":"2016-01-18 17:04:21.000000000","message":"get_objects should have been enough, ain\u0027t it?","commit_id":"e14ee0f14908ed6fce170503f2496231850c4bd1"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"2e6e6da82c1a56d2f7510c3a3b983353f6a5bd5d","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        return allowed_address_pairs"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def get_allowed_address_pairs(self, context, port_id):"},{"line_number":52,"context_line":"        pairs \u003d obj_addr_pair.AllowedAddressPairs.get_by_port_id("},{"line_number":53,"context_line":"            context, port_id)"},{"line_number":54,"context_line":"        return pairs"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_2407c61d","line":52,"in_reply_to":"ba63e191_4889ffc9","updated":"2016-01-21 18:19:54.000000000","message":"right","commit_id":"e14ee0f14908ed6fce170503f2496231850c4bd1"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f5e3305469690bc4b179dff2775ca625ab9a738b","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    def get_allowed_address_pairs(self, context, port_id):"},{"line_number":52,"context_line":"        pairs \u003d obj_addr_pair.AllowedAddressPairs.get_by_port_id("},{"line_number":53,"context_line":"            context, port_id)"},{"line_number":54,"context_line":"        return pairs"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def _extend_port_dict_allowed_address_pairs(self, port_res, port_db):"},{"line_number":57,"context_line":"        # If port_db is provided, allowed address pairs will be accessed via"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_cb9ac9c5","line":54,"updated":"2016-01-18 17:04:21.000000000","message":"I wonder whether it\u0027s safe to return a list of objects here. I see that e.g. ml2 plugin uses the method internally. What if dict compatibility is not enough and breaks something? To stay on safe side and not mix compatibility issues with initial objects introduction, I would return dicts here (I think you should get it by calling dict() on the objects).","commit_id":"e14ee0f14908ed6fce170503f2496231850c4bd1"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"2e6e6da82c1a56d2f7510c3a3b983353f6a5bd5d","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    def get_allowed_address_pairs(self, context, port_id):"},{"line_number":52,"context_line":"        pairs \u003d obj_addr_pair.AllowedAddressPairs.get_by_port_id("},{"line_number":53,"context_line":"            context, port_id)"},{"line_number":54,"context_line":"        return pairs"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def _extend_port_dict_allowed_address_pairs(self, port_res, port_db):"},{"line_number":57,"context_line":"        # If port_db is provided, allowed address pairs will be accessed via"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_07864465","line":54,"in_reply_to":"ba63e191_cb9ac9c5","updated":"2016-01-21 18:19:54.000000000","message":"agreed","commit_id":"e14ee0f14908ed6fce170503f2496231850c4bd1"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"7b3b4ff095551209b79e76267e1d8ab9cde5cfdf","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from neutron.db import db_base_plugin_v2"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from neutron.extensions import allowedaddresspairs as addr_pair"},{"line_number":22,"context_line":"from neutron.objects import allowedaddresspairs as obj_addr_pair"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class AllowedAddressPairsMixin(object):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_1ac93759","line":22,"range":{"start_line":22,"start_character":51,"end_line":22,"end_character":64},"updated":"2016-01-25 11:13:44.000000000","message":"Should this be neutron.objects.port.extensions.allowedaddresspairs?","commit_id":"602eee8e8e5a5ba101bc2b10e7701987644290af"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"5d17411cc9a98dc6f7cdbf6030a76148574a4a6a","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from neutron.db import db_base_plugin_v2"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from neutron.extensions import allowedaddresspairs as addr_pair"},{"line_number":22,"context_line":"from neutron.objects import allowedaddresspairs as obj_addr_pair"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class AllowedAddressPairsMixin(object):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_1b626fd9","line":22,"range":{"start_line":22,"start_character":51,"end_line":22,"end_character":64},"in_reply_to":"9a68dd71_1ac93759","updated":"2016-01-27 11:57:18.000000000","message":"right!","commit_id":"602eee8e8e5a5ba101bc2b10e7701987644290af"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"467119f0476bc2dc50b5b8fcebbfc23cd70c5d30","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from neutron.extensions import allowedaddresspairs as addr_pair"},{"line_number":22,"context_line":"from neutron.objects.port.extensions import (allowedaddresspairs"},{"line_number":23,"context_line":"    as obj_addr_pair)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class AllowedAddressPairsMixin(object):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_51bf55d0","line":23,"range":{"start_line":23,"start_character":20,"end_line":23,"end_character":21},"updated":"2016-01-27 17:00:12.000000000","message":"import incorrect","commit_id":"497ed88614858ce6614977b35e3b8a37faae06e2"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"ce6e38c58b231f9c3b60c4f49066c311908acfcb","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from neutron.extensions import allowedaddresspairs as addr_pair"},{"line_number":22,"context_line":"from neutron.objects.port.extensions import (allowedaddresspairs"},{"line_number":23,"context_line":"    as obj_addr_pair)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class AllowedAddressPairsMixin(object):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_759ff250","line":23,"range":{"start_line":23,"start_character":20,"end_line":23,"end_character":21},"in_reply_to":"7a5de9d1_51bf55d0","updated":"2016-02-02 11:10:42.000000000","message":"Issue now fixed.","commit_id":"497ed88614858ce6614977b35e3b8a37faae06e2"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"19a4012b875389ba841fa01483685c814e3bf1a6","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        if not attr.is_attr_set(allowed_address_pairs):"},{"line_number":32,"context_line":"            return []"},{"line_number":33,"context_line":"        try:"},{"line_number":34,"context_line":"            with context.session.begin(subtransactions\u003dTrue):"},{"line_number":35,"context_line":"                for address_pair in allowed_address_pairs:"},{"line_number":36,"context_line":"                    # use port.mac_address if no mac address in address pair"},{"line_number":37,"context_line":"                    if \u0027mac_address\u0027 not in address_pair:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_f6505360","line":34,"updated":"2016-01-29 10:05:22.000000000","message":"If we are using OVO, we do not have to open session here.","commit_id":"497ed88614858ce6614977b35e3b8a37faae06e2"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"ce6e38c58b231f9c3b60c4f49066c311908acfcb","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        if not attr.is_attr_set(allowed_address_pairs):"},{"line_number":32,"context_line":"            return []"},{"line_number":33,"context_line":"        try:"},{"line_number":34,"context_line":"            with context.session.begin(subtransactions\u003dTrue):"},{"line_number":35,"context_line":"                for address_pair in allowed_address_pairs:"},{"line_number":36,"context_line":"                    # use port.mac_address if no mac address in address pair"},{"line_number":37,"context_line":"                    if \u0027mac_address\u0027 not in address_pair:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_75cdb25c","line":34,"in_reply_to":"7a5de9d1_9907b9c9","updated":"2016-02-02 11:10:42.000000000","message":"Done","commit_id":"497ed88614858ce6614977b35e3b8a37faae06e2"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"ce6e38c58b231f9c3b60c4f49066c311908acfcb","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        if not attr.is_attr_set(allowed_address_pairs):"},{"line_number":32,"context_line":"            return []"},{"line_number":33,"context_line":"        try:"},{"line_number":34,"context_line":"            with context.session.begin(subtransactions\u003dTrue):"},{"line_number":35,"context_line":"                for address_pair in allowed_address_pairs:"},{"line_number":36,"context_line":"                    # use port.mac_address if no mac address in address pair"},{"line_number":37,"context_line":"                    if \u0027mac_address\u0027 not in address_pair:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_55d0b6f7","line":34,"in_reply_to":"7a5de9d1_f6505360","updated":"2016-02-02 11:10:42.000000000","message":"Sure, removed.","commit_id":"497ed88614858ce6614977b35e3b8a37faae06e2"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"55688ebaebc08543cfc2e9a23789707b90cc1d48","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        if not attr.is_attr_set(allowed_address_pairs):"},{"line_number":32,"context_line":"            return []"},{"line_number":33,"context_line":"        try:"},{"line_number":34,"context_line":"            with context.session.begin(subtransactions\u003dTrue):"},{"line_number":35,"context_line":"                for address_pair in allowed_address_pairs:"},{"line_number":36,"context_line":"                    # use port.mac_address if no mac address in address pair"},{"line_number":37,"context_line":"                    if \u0027mac_address\u0027 not in address_pair:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_9907b9c9","line":34,"in_reply_to":"7a5de9d1_f6505360","updated":"2016-01-29 18:37:34.000000000","message":"right, I think it can be removed, thanks!","commit_id":"497ed88614858ce6614977b35e3b8a37faae06e2"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"19a4012b875389ba841fa01483685c814e3bf1a6","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def _delete_allowed_address_pairs(self, context, id):"},{"line_number":72,"context_line":"        pairs \u003d self.get_allowed_address_pairs(context, port_id\u003did)"},{"line_number":73,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":74,"context_line":"            for pair in pairs:"},{"line_number":75,"context_line":"                pair.delete()"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_d6dc37e6","line":73,"updated":"2016-01-29 10:05:22.000000000","message":"The same as line 34","commit_id":"497ed88614858ce6614977b35e3b8a37faae06e2"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"ce6e38c58b231f9c3b60c4f49066c311908acfcb","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def _delete_allowed_address_pairs(self, context, id):"},{"line_number":72,"context_line":"        pairs \u003d self.get_allowed_address_pairs(context, port_id\u003did)"},{"line_number":73,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":74,"context_line":"            for pair in pairs:"},{"line_number":75,"context_line":"                pair.delete()"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_b5380a3f","line":73,"in_reply_to":"7a5de9d1_d6dc37e6","updated":"2016-02-02 11:10:42.000000000","message":"Done.","commit_id":"497ed88614858ce6614977b35e3b8a37faae06e2"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"08fd7b9d76cfaa3ac209fa36a08c21851af660d0","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        if not attr.is_attr_set(allowed_address_pairs):"},{"line_number":31,"context_line":"            return []"},{"line_number":32,"context_line":"        try:"},{"line_number":33,"context_line":"            with context.session.begin(subtransactions\u003dTrue):"},{"line_number":34,"context_line":"                for address_pair in allowed_address_pairs:"},{"line_number":35,"context_line":"                    # use port.mac_address if no mac address in address pair"},{"line_number":36,"context_line":"                    if \u0027mac_address\u0027 not in address_pair:"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_99c9c4ae","line":33,"updated":"2016-02-01 12:18:59.000000000","message":"Can it be deleted? We have session managed by OVO.","commit_id":"7355c31f90163a628643e345c612f3730eeb4b46"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"b90124ea5823a31765ac3c9e66d1d982b53d4f99","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        if not attr.is_attr_set(allowed_address_pairs):"},{"line_number":31,"context_line":"            return []"},{"line_number":32,"context_line":"        try:"},{"line_number":33,"context_line":"            with context.session.begin(subtransactions\u003dTrue):"},{"line_number":34,"context_line":"                for address_pair in allowed_address_pairs:"},{"line_number":35,"context_line":"                    # use port.mac_address if no mac address in address pair"},{"line_number":36,"context_line":"                    if \u0027mac_address\u0027 not in address_pair:"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_907399e7","line":33,"in_reply_to":"7a5de9d1_5adc6574","updated":"2016-02-02 11:49:42.000000000","message":"Done.","commit_id":"7355c31f90163a628643e345c612f3730eeb4b46"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"b90124ea5823a31765ac3c9e66d1d982b53d4f99","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        if not attr.is_attr_set(allowed_address_pairs):"},{"line_number":31,"context_line":"            return []"},{"line_number":32,"context_line":"        try:"},{"line_number":33,"context_line":"            with context.session.begin(subtransactions\u003dTrue):"},{"line_number":34,"context_line":"                for address_pair in allowed_address_pairs:"},{"line_number":35,"context_line":"                    # use port.mac_address if no mac address in address pair"},{"line_number":36,"context_line":"                    if \u0027mac_address\u0027 not in address_pair:"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_70761dda","line":33,"in_reply_to":"7a5de9d1_99c9c4ae","updated":"2016-02-02 11:49:42.000000000","message":"Deleted.","commit_id":"7355c31f90163a628643e345c612f3730eeb4b46"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"4d72289f40f6af5f4892af8f3241dd4306bfacfc","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        if not attr.is_attr_set(allowed_address_pairs):"},{"line_number":31,"context_line":"            return []"},{"line_number":32,"context_line":"        try:"},{"line_number":33,"context_line":"            with context.session.begin(subtransactions\u003dTrue):"},{"line_number":34,"context_line":"                for address_pair in allowed_address_pairs:"},{"line_number":35,"context_line":"                    # use port.mac_address if no mac address in address pair"},{"line_number":36,"context_line":"                    if \u0027mac_address\u0027 not in address_pair:"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_5adc6574","line":33,"in_reply_to":"7a5de9d1_99c9c4ae","updated":"2016-02-02 10:11:14.000000000","message":"yes it can be deleted.","commit_id":"7355c31f90163a628643e345c612f3730eeb4b46"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"08fd7b9d76cfaa3ac209fa36a08c21851af660d0","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def _delete_allowed_address_pairs(self, context, id):"},{"line_number":71,"context_line":"        pairs \u003d self.get_allowed_address_pairs(context, port_id\u003did)"},{"line_number":72,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":73,"context_line":"            for pair in pairs:"},{"line_number":74,"context_line":"                pair.delete()"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_19be34ff","line":72,"updated":"2016-02-01 12:18:59.000000000","message":"Same line 33.","commit_id":"7355c31f90163a628643e345c612f3730eeb4b46"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"b90124ea5823a31765ac3c9e66d1d982b53d4f99","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def _delete_allowed_address_pairs(self, context, id):"},{"line_number":71,"context_line":"        pairs \u003d self.get_allowed_address_pairs(context, port_id\u003did)"},{"line_number":72,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":73,"context_line":"            for pair in pairs:"},{"line_number":74,"context_line":"                pair.delete()"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_507d21b0","line":72,"in_reply_to":"7a5de9d1_19be34ff","updated":"2016-02-02 11:49:42.000000000","message":"Done.","commit_id":"7355c31f90163a628643e345c612f3730eeb4b46"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"2f3edc6c1e69e345c8f957c1bff4f348b694cefa","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    def _delete_allowed_address_pairs(self, context, id):"},{"line_number":70,"context_line":"        pairs \u003d self.get_allowed_address_pairs(context, port_id\u003did)"},{"line_number":71,"context_line":"        for pair in pairs:"},{"line_number":72,"context_line":"            pair.delete()"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def make_allowed_address_pairs_dict(self, allowed_address_pairs,"},{"line_number":75,"context_line":"                                        fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a5ae5dd_ab545fc9","line":72,"updated":"2016-02-08 06:14:47.000000000","message":"this looks inefficient than the original code.","commit_id":"87133444c1d741e606d5d1f8cf08a0c6d65db1de"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"5acaef36372e4573d739b3876207e951d9f90b7a","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    def _delete_allowed_address_pairs(self, context, id):"},{"line_number":70,"context_line":"        pairs \u003d self.get_allowed_address_pairs(context, port_id\u003did)"},{"line_number":71,"context_line":"        for pair in pairs:"},{"line_number":72,"context_line":"            pair.delete()"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def make_allowed_address_pairs_dict(self, allowed_address_pairs,"},{"line_number":75,"context_line":"                                        fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a57f1b5_1f7d066e","line":72,"in_reply_to":"5a5ae5dd_ab545fc9","updated":"2016-02-11 15:17:51.000000000","message":"I am not sure of a better approach, do you have any suggestions? I am not sure if it is going to be very inefficient?","commit_id":"87133444c1d741e606d5d1f8cf08a0c6d65db1de"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"cf806682f1d5a16556646109ed7bed07eac8ad4a","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    def _delete_allowed_address_pairs(self, context, id):"},{"line_number":70,"context_line":"        pairs \u003d self.get_allowed_address_pairs(context, port_id\u003did)"},{"line_number":71,"context_line":"        for pair in pairs:"},{"line_number":72,"context_line":"            pair.delete()"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def make_allowed_address_pairs_dict(self, allowed_address_pairs,"},{"line_number":75,"context_line":"                                        fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a5ae5dd_be61e406","line":72,"in_reply_to":"5a5ae5dd_ab545fc9","updated":"2016-02-08 16:14:30.000000000","message":"We can move the multiple entry deletion to AllowedAddressPair OVO i.e. AllowedAddressPair.delete_by_port_id(context, port_id) but this would also require to create multiple entry delete function in db_api","commit_id":"87133444c1d741e606d5d1f8cf08a0c6d65db1de"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"5acaef36372e4573d739b3876207e951d9f90b7a","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    def _delete_allowed_address_pairs(self, context, id):"},{"line_number":70,"context_line":"        pairs \u003d self.get_allowed_address_pairs(context, port_id\u003did)"},{"line_number":71,"context_line":"        for pair in pairs:"},{"line_number":72,"context_line":"            pair.delete()"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def make_allowed_address_pairs_dict(self, allowed_address_pairs,"},{"line_number":75,"context_line":"                                        fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a57f1b5_ff926a9e","line":72,"in_reply_to":"5a5ae5dd_be61e406","updated":"2016-02-11 15:17:51.000000000","message":"Sure, agreed.","commit_id":"87133444c1d741e606d5d1f8cf08a0c6d65db1de"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"04580428c9d112166e1b6fb395519a54b3345a91","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        if not attr.is_attr_set(allowed_address_pairs):"},{"line_number":47,"context_line":"            return []"},{"line_number":48,"context_line":"        try:"},{"line_number":49,"context_line":"            with context.session.begin(subtransactions\u003dTrue):"},{"line_number":50,"context_line":"                for address_pair in allowed_address_pairs:"},{"line_number":51,"context_line":"                    # use port.mac_address if no mac address in address pair"},{"line_number":52,"context_line":"                    if \u0027mac_address\u0027 not in address_pair:"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_114758bc","side":"PARENT","line":49,"updated":"2016-02-15 13:24:45.000000000","message":"Why do we remove the transactional guarantee here? AFAIU this makes it possible to leave some address pairs created while others left out of database. Is it really what we want to do here?","commit_id":"a6ddf981e18a2247bffed90e6628820ad3bbcc94"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"7659d3859f02c08c1355330f5864301c8dc7bf05","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        if not attr.is_attr_set(allowed_address_pairs):"},{"line_number":47,"context_line":"            return []"},{"line_number":48,"context_line":"        try:"},{"line_number":49,"context_line":"            with context.session.begin(subtransactions\u003dTrue):"},{"line_number":50,"context_line":"                for address_pair in allowed_address_pairs:"},{"line_number":51,"context_line":"                    # use port.mac_address if no mac address in address pair"},{"line_number":52,"context_line":"                    if \u0027mac_address\u0027 not in address_pair:"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_e9b6443c","side":"PARENT","line":49,"in_reply_to":"dae33548_114758bc","updated":"2016-02-15 14:19:11.000000000","message":"It was my suggestion to try removing  the session here, because the OVO is handling the DB access and stuff. But your concerns seems legit...","commit_id":"a6ddf981e18a2247bffed90e6628820ad3bbcc94"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"af44ec46a30be2926514fe9d9a1bbd1fb6f325fd","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        if not attr.is_attr_set(allowed_address_pairs):"},{"line_number":47,"context_line":"            return []"},{"line_number":48,"context_line":"        try:"},{"line_number":49,"context_line":"            with context.session.begin(subtransactions\u003dTrue):"},{"line_number":50,"context_line":"                for address_pair in allowed_address_pairs:"},{"line_number":51,"context_line":"                    # use port.mac_address if no mac address in address pair"},{"line_number":52,"context_line":"                    if \u0027mac_address\u0027 not in address_pair:"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_bee1d900","side":"PARENT","line":49,"in_reply_to":"dae33548_114758bc","updated":"2016-02-16 17:04:09.000000000","message":"Thanks for \"heads up\".","commit_id":"a6ddf981e18a2247bffed90e6628820ad3bbcc94"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"af44ec46a30be2926514fe9d9a1bbd1fb6f325fd","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        if not attr.is_attr_set(allowed_address_pairs):"},{"line_number":47,"context_line":"            return []"},{"line_number":48,"context_line":"        try:"},{"line_number":49,"context_line":"            with context.session.begin(subtransactions\u003dTrue):"},{"line_number":50,"context_line":"                for address_pair in allowed_address_pairs:"},{"line_number":51,"context_line":"                    # use port.mac_address if no mac address in address pair"},{"line_number":52,"context_line":"                    if \u0027mac_address\u0027 not in address_pair:"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_d845d570","side":"PARENT","line":49,"in_reply_to":"dae33548_e9b6443c","updated":"2016-02-16 17:04:09.000000000","message":"Ok. I will re-add it.","commit_id":"a6ddf981e18a2247bffed90e6628820ad3bbcc94"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"04580428c9d112166e1b6fb395519a54b3345a91","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    def get_allowed_address_pairs(self, context, port_id):"},{"line_number":51,"context_line":"        pairs \u003d obj_addr_pair.AllowedAddressPair.get_objects("},{"line_number":52,"context_line":"            context, port_id\u003dport_id)"},{"line_number":53,"context_line":"        return pairs"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def _extend_port_dict_allowed_address_pairs(self, port_res, port_db):"},{"line_number":56,"context_line":"        # If port_db is provided, allowed address pairs will be accessed via"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_91d6c8c3","line":53,"updated":"2016-02-15 13:24:45.000000000","message":"Is it really safe to return objects here? I wonder whether we want to go this route in those cases, or we may want to introduce new objectified methods in parallel to existing ones and deprecate the latter later.\n\nI prefer we split the matters, first introducing objects, then switching APIs.","commit_id":"26d3390c8ce0507989ffba6fa1ea8b6cb3bcf246"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"af44ec46a30be2926514fe9d9a1bbd1fb6f325fd","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    def get_allowed_address_pairs(self, context, port_id):"},{"line_number":51,"context_line":"        pairs \u003d obj_addr_pair.AllowedAddressPair.get_objects("},{"line_number":52,"context_line":"            context, port_id\u003dport_id)"},{"line_number":53,"context_line":"        return pairs"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def _extend_port_dict_allowed_address_pairs(self, port_res, port_db):"},{"line_number":56,"context_line":"        # If port_db is provided, allowed address pairs will be accessed via"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_7e2ab17f","line":53,"in_reply_to":"dae33548_91d6c8c3","updated":"2016-02-16 17:04:09.000000000","message":"It might make more sense to not make both changes at the same time. I have created a new API to return as objects.","commit_id":"26d3390c8ce0507989ffba6fa1ea8b6cb3bcf246"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"04580428c9d112166e1b6fb395519a54b3345a91","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    def _delete_allowed_address_pairs(self, context, id):"},{"line_number":70,"context_line":"        pairs \u003d self.get_allowed_address_pairs(context, port_id\u003did)"},{"line_number":71,"context_line":"        for pair in pairs:"},{"line_number":72,"context_line":"            pair.delete()"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def make_allowed_address_pairs_dict(self, allowed_address_pairs,"},{"line_number":75,"context_line":"                                        fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_d12210b9","line":72,"updated":"2016-02-15 13:24:45.000000000","message":"(No action required) As YAMAMOTO mentioned before, it\u0027s probably a bit less efficient since you\u0027ll have multiple DELETE statements instead of a single one with WHERE part; but I also believe it\u0027s not a huge deal here.","commit_id":"26d3390c8ce0507989ffba6fa1ea8b6cb3bcf246"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"af44ec46a30be2926514fe9d9a1bbd1fb6f325fd","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    def _delete_allowed_address_pairs(self, context, id):"},{"line_number":70,"context_line":"        pairs \u003d self.get_allowed_address_pairs(context, port_id\u003did)"},{"line_number":71,"context_line":"        for pair in pairs:"},{"line_number":72,"context_line":"            pair.delete()"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def make_allowed_address_pairs_dict(self, allowed_address_pairs,"},{"line_number":75,"context_line":"                                        fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_7b03e30d","line":72,"in_reply_to":"dae33548_d12210b9","updated":"2016-02-16 17:04:09.000000000","message":"Agreed.","commit_id":"26d3390c8ce0507989ffba6fa1ea8b6cb3bcf246"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"04580428c9d112166e1b6fb395519a54b3345a91","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        for pair in pairs:"},{"line_number":72,"context_line":"            pair.delete()"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def make_allowed_address_pairs_dict(self, allowed_address_pairs,"},{"line_number":75,"context_line":"                                        fields\u003dNone):"},{"line_number":76,"context_line":"        res \u003d {\u0027mac_address\u0027: allowed_address_pairs[\u0027mac_address\u0027],"},{"line_number":77,"context_line":"               \u0027ip_address\u0027: allowed_address_pairs[\u0027ip_address\u0027]}"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_f1b0f48d","line":74,"updated":"2016-02-15 13:24:45.000000000","message":"Why do we rename the method?","commit_id":"26d3390c8ce0507989ffba6fa1ea8b6cb3bcf246"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"af44ec46a30be2926514fe9d9a1bbd1fb6f325fd","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        for pair in pairs:"},{"line_number":72,"context_line":"            pair.delete()"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def make_allowed_address_pairs_dict(self, allowed_address_pairs,"},{"line_number":75,"context_line":"                                        fields\u003dNone):"},{"line_number":76,"context_line":"        res \u003d {\u0027mac_address\u0027: allowed_address_pairs[\u0027mac_address\u0027],"},{"line_number":77,"context_line":"               \u0027ip_address\u0027: allowed_address_pairs[\u0027ip_address\u0027]}"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_1e228552","line":74,"in_reply_to":"dae33548_f1b0f48d","updated":"2016-02-16 17:04:09.000000000","message":"This was a knock on effect of updating the API (refer to comment L53) for neutron/plugins/ml2/plugin.py (L1162) to work. As we are going to leave as is with the API returning a dict then this change is not needed. Removing the change.","commit_id":"26d3390c8ce0507989ffba6fa1ea8b6cb3bcf246"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9b24c9f84bf2ce35e856b29bdc42cc17741140f0","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from neutron.extensions import allowedaddresspairs as addr_pair"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class AllowedAddressPair(model_base.BASEV2):"},{"line_number":29,"context_line":"    port_id \u003d sa.Column(sa.String(36),"},{"line_number":30,"context_line":"                        sa.ForeignKey(\u0027ports.id\u0027, ondelete\u003d\"CASCADE\"),"},{"line_number":31,"context_line":"                        primary_key\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9aed3d3a_a4719eaa","side":"PARENT","line":28,"updated":"2016-02-29 11:10:20.000000000","message":"Moving the model into a separate file still seems unfitting for the patch to me.","commit_id":"a9db5b6f3f7f1507788725669a67b43f0197c077"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5ccfbe1e64775abdbaf979c28a34ae084e1dcfe1","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from neutron.extensions import allowedaddresspairs as addr_pair"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class AllowedAddressPair(model_base.BASEV2):"},{"line_number":29,"context_line":"    port_id \u003d sa.Column(sa.String(36),"},{"line_number":30,"context_line":"                        sa.ForeignKey(\u0027ports.id\u0027, ondelete\u003d\"CASCADE\"),"},{"line_number":31,"context_line":"                        primary_key\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7af24918_29c9bf26","side":"PARENT","line":28,"in_reply_to":"7af24918_c8901c46","updated":"2016-03-03 14:57:05.000000000","message":"It\u0027s fine to move it there, but it\u0027s better to split patches into separately reviewable pieces.","commit_id":"a9db5b6f3f7f1507788725669a67b43f0197c077"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"620e9721dd2dbad4b2906c5cd5f048c9c8f85c33","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from neutron.extensions import allowedaddresspairs as addr_pair"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class AllowedAddressPair(model_base.BASEV2):"},{"line_number":29,"context_line":"    port_id \u003d sa.Column(sa.String(36),"},{"line_number":30,"context_line":"                        sa.ForeignKey(\u0027ports.id\u0027, ondelete\u003d\"CASCADE\"),"},{"line_number":31,"context_line":"                        primary_key\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7af24918_c8901c46","side":"PARENT","line":28,"in_reply_to":"9aed3d3a_a4719eaa","updated":"2016-03-03 14:53:47.000000000","message":"Could you elaborate more on why you think this? IIRC, this is the pattern as suggested by rossella_s.","commit_id":"a9db5b6f3f7f1507788725669a67b43f0197c077"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9b24c9f84bf2ce35e856b29bdc42cc17741140f0","unresolved":false,"context_lines":[{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":5,"context_line":"#    a copy of the License at"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"#         http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":"#    Unless required by applicable law or agreed to in writing, software"}],"source_content_type":"text/x-python","patch_set":11,"id":"9aed3d3a_044e8a3a","line":6,"updated":"2016-02-29 11:10:20.000000000","message":"As was discussed in irc, this patch should be split into two pieces: one for objects implementation, another one for adopting the object in db classes.","commit_id":"569d13879ee467b57cd3c5d4afc504c26712d7a9"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"620e9721dd2dbad4b2906c5cd5f048c9c8f85c33","unresolved":false,"context_lines":[{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":5,"context_line":"#    a copy of the License at"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"#         http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":"#    Unless required by applicable law or agreed to in writing, software"}],"source_content_type":"text/x-python","patch_set":11,"id":"7af24918_e8b238e4","line":6,"in_reply_to":"9aed3d3a_044e8a3a","updated":"2016-03-03 14:53:47.000000000","message":"Sure, done in PS 13.","commit_id":"569d13879ee467b57cd3c5d4afc504c26712d7a9"},{"author":{"_account_id":9178,"name":"Sayali Lunkad","email":"sayali.lunkad@suse.com","username":"sayalilunkad"},"change_message_id":"0ed8cac8d8f75e6d88be664463c9746d8cad9792","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        return allowed_address_pairs"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def get_allowed_address_pairs(self, context, port_id):"},{"line_number":52,"context_line":"        pairs \u003d obj_addr_pair.AllowedAddressPair.get_objects("},{"line_number":53,"context_line":"            context, port_id\u003dport_id)"},{"line_number":54,"context_line":"        return [self._make_allowed_address_pairs_dict(pair)"},{"line_number":55,"context_line":"                for pair in pairs]"}],"source_content_type":"text/x-python","patch_set":11,"id":"dae33548_345498c8","line":52,"range":{"start_line":52,"start_character":8,"end_line":52,"end_character":13},"updated":"2016-02-17 11:41:15.000000000","message":"shouldn\u0027t this be called from get_allowed_address_pairs_obj?","commit_id":"569d13879ee467b57cd3c5d4afc504c26712d7a9"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"620e9721dd2dbad4b2906c5cd5f048c9c8f85c33","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        return allowed_address_pairs"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def get_allowed_address_pairs(self, context, port_id):"},{"line_number":52,"context_line":"        pairs \u003d obj_addr_pair.AllowedAddressPair.get_objects("},{"line_number":53,"context_line":"            context, port_id\u003dport_id)"},{"line_number":54,"context_line":"        return [self._make_allowed_address_pairs_dict(pair)"},{"line_number":55,"context_line":"                for pair in pairs]"}],"source_content_type":"text/x-python","patch_set":11,"id":"7af24918_e37ed968","line":52,"range":{"start_line":52,"start_character":8,"end_line":52,"end_character":13},"in_reply_to":"9aed3d3a_642dd694","updated":"2016-03-03 14:53:47.000000000","message":"Sure, makes sense. Updated.","commit_id":"569d13879ee467b57cd3c5d4afc504c26712d7a9"},{"author":{"_account_id":9178,"name":"Sayali Lunkad","email":"sayali.lunkad@suse.com","username":"sayalilunkad"},"change_message_id":"3a1615eab3e42e41771f573c904a7dfd58c3fa2d","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        return allowed_address_pairs"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def get_allowed_address_pairs(self, context, port_id):"},{"line_number":52,"context_line":"        pairs \u003d obj_addr_pair.AllowedAddressPair.get_objects("},{"line_number":53,"context_line":"            context, port_id\u003dport_id)"},{"line_number":54,"context_line":"        return [self._make_allowed_address_pairs_dict(pair)"},{"line_number":55,"context_line":"                for pair in pairs]"}],"source_content_type":"text/x-python","patch_set":11,"id":"dae33548_2bd432ea","line":52,"range":{"start_line":52,"start_character":8,"end_line":52,"end_character":13},"in_reply_to":"dae33548_345498c8","updated":"2016-02-17 12:23:52.000000000","message":"Ah got why this is done this way from previous comments.","commit_id":"569d13879ee467b57cd3c5d4afc504c26712d7a9"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"f48a6f433f3f06d653619971aee361c2cc37c017","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        return allowed_address_pairs"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def get_allowed_address_pairs(self, context, port_id):"},{"line_number":52,"context_line":"        pairs \u003d obj_addr_pair.AllowedAddressPair.get_objects("},{"line_number":53,"context_line":"            context, port_id\u003dport_id)"},{"line_number":54,"context_line":"        return [self._make_allowed_address_pairs_dict(pair)"},{"line_number":55,"context_line":"                for pair in pairs]"}],"source_content_type":"text/x-python","patch_set":11,"id":"dae33548_bc31a15c","line":52,"range":{"start_line":52,"start_character":8,"end_line":52,"end_character":13},"in_reply_to":"dae33548_345498c8","updated":"2016-02-17 15:23:05.000000000","message":"From Ihar\u0027s comment to update objects first in this patch and then APIs in a later patch.","commit_id":"569d13879ee467b57cd3c5d4afc504c26712d7a9"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9b24c9f84bf2ce35e856b29bdc42cc17741140f0","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        return allowed_address_pairs"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def get_allowed_address_pairs(self, context, port_id):"},{"line_number":52,"context_line":"        pairs \u003d obj_addr_pair.AllowedAddressPair.get_objects("},{"line_number":53,"context_line":"            context, port_id\u003dport_id)"},{"line_number":54,"context_line":"        return [self._make_allowed_address_pairs_dict(pair)"},{"line_number":55,"context_line":"                for pair in pairs]"}],"source_content_type":"text/x-python","patch_set":11,"id":"9aed3d3a_642dd694","line":52,"range":{"start_line":52,"start_character":8,"end_line":52,"end_character":13},"in_reply_to":"dae33548_bc31a15c","updated":"2016-02-29 11:10:20.000000000","message":"This method should probably rely on get_allowed_address_pairs_objs to avoid duplication.","commit_id":"569d13879ee467b57cd3c5d4afc504c26712d7a9"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9b24c9f84bf2ce35e856b29bdc42cc17741140f0","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        return [self._make_allowed_address_pairs_dict(pair)"},{"line_number":55,"context_line":"                for pair in pairs]"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def get_allowed_address_pairs_objs(self, context, port_id):"},{"line_number":58,"context_line":"        pairs \u003d obj_addr_pair.AllowedAddressPair.get_objects("},{"line_number":59,"context_line":"            context, port_id\u003dport_id)"},{"line_number":60,"context_line":"        return pairs"}],"source_content_type":"text/x-python","patch_set":11,"id":"9aed3d3a_443372f6","line":57,"updated":"2016-02-29 11:10:20.000000000","message":"I prefer we keep the method private (with underscore as prefix) until we decide it\u0027s part of public API.","commit_id":"569d13879ee467b57cd3c5d4afc504c26712d7a9"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"620e9721dd2dbad4b2906c5cd5f048c9c8f85c33","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        return [self._make_allowed_address_pairs_dict(pair)"},{"line_number":55,"context_line":"                for pair in pairs]"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def get_allowed_address_pairs_objs(self, context, port_id):"},{"line_number":58,"context_line":"        pairs \u003d obj_addr_pair.AllowedAddressPair.get_objects("},{"line_number":59,"context_line":"            context, port_id\u003dport_id)"},{"line_number":60,"context_line":"        return pairs"}],"source_content_type":"text/x-python","patch_set":11,"id":"7af24918_e814f84d","line":57,"in_reply_to":"9aed3d3a_443372f6","updated":"2016-03-03 14:53:47.000000000","message":"Sure, done.","commit_id":"569d13879ee467b57cd3c5d4afc504c26712d7a9"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9b24c9f84bf2ce35e856b29bdc42cc17741140f0","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def _delete_allowed_address_pairs(self, context, id):"},{"line_number":77,"context_line":"        pairs \u003d self.get_allowed_address_pairs_objs(context, port_id\u003did)"},{"line_number":78,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":79,"context_line":"            for pair in pairs:"},{"line_number":80,"context_line":"                pair.delete()"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9aed3d3a_a45a3e28","line":78,"updated":"2016-02-29 11:10:20.000000000","message":"(No action required) You may want to have a single transaction for both get and delete parts. But I see current code is written this way, so probably can be skipped.","commit_id":"569d13879ee467b57cd3c5d4afc504c26712d7a9"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"620e9721dd2dbad4b2906c5cd5f048c9c8f85c33","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def _delete_allowed_address_pairs(self, context, id):"},{"line_number":77,"context_line":"        pairs \u003d self.get_allowed_address_pairs_objs(context, port_id\u003did)"},{"line_number":78,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":79,"context_line":"            for pair in pairs:"},{"line_number":80,"context_line":"                pair.delete()"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"7af24918_28d0a0f5","line":78,"in_reply_to":"9aed3d3a_a45a3e28","updated":"2016-03-03 14:53:47.000000000","message":"Ok, leave as is for the moment.","commit_id":"569d13879ee467b57cd3c5d4afc504c26712d7a9"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9b24c9f84bf2ce35e856b29bdc42cc17741140f0","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                pair.delete()"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def _make_allowed_address_pairs_dict(self, allowed_address_pairs,"},{"line_number":83,"context_line":"                                        fields\u003dNone):"},{"line_number":84,"context_line":"        res \u003d {\u0027mac_address\u0027: allowed_address_pairs[\u0027mac_address\u0027],"},{"line_number":85,"context_line":"               \u0027ip_address\u0027: allowed_address_pairs[\u0027ip_address\u0027]}"},{"line_number":86,"context_line":"        return self._fields(res, fields)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9aed3d3a_c47ae276","line":83,"updated":"2016-02-29 11:10:20.000000000","message":"indentation changed for no reason.","commit_id":"569d13879ee467b57cd3c5d4afc504c26712d7a9"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"620e9721dd2dbad4b2906c5cd5f048c9c8f85c33","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                pair.delete()"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def _make_allowed_address_pairs_dict(self, allowed_address_pairs,"},{"line_number":83,"context_line":"                                        fields\u003dNone):"},{"line_number":84,"context_line":"        res \u003d {\u0027mac_address\u0027: allowed_address_pairs[\u0027mac_address\u0027],"},{"line_number":85,"context_line":"               \u0027ip_address\u0027: allowed_address_pairs[\u0027ip_address\u0027]}"},{"line_number":86,"context_line":"        return self._fields(res, fields)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7af24918_43c6ad9a","line":83,"in_reply_to":"9aed3d3a_c47ae276","updated":"2016-03-03 14:53:47.000000000","message":"Rolled back as was.","commit_id":"569d13879ee467b57cd3c5d4afc504c26712d7a9"}],"neutron/objects/allowedaddresspairs.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f5e3305469690bc4b179dff2775ca625ab9a738b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_a802fb6d","line":1,"updated":"2016-01-18 17:04:21.000000000","message":"I suggest we create another element in dir hierarchy for extensions. F.e.:\n\nneutron/objects/port/extensions/allowed_address_pair.py\n\nAnd then we\u0027ll add port.py as neutron/objects/port/port.py once it\u0027s there.","commit_id":"e14ee0f14908ed6fce170503f2496231850c4bd1"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f5e3305469690bc4b179dff2775ca625ab9a738b","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"@obj_base.VersionedObjectRegistry.register"},{"line_number":22,"context_line":"class AllowedAddressPairs(base.NeutronDbObject):"},{"line_number":23,"context_line":"    # Version 1.0: Initial version"},{"line_number":24,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_c87039a7","line":22,"updated":"2016-01-18 17:04:21.000000000","message":"Why is it Pairs, not Pair?","commit_id":"e14ee0f14908ed6fce170503f2496231850c4bd1"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"2e6e6da82c1a56d2f7510c3a3b983353f6a5bd5d","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"@obj_base.VersionedObjectRegistry.register"},{"line_number":22,"context_line":"class AllowedAddressPairs(base.NeutronDbObject):"},{"line_number":23,"context_line":"    # Version 1.0: Initial version"},{"line_number":24,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_e71210b4","line":22,"in_reply_to":"da6ed579_c87039a7","updated":"2016-01-21 18:19:54.000000000","message":"well it\u0027s not consistent everywhere but I\u0027ll rename it here to match the db table name","commit_id":"e14ee0f14908ed6fce170503f2496231850c4bd1"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f5e3305469690bc4b179dff2775ca625ab9a738b","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    db_model \u003d models.AllowedAddressPair"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    primary_key \u003d \u0027port_id\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    fields \u003d {"},{"line_number":31,"context_line":"        \u0027port_id\u0027: obj_fields.UUIDField(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_48cedf84","line":28,"updated":"2016-01-18 17:04:21.000000000","message":"But there are more primary keys in the object (actually, all of model fields). Should we somehow indicate it, f.e. with None, and then some special handling in get_by_id to bail out gracefully?","commit_id":"e14ee0f14908ed6fce170503f2496231850c4bd1"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"2e6e6da82c1a56d2f7510c3a3b983353f6a5bd5d","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    db_model \u003d models.AllowedAddressPair"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    primary_key \u003d \u0027port_id\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    fields \u003d {"},{"line_number":31,"context_line":"        \u0027port_id\u0027: obj_fields.UUIDField(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_ed850a07","line":28,"in_reply_to":"ba63e191_48cedf84","updated":"2016-01-21 18:19:54.000000000","message":"we need something better than bailing out or we need to modify the unit tests in BaseDbObjectTestCase since they rely on get_by_id. I will add a TODO for now","commit_id":"e14ee0f14908ed6fce170503f2496231850c4bd1"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f5e3305469690bc4b179dff2775ca625ab9a738b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    }"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @classmethod"},{"line_number":37,"context_line":"    def get_by_port_id(cls, context, port_id):"},{"line_number":38,"context_line":"        db_obj \u003d db_api.get_objects(context, cls.db_model, port_id\u003dport_id)"},{"line_number":39,"context_line":"        if db_obj:"},{"line_number":40,"context_line":"            obj \u003d cls(context, **db_obj)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_48e20931","line":37,"updated":"2016-01-18 17:04:21.000000000","message":"I don\u0027t think we need the method. existing get_objects should do the job.","commit_id":"e14ee0f14908ed6fce170503f2496231850c4bd1"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"2e6e6da82c1a56d2f7510c3a3b983353f6a5bd5d","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    }"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @classmethod"},{"line_number":37,"context_line":"    def get_by_port_id(cls, context, port_id):"},{"line_number":38,"context_line":"        db_obj \u003d db_api.get_objects(context, cls.db_model, port_id\u003dport_id)"},{"line_number":39,"context_line":"        if db_obj:"},{"line_number":40,"context_line":"            obj \u003d cls(context, **db_obj)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_c75d8c7a","line":37,"in_reply_to":"da6ed579_48e20931","updated":"2016-01-21 18:19:54.000000000","message":"I will remove it","commit_id":"e14ee0f14908ed6fce170503f2496231850c4bd1"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f5e3305469690bc4b179dff2775ca625ab9a738b","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    def get_by_port_id(cls, context, port_id):"},{"line_number":38,"context_line":"        db_obj \u003d db_api.get_objects(context, cls.db_model, port_id\u003dport_id)"},{"line_number":39,"context_line":"        if db_obj:"},{"line_number":40,"context_line":"            obj \u003d cls(context, **db_obj)"},{"line_number":41,"context_line":"            obj.obj_reset_changes()"},{"line_number":42,"context_line":"            return obj"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_48f9ffc7","line":40,"updated":"2016-01-18 17:04:21.000000000","message":"I think get_objects() return an iterable, not dict.","commit_id":"e14ee0f14908ed6fce170503f2496231850c4bd1"}],"neutron/objects/port/extensions/allowedaddresspairs.py":[{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"19a4012b875389ba841fa01483685c814e3bf1a6","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    primary_key \u003d \u0027port_id\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    fields \u003d {"},{"line_number":31,"context_line":"        \u0027port_id\u0027: obj_fields.UUIDField(),"},{"line_number":32,"context_line":"        #TODO(rossella_s) to use custom types like MacAddress and IPAddress"},{"line_number":33,"context_line":"        # we should define them like it\u0027s done in nova/db/sqlalchemy/types"},{"line_number":34,"context_line":"        # otherwise we get \"Error binding parameter\""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_f65a934f","line":31,"updated":"2016-01-29 10:05:22.000000000","message":"should be nullable\u003dFalse, as it is the primary key. I would also think if port_id can be changed? port_id should be put in \u0027fields_no_update\u0027 from NeutronDbObject base class","commit_id":"497ed88614858ce6614977b35e3b8a37faae06e2"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"ce6e38c58b231f9c3b60c4f49066c311908acfcb","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    primary_key \u003d \u0027port_id\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    fields \u003d {"},{"line_number":31,"context_line":"        \u0027port_id\u0027: obj_fields.UUIDField(),"},{"line_number":32,"context_line":"        #TODO(rossella_s) to use custom types like MacAddress and IPAddress"},{"line_number":33,"context_line":"        # we should define them like it\u0027s done in nova/db/sqlalchemy/types"},{"line_number":34,"context_line":"        # otherwise we get \"Error binding parameter\""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_60940e44","line":31,"in_reply_to":"7a5de9d1_cd9c8f11","updated":"2016-02-02 11:10:42.000000000","message":"Refer to the above comment.","commit_id":"497ed88614858ce6614977b35e3b8a37faae06e2"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"ce6e38c58b231f9c3b60c4f49066c311908acfcb","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    primary_key \u003d \u0027port_id\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    fields \u003d {"},{"line_number":31,"context_line":"        \u0027port_id\u0027: obj_fields.UUIDField(),"},{"line_number":32,"context_line":"        #TODO(rossella_s) to use custom types like MacAddress and IPAddress"},{"line_number":33,"context_line":"        # we should define them like it\u0027s done in nova/db/sqlalchemy/types"},{"line_number":34,"context_line":"        # otherwise we get \"Error binding parameter\""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_80ca6a6d","line":31,"in_reply_to":"7a5de9d1_f65a934f","updated":"2016-02-02 11:10:42.000000000","message":"As nullable by default, leaving as is. I have made port_id field not changeable.","commit_id":"497ed88614858ce6614977b35e3b8a37faae06e2"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"55688ebaebc08543cfc2e9a23789707b90cc1d48","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    primary_key \u003d \u0027port_id\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    fields \u003d {"},{"line_number":31,"context_line":"        \u0027port_id\u0027: obj_fields.UUIDField(),"},{"line_number":32,"context_line":"        #TODO(rossella_s) to use custom types like MacAddress and IPAddress"},{"line_number":33,"context_line":"        # we should define them like it\u0027s done in nova/db/sqlalchemy/types"},{"line_number":34,"context_line":"        # otherwise we get \"Error binding parameter\""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_cd9c8f11","line":31,"in_reply_to":"7a5de9d1_f65a934f","updated":"2016-01-29 18:37:34.000000000","message":"nullable is false by default, agreed regarding port_id","commit_id":"497ed88614858ce6614977b35e3b8a37faae06e2"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"19a4012b875389ba841fa01483685c814e3bf1a6","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        #TODO(rossella_s) to use custom types like MacAddress and IPAddress"},{"line_number":33,"context_line":"        # we should define them like it\u0027s done in nova/db/sqlalchemy/types"},{"line_number":34,"context_line":"        # otherwise we get \"Error binding parameter\""},{"line_number":35,"context_line":"        \u0027mac_address\u0027: obj_fields.StringField(),"},{"line_number":36,"context_line":"        \u0027ip_address\u0027: obj_fields.StringField(),"},{"line_number":37,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_b68f3bcb","line":35,"updated":"2016-01-29 10:05:22.000000000","message":"mac_address should be nullable\u003dFalse","commit_id":"497ed88614858ce6614977b35e3b8a37faae06e2"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"55688ebaebc08543cfc2e9a23789707b90cc1d48","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        #TODO(rossella_s) to use custom types like MacAddress and IPAddress"},{"line_number":33,"context_line":"        # we should define them like it\u0027s done in nova/db/sqlalchemy/types"},{"line_number":34,"context_line":"        # otherwise we get \"Error binding parameter\""},{"line_number":35,"context_line":"        \u0027mac_address\u0027: obj_fields.StringField(),"},{"line_number":36,"context_line":"        \u0027ip_address\u0027: obj_fields.StringField(),"},{"line_number":37,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_6d9d5b09","line":35,"in_reply_to":"7a5de9d1_b68f3bcb","updated":"2016-01-29 18:37:34.000000000","message":"ditto","commit_id":"497ed88614858ce6614977b35e3b8a37faae06e2"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"ce6e38c58b231f9c3b60c4f49066c311908acfcb","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        #TODO(rossella_s) to use custom types like MacAddress and IPAddress"},{"line_number":33,"context_line":"        # we should define them like it\u0027s done in nova/db/sqlalchemy/types"},{"line_number":34,"context_line":"        # otherwise we get \"Error binding parameter\""},{"line_number":35,"context_line":"        \u0027mac_address\u0027: obj_fields.StringField(),"},{"line_number":36,"context_line":"        \u0027ip_address\u0027: obj_fields.StringField(),"},{"line_number":37,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_c0eaa2ac","line":35,"in_reply_to":"7a5de9d1_b68f3bcb","updated":"2016-02-02 11:10:42.000000000","message":"ditto","commit_id":"497ed88614858ce6614977b35e3b8a37faae06e2"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"19a4012b875389ba841fa01483685c814e3bf1a6","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        # we should define them like it\u0027s done in nova/db/sqlalchemy/types"},{"line_number":34,"context_line":"        # otherwise we get \"Error binding parameter\""},{"line_number":35,"context_line":"        \u0027mac_address\u0027: obj_fields.StringField(),"},{"line_number":36,"context_line":"        \u0027ip_address\u0027: obj_fields.StringField(),"},{"line_number":37,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_f6acd336","line":36,"updated":"2016-01-29 10:05:22.000000000","message":"Should be nullable\u003dFalse","commit_id":"497ed88614858ce6614977b35e3b8a37faae06e2"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"55688ebaebc08543cfc2e9a23789707b90cc1d48","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        # we should define them like it\u0027s done in nova/db/sqlalchemy/types"},{"line_number":34,"context_line":"        # otherwise we get \"Error binding parameter\""},{"line_number":35,"context_line":"        \u0027mac_address\u0027: obj_fields.StringField(),"},{"line_number":36,"context_line":"        \u0027ip_address\u0027: obj_fields.StringField(),"},{"line_number":37,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_4d897fc8","line":36,"in_reply_to":"7a5de9d1_f6acd336","updated":"2016-01-29 18:37:34.000000000","message":"ditto","commit_id":"497ed88614858ce6614977b35e3b8a37faae06e2"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"ce6e38c58b231f9c3b60c4f49066c311908acfcb","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        # we should define them like it\u0027s done in nova/db/sqlalchemy/types"},{"line_number":34,"context_line":"        # otherwise we get \"Error binding parameter\""},{"line_number":35,"context_line":"        \u0027mac_address\u0027: obj_fields.StringField(),"},{"line_number":36,"context_line":"        \u0027ip_address\u0027: obj_fields.StringField(),"},{"line_number":37,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_60d08ef8","line":36,"in_reply_to":"7a5de9d1_f6acd336","updated":"2016-02-02 11:10:42.000000000","message":"ditto","commit_id":"497ed88614858ce6614977b35e3b8a37faae06e2"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"08fd7b9d76cfaa3ac209fa36a08c21851af660d0","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        \u0027port_id\u0027: obj_fields.UUIDField(),"},{"line_number":32,"context_line":"        #TODO(rossella_s) to use custom types like MacAddress and IPAddress"},{"line_number":33,"context_line":"        # we should define them like it\u0027s done in nova/db/sqlalchemy/types"},{"line_number":34,"context_line":"        # otherwise we get \"Error binding parameter\""},{"line_number":35,"context_line":"        \u0027mac_address\u0027: obj_fields.StringField(),"},{"line_number":36,"context_line":"        \u0027ip_address\u0027: obj_fields.StringField(),"},{"line_number":37,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_543eb1c1","line":34,"updated":"2016-02-01 12:18:59.000000000","message":"I\u0027m using the IPAddressField and IPNetworkField in Subnet OVO patch, and I\u0027m converting them to string in OVO. Should we introduce the patch with like nova sqlalchemy types conversion?","commit_id":"7355c31f90163a628643e345c612f3730eeb4b46"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"b90124ea5823a31765ac3c9e66d1d982b53d4f99","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        \u0027port_id\u0027: obj_fields.UUIDField(),"},{"line_number":32,"context_line":"        #TODO(rossella_s) to use custom types like MacAddress and IPAddress"},{"line_number":33,"context_line":"        # we should define them like it\u0027s done in nova/db/sqlalchemy/types"},{"line_number":34,"context_line":"        # otherwise we get \"Error binding parameter\""},{"line_number":35,"context_line":"        \u0027mac_address\u0027: obj_fields.StringField(),"},{"line_number":36,"context_line":"        \u0027ip_address\u0027: obj_fields.StringField(),"},{"line_number":37,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_f02f6da5","line":34,"in_reply_to":"7a5de9d1_543eb1c1","updated":"2016-02-02 11:49:42.000000000","message":"As discussed on IRC, we can update when patch is available. Thanks.","commit_id":"7355c31f90163a628643e345c612f3730eeb4b46"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"4d72289f40f6af5f4892af8f3241dd4306bfacfc","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        \u0027port_id\u0027: obj_fields.UUIDField(),"},{"line_number":32,"context_line":"        #TODO(rossella_s) to use custom types like MacAddress and IPAddress"},{"line_number":33,"context_line":"        # we should define them like it\u0027s done in nova/db/sqlalchemy/types"},{"line_number":34,"context_line":"        # otherwise we get \"Error binding parameter\""},{"line_number":35,"context_line":"        \u0027mac_address\u0027: obj_fields.StringField(),"},{"line_number":36,"context_line":"        \u0027ip_address\u0027: obj_fields.StringField(),"},{"line_number":37,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_9a565dcd","line":34,"in_reply_to":"7a5de9d1_543eb1c1","updated":"2016-02-02 10:11:14.000000000","message":"that\u0027s what I commented in your patch, instead of converting it to string we should handle it properly. So yes. It\u0027s already in the backlog so we are tracking this improvement","commit_id":"7355c31f90163a628643e345c612f3730eeb4b46"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"b90124ea5823a31765ac3c9e66d1d982b53d4f99","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        \u0027port_id\u0027: obj_fields.UUIDField(),"},{"line_number":32,"context_line":"        #TODO(rossella_s) to use custom types like MacAddress and IPAddress"},{"line_number":33,"context_line":"        # we should define them like it\u0027s done in nova/db/sqlalchemy/types"},{"line_number":34,"context_line":"        # otherwise we get \"Error binding parameter\""},{"line_number":35,"context_line":"        \u0027mac_address\u0027: obj_fields.StringField(),"},{"line_number":36,"context_line":"        \u0027ip_address\u0027: obj_fields.StringField(),"},{"line_number":37,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_7024ddc5","line":34,"in_reply_to":"7a5de9d1_9a565dcd","updated":"2016-02-02 11:49:42.000000000","message":"Refer to comment above.","commit_id":"7355c31f90163a628643e345c612f3730eeb4b46"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"04580428c9d112166e1b6fb395519a54b3345a91","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    db_model \u003d models.AllowedAddressPair"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    #TODO(rossella_s) find a way to handle multiple primary keys"},{"line_number":28,"context_line":"    primary_key \u003d \u0027port_id\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    fields_no_update \u003d [\u0027port_id\u0027]"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_6c9527e3","line":28,"updated":"2016-02-15 13:24:45.000000000","message":"Artur has a patch for that right?","commit_id":"26d3390c8ce0507989ffba6fa1ea8b6cb3bcf246"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"af44ec46a30be2926514fe9d9a1bbd1fb6f325fd","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    db_model \u003d models.AllowedAddressPair"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    #TODO(rossella_s) find a way to handle multiple primary keys"},{"line_number":28,"context_line":"    primary_key \u003d \u0027port_id\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    fields_no_update \u003d [\u0027port_id\u0027]"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_6a5787ce","line":28,"in_reply_to":"dae33548_26369b03","updated":"2016-02-16 17:04:09.000000000","message":"ok, updated comment to reference the patch for composite primary keys","commit_id":"26d3390c8ce0507989ffba6fa1ea8b6cb3bcf246"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"7659d3859f02c08c1355330f5864301c8dc7bf05","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    db_model \u003d models.AllowedAddressPair"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    #TODO(rossella_s) find a way to handle multiple primary keys"},{"line_number":28,"context_line":"    primary_key \u003d \u0027port_id\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    fields_no_update \u003d [\u0027port_id\u0027]"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_26369b03","line":28,"in_reply_to":"dae33548_6c9527e3","updated":"2016-02-15 14:19:11.000000000","message":"Yes, I have one :)","commit_id":"26d3390c8ce0507989ffba6fa1ea8b6cb3bcf246"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"04580428c9d112166e1b6fb395519a54b3345a91","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        \u0027port_id\u0027: obj_fields.UUIDField(),"},{"line_number":34,"context_line":"        #TODO(rossella_s) to use custom types like MacAddress and IPAddress"},{"line_number":35,"context_line":"        # we should define them like it\u0027s done in nova/db/sqlalchemy/types"},{"line_number":36,"context_line":"        # otherwise we get \"Error binding parameter\""},{"line_number":37,"context_line":"        \u0027mac_address\u0027: obj_fields.StringField(),"},{"line_number":38,"context_line":"        \u0027ip_address\u0027: obj_fields.StringField(),"},{"line_number":39,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_ecb0178e","line":36,"updated":"2016-02-15 13:24:45.000000000","message":"OK what\u0027s the plan for that? Do we have a patch?","commit_id":"26d3390c8ce0507989ffba6fa1ea8b6cb3bcf246"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"af44ec46a30be2926514fe9d9a1bbd1fb6f325fd","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        \u0027port_id\u0027: obj_fields.UUIDField(),"},{"line_number":34,"context_line":"        #TODO(rossella_s) to use custom types like MacAddress and IPAddress"},{"line_number":35,"context_line":"        # we should define them like it\u0027s done in nova/db/sqlalchemy/types"},{"line_number":36,"context_line":"        # otherwise we get \"Error binding parameter\""},{"line_number":37,"context_line":"        \u0027mac_address\u0027: obj_fields.StringField(),"},{"line_number":38,"context_line":"        \u0027ip_address\u0027: obj_fields.StringField(),"},{"line_number":39,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_ca5cd3ef","line":36,"in_reply_to":"dae33548_a65bcb53","updated":"2016-02-16 17:04:09.000000000","message":"Ok, updated comment to reference patch for the types.","commit_id":"26d3390c8ce0507989ffba6fa1ea8b6cb3bcf246"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"7659d3859f02c08c1355330f5864301c8dc7bf05","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        \u0027port_id\u0027: obj_fields.UUIDField(),"},{"line_number":34,"context_line":"        #TODO(rossella_s) to use custom types like MacAddress and IPAddress"},{"line_number":35,"context_line":"        # we should define them like it\u0027s done in nova/db/sqlalchemy/types"},{"line_number":36,"context_line":"        # otherwise we get \"Error binding parameter\""},{"line_number":37,"context_line":"        \u0027mac_address\u0027: obj_fields.StringField(),"},{"line_number":38,"context_line":"        \u0027ip_address\u0027: obj_fields.StringField(),"},{"line_number":39,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_a65bcb53","line":36,"in_reply_to":"dae33548_ecb0178e","updated":"2016-02-15 14:19:11.000000000","message":"The patch is WIP:  https://review.openstack.org/#/c/277558/\nFirst reviews are suggesting moving it to oslo db.","commit_id":"26d3390c8ce0507989ffba6fa1ea8b6cb3bcf246"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9b24c9f84bf2ce35e856b29bdc42cc17741140f0","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        #TODO(mhickey) Update when patch"},{"line_number":36,"context_line":"        # https://review.openstack.org/#/c/277558/ available"},{"line_number":37,"context_line":"        \u0027mac_address\u0027: obj_fields.StringField(),"},{"line_number":38,"context_line":"        \u0027ip_address\u0027: obj_fields.StringField(),"},{"line_number":39,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":11,"id":"9aed3d3a_242bce95","line":38,"range":{"start_line":38,"start_character":9,"end_line":38,"end_character":19},"updated":"2016-02-29 11:10:20.000000000","message":"How about rebasing on https://review.openstack.org/#/c/285349/ that should give you access to IP Address field?","commit_id":"569d13879ee467b57cd3c5d4afc504c26712d7a9"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"bf85f720ae484f9c5632e50fafcbcfb8df64f8e9","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        #TODO(mhickey) Update when patch"},{"line_number":36,"context_line":"        # https://review.openstack.org/#/c/277558/ available"},{"line_number":37,"context_line":"        \u0027mac_address\u0027: obj_fields.StringField(),"},{"line_number":38,"context_line":"        \u0027ip_address\u0027: obj_fields.StringField(),"},{"line_number":39,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":11,"id":"7af24918_f47a0e87","line":38,"range":{"start_line":38,"start_character":9,"end_line":38,"end_character":19},"in_reply_to":"9aed3d3a_242bce95","updated":"2016-03-03 18:13:38.000000000","message":"Would I not wait until it gets merged?","commit_id":"569d13879ee467b57cd3c5d4afc504c26712d7a9"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"f7203f2dffa399eafe2ea5499661d58a4a4dc8c2","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    primary_keys \u003d [\u0027port_id\u0027, \u0027mac_address\u0027, \u0027ip_address\u0027]"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    fields_no_update \u003d [\u0027port_id\u0027]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    fields \u003d {"},{"line_number":32,"context_line":"        \u0027port_id\u0027: obj_fields.UUIDField(),"}],"source_content_type":"text/x-python","patch_set":21,"id":"5aef4532_96249d60","line":29,"updated":"2016-03-09 11:27:05.000000000","message":"I wonder, if you change mac_address or ip_address, would you be able to update the object? From my tests, the OVO would not be able to search for old entry in DB because of changing the primary key argument... \nThe thing I\u0027m talking about - primary_keys cannot be updated at all... Any thoughts on that?","commit_id":"c4260cf93ab854bda2d5d65ff5361e3819e0c458"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"e9bd9ef8c040c60b9247a112de5fc68377a13c1d","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    primary_keys \u003d [\u0027port_id\u0027, \u0027mac_address\u0027, \u0027ip_address\u0027]"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    fields_no_update \u003d [\u0027port_id\u0027]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    fields \u003d {"},{"line_number":32,"context_line":"        \u0027port_id\u0027: obj_fields.UUIDField(),"}],"source_content_type":"text/x-python","patch_set":21,"id":"3afc51ec_89559efb","line":29,"in_reply_to":"5aef4532_96249d60","updated":"2016-03-15 10:36:29.000000000","message":"Sure, agreed. Added them as fields_no_update.","commit_id":"c4260cf93ab854bda2d5d65ff5361e3819e0c458"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"010fae9d8313ef2d5cf88bbbfa4df9720316fd21","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    fields \u003d {"},{"line_number":32,"context_line":"        \u0027port_id\u0027: obj_fields.UUIDField(),"},{"line_number":33,"context_line":"        #TODO(mhickey) Update when patch"},{"line_number":34,"context_line":"        # https://review.openstack.org/#/c/285349/ available"},{"line_number":35,"context_line":"        \u0027mac_address\u0027: obj_fields.StringField(),"},{"line_number":36,"context_line":"        #TODO(mhickey) Update when patch"},{"line_number":37,"context_line":"        # https://review.openstack.org/#/c/277558/ available"}],"source_content_type":"text/x-python","patch_set":23,"id":"3afc51ec_0cc7dc64","line":34,"updated":"2016-03-15 11:01:27.000000000","message":"After merging the modify_fields_from/to_db, you should change the type to MACAddressField() and implement smth like this:\ndef modify_fields_to_db(cls, fields):\n        result \u003d fields.copy()\n        if \u0027mac_address\u0027 in result:\n            result[\u0027mac_address\u0027] \u003d str(result[\u0027mac_address\u0027])\n        if \u0027ip_address\u0027 in fields:\n            result[\u0027ip_address\u0027] \u003d str(result[\u0027ip_address\u0027])\n        return result\n\nand:\n\ndef modify_fields_from_db(cls, db_obj):\n        result \u003d dict(db_obj)\n        LOG.error(result)\n        if \u0027mac_address\u0027 in result:\n            result[\u0027mac_address\u0027] \u003d netaddr.MACAddress(result[\u0027mac_address\u0027])\n        if \u0027ip_address\u0027 in result:\n            result[\u0027ip_address\u0027] \u003d netaddr.IPAddress(result[\u0027ip_address\u0027])\n        return result","commit_id":"86eed52a81ebb51b73fcc4e0956f75658331d9c9"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"11f8f9f0bde3ac9e1a05bd42adde95dfaf268292","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    fields \u003d {"},{"line_number":32,"context_line":"        \u0027port_id\u0027: obj_fields.UUIDField(),"},{"line_number":33,"context_line":"        #TODO(mhickey) Update when patch"},{"line_number":34,"context_line":"        # https://review.openstack.org/#/c/285349/ available"},{"line_number":35,"context_line":"        \u0027mac_address\u0027: obj_fields.StringField(),"},{"line_number":36,"context_line":"        #TODO(mhickey) Update when patch"},{"line_number":37,"context_line":"        # https://review.openstack.org/#/c/277558/ available"}],"source_content_type":"text/x-python","patch_set":23,"id":"1af94dfe_c41b3d7f","line":34,"in_reply_to":"3afc51ec_0cc7dc64","updated":"2016-03-16 17:39:02.000000000","message":"Ok, thanks for the code. Updated.","commit_id":"86eed52a81ebb51b73fcc4e0956f75658331d9c9"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"680ed29e2090acb084140197a810a01d6fd830c2","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    fields \u003d {"},{"line_number":32,"context_line":"        \u0027port_id\u0027: obj_fields.UUIDField(),"},{"line_number":33,"context_line":"        #TODO(mhickey) Update when patch"},{"line_number":34,"context_line":"        # https://review.openstack.org/#/c/285349/ available"},{"line_number":35,"context_line":"        \u0027mac_address\u0027: obj_fields.StringField(),"},{"line_number":36,"context_line":"        #TODO(mhickey) Update when patch"},{"line_number":37,"context_line":"        # https://review.openstack.org/#/c/277558/ available"}],"source_content_type":"text/x-python","patch_set":25,"id":"1af94dfe_b695c741","line":34,"updated":"2016-03-15 17:15:01.000000000","message":"I think it\u0027s a bad excuse now since we can handle it inside modify_*","commit_id":"d0783cf465037f424158dce87de61c1366089977"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"31b972d24b6f8272e0c64e434b10776d2ecb2697","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    fields \u003d {"},{"line_number":32,"context_line":"        \u0027port_id\u0027: obj_fields.UUIDField(),"},{"line_number":33,"context_line":"        #TODO(mhickey) Update when patch"},{"line_number":34,"context_line":"        # https://review.openstack.org/#/c/285349/ available"},{"line_number":35,"context_line":"        \u0027mac_address\u0027: obj_fields.StringField(),"},{"line_number":36,"context_line":"        #TODO(mhickey) Update when patch"},{"line_number":37,"context_line":"        # https://review.openstack.org/#/c/277558/ available"}],"source_content_type":"text/x-python","patch_set":25,"id":"1af94dfe_27582332","line":34,"in_reply_to":"1af94dfe_b695c741","updated":"2016-03-16 17:40:15.000000000","message":"Sure, updated.","commit_id":"d0783cf465037f424158dce87de61c1366089977"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"680ed29e2090acb084140197a810a01d6fd830c2","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        # https://review.openstack.org/#/c/285349/ available"},{"line_number":35,"context_line":"        \u0027mac_address\u0027: obj_fields.StringField(),"},{"line_number":36,"context_line":"        #TODO(mhickey) Update when patch"},{"line_number":37,"context_line":"        # https://review.openstack.org/#/c/277558/ available"},{"line_number":38,"context_line":"        \u0027ip_address\u0027: obj_fields.StringField(),"},{"line_number":39,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":25,"id":"1af94dfe_36889722","line":37,"updated":"2016-03-15 17:15:01.000000000","message":"ditto","commit_id":"d0783cf465037f424158dce87de61c1366089977"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"31b972d24b6f8272e0c64e434b10776d2ecb2697","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        # https://review.openstack.org/#/c/285349/ available"},{"line_number":35,"context_line":"        \u0027mac_address\u0027: obj_fields.StringField(),"},{"line_number":36,"context_line":"        #TODO(mhickey) Update when patch"},{"line_number":37,"context_line":"        # https://review.openstack.org/#/c/277558/ available"},{"line_number":38,"context_line":"        \u0027ip_address\u0027: obj_fields.StringField(),"},{"line_number":39,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":25,"id":"1af94dfe_a74c3371","line":37,"in_reply_to":"1af94dfe_36889722","updated":"2016-03-16 17:40:15.000000000","message":"Updated.","commit_id":"d0783cf465037f424158dce87de61c1366089977"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"4595cb1e95871b693d5e335a619339a56c544433","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        \u0027port_id\u0027: obj_fields.UUIDField(),"},{"line_number":35,"context_line":"        # Update with MAC address field patch when merged:"},{"line_number":36,"context_line":"        # https://review.openstack.org/#/c/293479/"},{"line_number":37,"context_line":"        \u0027mac_address\u0027: obj_fields.StringField(),"},{"line_number":38,"context_line":"        \u0027ip_address\u0027: obj_fields.IPAddressField(),"},{"line_number":39,"context_line":"    }"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"fa0719c6_fc873310","line":37,"updated":"2016-03-21 10:09:49.000000000","message":"Is there any problem using the MACField for mac_address? I\u0027m seeing the update to ip_address, but no changes for MAC...","commit_id":"671f52e8d7d150525603aa6a3ea6d14d2130651e"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"1a2a5e1e40bd2b877909c4cf248d524a29b00426","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        \u0027port_id\u0027: obj_fields.UUIDField(),"},{"line_number":35,"context_line":"        # Update with MAC address field patch when merged:"},{"line_number":36,"context_line":"        # https://review.openstack.org/#/c/293479/"},{"line_number":37,"context_line":"        \u0027mac_address\u0027: obj_fields.StringField(),"},{"line_number":38,"context_line":"        \u0027ip_address\u0027: obj_fields.IPAddressField(),"},{"line_number":39,"context_line":"    }"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"ba0121b8_c0e1999c","line":37,"in_reply_to":"fa0719c6_fc873310","updated":"2016-04-03 18:23:14.000000000","message":"Sure, updated.","commit_id":"671f52e8d7d150525603aa6a3ea6d14d2130651e"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"b121e0e4725d1162c3e147e1e1adb58d45d16938","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    primary_keys \u003d [\u0027port_id\u0027, \u0027mac_address\u0027, \u0027ip_address\u0027]"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    fields_no_update \u003d [\u0027port_id\u0027, \u0027mac_address\u0027, \u0027ip_address\u0027]"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    fields \u003d {"},{"line_number":35,"context_line":"        \u0027port_id\u0027: obj_fields.UUIDField(),"}],"source_content_type":"text/x-python","patch_set":31,"id":"9a061dce_c6626c16","line":32,"updated":"2016-04-04 09:44:51.000000000","message":"No need for this line, since primary keys are forbidden to update in other patch.","commit_id":"ba0fc8666b1a6bad450e4886b5de765a507c409d"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"fcd3919bc0a2e7b8daf1c4c8d7bbde13306568a7","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    primary_keys \u003d [\u0027port_id\u0027, \u0027mac_address\u0027, \u0027ip_address\u0027]"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    fields_no_update \u003d [\u0027port_id\u0027, \u0027mac_address\u0027, \u0027ip_address\u0027]"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    fields \u003d {"},{"line_number":35,"context_line":"        \u0027port_id\u0027: obj_fields.UUIDField(),"}],"source_content_type":"text/x-python","patch_set":31,"id":"9a061dce_e5e0f8fc","line":32,"in_reply_to":"9a061dce_c6626c16","updated":"2016-04-05 14:32:04.000000000","message":"Done","commit_id":"ba0fc8666b1a6bad450e4886b5de765a507c409d"}],"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"04580428c9d112166e1b6fb395519a54b3345a91","unresolved":false,"context_lines":[{"line_number":1159,"context_line":"            # not a request for deleting the address-pairs"},{"line_number":1160,"context_line":"            pairs \u003d self.get_allowed_address_pairs(context, id)"},{"line_number":1161,"context_line":"            updated_port[addr_pair.ADDRESS_PAIRS] \u003d ["},{"line_number":1162,"context_line":"                    self.make_allowed_address_pairs_dict(pair) for pair in"},{"line_number":1163,"context_line":"                    pairs]"},{"line_number":1164,"context_line":""},{"line_number":1165,"context_line":"            # check if address pairs has been in db, if address pairs could"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_4c4f8392","line":1162,"updated":"2016-02-15 13:24:45.000000000","message":"I presume it\u0027s better to leave the conversion to dict to where it belongs now (the db mixin).","commit_id":"26d3390c8ce0507989ffba6fa1ea8b6cb3bcf246"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"af44ec46a30be2926514fe9d9a1bbd1fb6f325fd","unresolved":false,"context_lines":[{"line_number":1159,"context_line":"            # not a request for deleting the address-pairs"},{"line_number":1160,"context_line":"            pairs \u003d self.get_allowed_address_pairs(context, id)"},{"line_number":1161,"context_line":"            updated_port[addr_pair.ADDRESS_PAIRS] \u003d ["},{"line_number":1162,"context_line":"                    self.make_allowed_address_pairs_dict(pair) for pair in"},{"line_number":1163,"context_line":"                    pairs]"},{"line_number":1164,"context_line":""},{"line_number":1165,"context_line":"            # check if address pairs has been in db, if address pairs could"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_5ef40d85","line":1162,"in_reply_to":"dae33548_4c4f8392","updated":"2016-02-16 17:04:09.000000000","message":"Sure. Change rolled back.","commit_id":"26d3390c8ce0507989ffba6fa1ea8b6cb3bcf246"}],"neutron/tests/tools.py":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"ffeeb25cdf8293a11752c4e70678dc175883449b","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        self.addCleanup(cleanUp)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"import unittest"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"def setup_mock_calls(mocked_call, expected_calls_and_values):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a5de9d1_aa75eb32","line":113,"updated":"2016-02-02 17:46:58.000000000","message":"I wonder why is this here? It can be moved with the other imports I think","commit_id":"87133444c1d741e606d5d1f8cf08a0c6d65db1de"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"5acaef36372e4573d739b3876207e951d9f90b7a","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        self.addCleanup(cleanUp)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"import unittest"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"def setup_mock_calls(mocked_call, expected_calls_and_values):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a57f1b5_bf5152da","line":113,"in_reply_to":"5a5ae5dd_4b284b33","updated":"2016-02-11 15:17:51.000000000","message":"Agreed but updated.","commit_id":"87133444c1d741e606d5d1f8cf08a0c6d65db1de"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"2f3edc6c1e69e345c8f957c1bff4f348b694cefa","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        self.addCleanup(cleanUp)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"import unittest"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"def setup_mock_calls(mocked_call, expected_calls_and_values):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a5ae5dd_4b284b33","line":113,"in_reply_to":"7a5de9d1_aa75eb32","updated":"2016-02-08 06:14:47.000000000","message":"+1\n\nnot a fault of this patch though.","commit_id":"87133444c1d741e606d5d1f8cf08a0c6d65db1de"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"5acaef36372e4573d739b3876207e951d9f90b7a","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        self.addCleanup(cleanUp)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"import unittest"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"def setup_mock_calls(mocked_call, expected_calls_and_values):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a57f1b5_7f3bda9c","line":113,"in_reply_to":"7a5de9d1_aa75eb32","updated":"2016-02-11 15:17:51.000000000","message":"Sure, done.","commit_id":"87133444c1d741e606d5d1f8cf08a0c6d65db1de"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"04580428c9d112166e1b6fb395519a54b3345a91","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        self.addCleanup(cleanUp)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"def setup_mock_calls(mocked_call, expected_calls_and_values):"},{"line_number":115,"context_line":"    \"\"\"setup_mock_calls is a convenient method to setup a sequence of mock"},{"line_number":116,"context_line":"    calls."},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_77e9741a","line":114,"updated":"2016-02-15 13:24:45.000000000","message":"While I agree that\u0027s a correct change for docstring, it does not really belong to the patch. Please propose it separately.","commit_id":"26d3390c8ce0507989ffba6fa1ea8b6cb3bcf246"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"7abb94da4c7a529aadc64744b88b09933f899d5f","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        self.addCleanup(cleanUp)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"def setup_mock_calls(mocked_call, expected_calls_and_values):"},{"line_number":115,"context_line":"    \"\"\"setup_mock_calls is a convenient method to setup a sequence of mock"},{"line_number":116,"context_line":"    calls."},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_5c56955c","line":114,"in_reply_to":"dae33548_2a561f5c","updated":"2016-02-17 15:25:11.000000000","message":"Docstring patch: https://review.openstack.org/#/c/281183/","commit_id":"26d3390c8ce0507989ffba6fa1ea8b6cb3bcf246"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"af44ec46a30be2926514fe9d9a1bbd1fb6f325fd","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        self.addCleanup(cleanUp)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"def setup_mock_calls(mocked_call, expected_calls_and_values):"},{"line_number":115,"context_line":"    \"\"\"setup_mock_calls is a convenient method to setup a sequence of mock"},{"line_number":116,"context_line":"    calls."},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_2a561f5c","line":114,"in_reply_to":"dae33548_77e9741a","updated":"2016-02-16 17:04:09.000000000","message":"Ok. I will remove the change for now and create a separate patch. I will add patch URL when available.","commit_id":"26d3390c8ce0507989ffba6fa1ea8b6cb3bcf246"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"04580428c9d112166e1b6fb395519a54b3345a91","unresolved":false,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"def get_random_ip():"},{"line_number":198,"context_line":"    return \u002710.%d.%d.%d\u0027 % ("},{"line_number":199,"context_line":"                         random.randint(3, 254),"},{"line_number":200,"context_line":"                         random.randint(3, 254),"},{"line_number":201,"context_line":"                         random.randint(3, 254))"},{"line_number":202,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_975d18ec","line":199,"updated":"2016-02-15 13:24:45.000000000","message":"Why do we skip some values? Like 1 or 2?","commit_id":"26d3390c8ce0507989ffba6fa1ea8b6cb3bcf246"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"af44ec46a30be2926514fe9d9a1bbd1fb6f325fd","unresolved":false,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"def get_random_ip():"},{"line_number":198,"context_line":"    return \u002710.%d.%d.%d\u0027 % ("},{"line_number":199,"context_line":"                         random.randint(3, 254),"},{"line_number":200,"context_line":"                         random.randint(3, 254),"},{"line_number":201,"context_line":"                         random.randint(3, 254))"},{"line_number":202,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_8aa5abb6","line":199,"in_reply_to":"dae33548_975d18ec","updated":"2016-02-16 17:04:09.000000000","message":"Not sure. @Rossella: any idea?","commit_id":"26d3390c8ce0507989ffba6fa1ea8b6cb3bcf246"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9b24c9f84bf2ce35e856b29bdc42cc17741140f0","unresolved":false,"context_lines":[{"line_number":129,"context_line":"  A return value or an exception can be specified."},{"line_number":130,"context_line":"\"\"\""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"import unittest"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"from neutron.common import utils"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9aed3d3a_64c316ee","side":"PARENT","line":132,"updated":"2016-02-29 11:10:20.000000000","message":"However I like the move, it\u0027s probably unrelated to the change. Same comment for renaming utils into common_utils.\n\nThe reason why we are so picky about unrelated changes is because every random line changed increases chance for a git conflict for other patches.","commit_id":"a9db5b6f3f7f1507788725669a67b43f0197c077"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"620e9721dd2dbad4b2906c5cd5f048c9c8f85c33","unresolved":false,"context_lines":[{"line_number":129,"context_line":"  A return value or an exception can be specified."},{"line_number":130,"context_line":"\"\"\""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"import unittest"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"from neutron.common import utils"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"7af24918_a31e916d","side":"PARENT","line":132,"in_reply_to":"9aed3d3a_64c316ee","updated":"2016-03-03 14:53:47.000000000","message":"I can rollback the unitest as is. However, the \"from neutron.common import utils\" is now deprecated by \"from neutron.common import utils as common_utils\". Done.","commit_id":"a9db5b6f3f7f1507788725669a67b43f0197c077"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"45d9af0084a73cb3868cb5a2483bbc0ad8bfdb8b","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import platform"},{"line_number":17,"context_line":"import random"},{"line_number":18,"context_line":"import string"},{"line_number":19,"context_line":"import unittest"},{"line_number":20,"context_line":"import warnings"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import fixtures"}],"source_content_type":"text/x-python","patch_set":11,"id":"bae84128_2c298ae6","line":19,"updated":"2016-02-24 17:02:14.000000000","message":"We should be using unittest2. Can you try that and see if anything breaks?","commit_id":"569d13879ee467b57cd3c5d4afc504c26712d7a9"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5ccfbe1e64775abdbaf979c28a34ae084e1dcfe1","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import platform"},{"line_number":17,"context_line":"import random"},{"line_number":18,"context_line":"import string"},{"line_number":19,"context_line":"import unittest"},{"line_number":20,"context_line":"import warnings"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import fixtures"}],"source_content_type":"text/x-python","patch_set":11,"id":"7af24918_a9794fca","line":19,"in_reply_to":"7af24918_c3de3d10","updated":"2016-03-03 14:57:05.000000000","message":"You don\u0027t need to touch the import in this patch, so omit the change and keep it for another one that you have.","commit_id":"569d13879ee467b57cd3c5d4afc504c26712d7a9"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"620e9721dd2dbad4b2906c5cd5f048c9c8f85c33","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import platform"},{"line_number":17,"context_line":"import random"},{"line_number":18,"context_line":"import string"},{"line_number":19,"context_line":"import unittest"},{"line_number":20,"context_line":"import warnings"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import fixtures"}],"source_content_type":"text/x-python","patch_set":11,"id":"7af24918_c3de3d10","line":19,"in_reply_to":"9aed3d3a_a4a23e49","updated":"2016-03-03 14:53:47.000000000","message":"Are you saying you want it changed in this patch or is it ok it will be changed in the referenced patch above? The other patch will probably be delivered before this patch.","commit_id":"569d13879ee467b57cd3c5d4afc504c26712d7a9"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"4287f09de2c9b4c584866fec51df0530a8ff13c8","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import platform"},{"line_number":17,"context_line":"import random"},{"line_number":18,"context_line":"import string"},{"line_number":19,"context_line":"import unittest"},{"line_number":20,"context_line":"import warnings"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import fixtures"}],"source_content_type":"text/x-python","patch_set":11,"id":"bae84128_e72971f4","line":19,"in_reply_to":"bae84128_2c298ae6","updated":"2016-02-24 19:49:03.000000000","message":"Thanks for the \"heads up\" Henry. Modified in patch: https://review.openstack.org/#/c/284376/","commit_id":"569d13879ee467b57cd3c5d4afc504c26712d7a9"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9b24c9f84bf2ce35e856b29bdc42cc17741140f0","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import platform"},{"line_number":17,"context_line":"import random"},{"line_number":18,"context_line":"import string"},{"line_number":19,"context_line":"import unittest"},{"line_number":20,"context_line":"import warnings"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import fixtures"}],"source_content_type":"text/x-python","patch_set":11,"id":"9aed3d3a_a4a23e49","line":19,"in_reply_to":"bae84128_e72971f4","updated":"2016-02-29 11:10:20.000000000","message":"Right. But you should also rely on the proper module in your new code, so the update of this patch is still justified.\n\nNote that unittest2 is 3party module, so should be moved to line 25.","commit_id":"569d13879ee467b57cd3c5d4afc504c26712d7a9"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9b24c9f84bf2ce35e856b29bdc42cc17741140f0","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    return random.randint(range_begin, range_end)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"def get_random_ip():"},{"line_number":181,"context_line":"    return \u002710.%d.%d.%d\u0027 % ("},{"line_number":182,"context_line":"                         random.randint(3, 254),"},{"line_number":183,"context_line":"                         random.randint(3, 254),"}],"source_content_type":"text/x-python","patch_set":11,"id":"9aed3d3a_e740c836","line":180,"updated":"2016-02-29 11:10:20.000000000","message":"Could probably be changed to access version\u003d argument and return IPv6 addresses too, if requested.","commit_id":"569d13879ee467b57cd3c5d4afc504c26712d7a9"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"620e9721dd2dbad4b2906c5cd5f048c9c8f85c33","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    return random.randint(range_begin, range_end)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"def get_random_ip():"},{"line_number":181,"context_line":"    return \u002710.%d.%d.%d\u0027 % ("},{"line_number":182,"context_line":"                         random.randint(3, 254),"},{"line_number":183,"context_line":"                         random.randint(3, 254),"}],"source_content_type":"text/x-python","patch_set":11,"id":"7af24918_60dbdc4f","line":180,"in_reply_to":"9aed3d3a_e740c836","updated":"2016-03-03 14:53:47.000000000","message":"Added.","commit_id":"569d13879ee467b57cd3c5d4afc504c26712d7a9"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"384cfe737742d02817fbf8aa4cc15ac93161161d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import importlib"},{"line_number":17,"context_line":"import netaddr"},{"line_number":18,"context_line":"import os"},{"line_number":19,"context_line":"import platform"},{"line_number":20,"context_line":"import random"}],"source_content_type":"text/x-python","patch_set":34,"id":"7a1b2928_c32240b9","line":17,"updated":"2016-04-11 14:35:11.000000000","message":"why the move? netaddr is 3party.","commit_id":"003eb6af9be1f139ddbbeb2d0bea77f7f18a1671"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"9afb6d0b96a80467ac5c5a7acea9b24d4c177e3f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import importlib"},{"line_number":17,"context_line":"import netaddr"},{"line_number":18,"context_line":"import os"},{"line_number":19,"context_line":"import platform"},{"line_number":20,"context_line":"import random"}],"source_content_type":"text/x-python","patch_set":34,"id":"5a18252c_e03499df","line":17,"in_reply_to":"7a1b2928_c32240b9","updated":"2016-04-12 12:32:13.000000000","message":"no idea, it must be some rebase fix that I did without noticing. Thanks","commit_id":"003eb6af9be1f139ddbbeb2d0bea77f7f18a1671"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"384cfe737742d02817fbf8aa4cc15ac93161161d","unresolved":false,"context_lines":[{"line_number":269,"context_line":"    return netaddr.IPNetwork(get_random_cidr(version\u003dversion))"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"def get_random_ip_address(version\u003d\u0027ipv4\u0027):"},{"line_number":273,"context_line":"    return netaddr.IPAddress(get_random_ip(version\u003dversion))"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"7a1b2928_c37400d1","line":272,"range":{"start_line":272,"start_character":34,"end_line":272,"end_character":40},"updated":"2016-04-11 14:35:11.000000000","message":"please define version with integers, as in line 268.","commit_id":"003eb6af9be1f139ddbbeb2d0bea77f7f18a1671"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"9afb6d0b96a80467ac5c5a7acea9b24d4c177e3f","unresolved":false,"context_lines":[{"line_number":269,"context_line":"    return netaddr.IPNetwork(get_random_cidr(version\u003dversion))"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"def get_random_ip_address(version\u003d\u0027ipv4\u0027):"},{"line_number":273,"context_line":"    return netaddr.IPAddress(get_random_ip(version\u003dversion))"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"5a18252c_1b74a89a","line":272,"range":{"start_line":272,"start_character":34,"end_line":272,"end_character":40},"in_reply_to":"7a1b2928_c37400d1","updated":"2016-04-12 12:32:13.000000000","message":"Done","commit_id":"003eb6af9be1f139ddbbeb2d0bea77f7f18a1671"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"384cfe737742d02817fbf8aa4cc15ac93161161d","unresolved":false,"context_lines":[{"line_number":273,"context_line":"    return netaddr.IPAddress(get_random_ip(version\u003dversion))"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"def get_random_ip(version\u003d\u0027ipv4\u0027):"},{"line_number":277,"context_line":"    if version \u003d\u003d \u0027ipv4\u0027:"},{"line_number":278,"context_line":"        return \u002710.%d.%d.%d\u0027 % (random.randint(3, 254),"},{"line_number":279,"context_line":"                                random.randint(3, 254),"}],"source_content_type":"text/x-python","patch_set":34,"id":"7a1b2928_4368f0f5","line":276,"range":{"start_line":276,"start_character":4,"end_line":276,"end_character":17},"updated":"2016-04-11 14:35:11.000000000","message":"should probably be get_random_ip_string","commit_id":"003eb6af9be1f139ddbbeb2d0bea77f7f18a1671"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"9afb6d0b96a80467ac5c5a7acea9b24d4c177e3f","unresolved":false,"context_lines":[{"line_number":273,"context_line":"    return netaddr.IPAddress(get_random_ip(version\u003dversion))"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"def get_random_ip(version\u003d\u0027ipv4\u0027):"},{"line_number":277,"context_line":"    if version \u003d\u003d \u0027ipv4\u0027:"},{"line_number":278,"context_line":"        return \u002710.%d.%d.%d\u0027 % (random.randint(3, 254),"},{"line_number":279,"context_line":"                                random.randint(3, 254),"}],"source_content_type":"text/x-python","patch_set":34,"id":"5a18252c_80ade533","line":276,"range":{"start_line":276,"start_character":4,"end_line":276,"end_character":17},"in_reply_to":"7a1b2928_4368f0f5","updated":"2016-04-12 12:32:13.000000000","message":"actually line 283 doesn\u0027t return a string, let me modify this method","commit_id":"003eb6af9be1f139ddbbeb2d0bea77f7f18a1671"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"384cfe737742d02817fbf8aa4cc15ac93161161d","unresolved":false,"context_lines":[{"line_number":279,"context_line":"                                random.randint(3, 254),"},{"line_number":280,"context_line":"                                random.randint(3, 254))"},{"line_number":281,"context_line":"    else:"},{"line_number":282,"context_line":"        random.seed()"},{"line_number":283,"context_line":"        ip \u003d ipv6_utils.get_ipv6_addr_by_EUI64(\u00272001:db8::/64\u0027,"},{"line_number":284,"context_line":"                                               get_random_mac()).format()"},{"line_number":285,"context_line":"        return ip"}],"source_content_type":"text/x-python","patch_set":34,"id":"7a1b2928_03fa7842","line":282,"updated":"2016-04-11 14:35:11.000000000","message":"Why do we need to reseed here?","commit_id":"003eb6af9be1f139ddbbeb2d0bea77f7f18a1671"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"9afb6d0b96a80467ac5c5a7acea9b24d4c177e3f","unresolved":false,"context_lines":[{"line_number":279,"context_line":"                                random.randint(3, 254),"},{"line_number":280,"context_line":"                                random.randint(3, 254))"},{"line_number":281,"context_line":"    else:"},{"line_number":282,"context_line":"        random.seed()"},{"line_number":283,"context_line":"        ip \u003d ipv6_utils.get_ipv6_addr_by_EUI64(\u00272001:db8::/64\u0027,"},{"line_number":284,"context_line":"                                               get_random_mac()).format()"},{"line_number":285,"context_line":"        return ip"}],"source_content_type":"text/x-python","patch_set":34,"id":"5a18252c_c0907def","line":282,"in_reply_to":"7a1b2928_03fa7842","updated":"2016-04-12 12:32:13.000000000","message":"no idea","commit_id":"003eb6af9be1f139ddbbeb2d0bea77f7f18a1671"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9fe13cd8e2936ba927eecb8116e44086355eb952","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        return \u002710.%d.%d.0/%d\u0027 % (random.randint(3, 254),"},{"line_number":250,"context_line":"                                  random.randint(3, 254),"},{"line_number":251,"context_line":"                                  24)"},{"line_number":252,"context_line":"    return \u00272001:db8:%x::/\u0026d\u0027 % (random.getrandbits(16), 64)"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"def get_random_mac():"}],"source_content_type":"text/x-python","patch_set":35,"id":"1a122d0e_a12f55a0","line":252,"range":{"start_line":252,"start_character":26,"end_line":252,"end_character":27},"updated":"2016-04-15 14:41:06.000000000","message":"and btw we have a bug here too. :)","commit_id":"246bdae75a2ddc41fe8607e1698741f8280a2254"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"986d7d211ca583118284635e7e6efb0efb48153a","unresolved":false,"context_lines":[{"line_number":270,"context_line":""},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"def get_random_ip_address(version\u003d4):"},{"line_number":273,"context_line":"    if version \u003d\u003d \u00274\u0027:"},{"line_number":274,"context_line":"        ip_string \u003d \u002710.%d.%d.%d\u0027 % (random.randint(3, 254),"},{"line_number":275,"context_line":"                                     random.randint(3, 254),"},{"line_number":276,"context_line":"                                     random.randint(3, 254))"}],"source_content_type":"text/x-python","patch_set":35,"id":"1a122d0e_c664274b","line":273,"range":{"start_line":273,"start_character":18,"end_line":273,"end_character":21},"updated":"2016-04-15 14:23:09.000000000","message":"ok, that\u0027s a bug. it should have been an integer.","commit_id":"246bdae75a2ddc41fe8607e1698741f8280a2254"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"05c85377de3d7f4c184965b23b959d3d2fff6f5c","unresolved":false,"context_lines":[{"line_number":270,"context_line":""},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"def get_random_ip_address(version\u003d4):"},{"line_number":273,"context_line":"    if version \u003d\u003d \u00274\u0027:"},{"line_number":274,"context_line":"        ip_string \u003d \u002710.%d.%d.%d\u0027 % (random.randint(3, 254),"},{"line_number":275,"context_line":"                                     random.randint(3, 254),"},{"line_number":276,"context_line":"                                     random.randint(3, 254))"}],"source_content_type":"text/x-python","patch_set":35,"id":"1a122d0e_a548005d","line":273,"range":{"start_line":273,"start_character":18,"end_line":273,"end_character":21},"in_reply_to":"1a122d0e_c664274b","updated":"2016-04-15 14:50:25.000000000","message":"Done","commit_id":"246bdae75a2ddc41fe8607e1698741f8280a2254"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"97be5d5b6cf3ce11d9ff0c1b8e84902613198adb","unresolved":false,"context_lines":[{"line_number":277,"context_line":"        return netaddr.IPAddress(ip_string)"},{"line_number":278,"context_line":"    else:"},{"line_number":279,"context_line":"        ip \u003d ipv6_utils.get_ipv6_addr_by_EUI64(\u00272001:db8::/64\u0027,"},{"line_number":280,"context_line":"                                               get_random_mac()).format()"},{"line_number":281,"context_line":"        return ip"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":""}],"source_content_type":"text/x-python","patch_set":35,"id":"1a122d0e_e1494d90","line":280,"range":{"start_line":280,"start_character":64,"end_line":280,"end_character":73},"updated":"2016-04-15 14:39:59.000000000","message":"also, format() should not be applied here. The function is supposed to return IPAddress.","commit_id":"246bdae75a2ddc41fe8607e1698741f8280a2254"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"05c85377de3d7f4c184965b23b959d3d2fff6f5c","unresolved":false,"context_lines":[{"line_number":277,"context_line":"        return netaddr.IPAddress(ip_string)"},{"line_number":278,"context_line":"    else:"},{"line_number":279,"context_line":"        ip \u003d ipv6_utils.get_ipv6_addr_by_EUI64(\u00272001:db8::/64\u0027,"},{"line_number":280,"context_line":"                                               get_random_mac()).format()"},{"line_number":281,"context_line":"        return ip"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":""}],"source_content_type":"text/x-python","patch_set":35,"id":"1a122d0e_456e4cca","line":280,"range":{"start_line":280,"start_character":64,"end_line":280,"end_character":73},"in_reply_to":"1a122d0e_e1494d90","updated":"2016-04-15 14:50:25.000000000","message":"Done","commit_id":"246bdae75a2ddc41fe8607e1698741f8280a2254"}],"neutron/tests/unit/objects/port/extensions/test_allowedaddresspairs.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9b24c9f84bf2ce35e856b29bdc42cc17741140f0","unresolved":false,"context_lines":[{"line_number":14,"context_line":"from neutron.tests.unit.objects import test_base as obj_test_base"},{"line_number":15,"context_line":"from neutron.tests.unit import testlib_api"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class AllowedAddressPairsDbObjectTestCase(obj_test_base.BaseDbObjectTestCase,"},{"line_number":19,"context_line":"                                          testlib_api.SqlTestCase):"},{"line_number":20,"context_line":"    _test_class \u003d allowedaddresspairs.AllowedAddressPair"}],"source_content_type":"text/x-python","patch_set":11,"id":"9aed3d3a_47e6d444","line":17,"updated":"2016-02-29 11:10:20.000000000","message":"Please also add a test class that inherits from test_base.BaseObjectIfaceTestCase","commit_id":"569d13879ee467b57cd3c5d4afc504c26712d7a9"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"bf85f720ae484f9c5632e50fafcbcfb8df64f8e9","unresolved":false,"context_lines":[{"line_number":14,"context_line":"from neutron.tests.unit.objects import test_base as obj_test_base"},{"line_number":15,"context_line":"from neutron.tests.unit import testlib_api"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class AllowedAddressPairsDbObjectTestCase(obj_test_base.BaseDbObjectTestCase,"},{"line_number":19,"context_line":"                                          testlib_api.SqlTestCase):"},{"line_number":20,"context_line":"    _test_class \u003d allowedaddresspairs.AllowedAddressPair"}],"source_content_type":"text/x-python","patch_set":11,"id":"7af24918_9460ea02","line":17,"in_reply_to":"9aed3d3a_47e6d444","updated":"2016-03-03 18:13:38.000000000","message":"Added.","commit_id":"569d13879ee467b57cd3c5d4afc504c26712d7a9"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"ac11069cb0d32381e90bcc216bae98890fb27309","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        self._create_test_port(self._network)"},{"line_number":37,"context_line":"        for obj in self.db_objs:"},{"line_number":38,"context_line":"            obj[\u0027port_id\u0027] \u003d self._port[\u0027id\u0027]"},{"line_number":39,"context_line":"            obj[\u0027mac_address\u0027] \u003d \u0027fake_mac\u0027"},{"line_number":40,"context_line":"            obj[\u0027ip_address\u0027] \u003d \u0027fake_ip\u0027"}],"source_content_type":"text/x-python","patch_set":21,"id":"5aef4532_760ab67a","line":39,"updated":"2016-03-09 10:21:01.000000000","message":"mac_address and ip_address should be set already by _BaseObjectTestCase.get_random_fields right?","commit_id":"c4260cf93ab854bda2d5d65ff5361e3819e0c458"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"e9bd9ef8c040c60b9247a112de5fc68377a13c1d","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        self._create_test_port(self._network)"},{"line_number":37,"context_line":"        for obj in self.db_objs:"},{"line_number":38,"context_line":"            obj[\u0027port_id\u0027] \u003d self._port[\u0027id\u0027]"},{"line_number":39,"context_line":"            obj[\u0027mac_address\u0027] \u003d \u0027fake_mac\u0027"},{"line_number":40,"context_line":"            obj[\u0027ip_address\u0027] \u003d \u0027fake_ip\u0027"}],"source_content_type":"text/x-python","patch_set":21,"id":"3afc51ec_297baa8d","line":39,"in_reply_to":"5aef4532_760ab67a","updated":"2016-03-15 10:36:29.000000000","message":"Sure, sorted out issue now and can remove the initialisation of these fields.","commit_id":"c4260cf93ab854bda2d5d65ff5361e3819e0c458"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"4595cb1e95871b693d5e335a619339a56c544433","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    _test_class \u003d allowedaddresspairs.AllowedAddressPair"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def setUp(self):"},{"line_number":24,"context_line":"        super(AllowedAddrPairsIfaceObjTestCase, self).setUp()"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class AllowedAddrPairsDbObjTestCase(obj_test_base.BaseDbObjectTestCase,"}],"source_content_type":"text/x-python","patch_set":28,"id":"fa0719c6_dce18fd2","line":24,"updated":"2016-03-21 10:09:49.000000000","message":"No need to implement setUp() method when only the base class is invoked.","commit_id":"671f52e8d7d150525603aa6a3ea6d14d2130651e"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"1a2a5e1e40bd2b877909c4cf248d524a29b00426","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    _test_class \u003d allowedaddresspairs.AllowedAddressPair"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def setUp(self):"},{"line_number":24,"context_line":"        super(AllowedAddrPairsIfaceObjTestCase, self).setUp()"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class AllowedAddrPairsDbObjTestCase(obj_test_base.BaseDbObjectTestCase,"}],"source_content_type":"text/x-python","patch_set":28,"id":"ba0121b8_609ecd08","line":24,"in_reply_to":"fa0719c6_dce18fd2","updated":"2016-04-03 18:23:14.000000000","message":"ok, removed","commit_id":"671f52e8d7d150525603aa6a3ea6d14d2130651e"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"4595cb1e95871b693d5e335a619339a56c544433","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        self.context \u003d context.get_admin_context()"},{"line_number":35,"context_line":"        self._create_test_network()"},{"line_number":36,"context_line":"        self._create_test_port(self._network)"},{"line_number":37,"context_line":"        for obj in self.db_objs:"},{"line_number":38,"context_line":"            obj[\u0027port_id\u0027] \u003d self._port[\u0027id\u0027]"},{"line_number":39,"context_line":"        for obj in self.obj_fields:"},{"line_number":40,"context_line":"            obj[\u0027port_id\u0027] \u003d self._port[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":28,"id":"fa0719c6_bc777b01","line":37,"updated":"2016-03-21 10:09:49.000000000","message":"Nit:\n\nfor obj in itertools.chain(self.db_objs, self.obj_fields):\n    obj[\u0027port_id\u0027] \u003d self._port.id","commit_id":"671f52e8d7d150525603aa6a3ea6d14d2130651e"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"1a2a5e1e40bd2b877909c4cf248d524a29b00426","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        self.context \u003d context.get_admin_context()"},{"line_number":35,"context_line":"        self._create_test_network()"},{"line_number":36,"context_line":"        self._create_test_port(self._network)"},{"line_number":37,"context_line":"        for obj in self.db_objs:"},{"line_number":38,"context_line":"            obj[\u0027port_id\u0027] \u003d self._port[\u0027id\u0027]"},{"line_number":39,"context_line":"        for obj in self.obj_fields:"},{"line_number":40,"context_line":"            obj[\u0027port_id\u0027] \u003d self._port[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":28,"id":"ba0121b8_e092ddf5","line":37,"in_reply_to":"fa0719c6_bc777b01","updated":"2016-04-03 18:23:14.000000000","message":"Makes sense to put together. Done.","commit_id":"671f52e8d7d150525603aa6a3ea6d14d2130651e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e8b8a3a3d9f9f3fd1cb2b0dbb749532c2ebd480c","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        for obj in self.db_objs:"},{"line_number":38,"context_line":"            obj[\u0027port_id\u0027] \u003d self._port[\u0027id\u0027]"},{"line_number":39,"context_line":"        for obj in self.obj_fields:"},{"line_number":40,"context_line":"            obj[\u0027port_id\u0027] \u003d self._port[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":28,"id":"fa0719c6_08dfec69","line":40,"updated":"2016-03-22 17:12:35.000000000","message":"nit: we start to introduce a lot of objects for extensions. all of them need a port. We could probably reduce some duplication by having a common base db test class specifically for port extensions.","commit_id":"671f52e8d7d150525603aa6a3ea6d14d2130651e"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"1a2a5e1e40bd2b877909c4cf248d524a29b00426","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        for obj in self.db_objs:"},{"line_number":38,"context_line":"            obj[\u0027port_id\u0027] \u003d self._port[\u0027id\u0027]"},{"line_number":39,"context_line":"        for obj in self.obj_fields:"},{"line_number":40,"context_line":"            obj[\u0027port_id\u0027] \u003d self._port[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":28,"id":"ba0121b8_a088e5c7","line":40,"in_reply_to":"fa0719c6_08dfec69","updated":"2016-04-03 18:23:14.000000000","message":"ok, possibly something to think about. I will add a TODO for the moment.","commit_id":"671f52e8d7d150525603aa6a3ea6d14d2130651e"}],"neutron/tests/unit/objects/test_base.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e8b8a3a3d9f9f3fd1cb2b0dbb749532c2ebd480c","unresolved":false,"context_lines":[{"line_number":481,"context_line":"        self.assertIs(expected_obj, observed_obj)"},{"line_number":482,"context_line":"        self.assertTrue(observed_obj.obj_reset_changes.called)"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"    def test_update_primary_key_forbidden_fail(self):"},{"line_number":485,"context_line":"        obj \u003d self._test_class(self.context, **self.db_obj)"},{"line_number":486,"context_line":"        obj.obj_reset_changes()"},{"line_number":487,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"fa0719c6_48f3a4d6","side":"PARENT","line":484,"updated":"2016-03-22 17:12:35.000000000","message":"why removed?","commit_id":"4c65e2ff1efd2f60a0812d7cbe56c267bb27b289"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"4595cb1e95871b693d5e335a619339a56c544433","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                                            nullable\u003dTrue)"},{"line_number":96,"context_line":"    }"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    fields_no_update \u003d [\u0027id\u0027]"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    synthetic_fields \u003d [\u0027obj_field\u0027]"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"fa0719c6_3cd1abce","line":98,"updated":"2016-03-21 10:09:49.000000000","message":"Why this change?","commit_id":"671f52e8d7d150525603aa6a3ea6d14d2130651e"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"1a2a5e1e40bd2b877909c4cf248d524a29b00426","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                                            nullable\u003dTrue)"},{"line_number":96,"context_line":"    }"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    fields_no_update \u003d [\u0027id\u0027]"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    synthetic_fields \u003d [\u0027obj_field\u0027]"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"ba0121b8_c07d19b3","line":98,"in_reply_to":"fa0719c6_3cd1abce","updated":"2016-04-03 18:23:14.000000000","message":"Not sure. Rolled back.","commit_id":"671f52e8d7d150525603aa6a3ea6d14d2130651e"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"4595cb1e95871b693d5e335a619339a56c544433","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    synthetic_fields \u003d [\u0027field2\u0027]"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    fields_no_update \u003d [\u0027id\u0027]"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    fields_need_translation \u003d {\u0027field_ovo\u0027: \u0027field_db\u0027}"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"fa0719c6_fced738f","line":165,"updated":"2016-03-21 10:09:49.000000000","message":"No need for this change.","commit_id":"671f52e8d7d150525603aa6a3ea6d14d2130651e"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"1a2a5e1e40bd2b877909c4cf248d524a29b00426","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    synthetic_fields \u003d [\u0027field2\u0027]"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    fields_no_update \u003d [\u0027id\u0027]"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    fields_need_translation \u003d {\u0027field_ovo\u0027: \u0027field_db\u0027}"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"ba0121b8_004ef195","line":165,"in_reply_to":"fa0719c6_fced738f","updated":"2016-04-03 18:23:14.000000000","message":"Ok, removed.","commit_id":"671f52e8d7d150525603aa6a3ea6d14d2130651e"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"4595cb1e95871b693d5e335a619339a56c544433","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    synthetic_fields \u003d [\u0027obj_field\u0027]"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    fields_no_update \u003d [\u0027id\u0027]"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"def get_random_dscp_mark():"}],"source_content_type":"text/x-python","patch_set":28,"id":"fa0719c6_9cf9d750","line":187,"updated":"2016-03-21 10:09:49.000000000","message":"No need to have this line.","commit_id":"671f52e8d7d150525603aa6a3ea6d14d2130651e"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"1a2a5e1e40bd2b877909c4cf248d524a29b00426","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    synthetic_fields \u003d [\u0027obj_field\u0027]"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    fields_no_update \u003d [\u0027id\u0027]"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"def get_random_dscp_mark():"}],"source_content_type":"text/x-python","patch_set":28,"id":"ba0121b8_60436d6d","line":187,"in_reply_to":"fa0719c6_9cf9d750","updated":"2016-04-03 18:23:14.000000000","message":"Removed.","commit_id":"671f52e8d7d150525603aa6a3ea6d14d2130651e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e8b8a3a3d9f9f3fd1cb2b0dbb749532c2ebd480c","unresolved":false,"context_lines":[{"line_number":244,"context_line":"            if field not in obj_cls.synthetic_fields:"},{"line_number":245,"context_line":"                generator \u003d FIELD_TYPE_VALUE_GENERATOR_MAP[type(field_obj)]"},{"line_number":246,"context_line":"                fields[field] \u003d generator()"},{"line_number":247,"context_line":"        obj \u003d obj_cls(None, **fields)"},{"line_number":248,"context_line":"        return obj.modify_fields_to_db(fields)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":28,"id":"fa0719c6_c8105404","line":247,"updated":"2016-03-22 17:12:35.000000000","message":"why is that needed?","commit_id":"671f52e8d7d150525603aa6a3ea6d14d2130651e"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"1a2a5e1e40bd2b877909c4cf248d524a29b00426","unresolved":false,"context_lines":[{"line_number":244,"context_line":"            if field not in obj_cls.synthetic_fields:"},{"line_number":245,"context_line":"                generator \u003d FIELD_TYPE_VALUE_GENERATOR_MAP[type(field_obj)]"},{"line_number":246,"context_line":"                fields[field] \u003d generator()"},{"line_number":247,"context_line":"        obj \u003d obj_cls(None, **fields)"},{"line_number":248,"context_line":"        return obj.modify_fields_to_db(fields)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":28,"id":"ba0121b8_c054f922","line":247,"in_reply_to":"fa0719c6_c8105404","updated":"2016-04-03 18:23:14.000000000","message":"Removed","commit_id":"671f52e8d7d150525603aa6a3ea6d14d2130651e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e8b8a3a3d9f9f3fd1cb2b0dbb749532c2ebd480c","unresolved":false,"context_lines":[{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    def _get_synthetic_fields_get_objects_calls(self, db_objs):"},{"line_number":298,"context_line":"        mock_calls \u003d []"},{"line_number":299,"context_line":"        # NOTE(rossella_s): since VersionedObjectRegistry is mocked the only"},{"line_number":300,"context_line":"        # class registered is FakeSmallNeutronObject, that is the only one for"},{"line_number":301,"context_line":"        # which the synthetic field is translated"},{"line_number":302,"context_line":"        for db_obj in db_objs:"}],"source_content_type":"text/x-python","patch_set":28,"id":"fa0719c6_e8f558cb","line":299,"updated":"2016-03-22 17:12:35.000000000","message":"? not needed I guess","commit_id":"671f52e8d7d150525603aa6a3ea6d14d2130651e"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"1a2a5e1e40bd2b877909c4cf248d524a29b00426","unresolved":false,"context_lines":[{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    def _get_synthetic_fields_get_objects_calls(self, db_objs):"},{"line_number":298,"context_line":"        mock_calls \u003d []"},{"line_number":299,"context_line":"        # NOTE(rossella_s): since VersionedObjectRegistry is mocked the only"},{"line_number":300,"context_line":"        # class registered is FakeSmallNeutronObject, that is the only one for"},{"line_number":301,"context_line":"        # which the synthetic field is translated"},{"line_number":302,"context_line":"        for db_obj in db_objs:"}],"source_content_type":"text/x-python","patch_set":28,"id":"ba0121b8_a02465c6","line":299,"in_reply_to":"fa0719c6_e8f558cb","updated":"2016-04-03 18:23:14.000000000","message":"I have removed the comment.","commit_id":"671f52e8d7d150525603aa6a3ea6d14d2130651e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e8b8a3a3d9f9f3fd1cb2b0dbb749532c2ebd480c","unresolved":false,"context_lines":[{"line_number":616,"context_line":"                                          **obj._get_composite_keys())"},{"line_number":617,"context_line":"        self.assertEqual(2, mock_commit.call_count)"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"    def test_update_no_field_to_update_forbidden_exception(self):"},{"line_number":620,"context_line":"        obj \u003d self._test_class(self.context, **self.db_obj)"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"        fields_to_update \u003d self.get_updatable_fields(self.db_obj)"}],"source_content_type":"text/x-python","patch_set":28,"id":"fa0719c6_0897ec48","line":619,"updated":"2016-03-22 17:12:35.000000000","message":"I don\u0027t believe it should be moved here since it checks object interface before update hits database. Also, it\u0027s not relevant to the patch goal.","commit_id":"671f52e8d7d150525603aa6a3ea6d14d2130651e"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"1a2a5e1e40bd2b877909c4cf248d524a29b00426","unresolved":false,"context_lines":[{"line_number":616,"context_line":"                                          **obj._get_composite_keys())"},{"line_number":617,"context_line":"        self.assertEqual(2, mock_commit.call_count)"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"    def test_update_no_field_to_update_forbidden_exception(self):"},{"line_number":620,"context_line":"        obj \u003d self._test_class(self.context, **self.db_obj)"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"        fields_to_update \u003d self.get_updatable_fields(self.db_obj)"}],"source_content_type":"text/x-python","patch_set":28,"id":"ba0121b8_c02b5993","line":619,"in_reply_to":"fa0719c6_0897ec48","updated":"2016-04-03 18:23:14.000000000","message":"Removed","commit_id":"671f52e8d7d150525603aa6a3ea6d14d2130651e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"384cfe737742d02817fbf8aa4cc15ac93161161d","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                                            nullable\u003dTrue)"},{"line_number":97,"context_line":"    }"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    primary_keys \u003d [\u0027id\u0027]"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    fields_no_update \u003d [\u0027field1\u0027]"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"7a1b2928_ae09eb2e","side":"PARENT","line":99,"updated":"2016-04-11 14:35:11.000000000","message":"why do we need to change that?","commit_id":"f6a933d640606465d0ff44f836e0d74b2a717c86"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"9afb6d0b96a80467ac5c5a7acea9b24d4c177e3f","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                                            nullable\u003dTrue)"},{"line_number":97,"context_line":"    }"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    primary_keys \u003d [\u0027id\u0027]"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    fields_no_update \u003d [\u0027field1\u0027]"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"5a18252c_40810d4a","side":"PARENT","line":99,"in_reply_to":"7a1b2928_ae09eb2e","updated":"2016-04-12 12:32:13.000000000","message":"meh","commit_id":"f6a933d640606465d0ff44f836e0d74b2a717c86"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"a9578602dea9cc8d91f7000fb43457f2334d823f","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    fields_no_update \u003d [\u0027field1\u0027]"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    primary_keys \u003d [\u0027id\u0027]"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    synthetic_fields \u003d [\u0027obj_field\u0027]"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":36,"id":"1a122d0e_ea072f7f","line":103,"updated":"2016-04-18 10:19:24.000000000","message":"nit: is this reordering necessary?","commit_id":"4c5f2a20082cfa4da0de186f0ab3e400a7d55964"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8486c1339f833820210a76aed9d816e742d7aa52","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    fields_no_update \u003d [\u0027field1\u0027]"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    primary_keys \u003d [\u0027id\u0027]"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    synthetic_fields \u003d [\u0027obj_field\u0027]"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":36,"id":"1a122d0e_cae6b3b3","line":103,"in_reply_to":"1a122d0e_ea072f7f","updated":"2016-04-18 10:21:08.000000000","message":"No.","commit_id":"4c5f2a20082cfa4da0de186f0ab3e400a7d55964"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"a9578602dea9cc8d91f7000fb43457f2334d823f","unresolved":false,"context_lines":[{"line_number":503,"context_line":"            \u0027fields_no_update\u0027,"},{"line_number":504,"context_line":"            new_callable\u003dmock.PropertyMock(return_value\u003d[\u0027a\u0027, \u0027c\u0027]),"},{"line_number":505,"context_line":"            create\u003dTrue):"},{"line_number":506,"context_line":"            obj \u003d self._test_class(self.context, **self.obj_fields[0])"},{"line_number":507,"context_line":"            self.assertRaises(base.NeutronObjectUpdateForbidden, obj.update)"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"    def test_update_updates_from_db_object(self):"}],"source_content_type":"text/x-python","patch_set":36,"id":"1a122d0e_8a6e7b2d","line":506,"updated":"2016-04-18 10:19:24.000000000","message":"why do we access obj_fields[0] now instead?","commit_id":"4c5f2a20082cfa4da0de186f0ab3e400a7d55964"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f9ec00dd0ed8a974cd16ed653031e2280a59d663","unresolved":false,"context_lines":[{"line_number":503,"context_line":"            \u0027fields_no_update\u0027,"},{"line_number":504,"context_line":"            new_callable\u003dmock.PropertyMock(return_value\u003d[\u0027a\u0027, \u0027c\u0027]),"},{"line_number":505,"context_line":"            create\u003dTrue):"},{"line_number":506,"context_line":"            obj \u003d self._test_class(self.context, **self.obj_fields[0])"},{"line_number":507,"context_line":"            self.assertRaises(base.NeutronObjectUpdateForbidden, obj.update)"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"    def test_update_updates_from_db_object(self):"}],"source_content_type":"text/x-python","patch_set":36,"id":"1a122d0e_b519187c","line":506,"in_reply_to":"1a122d0e_4ae90380","updated":"2016-04-18 10:24:02.000000000","message":"Note: https://review.openstack.org/#/c/306951/1","commit_id":"4c5f2a20082cfa4da0de186f0ab3e400a7d55964"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8486c1339f833820210a76aed9d816e742d7aa52","unresolved":false,"context_lines":[{"line_number":503,"context_line":"            \u0027fields_no_update\u0027,"},{"line_number":504,"context_line":"            new_callable\u003dmock.PropertyMock(return_value\u003d[\u0027a\u0027, \u0027c\u0027]),"},{"line_number":505,"context_line":"            create\u003dTrue):"},{"line_number":506,"context_line":"            obj \u003d self._test_class(self.context, **self.obj_fields[0])"},{"line_number":507,"context_line":"            self.assertRaises(base.NeutronObjectUpdateForbidden, obj.update)"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"    def test_update_updates_from_db_object(self):"}],"source_content_type":"text/x-python","patch_set":36,"id":"1a122d0e_4ae90380","line":506,"in_reply_to":"1a122d0e_8a6e7b2d","updated":"2016-04-18 10:21:08.000000000","message":"Because objects should be initialized with object fields, not db fields. I think this change is not strictly needed for the patch, could be a separate one. Need to check.","commit_id":"4c5f2a20082cfa4da0de186f0ab3e400a7d55964"}]}
