)]}'
{"neutron/tests/etc/policy.json":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"020bd27461a142f9e498a760b88032dbda38a50c","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    \"get_port:binding:vif_details\": \"rule:admin_only\","},{"line_number":75,"context_line":"    \"get_port:binding:host_id\": \"rule:admin_only\","},{"line_number":76,"context_line":"    \"get_port:binding:profile\": \"rule:admin_only\","},{"line_number":77,"context_line":"    \"update_port\": \"rule:admin_owner_or_network_owner or rule:context_is_advsvc\","},{"line_number":78,"context_line":"    \"update_port:device_owner\": \"not rule:network_device or rule:admin_or_network_owner or rule:context_is_advsvc\","},{"line_number":79,"context_line":"    \"update_port:mac_address\": \"rule:admin_only or rule:context_is_advsvc\","},{"line_number":80,"context_line":"    \"update_port:fixed_ips\": \"rule:admin_or_network_owner or rule:context_is_advsvc\","}],"source_content_type":"application/json","patch_set":4,"id":"9a68dd71_92313ea5","line":77,"range":{"start_line":77,"start_character":25,"end_line":77,"end_character":53},"updated":"2016-01-20 22:15:55.000000000","message":"It implies port owner cannot update its ports (typically port security group)","commit_id":"ff953afe02e16adc3d2af491c0b56e3fa16af2cf"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"33d6732d015d562e16fbf73392cf844b80874d39","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    \"get_port:binding:vif_details\": \"rule:admin_only\","},{"line_number":75,"context_line":"    \"get_port:binding:host_id\": \"rule:admin_only\","},{"line_number":76,"context_line":"    \"get_port:binding:profile\": \"rule:admin_only\","},{"line_number":77,"context_line":"    \"update_port\": \"rule:admin_owner_or_network_owner or rule:context_is_advsvc\","},{"line_number":78,"context_line":"    \"update_port:device_owner\": \"not rule:network_device or rule:admin_or_network_owner or rule:context_is_advsvc\","},{"line_number":79,"context_line":"    \"update_port:mac_address\": \"rule:admin_only or rule:context_is_advsvc\","},{"line_number":80,"context_line":"    \"update_port:fixed_ips\": \"rule:admin_or_network_owner or rule:context_is_advsvc\","}],"source_content_type":"application/json","patch_set":4,"id":"9a68dd71_51ff3b01","line":77,"range":{"start_line":77,"start_character":25,"end_line":77,"end_character":53},"in_reply_to":"9a68dd71_92313ea5","updated":"2016-01-21 03:15:46.000000000","message":"Hi, Credric, I think that should be discussed, and I would suggest you have a test.\n\nFirst, since \"rule:admin_owner_or_network_owner\" will match admin, resource owner, network owner, it\u0027s a large range then previous rule(only match admin and resource owner). So at least this changing doesn\u0027t make thing worse.\n\nSecond, since previous rule only matches admin and resource owner, network owner will be disallowed to update a port, for it\u0027s and-check for action rule and attributes rule. However, when port owner want to update port attributes listed in L78-L85 will also be disallowed, for rules there don\u0027t match port owner.\n\nThird, for port attributes not listed in L78-L85, port owner can still update them. For network owner, this patch purpose is to make network owner can update tenant port on its owned network, and that will make network_owner rule in following lines meanful.\n\nBTW, security group is a different port attribute from port_security_enabled, and since it\u0027s not listed here, port owner can always update that. :)","commit_id":"ff953afe02e16adc3d2af491c0b56e3fa16af2cf"}]}
