)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"57cd0877a727bc6d48d6b82bdfeb66c1b3942345","unresolved":false,"context_lines":[{"line_number":48,"context_line":"\u003d\u003d\u003dHow to try\u003d\u003d\u003d"},{"line_number":49,"context_line":"As admin:"},{"line_number":50,"context_line":"1. neutron flavor-create super_awesome L3_ROUTER_NAT"},{"line_number":51,"context_line":"2. neutron flavor-profile-create --driver \u0027neutron.services.l3_router.service_providers.dvr.DvrDriver\u0027"},{"line_number":52,"context_line":"3. neutron flavor-associate \u003cid from 1\u003e \u003cid from 2\u003e"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"As tenant:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dab17558_82d3bf37","line":51,"updated":"2016-05-13 23:44:19.000000000","message":"perhaps we want these to be prepopulated with the schema migration? To avoid the ops pain?","commit_id":"ab1ac67b8b6d90f9df677381608722763144ee9a"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b9070d69727857ed1ee4407eb19237c8c0bc528c","unresolved":false,"context_lines":[{"line_number":48,"context_line":"\u003d\u003d\u003dHow to try\u003d\u003d\u003d"},{"line_number":49,"context_line":"As admin:"},{"line_number":50,"context_line":"1. neutron flavor-create super_awesome L3_ROUTER_NAT"},{"line_number":51,"context_line":"2. neutron flavor-profile-create --driver \u0027neutron.services.l3_router.service_providers.dvr.DvrDriver\u0027"},{"line_number":52,"context_line":"3. neutron flavor-associate \u003cid from 1\u003e \u003cid from 2\u003e"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"As tenant:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dab17558_d952be66","line":51,"in_reply_to":"dab17558_82d3bf37","updated":"2016-05-16 08:36:22.000000000","message":"No, I don\u0027t think an op will always actually want to expose these flavors. Right now our default is to block setting distributed or HA by tenants. By exposing them as flavors tenants will be able to choose them.","commit_id":"ab1ac67b8b6d90f9df677381608722763144ee9a"}],"neutron/db/migration/alembic_migrations/versions/newton/expand/3d0e74aa7d37_add_flavor_id_to_routers.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"9c85a52ef0b9944a3faa3d81b0e6bc307136921c","unresolved":false,"context_lines":[{"line_number":32,"context_line":"down_revision \u003d \u0027d3435b514502\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# milestone identifier, used by neutron-db-manage"},{"line_number":35,"context_line":"neutron_milestone \u003d [migration.NEWTON]"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def upgrade():"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_c241470d","line":35,"updated":"2016-05-13 23:43:06.000000000","message":"is this new? And needed?","commit_id":"ab1ac67b8b6d90f9df677381608722763144ee9a"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b9070d69727857ed1ee4407eb19237c8c0bc528c","unresolved":false,"context_lines":[{"line_number":32,"context_line":"down_revision \u003d \u0027d3435b514502\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# milestone identifier, used by neutron-db-manage"},{"line_number":35,"context_line":"neutron_milestone \u003d [migration.NEWTON]"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def upgrade():"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_b941ba65","line":35,"in_reply_to":"dab17558_c241470d","updated":"2016-05-16 08:36:22.000000000","message":"seems to be. maybe Henry could clarify if it\u0027s requisite.","commit_id":"ab1ac67b8b6d90f9df677381608722763144ee9a"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"f0ed4323a4ebe4188654bb95004e952611f0a118","unresolved":false,"context_lines":[{"line_number":32,"context_line":"down_revision \u003d \u0027a963b38d82f4\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# milestone identifier, used by neutron-db-manage"},{"line_number":35,"context_line":"neutron_milestone \u003d [migration.NEWTON]"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def upgrade():"}],"source_content_type":"text/x-python","patch_set":12,"id":"7a8ec9b2_8174fcfd","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":38},"updated":"2016-09-13 17:43:44.000000000","message":"This should not have gone in here!!!","commit_id":"0e3f4b833502d0f501cfc3dd384642e46a3bf78a"}],"neutron/db/servicetype_db.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"9c85a52ef0b9944a3faa3d81b0e6bc307136921c","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        query \u003d ("},{"line_number":90,"context_line":"            context.session.query(ProviderResourceAssociation)."},{"line_number":91,"context_line":"            filter(ProviderResourceAssociation.resource_id.in_(resource_ids)))"},{"line_number":92,"context_line":"        return {rec.resource_id: rec.provider_name for rec in query}"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def add_resource_association(self, context, service_type, provider_name,"},{"line_number":95,"context_line":"                                 resource_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_4256f7d2","line":92,"updated":"2016-05-13 23:43:06.000000000","message":"I\u0027d extract these in its own patch for backport reasons if needed at all.","commit_id":"ab1ac67b8b6d90f9df677381608722763144ee9a"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b9070d69727857ed1ee4407eb19237c8c0bc528c","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        query \u003d ("},{"line_number":90,"context_line":"            context.session.query(ProviderResourceAssociation)."},{"line_number":91,"context_line":"            filter(ProviderResourceAssociation.resource_id.in_(resource_ids)))"},{"line_number":92,"context_line":"        return {rec.resource_id: rec.provider_name for rec in query}"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def add_resource_association(self, context, service_type, provider_name,"},{"line_number":95,"context_line":"                                 resource_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_5937eefe","line":92,"in_reply_to":"dab17558_4256f7d2","updated":"2016-05-16 08:36:22.000000000","message":"ok","commit_id":"ab1ac67b8b6d90f9df677381608722763144ee9a"}],"neutron/extensions/l3_flavors.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"9c85a52ef0b9944a3faa3d81b0e6bc307136921c","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"EXTENDED_ATTRIBUTES_2_0 \u003d {"},{"line_number":19,"context_line":"    \u0027routers\u0027: {"},{"line_number":20,"context_line":"        \u0027flavor_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":21,"context_line":"                      \u0027default\u0027: attributes.ATTR_NOT_SPECIFIED,"},{"line_number":22,"context_line":"                      \u0027is_visible\u0027: True, \u0027enforce_policy\u0027: True}"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_e26d6b9a","line":20,"updated":"2016-05-13 23:43:06.000000000","message":"are we allowing flavor updates?","commit_id":"ab1ac67b8b6d90f9df677381608722763144ee9a"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b9070d69727857ed1ee4407eb19237c8c0bc528c","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"EXTENDED_ATTRIBUTES_2_0 \u003d {"},{"line_number":19,"context_line":"    \u0027routers\u0027: {"},{"line_number":20,"context_line":"        \u0027flavor_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":21,"context_line":"                      \u0027default\u0027: attributes.ATTR_NOT_SPECIFIED,"},{"line_number":22,"context_line":"                      \u0027is_visible\u0027: True, \u0027enforce_policy\u0027: True}"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_99eaf672","line":20,"in_reply_to":"dab17558_e26d6b9a","updated":"2016-05-16 08:36:22.000000000","message":"ah, not initially. will update","commit_id":"ab1ac67b8b6d90f9df677381608722763144ee9a"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"9c85a52ef0b9944a3faa3d81b0e6bc307136921c","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @classmethod"},{"line_number":44,"context_line":"    def get_updated(cls):"},{"line_number":45,"context_line":"        return \"2015-12-10T00:00:00-00:00\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def get_extended_resources(self, version):"},{"line_number":48,"context_line":"        if version \u003d\u003d \"2.0\":"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_02734f81","line":45,"updated":"2016-05-13 23:43:06.000000000","message":"What about 1492-10-11? Please refresh pls?","commit_id":"ab1ac67b8b6d90f9df677381608722763144ee9a"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b9070d69727857ed1ee4407eb19237c8c0bc528c","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @classmethod"},{"line_number":44,"context_line":"    def get_updated(cls):"},{"line_number":45,"context_line":"        return \"2015-12-10T00:00:00-00:00\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def get_extended_resources(self, version):"},{"line_number":48,"context_line":"        if version \u003d\u003d \"2.0\":"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_f9034240","line":45,"in_reply_to":"dab17558_02734f81","updated":"2016-05-16 08:36:22.000000000","message":"Done","commit_id":"ab1ac67b8b6d90f9df677381608722763144ee9a"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"22bece5df160e275b92f3e763b0de04ec8a41909","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    def get_updated(cls):"},{"line_number":45,"context_line":"        return \"2016-05-17T00:00:00-00:00\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def get_extended_resources(self, version):"},{"line_number":48,"context_line":"        if version \u003d\u003d \"2.0\":"},{"line_number":49,"context_line":"            return EXTENDED_ATTRIBUTES_2_0"},{"line_number":50,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_b06da706","line":47,"updated":"2016-07-19 00:04:15.000000000","message":"Done","commit_id":"c93a5fda5edb1b2f28172eadcb5c8b1bd0e8cbcb"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"16af114c5f451a5ae49d7e28235db126c4d790a8","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    def get_updated(cls):"},{"line_number":45,"context_line":"        return \"2016-05-17T00:00:00-00:00\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def get_extended_resources(self, version):"},{"line_number":48,"context_line":"        if version \u003d\u003d \"2.0\":"},{"line_number":49,"context_line":"            return EXTENDED_ATTRIBUTES_2_0"},{"line_number":50,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_5030ab56","line":47,"updated":"2016-07-18 23:51:52.000000000","message":"don\u0027t we need to add required_extensions?","commit_id":"c93a5fda5edb1b2f28172eadcb5c8b1bd0e8cbcb"}],"neutron/plugins/common/constants.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"9c85a52ef0b9944a3faa3d81b0e6bc307136921c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    \u0027tag\u0027: \u0027tag\u0027,"},{"line_number":45,"context_line":"    \u0027timestamp_core\u0027: \u0027timestamp_core\u0027,"},{"line_number":46,"context_line":"    \u0027network_ip_availability\u0027: \u0027network-ip-availability\u0027,"},{"line_number":47,"context_line":"    \u0027flavors\u0027: \u0027flavors\u0027,"},{"line_number":48,"context_line":"}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"# Service operation status constants"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_22681387","line":47,"updated":"2016-05-13 23:43:06.000000000","message":"I\u0027d extract this into its own patch and start testing flavor and service type extensions by tweaking [1]\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/tests/contrib/hooks/api_extensions","commit_id":"ab1ac67b8b6d90f9df677381608722763144ee9a"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b9070d69727857ed1ee4407eb19237c8c0bc528c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    \u0027tag\u0027: \u0027tag\u0027,"},{"line_number":45,"context_line":"    \u0027timestamp_core\u0027: \u0027timestamp_core\u0027,"},{"line_number":46,"context_line":"    \u0027network_ip_availability\u0027: \u0027network-ip-availability\u0027,"},{"line_number":47,"context_line":"    \u0027flavors\u0027: \u0027flavors\u0027,"},{"line_number":48,"context_line":"}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"# Service operation status constants"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_d90abe25","line":47,"in_reply_to":"dab17558_22681387","updated":"2016-05-16 08:36:22.000000000","message":"ok","commit_id":"ab1ac67b8b6d90f9df677381608722763144ee9a"}],"neutron/services/l3_router/l3_router_plugin.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"76c12b13c7d8554c6c5b14e28dc21add23ef6e3e","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        rpc_worker \u003d service.RpcWorker([self], worker_process_count\u003d0)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        self.add_worker(rpc_worker)"},{"line_number":82,"context_line":"        self.driver_controller \u003d driver_controller.DriverController(self)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @log_helpers.log_method_call"},{"line_number":85,"context_line":"    def start_rpc_listeners(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_bac45d40","line":82,"updated":"2016-07-24 13:04:06.000000000","message":"nit, maybe over pedantic but you know...\ncan the var here please reflect that it is a l3 driver controller","commit_id":"b686fa4369ad103caef15e6657c7c6299978d222"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"0851e62031d75e660b277baeb84180b708d2827e","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        rpc_worker \u003d service.RpcWorker([self], worker_process_count\u003d0)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        self.add_worker(rpc_worker)"},{"line_number":82,"context_line":"        self.driver_controller \u003d driver_controller.DriverController(self)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @log_helpers.log_method_call"},{"line_number":85,"context_line":"    def start_rpc_listeners(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_07351bd9","line":82,"in_reply_to":"dada55a8_bac45d40","updated":"2016-07-25 22:33:55.000000000","message":"Done","commit_id":"b686fa4369ad103caef15e6657c7c6299978d222"}],"neutron/services/l3_router/service_providers/base.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f5ca7b1db7bfc8e204e1d1b92d3219e6b681bd52","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"class L3ServiceProvider(object):"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    supports_ha \u003d False  # True if driver supports HA routers"},{"line_number":19,"context_line":"    requires_ha \u003d False  # True if driver only works with HA routers"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_f01f1f07","line":16,"updated":"2016-07-23 16:13:55.000000000","message":"This is a class that\u0027s meant to be redefined by provider implementers so it\u0027d be nice to add a docstring?","commit_id":"b686fa4369ad103caef15e6657c7c6299978d222"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"0851e62031d75e660b277baeb84180b708d2827e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"class L3ServiceProvider(object):"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    supports_ha \u003d False  # True if driver supports HA routers"},{"line_number":19,"context_line":"    requires_ha \u003d False  # True if driver only works with HA routers"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_a746cf1e","line":16,"in_reply_to":"dada55a8_f01f1f07","updated":"2016-07-25 22:33:55.000000000","message":"Done","commit_id":"b686fa4369ad103caef15e6657c7c6299978d222"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"bd20be136d1868031730cec140c8486aaade215b","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    supports_ha \u003d False  # True if driver supports HA routers"},{"line_number":29,"context_line":"    requires_ha \u003d False  # True if driver only works with HA routers"},{"line_number":30,"context_line":"    supports_distributed \u003d False  # True if driver supports DVR routers"},{"line_number":31,"context_line":"    requires_distributed \u003d False  # True if driver only works with DVR routers"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def __init__(self, l3plugin):"},{"line_number":34,"context_line":"        self.l3plugin \u003d l3plugin"}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_cbf24c9a","line":31,"updated":"2016-07-28 01:17:56.000000000","message":"Enum requires an import in py27 from a package not currently in our requirements. It looks like it\u0027s in global requirements (enum34).\n\nI can still clean this up a bit to catch the insane case.","commit_id":"95b0db285f3d1d144c2c6554004dbcd489e07fc5"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"fbaa8a3bb3b336d2cb576afe32063c9e36496d85","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    supports_ha \u003d False  # True if driver supports HA routers"},{"line_number":29,"context_line":"    requires_ha \u003d False  # True if driver only works with HA routers"},{"line_number":30,"context_line":"    supports_distributed \u003d False  # True if driver supports DVR routers"},{"line_number":31,"context_line":"    requires_distributed \u003d False  # True if driver only works with DVR routers"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def __init__(self, l3plugin):"},{"line_number":34,"context_line":"        self.l3plugin \u003d l3plugin"}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_c3207efa","line":31,"updated":"2016-07-27 21:22:47.000000000","message":"nit: A single tri-state variable would make a little more sense to me and eliminate the possible non-sensical combination (i.e. supports_ha \u003d False, requires_ha \u003d True). It makes me wonder why we don\u0027t make use of Enum. Is it just too new or are there issue with it.\n\nAnyway, I don\u0027t think this has to be changed.","commit_id":"95b0db285f3d1d144c2c6554004dbcd489e07fc5"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"68b52d06b845fe75ef3cf45490560e96216e2eba","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    def is_compatible(self, value):"},{"line_number":21,"context_line":"        if value \u003d\u003d self.requires:"},{"line_number":22,"context_line":"            return True"},{"line_number":23,"context_line":"        if value and self.supports:"},{"line_number":24,"context_line":"            return True"},{"line_number":25,"context_line":"        return False"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_77fdc839","line":23,"range":{"start_line":23,"start_character":8,"end_line":23,"end_character":34},"updated":"2016-07-28 21:44:53.000000000","message":"Technically, \"if self.supports: return True\" works too (i.e. you don\u0027t have to consider value here) I think the following works:\n\n  return self.supports or value \u003d\u003d self.requires\n\nThis was just a result of my trying to double check your logic here. Your logic is equivalent so I think this falls in the \"nit\" bucket.","commit_id":"0e3f4b833502d0f501cfc3dd384642e46a3bf78a"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"40d62a43c6f1d6f55850ef69a5aa380acfdea489","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    def is_compatible(self, value):"},{"line_number":21,"context_line":"        if value \u003d\u003d self.requires:"},{"line_number":22,"context_line":"            return True"},{"line_number":23,"context_line":"        if value and self.supports:"},{"line_number":24,"context_line":"            return True"},{"line_number":25,"context_line":"        return False"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_895e6410","line":23,"range":{"start_line":23,"start_character":8,"end_line":23,"end_character":34},"in_reply_to":"bacf61ea_77fdc839","updated":"2016-07-28 21:45:57.000000000","message":"No, that\u0027s not right^.","commit_id":"0e3f4b833502d0f501cfc3dd384642e46a3bf78a"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"0690be56e0edb1db1a83b4e0e07330cdb35fe45d","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    def is_compatible(self, value):"},{"line_number":21,"context_line":"        if value \u003d\u003d self.requires:"},{"line_number":22,"context_line":"            return True"},{"line_number":23,"context_line":"        if value and self.supports:"},{"line_number":24,"context_line":"            return True"},{"line_number":25,"context_line":"        return False"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_e90560c2","line":23,"range":{"start_line":23,"start_character":8,"end_line":23,"end_character":34},"in_reply_to":"bacf61ea_895e6410","updated":"2016-07-28 21:48:54.000000000","message":"I wrote down the boolean equation and forgot to write down one important piece. So, disregard all of that. I meant this:\n\n  return (self.supports and not self.required) or value \u003d\u003d self.requires\n\nWhich isn\u0027t quite as compelling as a simplification.","commit_id":"0e3f4b833502d0f501cfc3dd384642e46a3bf78a"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"bf1a2411f689d0c72f1ddf8483f5d8b54ff57ce1","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    def is_compatible(self, value):"},{"line_number":21,"context_line":"        if value \u003d\u003d self.requires:"},{"line_number":22,"context_line":"            return True"},{"line_number":23,"context_line":"        if value and self.supports:"},{"line_number":24,"context_line":"            return True"},{"line_number":25,"context_line":"        return False"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_dfe92a1c","line":23,"range":{"start_line":23,"start_character":8,"end_line":23,"end_character":34},"in_reply_to":"bacf61ea_e90560c2","updated":"2016-07-28 22:40:50.000000000","message":"Trickier than it looks. I screwed it up once the first time i implemented it :)","commit_id":"0e3f4b833502d0f501cfc3dd384642e46a3bf78a"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"68b52d06b845fe75ef3cf45490560e96216e2eba","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        self.supports \u003d supports"},{"line_number":29,"context_line":"        self.requires \u003d requires"},{"line_number":30,"context_line":"        if requires and not supports:"},{"line_number":31,"context_line":"            raise RuntimeError(_(\"A driver can\u0027t require a feature and not \""},{"line_number":32,"context_line":"                                 \"support it.\"))"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"UNSUPPORTED \u003d _FeatureFlag(supports\u003dFalse, requires\u003dFalse)"},{"line_number":35,"context_line":"OPTIONAL \u003d _FeatureFlag(supports\u003dTrue, requires\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_775668d3","line":32,"range":{"start_line":31,"start_character":33,"end_line":32,"end_character":46},"updated":"2016-07-28 21:44:53.000000000","message":"What do you mean? People take on stuff they can\u0027t see through all the time. ;) But, you\u0027re right, we probably shouldn\u0027t encode that behavioral flaw in to our software.","commit_id":"0e3f4b833502d0f501cfc3dd384642e46a3bf78a"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"5974a8e6434a03f0859c9d9b2d24836c4723fca6","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    responsibility of the driver to subscribe to the events it is interested"},{"line_number":44,"context_line":"    in (e.g. router_create, router_update, router_delete, etc)."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    The \u0027ha\u0027 and \u0027distributed\u0027 attributes below are used to determine if a"},{"line_number":47,"context_line":"    router request with the \u0027ha\u0027 or \u0027distributed\u0027 attribute can be supported"},{"line_number":48,"context_line":"    by this particular driver. These attributes must be present."},{"line_number":49,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_318a40c0","line":46,"range":{"start_line":46,"start_character":28,"end_line":46,"end_character":29},"updated":"2016-07-28 20:51:10.000000000","message":"this docstring should be updated?","commit_id":"0e3f4b833502d0f501cfc3dd384642e46a3bf78a"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"68b52d06b845fe75ef3cf45490560e96216e2eba","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    responsibility of the driver to subscribe to the events it is interested"},{"line_number":44,"context_line":"    in (e.g. router_create, router_update, router_delete, etc)."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    The \u0027ha\u0027 and \u0027distributed\u0027 attributes below are used to determine if a"},{"line_number":47,"context_line":"    router request with the \u0027ha\u0027 or \u0027distributed\u0027 attribute can be supported"},{"line_number":48,"context_line":"    by this particular driver. These attributes must be present."},{"line_number":49,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_d7f634f8","line":46,"range":{"start_line":46,"start_character":28,"end_line":46,"end_character":29},"in_reply_to":"bacf61ea_318a40c0","updated":"2016-07-28 21:44:53.000000000","message":"I think its just as relevant as before. Maybe I don\u0027t see what you want fixed.","commit_id":"0e3f4b833502d0f501cfc3dd384642e46a3bf78a"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"1da413ee0c4ee9444b24b9305df730d0adf99386","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    responsibility of the driver to subscribe to the events it is interested"},{"line_number":44,"context_line":"    in (e.g. router_create, router_update, router_delete, etc)."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    The \u0027ha\u0027 and \u0027distributed\u0027 attributes below are used to determine if a"},{"line_number":47,"context_line":"    router request with the \u0027ha\u0027 or \u0027distributed\u0027 attribute can be supported"},{"line_number":48,"context_line":"    by this particular driver. These attributes must be present."},{"line_number":49,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_09e1d4fe","line":46,"range":{"start_line":46,"start_character":28,"end_line":46,"end_character":29},"in_reply_to":"bacf61ea_c99e9cb7","updated":"2016-07-28 21:50:51.000000000","message":"Oh, ok. I think it is clear enough the way it is written. So, no need to stop the presses.","commit_id":"0e3f4b833502d0f501cfc3dd384642e46a3bf78a"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"c75cdeccc4e4e3b97e46ba76f125d5bfe8f5e1d5","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    responsibility of the driver to subscribe to the events it is interested"},{"line_number":44,"context_line":"    in (e.g. router_create, router_update, router_delete, etc)."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    The \u0027ha\u0027 and \u0027distributed\u0027 attributes below are used to determine if a"},{"line_number":47,"context_line":"    router request with the \u0027ha\u0027 or \u0027distributed\u0027 attribute can be supported"},{"line_number":48,"context_line":"    by this particular driver. These attributes must be present."},{"line_number":49,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_c99e9cb7","line":46,"range":{"start_line":46,"start_character":28,"end_line":46,"end_character":29},"in_reply_to":"bacf61ea_d7f634f8","updated":"2016-07-28 21:46:22.000000000","message":"it\u0027s a nit, these are called ha_support and distributed_support.","commit_id":"0e3f4b833502d0f501cfc3dd384642e46a3bf78a"}],"neutron/services/l3_router/service_providers/driver_controller.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"9c85a52ef0b9944a3faa3d81b0e6bc307136921c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#    distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"},{"line_number":11,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":"from oslo_config import cfg"},{"line_number":15,"context_line":"from oslo_log import log as logging"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_62085bda","line":13,"updated":"2016-05-13 23:43:06.000000000","message":"space space space","commit_id":"ab1ac67b8b6d90f9df677381608722763144ee9a"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b9070d69727857ed1ee4407eb19237c8c0bc528c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#    distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"},{"line_number":11,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":"from oslo_config import cfg"},{"line_number":15,"context_line":"from oslo_log import log as logging"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_3904aa16","line":13,"in_reply_to":"dab17558_62085bda","updated":"2016-05-16 08:36:22.000000000","message":"Done","commit_id":"ab1ac67b8b6d90f9df677381608722763144ee9a"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f5ca7b1db7bfc8e204e1d1b92d3219e6b681bd52","unresolved":false,"context_lines":[{"line_number":29,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class DriverController(object):"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def __init__(self, l3_plugin):"},{"line_number":35,"context_line":"        self.l3_plugin \u003d l3_plugin"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_d01c9b15","line":32,"updated":"2016-07-23 16:13:55.000000000","message":"docstring? Why does this have no public API? If this is a reactive component only, can we spare a few words on its responsibilities?","commit_id":"b686fa4369ad103caef15e6657c7c6299978d222"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"0851e62031d75e660b277baeb84180b708d2827e","unresolved":false,"context_lines":[{"line_number":29,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class DriverController(object):"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def __init__(self, l3_plugin):"},{"line_number":35,"context_line":"        self.l3_plugin \u003d l3_plugin"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_1a29f289","line":32,"in_reply_to":"dada55a8_d01c9b15","updated":"2016-07-25 22:33:55.000000000","message":"Done","commit_id":"b686fa4369ad103caef15e6657c7c6299978d222"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f5ca7b1db7bfc8e204e1d1b92d3219e6b681bd52","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                                **kwargs):"},{"line_number":77,"context_line":"        \"\"\"Handle transition between providers."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        The provider can be updated in two ways. One is by the caller updating"},{"line_number":80,"context_line":"        the flavor and the other is by the caller changing the \u0027ha\u0027 and/or"},{"line_number":81,"context_line":"        \u0027distributed\u0027 attributes."},{"line_number":82,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_f0e6ff14","line":79,"updated":"2016-07-23 16:13:55.000000000","message":"the flavor can\u0027t be updated from the API [1], so this sentence might be a bit misleading. What do you mean exactly?\n\n[1] https://review.openstack.org/#/c/268941/9/neutron/extensions/l3_flavors.py@21","commit_id":"b686fa4369ad103caef15e6657c7c6299978d222"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"0851e62031d75e660b277baeb84180b708d2827e","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                                **kwargs):"},{"line_number":77,"context_line":"        \"\"\"Handle transition between providers."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        The provider can be updated in two ways. One is by the caller updating"},{"line_number":80,"context_line":"        the flavor and the other is by the caller changing the \u0027ha\u0027 and/or"},{"line_number":81,"context_line":"        \u0027distributed\u0027 attributes."},{"line_number":82,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_7a6e2eca","line":79,"in_reply_to":"dada55a8_f0e6ff14","updated":"2016-07-25 22:33:55.000000000","message":"oh, it\u0027s old from when i was thinking we would allow it.","commit_id":"b686fa4369ad103caef15e6657c7c6299978d222"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"76c12b13c7d8554c6c5b14e28dc21add23ef6e3e","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                # update the flavor automatically in the future."},{"line_number":97,"context_line":"                if old_router[\u0027flavor_id\u0027]:"},{"line_number":98,"context_line":"                    raise n_exc.Invalid("},{"line_number":99,"context_line":"                        \"Changing the \u0027ha\u0027 and \u0027distributed\u0027 attributes on a \""},{"line_number":100,"context_line":"                        \"router associated with a flavor is not supported.\")"},{"line_number":101,"context_line":"                if \u0027distributed\u0027 not in router:"},{"line_number":102,"context_line":"                    router[\u0027distributed\u0027] \u003d old_router[\u0027distributed\u0027]"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_fadc151a","line":99,"updated":"2016-07-24 13:04:06.000000000","message":"missing translation","commit_id":"b686fa4369ad103caef15e6657c7c6299978d222"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"0851e62031d75e660b277baeb84180b708d2827e","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                # update the flavor automatically in the future."},{"line_number":97,"context_line":"                if old_router[\u0027flavor_id\u0027]:"},{"line_number":98,"context_line":"                    raise n_exc.Invalid("},{"line_number":99,"context_line":"                        \"Changing the \u0027ha\u0027 and \u0027distributed\u0027 attributes on a \""},{"line_number":100,"context_line":"                        \"router associated with a flavor is not supported.\")"},{"line_number":101,"context_line":"                if \u0027distributed\u0027 not in router:"},{"line_number":102,"context_line":"                    router[\u0027distributed\u0027] \u003d old_router[\u0027distributed\u0027]"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_1a2f323f","line":99,"in_reply_to":"dada55a8_fadc151a","updated":"2016-07-25 22:33:55.000000000","message":"Done","commit_id":"b686fa4369ad103caef15e6657c7c6299978d222"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"76c12b13c7d8554c6c5b14e28dc21add23ef6e3e","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            if self._is_driver_compatible(distributed, ha, driver):"},{"line_number":157,"context_line":"                return driver"},{"line_number":158,"context_line":"        raise NotImplementedError("},{"line_number":159,"context_line":"            \"Could not find a service provider that supports \""},{"line_number":160,"context_line":"            \"distributed\u003d%(d)s and ha\u003d%(h)s\" % {\u0027d\u0027: distributed, \u0027h\u0027: ha}"},{"line_number":161,"context_line":"        )"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_3ae7cde5","line":159,"updated":"2016-07-24 13:04:06.000000000","message":"ditto","commit_id":"b686fa4369ad103caef15e6657c7c6299978d222"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"0851e62031d75e660b277baeb84180b708d2827e","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            if self._is_driver_compatible(distributed, ha, driver):"},{"line_number":157,"context_line":"                return driver"},{"line_number":158,"context_line":"        raise NotImplementedError("},{"line_number":159,"context_line":"            \"Could not find a service provider that supports \""},{"line_number":160,"context_line":"            \"distributed\u003d%(d)s and ha\u003d%(h)s\" % {\u0027d\u0027: distributed, \u0027h\u0027: ha}"},{"line_number":161,"context_line":"        )"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_7a262e69","line":159,"in_reply_to":"dada55a8_3ae7cde5","updated":"2016-07-25 22:33:55.000000000","message":"Done","commit_id":"b686fa4369ad103caef15e6657c7c6299978d222"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f5ca7b1db7bfc8e204e1d1b92d3219e6b681bd52","unresolved":false,"context_lines":[{"line_number":160,"context_line":"            \"distributed\u003d%(d)s and ha\u003d%(h)s\" % {\u0027d\u0027: distributed, \u0027h\u0027: ha}"},{"line_number":161,"context_line":"        )"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    @staticmethod"},{"line_number":164,"context_line":"    def _is_driver_compatible(distributed, ha, driver):"},{"line_number":165,"context_line":"        if driver.requires_distributed and not distributed:"},{"line_number":166,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_5030ab9e","line":163,"updated":"2016-07-23 16:13:55.000000000","message":"are these static methods meant to be overwritten? Why not have them be module functions?","commit_id":"b686fa4369ad103caef15e6657c7c6299978d222"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"0851e62031d75e660b277baeb84180b708d2827e","unresolved":false,"context_lines":[{"line_number":160,"context_line":"            \"distributed\u003d%(d)s and ha\u003d%(h)s\" % {\u0027d\u0027: distributed, \u0027h\u0027: ha}"},{"line_number":161,"context_line":"        )"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    @staticmethod"},{"line_number":164,"context_line":"    def _is_driver_compatible(distributed, ha, driver):"},{"line_number":165,"context_line":"        if driver.requires_distributed and not distributed:"},{"line_number":166,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_5a29aa36","line":163,"in_reply_to":"dada55a8_5030ab9e","updated":"2016-07-25 22:33:55.000000000","message":"Done","commit_id":"b686fa4369ad103caef15e6657c7c6299978d222"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"76c12b13c7d8554c6c5b14e28dc21add23ef6e3e","unresolved":false,"context_lines":[{"line_number":197,"context_line":"    def _ensure_driver_supports_request(drv, router_body):"},{"line_number":198,"context_line":"        r \u003d router_body"},{"line_number":199,"context_line":"        if drv.requires_distributed and r.get(\u0027distributed\u0027) is False:"},{"line_number":200,"context_line":"            raise n_exc.Invalid(\"Provider %s does not support \""},{"line_number":201,"context_line":"                                \"distributed\u003dFalse\" % drv.name)"},{"line_number":202,"context_line":"        if drv.requires_ha and r.get(\u0027ha\u0027) is False:"},{"line_number":203,"context_line":"            raise n_exc.Invalid(\"Provider %s does not support \""}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_7ad145fb","line":200,"updated":"2016-07-24 13:04:06.000000000","message":"ditto","commit_id":"b686fa4369ad103caef15e6657c7c6299978d222"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"0851e62031d75e660b277baeb84180b708d2827e","unresolved":false,"context_lines":[{"line_number":197,"context_line":"    def _ensure_driver_supports_request(drv, router_body):"},{"line_number":198,"context_line":"        r \u003d router_body"},{"line_number":199,"context_line":"        if drv.requires_distributed and r.get(\u0027distributed\u0027) is False:"},{"line_number":200,"context_line":"            raise n_exc.Invalid(\"Provider %s does not support \""},{"line_number":201,"context_line":"                                \"distributed\u003dFalse\" % drv.name)"},{"line_number":202,"context_line":"        if drv.requires_ha and r.get(\u0027ha\u0027) is False:"},{"line_number":203,"context_line":"            raise n_exc.Invalid(\"Provider %s does not support \""}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_9a1b221c","line":200,"in_reply_to":"dada55a8_7ad145fb","updated":"2016-07-25 22:33:55.000000000","message":"Done","commit_id":"b686fa4369ad103caef15e6657c7c6299978d222"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"76c12b13c7d8554c6c5b14e28dc21add23ef6e3e","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            raise n_exc.Invalid(\"Provider %s does not support \""},{"line_number":201,"context_line":"                                \"distributed\u003dFalse\" % drv.name)"},{"line_number":202,"context_line":"        if drv.requires_ha and r.get(\u0027ha\u0027) is False:"},{"line_number":203,"context_line":"            raise n_exc.Invalid(\"Provider %s does not support \""},{"line_number":204,"context_line":"                                \"ha\u003dFalse\" % drv.name)"},{"line_number":205,"context_line":"        if r.get(\u0027distributed\u0027) is True and not drv.supports_distributed:"},{"line_number":206,"context_line":"            raise n_exc.Invalid(\"Provider %s does not support \""}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_5acc4161","line":203,"updated":"2016-07-24 13:04:06.000000000","message":"ditto","commit_id":"b686fa4369ad103caef15e6657c7c6299978d222"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"0851e62031d75e660b277baeb84180b708d2827e","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            raise n_exc.Invalid(\"Provider %s does not support \""},{"line_number":201,"context_line":"                                \"distributed\u003dFalse\" % drv.name)"},{"line_number":202,"context_line":"        if drv.requires_ha and r.get(\u0027ha\u0027) is False:"},{"line_number":203,"context_line":"            raise n_exc.Invalid(\"Provider %s does not support \""},{"line_number":204,"context_line":"                                \"ha\u003dFalse\" % drv.name)"},{"line_number":205,"context_line":"        if r.get(\u0027distributed\u0027) is True and not drv.supports_distributed:"},{"line_number":206,"context_line":"            raise n_exc.Invalid(\"Provider %s does not support \""}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_fa1a1e16","line":203,"in_reply_to":"dada55a8_5acc4161","updated":"2016-07-25 22:33:55.000000000","message":"Done","commit_id":"b686fa4369ad103caef15e6657c7c6299978d222"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"76c12b13c7d8554c6c5b14e28dc21add23ef6e3e","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            raise n_exc.Invalid(\"Provider %s does not support \""},{"line_number":204,"context_line":"                                \"ha\u003dFalse\" % drv.name)"},{"line_number":205,"context_line":"        if r.get(\u0027distributed\u0027) is True and not drv.supports_distributed:"},{"line_number":206,"context_line":"            raise n_exc.Invalid(\"Provider %s does not support \""},{"line_number":207,"context_line":"                                \"distributed\u003dTrue\" % drv.name)"},{"line_number":208,"context_line":"        if r.get(\u0027ha\u0027) is True and not drv.supports_ha:"},{"line_number":209,"context_line":"            raise n_exc.Invalid(\"Provider %s does not support \""}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_badbbd1a","line":206,"updated":"2016-07-24 13:04:06.000000000","message":"ditto","commit_id":"b686fa4369ad103caef15e6657c7c6299978d222"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"0851e62031d75e660b277baeb84180b708d2827e","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            raise n_exc.Invalid(\"Provider %s does not support \""},{"line_number":204,"context_line":"                                \"ha\u003dFalse\" % drv.name)"},{"line_number":205,"context_line":"        if r.get(\u0027distributed\u0027) is True and not drv.supports_distributed:"},{"line_number":206,"context_line":"            raise n_exc.Invalid(\"Provider %s does not support \""},{"line_number":207,"context_line":"                                \"distributed\u003dTrue\" % drv.name)"},{"line_number":208,"context_line":"        if r.get(\u0027ha\u0027) is True and not drv.supports_ha:"},{"line_number":209,"context_line":"            raise n_exc.Invalid(\"Provider %s does not support \""}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_da159ae5","line":206,"in_reply_to":"dada55a8_badbbd1a","updated":"2016-07-25 22:33:55.000000000","message":"Done","commit_id":"b686fa4369ad103caef15e6657c7c6299978d222"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"76c12b13c7d8554c6c5b14e28dc21add23ef6e3e","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            raise n_exc.Invalid(\"Provider %s does not support \""},{"line_number":207,"context_line":"                                \"distributed\u003dTrue\" % drv.name)"},{"line_number":208,"context_line":"        if r.get(\u0027ha\u0027) is True and not drv.supports_ha:"},{"line_number":209,"context_line":"            raise n_exc.Invalid(\"Provider %s does not support \""},{"line_number":210,"context_line":"                                \"ha\u003dTrue\" % drv.name)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_9ad6b9ef","line":209,"updated":"2016-07-24 13:04:06.000000000","message":"ditto","commit_id":"b686fa4369ad103caef15e6657c7c6299978d222"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"0851e62031d75e660b277baeb84180b708d2827e","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            raise n_exc.Invalid(\"Provider %s does not support \""},{"line_number":207,"context_line":"                                \"distributed\u003dTrue\" % drv.name)"},{"line_number":208,"context_line":"        if r.get(\u0027ha\u0027) is True and not drv.supports_ha:"},{"line_number":209,"context_line":"            raise n_exc.Invalid(\"Provider %s does not support \""},{"line_number":210,"context_line":"                                \"ha\u003dTrue\" % drv.name)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_3ad3163a","line":209,"in_reply_to":"dada55a8_9ad6b9ef","updated":"2016-07-25 22:33:55.000000000","message":"Done","commit_id":"b686fa4369ad103caef15e6657c7c6299978d222"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"fbaa8a3bb3b336d2cb576afe32063c9e36496d85","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        \"\"\""},{"line_number":100,"context_line":"        drv \u003d self._get_provider_for_router(context, router_id)"},{"line_number":101,"context_line":"        new_drv \u003d None"},{"line_number":102,"context_line":"        if not _flavor_specified(router):"},{"line_number":103,"context_line":"            try:"},{"line_number":104,"context_line":"                _ensure_driver_supports_request(drv, router)"},{"line_number":105,"context_line":"            except n_exc.Invalid:"}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_f4873610","line":102,"range":{"start_line":102,"start_character":15,"end_line":102,"end_character":40},"updated":"2016-07-27 21:22:47.000000000","message":"The extension definition doesn\u0027t allow PUT to flavor_id, right?","commit_id":"95b0db285f3d1d144c2c6554004dbcd489e07fc5"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"bd20be136d1868031730cec140c8486aaade215b","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        \"\"\""},{"line_number":100,"context_line":"        drv \u003d self._get_provider_for_router(context, router_id)"},{"line_number":101,"context_line":"        new_drv \u003d None"},{"line_number":102,"context_line":"        if not _flavor_specified(router):"},{"line_number":103,"context_line":"            try:"},{"line_number":104,"context_line":"                _ensure_driver_supports_request(drv, router)"},{"line_number":105,"context_line":"            except n_exc.Invalid:"}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_4bfe5c6c","line":102,"updated":"2016-07-28 01:17:56.000000000","message":"Yeah, right now it\u0027s not supported but the plan is to allow it in the future. I\u0027ll add a note here.","commit_id":"95b0db285f3d1d144c2c6554004dbcd489e07fc5"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"fbaa8a3bb3b336d2cb576afe32063c9e36496d85","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                # flags from the previous state if not in the update so we can"},{"line_number":109,"context_line":"                # determine the target provider appropriately."},{"line_number":110,"context_line":"                # NOTE(kevinbenton): if the router is associated with a flavor"},{"line_number":111,"context_line":"                # we bail because changing the provider without changing"},{"line_number":112,"context_line":"                # the flavor will make things inconsistent. We can probably"},{"line_number":113,"context_line":"                # update the flavor automatically in the future."},{"line_number":114,"context_line":"                if old_router[\u0027flavor_id\u0027]:"},{"line_number":115,"context_line":"                    raise n_exc.Invalid(_("}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_94523adc","line":112,"range":{"start_line":111,"start_character":56,"end_line":112,"end_character":28},"updated":"2016-07-27 21:22:47.000000000","message":"Extension doesn\u0027t allow PUT to flavor_id. So, how can the flavor be changed?\n\nWe already allow converting a single node router to a DVR and a few other transitions. Will these transitions be allowed with the flavor based API?","commit_id":"95b0db285f3d1d144c2c6554004dbcd489e07fc5"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"bd20be136d1868031730cec140c8486aaade215b","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                # determine the target provider appropriately."},{"line_number":110,"context_line":"                # NOTE(kevinbenton): if the router is associated with a flavor"},{"line_number":111,"context_line":"                # we bail because changing the provider without changing"},{"line_number":112,"context_line":"                # the flavor will make things inconsistent. We can probably"},{"line_number":113,"context_line":"                # update the flavor automatically in the future."},{"line_number":114,"context_line":"                if old_router[\u0027flavor_id\u0027]:"},{"line_number":115,"context_line":"                    raise n_exc.Invalid(_("}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_2b032875","line":112,"updated":"2016-07-28 01:17:56.000000000","message":"The flavor will be changed if flipping the \u0027ha\u0027/\u0027distributed\u0027 attributes causes a change to another driver. This is to support our existing system.","commit_id":"95b0db285f3d1d144c2c6554004dbcd489e07fc5"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"fbaa8a3bb3b336d2cb576afe32063c9e36496d85","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                if \u0027ha\u0027 not in router:"},{"line_number":121,"context_line":"                    router[\u0027ha\u0027] \u003d old_router[\u0027distributed\u0027]"},{"line_number":122,"context_line":"                new_drv \u003d self._attrs_to_driver(router)"},{"line_number":123,"context_line":"        else:"},{"line_number":124,"context_line":"            router_db.flavor_id \u003d router[\u0027flavor_id\u0027]"},{"line_number":125,"context_line":"            new_drv \u003d self._get_l3_driver_by_flavor(context,"},{"line_number":126,"context_line":"                                                    router[\u0027flavor_id\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_f42a96e6","line":123,"range":{"start_line":123,"start_character":8,"end_line":123,"end_character":13},"updated":"2016-07-27 21:22:47.000000000","message":"Should this also check if router[\u0027flavor_id\u0027] \u003d\u003d old_router[\u0027flavor_id\u0027]?","commit_id":"95b0db285f3d1d144c2c6554004dbcd489e07fc5"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"bd20be136d1868031730cec140c8486aaade215b","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                if \u0027ha\u0027 not in router:"},{"line_number":121,"context_line":"                    router[\u0027ha\u0027] \u003d old_router[\u0027distributed\u0027]"},{"line_number":122,"context_line":"                new_drv \u003d self._attrs_to_driver(router)"},{"line_number":123,"context_line":"        else:"},{"line_number":124,"context_line":"            router_db.flavor_id \u003d router[\u0027flavor_id\u0027]"},{"line_number":125,"context_line":"            new_drv \u003d self._get_l3_driver_by_flavor(context,"},{"line_number":126,"context_line":"                                                    router[\u0027flavor_id\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_8bf8547e","line":123,"updated":"2016-07-28 01:17:56.000000000","message":"Yep","commit_id":"95b0db285f3d1d144c2c6554004dbcd489e07fc5"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"bd20be136d1868031730cec140c8486aaade215b","unresolved":false,"context_lines":[{"line_number":236,"context_line":"            router[\u0027flavor_id\u0027] !\u003d lib_const.ATTR_NOT_SPECIFIED)"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"def _ensure_driver_supports_request(drv, router_body):"},{"line_number":240,"context_line":"    r \u003d router_body"},{"line_number":241,"context_line":"    if drv.requires_distributed and r.get(\u0027distributed\u0027) is False:"},{"line_number":242,"context_line":"        raise n_exc.Invalid(_(\"Provider %s does not support \""}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_6bf52082","line":239,"updated":"2016-07-28 01:17:56.000000000","message":"I kind of want to maintain the specific messages. I can clean this up a bit though.","commit_id":"95b0db285f3d1d144c2c6554004dbcd489e07fc5"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"fbaa8a3bb3b336d2cb576afe32063c9e36496d85","unresolved":false,"context_lines":[{"line_number":236,"context_line":"            router[\u0027flavor_id\u0027] !\u003d lib_const.ATTR_NOT_SPECIFIED)"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"def _ensure_driver_supports_request(drv, router_body):"},{"line_number":240,"context_line":"    r \u003d router_body"},{"line_number":241,"context_line":"    if drv.requires_distributed and r.get(\u0027distributed\u0027) is False:"},{"line_number":242,"context_line":"        raise n_exc.Invalid(_(\"Provider %s does not support \""}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_d4679223","line":239,"range":{"start_line":239,"start_character":4,"end_line":239,"end_character":35},"updated":"2016-07-27 21:22:47.000000000","message":"nit: This method could be simplified by writing it in terms of _is_driver_compatible *if* you were willing to generate a slightly more generic message in the exception. Not a big deal though. Maybe the slightly more specific message makes it worth it.","commit_id":"95b0db285f3d1d144c2c6554004dbcd489e07fc5"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"68b52d06b845fe75ef3cf45490560e96216e2eba","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        drv \u003d self._get_provider_for_router(context, router_id)"},{"line_number":101,"context_line":"        new_drv \u003d None"},{"line_number":102,"context_line":"        if _flavor_specified(router):"},{"line_number":103,"context_line":"            if router[\u0027flavor_id\u0027] !\u003d old_router[\u0027flavor_id\u0027]:"},{"line_number":104,"context_line":"                # TODO(kevinbenton): this is currently disallowed by the API"},{"line_number":105,"context_line":"                # so we shouldn\u0027t hit it but this is a placeholder to add"},{"line_number":106,"context_line":"                # support later."}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_d7e0f4fc","line":103,"updated":"2016-07-28 21:44:53.000000000","message":"This was the most important thing I wanted to see fixed. Thanks.","commit_id":"0e3f4b833502d0f501cfc3dd384642e46a3bf78a"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"68b52d06b845fe75ef3cf45490560e96216e2eba","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                # TODO(kevinbenton): this is currently disallowed by the API"},{"line_number":105,"context_line":"                # so we shouldn\u0027t hit it but this is a placeholder to add"},{"line_number":106,"context_line":"                # support later."},{"line_number":107,"context_line":"                raise NotImplementedError()"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        # the following is to support updating the \u0027ha\u0027 and \u0027distributed\u0027"},{"line_number":110,"context_line":"        # attributes via the API."}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_3cd21701","line":107,"updated":"2016-07-28 21:44:53.000000000","message":"I like it, this makes it very hard to misinterpret.","commit_id":"0e3f4b833502d0f501cfc3dd384642e46a3bf78a"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"68b52d06b845fe75ef3cf45490560e96216e2eba","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                # support later."},{"line_number":107,"context_line":"                raise NotImplementedError()"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        # the following is to support updating the \u0027ha\u0027 and \u0027distributed\u0027"},{"line_number":110,"context_line":"        # attributes via the API."},{"line_number":111,"context_line":"        try:"},{"line_number":112,"context_line":"            _ensure_driver_supports_request(drv, router)"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_3c8a17c0","line":109,"updated":"2016-07-28 21:44:53.000000000","message":"I do like the way this flows a little better than PS11.","commit_id":"0e3f4b833502d0f501cfc3dd384642e46a3bf78a"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"68b52d06b845fe75ef3cf45490560e96216e2eba","unresolved":false,"context_lines":[{"line_number":208,"context_line":""},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"def _is_driver_compatible(distributed, ha, driver):"},{"line_number":211,"context_line":"    if not driver.distributed_support.is_compatible(distributed):"},{"line_number":212,"context_line":"        return False"},{"line_number":213,"context_line":"    if not driver.ha_support.is_compatible(ha):"},{"line_number":214,"context_line":"        return False"},{"line_number":215,"context_line":"    return True"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"def _is_distributed(distributed_attr):"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_1c73d3e8","line":215,"range":{"start_line":211,"start_character":4,"end_line":215,"end_character":15},"updated":"2016-07-28 21:44:53.000000000","message":"Now its just:\n\n  return (driver.distributed_support.is_compatible(ha) and\n          driver.distributed_support.is_compatible(distributed)\n\nBut, this is not a -1. Just an observation you could act on if you had the chance and you wanted to.","commit_id":"0e3f4b833502d0f501cfc3dd384642e46a3bf78a"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"bf1a2411f689d0c72f1ddf8483f5d8b54ff57ce1","unresolved":false,"context_lines":[{"line_number":208,"context_line":""},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"def _is_driver_compatible(distributed, ha, driver):"},{"line_number":211,"context_line":"    if not driver.distributed_support.is_compatible(distributed):"},{"line_number":212,"context_line":"        return False"},{"line_number":213,"context_line":"    if not driver.ha_support.is_compatible(ha):"},{"line_number":214,"context_line":"        return False"},{"line_number":215,"context_line":"    return True"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"def _is_distributed(distributed_attr):"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_ff44ee1b","line":215,"range":{"start_line":211,"start_character":4,"end_line":215,"end_character":15},"in_reply_to":"bacf61ea_1c73d3e8","updated":"2016-07-28 22:40:50.000000000","message":"that does look nicer. maybe if i\u0027m mucking around in here another time i\u0027ll swap it out.","commit_id":"0e3f4b833502d0f501cfc3dd384642e46a3bf78a"}],"neutron/services/l3_router/service_providers/dvr.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"68b52d06b845fe75ef3cf45490560e96216e2eba","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class DvrDriver(base.L3ServiceProvider):"},{"line_number":19,"context_line":"    distributed_support \u003d base.MANDATORY"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_9cf1836d","line":19,"range":{"start_line":19,"start_character":4,"end_line":19,"end_character":40},"updated":"2016-07-28 21:44:53.000000000","message":"While it took a little bit of extra code up front, this is pretty easy to read at a mere glance. I\u0027d say it is an overall improvement. But, I wouldn\u0027t have required it. :)","commit_id":"0e3f4b833502d0f501cfc3dd384642e46a3bf78a"}]}
