)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"4c14d05e115411536f2a9e85bef049de3223aa9a","unresolved":false,"context_lines":[{"line_number":13,"context_line":" * Agent has fetched all active networks"},{"line_number":14,"context_line":" * Agent configure a network start and finish"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Related-Bug: 1535285"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I517073e4a9a7a870cbbfd8cb0e14a7571176f562"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba63e191_84c4a940","line":16,"updated":"2016-01-19 03:23:40.000000000","message":"If you intend to resolve the bug, you should use Closes-Bug: #1535285","commit_id":"14841094a185e84050ccedf7ed8ade54d1bd902b"}],"neutron/agent/dhcp/agent.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"100347dbf6ecf3e5ce5d84583c95495db3150ce7","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def call_driver(self, action, network, **action_kwargs):"},{"line_number":102,"context_line":"        \"\"\"Invoke an action on a DHCP driver instance.\"\"\""},{"line_number":103,"context_line":"        LOG.info(\u0027Calling driver for network: %(net)s action: %(action)s\u0027,"},{"line_number":104,"context_line":"                 {\u0027net\u0027: network.id, \u0027action\u0027: action})"},{"line_number":105,"context_line":"        try:"},{"line_number":106,"context_line":"            # the Driver expects something that is duck typed similar to"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_a0f96cca","line":103,"range":{"start_line":103,"start_character":8,"end_line":103,"end_character":16},"updated":"2016-01-18 13:45:09.000000000","message":"Why did you change the log level? Could you add the explanation into Commit Message?","commit_id":"4aa4b0391f7a2ae4e70f08a7d66ebd577610b051"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"29dcce8d0cee158dd93c900f55fdccaa1e5c20e0","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        try:"},{"line_number":155,"context_line":"            active_networks \u003d self.plugin_rpc.get_active_networks_info()"},{"line_number":156,"context_line":"            LOG.info(_LI(\u0027All active networks have been got through RPC.\u0027))"},{"line_number":157,"context_line":"            active_network_ids \u003d set(network.id for network in active_networks)"},{"line_number":158,"context_line":"            for deleted_id in known_network_ids - active_network_ids:"},{"line_number":159,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_a60c2443","line":156,"range":{"start_line":156,"start_character":46,"end_line":156,"end_character":59},"updated":"2016-01-18 14:11:31.000000000","message":"have been got? shouldn\u0027t it be \u0027have been received or fetched\u0027? sounds a lot easier...","commit_id":"6db5cb051acf11ec7466b4bc9d8db63328734165"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"997417998b013e68e7516ac5790e0dfb25825ba6","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        try:"},{"line_number":155,"context_line":"            active_networks \u003d self.plugin_rpc.get_active_networks_info()"},{"line_number":156,"context_line":"            LOG.info(_LI(\u0027All active networks have been fetched through RPC.\u0027))"},{"line_number":157,"context_line":"            active_network_ids \u003d set(network.id for network in active_networks)"},{"line_number":158,"context_line":"            for deleted_id in known_network_ids - active_network_ids:"},{"line_number":159,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba63e191_694b93b1","line":156,"range":{"start_line":156,"start_character":12,"end_line":156,"end_character":79},"updated":"2016-01-19 01:07:07.000000000","message":"I don\u0027t think that we need this log because we can get failure log \"Unable to sync network state.\" if get_active_networks_info() fails.","commit_id":"14841094a185e84050ccedf7ed8ade54d1bd902b"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"4c14d05e115411536f2a9e85bef049de3223aa9a","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        try:"},{"line_number":155,"context_line":"            active_networks \u003d self.plugin_rpc.get_active_networks_info()"},{"line_number":156,"context_line":"            LOG.info(_LI(\u0027All active networks have been fetched through RPC.\u0027))"},{"line_number":157,"context_line":"            active_network_ids \u003d set(network.id for network in active_networks)"},{"line_number":158,"context_line":"            for deleted_id in known_network_ids - active_network_ids:"},{"line_number":159,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba63e191_e4d805f2","line":156,"range":{"start_line":156,"start_character":12,"end_line":156,"end_character":79},"in_reply_to":"ba63e191_61d5e741","updated":"2016-01-19 03:23:40.000000000","message":"I kind of agree with Hirofumi. In the configure procedure, if we got exception, extra log will be printed at line 163 and line 227. Can you elaborate in which case sync network successes, but configure fails, meanwhile, there is no extra log besides line 180.","commit_id":"14841094a185e84050ccedf7ed8ade54d1bd902b"},{"author":{"_account_id":17523,"name":"yaowei","email":"yaowei@unitedstack.com","username":"yaowei"},"change_message_id":"f7c574ba7a68279c8ee1c3ac2de9420404a4ee00","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        try:"},{"line_number":155,"context_line":"            active_networks \u003d self.plugin_rpc.get_active_networks_info()"},{"line_number":156,"context_line":"            LOG.info(_LI(\u0027All active networks have been fetched through RPC.\u0027))"},{"line_number":157,"context_line":"            active_network_ids \u003d set(network.id for network in active_networks)"},{"line_number":158,"context_line":"            for deleted_id in known_network_ids - active_network_ids:"},{"line_number":159,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba63e191_61d5e741","line":156,"range":{"start_line":156,"start_character":12,"end_line":156,"end_character":79},"in_reply_to":"ba63e191_694b93b1","updated":"2016-01-19 02:26:40.000000000","message":"The log is to distinguish rpc procedure from configure network procedure. get_active_networks_info() may cost lots of time when networks\u0027 number is large. With this log we can easily pinpoint performance problem.","commit_id":"14841094a185e84050ccedf7ed8ade54d1bd902b"},{"author":{"_account_id":9911,"name":"Wei Wang","email":"wangwei@unitedstack.com","username":"DamonWang"},"change_message_id":"a8895bae8788ae5f7f8a981d8b9622d09ba2794d","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        try:"},{"line_number":155,"context_line":"            active_networks \u003d self.plugin_rpc.get_active_networks_info()"},{"line_number":156,"context_line":"            LOG.info(_LI(\u0027All active networks have been fetched through RPC.\u0027))"},{"line_number":157,"context_line":"            active_network_ids \u003d set(network.id for network in active_networks)"},{"line_number":158,"context_line":"            for deleted_id in known_network_ids - active_network_ids:"},{"line_number":159,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba63e191_d73c9131","line":156,"range":{"start_line":156,"start_character":12,"end_line":156,"end_character":79},"in_reply_to":"ba63e191_e4d805f2","updated":"2016-01-19 03:49:37.000000000","message":"The problem is that when you restart dhcp-agent which configure thousands networks, you will get silence of dhcp-agent for more than 20 mins, it\u0027s really bad for ops. more logs will show what dhcp-agent is doing.\n\nFor example, an op is restarting dhcp-agent for some reason, he can\u0027t get any output from log of dhcp-agent, he may restart again and again since he think there must something wrong. Therefore he may make situation more and more bad.\n\nLog is important to op to observe status of a process, now dhcp-agent is really short of it.","commit_id":"14841094a185e84050ccedf7ed8ade54d1bd902b"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"5bdb2e3b939f24d25097863166599d6dffe9c465","unresolved":false,"context_lines":[{"line_number":220,"context_line":"    def safe_configure_dhcp_for_network(self, network):"},{"line_number":221,"context_line":"        try:"},{"line_number":222,"context_line":"            network_id \u003d network.get(\u0027id\u0027)"},{"line_number":223,"context_line":"            LOG.info(_LI(\u0027Start configure dhcp for network %s.\u0027), network_id)"},{"line_number":224,"context_line":"            self.configure_dhcp_for_network(network)"},{"line_number":225,"context_line":"            LOG.info(_LI(\u0027Finish configure dhcp for network %s.\u0027), network_id)"},{"line_number":226,"context_line":"        except (exceptions.NetworkNotFound, RuntimeError):"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba63e191_cef950ca","line":223,"range":{"start_line":223,"start_character":21,"end_line":223,"end_character":24},"updated":"2016-01-19 10:10:47.000000000","message":"Nit/suggestion:\nAs a log message doesn\u0027t seem very coherent, we may either want to write:\n\n\"Starting configure_dhcp_for_network %s.\" but that sounds more like DEBUG,\n\nMay be \"Starting network %s dhcp configuration\"  ?","commit_id":"3a3208cb07c90d25f9b79785234c2aa826938ac6"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"5bdb2e3b939f24d25097863166599d6dffe9c465","unresolved":false,"context_lines":[{"line_number":222,"context_line":"            network_id \u003d network.get(\u0027id\u0027)"},{"line_number":223,"context_line":"            LOG.info(_LI(\u0027Start configure dhcp for network %s.\u0027), network_id)"},{"line_number":224,"context_line":"            self.configure_dhcp_for_network(network)"},{"line_number":225,"context_line":"            LOG.info(_LI(\u0027Finish configure dhcp for network %s.\u0027), network_id)"},{"line_number":226,"context_line":"        except (exceptions.NetworkNotFound, RuntimeError):"},{"line_number":227,"context_line":"            LOG.warn(_LW(\u0027Network %s may have been deleted and its resources \u0027"},{"line_number":228,"context_line":"                         \u0027may have already been disposed.\u0027), network.id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba63e191_0edd2842","line":225,"range":{"start_line":225,"start_character":24,"end_line":225,"end_character":26},"updated":"2016-01-19 10:10:47.000000000","message":"Do we need a second log for this?, may we move this extra one to DEBUG? \n\nNot enough logging is not helpful but too much is also bad.","commit_id":"3a3208cb07c90d25f9b79785234c2aa826938ac6"},{"author":{"_account_id":17523,"name":"yaowei","email":"yaowei@unitedstack.com","username":"yaowei"},"change_message_id":"266afdb11973feef612a3ae7f8fd4d4e1252d066","unresolved":false,"context_lines":[{"line_number":222,"context_line":"            network_id \u003d network.get(\u0027id\u0027)"},{"line_number":223,"context_line":"            LOG.info(_LI(\u0027Start configure dhcp for network %s.\u0027), network_id)"},{"line_number":224,"context_line":"            self.configure_dhcp_for_network(network)"},{"line_number":225,"context_line":"            LOG.info(_LI(\u0027Finish configure dhcp for network %s.\u0027), network_id)"},{"line_number":226,"context_line":"        except (exceptions.NetworkNotFound, RuntimeError):"},{"line_number":227,"context_line":"            LOG.warn(_LW(\u0027Network %s may have been deleted and its resources \u0027"},{"line_number":228,"context_line":"                         \u0027may have already been disposed.\u0027), network.id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba63e191_641723a4","line":225,"range":{"start_line":225,"start_character":24,"end_line":225,"end_character":26},"in_reply_to":"ba63e191_0edd2842","updated":"2016-01-19 11:02:39.000000000","message":"This log can help to finger out dhcp configuration procedure finished successfully.  Or some accidental cases and interrupt may not be tracked in configuration.","commit_id":"3a3208cb07c90d25f9b79785234c2aa826938ac6"},{"author":{"_account_id":20257,"name":"liujie","email":"liu.jie3@zte.com.cn","username":"liujie"},"change_message_id":"c527fe6abebe9df4d0814c43b3df678e3720cf86","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        try:"},{"line_number":155,"context_line":"            active_networks \u003d self.plugin_rpc.get_active_networks_info()"},{"line_number":156,"context_line":"            LOG.info(_LI(\u0027All active networks have been fetched through RPC.\u0027))"},{"line_number":157,"context_line":"            active_network_ids \u003d set(network.id for network in active_networks)"},{"line_number":158,"context_line":"            for deleted_id in known_network_ids - active_network_ids:"},{"line_number":159,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a68dd71_4645fe6d","line":156,"updated":"2016-01-22 07:03:07.000000000","message":"Maybe Log.debug is better","commit_id":"89ca42fef4496d9e7e12f9e8243b5d6956d90468"}]}
