)]}'
{"neutron/db/l3_db.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"b55e575b8218a94d8291fb2d4f0ed89e7a6c8041","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    floating_port_id \u003d sa.Column(sa.String(36),"},{"line_number":112,"context_line":"                                 sa.ForeignKey(\u0027ports.id\u0027, ondelete\u003d\"CASCADE\"),"},{"line_number":113,"context_line":"                                 nullable\u003dFalse)"},{"line_number":114,"context_line":"    port \u003d orm.relationship(models_v2.Port,"},{"line_number":115,"context_line":"                            backref\u003dorm.backref(\u0027floating_ips\u0027,"},{"line_number":116,"context_line":"                                                cascade\u003d\u0027all,delete-orphan\u0027),"},{"line_number":117,"context_line":"                            foreign_keys\u003d\u0027FloatingIP.floating_port_id\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_5c20d949","line":114,"updated":"2016-01-20 14:02:11.000000000","message":"please add a comment describing why is this relationship needed","commit_id":"803fd050444780c92c12066e2adf055648326176"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"f9f06cb85f5c760cb17bef2b86e458e9e714a025","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    floating_port_id \u003d sa.Column(sa.String(36),"},{"line_number":112,"context_line":"                                 sa.ForeignKey(\u0027ports.id\u0027, ondelete\u003d\"CASCADE\"),"},{"line_number":113,"context_line":"                                 nullable\u003dFalse)"},{"line_number":114,"context_line":"    port \u003d orm.relationship(models_v2.Port,"},{"line_number":115,"context_line":"                            backref\u003dorm.backref(\u0027floating_ips\u0027,"},{"line_number":116,"context_line":"                                                cascade\u003d\u0027all,delete-orphan\u0027),"},{"line_number":117,"context_line":"                            foreign_keys\u003d\u0027FloatingIP.floating_port_id\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_d3598036","line":114,"in_reply_to":"9a68dd71_5c20d949","updated":"2016-01-22 21:55:43.000000000","message":"Thanks for review, Oleg. I will add comment in the next PS.","commit_id":"803fd050444780c92c12066e2adf055648326176"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"1db46b4b355af37f91c2f560f8a6bca3dc47ea42","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                                 nullable\u003dFalse)"},{"line_number":114,"context_line":"    port \u003d orm.relationship(models_v2.Port,"},{"line_number":115,"context_line":"                            backref\u003dorm.backref(\u0027floating_ips\u0027,"},{"line_number":116,"context_line":"                                                cascade\u003d\u0027all,delete-orphan\u0027),"},{"line_number":117,"context_line":"                            foreign_keys\u003d\u0027FloatingIP.floating_port_id\u0027)"},{"line_number":118,"context_line":"    fixed_port_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\u0027ports.id\u0027))"},{"line_number":119,"context_line":"    fixed_ip_address \u003d sa.Column(sa.String(64))"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_49822802","line":116,"updated":"2016-01-28 11:02:51.000000000","message":"Is this correct? Left as is that would mean Port *owns* FloatingIPs and removal of a port instance leads to removal all associated floating IPs. My understanding of the Neutron entities is that it\u0027s not the case here - removal of a port should only disassociate bound floating IPs, but they must stay allocated for this tenant, as he or she can use these floating IPs later for other ports.","commit_id":"803fd050444780c92c12066e2adf055648326176"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"f18aed3e66b587351bc6fc68c536ea02fa1efb72","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                                 nullable\u003dFalse)"},{"line_number":114,"context_line":"    port \u003d orm.relationship(models_v2.Port,"},{"line_number":115,"context_line":"                            backref\u003dorm.backref(\u0027floating_ips\u0027,"},{"line_number":116,"context_line":"                                                cascade\u003d\u0027all,delete-orphan\u0027),"},{"line_number":117,"context_line":"                            foreign_keys\u003d\u0027FloatingIP.floating_port_id\u0027)"},{"line_number":118,"context_line":"    fixed_port_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\u0027ports.id\u0027))"},{"line_number":119,"context_line":"    fixed_ip_address \u003d sa.Column(sa.String(64))"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_e4f9b94e","line":116,"in_reply_to":"7a5de9d1_49822802","updated":"2016-01-28 11:28:06.000000000","message":"Roman, it already works this way. See L111 and [1]. My change is only adds ORM-level \"delete\" cascade relationship.\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/db/l3_db.py#L1138","commit_id":"803fd050444780c92c12066e2adf055648326176"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"c96119a572f9a3aaf88361545fabdad4fdce1fd7","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                                 nullable\u003dFalse)"},{"line_number":114,"context_line":"    port \u003d orm.relationship(models_v2.Port,"},{"line_number":115,"context_line":"                            backref\u003dorm.backref(\u0027floating_ips\u0027,"},{"line_number":116,"context_line":"                                                cascade\u003d\u0027all,delete-orphan\u0027),"},{"line_number":117,"context_line":"                            foreign_keys\u003d\u0027FloatingIP.floating_port_id\u0027)"},{"line_number":118,"context_line":"    fixed_port_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\u0027ports.id\u0027))"},{"line_number":119,"context_line":"    fixed_ip_address \u003d sa.Column(sa.String(64))"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_d141de0c","line":116,"in_reply_to":"7a5de9d1_49822802","updated":"2016-01-28 11:52:15.000000000","message":"Seems you mixed up 2 types of ports here: fixed_port (compute port), which a floating ip is assigned to and floating_port which is \t\nancillary. When floating_port is deleted floating ip is deleted by cascade","commit_id":"803fd050444780c92c12066e2adf055648326176"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"3563d4a622424f6c2168cf07a7b84a881bfdecfe","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                                 nullable\u003dFalse)"},{"line_number":114,"context_line":"    port \u003d orm.relationship(models_v2.Port,"},{"line_number":115,"context_line":"                            backref\u003dorm.backref(\u0027floating_ips\u0027,"},{"line_number":116,"context_line":"                                                cascade\u003d\u0027all,delete-orphan\u0027),"},{"line_number":117,"context_line":"                            foreign_keys\u003d\u0027FloatingIP.floating_port_id\u0027)"},{"line_number":118,"context_line":"    fixed_port_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\u0027ports.id\u0027))"},{"line_number":119,"context_line":"    fixed_ip_address \u003d sa.Column(sa.String(64))"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_91736680","line":116,"in_reply_to":"7a5de9d1_e4f9b94e","updated":"2016-01-28 11:52:31.000000000","message":"Oh, that\u0027s a surprise for me :P","commit_id":"803fd050444780c92c12066e2adf055648326176"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"8d0d2d00b44c7b21c7217659adb915052edd9623","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                                 nullable\u003dFalse)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    # The ORM-level \"delete\" cascade relationship beetwin port and floating_ip"},{"line_number":116,"context_line":"    # is required because we need the in-Python event behavior for cascade"},{"line_number":117,"context_line":"    # removal of the floating_ip"},{"line_number":118,"context_line":"    port \u003d orm.relationship(models_v2.Port,"},{"line_number":119,"context_line":"                            backref\u003dorm.backref(\u0027floating_ips\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_475bb72e","line":116,"range":{"start_line":116,"start_character":26,"end_line":116,"end_character":33},"updated":"2016-01-29 08:36:47.000000000","message":"it doesn\u0027t says why we need (for qouta management)","commit_id":"8ea104270c319a1289b982cffe89eaad9de444a2"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"058cf5b622d37496bbb3b74a19ad0dc16669eb2d","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                                 nullable\u003dFalse)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    # The ORM-level \"delete\" cascade relationship beetwin port and floating_ip"},{"line_number":116,"context_line":"    # is required because we need the in-Python event behavior for cascade"},{"line_number":117,"context_line":"    # removal of the floating_ip"},{"line_number":118,"context_line":"    port \u003d orm.relationship(models_v2.Port,"},{"line_number":119,"context_line":"                            backref\u003dorm.backref(\u0027floating_ips\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_40163d56","line":116,"range":{"start_line":116,"start_character":26,"end_line":116,"end_character":33},"in_reply_to":"7a5de9d1_475bb72e","updated":"2016-01-29 09:33:52.000000000","message":"Done","commit_id":"8ea104270c319a1289b982cffe89eaad9de444a2"}],"neutron/tests/unit/extensions/test_l3.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"b55e575b8218a94d8291fb2d4f0ed89e7a6c8041","unresolved":false,"context_lines":[{"line_number":2986,"context_line":"                                                      \u0027floatingips\u0027)"},{"line_number":2987,"context_line":""},{"line_number":2988,"context_line":""},{"line_number":2989,"context_line":"class TestFloatingIPResourcesEventHandler(L3NatTestCaseMixin,"},{"line_number":2990,"context_line":"                                          ml2_base.ML2TestFramework):"},{"line_number":2991,"context_line":""},{"line_number":2992,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_9cb3b10a","line":2989,"range":{"start_line":2989,"start_character":10,"end_line":2989,"end_character":20},"updated":"2016-01-20 14:02:11.000000000","message":"L3Resources? Routers can be added there later","commit_id":"803fd050444780c92c12066e2adf055648326176"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"f9f06cb85f5c760cb17bef2b86e458e9e714a025","unresolved":false,"context_lines":[{"line_number":2986,"context_line":"                                                      \u0027floatingips\u0027)"},{"line_number":2987,"context_line":""},{"line_number":2988,"context_line":""},{"line_number":2989,"context_line":"class TestFloatingIPResourcesEventHandler(L3NatTestCaseMixin,"},{"line_number":2990,"context_line":"                                          ml2_base.ML2TestFramework):"},{"line_number":2991,"context_line":""},{"line_number":2992,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_736a14b5","line":2989,"range":{"start_line":2989,"start_character":10,"end_line":2989,"end_character":20},"in_reply_to":"9a68dd71_9cb3b10a","updated":"2016-01-22 21:55:43.000000000","message":"Good idea. Will rename it.","commit_id":"803fd050444780c92c12066e2adf055648326176"}],"neutron/tests/unit/plugins/ml2/test_tracked_resources.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"8d0d2d00b44c7b21c7217659adb915052edd9623","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                                  BaseTestEventHandler):"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def setUp(self):"},{"line_number":163,"context_line":"        handler_patch \u003d mock.patch("},{"line_number":164,"context_line":"            \u0027neutron.quota.resource.TrackedResource._db_event_handler\u0027)"},{"line_number":165,"context_line":"        self.handler_mock \u003d handler_patch.start()"},{"line_number":166,"context_line":"        super(TestL3ResourcesEventHandler, self).setUp()"},{"line_number":167,"context_line":"        ext_mgr \u003d test_l3.L3TestExtensionManager()"},{"line_number":168,"context_line":"        self.ext_api \u003d test_extensions.setup_extensions_middleware(ext_mgr)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_8aa536b6","line":165,"range":{"start_line":163,"start_character":8,"end_line":165,"end_character":49},"updated":"2016-01-29 08:36:47.000000000","message":"can we get rid of this duplication?","commit_id":"8ea104270c319a1289b982cffe89eaad9de444a2"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"058cf5b622d37496bbb3b74a19ad0dc16669eb2d","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                                  BaseTestEventHandler):"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def setUp(self):"},{"line_number":163,"context_line":"        handler_patch \u003d mock.patch("},{"line_number":164,"context_line":"            \u0027neutron.quota.resource.TrackedResource._db_event_handler\u0027)"},{"line_number":165,"context_line":"        self.handler_mock \u003d handler_patch.start()"},{"line_number":166,"context_line":"        super(TestL3ResourcesEventHandler, self).setUp()"},{"line_number":167,"context_line":"        ext_mgr \u003d test_l3.L3TestExtensionManager()"},{"line_number":168,"context_line":"        self.ext_api \u003d test_extensions.setup_extensions_middleware(ext_mgr)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_db42223e","line":165,"range":{"start_line":163,"start_character":8,"end_line":165,"end_character":49},"in_reply_to":"7a5de9d1_8aa536b6","updated":"2016-01-29 09:33:52.000000000","message":"Done","commit_id":"8ea104270c319a1289b982cffe89eaad9de444a2"}]}
