)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"bc0ebb41cb65626b8bfa77604f9a410b6cd1ed02","unresolved":false,"context_lines":[{"line_number":7,"context_line":"WIP Network OVO"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Introducing the Network OVO and it usage for DHCP get_active_networks_info."},{"line_number":10,"context_line":"This patch is dependend on Subnet OVO patch."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5160d0ab9e8042c356229420739db0ce42842368"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a5de9d1_b17b5ebd","line":10,"range":{"start_line":10,"start_character":14,"end_line":10,"end_character":23},"updated":"2016-02-01 19:42:36.000000000","message":"dependent or depends","commit_id":"440c9c5c4dc1532bc6eaaa5d43eb31b2770d9499"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"2b635fa96766b80e755bd443b10550d2d84a9eb0","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Segments are part of the network object. Since we need to reduce the"},{"line_number":14,"context_line":"number of SQL queries executed per resource, and we want to include"},{"line_number":15,"context_line":"segmentation information for networks, Network model was extended with"},{"line_number":16,"context_line":"segments relationship that makes the infromation available on every"},{"line_number":17,"context_line":"network resource fetch from the database."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This implementation of the object is not complete for the job of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"1ac06dbe_c453536b","line":16,"range":{"start_line":16,"start_character":37,"end_line":16,"end_character":48},"updated":"2016-08-25 00:17:06.000000000","message":"nit: s/infromation/information/","commit_id":"5c0ab20f2b452d434190cc589185f06df336ca72"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c8e78f3feb3a89d0cc84006b767743d10c2b3e7e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Segments are part of the network object. Since we need to reduce the"},{"line_number":14,"context_line":"number of SQL queries executed per resource, and we want to include"},{"line_number":15,"context_line":"segmentation information for networks, Network model was extended with"},{"line_number":16,"context_line":"segments relationship that makes the infromation available on every"},{"line_number":17,"context_line":"network resource fetch from the database."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This implementation of the object is not complete for the job of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"1ac06dbe_373ebbda","line":16,"range":{"start_line":16,"start_character":37,"end_line":16,"end_character":48},"in_reply_to":"1ac06dbe_c453536b","updated":"2016-08-25 10:15:19.000000000","message":"Done","commit_id":"5c0ab20f2b452d434190cc589185f06df336ca72"}],"neutron/api/rpc/handlers/dhcp_rpc.py":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"bce6c7602f0f91b09fa9b889ba35d97938dc2026","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                context, host)"},{"line_number":78,"context_line":"        else:"},{"line_number":79,"context_line":"            filters \u003d dict(admin_state_up\u003d[True])"},{"line_number":80,"context_line":"            nets \u003d Network.get_networks(context, filters\u003dfilters)"},{"line_number":81,"context_line":"        return nets"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def _port_action(self, plugin, context, port, action):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_de2d17a9","line":80,"updated":"2016-01-29 18:35:35.000000000","message":"get_objects?","commit_id":"440c9c5c4dc1532bc6eaaa5d43eb31b2770d9499"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"bce6c7602f0f91b09fa9b889ba35d97938dc2026","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        LOG.debug(\u0027Network %(network_id)s requested from \u0027"},{"line_number":143,"context_line":"                  \u0027%(host)s\u0027, {\u0027network_id\u0027: network_id,"},{"line_number":144,"context_line":"                               \u0027host\u0027: host})"},{"line_number":145,"context_line":"        network \u003d Network.get_network_by_id(context, network_id)"},{"line_number":146,"context_line":"        LOG.debug(\"Networks OVO objects {0}\".format(network))"},{"line_number":147,"context_line":"        return network"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_7e150347","line":145,"updated":"2016-01-29 18:35:35.000000000","message":"get_by_id ?","commit_id":"440c9c5c4dc1532bc6eaaa5d43eb31b2770d9499"}],"neutron/db/api.py":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"bce6c7602f0f91b09fa9b889ba35d97938dc2026","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                .all())"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"def get_networks(context, **kwargs):"},{"line_number":97,"context_line":"    # TODO(korzen): fill in the network get logic"},{"line_number":98,"context_line":"    pass"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_1e288f99","line":96,"updated":"2016-01-29 18:35:35.000000000","message":"you don\u0027t need this, you should call get_objects on the Network object","commit_id":"440c9c5c4dc1532bc6eaaa5d43eb31b2770d9499"}],"neutron/objects/network.py":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"bce6c7602f0f91b09fa9b889ba35d97938dc2026","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        return grouped"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    @classmethod"},{"line_number":77,"context_line":"    def get_network_by_id(cls, context, network_id):"},{"line_number":78,"context_line":"        plugin \u003d manager.NeutronManager.get_plugin()"},{"line_number":79,"context_line":"        try:"},{"line_number":80,"context_line":"            network \u003d plugin.get_network(context, network_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_9976d9a2","line":77,"updated":"2016-01-29 18:35:35.000000000","message":"get_by_id","commit_id":"440c9c5c4dc1532bc6eaaa5d43eb31b2770d9499"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"bce6c7602f0f91b09fa9b889ba35d97938dc2026","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    def get_network_by_id(cls, context, network_id):"},{"line_number":78,"context_line":"        plugin \u003d manager.NeutronManager.get_plugin()"},{"line_number":79,"context_line":"        try:"},{"line_number":80,"context_line":"            network \u003d plugin.get_network(context, network_id)"},{"line_number":81,"context_line":"        except n_exc.NetworkNotFound:"},{"line_number":82,"context_line":"            LOG.warn(_LW(\"Network %s could not be found, it might have \""},{"line_number":83,"context_line":"                         \"been deleted concurrently.\"), network_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_19b2e94c","line":80,"updated":"2016-01-29 18:35:35.000000000","message":"we shouldn\u0027t use plugin methods but use db_api","commit_id":"440c9c5c4dc1532bc6eaaa5d43eb31b2770d9499"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"bce6c7602f0f91b09fa9b889ba35d97938dc2026","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        return Network(context, **network)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @classmethod"},{"line_number":91,"context_line":"    def get_networks(cls, context, filters\u003dNone):"},{"line_number":92,"context_line":"        plugin \u003d manager.NeutronManager.get_plugin()"},{"line_number":93,"context_line":"        nets \u003d plugin.get_networks(context, filters\u003dfilters)"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_b9895577","line":91,"updated":"2016-01-29 18:35:35.000000000","message":"get_objects","commit_id":"440c9c5c4dc1532bc6eaaa5d43eb31b2770d9499"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"bce6c7602f0f91b09fa9b889ba35d97938dc2026","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    @classmethod"},{"line_number":91,"context_line":"    def get_networks(cls, context, filters\u003dNone):"},{"line_number":92,"context_line":"        plugin \u003d manager.NeutronManager.get_plugin()"},{"line_number":93,"context_line":"        nets \u003d plugin.get_networks(context, filters\u003dfilters)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        LOG.debug(\"Networks DB data: {0}\".format(nets))"},{"line_number":96,"context_line":"        filters \u003d {\u0027network_id\u0027: [network[\u0027id\u0027] for network in nets]}"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_f98b4d66","line":93,"updated":"2016-01-29 18:35:35.000000000","message":"ditto...no plugin methods","commit_id":"440c9c5c4dc1532bc6eaaa5d43eb31b2770d9499"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a1f5e7e28229a405a14b809631b727606ae06172","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    primary_keys \u003d [\u0027network_id\u0027, \u0027dhcp_agent_id\u0027]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    # foreign_keys \u003d {\u0027network_id\u0027: \u0027id\u0027, \u0027dhcp_agent_id\u0027: \u0027id\u0027}"},{"line_number":42,"context_line":"    foreign_keys \u003d {\u0027network_id\u0027: \u0027id\u0027}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"@obj_base.VersionedObjectRegistry.register"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_2abd73b7","line":42,"range":{"start_line":41,"start_character":0,"end_line":42,"end_character":39},"updated":"2016-05-10 08:13:11.000000000","message":"The commented line is the correct one.","commit_id":"4ba4ca46d1dda08f4c1d1666a7de508a35e4ccd0"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"a8884d60cf274f29ed8b12e54f19edd8cf9ccc0d","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    primary_keys \u003d [\u0027network_id\u0027, \u0027dhcp_agent_id\u0027]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    # foreign_keys \u003d {\u0027network_id\u0027: \u0027id\u0027, \u0027dhcp_agent_id\u0027: \u0027id\u0027}"},{"line_number":42,"context_line":"    foreign_keys \u003d {\u0027network_id\u0027: \u0027id\u0027}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"@obj_base.VersionedObjectRegistry.register"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_74b8f9c8","line":42,"range":{"start_line":41,"start_character":0,"end_line":42,"end_character":39},"in_reply_to":"dab17558_2abd73b7","updated":"2016-05-10 08:56:32.000000000","message":"Rodolfo, currently we do not support multiple foreign keys in object base class. Do you see use case for the commented line? If yes, the we need to reevaluate the the load_synthetic_fields in [1]\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/objects/base.py#L313","commit_id":"4ba4ca46d1dda08f4c1d1666a7de508a35e4ccd0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fbc94efbde0c1dd3910f774940a2c03a1e9d2b04","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    primary_keys \u003d [\u0027network_id\u0027, \u0027dhcp_agent_id\u0027]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    # foreign_keys \u003d {\u0027network_id\u0027: \u0027id\u0027, \u0027dhcp_agent_id\u0027: \u0027id\u0027}"},{"line_number":42,"context_line":"    foreign_keys \u003d {\u0027network_id\u0027: \u0027id\u0027}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"@obj_base.VersionedObjectRegistry.register"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_ae7680a1","line":42,"range":{"start_line":41,"start_character":0,"end_line":42,"end_character":39},"in_reply_to":"dab17558_74b8f9c8","updated":"2016-05-10 13:10:11.000000000","message":"You are right, I didn\u0027t see this condition.\n\nBut this table is a view of two fields which are foreign keys. So maybe this change is needed.\n\nNow I see your comments: https://review.openstack.org/#/c/283711/4/neutron/objects/base.py","commit_id":"4ba4ca46d1dda08f4c1d1666a7de508a35e4ccd0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"50caa03d3375f7d8ea27475d10c7c2e85d7d7c81","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        \u0027dhcp_agents\u0027: obj_fields.ObjectField(\u0027NetworkDhcpAgentBinding\u0027,"},{"line_number":70,"context_line":"                                              nullable\u003dTrue)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        # extension fields:"},{"line_number":73,"context_line":"        # TODO(korzen) Fields to be considered:"},{"line_number":74,"context_line":"        # \u0027availability_zones\u0027: obj_fields.ListOfStringsField(),"},{"line_number":75,"context_line":"        # \u0027router:external\u0027: obj_fields.BooleanField(),"},{"line_number":76,"context_line":"        # \u0027shared\u0027: obj_fields.BooleanField(),"},{"line_number":77,"context_line":"        # \u0027port_security_enabled\u0027: obj_fields.BooleanField(),"},{"line_number":78,"context_line":"        # \u0027provider:network_type\u0027: obj_fields.StringField(),"},{"line_number":79,"context_line":"        # \u0027provider:segmentation_id\u0027: obj_fields.IntegerField(),"},{"line_number":80,"context_line":"        # \u0027provider:physical_network\u0027: obj_fields.StringField(nullable\u003dTrue)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    }"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_c3c92d5b","line":80,"range":{"start_line":72,"start_character":7,"end_line":80,"end_character":76},"updated":"2016-05-10 08:14:05.000000000","message":"Where does it come from?","commit_id":"4ba4ca46d1dda08f4c1d1666a7de508a35e4ccd0"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"7dd7bbd28027c2bcf3805e9b364d5e94effe3a0c","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        \u0027dhcp_agents\u0027: obj_fields.ObjectField(\u0027NetworkDhcpAgentBinding\u0027,"},{"line_number":70,"context_line":"                                              nullable\u003dTrue)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        # extension fields:"},{"line_number":73,"context_line":"        # TODO(korzen) Fields to be considered:"},{"line_number":74,"context_line":"        # \u0027availability_zones\u0027: obj_fields.ListOfStringsField(),"},{"line_number":75,"context_line":"        # \u0027router:external\u0027: obj_fields.BooleanField(),"},{"line_number":76,"context_line":"        # \u0027shared\u0027: obj_fields.BooleanField(),"},{"line_number":77,"context_line":"        # \u0027port_security_enabled\u0027: obj_fields.BooleanField(),"},{"line_number":78,"context_line":"        # \u0027provider:network_type\u0027: obj_fields.StringField(),"},{"line_number":79,"context_line":"        # \u0027provider:segmentation_id\u0027: obj_fields.IntegerField(),"},{"line_number":80,"context_line":"        # \u0027provider:physical_network\u0027: obj_fields.StringField(nullable\u003dTrue)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    }"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_1451add8","line":80,"range":{"start_line":72,"start_character":7,"end_line":80,"end_character":76},"in_reply_to":"dab17558_c3c92d5b","updated":"2016-05-10 08:52:12.000000000","message":"This fields were taken from DHCP RPC message between neutron-server and dhcp-agent.","commit_id":"4ba4ca46d1dda08f4c1d1666a7de508a35e4ccd0"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"af049df565ce6bd172ec18b2d40bade70fa42cab","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        \u0027security\u0027: \u0027port_security\u0027,"},{"line_number":114,"context_line":"    }"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def create(self):"},{"line_number":117,"context_line":"        fields \u003d self.obj_get_changes()"},{"line_number":118,"context_line":"        with db_api.autonested_transaction(self.obj_context.session):"},{"line_number":119,"context_line":"            dns_domain \u003d self.dns_domain"}],"source_content_type":"text/x-python","patch_set":14,"id":"3ac371cc_7cf83de6","line":116,"updated":"2016-08-15 13:47:45.000000000","message":"This function and the following one looks very much alike, aside from the create/update difference.","commit_id":"59f6be0dc72844e962496598dc6681d71a83f07b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a5c8679971991db763642485c882be013476c9a3","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        \u0027security\u0027: \u0027port_security\u0027,"},{"line_number":114,"context_line":"    }"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def create(self):"},{"line_number":117,"context_line":"        fields \u003d self.obj_get_changes()"},{"line_number":118,"context_line":"        with db_api.autonested_transaction(self.obj_context.session):"},{"line_number":119,"context_line":"            dns_domain \u003d self.dns_domain"}],"source_content_type":"text/x-python","patch_set":14,"id":"3ac371cc_cee8897f","line":116,"in_reply_to":"3ac371cc_7cf83de6","updated":"2016-08-15 17:23:54.000000000","message":"That\u0027s a feature. I don\u0027t think it\u0027s asking for deduplication at the point when it\u0027s just a single call to set_dns_domain that you would hide (note that I would still need to extract it separately for each code path).","commit_id":"59f6be0dc72844e962496598dc6681d71a83f07b"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"af049df565ce6bd172ec18b2d40bade70fa42cab","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            self.obj_reset_changes([\u0027dns_domain\u0027])"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    @classmethod"},{"line_number":147,"context_line":"    def modify_fields_from_db(cls, db_obj):"},{"line_number":148,"context_line":"        result \u003d super(Network, cls).modify_fields_from_db(db_obj)"},{"line_number":149,"context_line":"        if az_ext.AZ_HINTS in result:"},{"line_number":150,"context_line":"            result[az_ext.AZ_HINTS] \u003d ("}],"source_content_type":"text/x-python","patch_set":14,"id":"3ac371cc_fce42d3c","line":147,"updated":"2016-08-15 13:47:45.000000000","message":"Likewise, only \u0027from_db\u0027 and \u0027to_db\u0027","commit_id":"59f6be0dc72844e962496598dc6681d71a83f07b"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"5c1d605976c66d9be9e518811fadb97d902a773b","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            self.obj_reset_changes([\u0027dns_domain\u0027])"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    @classmethod"},{"line_number":147,"context_line":"    def modify_fields_from_db(cls, db_obj):"},{"line_number":148,"context_line":"        result \u003d super(Network, cls).modify_fields_from_db(db_obj)"},{"line_number":149,"context_line":"        if az_ext.AZ_HINTS in result:"},{"line_number":150,"context_line":"            result[az_ext.AZ_HINTS] \u003d ("}],"source_content_type":"text/x-python","patch_set":14,"id":"3ac371cc_61032d0e","line":147,"in_reply_to":"3ac371cc_0e8aa1bf","updated":"2016-08-16 16:08:05.000000000","message":"I missed that one.","commit_id":"59f6be0dc72844e962496598dc6681d71a83f07b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a5c8679971991db763642485c882be013476c9a3","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            self.obj_reset_changes([\u0027dns_domain\u0027])"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    @classmethod"},{"line_number":147,"context_line":"    def modify_fields_from_db(cls, db_obj):"},{"line_number":148,"context_line":"        result \u003d super(Network, cls).modify_fields_from_db(db_obj)"},{"line_number":149,"context_line":"        if az_ext.AZ_HINTS in result:"},{"line_number":150,"context_line":"            result[az_ext.AZ_HINTS] \u003d ("}],"source_content_type":"text/x-python","patch_set":14,"id":"3ac371cc_0e8aa1bf","line":147,"in_reply_to":"3ac371cc_fce42d3c","updated":"2016-08-15 17:23:54.000000000","message":"No. Don\u0027t you see that those are different functions called? az_list_to_string vs. az_stirng_to_list.","commit_id":"59f6be0dc72844e962496598dc6681d71a83f07b"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"58206215fea420809b1f3d9e97554c56c6a7f82c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"3ac371cc_0ff731f6","updated":"2016-08-15 22:50:23.000000000","message":"I don\u0027t see any reason to keep External network out of this, inorder to consolidate all objects related to network in one place. please correct me if there is any ?","commit_id":"ea70df4834827eb94c73f1816fc54b2ea6edf7fe"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f7f409814768b33768d62cfbc6a2639965a97646","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"3ac371cc_bd47284a","in_reply_to":"3ac371cc_0ff731f6","updated":"2016-08-16 07:20:53.000000000","message":"The only reason is to deliver what\u0027s needed for push-notifications asap. We can always add support for that on top, but I don\u0027t think that push-notifications will benefit from it, so it\u0027s out of the patch.","commit_id":"ea70df4834827eb94c73f1816fc54b2ea6edf7fe"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"58206215fea420809b1f3d9e97554c56c6a7f82c","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"@obj_base.VersionedObjectRegistry.register"},{"line_number":54,"context_line":"class NetworkPortSecurity(base_ps._PortSecurity):"},{"line_number":55,"context_line":"    # Version 1.0: Initial version"},{"line_number":56,"context_line":"    VERSION \u003d \"1.0\""},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"3ac371cc_109d9365","line":54,"range":{"start_line":54,"start_character":6,"end_line":54,"end_character":25},"updated":"2016-08-15 22:50:23.000000000","message":"any particular reason behind having different object name than model ?","commit_id":"ea70df4834827eb94c73f1816fc54b2ea6edf7fe"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f7f409814768b33768d62cfbc6a2639965a97646","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"@obj_base.VersionedObjectRegistry.register"},{"line_number":54,"context_line":"class NetworkPortSecurity(base_ps._PortSecurity):"},{"line_number":55,"context_line":"    # Version 1.0: Initial version"},{"line_number":56,"context_line":"    VERSION \u003d \"1.0\""},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"3ac371cc_9d4cec43","line":54,"range":{"start_line":54,"start_character":6,"end_line":54,"end_character":25},"in_reply_to":"3ac371cc_109d9365","updated":"2016-08-16 07:20:53.000000000","message":"Well, not *really* but I mildly feel that binding is a database thing, and what we care about in terms of objects is whether port is provided with \u0027security\u0027. Honestly, in the future I would just squash models as you suggested below, and then convert the field to boolean and forget about it.","commit_id":"ea70df4834827eb94c73f1816fc54b2ea6edf7fe"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"58206215fea420809b1f3d9e97554c56c6a7f82c","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        # TODO(ihrachys): consider exposing availability zones"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        # TODO(ihrachys): consider converting to boolean"},{"line_number":89,"context_line":"        \u0027security\u0027: obj_fields.ObjectField("},{"line_number":90,"context_line":"            \u0027NetworkPortSecurity\u0027, nullable\u003dTrue),"},{"line_number":91,"context_line":"        \u0027segments\u0027: obj_fields.ListOfObjectsField("},{"line_number":92,"context_line":"            \u0027NetworkSegment\u0027, nullable\u003dTrue),"},{"line_number":93,"context_line":"        \u0027dns_domain\u0027: common_types.DomainNameField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":15,"id":"3ac371cc_10563329","line":90,"range":{"start_line":89,"start_character":8,"end_line":90,"end_character":50},"updated":"2016-08-15 22:50:23.000000000","message":"I feel if we get this to boolean the table https://github.com/openstack/neutron/blob/master/neutron/db/port_security/models.py#L34 for this will be useless. is it future plan to decompose that table? I still not get the reason for having it this way ?","commit_id":"ea70df4834827eb94c73f1816fc54b2ea6edf7fe"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f7f409814768b33768d62cfbc6a2639965a97646","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        # TODO(ihrachys): consider exposing availability zones"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        # TODO(ihrachys): consider converting to boolean"},{"line_number":89,"context_line":"        \u0027security\u0027: obj_fields.ObjectField("},{"line_number":90,"context_line":"            \u0027NetworkPortSecurity\u0027, nullable\u003dTrue),"},{"line_number":91,"context_line":"        \u0027segments\u0027: obj_fields.ListOfObjectsField("},{"line_number":92,"context_line":"            \u0027NetworkSegment\u0027, nullable\u003dTrue),"},{"line_number":93,"context_line":"        \u0027dns_domain\u0027: common_types.DomainNameField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":15,"id":"3ac371cc_9dc50c90","line":90,"range":{"start_line":89,"start_character":8,"end_line":90,"end_character":50},"in_reply_to":"3ac371cc_10563329","updated":"2016-08-16 07:20:53.000000000","message":"I think the reason was that it seemed more decoupled to some than direct modification of the core resource table. I agree it was a weird decision that now requires another JOIN. I would say, in the future we should indeed consider squshing those models, the way it is now, it does not make much sense.","commit_id":"ea70df4834827eb94c73f1816fc54b2ea6edf7fe"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"19002c1fc83e57e870dd1f58a3c0cd54d30c8228","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        # since it\u0027s a feature that will probably later be added for other"},{"line_number":97,"context_line":"        # resources too"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        # TODO(ihrachys): expose external network attributes"},{"line_number":100,"context_line":"    }"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    synthetic_fields \u003d ["}],"source_content_type":"text/x-python","patch_set":15,"id":"3ac371cc_415caa4a","line":99,"updated":"2016-08-18 14:55:46.000000000","message":"Also we have qos_policy\n\nhttps://github.com/openstack/neutron/blob/master/neutron/db/qos/models.py#L46\nhttps://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/extensions/qos.py#L46","commit_id":"ea70df4834827eb94c73f1816fc54b2ea6edf7fe"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"47131419f8db78ca8b65696599a2224882e44738","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        # since it\u0027s a feature that will probably later be added for other"},{"line_number":97,"context_line":"        # resources too"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        # TODO(ihrachys): expose external network attributes"},{"line_number":100,"context_line":"    }"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    synthetic_fields \u003d ["}],"source_content_type":"text/x-python","patch_set":15,"id":"1ac06dbe_35ab8e8b","line":99,"in_reply_to":"3ac371cc_415caa4a","updated":"2016-08-19 13:56:48.000000000","message":"Oh right!","commit_id":"ea70df4834827eb94c73f1816fc54b2ea6edf7fe"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"06d5d76a51e8bc41a81b26b1709caf02f200f2e7","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"@obj_base.VersionedObjectRegistry.register"},{"line_number":34,"context_line":"class NetworkSegment(base.NeutronDbObject):"},{"line_number":35,"context_line":"    # Version 1.0: Initial version"},{"line_number":36,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"1ac06dbe_dbed0927","line":34,"range":{"start_line":34,"start_character":5,"end_line":34,"end_character":19},"updated":"2016-08-19 14:18:13.000000000","message":"so which way we should proceed [1]:\nneutron/objects/network/network_segment?\nor\nneutron/objects/network_segment?\n\n[1] https://review.openstack.org/#/c/353571/6/neutron/objects/network/network_segment.py","commit_id":"64d5c7e1e779046756a70e7462968208d2ee4865"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"aa182229db825fc79bba3afaa47495d821d83c0f","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"@obj_base.VersionedObjectRegistry.register"},{"line_number":34,"context_line":"class NetworkSegment(base.NeutronDbObject):"},{"line_number":35,"context_line":"    # Version 1.0: Initial version"},{"line_number":36,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"1ac06dbe_af20c7f8","line":34,"range":{"start_line":34,"start_character":5,"end_line":34,"end_character":19},"in_reply_to":"1ac06dbe_0f9e3b56","updated":"2016-08-19 15:11:44.000000000","message":"It\u0027s stacked on top, it just moves the object from there into this common module.","commit_id":"64d5c7e1e779046756a70e7462968208d2ee4865"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"3960f2fe66c504b657921011f666de74a51fd1e8","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"@obj_base.VersionedObjectRegistry.register"},{"line_number":34,"context_line":"class NetworkSegment(base.NeutronDbObject):"},{"line_number":35,"context_line":"    # Version 1.0: Initial version"},{"line_number":36,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"1ac06dbe_0f9e3b56","line":34,"range":{"start_line":34,"start_character":5,"end_line":34,"end_character":19},"in_reply_to":"1ac06dbe_7ee7a312","updated":"2016-08-19 15:10:18.000000000","message":"the [1] patch is going to be merged (it has +W), so we should adjust this patch to use neutron/objects/network/network_segment, not introducing second object of NetworkSegment in network.py\n\n[1] https://review.openstack.org/#/c/353571","commit_id":"64d5c7e1e779046756a70e7462968208d2ee4865"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"c9690874f91db5bc65dd4948fc44efe7bf86bdd4","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"@obj_base.VersionedObjectRegistry.register"},{"line_number":34,"context_line":"class NetworkSegment(base.NeutronDbObject):"},{"line_number":35,"context_line":"    # Version 1.0: Initial version"},{"line_number":36,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"1ac06dbe_4f74b3ce","line":34,"range":{"start_line":34,"start_character":5,"end_line":34,"end_character":19},"in_reply_to":"1ac06dbe_af20c7f8","updated":"2016-08-19 15:13:22.000000000","message":"OK, I did not noticed, then we are fine :)","commit_id":"64d5c7e1e779046756a70e7462968208d2ee4865"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"86c65c267af75620329997e80e9a486181c6384b","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"@obj_base.VersionedObjectRegistry.register"},{"line_number":34,"context_line":"class NetworkSegment(base.NeutronDbObject):"},{"line_number":35,"context_line":"    # Version 1.0: Initial version"},{"line_number":36,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"1ac06dbe_7ee7a312","line":34,"range":{"start_line":34,"start_character":5,"end_line":34,"end_character":19},"in_reply_to":"1ac06dbe_dbed0927","updated":"2016-08-19 14:32:23.000000000","message":"The patch consolidates everything in a single module. We may have a different opinion later, but I personally think it\u0027s a better practice than scattering files around. Since we don\u0027t have a clear guideline just yet, I took the liberty.","commit_id":"64d5c7e1e779046756a70e7462968208d2ee4865"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"6cd55555fb0a04dc0e9b6a241c28bde698af1069","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        with db_api.autonested_transaction(self.obj_context.session):"},{"line_number":173,"context_line":"            obj_db_api.delete_objects("},{"line_number":174,"context_line":"                self.obj_context, dns_db.NetworkDNSDomain,"},{"line_number":175,"context_line":"                ignore_missing\u003dTrue,"},{"line_number":176,"context_line":"                network_id\u003dself.id,"},{"line_number":177,"context_line":"            )"},{"line_number":178,"context_line":"            if dns_domain:"}],"source_content_type":"text/x-python","patch_set":21,"id":"1ac06dbe_e1f133cf","line":175,"range":{"start_line":175,"start_character":16,"end_line":175,"end_character":36},"updated":"2016-08-19 15:50:52.000000000","message":"I guess it was removed in port patch?","commit_id":"154cd198ea3b99b0cc9d222ee8f6b85e0d8d0543"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f52ad25ed2640e3d09e4499f3bd9c79dc95e5830","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        with db_api.autonested_transaction(self.obj_context.session):"},{"line_number":173,"context_line":"            obj_db_api.delete_objects("},{"line_number":174,"context_line":"                self.obj_context, dns_db.NetworkDNSDomain,"},{"line_number":175,"context_line":"                ignore_missing\u003dTrue,"},{"line_number":176,"context_line":"                network_id\u003dself.id,"},{"line_number":177,"context_line":"            )"},{"line_number":178,"context_line":"            if dns_domain:"}],"source_content_type":"text/x-python","patch_set":21,"id":"1ac06dbe_f76291ac","line":175,"range":{"start_line":175,"start_character":16,"end_line":175,"end_character":36},"in_reply_to":"1ac06dbe_e1f133cf","updated":"2016-08-19 16:16:59.000000000","message":"Done","commit_id":"154cd198ea3b99b0cc9d222ee8f6b85e0d8d0543"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"95152adbd947fc21c6a876a7617ec66f916f671c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"from neutron.objects import rbac_db"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"@obj_base.VersionedObjectRegistry.register"},{"line_number":35,"context_line":"class NetworkSegment(base.NeutronDbObject):"},{"line_number":36,"context_line":"    # Version 1.0: Initial version"},{"line_number":37,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    db_model \u003d segments_db.NetworkSegment"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    fields \u003d {"},{"line_number":42,"context_line":"        \u0027id\u0027: obj_fields.UUIDField(),"},{"line_number":43,"context_line":"        \u0027network_id\u0027: obj_fields.UUIDField(),"},{"line_number":44,"context_line":"        \u0027network_type\u0027: obj_fields.StringField(),"},{"line_number":45,"context_line":"        \u0027physical_network\u0027: obj_fields.StringField(nullable\u003dTrue),"},{"line_number":46,"context_line":"        \u0027segmentation_id\u0027: obj_fields.IntegerField(nullable\u003dTrue),"},{"line_number":47,"context_line":"        \u0027is_dynamic\u0027: obj_fields.BooleanField(default\u003dFalse),"},{"line_number":48,"context_line":"        \u0027segment_index\u0027: obj_fields.IntegerField(default\u003d0)"},{"line_number":49,"context_line":"    }"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    foreign_keys \u003d {"},{"line_number":52,"context_line":"        \u0027Network\u0027: {\u0027network_id\u0027: \u0027id\u0027},"},{"line_number":53,"context_line":"        \u0027PortBindingLevel\u0027: {\u0027id\u0027: \u0027segment_id\u0027},"},{"line_number":54,"context_line":"    }"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @classmethod"},{"line_number":57,"context_line":"    def get_objects(cls, context, _pager\u003dNone, **kwargs):"}],"source_content_type":"text/x-python","patch_set":22,"id":"1ac06dbe_737efe6a","line":54,"range":{"start_line":34,"start_character":0,"end_line":54,"end_character":5},"updated":"2016-08-23 18:42:24.000000000","message":"you need a rebase this would be duplicate , already added object https://github.com/openstack/neutron/blob/master/neutron/objects/network/network_segment.py","commit_id":"c6771a1c42d007f657349316587c4e3e55553253"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"c42417718abe6717f5ebbe0c62eb94452fc1ed82","unresolved":false,"context_lines":[{"line_number":31,"context_line":"from neutron.objects import rbac_db"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"@obj_base.VersionedObjectRegistry.register"},{"line_number":35,"context_line":"class NetworkSegment(base.NeutronDbObject):"},{"line_number":36,"context_line":"    # Version 1.0: Initial version"},{"line_number":37,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    db_model \u003d segments_db.NetworkSegment"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    fields \u003d {"},{"line_number":42,"context_line":"        \u0027id\u0027: obj_fields.UUIDField(),"},{"line_number":43,"context_line":"        \u0027network_id\u0027: obj_fields.UUIDField(),"},{"line_number":44,"context_line":"        \u0027network_type\u0027: obj_fields.StringField(),"},{"line_number":45,"context_line":"        \u0027physical_network\u0027: obj_fields.StringField(nullable\u003dTrue),"},{"line_number":46,"context_line":"        \u0027segmentation_id\u0027: obj_fields.IntegerField(nullable\u003dTrue),"},{"line_number":47,"context_line":"        \u0027is_dynamic\u0027: obj_fields.BooleanField(default\u003dFalse),"},{"line_number":48,"context_line":"        \u0027segment_index\u0027: obj_fields.IntegerField(default\u003d0)"},{"line_number":49,"context_line":"    }"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    foreign_keys \u003d {"},{"line_number":52,"context_line":"        \u0027Network\u0027: {\u0027network_id\u0027: \u0027id\u0027},"},{"line_number":53,"context_line":"        \u0027PortBindingLevel\u0027: {\u0027id\u0027: \u0027segment_id\u0027},"},{"line_number":54,"context_line":"    }"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @classmethod"},{"line_number":57,"context_line":"    def get_objects(cls, context, _pager\u003dNone, **kwargs):"}],"source_content_type":"text/x-python","patch_set":22,"id":"1ac06dbe_b3f7d6d1","line":54,"range":{"start_line":34,"start_character":0,"end_line":54,"end_character":5},"in_reply_to":"1ac06dbe_737efe6a","updated":"2016-08-23 18:51:05.000000000","message":"ignore my previous comment if this is supposed to be moved here, but what made me comment was this changed merged only five days ago in separate module, why was that even merged ?","commit_id":"c6771a1c42d007f657349316587c4e3e55553253"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"2b635fa96766b80e755bd443b10550d2d84a9eb0","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @classmethod"},{"line_number":57,"context_line":"    def get_objects(cls, context, _pager\u003dNone, **kwargs):"},{"line_number":58,"context_line":"        if not _pager:"},{"line_number":59,"context_line":"            _pager \u003d base.Pager()"},{"line_number":60,"context_line":"        if not _pager.sorts:"},{"line_number":61,"context_line":"            # (NOTE) True means ASC, False is DESC"},{"line_number":62,"context_line":"            _pager.sorts \u003d ["},{"line_number":63,"context_line":"                (field, True) for field in (\u0027network_id\u0027, \u0027segment_index\u0027)"},{"line_number":64,"context_line":"            ]"},{"line_number":65,"context_line":"        return super(NetworkSegment, cls).get_objects(context, _pager,"},{"line_number":66,"context_line":"                                                      **kwargs)"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"1ac06dbe_9f7362e7","line":64,"range":{"start_line":58,"start_character":8,"end_line":64,"end_character":13},"updated":"2016-08-25 00:17:06.000000000","message":"Shouldn\u0027t be better to create sorts as argument and has this logic in the base class?","commit_id":"5c0ab20f2b452d434190cc589185f06df336ca72"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"6d5a2409fe576b3f74dc36d18ed9b2269611ad82","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @classmethod"},{"line_number":57,"context_line":"    def get_objects(cls, context, _pager\u003dNone, **kwargs):"},{"line_number":58,"context_line":"        if not _pager:"},{"line_number":59,"context_line":"            _pager \u003d base.Pager()"},{"line_number":60,"context_line":"        if not _pager.sorts:"},{"line_number":61,"context_line":"            # (NOTE) True means ASC, False is DESC"},{"line_number":62,"context_line":"            _pager.sorts \u003d ["},{"line_number":63,"context_line":"                (field, True) for field in (\u0027network_id\u0027, \u0027segment_index\u0027)"},{"line_number":64,"context_line":"            ]"},{"line_number":65,"context_line":"        return super(NetworkSegment, cls).get_objects(context, _pager,"},{"line_number":66,"context_line":"                                                      **kwargs)"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"fa7ab95a_819be2c8","line":64,"range":{"start_line":58,"start_character":8,"end_line":64,"end_character":13},"in_reply_to":"1ac06dbe_0a26f6b9","updated":"2016-08-26 15:00:11.000000000","message":"Well, I was thinking something like this in the NeutronDbObject base class:\n\n    def get_objects(cls, context, _pager\u003dNone, _sorts\u003dNone, **kwargs):\n        ...\n        if not _pager:\n            _pager \u003d cls.Pager()\n        if not _pager.sorts and _sorts is not None:\n            _pager.sorts \u003d _sorts","commit_id":"5c0ab20f2b452d434190cc589185f06df336ca72"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c8e78f3feb3a89d0cc84006b767743d10c2b3e7e","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @classmethod"},{"line_number":57,"context_line":"    def get_objects(cls, context, _pager\u003dNone, **kwargs):"},{"line_number":58,"context_line":"        if not _pager:"},{"line_number":59,"context_line":"            _pager \u003d base.Pager()"},{"line_number":60,"context_line":"        if not _pager.sorts:"},{"line_number":61,"context_line":"            # (NOTE) True means ASC, False is DESC"},{"line_number":62,"context_line":"            _pager.sorts \u003d ["},{"line_number":63,"context_line":"                (field, True) for field in (\u0027network_id\u0027, \u0027segment_index\u0027)"},{"line_number":64,"context_line":"            ]"},{"line_number":65,"context_line":"        return super(NetworkSegment, cls).get_objects(context, _pager,"},{"line_number":66,"context_line":"                                                      **kwargs)"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"1ac06dbe_0a26f6b9","line":64,"range":{"start_line":58,"start_character":8,"end_line":64,"end_character":13},"in_reply_to":"1ac06dbe_9f7362e7","updated":"2016-08-25 10:15:19.000000000","message":"If you mean that default sorting parameters should be declared on objects, yes. And I have a TODO for just that in some other place. It\u0027s work for a follow up.\n\nIf you mean that we need another argument for sorting, then no, we already have _pager for that.","commit_id":"5c0ab20f2b452d434190cc589185f06df336ca72"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9f2485900db80d9740705e059b07bf0d5188fd46","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @classmethod"},{"line_number":57,"context_line":"    def get_objects(cls, context, _pager\u003dNone, **kwargs):"},{"line_number":58,"context_line":"        if not _pager:"},{"line_number":59,"context_line":"            _pager \u003d base.Pager()"},{"line_number":60,"context_line":"        if not _pager.sorts:"},{"line_number":61,"context_line":"            # (NOTE) True means ASC, False is DESC"},{"line_number":62,"context_line":"            _pager.sorts \u003d ["},{"line_number":63,"context_line":"                (field, True) for field in (\u0027network_id\u0027, \u0027segment_index\u0027)"},{"line_number":64,"context_line":"            ]"},{"line_number":65,"context_line":"        return super(NetworkSegment, cls).get_objects(context, _pager,"},{"line_number":66,"context_line":"                                                      **kwargs)"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"fa7ab95a_c0687a8a","line":64,"range":{"start_line":58,"start_character":8,"end_line":64,"end_character":13},"in_reply_to":"fa7ab95a_819be2c8","updated":"2016-08-26 17:52:37.000000000","message":"No, we don\u0027t want to add another argument for sorts. What next? Limit? Page_reverse? Pager is enough, it encapsulates all features.","commit_id":"5c0ab20f2b452d434190cc589185f06df336ca72"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"68138106906c90ae1c4703a47cc11bf04cd932a8","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @classmethod"},{"line_number":57,"context_line":"    def get_objects(cls, context, _pager\u003dNone, **kwargs):"},{"line_number":58,"context_line":"        if not _pager:"},{"line_number":59,"context_line":"            _pager \u003d base.Pager()"},{"line_number":60,"context_line":"        if not _pager.sorts:"},{"line_number":61,"context_line":"            # (NOTE) True means ASC, False is DESC"},{"line_number":62,"context_line":"            _pager.sorts \u003d ["},{"line_number":63,"context_line":"                (field, True) for field in (\u0027network_id\u0027, \u0027segment_index\u0027)"},{"line_number":64,"context_line":"            ]"},{"line_number":65,"context_line":"        return super(NetworkSegment, cls).get_objects(context, _pager,"},{"line_number":66,"context_line":"                                                      **kwargs)"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"fa7ab95a_fc7e62e2","line":64,"range":{"start_line":58,"start_character":8,"end_line":64,"end_character":13},"in_reply_to":"fa7ab95a_c0687a8a","updated":"2016-08-30 17:04:45.000000000","message":"I don\u0027t like to add another argument either, but it seems like more classes are sharing the same logic[1], so eventually we\u0027ll have duplicated code which is worst that adding arguments\n\n[1] https://review.openstack.org/#/c/351368/24/neutron/objects/ports.py@142","commit_id":"5c0ab20f2b452d434190cc589185f06df336ca72"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"df510ce8d4fe50d0977b0b649d73297eeff87dcc","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @classmethod"},{"line_number":57,"context_line":"    def get_objects(cls, context, _pager\u003dNone, **kwargs):"},{"line_number":58,"context_line":"        if not _pager:"},{"line_number":59,"context_line":"            _pager \u003d base.Pager()"},{"line_number":60,"context_line":"        if not _pager.sorts:"},{"line_number":61,"context_line":"            # (NOTE) True means ASC, False is DESC"},{"line_number":62,"context_line":"            _pager.sorts \u003d ["},{"line_number":63,"context_line":"                (field, True) for field in (\u0027network_id\u0027, \u0027segment_index\u0027)"},{"line_number":64,"context_line":"            ]"},{"line_number":65,"context_line":"        return super(NetworkSegment, cls).get_objects(context, _pager,"},{"line_number":66,"context_line":"                                                      **kwargs)"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"fa7ab95a_e54da9c5","line":64,"range":{"start_line":58,"start_character":8,"end_line":64,"end_character":13},"in_reply_to":"fa7ab95a_fc7e62e2","updated":"2016-08-31 13:36:20.000000000","message":"We should be able to tackle that without changing objects API in a duplicating way.","commit_id":"5c0ab20f2b452d434190cc589185f06df336ca72"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"92a29ccbdf4cd4075c7b6ccf5d96373ab87dc926","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                self.obj_context, dns_db.NetworkDNSDomain,"},{"line_number":175,"context_line":"                network_id\u003dself.id,"},{"line_number":176,"context_line":"            )"},{"line_number":177,"context_line":"            if dns_domain:"},{"line_number":178,"context_line":"                obj_db_api.create_object("},{"line_number":179,"context_line":"                    self.obj_context, dns_db.NetworkDNSDomain,"},{"line_number":180,"context_line":"                    {\u0027network_id\u0027: self.id, \u0027dns_domain\u0027: dns_domain}"},{"line_number":181,"context_line":"                )"},{"line_number":182,"context_line":"            self.dns_domain \u003d dns_domain"},{"line_number":183,"context_line":"            self.obj_reset_changes([\u0027dns_domain\u0027])"}],"source_content_type":"text/x-python","patch_set":24,"id":"1ac06dbe_e1e493ad","line":180,"range":{"start_line":177,"start_character":12,"end_line":180,"end_character":69},"updated":"2016-08-24 18:36:47.000000000","message":"I assume validation for valid dns_domain will happen before data reaches this point, otherwise, may need a mechanism for validation.","commit_id":"5c0ab20f2b452d434190cc589185f06df336ca72"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"2b635fa96766b80e755bd443b10550d2d84a9eb0","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                self.obj_context, dns_db.NetworkDNSDomain,"},{"line_number":175,"context_line":"                network_id\u003dself.id,"},{"line_number":176,"context_line":"            )"},{"line_number":177,"context_line":"            if dns_domain:"},{"line_number":178,"context_line":"                obj_db_api.create_object("},{"line_number":179,"context_line":"                    self.obj_context, dns_db.NetworkDNSDomain,"},{"line_number":180,"context_line":"                    {\u0027network_id\u0027: self.id, \u0027dns_domain\u0027: dns_domain}"},{"line_number":181,"context_line":"                )"},{"line_number":182,"context_line":"            self.dns_domain \u003d dns_domain"},{"line_number":183,"context_line":"            self.obj_reset_changes([\u0027dns_domain\u0027])"}],"source_content_type":"text/x-python","patch_set":24,"id":"1ac06dbe_bad0ecf8","line":180,"range":{"start_line":177,"start_character":12,"end_line":180,"end_character":69},"in_reply_to":"1ac06dbe_e1e493ad","updated":"2016-08-25 00:17:06.000000000","message":"Maybe, I guess that if an exception is raised at this point the transaction is rolling back, but maybe it\u0027s a scenario that needs to be consider in the UT.","commit_id":"5c0ab20f2b452d434190cc589185f06df336ca72"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"2b635fa96766b80e755bd443b10550d2d84a9eb0","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                self.obj_context, dns_db.NetworkDNSDomain,"},{"line_number":175,"context_line":"                network_id\u003dself.id,"},{"line_number":176,"context_line":"            )"},{"line_number":177,"context_line":"            if dns_domain:"},{"line_number":178,"context_line":"                obj_db_api.create_object("},{"line_number":179,"context_line":"                    self.obj_context, dns_db.NetworkDNSDomain,"},{"line_number":180,"context_line":"                    {\u0027network_id\u0027: self.id, \u0027dns_domain\u0027: dns_domain}"},{"line_number":181,"context_line":"                )"},{"line_number":182,"context_line":"            self.dns_domain \u003d dns_domain"},{"line_number":183,"context_line":"            self.obj_reset_changes([\u0027dns_domain\u0027])"}],"source_content_type":"text/x-python","patch_set":24,"id":"1ac06dbe_1abae0c0","line":180,"range":{"start_line":177,"start_character":12,"end_line":180,"end_character":69},"in_reply_to":"1ac06dbe_e1e493ad","updated":"2016-08-25 00:17:06.000000000","message":"Maybe, I guess that if this raises an exception it\u0027s rolling back this transaction.","commit_id":"5c0ab20f2b452d434190cc589185f06df336ca72"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"2b635fa96766b80e755bd443b10550d2d84a9eb0","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                self.obj_context, dns_db.NetworkDNSDomain,"},{"line_number":175,"context_line":"                network_id\u003dself.id,"},{"line_number":176,"context_line":"            )"},{"line_number":177,"context_line":"            if dns_domain:"},{"line_number":178,"context_line":"                obj_db_api.create_object("},{"line_number":179,"context_line":"                    self.obj_context, dns_db.NetworkDNSDomain,"},{"line_number":180,"context_line":"                    {\u0027network_id\u0027: self.id, \u0027dns_domain\u0027: dns_domain}"},{"line_number":181,"context_line":"                )"},{"line_number":182,"context_line":"            self.dns_domain \u003d dns_domain"},{"line_number":183,"context_line":"            self.obj_reset_changes([\u0027dns_domain\u0027])"}],"source_content_type":"text/x-python","patch_set":24,"id":"1ac06dbe_bac90c5d","line":180,"range":{"start_line":177,"start_character":12,"end_line":180,"end_character":69},"in_reply_to":"1ac06dbe_e1e493ad","updated":"2016-08-25 00:17:06.000000000","message":"Maybe, I guess that if this raises an exception it\u0027s rolling back this transaction.","commit_id":"5c0ab20f2b452d434190cc589185f06df336ca72"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c8e78f3feb3a89d0cc84006b767743d10c2b3e7e","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                self.obj_context, dns_db.NetworkDNSDomain,"},{"line_number":175,"context_line":"                network_id\u003dself.id,"},{"line_number":176,"context_line":"            )"},{"line_number":177,"context_line":"            if dns_domain:"},{"line_number":178,"context_line":"                obj_db_api.create_object("},{"line_number":179,"context_line":"                    self.obj_context, dns_db.NetworkDNSDomain,"},{"line_number":180,"context_line":"                    {\u0027network_id\u0027: self.id, \u0027dns_domain\u0027: dns_domain}"},{"line_number":181,"context_line":"                )"},{"line_number":182,"context_line":"            self.dns_domain \u003d dns_domain"},{"line_number":183,"context_line":"            self.obj_reset_changes([\u0027dns_domain\u0027])"}],"source_content_type":"text/x-python","patch_set":24,"id":"1ac06dbe_8a966692","line":180,"range":{"start_line":177,"start_character":12,"end_line":180,"end_character":69},"in_reply_to":"1ac06dbe_e1e493ad","updated":"2016-08-25 10:15:19.000000000","message":"Object fields do validation.","commit_id":"5c0ab20f2b452d434190cc589185f06df336ca72"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"2b635fa96766b80e755bd443b10550d2d84a9eb0","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        super(Network, self).from_db_object(*objs)"},{"line_number":203,"context_line":"        for db_obj in objs:"},{"line_number":204,"context_line":"            # extract domain name"},{"line_number":205,"context_line":"            if db_obj.get(\u0027dns_domain\u0027):"},{"line_number":206,"context_line":"                self.dns_domain \u003d ("},{"line_number":207,"context_line":"                    db_obj.dns_domain.dns_domain"},{"line_number":208,"context_line":"                )"},{"line_number":209,"context_line":"            else:"},{"line_number":210,"context_line":"                self.dns_domain \u003d None"},{"line_number":211,"context_line":"            self.obj_reset_changes([\u0027dns_domain\u0027])"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"            # extract qos policy binding"}],"source_content_type":"text/x-python","patch_set":24,"id":"1ac06dbe_3a499c8f","line":210,"range":{"start_line":205,"start_character":0,"end_line":210,"end_character":38},"updated":"2016-08-25 00:17:06.000000000","message":"self.dns_domain \u003d None\nif db_obj.get(\u0027dns_domain\u0027):\n    self.dns_domain \u003d (\n        db_obj.dns_domain.dns_domain\n    )","commit_id":"5c0ab20f2b452d434190cc589185f06df336ca72"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c8e78f3feb3a89d0cc84006b767743d10c2b3e7e","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        super(Network, self).from_db_object(*objs)"},{"line_number":203,"context_line":"        for db_obj in objs:"},{"line_number":204,"context_line":"            # extract domain name"},{"line_number":205,"context_line":"            if db_obj.get(\u0027dns_domain\u0027):"},{"line_number":206,"context_line":"                self.dns_domain \u003d ("},{"line_number":207,"context_line":"                    db_obj.dns_domain.dns_domain"},{"line_number":208,"context_line":"                )"},{"line_number":209,"context_line":"            else:"},{"line_number":210,"context_line":"                self.dns_domain \u003d None"},{"line_number":211,"context_line":"            self.obj_reset_changes([\u0027dns_domain\u0027])"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"            # extract qos policy binding"}],"source_content_type":"text/x-python","patch_set":24,"id":"1ac06dbe_aa8b6267","line":210,"range":{"start_line":205,"start_character":0,"end_line":210,"end_character":38},"in_reply_to":"1ac06dbe_3a499c8f","updated":"2016-08-25 10:15:19.000000000","message":"I don\u0027t think it\u0027s somehow better.","commit_id":"5c0ab20f2b452d434190cc589185f06df336ca72"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"2b635fa96766b80e755bd443b10550d2d84a9eb0","unresolved":false,"context_lines":[{"line_number":211,"context_line":"            self.obj_reset_changes([\u0027dns_domain\u0027])"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"            # extract qos policy binding"},{"line_number":214,"context_line":"            if db_obj.get(\u0027qos_policy_binding\u0027):"},{"line_number":215,"context_line":"                self.qos_policy_id \u003d ("},{"line_number":216,"context_line":"                    db_obj.qos_policy_binding.policy_id"},{"line_number":217,"context_line":"                )"},{"line_number":218,"context_line":"            else:"},{"line_number":219,"context_line":"                self.qos_policy_id \u003d None"},{"line_number":220,"context_line":"            self.obj_reset_changes([\u0027qos_policy_id\u0027])"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":24,"id":"1ac06dbe_55a9cbde","line":219,"range":{"start_line":214,"start_character":0,"end_line":219,"end_character":41},"updated":"2016-08-25 00:17:06.000000000","message":"self.qos_policy_id \u003d None\nif db_obj.get(\u0027qos_policy_binding\u0027):\n    self.qos_policy_id \u003d (\n        db_obj.qos_policy_binding.policy_id\n    )","commit_id":"5c0ab20f2b452d434190cc589185f06df336ca72"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c8e78f3feb3a89d0cc84006b767743d10c2b3e7e","unresolved":false,"context_lines":[{"line_number":211,"context_line":"            self.obj_reset_changes([\u0027dns_domain\u0027])"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"            # extract qos policy binding"},{"line_number":214,"context_line":"            if db_obj.get(\u0027qos_policy_binding\u0027):"},{"line_number":215,"context_line":"                self.qos_policy_id \u003d ("},{"line_number":216,"context_line":"                    db_obj.qos_policy_binding.policy_id"},{"line_number":217,"context_line":"                )"},{"line_number":218,"context_line":"            else:"},{"line_number":219,"context_line":"                self.qos_policy_id \u003d None"},{"line_number":220,"context_line":"            self.obj_reset_changes([\u0027qos_policy_id\u0027])"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":24,"id":"1ac06dbe_6ad84a80","line":219,"range":{"start_line":214,"start_character":0,"end_line":219,"end_character":41},"in_reply_to":"1ac06dbe_55a9cbde","updated":"2016-08-25 10:15:19.000000000","message":"I beg to differ.","commit_id":"5c0ab20f2b452d434190cc589185f06df336ca72"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"387aeee26217cce09226c1eb57cab6389f06f139","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        # TODO(ihrachys): introduce an object for the binding to isolate"},{"line_number":155,"context_line":"        # database access in a single place, currently scattered between port"},{"line_number":156,"context_line":"        # and policy objects"},{"line_number":157,"context_line":"        with db_api.autonested_transaction(self.obj_context.session):"},{"line_number":158,"context_line":"            obj_db_api.delete_objects("},{"line_number":159,"context_line":"                self.obj_context, qos_models.QosNetworkPolicyBinding,"},{"line_number":160,"context_line":"                network_id\u003dself.id,"}],"source_content_type":"text/x-python","patch_set":32,"id":"5a8bc5a2_a5728b47","line":157,"updated":"2016-09-23 13:27:44.000000000","message":"it doesn\u0027t hurt but it\u0027s not needed to open a nested transaction here. This method is supposed to be called only inside an existing transaction I think...isn\u0027t it?","commit_id":"ab3e7e5dc72d216f8279a624700aec509c1b8f09"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c834a7918dd7998879d74cfd52d32b4fb712cb6e","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        # TODO(ihrachys): introduce an object for the binding to isolate"},{"line_number":155,"context_line":"        # database access in a single place, currently scattered between port"},{"line_number":156,"context_line":"        # and policy objects"},{"line_number":157,"context_line":"        with db_api.autonested_transaction(self.obj_context.session):"},{"line_number":158,"context_line":"            obj_db_api.delete_objects("},{"line_number":159,"context_line":"                self.obj_context, qos_models.QosNetworkPolicyBinding,"},{"line_number":160,"context_line":"                network_id\u003dself.id,"}],"source_content_type":"text/x-python","patch_set":32,"id":"5a8bc5a2_9b5ed010","line":157,"in_reply_to":"5a8bc5a2_a5728b47","updated":"2016-09-23 13:48:06.000000000","message":"Done","commit_id":"ab3e7e5dc72d216f8279a624700aec509c1b8f09"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"387aeee26217cce09226c1eb57cab6389f06f139","unresolved":false,"context_lines":[{"line_number":168,"context_line":"            self.obj_reset_changes([\u0027qos_policy_id\u0027])"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    def _set_dns_domain(self, dns_domain):"},{"line_number":171,"context_line":"        with db_api.autonested_transaction(self.obj_context.session):"},{"line_number":172,"context_line":"            obj_db_api.delete_objects("},{"line_number":173,"context_line":"                self.obj_context, dns_db.NetworkDNSDomain,"},{"line_number":174,"context_line":"                network_id\u003dself.id,"}],"source_content_type":"text/x-python","patch_set":32,"id":"5a8bc5a2_259d9b59","line":171,"updated":"2016-09-23 13:27:44.000000000","message":"ditto","commit_id":"ab3e7e5dc72d216f8279a624700aec509c1b8f09"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c834a7918dd7998879d74cfd52d32b4fb712cb6e","unresolved":false,"context_lines":[{"line_number":168,"context_line":"            self.obj_reset_changes([\u0027qos_policy_id\u0027])"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    def _set_dns_domain(self, dns_domain):"},{"line_number":171,"context_line":"        with db_api.autonested_transaction(self.obj_context.session):"},{"line_number":172,"context_line":"            obj_db_api.delete_objects("},{"line_number":173,"context_line":"                self.obj_context, dns_db.NetworkDNSDomain,"},{"line_number":174,"context_line":"                network_id\u003dself.id,"}],"source_content_type":"text/x-python","patch_set":32,"id":"5a8bc5a2_bb9b8cc8","line":171,"in_reply_to":"5a8bc5a2_259d9b59","updated":"2016-09-23 13:48:06.000000000","message":"Done","commit_id":"ab3e7e5dc72d216f8279a624700aec509c1b8f09"}],"neutron/objects/network/network.py":[{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"84b0ebd6e1b14f5ebdd97a3637a039c66102f5ae","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    primary_keys \u003d [\u0027network_id\u0027, \u0027dhcp_agent_id\u0027]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    # foreign_keys \u003d {\u0027network_id\u0027: \u0027id\u0027, \u0027dhcp_agent_id\u0027: \u0027id\u0027}"},{"line_number":42,"context_line":"    foreign_keys \u003d {\u0027network_id\u0027: \u0027id\u0027}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_4fe521a6","line":41,"range":{"start_line":41,"start_character":6,"end_line":41,"end_character":64},"updated":"2016-08-01 12:45:24.000000000","message":"I\u0027m wondering if for this use case we need to introduce the multiple foreign_keys model...","commit_id":"3118c50af908c847f9c478d0cf3bb98938cf6885"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"84b0ebd6e1b14f5ebdd97a3637a039c66102f5ae","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        \u0027subnets\u0027: obj_fields.ListOfObjectsField(\u0027Subnet\u0027, nullable\u003dTrue),"},{"line_number":66,"context_line":"        # TODO(korzen): get Port object when implementation is ready"},{"line_number":67,"context_line":"        # \u0027ports\u0027: obj_fields.ListOfObjectsField(\u0027Port\u0027)),"},{"line_number":68,"context_line":"        # \u0027dhcp_agents\u0027: obj_fields.ObjectField(\u0027NetworkDhcpAgentBinding\u0027,"},{"line_number":69,"context_line":"        #                                      nullable\u003dTrue)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        # extension fields:"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_af5c9d7d","line":68,"range":{"start_line":68,"start_character":11,"end_line":68,"end_character":22},"updated":"2016-08-01 12:45:24.000000000","message":"I\u0027m not sure if dhcp_agents are required as synthetic fields in network object, to be checked.","commit_id":"3118c50af908c847f9c478d0cf3bb98938cf6885"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"75ddbfedd1e5736a48a29ac57347ade6de7cb281","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        \u0027subnets\u0027: obj_fields.ListOfObjectsField(\u0027Subnet\u0027, nullable\u003dTrue),"},{"line_number":66,"context_line":"        # TODO(korzen): get Port object when implementation is ready"},{"line_number":67,"context_line":"        # \u0027ports\u0027: obj_fields.ListOfObjectsField(\u0027Port\u0027)),"},{"line_number":68,"context_line":"        # \u0027dhcp_agents\u0027: obj_fields.ObjectField(\u0027NetworkDhcpAgentBinding\u0027,"},{"line_number":69,"context_line":"        #                                      nullable\u003dTrue)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        # extension fields:"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_df145c45","line":68,"range":{"start_line":68,"start_character":11,"end_line":68,"end_character":22},"in_reply_to":"bacf61ea_af5c9d7d","updated":"2016-08-04 14:53:13.000000000","message":"IIRC, it is used in [1] so I guess we can have it as synthetic fields.\n\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/db/agentschedulers_db.py#L582","commit_id":"3118c50af908c847f9c478d0cf3bb98938cf6885"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"75ddbfedd1e5736a48a29ac57347ade6de7cb281","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        # \u0027dhcp_agents\u0027: obj_fields.ObjectField(\u0027NetworkDhcpAgentBinding\u0027,"},{"line_number":69,"context_line":"        #                                      nullable\u003dTrue)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        # extension fields:"},{"line_number":72,"context_line":"        # TODO(korzen) Fields to be considered:"},{"line_number":73,"context_line":"        # \u0027availability_zones\u0027: obj_fields.ListOfStringsField(),"},{"line_number":74,"context_line":"        # \u0027mtu\u0027: obj_fields.IntegerField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_df69fcbf","line":71,"range":{"start_line":71,"start_character":10,"end_line":71,"end_character":27},"updated":"2016-08-04 14:53:13.000000000","message":"We also need \u0027qos_policy_binding\u0027 field to be used in [1][2][3]\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/db/qos/models.py#L48\n[2] https://github.com/openstack/neutron/blob/master/neutron/core_extensions/qos.py\n[3] https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/extensions/qos.py","commit_id":"3118c50af908c847f9c478d0cf3bb98938cf6885"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"2145843330dc9953562070c76edb0084aa09d727","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        # \u0027dhcp_agents\u0027: obj_fields.ObjectField(\u0027NetworkDhcpAgentBinding\u0027,"},{"line_number":69,"context_line":"        #                                      nullable\u003dTrue)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        # extension fields:"},{"line_number":72,"context_line":"        # TODO(korzen) Fields to be considered:"},{"line_number":73,"context_line":"        # \u0027availability_zones\u0027: obj_fields.ListOfStringsField(),"},{"line_number":74,"context_line":"        # \u0027mtu\u0027: obj_fields.IntegerField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_dc997f21","line":71,"range":{"start_line":71,"start_character":10,"end_line":71,"end_character":27},"in_reply_to":"bacf61ea_b4dedb0e","updated":"2016-08-08 13:57:54.000000000","message":"In my opinion, we should include all the extension fields as synthetic fields upfront. Many of the below is the built-in types, so what we need is the loading methods - which can be added later.","commit_id":"3118c50af908c847f9c478d0cf3bb98938cf6885"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"f05d126700a1acaad182342d4eb5f27a503bb636","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        # \u0027dhcp_agents\u0027: obj_fields.ObjectField(\u0027NetworkDhcpAgentBinding\u0027,"},{"line_number":69,"context_line":"        #                                      nullable\u003dTrue)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        # extension fields:"},{"line_number":72,"context_line":"        # TODO(korzen) Fields to be considered:"},{"line_number":73,"context_line":"        # \u0027availability_zones\u0027: obj_fields.ListOfStringsField(),"},{"line_number":74,"context_line":"        # \u0027mtu\u0027: obj_fields.IntegerField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_b4dedb0e","line":71,"range":{"start_line":71,"start_character":10,"end_line":71,"end_character":27},"in_reply_to":"bacf61ea_df69fcbf","updated":"2016-08-04 20:24:29.000000000","message":"Re: discussion with Victor Morales. For the sake of finishing priority objects. Consider not dealing with the various extensions till later. Finish the core network object, refactor later to include extensions. Thoughts?","commit_id":"3118c50af908c847f9c478d0cf3bb98938cf6885"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"84b0ebd6e1b14f5ebdd97a3637a039c66102f5ae","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    def modify_fields_from_db(cls, db_obj):"},{"line_number":88,"context_line":"        result \u003d super(Network, cls).modify_fields_from_db(db_obj)"},{"line_number":89,"context_line":"        if \u0027availability_zone_hints\u0027 in result:"},{"line_number":90,"context_line":"            result[\u0027availability_zone_hints\u0027] \u003d \\"},{"line_number":91,"context_line":"                str(result[\u0027availability_zone_hints\u0027]).split(\u0027,\u0027)"},{"line_number":92,"context_line":"        return result"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_cf82b1c7","line":90,"updated":"2016-08-01 12:45:24.000000000","message":"Changing from list to string is already somewhere in common tools, we need to evaluate if it is needed where or in the extension code [1]\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/db/availability_zone/network.py#L24","commit_id":"3118c50af908c847f9c478d0cf3bb98938cf6885"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"84b0ebd6e1b14f5ebdd97a3637a039c66102f5ae","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    def modify_fields_to_db(cls, fields):"},{"line_number":96,"context_line":"        result \u003d super(Network, cls).modify_fields_to_db(fields)"},{"line_number":97,"context_line":"        if \u0027availability_zone_hints\u0027 in result:"},{"line_number":98,"context_line":"            result[\u0027availability_zone_hints\u0027] \u003d \\"},{"line_number":99,"context_line":"                \",\".join(map(str, result[\u0027availability_zone_hints\u0027]))"},{"line_number":100,"context_line":"        return result"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_af85bdcf","line":98,"updated":"2016-08-01 12:45:24.000000000","message":"ditto.","commit_id":"3118c50af908c847f9c478d0cf3bb98938cf6885"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"84b0ebd6e1b14f5ebdd97a3637a039c66102f5ae","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                \",\".join(map(str, result[\u0027availability_zone_hints\u0027]))"},{"line_number":100,"context_line":"        return result"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def reload_subnets(self):"},{"line_number":103,"context_line":"        subnets \u003d subnet.Subnet.get_objects(self._context, network_id\u003dself.id)"},{"line_number":104,"context_line":"        setattr(self, \u0027subnets\u0027, subnets)"},{"line_number":105,"context_line":"        self.obj_reset_changes([\u0027subnets\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_2f670db8","line":102,"updated":"2016-08-01 12:45:24.000000000","message":"I do not like this reload_(subnet|ports) method as it should not be required to have them. In my opinion we can drop them.","commit_id":"3118c50af908c847f9c478d0cf3bb98938cf6885"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"84b0ebd6e1b14f5ebdd97a3637a039c66102f5ae","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        self.obj_reset_changes([\u0027ports\u0027])"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @classmethod"},{"line_number":114,"context_line":"    def get_object(cls, context, **kwargs):"},{"line_number":115,"context_line":"        with db_api.autonested_transaction(context.session):"},{"line_number":116,"context_line":"            net_obj \u003d super(Network, cls).get_object(context, **kwargs)"},{"line_number":117,"context_line":"            # if net_obj is not None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_afdf7d38","line":114,"updated":"2016-08-01 12:45:24.000000000","message":"If reload_* methods are not required, we can remove get_object overridden method.","commit_id":"3118c50af908c847f9c478d0cf3bb98938cf6885"}],"neutron/objects/network/network_segment.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"c42417718abe6717f5ebbe0c62eb94452fc1ed82","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    foreign_keys \u003d {"},{"line_number":38,"context_line":"        \u0027Network\u0027: {\u0027network_id\u0027: \u0027id\u0027},"},{"line_number":39,"context_line":"        \u0027PortBindingLevel\u0027: {\u0027id\u0027: \u0027segment_id\u0027},"},{"line_number":40,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":22,"id":"1ac06dbe_f3ecaebc","side":"PARENT","line":39,"range":{"start_line":39,"start_character":8,"end_line":39,"end_character":48},"updated":"2016-08-23 18:51:05.000000000","message":"this is not there in https://github.com/openstack/neutron/blob/master/neutron/objects/network/network_segment.py#L37 wondering where it come from","commit_id":"e6219d1e06c28d5268fa29a2b30999cd77ba6113"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"680e417530c1faac7dbb984b5853d87dbb6b7088","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    foreign_keys \u003d {"},{"line_number":38,"context_line":"        \u0027Network\u0027: {\u0027network_id\u0027: \u0027id\u0027},"},{"line_number":39,"context_line":"        \u0027PortBindingLevel\u0027: {\u0027id\u0027: \u0027segment_id\u0027},"},{"line_number":40,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":22,"id":"1ac06dbe_e948ff8c","side":"PARENT","line":39,"range":{"start_line":39,"start_character":8,"end_line":39,"end_character":48},"in_reply_to":"1ac06dbe_f3ecaebc","updated":"2016-08-24 16:33:18.000000000","message":"The previous patch that adds port object? The network is stacked on top of port. Just check dependencies.","commit_id":"e6219d1e06c28d5268fa29a2b30999cd77ba6113"}],"neutron/tests/unit/objects/test_base.py":[{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"84b0ebd6e1b14f5ebdd97a3637a039c66102f5ae","unresolved":false,"context_lines":[{"line_number":1072,"context_line":"            # make sure children point to the base object"},{"line_number":1073,"context_line":"            for local_field, foreign_key in objclass.foreign_keys.items():"},{"line_number":1074,"context_line":"                objclass_fields[local_field] \u003d obj.get(foreign_key)"},{"line_number":1075,"context_line":"            if (\u0027segment_id\u0027 in objclass_fields"},{"line_number":1076,"context_line":"                and \u0027network_id\u0027 in objclass_fields):"},{"line_number":1077,"context_line":"                network \u003d {\u0027id\u0027: objclass_fields[\u0027network_id\u0027]}"},{"line_number":1078,"context_line":"                self._create_test_segment(network)"},{"line_number":1079,"context_line":"                objclass_fields[\u0027segment_id\u0027] \u003d self._segment[\u0027id\u0027]"},{"line_number":1080,"context_line":"            synth_field_obj \u003d objclass(self.context, **objclass_fields)"},{"line_number":1081,"context_line":"            synth_field_obj.create()"},{"line_number":1082,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_8f66f927","line":1079,"range":{"start_line":1075,"start_character":11,"end_line":1079,"end_character":67},"updated":"2016-08-01 12:45:24.000000000","message":"This is workaround for subnet object creation. Subnet requires to create the network and subnet upfront. So it means that segment_id requires to point to existing segment created.","commit_id":"3118c50af908c847f9c478d0cf3bb98938cf6885"}],"neutron/tests/unit/objects/test_network.py":[{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"6cd55555fb0a04dc0e9b6a241c28bde698af1069","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        obj \u003d network.Network.get_object(self.context, id\u003dobj.id)"},{"line_number":102,"context_line":"        self.assertIsNone(obj.qos_policy_id)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def test__attach_qos_policy(self):"},{"line_number":105,"context_line":"        obj \u003d self._make_object(self.obj_fields[0])"},{"line_number":106,"context_line":"        obj.create()"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1ac06dbe_61826302","line":104,"range":{"start_line":104,"start_character":12,"end_line":104,"end_character":14},"updated":"2016-08-19 15:50:52.000000000","message":"s/__/_/ ?","commit_id":"154cd198ea3b99b0cc9d222ee8f6b85e0d8d0543"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f52ad25ed2640e3d09e4499f3bd9c79dc95e5830","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        obj \u003d network.Network.get_object(self.context, id\u003dobj.id)"},{"line_number":102,"context_line":"        self.assertIsNone(obj.qos_policy_id)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def test__attach_qos_policy(self):"},{"line_number":105,"context_line":"        obj \u003d self._make_object(self.obj_fields[0])"},{"line_number":106,"context_line":"        obj.create()"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1ac06dbe_97dd1d73","line":104,"range":{"start_line":104,"start_character":12,"end_line":104,"end_character":14},"in_reply_to":"1ac06dbe_61826302","updated":"2016-08-19 16:16:59.000000000","message":"As designed, to reflect we target an internal method.","commit_id":"154cd198ea3b99b0cc9d222ee8f6b85e0d8d0543"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"e5bf58bd08f3cd39b9e210575e1f9a56e5e72d06","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        obj \u003d network.Network.get_object(self.context, id\u003dobj.id)"},{"line_number":102,"context_line":"        self.assertIsNone(obj.qos_policy_id)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def test__attach_qos_policy(self):"},{"line_number":105,"context_line":"        obj \u003d self._make_object(self.obj_fields[0])"},{"line_number":106,"context_line":"        obj.create()"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1ac06dbe_ad1d6abf","line":104,"range":{"start_line":104,"start_character":12,"end_line":104,"end_character":14},"in_reply_to":"1ac06dbe_97dd1d73","updated":"2016-08-19 17:04:06.000000000","message":"ok, understood.","commit_id":"154cd198ea3b99b0cc9d222ee8f6b85e0d8d0543"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"92a29ccbdf4cd4075c7b6ccf5d96373ab87dc926","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def setUp(self):"},{"line_number":43,"context_line":"        super(NetworkSegmentIfaceObjTestCase, self).setUp()"},{"line_number":44,"context_line":"        # TODO(ihrachys): we should not need to duplicate that in every single"},{"line_number":45,"context_line":"        # place, instead we should move the default pager into the base class"},{"line_number":46,"context_line":"        # attribute and pull it from there for testing matters. Leaving it for"},{"line_number":47,"context_line":"        # a follow up."},{"line_number":48,"context_line":"        self.pager_map[self._test_class.obj_name()] \u003d ("},{"line_number":49,"context_line":"            obj_base.Pager("},{"line_number":50,"context_line":"                sorts\u003d[(\u0027network_id\u0027, True), (\u0027segment_index\u0027, True)]))"}],"source_content_type":"text/x-python","patch_set":24,"id":"1ac06dbe_b219477c","line":47,"range":{"start_line":44,"start_character":7,"end_line":47,"end_character":22},"updated":"2016-08-24 18:36:47.000000000","message":"+1 that would be much better solution","commit_id":"5c0ab20f2b452d434190cc589185f06df336ca72"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"92a29ccbdf4cd4075c7b6ccf5d96373ab87dc926","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                sorts\u003d[(\u0027network_id\u0027, True), (\u0027segment_index\u0027, True)]))"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"class NetworkDbObjectTestCase(obj_test_base.BaseDbObjectTestCase,"},{"line_number":75,"context_line":"                              testlib_api.SqlTestCase):"},{"line_number":76,"context_line":"    _test_class \u003d network.Network"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def test_qos_policy_id(self):"}],"source_content_type":"text/x-python","patch_set":24,"id":"1ac06dbe_d26163d5","line":75,"range":{"start_line":74,"start_character":7,"end_line":75,"end_character":55},"updated":"2016-08-24 18:36:47.000000000","message":"tests look good, I guess set_dns_domain test can also be added here, it is okay if that would be done in followup patch but worth leaving a note or todo","commit_id":"5c0ab20f2b452d434190cc589185f06df336ca72"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c8e78f3feb3a89d0cc84006b767743d10c2b3e7e","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                sorts\u003d[(\u0027network_id\u0027, True), (\u0027segment_index\u0027, True)]))"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"class NetworkDbObjectTestCase(obj_test_base.BaseDbObjectTestCase,"},{"line_number":75,"context_line":"                              testlib_api.SqlTestCase):"},{"line_number":76,"context_line":"    _test_class \u003d network.Network"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def test_qos_policy_id(self):"}],"source_content_type":"text/x-python","patch_set":24,"id":"1ac06dbe_8ab0268d","line":75,"range":{"start_line":74,"start_character":7,"end_line":75,"end_character":55},"in_reply_to":"1ac06dbe_d26163d5","updated":"2016-08-25 10:15:19.000000000","message":"Spot on. I will add it here.","commit_id":"5c0ab20f2b452d434190cc589185f06df336ca72"}],"neutron/tests/unit/objects/test_objects.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"2b635fa96766b80e755bd443b10550d2d84a9eb0","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# NOTE: The hashes in this list should only be changed if they come with a"},{"line_number":27,"context_line":"# corresponding version bump in the affected objects. Please keep the list in"},{"line_number":28,"context_line":"# alphabetic order."},{"line_number":29,"context_line":"object_data \u003d {"},{"line_number":30,"context_line":"    \u0027_DefaultSecurityGroup\u0027: \u00271.0-971520cb2e0ec06d747885a0cf78347f\u0027,"}],"source_content_type":"text/x-python","patch_set":24,"id":"1ac06dbe_b54abf25","line":27,"range":{"start_line":27,"start_character":54,"end_line":27,"end_character":60},"updated":"2016-08-25 00:17:06.000000000","message":"Please!!! :)","commit_id":"5c0ab20f2b452d434190cc589185f06df336ca72"}]}
