)]}'
{"doc/source/devref/address_scopes.rst":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"efbb9b1186c0d1e0c9594f48e91e7dec7c5945b1","unresolved":false,"context_lines":[{"line_number":182,"context_line":""},{"line_number":183,"context_line":"One exception is made for floating IP traffic.  When traffic is headed to a"},{"line_number":184,"context_line":"floating IP, DNAT is applied and the traffic is allowed to route to the private"},{"line_number":185,"context_line":"IP address potentially crossing the address scope boundary.  When traffic"},{"line_number":186,"context_line":"flows from an internal port to the external network and a floating IP is"},{"line_number":187,"context_line":"assigned, that traffic is also allowed."},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"Another exception is made for traffic from an internal network to the external"},{"line_number":190,"context_line":"network when there is no floating IP assigned.  In this case, SNAT to the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba63e191_8f3f9dd5","line":187,"range":{"start_line":185,"start_character":61,"end_line":187,"end_character":39},"updated":"2016-01-20 04:43:07.000000000","message":"I don\u0027t think this works with the current code.  I think I still need to MARK traffic from the fixed ips with the external network scope so that traffic doesn\u0027t get blocked.","commit_id":"dece2de2067980fefa428b5fb14799a5e6b43118"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"689f5e9caa656ae1fe9db5d9c55d094be2396e45","unresolved":false,"context_lines":[{"line_number":182,"context_line":""},{"line_number":183,"context_line":"One exception is made for floating IP traffic.  When traffic is headed to a"},{"line_number":184,"context_line":"floating IP, DNAT is applied and the traffic is allowed to route to the private"},{"line_number":185,"context_line":"IP address potentially crossing the address scope boundary.  When traffic"},{"line_number":186,"context_line":"flows from an internal port to the external network and a floating IP is"},{"line_number":187,"context_line":"assigned, that traffic is also allowed."},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"Another exception is made for traffic from an internal network to the external"},{"line_number":190,"context_line":"network when there is no floating IP assigned.  In this case, SNAT to the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a68dd71_a892e555","line":187,"range":{"start_line":185,"start_character":61,"end_line":187,"end_character":39},"in_reply_to":"ba63e191_80844ad4","updated":"2016-01-20 17:34:15.000000000","message":"This MARK works for traffic that originates from outside that is destined for the floating ip.  However, this sentence is about traffic that originates from the fixed port on the internal network going externally.  I don\u0027t think that works with the current code because I think the traffic will be blocked unless the internal network matches scope with the external network.\n\nOr, it might fall through to the SNAT case.  It might work by accident when SNAT is turned on since the DROP rule is not placed on the gateway interface in that case.  But, when you turned SNAT off, I think it would break.\n\nThat is what I realized late last night after I posted patch set one and was going through it here one last time.\n\nI\u0027ll look in to this today.","commit_id":"dece2de2067980fefa428b5fb14799a5e6b43118"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"67de3e81edfe5652389e1d41c44f64055064d512","unresolved":false,"context_lines":[{"line_number":182,"context_line":""},{"line_number":183,"context_line":"One exception is made for floating IP traffic.  When traffic is headed to a"},{"line_number":184,"context_line":"floating IP, DNAT is applied and the traffic is allowed to route to the private"},{"line_number":185,"context_line":"IP address potentially crossing the address scope boundary.  When traffic"},{"line_number":186,"context_line":"flows from an internal port to the external network and a floating IP is"},{"line_number":187,"context_line":"assigned, that traffic is also allowed."},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"Another exception is made for traffic from an internal network to the external"},{"line_number":190,"context_line":"network when there is no floating IP assigned.  In this case, SNAT to the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba63e191_80844ad4","line":187,"range":{"start_line":185,"start_character":61,"end_line":187,"end_character":39},"in_reply_to":"ba63e191_8f3f9dd5","updated":"2016-01-20 10:56:10.000000000","message":"From my understanding, the floatingip across scopes can work with current code. The mangle rule for floatingip will change the mark according to the floatingip.\n\nfor example:\n\nsource               destination         \n0.0.0.0/0            172.24.4.4           MARK xset 0x4000000/0xffff0000","commit_id":"dece2de2067980fefa428b5fb14799a5e6b43118"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"00da116ebe089fdb226821fe87bb0135aadf2ebe","unresolved":false,"context_lines":[{"line_number":182,"context_line":""},{"line_number":183,"context_line":"One exception is made for floating IP traffic.  When traffic is headed to a"},{"line_number":184,"context_line":"floating IP, DNAT is applied and the traffic is allowed to route to the private"},{"line_number":185,"context_line":"IP address potentially crossing the address scope boundary.  When traffic"},{"line_number":186,"context_line":"flows from an internal port to the external network and a floating IP is"},{"line_number":187,"context_line":"assigned, that traffic is also allowed."},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"Another exception is made for traffic from an internal network to the external"},{"line_number":190,"context_line":"network when there is no floating IP assigned.  In this case, SNAT to the"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a68dd71_42dd4513","line":187,"range":{"start_line":185,"start_character":61,"end_line":187,"end_character":39},"updated":"2016-01-20 18:23:15.000000000","message":"I believe this is still broken and will be testing this today.","commit_id":"8fd4158bc8c2f827fe36046f3101f7c71710d1bc"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"d576295416a1e2889acf2b21e8f67f1d4b86cccf","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    |                |        |                  |        |              |"},{"line_number":172,"context_line":"    +----------------+        +------------------+        +--------------+"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"L3 Agent"},{"line_number":175,"context_line":"~~~~~~~~"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"The L3 agent is limited in its support for multiple address scopes.  Within a"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a68dd71_03c8aa54","line":174,"range":{"start_line":174,"start_character":0,"end_line":174,"end_character":8},"updated":"2016-01-20 20:41:59.000000000","message":"I also need to add a release note about address scopes.","commit_id":"45e0caf07c2d42a23116dc9fbbd9b8fedd4242dc"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"094160fbe9b1a8cbf5f1d0d5f16be1f0b2ebc525","unresolved":false,"context_lines":[{"line_number":175,"context_line":"~~~~~~~~"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"The L3 agent is limited in its support for multiple address scopes.  Within a"},{"line_number":178,"context_line":"router in the reference implementation, traffic is marked on igress with the"},{"line_number":179,"context_line":"address scope corresponding to the network it is coming from.  If that traffic"},{"line_number":180,"context_line":"would route to an interface in a different address scope, the traffic is"},{"line_number":181,"context_line":"blocked unless an exception is made."}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a68dd71_27e93b1b","line":178,"updated":"2016-01-20 20:23:02.000000000","message":"s/igress/ingress","commit_id":"45e0caf07c2d42a23116dc9fbbd9b8fedd4242dc"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"27ea16ba3a9fbe3e1c8d61a98e23b9f6448025ba","unresolved":false,"context_lines":[{"line_number":175,"context_line":"~~~~~~~~"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"The L3 agent is limited in its support for multiple address scopes.  Within a"},{"line_number":178,"context_line":"router in the reference implementation, traffic is marked on igress with the"},{"line_number":179,"context_line":"address scope corresponding to the network it is coming from.  If that traffic"},{"line_number":180,"context_line":"would route to an interface in a different address scope, the traffic is"},{"line_number":181,"context_line":"blocked unless an exception is made."}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a68dd71_120692ce","line":178,"in_reply_to":"9a68dd71_27e93b1b","updated":"2016-01-21 11:34:52.000000000","message":"Done","commit_id":"45e0caf07c2d42a23116dc9fbbd9b8fedd4242dc"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"d576295416a1e2889acf2b21e8f67f1d4b86cccf","unresolved":false,"context_lines":[{"line_number":187,"context_line":"assigned, that traffic is also allowed."},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"Another exception is made for traffic from an internal network to the external"},{"line_number":190,"context_line":"network when there is no floating IP assigned.  In this case, SNAT to the"},{"line_number":191,"context_line":"router\u0027s fixed IP address is applied to the traffic.  However, SNAT is not used"},{"line_number":192,"context_line":"if the external network has an explicit address scope assigned and it matches"},{"line_number":193,"context_line":"the internal network\u0027s.  In that case, traffic routes straight through without"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a68dd71_83bb3ac4","line":190,"range":{"start_line":190,"start_character":25,"end_line":190,"end_character":45},"updated":"2016-01-20 20:41:59.000000000","message":"This is true only when snat is enabled on the router.  Floating IPs work either way.","commit_id":"45e0caf07c2d42a23116dc9fbbd9b8fedd4242dc"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"27ea16ba3a9fbe3e1c8d61a98e23b9f6448025ba","unresolved":false,"context_lines":[{"line_number":187,"context_line":"assigned, that traffic is also allowed."},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"Another exception is made for traffic from an internal network to the external"},{"line_number":190,"context_line":"network when there is no floating IP assigned.  In this case, SNAT to the"},{"line_number":191,"context_line":"router\u0027s fixed IP address is applied to the traffic.  However, SNAT is not used"},{"line_number":192,"context_line":"if the external network has an explicit address scope assigned and it matches"},{"line_number":193,"context_line":"the internal network\u0027s.  In that case, traffic routes straight through without"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a68dd71_12a212af","line":190,"range":{"start_line":190,"start_character":25,"end_line":190,"end_character":45},"in_reply_to":"9a68dd71_83bb3ac4","updated":"2016-01-21 11:34:52.000000000","message":"I change it to \"when SNAT is enabled\"","commit_id":"45e0caf07c2d42a23116dc9fbbd9b8fedd4242dc"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"072b09da0835523c233f0a96c85fa422f73b9dc6","unresolved":false,"context_lines":[{"line_number":187,"context_line":"assigned, that traffic is also allowed."},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"Another exception is made for traffic from an internal network to the external"},{"line_number":190,"context_line":"network when SNAT is enabled.  In this case, SNAT to the router\u0027s fixed IP"},{"line_number":191,"context_line":"address is applied to the traffic.  However, SNAT is not used if the external"},{"line_number":192,"context_line":"network has an explicit address scope assigned and it matches the internal"},{"line_number":193,"context_line":"network\u0027s.  In that case, traffic routes straight through without NAT.  The"}],"source_content_type":"text/x-rst","patch_set":13,"id":"5a5ae5dd_480d0836","line":190,"updated":"2016-02-04 21:32:24.000000000","message":"technically the case at line 186-187 is SNAT too, but I understand what you mean here. No distinction or further clarification is necessary imo.","commit_id":"3e94111d6b83ea30aecdf388d4ba102c39b7251d"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"a5daa34eb42f428afe39074aa0d43beaa7887881","unresolved":false,"context_lines":[{"line_number":187,"context_line":"assigned, that traffic is also allowed."},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"Another exception is made for traffic from an internal network to the external"},{"line_number":190,"context_line":"network when SNAT is enabled.  In this case, SNAT to the router\u0027s fixed IP"},{"line_number":191,"context_line":"address is applied to the traffic.  However, SNAT is not used if the external"},{"line_number":192,"context_line":"network has an explicit address scope assigned and it matches the internal"},{"line_number":193,"context_line":"network\u0027s.  In that case, traffic routes straight through without NAT.  The"}],"source_content_type":"text/x-rst","patch_set":13,"id":"5a5ae5dd_4f76f706","line":190,"in_reply_to":"5a5ae5dd_480d0836","updated":"2016-02-08 17:20:39.000000000","message":"I wrote this in the context of the --disable-snat argument to router-gateway-set and I\u0027m specific that I\u0027m talking about SNAT \"to the router\u0027s fixed IP\".  I could probably be a little clearer but I don\u0027t think I got anything wrong.\n\nYou\u0027re right in pointing out that it is confusing the way we talk about SNAT in Neutron as if it only applied to the shared SNAT that is used when a floating IP is not associated to an instance.  Really, there are two kinds of SNAT for traffic sourced from a Neutron internal network destined for an external network:\n\n- Floating IPs use 1-1 SNAT for traffic from the associated port.\n- N-1 SNAT to the router\u0027s fixed IP is used for traffic from ports with no floating IP.","commit_id":"3e94111d6b83ea30aecdf388d4ba102c39b7251d"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"072b09da0835523c233f0a96c85fa422f73b9dc6","unresolved":false,"context_lines":[{"line_number":202,"context_line":"unresolved issues with it."},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"Second, the default SNAT feature cannot be supported with the current Linux"},{"line_number":205,"context_line":"conntrack implementation unless a double NAT is used (one NAT to get from the"},{"line_number":206,"context_line":"address scope to an intermediate address specific to the scope and a second NAT"},{"line_number":207,"context_line":"to get from that intermediate address to an external address).  Single NAT"},{"line_number":208,"context_line":"won\u0027t work if there are duplicate addresses across the scopes."}],"source_content_type":"text/x-rst","patch_set":13,"id":"5a5ae5dd_28a68c10","line":205,"updated":"2016-02-04 21:32:24.000000000","message":"Out of curiosity, what are the implications, from a user perspective, of this limitation?","commit_id":"3e94111d6b83ea30aecdf388d4ba102c39b7251d"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"a5daa34eb42f428afe39074aa0d43beaa7887881","unresolved":false,"context_lines":[{"line_number":202,"context_line":"unresolved issues with it."},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"Second, the default SNAT feature cannot be supported with the current Linux"},{"line_number":205,"context_line":"conntrack implementation unless a double NAT is used (one NAT to get from the"},{"line_number":206,"context_line":"address scope to an intermediate address specific to the scope and a second NAT"},{"line_number":207,"context_line":"to get from that intermediate address to an external address).  Single NAT"},{"line_number":208,"context_line":"won\u0027t work if there are duplicate addresses across the scopes."}],"source_content_type":"text/x-rst","patch_set":13,"id":"5a5ae5dd_ef0a4478","line":205,"in_reply_to":"5a5ae5dd_28a68c10","updated":"2016-02-08 17:20:39.000000000","message":"The user\u0027s perspective of this limitation is stated on L210.  You\u0027ll not be allowed to connect a single router to networks with overlapping IP space, even if the overlap is across address scopes.  You\u0027ll get an error when you call \"neutron router-interface-add\" if the subnet you\u0027re trying to connect to overlaps with another subnet you\u0027re already connected to even if they are in different address scopes.\n\nIf you need to connect to networks with overlapping IPs then you\u0027ll still need to use multiple routers.","commit_id":"3e94111d6b83ea30aecdf388d4ba102c39b7251d"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"072b09da0835523c233f0a96c85fa422f73b9dc6","unresolved":false,"context_lines":[{"line_number":205,"context_line":"conntrack implementation unless a double NAT is used (one NAT to get from the"},{"line_number":206,"context_line":"address scope to an intermediate address specific to the scope and a second NAT"},{"line_number":207,"context_line":"to get from that intermediate address to an external address).  Single NAT"},{"line_number":208,"context_line":"won\u0027t work if there are duplicate addresses across the scopes."},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"Due to these complications the router will still refuse to connect to"},{"line_number":211,"context_line":"overlapping subnets.  We can look in to an implementation that overcomes these"}],"source_content_type":"text/x-rst","patch_set":13,"id":"5a5ae5dd_8851c010","line":208,"updated":"2016-02-04 21:32:24.000000000","message":"Can we then say that the only implementation of the address scopes features does not implement it as they were meant to be implemented?\n\nBy the way, I\u0027m assuming the reference impl is the only impl - is that accurate?","commit_id":"3e94111d6b83ea30aecdf388d4ba102c39b7251d"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"a5daa34eb42f428afe39074aa0d43beaa7887881","unresolved":false,"context_lines":[{"line_number":205,"context_line":"conntrack implementation unless a double NAT is used (one NAT to get from the"},{"line_number":206,"context_line":"address scope to an intermediate address specific to the scope and a second NAT"},{"line_number":207,"context_line":"to get from that intermediate address to an external address).  Single NAT"},{"line_number":208,"context_line":"won\u0027t work if there are duplicate addresses across the scopes."},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"Due to these complications the router will still refuse to connect to"},{"line_number":211,"context_line":"overlapping subnets.  We can look in to an implementation that overcomes these"}],"source_content_type":"text/x-rst","patch_set":13,"id":"5a5ae5dd_ef21e39e","line":208,"in_reply_to":"5a5ae5dd_8851c010","updated":"2016-02-08 17:20:39.000000000","message":"I wouldn\u0027t say it that way.  The reference implementation implements the forwarding rules correctly but limits the allowed configurations for connecting a router to avoid these pitfalls.  In short, I limit the allowed configurations in order to maintain correct forwarding semantics.\n\nWhen someone understands address scopes, they\u0027d expect to be able to connect a router to multiple overlapping subnets as long as those subnets are in different address scopes.  They might be surprised when they try and get an error from \"neutron router-interface-add\" saying they cannot do this.\n\nThe reference impl is the only implementation as far as I know.","commit_id":"3e94111d6b83ea30aecdf388d4ba102c39b7251d"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"0bb2e3eb40ac0d03dcc8d790572aa61198f15911","unresolved":false,"context_lines":[{"line_number":209,"context_line":""},{"line_number":210,"context_line":"Due to these complications the router will still refuse to connect to"},{"line_number":211,"context_line":"overlapping subnets.  We can look in to an implementation that overcomes these"},{"line_number":212,"context_line":"limitations in the future."}],"source_content_type":"text/x-rst","patch_set":13,"id":"5a5ae5dd_36ee5823","line":212,"updated":"2016-02-03 08:43:23.000000000","message":"i have a question; other implementations should mirror these limitations?\nie. if we fix the limitation in future, will it be another extension?","commit_id":"3e94111d6b83ea30aecdf388d4ba102c39b7251d"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e1cf71d5d6a59c215c915dff8a8d1a49ea4ff8da","unresolved":false,"context_lines":[{"line_number":209,"context_line":""},{"line_number":210,"context_line":"Due to these complications the router will still refuse to connect to"},{"line_number":211,"context_line":"overlapping subnets.  We can look in to an implementation that overcomes these"},{"line_number":212,"context_line":"limitations in the future."}],"source_content_type":"text/x-rst","patch_set":13,"id":"5a5ae5dd_d50c8344","line":212,"in_reply_to":"5a5ae5dd_36ee5823","updated":"2016-02-03 16:08:48.000000000","message":"IMO, other implementations do not need to mimic this behavior and I don\u0027t think an extension will be needed if the limitation is fixed in the future.","commit_id":"3e94111d6b83ea30aecdf388d4ba102c39b7251d"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"a5daa34eb42f428afe39074aa0d43beaa7887881","unresolved":false,"context_lines":[{"line_number":209,"context_line":""},{"line_number":210,"context_line":"Due to these complications the router will still refuse to connect to"},{"line_number":211,"context_line":"overlapping subnets.  We can look in to an implementation that overcomes these"},{"line_number":212,"context_line":"limitations in the future."}],"source_content_type":"text/x-rst","patch_set":13,"id":"5a5ae5dd_8f52b033","line":212,"in_reply_to":"5a5ae5dd_4872e8ae","updated":"2016-02-08 17:20:39.000000000","message":"I think you might be misunderstanding the limitation.  Yamamoto\u0027s question, as I understood it, was whether other implementations must refuse to connect a router to different networks with overlapping IPs in different address scopes not whether other implementations must honor the forwarding semantics of address scopes.  I agree that they *MUST* respect the forwarding semantics in order to support address scopes.\n\nIf they have a solution for applying these rules while connecting the router to overlapping IPs, I don\u0027t see a reason to prevent them from doing so.  I\u0027d like to explore solutions to this in the reference implementation also.","commit_id":"3e94111d6b83ea30aecdf388d4ba102c39b7251d"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"5f75c1e4f747597cad6477c1033e3a94b67ca041","unresolved":false,"context_lines":[{"line_number":209,"context_line":""},{"line_number":210,"context_line":"Due to these complications the router will still refuse to connect to"},{"line_number":211,"context_line":"overlapping subnets.  We can look in to an implementation that overcomes these"},{"line_number":212,"context_line":"limitations in the future."}],"source_content_type":"text/x-rst","patch_set":13,"id":"5a5ae5dd_f35c53f2","line":212,"in_reply_to":"5a5ae5dd_8f52b033","updated":"2016-02-09 03:41:28.000000000","message":"Carl,\n\nhow about filing a bug for the limitation\nto make it clear what\u0027s the spec-wise correct behaviour?","commit_id":"3e94111d6b83ea30aecdf388d4ba102c39b7251d"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"072b09da0835523c233f0a96c85fa422f73b9dc6","unresolved":false,"context_lines":[{"line_number":209,"context_line":""},{"line_number":210,"context_line":"Due to these complications the router will still refuse to connect to"},{"line_number":211,"context_line":"overlapping subnets.  We can look in to an implementation that overcomes these"},{"line_number":212,"context_line":"limitations in the future."}],"source_content_type":"text/x-rst","patch_set":13,"id":"5a5ae5dd_4872e8ae","line":212,"in_reply_to":"5a5ae5dd_d50c8344","updated":"2016-02-04 21:32:24.000000000","message":"IMO Other implementations MUST implement the same behaviour. If an implementation of the L3 service supports address scope, it must respect the rules for forwarding traffic in a router within the same address scope only.","commit_id":"3e94111d6b83ea30aecdf388d4ba102c39b7251d"}],"neutron/agent/l3/dvr_edge_router.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"83a51db5809ce1f9c37fb9a60c2dc2b400739115","unresolved":false,"context_lines":[{"line_number":225,"context_line":"                iptables_manager, ports_scopemark,"},{"line_number":226,"context_line":"                self.address_scope_mangle_rule)"},{"line_number":227,"context_line":"            self.process_external_port_address_scope_routing(iptables_manager)"},{"line_number":228,"context_line":"            self.process_floating_ip_address_scope_rules(iptables_manager)"},{"line_number":229,"context_line":"        super(DvrEdgeRouter, self).process_address_scope()"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    def init_snat_iptables_for_address_scope(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a68dd71_0429f936","line":228,"updated":"2016-01-24 11:22:50.000000000","message":"dvr edge router should not consider floatingip","commit_id":"d9b9a6655c73d7f3b8eded49953319be57b53e1a"}],"neutron/agent/l3/dvr_local_router.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"efbb9b1186c0d1e0c9594f48e91e7dec7c5945b1","unresolved":false,"context_lines":[{"line_number":414,"context_line":"    def _handle_router_snat_rules(self, ex_gw_port, interface_name):"},{"line_number":415,"context_line":"        pass"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"    def process_external_port_address_scope_routing(self):"},{"line_number":418,"context_line":"        pass"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"    def process_external(self, agent):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_0f2c0daa","line":417,"range":{"start_line":417,"start_character":8,"end_line":417,"end_character":51},"updated":"2016-01-20 04:43:07.000000000","message":"Is this still needed?","commit_id":"dece2de2067980fefa428b5fb14799a5e6b43118"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"67de3e81edfe5652389e1d41c44f64055064d512","unresolved":false,"context_lines":[{"line_number":414,"context_line":"    def _handle_router_snat_rules(self, ex_gw_port, interface_name):"},{"line_number":415,"context_line":"        pass"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"    def process_external_port_address_scope_routing(self):"},{"line_number":418,"context_line":"        pass"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"    def process_external(self, agent):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_965fade4","line":417,"range":{"start_line":417,"start_character":8,"end_line":417,"end_character":51},"in_reply_to":"ba63e191_0f2c0daa","updated":"2016-01-20 10:56:10.000000000","message":"I will remove it for now","commit_id":"dece2de2067980fefa428b5fb14799a5e6b43118"}],"neutron/agent/l3/ha.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"efbb9b1186c0d1e0c9594f48e91e7dec7c5945b1","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            self._update_metadata_proxy(ri, router_id, state)"},{"line_number":128,"context_line":"        self._update_radvd_daemon(ri, state)"},{"line_number":129,"context_line":"        self.state_change_notifier.queue_event((router_id, state))"},{"line_number":130,"context_line":"        ri.process_address_scope()"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def _configure_ipv6_ra_on_ext_gw_port_if_necessary(self, ri, state):"},{"line_number":133,"context_line":"        # If ipv6 is enabled on the platform, ipv6_gateway config flag is"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_6f134967","line":130,"range":{"start_line":130,"start_character":11,"end_line":130,"end_character":32},"updated":"2016-01-20 04:43:07.000000000","message":"I\u0027ve not testing HA at all.  Is this still necessary?","commit_id":"dece2de2067980fefa428b5fb14799a5e6b43118"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"67de3e81edfe5652389e1d41c44f64055064d512","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            self._update_metadata_proxy(ri, router_id, state)"},{"line_number":128,"context_line":"        self._update_radvd_daemon(ri, state)"},{"line_number":129,"context_line":"        self.state_change_notifier.queue_event((router_id, state))"},{"line_number":130,"context_line":"        ri.process_address_scope()"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def _configure_ipv6_ra_on_ext_gw_port_if_necessary(self, ri, state):"},{"line_number":133,"context_line":"        # If ipv6 is enabled on the platform, ipv6_gateway config flag is"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_f6ee29b3","line":130,"range":{"start_line":130,"start_character":11,"end_line":130,"end_character":32},"in_reply_to":"ba63e191_6f134967","updated":"2016-01-20 10:56:10.000000000","message":"I will remove it for now","commit_id":"dece2de2067980fefa428b5fb14799a5e6b43118"}],"neutron/agent/l3/ha_router.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"efbb9b1186c0d1e0c9594f48e91e7dec7c5945b1","unresolved":false,"context_lines":[{"line_number":364,"context_line":""},{"line_number":365,"context_line":"    def process_address_scope(self):"},{"line_number":366,"context_line":"        if self.ha_state \u003d\u003d \u0027master\u0027:"},{"line_number":367,"context_line":"            with lockutils.lock(self.router_id,"},{"line_number":368,"context_line":"                                common_utils.SYNCHRONIZED_PREFIX, True):"},{"line_number":369,"context_line":"                super(HaRouter, self).process_address_scope()"},{"line_number":370,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_d203f80b","line":367,"range":{"start_line":367,"start_character":17,"end_line":367,"end_character":26},"updated":"2016-01-20 04:43:07.000000000","message":"None of this locking should be needed when the routing table manager is no longer used.","commit_id":"dece2de2067980fefa428b5fb14799a5e6b43118"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"67de3e81edfe5652389e1d41c44f64055064d512","unresolved":false,"context_lines":[{"line_number":364,"context_line":""},{"line_number":365,"context_line":"    def process_address_scope(self):"},{"line_number":366,"context_line":"        if self.ha_state \u003d\u003d \u0027master\u0027:"},{"line_number":367,"context_line":"            with lockutils.lock(self.router_id,"},{"line_number":368,"context_line":"                                common_utils.SYNCHRONIZED_PREFIX, True):"},{"line_number":369,"context_line":"                super(HaRouter, self).process_address_scope()"},{"line_number":370,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_d621a5fc","line":367,"range":{"start_line":367,"start_character":17,"end_line":367,"end_character":26},"in_reply_to":"ba63e191_d203f80b","updated":"2016-01-20 10:56:10.000000000","message":"I will remove it","commit_id":"dece2de2067980fefa428b5fb14799a5e6b43118"}],"neutron/agent/l3/router_info.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"efbb9b1186c0d1e0c9594f48e91e7dec7c5945b1","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from neutron._i18n import _LE, _LW"},{"line_number":21,"context_line":"from neutron.agent.l3 import namespaces"},{"line_number":22,"context_line":"from neutron.agent.l3 import rt_tables"},{"line_number":23,"context_line":"from neutron.agent.linux import ip_lib"},{"line_number":24,"context_line":"from neutron.agent.linux import iptables_manager"},{"line_number":25,"context_line":"from neutron.agent.linux import ra"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_b29c44c1","line":22,"range":{"start_line":22,"start_character":29,"end_line":22,"end_character":38},"updated":"2016-01-20 04:43:07.000000000","message":"Right now rt_tables is still used.  The *only* thing it is used for now is to allocate an id for the packet and connection marking in iptables.  We should be able to easily rip this out and replace it with a dict.  SInce it is all iptables, I don\u0027t think that we need to persist the allocations at all.\n\nI meant to get to this but I didn\u0027t because it wasn\u0027t essential to proving this concept.","commit_id":"dece2de2067980fefa428b5fb14799a5e6b43118"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"67de3e81edfe5652389e1d41c44f64055064d512","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from neutron._i18n import _LE, _LW"},{"line_number":21,"context_line":"from neutron.agent.l3 import namespaces"},{"line_number":22,"context_line":"from neutron.agent.l3 import rt_tables"},{"line_number":23,"context_line":"from neutron.agent.linux import ip_lib"},{"line_number":24,"context_line":"from neutron.agent.linux import iptables_manager"},{"line_number":25,"context_line":"from neutron.agent.linux import ra"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_166f3d2c","line":22,"range":{"start_line":22,"start_character":29,"end_line":22,"end_character":38},"in_reply_to":"ba63e191_b29c44c1","updated":"2016-01-20 10:56:10.000000000","message":"Done","commit_id":"dece2de2067980fefa428b5fb14799a5e6b43118"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"efbb9b1186c0d1e0c9594f48e91e7dec7c5945b1","unresolved":false,"context_lines":[{"line_number":33,"context_line":"EXTERNAL_DEV_PREFIX \u003d namespaces.EXTERNAL_DEV_PREFIX"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"FLOATINGIP_STATUS_NOCHANGE \u003d object()"},{"line_number":36,"context_line":"AS_DEFAULT_TABLE \u003d \"noscope\""},{"line_number":37,"context_line":"ADDRESS_SCOPE_MARK_MASK \u003d \"0xffff0000\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_123190ec","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":16},"updated":"2016-01-20 04:43:07.000000000","message":"I think this can come out when the routing tables manager is no longer used.","commit_id":"dece2de2067980fefa428b5fb14799a5e6b43118"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"67de3e81edfe5652389e1d41c44f64055064d512","unresolved":false,"context_lines":[{"line_number":33,"context_line":"EXTERNAL_DEV_PREFIX \u003d namespaces.EXTERNAL_DEV_PREFIX"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"FLOATINGIP_STATUS_NOCHANGE \u003d object()"},{"line_number":36,"context_line":"AS_DEFAULT_TABLE \u003d \"noscope\""},{"line_number":37,"context_line":"ADDRESS_SCOPE_MARK_MASK \u003d \"0xffff0000\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_16565d5c","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":16},"in_reply_to":"ba63e191_123190ec","updated":"2016-01-20 10:56:10.000000000","message":"I will keep this const as the name of default address scope","commit_id":"dece2de2067980fefa428b5fb14799a5e6b43118"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"efbb9b1186c0d1e0c9594f48e91e7dec7c5945b1","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            router_id, agent_conf, interface_driver, use_ipv6)"},{"line_number":58,"context_line":"        self.router_namespace \u003d ns"},{"line_number":59,"context_line":"        self.ns_name \u003d ns.name"},{"line_number":60,"context_line":"        self.rt_tables_manager \u003d rt_tables.RoutingTablesManager(ns.name)"},{"line_number":61,"context_line":"        self.iptables_manager \u003d iptables_manager.IptablesManager("},{"line_number":62,"context_line":"            use_ipv6\u003duse_ipv6,"},{"line_number":63,"context_line":"            namespace\u003dself.ns_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_72a6cc11","line":60,"range":{"start_line":60,"start_character":13,"end_line":60,"end_character":30},"updated":"2016-01-20 04:43:07.000000000","message":"This should go away.","commit_id":"dece2de2067980fefa428b5fb14799a5e6b43118"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"67de3e81edfe5652389e1d41c44f64055064d512","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            router_id, agent_conf, interface_driver, use_ipv6)"},{"line_number":58,"context_line":"        self.router_namespace \u003d ns"},{"line_number":59,"context_line":"        self.ns_name \u003d ns.name"},{"line_number":60,"context_line":"        self.rt_tables_manager \u003d rt_tables.RoutingTablesManager(ns.name)"},{"line_number":61,"context_line":"        self.iptables_manager \u003d iptables_manager.IptablesManager("},{"line_number":62,"context_line":"            use_ipv6\u003duse_ipv6,"},{"line_number":63,"context_line":"            namespace\u003dself.ns_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_d64f65bb","line":60,"range":{"start_line":60,"start_character":13,"end_line":60,"end_character":30},"in_reply_to":"ba63e191_72a6cc11","updated":"2016-01-20 10:56:10.000000000","message":"Done","commit_id":"dece2de2067980fefa428b5fb14799a5e6b43118"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"efbb9b1186c0d1e0c9594f48e91e7dec7c5945b1","unresolved":false,"context_lines":[{"line_number":173,"context_line":"                self.iptables_manager.ipv4[\u0027nat\u0027].add_rule(chain, rule,"},{"line_number":174,"context_line":"                                                           tag\u003d\u0027floating_ip\u0027)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        self.iptables_manager.apply()"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def process_floating_ip_mangle_rules(self):"},{"line_number":179,"context_line":"        \"\"\"Configure mangle rules for the router\u0027s floating IPs.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_d2869864","line":176,"range":{"start_line":176,"start_character":30,"end_line":176,"end_character":35},"updated":"2016-01-20 04:43:07.000000000","message":"I\u0027m not sure why apply is called here.  Does it need to be?","commit_id":"dece2de2067980fefa428b5fb14799a5e6b43118"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"689f5e9caa656ae1fe9db5d9c55d094be2396e45","unresolved":false,"context_lines":[{"line_number":173,"context_line":"                self.iptables_manager.ipv4[\u0027nat\u0027].add_rule(chain, rule,"},{"line_number":174,"context_line":"                                                           tag\u003d\u0027floating_ip\u0027)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        self.iptables_manager.apply()"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def process_floating_ip_mangle_rules(self):"},{"line_number":179,"context_line":"        \"\"\"Configure mangle rules for the router\u0027s floating IPs.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_a27766d3","line":176,"range":{"start_line":176,"start_character":30,"end_line":176,"end_character":35},"in_reply_to":"ba63e191_bb83bf55","updated":"2016-01-20 17:34:15.000000000","message":"Right, I wasn\u0027t paying close enough attention to notice that it was in the original.  The way gerrit showed the diff made it appear to be new code.  Let\u0027s leave it for now here.  It shouldn\u0027t be harming anything.  I see you removed the one on L198 in your latest patch set.  That is good.","commit_id":"dece2de2067980fefa428b5fb14799a5e6b43118"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"67de3e81edfe5652389e1d41c44f64055064d512","unresolved":false,"context_lines":[{"line_number":173,"context_line":"                self.iptables_manager.ipv4[\u0027nat\u0027].add_rule(chain, rule,"},{"line_number":174,"context_line":"                                                           tag\u003d\u0027floating_ip\u0027)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        self.iptables_manager.apply()"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def process_floating_ip_mangle_rules(self):"},{"line_number":179,"context_line":"        \"\"\"Configure mangle rules for the router\u0027s floating IPs.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_bb83bf55","line":176,"range":{"start_line":176,"start_character":30,"end_line":176,"end_character":35},"in_reply_to":"ba63e191_d2869864","updated":"2016-01-20 10:56:10.000000000","message":"It is from legacy code. But after checking around, I think it can be removed, because all iptables will be applied in the with block in process_external. It is an unrelated change, I would like to post it as another patch.","commit_id":"dece2de2067980fefa428b5fb14799a5e6b43118"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"efbb9b1186c0d1e0c9594f48e91e7dec7c5945b1","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        self.router[l3_constants.FLOATINGIP_KEY] \u003d []"},{"line_number":295,"context_line":"        self.process_delete(agent)"},{"line_number":296,"context_line":"        self.disable_radvd()"},{"line_number":297,"context_line":"        if self.rt_tables_manager:"},{"line_number":298,"context_line":"            self.rt_tables_manager.destroy()"},{"line_number":299,"context_line":"        self.router_namespace.delete()"},{"line_number":300,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_329854c0","line":297,"range":{"start_line":297,"start_character":16,"end_line":297,"end_character":33},"updated":"2016-01-20 04:43:07.000000000","message":"This should go away.","commit_id":"dece2de2067980fefa428b5fb14799a5e6b43118"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"67de3e81edfe5652389e1d41c44f64055064d512","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        self.router[l3_constants.FLOATINGIP_KEY] \u003d []"},{"line_number":295,"context_line":"        self.process_delete(agent)"},{"line_number":296,"context_line":"        self.disable_radvd()"},{"line_number":297,"context_line":"        if self.rt_tables_manager:"},{"line_number":298,"context_line":"            self.rt_tables_manager.destroy()"},{"line_number":299,"context_line":"        self.router_namespace.delete()"},{"line_number":300,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_9bf7dbf4","line":297,"range":{"start_line":297,"start_character":16,"end_line":297,"end_character":33},"in_reply_to":"ba63e191_329854c0","updated":"2016-01-20 10:56:10.000000000","message":"Done","commit_id":"dece2de2067980fefa428b5fb14799a5e6b43118"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"efbb9b1186c0d1e0c9594f48e91e7dec7c5945b1","unresolved":false,"context_lines":[{"line_number":333,"context_line":"                                          fixed_ip[\u0027ip_address\u0027],"},{"line_number":334,"context_line":"                                          self.agent_conf)"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"    def _get_routing_tables(self, port):"},{"line_number":337,"context_line":"        \"\"\"Get the IP version 4 and 6 routing tables for the port"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"        If RPC sends address scopes with the port, map them to a routing table"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_f2915c9a","line":336,"range":{"start_line":336,"start_character":8,"end_line":336,"end_character":27},"updated":"2016-01-20 04:43:07.000000000","message":"This should go away","commit_id":"dece2de2067980fefa428b5fb14799a5e6b43118"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"67de3e81edfe5652389e1d41c44f64055064d512","unresolved":false,"context_lines":[{"line_number":333,"context_line":"                                          fixed_ip[\u0027ip_address\u0027],"},{"line_number":334,"context_line":"                                          self.agent_conf)"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"    def _get_routing_tables(self, port):"},{"line_number":337,"context_line":"        \"\"\"Get the IP version 4 and 6 routing tables for the port"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"        If RPC sends address scopes with the port, map them to a routing table"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_3bdfcf6a","line":336,"range":{"start_line":336,"start_character":8,"end_line":336,"end_character":27},"in_reply_to":"ba63e191_f2915c9a","updated":"2016-01-20 10:56:10.000000000","message":"Done","commit_id":"dece2de2067980fefa428b5fb14799a5e6b43118"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"efbb9b1186c0d1e0c9594f48e91e7dec7c5945b1","unresolved":false,"context_lines":[{"line_number":787,"context_line":"        return {l3_constants.IP_VERSION_4: devicename_scopemark_v4,"},{"line_number":788,"context_line":"                l3_constants.IP_VERSION_6: devicename_scopemark_v6}"},{"line_number":789,"context_line":""},{"line_number":790,"context_line":"    def process_ports_address_scope_iptables(self):"},{"line_number":791,"context_line":"        # Prepare address scope iptables rule for internal ports"},{"line_number":792,"context_line":"        internal_ports \u003d self.router.get(l3_constants.INTERFACE_KEY, [])"},{"line_number":793,"context_line":"        ports_scopemark \u003d self._get_port_devicename_scopemark("}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_32dff46a","line":790,"range":{"start_line":790,"start_character":8,"end_line":790,"end_character":44},"updated":"2016-01-20 04:43:07.000000000","message":"This method seems much more complicated than it needs to be.  Can\u0027t we just delete all of the rules and add the right ones back?  Since this is iptables, nothing will be applied until we\u0027re done and then everything will be applied in one shot, right?  I meant to look in to simplifying this method today but I didn\u0027t get to it.","commit_id":"dece2de2067980fefa428b5fb14799a5e6b43118"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"67de3e81edfe5652389e1d41c44f64055064d512","unresolved":false,"context_lines":[{"line_number":787,"context_line":"        return {l3_constants.IP_VERSION_4: devicename_scopemark_v4,"},{"line_number":788,"context_line":"                l3_constants.IP_VERSION_6: devicename_scopemark_v6}"},{"line_number":789,"context_line":""},{"line_number":790,"context_line":"    def process_ports_address_scope_iptables(self):"},{"line_number":791,"context_line":"        # Prepare address scope iptables rule for internal ports"},{"line_number":792,"context_line":"        internal_ports \u003d self.router.get(l3_constants.INTERFACE_KEY, [])"},{"line_number":793,"context_line":"        ports_scopemark \u003d self._get_port_devicename_scopemark("}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_1360af00","line":790,"range":{"start_line":790,"start_character":8,"end_line":790,"end_character":44},"in_reply_to":"ba63e191_32dff46a","updated":"2016-01-20 10:56:10.000000000","message":"That could be simplified as your comment.","commit_id":"dece2de2067980fefa428b5fb14799a5e6b43118"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"efbb9b1186c0d1e0c9594f48e91e7dec7c5945b1","unresolved":false,"context_lines":[{"line_number":863,"context_line":"                        \u0027snat\u0027, rule, top\u003dTrue)"},{"line_number":864,"context_line":""},{"line_number":865,"context_line":"    def process_address_scope(self):"},{"line_number":866,"context_line":"        with self.rt_tables_manager:"},{"line_number":867,"context_line":"            self.process_ports_address_scope_iptables()"},{"line_number":868,"context_line":"            self.process_external_port_address_scope_routing()"},{"line_number":869,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_f2e87c12","line":866,"range":{"start_line":866,"start_character":18,"end_line":866,"end_character":35},"updated":"2016-01-20 04:43:07.000000000","message":"This should go away.","commit_id":"dece2de2067980fefa428b5fb14799a5e6b43118"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"67de3e81edfe5652389e1d41c44f64055064d512","unresolved":false,"context_lines":[{"line_number":863,"context_line":"                        \u0027snat\u0027, rule, top\u003dTrue)"},{"line_number":864,"context_line":""},{"line_number":865,"context_line":"    def process_address_scope(self):"},{"line_number":866,"context_line":"        with self.rt_tables_manager:"},{"line_number":867,"context_line":"            self.process_ports_address_scope_iptables()"},{"line_number":868,"context_line":"            self.process_external_port_address_scope_routing()"},{"line_number":869,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_f32b9b92","line":866,"range":{"start_line":866,"start_character":18,"end_line":866,"end_character":35},"in_reply_to":"ba63e191_f2e87c12","updated":"2016-01-20 10:56:10.000000000","message":"Done","commit_id":"dece2de2067980fefa428b5fb14799a5e6b43118"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"67de3e81edfe5652389e1d41c44f64055064d512","unresolved":false,"context_lines":[{"line_number":871,"context_line":"            self.process_floating_ip_mangle_rules()"},{"line_number":872,"context_line":""},{"line_number":873,"context_line":"            # Add a block for traffic that shouldn\u0027t cross scope"},{"line_number":874,"context_line":"            self.iptables_manager.ipv4[\u0027nat\u0027].add_rule("},{"line_number":875,"context_line":"                \u0027snat\u0027, \u0027-j $float-snat\u0027)"},{"line_number":876,"context_line":""},{"line_number":877,"context_line":"    @common_utils.exception_logger()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_1643bd43","line":874,"updated":"2016-01-20 10:56:10.000000000","message":"I think this rule is duplicated with line 704, I will remove it for now.","commit_id":"dece2de2067980fefa428b5fb14799a5e6b43118"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"a9cbcde3955435cd17b443a9eb20b7066f4a8362","unresolved":false,"context_lines":[{"line_number":414,"context_line":"        self.radvd.disable()"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"    def internal_network_updated(self, interface_name, ip_cidrs):"},{"line_number":417,"context_line":"        self.driver.init_router_port("},{"line_number":418,"context_line":"            interface_name,"},{"line_number":419,"context_line":"            ip_cidrs\u003dip_cidrs,"},{"line_number":420,"context_line":"            namespace\u003dself.ns_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_1140f555","line":417,"range":{"start_line":417,"start_character":20,"end_line":417,"end_character":36},"updated":"2016-01-20 19:52:14.000000000","message":"I\u0027m not sure why this wasn\u0027t init_router_port before.","commit_id":"8fd4158bc8c2f827fe36046f3101f7c71710d1bc"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f68162979196004c7b88aa9ea651424863b8d959","unresolved":false,"context_lines":[{"line_number":781,"context_line":"            device_name \u003d name_generator(p[\u0027id\u0027])"},{"line_number":782,"context_line":"            ip_cidrs \u003d common_utils.fixed_ip_cidrs(p[\u0027fixed_ips\u0027])"},{"line_number":783,"context_line":"            for ip_version in {ip_lib.get_ip_version(cidr)"},{"line_number":784,"context_line":"                               for cidr in ip_cidrs}:"},{"line_number":785,"context_line":"                port_as_marks \u003d self.get_port_address_scope_mark(p)"},{"line_number":786,"context_line":"                devicename_scopemark[ip_version][device_name] \u003d ("},{"line_number":787,"context_line":"                    port_as_marks[ip_version])"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_f16d21cd","line":784,"updated":"2016-01-20 19:40:32.000000000","message":"This is possibly only doing IPv4, but the caller will always do both.  Seems like it could be a problem.","commit_id":"8fd4158bc8c2f827fe36046f3101f7c71710d1bc"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"865619e645b000dc951aea194d07ff58e33a3c71","unresolved":false,"context_lines":[{"line_number":781,"context_line":"            device_name \u003d name_generator(p[\u0027id\u0027])"},{"line_number":782,"context_line":"            ip_cidrs \u003d common_utils.fixed_ip_cidrs(p[\u0027fixed_ips\u0027])"},{"line_number":783,"context_line":"            for ip_version in {ip_lib.get_ip_version(cidr)"},{"line_number":784,"context_line":"                               for cidr in ip_cidrs}:"},{"line_number":785,"context_line":"                port_as_marks \u003d self.get_port_address_scope_mark(p)"},{"line_number":786,"context_line":"                devicename_scopemark[ip_version][device_name] \u003d ("},{"line_number":787,"context_line":"                    port_as_marks[ip_version])"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_8c1dacbf","line":784,"in_reply_to":"9a68dd71_2c2600bb","updated":"2016-01-20 20:08:40.000000000","message":"Since the return dict is initialized on L778 with both ip versions, I don\u0027t think we have a problem.","commit_id":"8fd4158bc8c2f827fe36046f3101f7c71710d1bc"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"abb2c438db25961411a95981d9a29bc4e7c0d8c8","unresolved":false,"context_lines":[{"line_number":781,"context_line":"            device_name \u003d name_generator(p[\u0027id\u0027])"},{"line_number":782,"context_line":"            ip_cidrs \u003d common_utils.fixed_ip_cidrs(p[\u0027fixed_ips\u0027])"},{"line_number":783,"context_line":"            for ip_version in {ip_lib.get_ip_version(cidr)"},{"line_number":784,"context_line":"                               for cidr in ip_cidrs}:"},{"line_number":785,"context_line":"                port_as_marks \u003d self.get_port_address_scope_mark(p)"},{"line_number":786,"context_line":"                devicename_scopemark[ip_version][device_name] \u003d ("},{"line_number":787,"context_line":"                    port_as_marks[ip_version])"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_2c2600bb","line":784,"in_reply_to":"9a68dd71_f16d21cd","updated":"2016-01-20 19:54:22.000000000","message":"I\u0027ll look in to this.","commit_id":"8fd4158bc8c2f827fe36046f3101f7c71710d1bc"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f68162979196004c7b88aa9ea651424863b8d959","unresolved":false,"context_lines":[{"line_number":822,"context_line":"                    \u0027scope\u0027,"},{"line_number":823,"context_line":"                    self.address_scope_mangle_rule(device_name, mark))"},{"line_number":824,"context_line":"                if dont_block_external and device_name \u003d\u003d external_device_name:"},{"line_number":825,"context_line":"                        continue"},{"line_number":826,"context_line":"                iptables[\u0027filter\u0027].add_rule("},{"line_number":827,"context_line":"                    \u0027scope\u0027,"},{"line_number":828,"context_line":"                    self.address_scope_filter_rule(device_name, mark))"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_16878b10","line":825,"range":{"start_line":825,"start_character":8,"end_line":825,"end_character":23},"updated":"2016-01-20 19:40:32.000000000","message":"Can\u0027t tell if indent is 4 here","commit_id":"8fd4158bc8c2f827fe36046f3101f7c71710d1bc"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"a9cbcde3955435cd17b443a9eb20b7066f4a8362","unresolved":false,"context_lines":[{"line_number":822,"context_line":"                    \u0027scope\u0027,"},{"line_number":823,"context_line":"                    self.address_scope_mangle_rule(device_name, mark))"},{"line_number":824,"context_line":"                if dont_block_external and device_name \u003d\u003d external_device_name:"},{"line_number":825,"context_line":"                        continue"},{"line_number":826,"context_line":"                iptables[\u0027filter\u0027].add_rule("},{"line_number":827,"context_line":"                    \u0027scope\u0027,"},{"line_number":828,"context_line":"                    self.address_scope_filter_rule(device_name, mark))"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_f6b3d708","line":825,"range":{"start_line":825,"start_character":24,"end_line":825,"end_character":32},"updated":"2016-01-20 19:52:14.000000000","message":"This is indented too much","commit_id":"8fd4158bc8c2f827fe36046f3101f7c71710d1bc"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"a9cbcde3955435cd17b443a9eb20b7066f4a8362","unresolved":false,"context_lines":[{"line_number":827,"context_line":"                    \u0027scope\u0027,"},{"line_number":828,"context_line":"                    self.address_scope_filter_rule(device_name, mark))"},{"line_number":829,"context_line":""},{"line_number":830,"context_line":"    def process_external_port_address_scope_routing(self):"},{"line_number":831,"context_line":"        external_port \u003d self.get_ex_gw_port()"},{"line_number":832,"context_line":"        if external_port:"},{"line_number":833,"context_line":"            external_interface_name \u003d self.get_external_device_name("}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_db5b5c53","line":830,"range":{"start_line":830,"start_character":8,"end_line":830,"end_character":51},"updated":"2016-01-20 19:52:14.000000000","message":"The indentation in this file could be improved.  In general, reverse the sense of the ifs and return early.\n\n  if not external_port:\n      return","commit_id":"8fd4158bc8c2f827fe36046f3101f7c71710d1bc"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"a9cbcde3955435cd17b443a9eb20b7066f4a8362","unresolved":false,"context_lines":[{"line_number":830,"context_line":"    def process_external_port_address_scope_routing(self):"},{"line_number":831,"context_line":"        external_port \u003d self.get_ex_gw_port()"},{"line_number":832,"context_line":"        if external_port:"},{"line_number":833,"context_line":"            external_interface_name \u003d self.get_external_device_name("},{"line_number":834,"context_line":"                external_port[\u0027id\u0027])"},{"line_number":835,"context_line":""},{"line_number":836,"context_line":"            # Insert iptables rule to prevent snat within the same address"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_965ffb0d","line":833,"range":{"start_line":833,"start_character":12,"end_line":833,"end_character":35},"updated":"2016-01-20 19:52:14.000000000","message":"Move this down to where it will be used.","commit_id":"8fd4158bc8c2f827fe36046f3101f7c71710d1bc"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f68162979196004c7b88aa9ea651424863b8d959","unresolved":false,"context_lines":[{"line_number":835,"context_line":""},{"line_number":836,"context_line":"            # Insert iptables rule to prevent snat within the same address"},{"line_number":837,"context_line":"            # scope"},{"line_number":838,"context_line":"            if self._snat_enabled:"},{"line_number":839,"context_line":"                # If external net has address scope, find it"},{"line_number":840,"context_line":"                scopes \u003d external_port.get(\u0027address_scopes\u0027, {})"},{"line_number":841,"context_line":"                address_scope \u003d scopes.get(str(l3_constants.IP_VERSION_4))"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_961dbbbf","line":838,"updated":"2016-01-20 19:40:32.000000000","message":"Looks like this could be the first check:\n\nif not self._snat_enabled:\n    return","commit_id":"8fd4158bc8c2f827fe36046f3101f7c71710d1bc"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"abb2c438db25961411a95981d9a29bc4e7c0d8c8","unresolved":false,"context_lines":[{"line_number":835,"context_line":""},{"line_number":836,"context_line":"            # Insert iptables rule to prevent snat within the same address"},{"line_number":837,"context_line":"            # scope"},{"line_number":838,"context_line":"            if self._snat_enabled:"},{"line_number":839,"context_line":"                # If external net has address scope, find it"},{"line_number":840,"context_line":"                scopes \u003d external_port.get(\u0027address_scopes\u0027, {})"},{"line_number":841,"context_line":"                address_scope \u003d scopes.get(str(l3_constants.IP_VERSION_4))"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_2cffe002","line":838,"in_reply_to":"9a68dd71_961dbbbf","updated":"2016-01-20 19:54:22.000000000","message":"I\u0027m actually ahead of you on that one.  :)","commit_id":"8fd4158bc8c2f827fe36046f3101f7c71710d1bc"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"a9cbcde3955435cd17b443a9eb20b7066f4a8362","unresolved":false,"context_lines":[{"line_number":840,"context_line":"                scopes \u003d external_port.get(\u0027address_scopes\u0027, {})"},{"line_number":841,"context_line":"                address_scope \u003d scopes.get(str(l3_constants.IP_VERSION_4))"},{"line_number":842,"context_line":"                if address_scope:"},{"line_number":843,"context_line":"                    self.get_address_scope_mark_mask(address_scope)"},{"line_number":844,"context_line":"                    rule \u003d \u0027-o %s -m connmark --mark %s -j ACCEPT\u0027 % ("},{"line_number":845,"context_line":"                        external_interface_name,"},{"line_number":846,"context_line":"                        self.get_address_scope_mark_mask(address_scope))"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_76b9272e","line":843,"range":{"start_line":843,"start_character":20,"end_line":843,"end_character":67},"updated":"2016-01-20 19:52:14.000000000","message":"This doesn\u0027t seem to do anything.","commit_id":"8fd4158bc8c2f827fe36046f3101f7c71710d1bc"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f68162979196004c7b88aa9ea651424863b8d959","unresolved":false,"context_lines":[{"line_number":840,"context_line":"                scopes \u003d external_port.get(\u0027address_scopes\u0027, {})"},{"line_number":841,"context_line":"                address_scope \u003d scopes.get(str(l3_constants.IP_VERSION_4))"},{"line_number":842,"context_line":"                if address_scope:"},{"line_number":843,"context_line":"                    self.get_address_scope_mark_mask(address_scope)"},{"line_number":844,"context_line":"                    rule \u003d \u0027-o %s -m connmark --mark %s -j ACCEPT\u0027 % ("},{"line_number":845,"context_line":"                        external_interface_name,"},{"line_number":846,"context_line":"                        self.get_address_scope_mark_mask(address_scope))"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_1b11f4ac","line":843,"updated":"2016-01-20 19:40:32.000000000","message":"Why this and the call on L846?","commit_id":"8fd4158bc8c2f827fe36046f3101f7c71710d1bc"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"27ea16ba3a9fbe3e1c8d61a98e23b9f6448025ba","unresolved":false,"context_lines":[{"line_number":154,"context_line":"                floating_ip, internal_mark))"},{"line_number":155,"context_line":"        mark_traffic_from_floating_ip \u003d ("},{"line_number":156,"context_line":"            \u0027floatingip\u0027, \u0027-s %s -j MARK --set-mark %s\u0027 % ("},{"line_number":157,"context_line":"                fixed_ip, external_mark))"},{"line_number":158,"context_line":"        return [mark_traffic_to_floating_ip,"},{"line_number":159,"context_line":"                mark_traffic_from_floating_ip]"},{"line_number":160,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_e9dbe319","line":157,"updated":"2016-01-21 11:34:52.000000000","message":"This will make the port with fixed IP have full access to the address scope of external network. I don\u0027t think it is an expected behavior.","commit_id":"45e0caf07c2d42a23116dc9fbbd9b8fedd4242dc"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"02b7dcb0e6d8fa34dc6fd68112f27dbbb6866d42","unresolved":false,"context_lines":[{"line_number":154,"context_line":"                floating_ip, internal_mark))"},{"line_number":155,"context_line":"        mark_traffic_from_floating_ip \u003d ("},{"line_number":156,"context_line":"            \u0027floatingip\u0027, \u0027-s %s -j MARK --set-mark %s\u0027 % ("},{"line_number":157,"context_line":"                fixed_ip, external_mark))"},{"line_number":158,"context_line":"        return [mark_traffic_to_floating_ip,"},{"line_number":159,"context_line":"                mark_traffic_from_floating_ip]"},{"line_number":160,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_9c9c7a5e","line":157,"in_reply_to":"9a68dd71_e9dbe319","updated":"2016-01-22 21:08:08.000000000","message":"I thought this was the correct thing to do because later in the\nPOSTROUTING chain, the fixed ip will get SNATed to the floating ip under\nthe same conditions.  So, since the source address will be rewritten\nusing an address in the external address scope then the packet\nshould be marked with the external network\u0027s scope.\n\nSo, my change adds a rule to the mangle table like this:\n\n    -A neutron-l3-agent-PREROUTING -j neutron-l3-agent-floatingip\n    -A neutron-l3-agent-floatingip -s 172.16.0.3/32 -j MARK --set-xmark 0x4000000/0xffff0000\n\nLater, the following is added for the same floating ip in the nat table:\n\n    -A POSTROUTING -j neutron-postrouting-bottom\n    -A neutron-postrouting-bottom -j neutron-l3-agent-snat\n    -A neutron-l3-agent-snat -j neutron-l3-agent-float-snat\n    -A neutron-l3-agent-float-snat -s 172.16.0.3/32 -j SNAT --to-source 172.24.4.3\n\nThis unconditionally applies SNAT to the same traffic.  This is why I\nadded the unconditional rule to the mangle table to allow the traffic\nto cross scopes like this.\n\n(I copy/pasted this from my email to you and made a few small edits)","commit_id":"45e0caf07c2d42a23116dc9fbbd9b8fedd4242dc"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"27ea16ba3a9fbe3e1c8d61a98e23b9f6448025ba","unresolved":false,"context_lines":[{"line_number":794,"context_line":"            ip_cidrs \u003d common_utils.fixed_ip_cidrs(p[\u0027fixed_ips\u0027])"},{"line_number":795,"context_line":"            for ip_version in {ip_lib.get_ip_version(cidr)"},{"line_number":796,"context_line":"                               for cidr in ip_cidrs}:"},{"line_number":797,"context_line":"                port_as_marks \u003d self.get_port_address_scope_mark(p)"},{"line_number":798,"context_line":"                devicename_scopemark[ip_version][device_name] \u003d ("},{"line_number":799,"context_line":"                    port_as_marks[ip_version])"},{"line_number":800,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_4f823c54","line":797,"updated":"2016-01-21 11:34:52.000000000","message":"This line could be moved after line 794.","commit_id":"45e0caf07c2d42a23116dc9fbbd9b8fedd4242dc"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"02b7dcb0e6d8fa34dc6fd68112f27dbbb6866d42","unresolved":false,"context_lines":[{"line_number":794,"context_line":"            ip_cidrs \u003d common_utils.fixed_ip_cidrs(p[\u0027fixed_ips\u0027])"},{"line_number":795,"context_line":"            for ip_version in {ip_lib.get_ip_version(cidr)"},{"line_number":796,"context_line":"                               for cidr in ip_cidrs}:"},{"line_number":797,"context_line":"                port_as_marks \u003d self.get_port_address_scope_mark(p)"},{"line_number":798,"context_line":"                devicename_scopemark[ip_version][device_name] \u003d ("},{"line_number":799,"context_line":"                    port_as_marks[ip_version])"},{"line_number":800,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_1c164af1","line":797,"in_reply_to":"9a68dd71_4f823c54","updated":"2016-01-22 21:08:08.000000000","message":"Good point.  Thanks.","commit_id":"45e0caf07c2d42a23116dc9fbbd9b8fedd4242dc"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"85b6bbcda1c1533a95ae3890a3843a0fcccb8e97","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    def floating_filter_rules(self, fixed_id, external_devicename,"},{"line_number":157,"context_line":"                              internal_mark):"},{"line_number":158,"context_line":"        allow_traffic_from_fixed_id_to_external \u003d ("},{"line_number":159,"context_line":"            \u0027floatingip\u0027, \u0027-s %s -o %s -m mark --mark %s -j ACCEPT\u0027 % ("},{"line_number":160,"context_line":"                fixed_id, external_devicename, internal_mark))"},{"line_number":161,"context_line":"        return [allow_traffic_from_fixed_id_to_external]"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_bc061e84","line":159,"range":{"start_line":159,"start_character":60,"end_line":159,"end_character":66},"updated":"2016-01-22 21:12:09.000000000","message":"Please see my comment in PS5.  I suspect my rule might have been correct.  If it was, I think I like the MARK to the external address scope better than an ACCEPT here.  It is consistent with how traffic flowing the other way is handled (floating IP DNAT traffic).","commit_id":"c3928d77ebfdde6409e053404e01c0a0d2bda2a5"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"83a51db5809ce1f9c37fb9a60c2dc2b400739115","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        \"\"\""},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        # Clear out all iptables rules for floating ips"},{"line_number":218,"context_line":"        self.iptables_manager.ipv4[\u0027mangle\u0027].empty_chain(\u0027floatingip\u0027)"},{"line_number":219,"context_line":"        self.iptables_manager.ipv4[\u0027filter\u0027].empty_chain(\u0027floatingip\u0027)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        floating_ips \u003d self.get_floating_ips()"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a68dd71_c41f6106","line":218,"updated":"2016-01-24 11:22:50.000000000","message":"I think you want to use iptables_manager without \u0027self.\u0027 here.","commit_id":"d9b9a6655c73d7f3b8eded49953319be57b53e1a"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"74a90ffc7589fcd80f54ad244eb02b1a09121554","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"FLOATINGIP_STATUS_NOCHANGE \u003d object()"},{"line_number":34,"context_line":"ADDRESS_SCOPE_MARK_MASK \u003d \"0xffff0000\""},{"line_number":35,"context_line":"ADDRESS_SCOPE_MARK_IDS \u003d set(range(1024, 2048))"},{"line_number":36,"context_line":"DEFAULT_ADDRESS_SCOPE \u003d \"noscope\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"9a061dce_fce89812","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":47},"updated":"2016-04-05 12:46:03.000000000","message":"https://bugs.launchpad.net/neutron/+bug/1566291","commit_id":"3e94111d6b83ea30aecdf388d4ba102c39b7251d"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"072b09da0835523c233f0a96c85fa422f73b9dc6","unresolved":false,"context_lines":[{"line_number":232,"context_line":"            internal_mark \u003d self.get_address_scope_mark_mask(fixed_scope)"},{"line_number":233,"context_line":"            external_port \u003d self.get_ex_gw_port()"},{"line_number":234,"context_line":"            external_devicename \u003d self.get_external_device_interface_name("},{"line_number":235,"context_line":"                external_port)"},{"line_number":236,"context_line":"            mangle_rules \u003d self.floating_mangle_rules(fip_ip, fixed_ip,"},{"line_number":237,"context_line":"                                                      external_devicename,"},{"line_number":238,"context_line":"                                                      internal_mark)"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_8899c021","line":235,"updated":"2016-02-04 21:32:24.000000000","message":"Lines 233 and 234 can probably lives outside the for loop","commit_id":"3e94111d6b83ea30aecdf388d4ba102c39b7251d"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"a5daa34eb42f428afe39074aa0d43beaa7887881","unresolved":false,"context_lines":[{"line_number":232,"context_line":"            internal_mark \u003d self.get_address_scope_mark_mask(fixed_scope)"},{"line_number":233,"context_line":"            external_port \u003d self.get_ex_gw_port()"},{"line_number":234,"context_line":"            external_devicename \u003d self.get_external_device_interface_name("},{"line_number":235,"context_line":"                external_port)"},{"line_number":236,"context_line":"            mangle_rules \u003d self.floating_mangle_rules(fip_ip, fixed_ip,"},{"line_number":237,"context_line":"                                                      external_devicename,"},{"line_number":238,"context_line":"                                                      internal_mark)"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_72b39c4d","line":235,"in_reply_to":"5a5ae5dd_8899c021","updated":"2016-02-08 17:20:39.000000000","message":"Good point, if we need to crack open this patch, I\u0027ll fix it.  This isn\u0027t a particularly performance sensitive thing so I\u0027m not too concerned about it.  But, it is good practice to avoid redundant calls.","commit_id":"3e94111d6b83ea30aecdf388d4ba102c39b7251d"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7381412525173861e6ac308a15191f4e1b2225d0","unresolved":false,"context_lines":[{"line_number":808,"context_line":"            agent.context, self.router_id, fip_statuses)"},{"line_number":809,"context_line":""},{"line_number":810,"context_line":"    def _get_port_devicename_scopemark(self, ports, name_generator):"},{"line_number":811,"context_line":"        devicename_scopemark \u003d {l3_constants.IP_VERSION_4: dict(),"},{"line_number":812,"context_line":"                                l3_constants.IP_VERSION_6: dict()}"},{"line_number":813,"context_line":"        for p in ports:"},{"line_number":814,"context_line":"            device_name \u003d name_generator(p[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_6e92c3a1","line":811,"updated":"2016-02-08 23:28:43.000000000","message":"defaultdict might have helped you here","commit_id":"3e94111d6b83ea30aecdf388d4ba102c39b7251d"}],"neutron/agent/linux/iptables_manager.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"efbb9b1186c0d1e0c9594f48e91e7dec7c5945b1","unresolved":false,"context_lines":[{"line_number":431,"context_line":""},{"line_number":432,"context_line":"    def get_chain(self, table, chain, ip_version\u003d4, wrap\u003dTrue):"},{"line_number":433,"context_line":"        try:"},{"line_number":434,"context_line":"            requested_table \u003d self.get_tables(ip_version)[table]"},{"line_number":435,"context_line":"        except KeyError:"},{"line_number":436,"context_line":"            return []"},{"line_number":437,"context_line":"        return requested_table._get_chain_rules(chain, wrap)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_72cb2ca6","line":434,"range":{"start_line":434,"start_character":35,"end_line":434,"end_character":45},"updated":"2016-01-20 04:43:07.000000000","message":"I suspect this should change.","commit_id":"dece2de2067980fefa428b5fb14799a5e6b43118"}],"neutron/tests/unit/agent/l3/test_agent.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7381412525173861e6ac308a15191f4e1b2225d0","unresolved":false,"context_lines":[{"line_number":1147,"context_line":"        mangle_rules_delta \u003d ["},{"line_number":1148,"context_line":"            r for r in orig_mangle_rules"},{"line_number":1149,"context_line":"            if r not in ri.iptables_manager.ipv4[\u0027mangle\u0027].rules]"},{"line_number":1150,"context_line":"        self.assertEqual(2, len(mangle_rules_delta))"},{"line_number":1151,"context_line":"        self._verify_snat_mangle_rules(nat_rules_delta, mangle_rules_delta,"},{"line_number":1152,"context_line":"                                       router)"},{"line_number":1153,"context_line":"        self.assertEqual(1, self.send_adv_notif.call_count)"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_ee3a3398","line":1150,"updated":"2016-02-08 23:28:43.000000000","message":"Some might argued these should be removed altogether.","commit_id":"3e94111d6b83ea30aecdf388d4ba102c39b7251d"}],"neutron/tests/unit/agent/test_securitygroups_rpc.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7381412525173861e6ac308a15191f4e1b2225d0","unresolved":false,"context_lines":[{"line_number":1873,"context_line":"-I OUTPUT 1 -j neutron-filter-top"},{"line_number":1874,"context_line":"-I OUTPUT 2 -j %(bn)s-OUTPUT"},{"line_number":1875,"context_line":"-I neutron-filter-top 1 -j %(bn)s-local"},{"line_number":1876,"context_line":"-I %(bn)s-FORWARD 1 -j %(bn)s-scope"},{"line_number":1877,"context_line":"-I %(bn)s-FORWARD 2 %(physdev_mod)s --physdev-INGRESS tap_port1 \\"},{"line_number":1878,"context_line":"%(physdev_is_bridged)s -j %(bn)s-sg-chain"},{"line_number":1879,"context_line":"-I %(bn)s-FORWARD 3 %(physdev_mod)s --physdev-EGRESS tap_port1 \\"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_ceb417d6","line":1876,"updated":"2016-02-08 23:28:43.000000000","message":"Can you elaborate on under which circumstances these are generated vs the old ones? Is there anything we gotta worry about as far as backward compat is concerned?","commit_id":"3e94111d6b83ea30aecdf388d4ba102c39b7251d"}]}
