)]}'
{"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_dvr_neutron_agent.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b4ce7c05a3869513fc0e2cd870f418f5ea8ff9aa","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                          \u0027startup due to RPC error.  It happens when the \u0027"},{"line_number":170,"context_line":"                          \u0027server does not support this RPC API.  Detailed \u0027"},{"line_number":171,"context_line":"                          \u0027message: %s\u0027), e)"},{"line_number":172,"context_line":"            exit(1)"},{"line_number":173,"context_line":"        except oslo_messaging.MessagingTimeout:"},{"line_number":174,"context_line":"            LOG.error(_LE(\u0027DVR: Failed to obtain a valid local \u0027"},{"line_number":175,"context_line":"                          \u0027DVR MAC address\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_26907395","line":172,"updated":"2016-01-20 14:50:56.000000000","message":"Should this be sys.exit(1) ?  Although I do see one place where the non-DVR agent uses exit(1) which probably needs to be fixed.","commit_id":"8a228034ffc7c8a0e6eeb56b6605c91091f09b84"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"831afca5bdd25d90950cbfef309aa08a68ce3558","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                          \u0027startup due to RPC error.  It happens when the \u0027"},{"line_number":170,"context_line":"                          \u0027server does not support this RPC API.  Detailed \u0027"},{"line_number":171,"context_line":"                          \u0027message: %s\u0027), e)"},{"line_number":172,"context_line":"            exit(1)"},{"line_number":173,"context_line":"        except oslo_messaging.MessagingTimeout:"},{"line_number":174,"context_line":"            LOG.error(_LE(\u0027DVR: Failed to obtain a valid local \u0027"},{"line_number":175,"context_line":"                          \u0027DVR MAC address\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_bc86abb7","line":172,"in_reply_to":"9a68dd71_26907395","updated":"2016-01-20 16:29:28.000000000","message":"Done","commit_id":"8a228034ffc7c8a0e6eeb56b6605c91091f09b84"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b4ce7c05a3869513fc0e2cd870f418f5ea8ff9aa","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        except oslo_messaging.MessagingTimeout:"},{"line_number":174,"context_line":"            LOG.error(_LE(\u0027DVR: Failed to obtain a valid local \u0027"},{"line_number":175,"context_line":"                          \u0027DVR MAC address\u0027))"},{"line_number":176,"context_line":"            exit(1)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        if not self.in_distributed_mode():"},{"line_number":179,"context_line":"            # switch all traffic using L2 learning"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_465fa70e","line":176,"updated":"2016-01-20 14:50:56.000000000","message":"nit: To avoid the one-line duplication :)\n\nfinally:\n    if self.dvr_mac_address is None:\n        sys.exit(1)","commit_id":"8a228034ffc7c8a0e6eeb56b6605c91091f09b84"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"831afca5bdd25d90950cbfef309aa08a68ce3558","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        except oslo_messaging.MessagingTimeout:"},{"line_number":174,"context_line":"            LOG.error(_LE(\u0027DVR: Failed to obtain a valid local \u0027"},{"line_number":175,"context_line":"                          \u0027DVR MAC address\u0027))"},{"line_number":176,"context_line":"            exit(1)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        if not self.in_distributed_mode():"},{"line_number":179,"context_line":"            # switch all traffic using L2 learning"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_fc48a389","line":176,"in_reply_to":"9a68dd71_465fa70e","updated":"2016-01-20 16:29:28.000000000","message":"Done, and below block can be deleted as well I guess","commit_id":"8a228034ffc7c8a0e6eeb56b6605c91091f09b84"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"343bd56b592ac7796c600caca9f44f8057181ec4","unresolved":false,"context_lines":[{"line_number":175,"context_line":"            LOG.error(_LE(\u0027DVR: Failed to obtain a valid local \u0027"},{"line_number":176,"context_line":"                          \u0027DVR MAC address\u0027))"},{"line_number":177,"context_line":"        finally:"},{"line_number":178,"context_line":"            if self.dvr_mac_address is None:"},{"line_number":179,"context_line":"                sys.exit(1)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def get_dvr_mac_address_with_retry(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_bf23fd04","line":178,"updated":"2016-01-20 16:35:07.000000000","message":"I would suggest try to use self.in_distributed_mode() here.","commit_id":"f1a28b710b26b629fe72aeabb471b4e83d44925f"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"aca44aa10a892faa9fd7b62f75e05d39fdf009aa","unresolved":false,"context_lines":[{"line_number":175,"context_line":"            LOG.error(_LE(\u0027DVR: Failed to obtain a valid local \u0027"},{"line_number":176,"context_line":"                          \u0027DVR MAC address\u0027))"},{"line_number":177,"context_line":"        finally:"},{"line_number":178,"context_line":"            if self.dvr_mac_address is None:"},{"line_number":179,"context_line":"                sys.exit(1)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def get_dvr_mac_address_with_retry(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_7b657e43","line":178,"in_reply_to":"9a68dd71_0352ea67","updated":"2016-01-21 02:32:44.000000000","message":"Thanks, Brian :)","commit_id":"f1a28b710b26b629fe72aeabb471b4e83d44925f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2acac62e82410dd803350b4a0efdb8901a2b58d8","unresolved":false,"context_lines":[{"line_number":175,"context_line":"            LOG.error(_LE(\u0027DVR: Failed to obtain a valid local \u0027"},{"line_number":176,"context_line":"                          \u0027DVR MAC address\u0027))"},{"line_number":177,"context_line":"        finally:"},{"line_number":178,"context_line":"            if self.dvr_mac_address is None:"},{"line_number":179,"context_line":"                sys.exit(1)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def get_dvr_mac_address_with_retry(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_0352ea67","line":178,"in_reply_to":"9a68dd71_bf23fd04","updated":"2016-01-20 20:55:34.000000000","message":"You mean like was done in the original code? :)\n\nI\u0027ll make that change.","commit_id":"f1a28b710b26b629fe72aeabb471b4e83d44925f"}],"neutron/tests/unit/plugins/ml2/drivers/openvswitch/agent/test_ovs_neutron_agent.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b4ce7c05a3869513fc0e2cd870f418f5ea8ff9aa","unresolved":false,"context_lines":[{"line_number":2600,"context_line":"                mock.patch.object(self.agent, \u0027int_br\u0027, new\u003dint_br),\\"},{"line_number":2601,"context_line":"                mock.patch.object(self.agent.dvr_agent, \u0027int_br\u0027, new\u003dint_br):"},{"line_number":2602,"context_line":"            with testtools.ExpectedException(SystemExit):"},{"line_number":2603,"context_line":"                self.agent.dvr_agent.get_dvr_mac_address()"},{"line_number":2604,"context_line":""},{"line_number":2605,"context_line":"    def test_get_dvr_mac_address_retried(self):"},{"line_number":2606,"context_line":"        valid_entry \u003d {\u0027host\u0027: \u0027cn1\u0027, \u0027mac_address\u0027: \u0027aa:22:33:44:55:66\u0027}"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_a659c390","line":2603,"updated":"2016-01-20 14:50:56.000000000","message":"Should you still verify self.dvr_mac_address is None?","commit_id":"8a228034ffc7c8a0e6eeb56b6605c91091f09b84"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"ac0e46ed9ef41acb3c66f5ed0d0cfec867197220","unresolved":false,"context_lines":[{"line_number":2600,"context_line":"                mock.patch.object(self.agent, \u0027int_br\u0027, new\u003dint_br),\\"},{"line_number":2601,"context_line":"                mock.patch.object(self.agent.dvr_agent, \u0027int_br\u0027, new\u003dint_br):"},{"line_number":2602,"context_line":"            with testtools.ExpectedException(SystemExit):"},{"line_number":2603,"context_line":"                self.agent.dvr_agent.get_dvr_mac_address()"},{"line_number":2604,"context_line":""},{"line_number":2605,"context_line":"    def test_get_dvr_mac_address_retried(self):"},{"line_number":2606,"context_line":"        valid_entry \u003d {\u0027host\u0027: \u0027cn1\u0027, \u0027mac_address\u0027: \u0027aa:22:33:44:55:66\u0027}"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_7f4b45b1","line":2603,"in_reply_to":"9a68dd71_1fe9e91a","updated":"2016-01-20 16:34:56.000000000","message":"Agree, it doesn\u0027t matter. After sys.exit, self.dvr_mac_address will become \"history\".","commit_id":"8a228034ffc7c8a0e6eeb56b6605c91091f09b84"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"831afca5bdd25d90950cbfef309aa08a68ce3558","unresolved":false,"context_lines":[{"line_number":2600,"context_line":"                mock.patch.object(self.agent, \u0027int_br\u0027, new\u003dint_br),\\"},{"line_number":2601,"context_line":"                mock.patch.object(self.agent.dvr_agent, \u0027int_br\u0027, new\u003dint_br):"},{"line_number":2602,"context_line":"            with testtools.ExpectedException(SystemExit):"},{"line_number":2603,"context_line":"                self.agent.dvr_agent.get_dvr_mac_address()"},{"line_number":2604,"context_line":""},{"line_number":2605,"context_line":"    def test_get_dvr_mac_address_retried(self):"},{"line_number":2606,"context_line":"        valid_entry \u003d {\u0027host\u0027: \u0027cn1\u0027, \u0027mac_address\u0027: \u0027aa:22:33:44:55:66\u0027}"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_1fe9e91a","line":2603,"in_reply_to":"9a68dd71_a659c390","updated":"2016-01-20 16:29:28.000000000","message":"we can check but does it matter after SystemExit? :)","commit_id":"8a228034ffc7c8a0e6eeb56b6605c91091f09b84"}]}
