)]}'
{"neutron/agent/l3/router_info.py":[{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"062d74c3f400cf9359a618dff8855e1ac5c37fa5","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                self.iptables_manager.ipv4[\u0027nat\u0027].add_rule(chain, rule,"},{"line_number":160,"context_line":"                                                           tag\u003d\u0027floating_ip\u0027)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        self.iptables_manager.apply()"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def process_snat_dnat_for_fip(self):"},{"line_number":165,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_6d487f5c","side":"PARENT","line":162,"updated":"2016-01-20 16:57:51.000000000","message":"Since defer_apply will turn on iptables_apply_deferred flag, and that will make apply directly return. So no _apply is called indeed. But it\u0027s OK to me to remove the unnecessary code here.","commit_id":"e0beb2be22f07a8fa9452be1ccd8a2e3cf8196c0"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"7198c68a5813e3e9c953e520dcb8dc0537052d27","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                self.iptables_manager.ipv4[\u0027nat\u0027].add_rule(chain, rule,"},{"line_number":160,"context_line":"                                                           tag\u003d\u0027floating_ip\u0027)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        self.iptables_manager.apply()"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def process_snat_dnat_for_fip(self):"},{"line_number":165,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_6daabf72","side":"PARENT","line":162,"in_reply_to":"9a68dd71_6d487f5c","updated":"2016-01-20 17:05:02.000000000","message":"Oops, I checked more. process_floating_ip_nat_rules will be called by method external_gateway_removed in DvrLocalRouter, and later one will be called by _process_external_on_delete.\n\nAnd _process_external_on_delete is different from process_external, it doesn\u0027t have self.iptables_manager.defer_apply() as a with statement. So if L162 is removed here, no iptables apply will be done in external delete processing.","commit_id":"e0beb2be22f07a8fa9452be1ccd8a2e3cf8196c0"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"044e0011e84a3c145d82bbfe9e7a18908066d481","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                self.iptables_manager.ipv4[\u0027nat\u0027].add_rule(chain, rule,"},{"line_number":160,"context_line":"                                                           tag\u003d\u0027floating_ip\u0027)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        self.iptables_manager.apply()"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def process_snat_dnat_for_fip(self):"},{"line_number":165,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_de777838","side":"PARENT","line":162,"in_reply_to":"9a68dd71_6daabf72","updated":"2016-01-22 03:53:51.000000000","message":"Thanks, ZongKai. But _process_external_on_delete was introduced by 300f73d489ce0131035bac59a1f12787e20bf3ab recently. And this apply is here for a long time. I believe its intention it not for the delete process. \n\nFrom the discussion at [1], I think the iptables.apply was removed intentionally in delete process, to avoid unnecessary transaction. And removing this apply here fits the intention in [1].\n\nAnd let\u0027s assume that the iptables is not cleaned up in the delete process. The router namespace will be deleted then. So, there is no pain here. \n\n[1] https://review.openstack.org/#/c/251502/12/neutron/agent/l3/router_info.py","commit_id":"e0beb2be22f07a8fa9452be1ccd8a2e3cf8196c0"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"c36cdbad198a9da3c816a8608933d0e65551da1a","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                self.iptables_manager.ipv4[\u0027nat\u0027].add_rule(chain, rule,"},{"line_number":160,"context_line":"                                                           tag\u003d\u0027floating_ip\u0027)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        self.iptables_manager.apply()"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def process_snat_dnat_for_fip(self):"},{"line_number":165,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_b9789e90","side":"PARENT","line":162,"in_reply_to":"9a68dd71_de777838","updated":"2016-01-22 04:09:06.000000000","message":"So that\u0027s the point, the whole router namespace is going to be deleted, no need to process iptables apply as iptables will no longer exist. OK, make sense to me.","commit_id":"e0beb2be22f07a8fa9452be1ccd8a2e3cf8196c0"}]}
