)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"93246a6f3a265cbe62dc616d8d3fb6c168533e71","unresolved":false,"context_lines":[{"line_number":22,"context_line":"error information."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I17e2f08d274336999abe9426ce4308672fade261"},{"line_number":25,"context_line":"Closes-bug: #1533034"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7a5de9d1_615ce64b","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":20},"updated":"2016-01-28 07:16:38.000000000","message":"I cannot understand what you want. At least, this patch happens a failure with build-in function id in my env.\n\nPlease add UT. Reviewers and I will be able to understand what this patch does if it\u0027s added.","commit_id":"b38c762e5376ac6fae82eea23291c637517bebe0"},{"author":{"_account_id":11208,"name":"Baohua Yang","email":"baohua@linux.vnet.ibm.com","username":"yangbaohua"},"change_message_id":"e45bb1c23409c6922fd51d39f2e5b2a57bf35e05","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove unclear built-in in subnetpool exception"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"from code, we can see that subnetpool_id need to get,"},{"line_number":10,"context_line":"but if we run wrong command. it will execute other judgement first."},{"line_number":11,"context_line":"subnetpool can\u0027t even be created in db, and it will think we have none"},{"line_number":12,"context_line":"subnetpool, it will return ATTR_NOT_SEPCIFIED, which is object class."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a5de9d1_e11cc86b","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":4},"updated":"2016-02-01 07:58:51.000000000","message":"From","commit_id":"cb71e43960fab58fe8575760d717ebcb09f1e339"},{"author":{"_account_id":11208,"name":"Baohua Yang","email":"baohua@linux.vnet.ibm.com","username":"yangbaohua"},"change_message_id":"e45bb1c23409c6922fd51d39f2e5b2a57bf35e05","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove unclear built-in in subnetpool exception"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"from code, we can see that subnetpool_id need to get,"},{"line_number":10,"context_line":"but if we run wrong command. it will execute other judgement first."},{"line_number":11,"context_line":"subnetpool can\u0027t even be created in db, and it will think we have none"},{"line_number":12,"context_line":"subnetpool, it will return ATTR_NOT_SEPCIFIED, which is object class."},{"line_number":13,"context_line":"so there is no subnetpool or id in db. then it will select ATTR_NOT_SPECIFIED,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a5de9d1_01180474","line":10,"range":{"start_line":10,"start_character":27,"end_line":10,"end_character":28},"updated":"2016-02-01 07:58:51.000000000","message":",","commit_id":"cb71e43960fab58fe8575760d717ebcb09f1e339"},{"author":{"_account_id":11208,"name":"Baohua Yang","email":"baohua@linux.vnet.ibm.com","username":"yangbaohua"},"change_message_id":"e45bb1c23409c6922fd51d39f2e5b2a57bf35e05","unresolved":false,"context_lines":[{"line_number":9,"context_line":"from code, we can see that subnetpool_id need to get,"},{"line_number":10,"context_line":"but if we run wrong command. it will execute other judgement first."},{"line_number":11,"context_line":"subnetpool can\u0027t even be created in db, and it will think we have none"},{"line_number":12,"context_line":"subnetpool, it will return ATTR_NOT_SEPCIFIED, which is object class."},{"line_number":13,"context_line":"so there is no subnetpool or id in db. then it will select ATTR_NOT_SPECIFIED,"},{"line_number":14,"context_line":"which equals to object()"},{"line_number":15,"context_line":"that\u0027s why the bug display unclear build-in function id."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a5de9d1_e1b8482c","line":12,"range":{"start_line":12,"start_character":10,"end_line":12,"end_character":11},"updated":"2016-02-01 07:58:51.000000000","message":".","commit_id":"cb71e43960fab58fe8575760d717ebcb09f1e339"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"b5411793b116098755df71df8d8c6a01a86e0077","unresolved":false,"context_lines":[{"line_number":10,"context_line":"but if we run wrong command. it will execute other judgement first."},{"line_number":11,"context_line":"subnetpool can\u0027t even be created in db, and it will think we have none"},{"line_number":12,"context_line":"subnetpool, it will return ATTR_NOT_SEPCIFIED, which is object class."},{"line_number":13,"context_line":"so there is no subnetpool or id in db. then it will select ATTR_NOT_SPECIFIED,"},{"line_number":14,"context_line":"which equals to object()"},{"line_number":15,"context_line":"that\u0027s why the bug display unclear build-in function id."},{"line_number":16,"context_line":"subnetpool_id \u003d subnet.get(\u0027subnetpool_id\u0027,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a5de9d1_65245dc4","line":13,"range":{"start_line":13,"start_character":37,"end_line":13,"end_character":43},"updated":"2016-02-01 11:02:49.000000000","message":"\", then\" or \". Then\"","commit_id":"cb71e43960fab58fe8575760d717ebcb09f1e339"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"b5411793b116098755df71df8d8c6a01a86e0077","unresolved":false,"context_lines":[{"line_number":11,"context_line":"subnetpool can\u0027t even be created in db, and it will think we have none"},{"line_number":12,"context_line":"subnetpool, it will return ATTR_NOT_SEPCIFIED, which is object class."},{"line_number":13,"context_line":"so there is no subnetpool or id in db. then it will select ATTR_NOT_SPECIFIED,"},{"line_number":14,"context_line":"which equals to object()"},{"line_number":15,"context_line":"that\u0027s why the bug display unclear build-in function id."},{"line_number":16,"context_line":"subnetpool_id \u003d subnet.get(\u0027subnetpool_id\u0027,"},{"line_number":17,"context_line":"                             attributes.ATTR_NOT_SPECIFIED)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a5de9d1_c51bd17f","line":14,"updated":"2016-02-01 11:02:49.000000000","message":"missing a comma or dot?","commit_id":"cb71e43960fab58fe8575760d717ebcb09f1e339"},{"author":{"_account_id":11208,"name":"Baohua Yang","email":"baohua@linux.vnet.ibm.com","username":"yangbaohua"},"change_message_id":"e45bb1c23409c6922fd51d39f2e5b2a57bf35e05","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        if subnetpool_id !\u003d attributes.ATTR_NOT_SPECIFIED:"},{"line_number":19,"context_line":"            return subnetpool_id"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"I just reove subnetpool_id from exception msg"},{"line_number":22,"context_line":"Change-Id: I17e2f08d274336999abe9426ce4308672fade261"},{"line_number":23,"context_line":"Closes-bug: #1533034"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a5de9d1_21b3c051","line":21,"range":{"start_line":21,"start_character":7,"end_line":21,"end_character":12},"updated":"2016-02-01 07:58:51.000000000","message":"reuse?","commit_id":"cb71e43960fab58fe8575760d717ebcb09f1e339"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"3e6811e04cf84a08062daf8d2b7b3b36c6e6ce5d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     linwwu \u003cwlwwu@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-02-22 23:08:41 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove unclear built-in in subnetpool exception"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"From code, we can see that subnetpool_id need to get,"},{"line_number":10,"context_line":"but if we run wrong command, it will execute other judgement first."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"bae84128_28e7f340","line":7,"range":{"start_line":7,"start_character":20,"end_line":7,"end_character":21},"updated":"2016-02-23 20:34:56.000000000","message":"Prefer:\n\n Avoid ATTR_NOT_SPECIFIED use in AddressScope exception messages","commit_id":"88cd7bd1240ff820143c6f8294f9c7f1ddf780c1"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"3e6811e04cf84a08062daf8d2b7b3b36c6e6ce5d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove unclear built-in in subnetpool exception"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"From code, we can see that subnetpool_id need to get,"},{"line_number":10,"context_line":"but if we run wrong command, it will execute other judgement first."},{"line_number":11,"context_line":"subnetpool can\u0027t even be created in db, and it will think we have none"},{"line_number":12,"context_line":"subnetpool. It will return ATTR_NOT_SEPCIFIED, which is object class."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"bae84128_e8422bad","line":9,"range":{"start_line":9,"start_character":5,"end_line":9,"end_character":9},"updated":"2016-02-23 20:34:56.000000000","message":"Prefer (iiuc the commit message):\n\nA HTTP exception is raised when you try to create a subnetpool associated to an address scope with an inconsistent ip-version. Currently this exception message contains \" \u003cbuilt-in function id\u003e\" as subnetpool_id because the subnetpool is about to be created so its subnetpool_id is  ATTR_NOT_SPECIFIED (\u003d\u003d object())!\n\nThis change proposes to remove subnetpool_id from previous exception because subnetpool_id is always unset when the error is raised.\n\nCloses-Bug: ...","commit_id":"88cd7bd1240ff820143c6f8294f9c7f1ddf780c1"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"c4b0c671013c8a4f2872fbb172dc6f2575c2b742","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove unclear built-in in subnetpool exception"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"I just remove subnetpool_id from exception msg. We will not use subnetpool_id in execption."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I17e2f08d274336999abe9426ce4308672fade261"},{"line_number":12,"context_line":"Closes-bug: #1533034"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"bae84128_c19a7913","line":9,"range":{"start_line":9,"start_character":51,"end_line":9,"end_character":55},"updated":"2016-02-24 12:54:07.000000000","message":"Line to wrap","commit_id":"6df5f1389eff44feb7d932eac98c87b5113f3fe4"},{"author":{"_account_id":19383,"name":"linwei wu","email":"wlwwu@cn.ibm.com","username":"linwwu"},"change_message_id":"ad77fec4bc5df1e01697d63b6fbb5d9fa24e6262","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove unclear built-in in subnetpool exception"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"I just remove subnetpool_id from exception msg. We will not use subnetpool_id in execption."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I17e2f08d274336999abe9426ce4308672fade261"},{"line_number":12,"context_line":"Closes-bug: #1533034"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"bae84128_107470fb","line":9,"range":{"start_line":9,"start_character":51,"end_line":9,"end_character":55},"in_reply_to":"bae84128_10d8f01c","updated":"2016-02-25 08:16:16.000000000","message":"thx. I will post a new branch","commit_id":"6df5f1389eff44feb7d932eac98c87b5113f3fe4"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"a8528dcd0fecb30d95021bdbc311f3a0ab36bb7c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove unclear built-in in subnetpool exception"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"I just remove subnetpool_id from exception msg. We will not use subnetpool_id in execption."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I17e2f08d274336999abe9426ce4308672fade261"},{"line_number":12,"context_line":"Closes-bug: #1533034"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"bae84128_90afe093","line":9,"range":{"start_line":9,"start_character":51,"end_line":9,"end_character":55},"in_reply_to":"bae84128_252fb8a2","updated":"2016-02-25 08:16:08.000000000","message":"From [1], \"Subsequent lines should be wrapped at 72 characters\"\n\n[1] https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"6df5f1389eff44feb7d932eac98c87b5113f3fe4"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"136ea8b3501773f71b07cb9f7888ba71bebf8f19","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove unclear built-in in subnetpool exception"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"I just remove subnetpool_id from exception msg. We will not use subnetpool_id in execption."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I17e2f08d274336999abe9426ce4308672fade261"},{"line_number":12,"context_line":"Closes-bug: #1533034"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"bae84128_10d8f01c","line":9,"range":{"start_line":9,"start_character":51,"end_line":9,"end_character":55},"in_reply_to":"bae84128_252fb8a2","updated":"2016-02-25 08:12:54.000000000","message":"This line is too long. Commit message guideline[1] says 72 characters on a line. So you should just add a new line.\n\n[1]: https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"6df5f1389eff44feb7d932eac98c87b5113f3fe4"},{"author":{"_account_id":19383,"name":"linwei wu","email":"wlwwu@cn.ibm.com","username":"linwwu"},"change_message_id":"54c85b2f33399666663bb9726fae20069ad542fd","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove unclear built-in in subnetpool exception"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"I just remove subnetpool_id from exception msg. We will not use subnetpool_id in execption."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I17e2f08d274336999abe9426ce4308672fade261"},{"line_number":12,"context_line":"Closes-bug: #1533034"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"bae84128_252fb8a2","line":9,"range":{"start_line":9,"start_character":51,"end_line":9,"end_character":55},"in_reply_to":"bae84128_c19a7913","updated":"2016-02-25 08:00:49.000000000","message":"what do you mean?","commit_id":"6df5f1389eff44feb7d932eac98c87b5113f3fe4"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"a8528dcd0fecb30d95021bdbc311f3a0ab36bb7c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove unclear built-in in subnetpool exception"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"I just remove subnetpool_id from exception msg. We will not use subnetpool_id in execption."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I17e2f08d274336999abe9426ce4308672fade261"},{"line_number":12,"context_line":"Closes-bug: #1533034"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"bae84128_b082e4c6","line":10,"updated":"2016-02-25 08:16:08.000000000","message":"Although the change is simple, I think the problem and the reason of using this solution should be stated more clearly here.","commit_id":"6df5f1389eff44feb7d932eac98c87b5113f3fe4"}],"neutron/common/exceptions.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"ad0e9a18f50a7daf31baab6d0eae54b5b045ecc7","unresolved":false,"context_lines":[{"line_number":505,"context_line":""},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"class SubnetpoolAssociationToAddressScopeError(BadRequest):"},{"line_number":508,"context_line":"    message \u003d _(\"Subnetpool Cannot be created. It cannot associated with address\""},{"line_number":509,"context_line":"                \"scope %(address_scope_id)s.\")"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_1a081c91","line":508,"range":{"start_line":508,"start_character":57,"end_line":508,"end_character":67},"updated":"2016-01-26 12:00:17.000000000","message":"\"be associated\" ?","commit_id":"94ed5c6b72ea37dfabe9e04648e023db6f0354b2"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"ad0e9a18f50a7daf31baab6d0eae54b5b045ecc7","unresolved":false,"context_lines":[{"line_number":516,"context_line":""},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"class SubnetpoolAssociationIpVersionToAddressScopeError(BadRequest):"},{"line_number":519,"context_line":"    message \u003d _(\"Subnetpool Cannot be created. It cannot associated with address\""},{"line_number":520,"context_line":"                \"scope %(address_scope_id)s, because subnetpool ip_version is not\""},{"line_number":521,"context_line":"                \"%(ip_version)s.\")"},{"line_number":522,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_bafc7073","line":519,"range":{"start_line":519,"start_character":57,"end_line":519,"end_character":67},"updated":"2016-01-26 12:00:17.000000000","message":"ditto","commit_id":"94ed5c6b72ea37dfabe9e04648e023db6f0354b2"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7c1c2c200bd7566f6592160f5d751939a3e590b9","unresolved":false,"context_lines":[{"line_number":505,"context_line":""},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"class SubnetpoolAssociationToAddressScopeError(BadRequest):"},{"line_number":508,"context_line":"    message \u003d _(\"Subnetpool Cannot be created. It cannot be associated with address\""},{"line_number":509,"context_line":"                \"scope %(address_scope_id)s.\")"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_1220d748","line":508,"range":{"start_line":508,"start_character":28,"end_line":508,"end_character":34},"updated":"2016-01-27 05:27:56.000000000","message":"Cannot \u003d\u003e cannot","commit_id":"3c23c1870790de8461325a2267a432f6405fed84"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7c1c2c200bd7566f6592160f5d751939a3e590b9","unresolved":false,"context_lines":[{"line_number":505,"context_line":""},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"class SubnetpoolAssociationToAddressScopeError(BadRequest):"},{"line_number":508,"context_line":"    message \u003d _(\"Subnetpool Cannot be created. It cannot be associated with address\""},{"line_number":509,"context_line":"                \"scope %(address_scope_id)s.\")"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_d219df23","line":508,"range":{"start_line":508,"start_character":76,"end_line":508,"end_character":83},"updated":"2016-01-27 05:27:56.000000000","message":"missing space","commit_id":"3c23c1870790de8461325a2267a432f6405fed84"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7c1c2c200bd7566f6592160f5d751939a3e590b9","unresolved":false,"context_lines":[{"line_number":516,"context_line":""},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"class SubnetpoolAssociationIpVersionToAddressScopeError(BadRequest):"},{"line_number":519,"context_line":"    message \u003d _(\"Subnetpool Cannot be created. It cannot associated with address\""},{"line_number":520,"context_line":"                \"scope %(address_scope_id)s, because subnetpool ip_version is not\""},{"line_number":521,"context_line":"                \"%(ip_version)s.\")"},{"line_number":522,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_92d28733","line":519,"range":{"start_line":519,"start_character":28,"end_line":519,"end_character":34},"updated":"2016-01-27 05:27:56.000000000","message":"Cannot \u003d\u003e cannot","commit_id":"3c23c1870790de8461325a2267a432f6405fed84"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7c1c2c200bd7566f6592160f5d751939a3e590b9","unresolved":false,"context_lines":[{"line_number":516,"context_line":""},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"class SubnetpoolAssociationIpVersionToAddressScopeError(BadRequest):"},{"line_number":519,"context_line":"    message \u003d _(\"Subnetpool Cannot be created. It cannot associated with address\""},{"line_number":520,"context_line":"                \"scope %(address_scope_id)s, because subnetpool ip_version is not\""},{"line_number":521,"context_line":"                \"%(ip_version)s.\")"},{"line_number":522,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_b2d78b22","line":519,"range":{"start_line":519,"start_character":73,"end_line":519,"end_character":80},"updated":"2016-01-27 05:27:56.000000000","message":"missing space","commit_id":"3c23c1870790de8461325a2267a432f6405fed84"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7c1c2c200bd7566f6592160f5d751939a3e590b9","unresolved":false,"context_lines":[{"line_number":517,"context_line":""},{"line_number":518,"context_line":"class SubnetpoolAssociationIpVersionToAddressScopeError(BadRequest):"},{"line_number":519,"context_line":"    message \u003d _(\"Subnetpool Cannot be created. It cannot associated with address\""},{"line_number":520,"context_line":"                \"scope %(address_scope_id)s, because subnetpool ip_version is not\""},{"line_number":521,"context_line":"                \"%(ip_version)s.\")"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_52dc0f46","line":520,"range":{"start_line":520,"start_character":78,"end_line":520,"end_character":81},"updated":"2016-01-27 05:27:56.000000000","message":"missing space","commit_id":"3c23c1870790de8461325a2267a432f6405fed84"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"b8fa0544d2ac1c5aba997e7cfaa0d3197b464df2","unresolved":false,"context_lines":[{"line_number":286,"context_line":"                \"within an address scope must have unique prefixes.\")"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"\u003c\u003c\u003c\u003c\u003c\u003c\u003c HEAD"},{"line_number":290,"context_line":"class IllegalSubnetPoolAssociationToAddressScope(e.BadRequest):"},{"line_number":291,"context_line":"    message \u003d _(\"Illegal subnetpool association: subnetpool %(subnetpool_id)s \""},{"line_number":292,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":293,"context_line":"class IllegalSubnetPoolAssociationToAddressScope(BadRequest):"},{"line_number":294,"context_line":"    message \u003d _(\"Illegal subnetpool association: subnetpool \""},{"line_number":295,"context_line":"\u003e\u003e\u003e\u003e\u003e\u003e\u003e Remove unclear built-in in subnetpool exception"},{"line_number":296,"context_line":"                \"cannot be associated with address scope \""},{"line_number":297,"context_line":"                \"%(address_scope_id)s.\")"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"\u003c\u003c\u003c\u003c\u003c\u003c\u003c HEAD"},{"line_number":301,"context_line":"class IllegalSubnetPoolIpVersionAssociationToAddressScope(e.BadRequest):"},{"line_number":302,"context_line":"    message \u003d _(\"Illegal subnetpool association: subnetpool %(subnetpool_id)s \""},{"line_number":303,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":304,"context_line":"class IllegalSubnetPoolIpVersionAssociationToAddressScope(BadRequest):"},{"line_number":305,"context_line":"    message \u003d _(\"Illegal subnetpool association: \""},{"line_number":306,"context_line":"\u003e\u003e\u003e\u003e\u003e\u003e\u003e Remove unclear built-in in subnetpool exception"},{"line_number":307,"context_line":"                \"cannot associate with address scope %(address_scope_id)s \""},{"line_number":308,"context_line":"                \"because subnetpool ip_version is not %(ip_version)s.\")"},{"line_number":309,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_3bcdde5d","line":306,"range":{"start_line":289,"start_character":0,"end_line":306,"end_character":55},"updated":"2016-02-22 07:13:28.000000000","message":"You miss cleaning conflict.","commit_id":"de5d0eded3acdb3512da775f1021da7a47b70c63"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"d1fe33b80cd54224cbe08a0d150814efac624362","unresolved":false,"context_lines":[{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    def __init__(self, address_scope_id, subnetpool_id\u003dNone):"},{"line_number":298,"context_line":"        subnetpool_id \u003d subnetpool_id or IN_CREATION"},{"line_number":299,"context_line":"        super(IllegalSubnetPoolAssociationToAddressScope, self).___init__("},{"line_number":300,"context_line":"            address_scope_id\u003daddress_scope_id, subnetpool_id\u003dsubnetpool_id)"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"3afc51ec_fcda7077","line":299,"updated":"2016-03-13 13:44:09.000000000","message":"___init__ ? should this not be __init__","commit_id":"3d37f2663078c420b01d4eb68e1f006c5ee5433f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"71fc71ac567fcdc9fe4df81c614224f7e598faf2","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from neutron.common import _deprecate"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"IN_CREATION \u003d _(\u0027in creation\u0027)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class SubnetPoolNotFound(e.NotFound):"}],"source_content_type":"text/x-python","patch_set":17,"id":"3afc51ec_c8fece6a","line":24,"updated":"2016-03-13 21:49:21.000000000","message":"Concatenation of strings is not the right way to handle i18n since it\u0027s not compatible with some languages. We should have a message per case.","commit_id":"93954351ab4e553b4e05800d641d719b21958a59"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"dbba1d446ea782bff81c884938e1705d7d776200","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from neutron.common import _deprecate"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"IN_CREATION \u003d _(\u0027in creation\u0027)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class SubnetPoolNotFound(e.NotFound):"}],"source_content_type":"text/x-python","patch_set":17,"id":"3afc51ec_14a3ac50","line":24,"in_reply_to":"3afc51ec_c8fece6a","updated":"2016-03-14 02:17:56.000000000","message":"btw we\u0027re in string freeze","commit_id":"93954351ab4e553b4e05800d641d719b21958a59"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8567939dae402974f6347f52c93601e258aa76c8","unresolved":false,"context_lines":[{"line_number":286,"context_line":"                \"within an address scope must have unique prefixes.\")"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"class IllegalSubnetPoolAssociationToAddressScope(e.BadRequest):"},{"line_number":290,"context_line":"    create_message \u003d _(\"Illegal subnetpool creation: the subnetpool cannot be \""},{"line_number":291,"context_line":"                       \"associated with address scope %(address_scope_id)s.\")"},{"line_number":292,"context_line":"    update_message \u003d _(\"Illegal subnetpool association: subnetpool \""}],"source_content_type":"text/x-python","patch_set":19,"id":"ba0121b8_49a80320","line":289,"updated":"2016-03-29 13:12:46.000000000","message":"Why don\u0027t we make it two separate exceptions? This __init__ makes the logic twisted a bit.","commit_id":"6e3ce7a59dce87aef6fb3182ef5ae0d0dd3cb436"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"613e8fb20df4cced9932e882e92db185e4d8b84c","unresolved":false,"context_lines":[{"line_number":286,"context_line":"                \"within an address scope must have unique prefixes.\")"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"class IllegalSubnetPoolAssociationToAddressScope(e.BadRequest):"},{"line_number":290,"context_line":"    create_message \u003d _(\"Illegal subnetpool creation: the subnetpool cannot be \""},{"line_number":291,"context_line":"                       \"associated with address scope %(address_scope_id)s.\")"},{"line_number":292,"context_line":"    update_message \u003d _(\"Illegal subnetpool association: subnetpool \""}],"source_content_type":"text/x-python","patch_set":19,"id":"ba0121b8_d5b4a0f3","line":289,"in_reply_to":"ba0121b8_49a80320","updated":"2016-03-29 14:05:46.000000000","message":"2 separate exceptions imply to move this logic in _validate_address_scope_id or to provide the exception class to _validate_address_scope_id as an argument. IMO, both approachs are worse than this one.","commit_id":"6e3ce7a59dce87aef6fb3182ef5ae0d0dd3cb436"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"486ed288edae8175ed7363d02b2c3c98f9c6b1df","unresolved":false,"context_lines":[{"line_number":286,"context_line":"                \"within an address scope must have unique prefixes.\")"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"class IllegalSubnetPoolAssociationToAddressScope(e.BadRequest):"},{"line_number":290,"context_line":"    create_message \u003d _(\"Illegal subnetpool creation: the subnetpool cannot be \""},{"line_number":291,"context_line":"                       \"associated with address scope %(address_scope_id)s.\")"},{"line_number":292,"context_line":"    update_message \u003d _(\"Illegal subnetpool association: subnetpool \""}],"source_content_type":"text/x-python","patch_set":19,"id":"ba0121b8_4ffdd8af","line":289,"in_reply_to":"ba0121b8_d5b4a0f3","updated":"2016-04-01 18:11:29.000000000","message":"I agree that these should be split.  Logic doesn\u0027t really belong in the exception, IMO.\n\nI\u0027m actually thinking that _validate_address_scope_id should be refactored in to two also, one for create and one for update (probably sharing some common code).  It seems like a lot but the end result will be more straight-forward that this.","commit_id":"6e3ce7a59dce87aef6fb3182ef5ae0d0dd3cb436"}],"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"ad0e9a18f50a7daf31baab6d0eae54b5b045ecc7","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        if updated[\u0027shared\u0027] \u003d\u003d original.shared or updated[\u0027shared\u0027]:"},{"line_number":209,"context_line":"            return"},{"line_number":210,"context_line":"        ports \u003d self._model_query("},{"line_number":211,"context_line":"            context, models_v2.Port).filter("},{"line_number":212,"context_line":"                and_("},{"line_number":213,"context_line":"                    models_v2.Port.network_id \u003d\u003d id,"},{"line_number":214,"context_line":"                    models_v2.Port.device_owner !\u003d"},{"line_number":215,"context_line":"                    constants.DEVICE_OWNER_ROUTER_GW,"},{"line_number":216,"context_line":"                    models_v2.Port.device_owner !\u003d"},{"line_number":217,"context_line":"                    constants.DEVICE_OWNER_FLOATINGIP))"},{"line_number":218,"context_line":"        subnets \u003d self._model_query("},{"line_number":219,"context_line":"            context, models_v2.Subnet).filter("},{"line_number":220,"context_line":"                models_v2.Subnet.network_id \u003d\u003d id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_bab47082","line":217,"range":{"start_line":211,"start_character":12,"end_line":217,"end_character":55},"updated":"2016-01-26 12:00:17.000000000","message":"I don\u0027t understand how this change is relevant.","commit_id":"94ed5c6b72ea37dfabe9e04648e023db6f0354b2"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"ad0e9a18f50a7daf31baab6d0eae54b5b045ecc7","unresolved":false,"context_lines":[{"line_number":522,"context_line":""},{"line_number":523,"context_line":"        mode_list \u003d [constants.IPV6_SLAAC,"},{"line_number":524,"context_line":"                     constants.DHCPV6_STATELESS,"},{"line_number":525,"context_line":"                     attributes.ATTR_NOT_SPECIFIED]"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"        ra_mode \u003d subnet.get(\u0027ipv6_ra_mode\u0027)"},{"line_number":528,"context_line":"        if ra_mode not in mode_list:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_3a05e013","line":525,"range":{"start_line":525,"start_character":21,"end_line":525,"end_character":50},"updated":"2016-01-26 12:00:17.000000000","message":"This appears to be completely unrelated.  It reverts something that was changed in I2e3cd4dda185e478b0f97eb8511e64ad2b83a2cf.","commit_id":"94ed5c6b72ea37dfabe9e04648e023db6f0354b2"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"0677f358e4717ad62c165a11d0ae3b1b75a3af3b","unresolved":false,"context_lines":[{"line_number":602,"context_line":"            return subnetpool_id"},{"line_number":603,"context_line":"        else:"},{"line_number":604,"context_line":"            subnetpool_id \u003d None"},{"line_number":605,"context_line":"            return subnetpool_id"},{"line_number":606,"context_line":""},{"line_number":607,"context_line":"        cidr \u003d subnet.get(\u0027cidr\u0027)"},{"line_number":608,"context_line":"        if attributes.is_attr_set(cidr):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_a1d2df32","line":605,"updated":"2016-01-27 03:12:07.000000000","message":"return here will make line 606 to line 629 be not available","commit_id":"3c23c1870790de8461325a2267a432f6405fed84"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7c1c2c200bd7566f6592160f5d751939a3e590b9","unresolved":false,"context_lines":[{"line_number":893,"context_line":"                                                         address_scope_id):"},{"line_number":894,"context_line":"                raise n_exc.IllegalSubnetPoolAssociationToAddressScope("},{"line_number":895,"context_line":"                    subnetpool_id\u003dsubnetpool_id, address_scope_id\u003daddress_scope_id)"},{"line_number":896,"context_line":"        else:"},{"line_number":897,"context_line":"            raise n_exc.SubnetpoolAssociationToAddressScopeError("},{"line_number":898,"context_line":"                address_scope_id\u003daddress_scope_id)"},{"line_number":899,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_32e4fb0b","line":896,"updated":"2016-01-27 05:27:56.000000000","message":"where is a unit test for this flow?","commit_id":"3c23c1870790de8461325a2267a432f6405fed84"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7c1c2c200bd7566f6592160f5d751939a3e590b9","unresolved":false,"context_lines":[{"line_number":905,"context_line":"                raise n_exc.IllegalSubnetPoolIpVersionAssociationToAddressScope("},{"line_number":906,"context_line":"                    subnetpool_id\u003dsubnetpool_id, address_scope_id\u003daddress_scope_id,"},{"line_number":907,"context_line":"                    ip_version\u003das_ip_version)"},{"line_number":908,"context_line":"        else:"},{"line_number":909,"context_line":"            raise SubnetpoolAssociationIpVersionToAddressScopeError("},{"line_number":910,"context_line":"                address_scope_id\u003daddress_scope_id, ip_version\u003das_ip_version)"},{"line_number":911,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_d2f0ffcb","line":908,"updated":"2016-01-27 05:27:56.000000000","message":"ditto","commit_id":"3c23c1870790de8461325a2267a432f6405fed84"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"0677f358e4717ad62c165a11d0ae3b1b75a3af3b","unresolved":false,"context_lines":[{"line_number":906,"context_line":"                    subnetpool_id\u003dsubnetpool_id, address_scope_id\u003daddress_scope_id,"},{"line_number":907,"context_line":"                    ip_version\u003das_ip_version)"},{"line_number":908,"context_line":"        else:"},{"line_number":909,"context_line":"            raise SubnetpoolAssociationIpVersionToAddressScopeError("},{"line_number":910,"context_line":"                address_scope_id\u003daddress_scope_id, ip_version\u003das_ip_version)"},{"line_number":911,"context_line":""},{"line_number":912,"context_line":"        subnetpools \u003d self._get_subnetpools_by_address_scope_id("}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_81af9b93","line":909,"updated":"2016-01-27 03:12:07.000000000","message":"if not subnetpool_id, code will stop at line 897, this line will never be reached.","commit_id":"3c23c1870790de8461325a2267a432f6405fed84"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"93246a6f3a265cbe62dc616d8d3fb6c168533e71","unresolved":false,"context_lines":[{"line_number":885,"context_line":"        if not attributes.is_attr_set(address_scope_id):"},{"line_number":886,"context_line":"            return"},{"line_number":887,"context_line":""},{"line_number":888,"context_line":"        if subnetpool_id !\u003d attributes.ATTR_NOT_SPECIFIED:"},{"line_number":889,"context_line":"            if not self.is_address_scope_owned_by_tenant(context,"},{"line_number":890,"context_line":"                                                         address_scope_id):"},{"line_number":891,"context_line":"                raise n_exc.IllegalSubnetPoolAssociationToAddressScope("}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_410d2a3d","line":888,"range":{"start_line":888,"start_character":11,"end_line":888,"end_character":57},"updated":"2016-01-28 07:16:38.000000000","message":"What case passes attributes.ATTR_NOT_SPECIFIED as subnetpool_id in _validate_address_scope_id()?","commit_id":"b38c762e5376ac6fae82eea23291c637517bebe0"},{"author":{"_account_id":19383,"name":"linwei wu","email":"wlwwu@cn.ibm.com","username":"linwwu"},"change_message_id":"7e3f51e739ecafb327652c5a12828e83a4ed940b","unresolved":false,"context_lines":[{"line_number":885,"context_line":"        if not attributes.is_attr_set(address_scope_id):"},{"line_number":886,"context_line":"            return"},{"line_number":887,"context_line":""},{"line_number":888,"context_line":"        if subnetpool_id !\u003d attributes.ATTR_NOT_SPECIFIED:"},{"line_number":889,"context_line":"            if not self.is_address_scope_owned_by_tenant(context,"},{"line_number":890,"context_line":"                                                         address_scope_id):"},{"line_number":891,"context_line":"                raise n_exc.IllegalSubnetPoolAssociationToAddressScope("}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_8d46f321","line":888,"range":{"start_line":888,"start_character":11,"end_line":888,"end_character":57},"in_reply_to":"7a5de9d1_410d2a3d","updated":"2016-01-28 09:01:09.000000000","message":"If subnetpool_id doen\u0027t exist, it will give object() as subnetpool_id. that\u0027s why I add if here to detect whether we get subnetpool_id or we just get one atrribute_not_specified. if we get attributes.attr_not_specified. we will directly display error that we can\u0027t create subnetpool.\n\ndo you have better suggestions to fix this bug?","commit_id":"b38c762e5376ac6fae82eea23291c637517bebe0"},{"author":{"_account_id":19383,"name":"linwei wu","email":"wlwwu@cn.ibm.com","username":"linwwu"},"change_message_id":"e551dfd773fd65b7719cb478856db663c63d2be4","unresolved":false,"context_lines":[{"line_number":885,"context_line":"        if not attributes.is_attr_set(address_scope_id):"},{"line_number":886,"context_line":"            return"},{"line_number":887,"context_line":""},{"line_number":888,"context_line":"        if subnetpool_id !\u003d attributes.ATTR_NOT_SPECIFIED:"},{"line_number":889,"context_line":"            if not self.is_address_scope_owned_by_tenant(context,"},{"line_number":890,"context_line":"                                                         address_scope_id):"},{"line_number":891,"context_line":"                raise n_exc.IllegalSubnetPoolAssociationToAddressScope("}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_68c68269","line":888,"range":{"start_line":888,"start_character":11,"end_line":888,"end_character":57},"in_reply_to":"7a5de9d1_6981244a","updated":"2016-02-01 02:02:54.000000000","message":"okay. maybe simple way is to reove subnetpoolid from msg.","commit_id":"b38c762e5376ac6fae82eea23291c637517bebe0"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"38bc746a3ba23a32ca750ab6e08b874e0ed1c988","unresolved":false,"context_lines":[{"line_number":885,"context_line":"        if not attributes.is_attr_set(address_scope_id):"},{"line_number":886,"context_line":"            return"},{"line_number":887,"context_line":""},{"line_number":888,"context_line":"        if subnetpool_id !\u003d attributes.ATTR_NOT_SPECIFIED:"},{"line_number":889,"context_line":"            if not self.is_address_scope_owned_by_tenant(context,"},{"line_number":890,"context_line":"                                                         address_scope_id):"},{"line_number":891,"context_line":"                raise n_exc.IllegalSubnetPoolAssociationToAddressScope("}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_6981244a","line":888,"range":{"start_line":888,"start_character":11,"end_line":888,"end_character":57},"in_reply_to":"7a5de9d1_8d46f321","updated":"2016-01-28 11:03:18.000000000","message":"First \u003cbuilt-in function id\u003e doesn\u0027t mean object(). It means \"id\" defined in python namespace. This \"id\" is passed at L956.\n\nIf I were you, I\u0027d change \"id\" to None and check whether subnetpool_id is None here OR just remove subnetpool_id from IllegalSubnetPoolAssociationToAddressScope.","commit_id":"b38c762e5376ac6fae82eea23291c637517bebe0"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"00b1447ca8e2de7b82c1a3354b25c984699d5adb","unresolved":false,"context_lines":[{"line_number":889,"context_line":""},{"line_number":890,"context_line":"        new_set \u003d netaddr.IPSet(sp_prefixes)"},{"line_number":891,"context_line":"        for sp in subnetpools:"},{"line_number":892,"context_line":"            if sp.id \u003d\u003d subnetpool_id:"},{"line_number":893,"context_line":"                continue"},{"line_number":894,"context_line":"            sp_set \u003d netaddr.IPSet([prefix[\u0027cidr\u0027] for prefix in sp.prefixes])"},{"line_number":895,"context_line":"            if sp_set.intersection(new_set):"}],"source_content_type":"text/x-python","patch_set":14,"id":"3afc51ec_99eede89","line":892,"updated":"2016-03-13 13:07:18.000000000","message":"Using subnetpool_id \u003d\u003d None is fine because for every sp sp.id !\u003d None","commit_id":"3d37f2663078c420b01d4eb68e1f006c5ee5433f"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"00b1447ca8e2de7b82c1a3354b25c984699d5adb","unresolved":false,"context_lines":[{"line_number":891,"context_line":"        for sp in subnetpools:"},{"line_number":892,"context_line":"            if sp.id \u003d\u003d subnetpool_id:"},{"line_number":893,"context_line":"                continue"},{"line_number":894,"context_line":"            sp_set \u003d netaddr.IPSet([prefix[\u0027cidr\u0027] for prefix in sp.prefixes])"},{"line_number":895,"context_line":"            if sp_set.intersection(new_set):"},{"line_number":896,"context_line":"                raise n_exc.AddressScopePrefixConflict()"},{"line_number":897,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"3afc51ec_1903ee43","line":894,"updated":"2016-03-13 13:07:18.000000000","message":"It\u0027s unrelated to the change but i doubt this check is concurrency-safe!","commit_id":"3d37f2663078c420b01d4eb68e1f006c5ee5433f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c3ca2e2c1f411c3522df60e01249895a52c3eb97","unresolved":false,"context_lines":[{"line_number":934,"context_line":"            self._check_default_subnetpool_exists(context,"},{"line_number":935,"context_line":"                                                  sp_reader.ip_version)"},{"line_number":936,"context_line":"        self._validate_address_scope_id(context, sp_reader.address_scope_id,"},{"line_number":937,"context_line":"                                        None, sp_reader.prefixes,"},{"line_number":938,"context_line":"                                        sp_reader.ip_version)"},{"line_number":939,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":940,"context_line":"            pool_args \u003d {\u0027tenant_id\u0027: sp[\u0027tenant_id\u0027],"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba0121b8_e983d7ca","line":937,"updated":"2016-03-29 13:10:55.000000000","message":"why is this not sp_reader.id?","commit_id":"6e3ce7a59dce87aef6fb3182ef5ae0d0dd3cb436"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"486ed288edae8175ed7363d02b2c3c98f9c6b1df","unresolved":false,"context_lines":[{"line_number":934,"context_line":"            self._check_default_subnetpool_exists(context,"},{"line_number":935,"context_line":"                                                  sp_reader.ip_version)"},{"line_number":936,"context_line":"        self._validate_address_scope_id(context, sp_reader.address_scope_id,"},{"line_number":937,"context_line":"                                        None, sp_reader.prefixes,"},{"line_number":938,"context_line":"                                        sp_reader.ip_version)"},{"line_number":939,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":940,"context_line":"            pool_args \u003d {\u0027tenant_id\u0027: sp[\u0027tenant_id\u0027],"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba0121b8_4ff6785d","line":937,"in_reply_to":"ba0121b8_35019caf","updated":"2016-04-01 18:11:29.000000000","message":"I agree with @Cedric that there isn\u0027t a valid id that can be passed here.  But, I don\u0027t think that passing None here is clear.  See my comment in the other file.","commit_id":"6e3ce7a59dce87aef6fb3182ef5ae0d0dd3cb436"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"0e8a3920b7b40314f7734794e3c7f07c4930b042","unresolved":false,"context_lines":[{"line_number":934,"context_line":"            self._check_default_subnetpool_exists(context,"},{"line_number":935,"context_line":"                                                  sp_reader.ip_version)"},{"line_number":936,"context_line":"        self._validate_address_scope_id(context, sp_reader.address_scope_id,"},{"line_number":937,"context_line":"                                        None, sp_reader.prefixes,"},{"line_number":938,"context_line":"                                        sp_reader.ip_version)"},{"line_number":939,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":940,"context_line":"            pool_args \u003d {\u0027tenant_id\u0027: sp[\u0027tenant_id\u0027],"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba0121b8_35019caf","line":937,"in_reply_to":"ba0121b8_e983d7ca","updated":"2016-03-29 14:02:05.000000000","message":"Because it\u0027s a random id which gets a meaning only if create_subnetpool succeed.","commit_id":"6e3ce7a59dce87aef6fb3182ef5ae0d0dd3cb436"}]}