)]}'
{"neutron/agent/l3/dvr_fip_ns.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"7073d1864222daee8c22b47c1d030322c2890da5","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            gw_ip \u003d subnet.get(\u0027gateway_ip\u0027)"},{"line_number":121,"context_line":"            ipd \u003d ip_lib.IPDevice(interface_name,"},{"line_number":122,"context_line":"                                  namespace\u003dns_name)"},{"line_number":123,"context_line":"            if gw_ip:"},{"line_number":124,"context_line":"                ipd.route.add_gateway(gw_ip)"},{"line_number":125,"context_line":"            else:"},{"line_number":126,"context_line":"                old_gw \u003d ipd.route.get_gateway()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_886ae57f","line":123,"updated":"2016-01-23 13:08:18.000000000","message":"The problem here is similar to the bug 1520775, I think it is part of that bug.\n\nAnd I think the code here has a regression issue.\nFor example, external network have 2 subnets, one ipv4 and one ipv6. The ipv4 subnet has gateway ip, whereas ipv6 subnet doesn\u0027t have gateway ip. Because ex_gw_port[\u0027subnets\u0027] is an unorder list, let\u0027s assume ipv4 subnet comes first.\nIn the ipv4 round, the gateway will be set. And in the ipv5 round, the ipv4 gateway will be cleared at line 125~128.","commit_id":"864bee0fb896686d02df9a9f1a7e6001538ef2f7"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"2998536bd8e426f8047c205326bea3767d16edc6","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            gw_ip \u003d subnet.get(\u0027gateway_ip\u0027)"},{"line_number":121,"context_line":"            ipd \u003d ip_lib.IPDevice(interface_name,"},{"line_number":122,"context_line":"                                  namespace\u003dns_name)"},{"line_number":123,"context_line":"            if gw_ip:"},{"line_number":124,"context_line":"                ipd.route.add_gateway(gw_ip)"},{"line_number":125,"context_line":"            else:"},{"line_number":126,"context_line":"                old_gw \u003d ipd.route.get_gateway()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_da12db56","line":123,"in_reply_to":"9a68dd71_886ae57f","updated":"2016-01-24 03:10:24.000000000","message":"1, floatingip is not for IPv6.\n2, A good point to share: calling delete_gateway with gateway_ip, it will try to delete gateway with parameter \"via gateway_ip\", so without correct IP, the default gateway will not be deleted.\n\nBTW, this patch will just work for DVR FIP netns.","commit_id":"864bee0fb896686d02df9a9f1a7e6001538ef2f7"}]}
