)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"ef9c2f4a1eaa1f1d4769173841288543316ee1a0","unresolved":false,"context_lines":[{"line_number":12,"context_line":"as the floating IP agent gateway port on the corresponding host."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I654e4d2496e19c011653eedb87c9b6026f801e9f"},{"line_number":15,"context_line":"Partially-Implements: blueprint bgp-dynamic-routing"},{"line_number":16,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"5aef4532_736a9f82","line":15,"updated":"2016-03-09 19:02:50.000000000","message":"when do we expect to see the patch that does \u0027Implements: bla\u0027?","commit_id":"c93f431ae1b9f54fb7ef65674576f108717e2eaf"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7ede1a91033b601c3e69c3c9f759caa961277c8b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"as the floating IP agent gateway port on the corresponding host."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I654e4d2496e19c011653eedb87c9b6026f801e9f"},{"line_number":15,"context_line":"Partially-Implements: blueprint bgp-dynamic-routing"},{"line_number":16,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"5aef4532_64181376","line":15,"in_reply_to":"5aef4532_29c3848a","updated":"2016-03-09 19:47:40.000000000","message":"There\u0027s always been a grey area. But it\u0027s my understanding that this patch completes the chain to consider bgp complete for Mitaka. Correct?","commit_id":"c93f431ae1b9f54fb7ef65674576f108717e2eaf"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"30417883ff9326b39bef02019468628830673fa6","unresolved":false,"context_lines":[{"line_number":12,"context_line":"as the floating IP agent gateway port on the corresponding host."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I654e4d2496e19c011653eedb87c9b6026f801e9f"},{"line_number":15,"context_line":"Partially-Implements: blueprint bgp-dynamic-routing"},{"line_number":16,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"5aef4532_29c3848a","line":15,"in_reply_to":"5aef4532_736a9f82","updated":"2016-03-09 19:33:22.000000000","message":"In this patch. I thought \"partially-implements\" is used on all reviews when you have multiple patches to implement a feature, but I guess that was the wrong understanding. Will change.","commit_id":"c93f431ae1b9f54fb7ef65674576f108717e2eaf"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f3773cf748accd29de4e405a682b43190c15a1f3","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I654e4d2496e19c011653eedb87c9b6026f801e9f"},{"line_number":15,"context_line":"Partially-Implements: blueprint bgp-dynamic-routing"},{"line_number":16,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"5aef4532_b3d1c759","line":16,"updated":"2016-03-09 18:56:54.000000000","message":"DocImpact needs a one liner:\n\n[1] http://lists.openstack.org/pipermail/openstack-dev/2016-March/087851.html","commit_id":"c93f431ae1b9f54fb7ef65674576f108717e2eaf"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7ede1a91033b601c3e69c3c9f759caa961277c8b","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I654e4d2496e19c011653eedb87c9b6026f801e9f"},{"line_number":15,"context_line":"Partially-Implements: blueprint bgp-dynamic-routing"},{"line_number":16,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"5aef4532_09104858","line":16,"in_reply_to":"5aef4532_a93dd490","updated":"2016-03-09 19:47:40.000000000","message":"Done as Carl has resigned?","commit_id":"c93f431ae1b9f54fb7ef65674576f108717e2eaf"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"30417883ff9326b39bef02019468628830673fa6","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I654e4d2496e19c011653eedb87c9b6026f801e9f"},{"line_number":15,"context_line":"Partially-Implements: blueprint bgp-dynamic-routing"},{"line_number":16,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"5aef4532_a93dd490","line":16,"in_reply_to":"5aef4532_b3d1c759","updated":"2016-03-09 19:33:22.000000000","message":"Done","commit_id":"c93f431ae1b9f54fb7ef65674576f108717e2eaf"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"ff5d5826456cdcc437302488f3faf7c364324318","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I654e4d2496e19c011653eedb87c9b6026f801e9f"},{"line_number":15,"context_line":"Partially-Implements: blueprint bgp-dynamic-routing"},{"line_number":16,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"5aef4532_493c10c8","line":16,"in_reply_to":"5aef4532_b3d1c759","updated":"2016-03-09 19:28:53.000000000","message":"I should resign now.  This is embarrassing.","commit_id":"c93f431ae1b9f54fb7ef65674576f108717e2eaf"}],"neutron/db/bgp_db.py":[{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"b5619414ea9da1d11439b834b12f78b628691d9b","unresolved":false,"context_lines":[{"line_number":604,"context_line":"                                                          bgp_speaker_id,"},{"line_number":605,"context_line":"                                                          True)"},{"line_number":606,"context_line":"            query \u003d context.session.query(l3_db.IpAllocation.ip_address,"},{"line_number":607,"context_line":"                                          portbindings_db.PortBindingPort.host,"},{"line_number":608,"context_line":"                                          address_scope_db.AddressScope.id)"},{"line_number":609,"context_line":"            query \u003d query.filter(l3_db.RouterPort.router_id.in_(routers),"},{"line_number":610,"context_line":"                                 l3_db.RouterPort.port_type \u003d\u003d constants.DEVICE_OWNER_ROUTER_INTF,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a57f1b5_c1d49ebe","line":607,"range":{"start_line":607,"start_character":73,"end_line":607,"end_character":74},"updated":"2016-02-10 23:07:59.000000000","message":"You may need to use the \"ml2 portbindings table\" instead of the PortBinding table.","commit_id":"da1eff8efdda2daa961a01350f6f4802c52b6ea7"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"bfe8f738b8cc0cea1168384001dfc1fa1414b5f5","unresolved":false,"context_lines":[{"line_number":34,"context_line":"from neutron.db import model_base"},{"line_number":35,"context_line":"from neutron.db import models_v2"},{"line_number":36,"context_line":"from neutron.extensions import bgp as bgp_ext"},{"line_number":37,"context_line":"from neutron.plugins.ml2 import models as ml2_models"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_3fc3d539","line":37,"updated":"2016-03-03 04:48:30.000000000","message":"I know you warned me about this and I agree there is no way around it right now.  But, seeing this here now makes me wonder if we should do this [1] to the PortBinding table.\n\n [1] https://review.openstack.org/#/c/242393/","commit_id":"5639126ae54c24d5a05ee499f3c15026602d9c8d"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"76893a229339c241ffb239dbaf5d8e12581e5c2f","unresolved":false,"context_lines":[{"line_number":34,"context_line":"from neutron.db import model_base"},{"line_number":35,"context_line":"from neutron.db import models_v2"},{"line_number":36,"context_line":"from neutron.extensions import bgp as bgp_ext"},{"line_number":37,"context_line":"from neutron.plugins.ml2 import models as ml2_models"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_ca492662","line":37,"in_reply_to":"7af24918_3fc3d539","updated":"2016-03-03 16:03:55.000000000","message":"We won\u0027t get the DVR binding information we need with the standard port bindings, it has to be ML2 port bindings for now.  I see where you\u0027re thought process is going and I\u0027m on board, but more work is required to get there.  We\u0027re stuck on ML2 port bindings for Mitaka. I smell an RFE of some sort.","commit_id":"5639126ae54c24d5a05ee499f3c15026602d9c8d"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"bfe8f738b8cc0cea1168384001dfc1fa1414b5f5","unresolved":false,"context_lines":[{"line_number":505,"context_line":"                                                               context,"},{"line_number":506,"context_line":"                                                               router_id,"},{"line_number":507,"context_line":"                                                               bgp_speaker_id)"},{"line_number":508,"context_line":"            routes \u003d list(itertools.chain(fip_routes,"},{"line_number":509,"context_line":"                                          net_routes,"},{"line_number":510,"context_line":"                                          dvr_fip_routes))"},{"line_number":511,"context_line":"            route_dict[bgp_speaker_id] \u003d routes"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_5f1981d6","line":508,"range":{"start_line":508,"start_character":21,"end_line":508,"end_character":26},"updated":"2016-03-03 04:48:30.000000000","message":"femtonit:  You\u0027d probably have room in this line for all three args if you converted to list on L511.  Just sayin\u0027  ;)","commit_id":"5639126ae54c24d5a05ee499f3c15026602d9c8d"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"76893a229339c241ffb239dbaf5d8e12581e5c2f","unresolved":false,"context_lines":[{"line_number":505,"context_line":"                                                               context,"},{"line_number":506,"context_line":"                                                               router_id,"},{"line_number":507,"context_line":"                                                               bgp_speaker_id)"},{"line_number":508,"context_line":"            routes \u003d list(itertools.chain(fip_routes,"},{"line_number":509,"context_line":"                                          net_routes,"},{"line_number":510,"context_line":"                                          dvr_fip_routes))"},{"line_number":511,"context_line":"            route_dict[bgp_speaker_id] \u003d routes"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_2a71aaa8","line":508,"range":{"start_line":508,"start_character":21,"end_line":508,"end_character":26},"in_reply_to":"7af24918_5f1981d6","updated":"2016-03-03 16:03:55.000000000","message":"Done","commit_id":"5639126ae54c24d5a05ee499f3c15026602d9c8d"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"26ce60e3b951e687c99de7b34ebbc50cf490f513","unresolved":false,"context_lines":[{"line_number":546,"context_line":"                                    l3_db.Router.id \u003d\u003d router_attrs.router_id)"},{"line_number":547,"context_line":"            query \u003d query.filter(router_attrs.distributed !\u003d sa.sql.true())"},{"line_number":548,"context_line":"            return self._host_route_list_from_tuples(query.all())"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"    def _get_dvr_fip_host_routes_by_router(self, context, bgp_speaker_id,"},{"line_number":551,"context_line":"                                           router_id):"},{"line_number":552,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_7501076a","line":549,"updated":"2016-03-03 00:24:31.000000000","message":"I see lot more code duplication here with respect to the queries.\nIs it possible to customize it based on the passed in arguments.","commit_id":"5639126ae54c24d5a05ee499f3c15026602d9c8d"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"76893a229339c241ffb239dbaf5d8e12581e5c2f","unresolved":false,"context_lines":[{"line_number":546,"context_line":"                                    l3_db.Router.id \u003d\u003d router_attrs.router_id)"},{"line_number":547,"context_line":"            query \u003d query.filter(router_attrs.distributed !\u003d sa.sql.true())"},{"line_number":548,"context_line":"            return self._host_route_list_from_tuples(query.all())"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"    def _get_dvr_fip_host_routes_by_router(self, context, bgp_speaker_id,"},{"line_number":551,"context_line":"                                           router_id):"},{"line_number":552,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_9db48a35","line":549,"in_reply_to":"7af24918_3f02b5b4","updated":"2016-03-03 16:03:55.000000000","message":"I will see what can be done to make these methods more readable. I\u0027m not sure there\u0027s a lot of logic duplication. I think what you\u0027re seeing is some similarity in the queries that are being constructed. I think that maybe tidying up some of the variable names and such might help readability, but trying remove the perceived duplication might make the generation of the queries harder for humans to follow.","commit_id":"5639126ae54c24d5a05ee499f3c15026602d9c8d"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"bfe8f738b8cc0cea1168384001dfc1fa1414b5f5","unresolved":false,"context_lines":[{"line_number":546,"context_line":"                                    l3_db.Router.id \u003d\u003d router_attrs.router_id)"},{"line_number":547,"context_line":"            query \u003d query.filter(router_attrs.distributed !\u003d sa.sql.true())"},{"line_number":548,"context_line":"            return self._host_route_list_from_tuples(query.all())"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"    def _get_dvr_fip_host_routes_by_router(self, context, bgp_speaker_id,"},{"line_number":551,"context_line":"                                           router_id):"},{"line_number":552,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_3f02b5b4","line":549,"in_reply_to":"7af24918_7501076a","updated":"2016-03-03 04:48:30.000000000","message":"Be careful with this.  If the answer is to add arguments and then combine all the methods in to one to reduce duplication then I\u0027d be -1 to that.  I wouldn\u0027t mess around with these methods\u0027 signatures in the name of code dedup.  It usually makes things more difficult to read.  For the most part, I like these methods with the names and arguments they have now.\n\nIf there are pieces of code that are genuinely shareable between these methods then, by all means, feel free to de-duplicate.","commit_id":"5639126ae54c24d5a05ee499f3c15026602d9c8d"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"26ce60e3b951e687c99de7b34ebbc50cf490f513","unresolved":false,"context_lines":[{"line_number":554,"context_line":"            binding_speaker \u003d BgpSpeakerNetworkBinding.bgp_speaker_id"},{"line_number":555,"context_line":"            binding_version \u003d BgpSpeakerNetworkBinding.ip_version"},{"line_number":556,"context_line":"            port_binding_port \u003d ml2_models.PortBinding.port_id"},{"line_number":557,"context_line":"            fip_agent_gw \u003d lib_consts.DEVICE_OWNER_AGENT_GW"},{"line_number":558,"context_line":"            gw_query \u003d context.session.query(models_v2.Port.network_id,"},{"line_number":559,"context_line":"                                             ml2_models.PortBinding.host,"},{"line_number":560,"context_line":"                                             models_v2.IPAllocation.ip_address)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_e38e00cf","line":557,"range":{"start_line":557,"start_character":12,"end_line":557,"end_character":24},"updated":"2016-03-03 00:24:31.000000000","message":"nit: you can use the constant directly, why do you need a local variable.","commit_id":"5639126ae54c24d5a05ee499f3c15026602d9c8d"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"76893a229339c241ffb239dbaf5d8e12581e5c2f","unresolved":false,"context_lines":[{"line_number":554,"context_line":"            binding_speaker \u003d BgpSpeakerNetworkBinding.bgp_speaker_id"},{"line_number":555,"context_line":"            binding_version \u003d BgpSpeakerNetworkBinding.ip_version"},{"line_number":556,"context_line":"            port_binding_port \u003d ml2_models.PortBinding.port_id"},{"line_number":557,"context_line":"            fip_agent_gw \u003d lib_consts.DEVICE_OWNER_AGENT_GW"},{"line_number":558,"context_line":"            gw_query \u003d context.session.query(models_v2.Port.network_id,"},{"line_number":559,"context_line":"                                             ml2_models.PortBinding.host,"},{"line_number":560,"context_line":"                                             models_v2.IPAllocation.ip_address)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_9db92a18","line":557,"range":{"start_line":557,"start_character":12,"end_line":557,"end_character":24},"in_reply_to":"7af24918_bfb24504","updated":"2016-03-03 16:03:55.000000000","message":"Exactly, line-width restrictions are the enemy in this patch. I\u0027ll try and tidy up variable names throughout.","commit_id":"5639126ae54c24d5a05ee499f3c15026602d9c8d"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"bfe8f738b8cc0cea1168384001dfc1fa1414b5f5","unresolved":false,"context_lines":[{"line_number":554,"context_line":"            binding_speaker \u003d BgpSpeakerNetworkBinding.bgp_speaker_id"},{"line_number":555,"context_line":"            binding_version \u003d BgpSpeakerNetworkBinding.ip_version"},{"line_number":556,"context_line":"            port_binding_port \u003d ml2_models.PortBinding.port_id"},{"line_number":557,"context_line":"            fip_agent_gw \u003d lib_consts.DEVICE_OWNER_AGENT_GW"},{"line_number":558,"context_line":"            gw_query \u003d context.session.query(models_v2.Port.network_id,"},{"line_number":559,"context_line":"                                             ml2_models.PortBinding.host,"},{"line_number":560,"context_line":"                                             models_v2.IPAllocation.ip_address)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_bfb24504","line":557,"range":{"start_line":557,"start_character":12,"end_line":557,"end_character":24},"in_reply_to":"7af24918_e38e00cf","updated":"2016-03-03 04:48:30.000000000","message":"I think the goal was to use a shorter name to avoid awkward line breaks later in the code.  I\u0027m fine with either way.  You might consider making this all caps to preserve its \"constness\" but I don\u0027t really care.  That was just a thought I had now.\n\n  FIP_AGENT_GW \u003d lib_consts.DEVICE_OWNER_AGENT_GW","commit_id":"5639126ae54c24d5a05ee499f3c15026602d9c8d"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"bfe8f738b8cc0cea1168384001dfc1fa1414b5f5","unresolved":false,"context_lines":[{"line_number":558,"context_line":"            gw_query \u003d context.session.query(models_v2.Port.network_id,"},{"line_number":559,"context_line":"                                             ml2_models.PortBinding.host,"},{"line_number":560,"context_line":"                                             models_v2.IPAllocation.ip_address)"},{"line_number":561,"context_line":"            gw_query \u003d gw_query.filter("},{"line_number":562,"context_line":"                      ml2_models.PortBinding.port_id \u003d\u003d models_v2.Port.id,"},{"line_number":563,"context_line":"                      models_v2.IPAllocation.port_id \u003d\u003d models_v2.Port.id,"},{"line_number":564,"context_line":"                      models_v2.IPAllocation.subnet_id \u003d\u003d models_v2.Subnet.id,"},{"line_number":565,"context_line":"                      models_v2.Subnet.ip_version \u003d\u003d 4,"},{"line_number":566,"context_line":"                      models_v2.Port.device_owner \u003d\u003d fip_agent_gw,"},{"line_number":567,"context_line":"                      models_v2.Port.network_id \u003d\u003d binding_network,"},{"line_number":568,"context_line":"                      binding_speaker \u003d\u003d bgp_speaker_id,"},{"line_number":569,"context_line":"                      binding_version \u003d\u003d 4)"},{"line_number":570,"context_line":"            gw_query \u003d gw_query.subquery()"},{"line_number":571,"context_line":"            fip_query \u003d context.session.query("},{"line_number":572,"context_line":"                                         l3_db.FloatingIP.floating_network_id,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_42b8842a","line":569,"range":{"start_line":561,"start_character":32,"end_line":569,"end_character":43},"updated":"2016-03-03 04:48:30.000000000","message":"For example, this filter looks like it is genuinely shareable.  Giving it a meaningful name by wrapping it in a method could help readability.","commit_id":"5639126ae54c24d5a05ee499f3c15026602d9c8d"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"bfe8f738b8cc0cea1168384001dfc1fa1414b5f5","unresolved":false,"context_lines":[{"line_number":569,"context_line":"                      binding_version \u003d\u003d 4)"},{"line_number":570,"context_line":"            gw_query \u003d gw_query.subquery()"},{"line_number":571,"context_line":"            fip_query \u003d context.session.query("},{"line_number":572,"context_line":"                                         l3_db.FloatingIP.floating_network_id,"},{"line_number":573,"context_line":"                                         ml2_models.PortBinding.host,"},{"line_number":574,"context_line":"                                         l3_db.FloatingIP.floating_ip_address)"},{"line_number":575,"context_line":"            fip_query \u003d fip_query.filter("},{"line_number":576,"context_line":"                      l3_db.FloatingIP.fixed_port_id \u003d\u003d port_binding_port,"},{"line_number":577,"context_line":"                      l3_db.FloatingIP.floating_network_id \u003d\u003d binding_network,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_c2f13403","line":574,"range":{"start_line":572,"start_character":41,"end_line":574,"end_character":77},"updated":"2016-03-03 04:48:30.000000000","message":"Another potentially shareable bit.  etc...","commit_id":"5639126ae54c24d5a05ee499f3c15026602d9c8d"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"bfe8f738b8cc0cea1168384001dfc1fa1414b5f5","unresolved":false,"context_lines":[{"line_number":573,"context_line":"                                         ml2_models.PortBinding.host,"},{"line_number":574,"context_line":"                                         l3_db.FloatingIP.floating_ip_address)"},{"line_number":575,"context_line":"            fip_query \u003d fip_query.filter("},{"line_number":576,"context_line":"                      l3_db.FloatingIP.fixed_port_id \u003d\u003d port_binding_port,"},{"line_number":577,"context_line":"                      l3_db.FloatingIP.floating_network_id \u003d\u003d binding_network,"},{"line_number":578,"context_line":"                      l3_db.FloatingIP.router_id \u003d\u003d router_id,"},{"line_number":579,"context_line":"                      binding_speaker \u003d\u003d bgp_speaker_id)"},{"line_number":580,"context_line":"            fip_query \u003d fip_query.subquery()"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_c27ad476","line":577,"range":{"start_line":576,"start_character":22,"end_line":577,"end_character":77},"updated":"2016-03-03 04:48:30.000000000","message":"This filter could also be shareable.","commit_id":"5639126ae54c24d5a05ee499f3c15026602d9c8d"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"00c95707bbaa1b58bc86a233deeb91cf854a533d","unresolved":false,"context_lines":[{"line_number":573,"context_line":"                                         ml2_models.PortBinding.host,"},{"line_number":574,"context_line":"                                         l3_db.FloatingIP.floating_ip_address)"},{"line_number":575,"context_line":"            fip_query \u003d fip_query.filter("},{"line_number":576,"context_line":"                      l3_db.FloatingIP.fixed_port_id \u003d\u003d port_binding_port,"},{"line_number":577,"context_line":"                      l3_db.FloatingIP.floating_network_id \u003d\u003d binding_network,"},{"line_number":578,"context_line":"                      l3_db.FloatingIP.router_id \u003d\u003d router_id,"},{"line_number":579,"context_line":"                      binding_speaker \u003d\u003d bgp_speaker_id)"},{"line_number":580,"context_line":"            fip_query \u003d fip_query.subquery()"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_559bee17","line":577,"range":{"start_line":576,"start_character":22,"end_line":577,"end_character":77},"in_reply_to":"7af24918_c27ad476","updated":"2016-03-03 19:21:01.000000000","message":"Maybe not so shareable, when we query by binding network we actually have an explicit network_id passed in, so the query is subtly different.","commit_id":"5639126ae54c24d5a05ee499f3c15026602d9c8d"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"26ce60e3b951e687c99de7b34ebbc50cf490f513","unresolved":false,"context_lines":[{"line_number":633,"context_line":"            binding_speaker \u003d BgpSpeakerNetworkBinding.bgp_speaker_id"},{"line_number":634,"context_line":"            binding_version \u003d BgpSpeakerNetworkBinding.ip_version"},{"line_number":635,"context_line":"            port_binding_port \u003d ml2_models.PortBinding.port_id"},{"line_number":636,"context_line":"            fip_agent_gw \u003d lib_consts.DEVICE_OWNER_AGENT_GW"},{"line_number":637,"context_line":"            gw_query \u003d context.session.query("},{"line_number":638,"context_line":"                                         models_v2.Port.network_id,"},{"line_number":639,"context_line":"                                         ml2_models.PortBinding.host,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_d5df3b67","line":636,"range":{"start_line":636,"start_character":12,"end_line":636,"end_character":24},"updated":"2016-03-03 00:24:31.000000000","message":"ditto","commit_id":"5639126ae54c24d5a05ee499f3c15026602d9c8d"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"bfe8f738b8cc0cea1168384001dfc1fa1414b5f5","unresolved":false,"context_lines":[{"line_number":711,"context_line":"    def _get_dvr_fip_host_routes_by_bgp_speaker(self, context,"},{"line_number":712,"context_line":"                                                bgp_speaker_id):"},{"line_number":713,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":714,"context_line":"            binding_network \u003d BgpSpeakerNetworkBinding.network_id"},{"line_number":715,"context_line":"            binding_speaker \u003d BgpSpeakerNetworkBinding.bgp_speaker_id"},{"line_number":716,"context_line":"            binding_version \u003d BgpSpeakerNetworkBinding.ip_version"},{"line_number":717,"context_line":"            port_binding_port \u003d ml2_models.PortBinding.port_id"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_5f518135","line":714,"range":{"start_line":714,"start_character":30,"end_line":714,"end_character":54},"updated":"2016-03-03 04:48:30.000000000","message":"nit:  You might consider these local short-cuts instead of the individual ones:\n\n  BgpBinding \u003d BgpSpeakerNetworkBinding\n  PortBinding \u003d ml2_models.PortBinding\n  Port \u003d ml2_models.Port\n\netc...  Making them look like ordinary local variables makes it more difficult to follow visually for me.","commit_id":"5639126ae54c24d5a05ee499f3c15026602d9c8d"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"76893a229339c241ffb239dbaf5d8e12581e5c2f","unresolved":false,"context_lines":[{"line_number":711,"context_line":"    def _get_dvr_fip_host_routes_by_bgp_speaker(self, context,"},{"line_number":712,"context_line":"                                                bgp_speaker_id):"},{"line_number":713,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":714,"context_line":"            binding_network \u003d BgpSpeakerNetworkBinding.network_id"},{"line_number":715,"context_line":"            binding_speaker \u003d BgpSpeakerNetworkBinding.bgp_speaker_id"},{"line_number":716,"context_line":"            binding_version \u003d BgpSpeakerNetworkBinding.ip_version"},{"line_number":717,"context_line":"            port_binding_port \u003d ml2_models.PortBinding.port_id"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_ea3d0290","line":714,"range":{"start_line":714,"start_character":30,"end_line":714,"end_character":54},"in_reply_to":"7af24918_5f518135","updated":"2016-03-03 16:03:55.000000000","message":"Good suggestion","commit_id":"5639126ae54c24d5a05ee499f3c15026602d9c8d"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"bfe8f738b8cc0cea1168384001dfc1fa1414b5f5","unresolved":false,"context_lines":[{"line_number":714,"context_line":"            binding_network \u003d BgpSpeakerNetworkBinding.network_id"},{"line_number":715,"context_line":"            binding_speaker \u003d BgpSpeakerNetworkBinding.bgp_speaker_id"},{"line_number":716,"context_line":"            binding_version \u003d BgpSpeakerNetworkBinding.ip_version"},{"line_number":717,"context_line":"            port_binding_port \u003d ml2_models.PortBinding.port_id"},{"line_number":718,"context_line":"            fip_agent_gw \u003d lib_consts.DEVICE_OWNER_AGENT_GW"},{"line_number":719,"context_line":"            gw_query \u003d context.session.query("},{"line_number":720,"context_line":"                                         models_v2.Port.network_id,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_3f059513","line":717,"range":{"start_line":717,"start_character":12,"end_line":717,"end_character":29},"updated":"2016-03-03 04:48:30.000000000","message":"nit:  This local alias isn\u0027t used consistently throughout the method.","commit_id":"5639126ae54c24d5a05ee499f3c15026602d9c8d"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"26ce60e3b951e687c99de7b34ebbc50cf490f513","unresolved":false,"context_lines":[{"line_number":715,"context_line":"            binding_speaker \u003d BgpSpeakerNetworkBinding.bgp_speaker_id"},{"line_number":716,"context_line":"            binding_version \u003d BgpSpeakerNetworkBinding.ip_version"},{"line_number":717,"context_line":"            port_binding_port \u003d ml2_models.PortBinding.port_id"},{"line_number":718,"context_line":"            fip_agent_gw \u003d lib_consts.DEVICE_OWNER_AGENT_GW"},{"line_number":719,"context_line":"            gw_query \u003d context.session.query("},{"line_number":720,"context_line":"                                         models_v2.Port.network_id,"},{"line_number":721,"context_line":"                                         ml2_models.PortBinding.host,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_d5745b69","line":718,"range":{"start_line":718,"start_character":11,"end_line":718,"end_character":24},"updated":"2016-03-03 00:24:31.000000000","message":"ditto","commit_id":"5639126ae54c24d5a05ee499f3c15026602d9c8d"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"00b62fc8c1d396f066ce8968bf1190218a5d64ed","unresolved":false,"context_lines":[{"line_number":548,"context_line":"    def _get_dvr_fip_host_routes_by_router(self, context, bgp_speaker_id,"},{"line_number":549,"context_line":"                                           router_id):"},{"line_number":550,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":551,"context_line":"            bgp_binding \u003d BgpSpeakerNetworkBinding"},{"line_number":552,"context_line":"            ml2_portbinding \u003d ml2_models.PortBinding"},{"line_number":553,"context_line":"            ip_allocation \u003d models_v2.IPAllocation"},{"line_number":554,"context_line":"            port \u003d models_v2.Port"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_60cd8630","line":551,"range":{"start_line":551,"start_character":11,"end_line":551,"end_character":24},"updated":"2016-03-03 19:22:05.000000000","message":"These aliases can start with Camelcase.\nBGPBinding \u003d\nPortbinding \u003d ml2_models.PortBinding\nIPAllocation \u003d models_v2.IPAlocation\nPort \u003d models_v2.Port","commit_id":"2a6429efc7023e2d3939a026575cac8ff0aa37ed"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"9aad413878cb00ec417a1a7939621dbff0b0c474","unresolved":false,"context_lines":[{"line_number":548,"context_line":"    def _get_dvr_fip_host_routes_by_router(self, context, bgp_speaker_id,"},{"line_number":549,"context_line":"                                           router_id):"},{"line_number":550,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":551,"context_line":"            bgp_binding \u003d BgpSpeakerNetworkBinding"},{"line_number":552,"context_line":"            ml2_portbinding \u003d ml2_models.PortBinding"},{"line_number":553,"context_line":"            ip_allocation \u003d models_v2.IPAllocation"},{"line_number":554,"context_line":"            port \u003d models_v2.Port"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_db3d6f2c","line":551,"range":{"start_line":551,"start_character":11,"end_line":551,"end_character":24},"in_reply_to":"7af24918_60cd8630","updated":"2016-03-03 19:40:32.000000000","message":"Makes sense, done.","commit_id":"2a6429efc7023e2d3939a026575cac8ff0aa37ed"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"ef19c2eaa1df4f5af9ac154621f306f73e8ebcab","unresolved":false,"context_lines":[{"line_number":580,"context_line":"                bgp_binding.bgp_speaker_id \u003d\u003d bgp_speaker_id)"},{"line_number":581,"context_line":"            fip_query \u003d fip_query.subquery()"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"            #Create the join query"},{"line_number":584,"context_line":"            join_query \u003d context.session.query("},{"line_number":585,"context_line":"                                           fip_query.c.floating_ip_address,"},{"line_number":586,"context_line":"                                           gw_query.c.ip_address)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_d5937e59","line":583,"updated":"2016-03-03 19:20:43.000000000","message":"This block is repeated 3 times, will refactor.  The pattern in the first queries patch is to have a single method that handles the joining of subqueries, I\u0027m thinking I\u0027ll go that route.\n\nBefore the join query in each of these methods I\u0027m finding it less pleasant to try and consolidate in some way. I\u0027m thinking that there\u0027s some re-use to be found in joining FIP\u0027s to agent gateways, which should help.","commit_id":"2a6429efc7023e2d3939a026575cac8ff0aa37ed"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"b0c5056f928f9b3f0fa5ab24bc73362079e945c3","unresolved":false,"context_lines":[{"line_number":557,"context_line":"                                             IpAllocation.ip_address)"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"            #Subquery for FIP agent gateway ports"},{"line_number":560,"context_line":"            gw_query \u003d gw_query.filter("},{"line_number":561,"context_line":"                ML2PortBinding.port_id \u003d\u003d Port.id,"},{"line_number":562,"context_line":"                IpAllocation.port_id \u003d\u003d Port.id,"},{"line_number":563,"context_line":"                IpAllocation.subnet_id \u003d\u003d models_v2.Subnet.id,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5aef4532_f6caa24e","line":560,"range":{"start_line":560,"start_character":12,"end_line":560,"end_character":20},"updated":"2016-03-07 19:12:26.000000000","message":"gw_query is exactly the same in all three methods in this file, right?","commit_id":"2d38c7b62d6549ab317d8646d8e5eddecc1be072"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"0ca8681788eba988a48fa9e93057d615386dc331","unresolved":false,"context_lines":[{"line_number":557,"context_line":"                                             IpAllocation.ip_address)"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"            #Subquery for FIP agent gateway ports"},{"line_number":560,"context_line":"            gw_query \u003d gw_query.filter("},{"line_number":561,"context_line":"                ML2PortBinding.port_id \u003d\u003d Port.id,"},{"line_number":562,"context_line":"                IpAllocation.port_id \u003d\u003d Port.id,"},{"line_number":563,"context_line":"                IpAllocation.subnet_id \u003d\u003d models_v2.Subnet.id,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5aef4532_be10ec4f","line":560,"range":{"start_line":560,"start_character":12,"end_line":560,"end_character":20},"in_reply_to":"5aef4532_f6caa24e","updated":"2016-03-07 20:38:32.000000000","message":"Turns out there is one small difference but my point still stands.","commit_id":"2d38c7b62d6549ab317d8646d8e5eddecc1be072"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"b0c5056f928f9b3f0fa5ab24bc73362079e945c3","unresolved":false,"context_lines":[{"line_number":576,"context_line":"            fip_query \u003d fip_query.filter("},{"line_number":577,"context_line":"                l3_db.FloatingIP.fixed_port_id \u003d\u003d ML2PortBinding.port_id,"},{"line_number":578,"context_line":"                l3_db.FloatingIP.floating_network_id \u003d\u003d BgpBinding.network_id,"},{"line_number":579,"context_line":"                l3_db.FloatingIP.router_id \u003d\u003d router_id,"},{"line_number":580,"context_line":"                BgpBinding.bgp_speaker_id \u003d\u003d bgp_speaker_id)"},{"line_number":581,"context_line":"            fip_query \u003d fip_query.subquery()"},{"line_number":582,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5aef4532_f6a3c29c","line":579,"range":{"start_line":579,"start_character":0,"end_line":579,"end_character":56},"updated":"2016-03-07 19:12:26.000000000","message":"This looks like it is the only unique part of this fip_query between this method and the next two methods.","commit_id":"2d38c7b62d6549ab317d8646d8e5eddecc1be072"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"b0c5056f928f9b3f0fa5ab24bc73362079e945c3","unresolved":false,"context_lines":[{"line_number":580,"context_line":"                BgpBinding.bgp_speaker_id \u003d\u003d bgp_speaker_id)"},{"line_number":581,"context_line":"            fip_query \u003d fip_query.subquery()"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"            #Create the join query"},{"line_number":584,"context_line":"            join_query \u003d self._join_fip_by_host_binding_to_agent_gateway("},{"line_number":585,"context_line":"                                                                    context,"},{"line_number":586,"context_line":"                                                                    fip_query,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5aef4532_d6ce8659","line":583,"range":{"start_line":583,"start_character":24,"end_line":583,"end_character":28},"updated":"2016-03-07 19:12:26.000000000","message":"This join query is duplicated, too.","commit_id":"2d38c7b62d6549ab317d8646d8e5eddecc1be072"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"0ca8681788eba988a48fa9e93057d615386dc331","unresolved":false,"context_lines":[{"line_number":646,"context_line":"                models_v2.Subnet.ip_version \u003d\u003d 4,"},{"line_number":647,"context_line":"                Port.device_owner \u003d\u003d lib_consts.DEVICE_OWNER_AGENT_GW,"},{"line_number":648,"context_line":"                Port.network_id \u003d\u003d BgpBinding.network_id,"},{"line_number":649,"context_line":"                BgpBinding.network_id \u003d\u003d network_id,"},{"line_number":650,"context_line":"                BgpBinding.bgp_speaker_id \u003d\u003d bgp_speaker_id,"},{"line_number":651,"context_line":"                BgpBinding.ip_version \u003d\u003d 4)"},{"line_number":652,"context_line":"            gw_query \u003d gw_query.subquery()"}],"source_content_type":"text/x-python","patch_set":9,"id":"5aef4532_c372417c","line":649,"range":{"start_line":649,"start_character":16,"end_line":649,"end_character":51},"updated":"2016-03-07 20:38:32.000000000","message":"I missed this one.","commit_id":"2d38c7b62d6549ab317d8646d8e5eddecc1be072"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"b0c5056f928f9b3f0fa5ab24bc73362079e945c3","unresolved":false,"context_lines":[{"line_number":659,"context_line":"            fip_query \u003d fip_query.filter("},{"line_number":660,"context_line":"                l3_db.FloatingIP.fixed_port_id \u003d\u003d ML2PortBinding.port_id,"},{"line_number":661,"context_line":"                l3_db.FloatingIP.floating_network_id \u003d\u003d BgpBinding.network_id,"},{"line_number":662,"context_line":"                BgpBinding.network_id \u003d\u003d network_id,"},{"line_number":663,"context_line":"                BgpBinding.bgp_speaker_id \u003d\u003d bgp_speaker_id)"},{"line_number":664,"context_line":"            fip_query \u003d fip_query.subquery()"},{"line_number":665,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5aef4532_16abce75","line":662,"range":{"start_line":662,"start_character":0,"end_line":662,"end_character":52},"updated":"2016-03-07 19:12:26.000000000","message":"The unique part of this query.","commit_id":"2d38c7b62d6549ab317d8646d8e5eddecc1be072"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"b0c5056f928f9b3f0fa5ab24bc73362079e945c3","unresolved":false,"context_lines":[{"line_number":742,"context_line":"                                         l3_db.FloatingIP.floating_ip_address)"},{"line_number":743,"context_line":"            fip_query \u003d fip_query.filter("},{"line_number":744,"context_line":"                l3_db.FloatingIP.fixed_port_id \u003d\u003d ML2PortBinding.port_id,"},{"line_number":745,"context_line":"                l3_db.FloatingIP.floating_network_id \u003d\u003d BgpBinding.network_id,"},{"line_number":746,"context_line":"                BgpBinding.bgp_speaker_id \u003d\u003d bgp_speaker_id)"},{"line_number":747,"context_line":"            fip_query \u003d fip_query.subquery()"},{"line_number":748,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5aef4532_96035e73","line":745,"updated":"2016-03-07 19:12:26.000000000","message":"This fip_query doesn\u0027t have any unique part.  It is all duplicated with the other two.","commit_id":"2d38c7b62d6549ab317d8646d8e5eddecc1be072"}],"releasenotes/notes/bgp-support-ef361825ca63f28b.yaml":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"cef668b411a47c84c764e57ec77e7e23a754cb36","unresolved":false,"context_lines":[{"line_number":13,"context_line":"issues:"},{"line_number":14,"context_line":"  - When using DVR, if a floating IP is associated to a fixed IP direct"},{"line_number":15,"context_line":"    access to the fixed IP is not possible. When using a distributed"},{"line_number":16,"context_line":"    router, the floating IP will mask the floating IP making it"},{"line_number":17,"context_line":"    inaccessible, even though the tenant subnet is being announced as"},{"line_number":18,"context_line":"    accessible through the centralized router."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"5aef4532_260a9879","line":16,"range":{"start_line":16,"start_character":16,"end_line":16,"end_character":50},"updated":"2016-03-09 18:00:45.000000000","message":"This doesn\u0027t sound right.","commit_id":"abff7d0000c3cc095a56b56a519b699a83be1ea2"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"fd0063c5527a785a29d8488cd4691728ff06c9a3","unresolved":false,"context_lines":[{"line_number":13,"context_line":"issues:"},{"line_number":14,"context_line":"  - When using DVR, if a floating IP is associated to a fixed IP direct"},{"line_number":15,"context_line":"    access to the fixed IP is not possible. When using a distributed"},{"line_number":16,"context_line":"    router, the floating IP will mask the floating IP making it"},{"line_number":17,"context_line":"    inaccessible, even though the tenant subnet is being announced as"},{"line_number":18,"context_line":"    accessible through the centralized router."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"5aef4532_2658d889","line":16,"range":{"start_line":16,"start_character":16,"end_line":16,"end_character":50},"in_reply_to":"5aef4532_260a9879","updated":"2016-03-09 18:03:07.000000000","message":"Doh! floating IP masks the fixed IP not floating IP, typo.","commit_id":"abff7d0000c3cc095a56b56a519b699a83be1ea2"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"837018afde4486c5eb9e220d1696eeef92861d36","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    access to the fixed IP is not possible when traffic is sent from"},{"line_number":16,"context_line":"    outside of a Neutron tenant network (north-south traffic). Traffic"},{"line_number":17,"context_line":"    sent between tenant networks (east-west traffic) is not affected."},{"line_number":18,"context_line":"    When using a distributed  router, the floating IP will mask the fixed"},{"line_number":19,"context_line":"    IP making it inaccessible, even though the tenant subnet is being"},{"line_number":20,"context_line":"    announced as accessible through the centralized router. In such a case,"},{"line_number":21,"context_line":"    traffic sent to the instance must be directed to the floating IP."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"5aef4532_bd1356b7","line":18,"range":{"start_line":18,"start_character":28,"end_line":18,"end_character":30},"updated":"2016-03-09 18:32:31.000000000","message":"Uh oh, double space!  ;)","commit_id":"c93f431ae1b9f54fb7ef65674576f108717e2eaf"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"ef9c2f4a1eaa1f1d4769173841288543316ee1a0","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    sent between tenant networks (east-west traffic) is not affected."},{"line_number":18,"context_line":"    When using a distributed  router, the floating IP will mask the fixed"},{"line_number":19,"context_line":"    IP making it inaccessible, even though the tenant subnet is being"},{"line_number":20,"context_line":"    announced as accessible through the centralized router. In such a case,"},{"line_number":21,"context_line":"    traffic sent to the instance must be directed to the floating IP."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"5aef4532_53a84377","line":20,"updated":"2016-03-09 19:02:50.000000000","message":"what centralized router? You mean the snat part of the dvr router?","commit_id":"c93f431ae1b9f54fb7ef65674576f108717e2eaf"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7ede1a91033b601c3e69c3c9f759caa961277c8b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    sent between tenant networks (east-west traffic) is not affected."},{"line_number":18,"context_line":"    When using a distributed  router, the floating IP will mask the fixed"},{"line_number":19,"context_line":"    IP making it inaccessible, even though the tenant subnet is being"},{"line_number":20,"context_line":"    announced as accessible through the centralized router. In such a case,"},{"line_number":21,"context_line":"    traffic sent to the instance must be directed to the floating IP."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"5aef4532_6953cc39","line":20,"in_reply_to":"5aef4532_49d37004","updated":"2016-03-09 19:47:40.000000000","message":"I would like to think so ;)","commit_id":"c93f431ae1b9f54fb7ef65674576f108717e2eaf"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"2cea33135692b11dd34caf47c387813d68fd3d66","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    sent between tenant networks (east-west traffic) is not affected."},{"line_number":18,"context_line":"    When using a distributed  router, the floating IP will mask the fixed"},{"line_number":19,"context_line":"    IP making it inaccessible, even though the tenant subnet is being"},{"line_number":20,"context_line":"    announced as accessible through the centralized router. In such a case,"},{"line_number":21,"context_line":"    traffic sent to the instance must be directed to the floating IP."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"5aef4532_49d37004","line":20,"in_reply_to":"5aef4532_53a84377","updated":"2016-03-09 19:41:12.000000000","message":"Yes, SNAT part of the DVR router. Not sure how to describe that to the lay operator, but perhaps they\u0027ll understand what the SNAT component is.","commit_id":"c93f431ae1b9f54fb7ef65674576f108717e2eaf"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"ef9c2f4a1eaa1f1d4769173841288543316ee1a0","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    When using a distributed  router, the floating IP will mask the fixed"},{"line_number":19,"context_line":"    IP making it inaccessible, even though the tenant subnet is being"},{"line_number":20,"context_line":"    announced as accessible through the centralized router. In such a case,"},{"line_number":21,"context_line":"    traffic sent to the instance must be directed to the floating IP."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"5aef4532_b32c2703","line":21,"updated":"2016-03-09 19:02:50.000000000","message":"You mean that north/south traffic can solely work by directly talking to the Floating IP, i.e. there\u0027s no N/S path advertised for the fixed ip, should traffic be initiated by an entity outside the Neutron domain?\n\nCan you mention whether or not this limitation is planned to be lifted?","commit_id":"c93f431ae1b9f54fb7ef65674576f108717e2eaf"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7ede1a91033b601c3e69c3c9f759caa961277c8b","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    When using a distributed  router, the floating IP will mask the fixed"},{"line_number":19,"context_line":"    IP making it inaccessible, even though the tenant subnet is being"},{"line_number":20,"context_line":"    announced as accessible through the centralized router. In such a case,"},{"line_number":21,"context_line":"    traffic sent to the instance must be directed to the floating IP."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"5aef4532_e93d1cde","line":21,"in_reply_to":"5aef4532_29254408","updated":"2016-03-09 19:47:40.000000000","message":"thank you","commit_id":"c93f431ae1b9f54fb7ef65674576f108717e2eaf"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"2cea33135692b11dd34caf47c387813d68fd3d66","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    When using a distributed  router, the floating IP will mask the fixed"},{"line_number":19,"context_line":"    IP making it inaccessible, even though the tenant subnet is being"},{"line_number":20,"context_line":"    announced as accessible through the centralized router. In such a case,"},{"line_number":21,"context_line":"    traffic sent to the instance must be directed to the floating IP."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"5aef4532_29254408","line":21,"in_reply_to":"5aef4532_b32c2703","updated":"2016-03-09 19:41:12.000000000","message":"I\u0027ll make mention of the limitations of the L3 agent. There is no bug or spec to link to yet though, but I can mention the intent to address the issue.","commit_id":"c93f431ae1b9f54fb7ef65674576f108717e2eaf"}]}
