)]}'
{"neutron/tests/unit/plugins/ml2/drivers/l2pop/test_mech_driver.py":[{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"cb761bede4980154e9cbd6fe6d4e02bef83fe4f1","unresolved":false,"context_lines":[{"line_number":412,"context_line":"                            self.mock_fanout.assert_called_with("},{"line_number":413,"context_line":"                                mock.ANY, \u0027add_fdb_entries\u0027, expected2)"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"    def test_fdb_add_called_dualstack(self):"},{"line_number":416,"context_line":"        self._register_ml2_agents()"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"        host_arg \u003d {portbindings.HOST_ID: HOST,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_f2a7b1ba","line":415,"range":{"start_line":415,"start_character":8,"end_line":415,"end_character":37},"updated":"2016-01-25 09:20:42.000000000","message":"I think it would be better to duplicate the test : \n\ntest_fdb_add_two_agents()\n\nAnd mocking the fanout and the cast.\nThis way, we would ensure that the fdb message contains IPV6 addresses in those two messages, and that the fdb message is correctly built for agents that boot a new port (cast) and for agents that host a port in the same segment (fanout).\n\nThoughts?","commit_id":"a813d94e710cf8e36f0d711f266059b17afb2894"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"a02ac826262fd6090f55dbcd244ab1c0224bdaf8","unresolved":false,"context_lines":[{"line_number":412,"context_line":"                            self.mock_fanout.assert_called_with("},{"line_number":413,"context_line":"                                mock.ANY, \u0027add_fdb_entries\u0027, expected2)"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"    def test_fdb_add_called_dualstack(self):"},{"line_number":416,"context_line":"        self._register_ml2_agents()"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"        host_arg \u003d {portbindings.HOST_ID: HOST,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_91e3d2d8","line":415,"range":{"start_line":415,"start_character":8,"end_line":415,"end_character":37},"in_reply_to":"9a68dd71_f2a7b1ba","updated":"2016-01-25 10:03:04.000000000","message":"+1","commit_id":"a813d94e710cf8e36f0d711f266059b17afb2894"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"f034daa4c9b325ee9ac63e1666d18bec8a0590d1","unresolved":false,"context_lines":[{"line_number":412,"context_line":"                            self.mock_fanout.assert_called_with("},{"line_number":413,"context_line":"                                mock.ANY, \u0027add_fdb_entries\u0027, expected2)"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"    def test_fdb_add_called_dualstack(self):"},{"line_number":416,"context_line":"        self._register_ml2_agents()"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"        host_arg \u003d {portbindings.HOST_ID: HOST,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_c4617dd4","line":415,"in_reply_to":"9a68dd71_f2a7b1ba","updated":"2016-01-25 14:38:54.000000000","message":"How about we do it in a follow up patch? I\u0027m reading through test_fdb_add_two_agents() and there are some things that I\u0027m a little unclear about, that I need to investigate further. It shouldn\u0027t block this patch though.","commit_id":"a813d94e710cf8e36f0d711f266059b17afb2894"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"761fae4cdad0bd0040a78526bcbf08f1c95f180a","unresolved":false,"context_lines":[{"line_number":445,"context_line":"                expected \u003d {p1[\u0027network_id\u0027]:"},{"line_number":446,"context_line":"                            {\u0027ports\u0027:"},{"line_number":447,"context_line":"                             {\u002720.0.0.1\u0027: [constants.FLOODING_ENTRY,"},{"line_number":448,"context_line":"                                           l2pop_rpc.PortInfo("},{"line_number":449,"context_line":"                                               p1[\u0027mac_address\u0027],"},{"line_number":450,"context_line":"                                               p1_ips[0]),"},{"line_number":451,"context_line":"                                           l2pop_rpc.PortInfo("},{"line_number":452,"context_line":"                                               p1[\u0027mac_address\u0027],"},{"line_number":453,"context_line":"                                               p1_ips[1])]},"},{"line_number":454,"context_line":"                             \u0027network_type\u0027: \u0027vxlan\u0027,"},{"line_number":455,"context_line":"                             \u0027segment_id\u0027: 1}}"},{"line_number":456,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_ba80f0f8","line":453,"range":{"start_line":448,"start_character":43,"end_line":453,"end_character":57},"updated":"2016-01-26 11:49:39.000000000","message":"the order may change I guess..","commit_id":"a813d94e710cf8e36f0d711f266059b17afb2894"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"de86d441d1b1f6f0a2365a8e519bed84800a6f79","unresolved":false,"context_lines":[{"line_number":450,"context_line":"                                               p1_ips[0]),"},{"line_number":451,"context_line":"                                           l2pop_rpc.PortInfo("},{"line_number":452,"context_line":"                                               p1[\u0027mac_address\u0027],"},{"line_number":453,"context_line":"                                               p1_ips[1])]},"},{"line_number":454,"context_line":"                             \u0027network_type\u0027: \u0027vxlan\u0027,"},{"line_number":455,"context_line":"                             \u0027segment_id\u0027: 1}}"},{"line_number":456,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_bd6bf384","line":453,"in_reply_to":"9a68dd71_ba80f0f8","updated":"2016-01-26 17:53:34.000000000","message":"We specify the order up in L429","commit_id":"a813d94e710cf8e36f0d711f266059b17afb2894"}]}