)]}'
{"neutron/hacking/checks.py":[{"author":{"_account_id":18573,"name":"Petri Kemppainen","email":"petri.kemppainen@nokia.com","username":"petrkemp"},"change_message_id":"7da9184819f20770bfd127ff4d863abed0301008","unresolved":false,"context_lines":[{"line_number":231,"context_line":""},{"line_number":232,"context_line":"def check_use_dict_keys_as_list(logical_line):"},{"line_number":233,"context_line":"    msg \u003d (\"N332: Replace \u0027dict.keys() + onelist\u0027 with \u0027list(dict.keys())\""},{"line_number":234,"context_line":"           \" + onelist\u0027, same for dict.values() and dict.items().\")"},{"line_number":235,"context_line":"    if use_dict_keys_as_list.search(logical_line):"},{"line_number":236,"context_line":"        yield (0, msg)"},{"line_number":237,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_7dfdb6af","line":234,"range":{"start_line":234,"start_character":12,"end_line":234,"end_character":13},"updated":"2016-01-25 18:12:48.000000000","message":"Please, move this space to the end of the previous line.","commit_id":"41b93389965ec75a0954e72c749fccbeb9e330f3"},{"author":{"_account_id":8686,"name":"Wang Bo","email":"bo.wang@easystack.cn","username":"wangbo"},"change_message_id":"f13651989684fe2be537899d5eccfd7185eb7c24","unresolved":false,"context_lines":[{"line_number":231,"context_line":""},{"line_number":232,"context_line":"def check_use_dict_keys_as_list(logical_line):"},{"line_number":233,"context_line":"    msg \u003d (\"N332: Replace \u0027dict.keys() + onelist\u0027 with \u0027list(dict.keys())\""},{"line_number":234,"context_line":"           \" + onelist\u0027, same for dict.values() and dict.items().\")"},{"line_number":235,"context_line":"    if use_dict_keys_as_list.search(logical_line):"},{"line_number":236,"context_line":"        yield (0, msg)"},{"line_number":237,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_6523cf56","line":234,"range":{"start_line":234,"start_character":12,"end_line":234,"end_character":13},"in_reply_to":"9a68dd71_7dfdb6af","updated":"2016-01-26 03:16:33.000000000","message":"thanks for your review.\n\nDone in patch set 3.","commit_id":"41b93389965ec75a0954e72c749fccbeb9e330f3"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"6003da5c1167b888b8b0717bbe77c127489fc135","unresolved":false,"context_lines":[{"line_number":42,"context_line":"}"},{"line_number":43,"context_line":"_all_hints \u003d set(_all_log_levels.values())"},{"line_number":44,"context_line":"mutable_default_args \u003d re.compile(r\"^\\s*def .+\\((.+\u003d\\{\\}|.+\u003d\\[\\])\")"},{"line_number":45,"context_line":"use_dict_keys_as_list \u003d re.compile(r\"\\.(?:keys|values|items)\\(\\) *\\+ *\")"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def _regex_for_level(level, hint):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_bb4a2826","line":45,"range":{"start_line":45,"start_character":35,"end_line":45,"end_character":71},"updated":"2016-01-26 15:11:05.000000000","message":"What about \"onelist + dict.keys()\"?","commit_id":"f6b387064bc858fe02fb1919fb3d3a63184d8d96"},{"author":{"_account_id":8686,"name":"Wang Bo","email":"bo.wang@easystack.cn","username":"wangbo"},"change_message_id":"528c933b3573f0a92a0fb822519ce7dc0d57e21d","unresolved":false,"context_lines":[{"line_number":42,"context_line":"}"},{"line_number":43,"context_line":"_all_hints \u003d set(_all_log_levels.values())"},{"line_number":44,"context_line":"mutable_default_args \u003d re.compile(r\"^\\s*def .+\\((.+\u003d\\{\\}|.+\u003d\\[\\])\")"},{"line_number":45,"context_line":"use_dict_keys_as_list \u003d re.compile(r\"\\.(?:keys|values|items)\\(\\) *\\+ *\")"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def _regex_for_level(level, hint):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_89511911","line":45,"range":{"start_line":45,"start_character":35,"end_line":45,"end_character":71},"in_reply_to":"9a68dd71_863588f8","updated":"2016-01-26 16:41:19.000000000","message":"in patch set 4. sorry","commit_id":"f6b387064bc858fe02fb1919fb3d3a63184d8d96"},{"author":{"_account_id":8686,"name":"Wang Bo","email":"bo.wang@easystack.cn","username":"wangbo"},"change_message_id":"5de943dbe96fe0296c2f59a5778b09e62e04f145","unresolved":false,"context_lines":[{"line_number":42,"context_line":"}"},{"line_number":43,"context_line":"_all_hints \u003d set(_all_log_levels.values())"},{"line_number":44,"context_line":"mutable_default_args \u003d re.compile(r\"^\\s*def .+\\((.+\u003d\\{\\}|.+\u003d\\[\\])\")"},{"line_number":45,"context_line":"use_dict_keys_as_list \u003d re.compile(r\"\\.(?:keys|values|items)\\(\\) *\\+ *\")"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def _regex_for_level(level, hint):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_863588f8","line":45,"range":{"start_line":45,"start_character":35,"end_line":45,"end_character":71},"in_reply_to":"9a68dd71_bb4a2826","updated":"2016-01-26 16:39:12.000000000","message":"thanks for your review, yes this need to be took into account.\n\nDone in patch set 5.","commit_id":"f6b387064bc858fe02fb1919fb3d3a63184d8d96"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"6f390a510bd6c3456b5cf1d0a8c5d40bde22844f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"_all_hints \u003d set(_all_log_levels.values())"},{"line_number":44,"context_line":"mutable_default_args \u003d re.compile(r\"^\\s*def .+\\((.+\u003d\\{\\}|.+\u003d\\[\\])\")"},{"line_number":45,"context_line":"dict_keys_add_list \u003d re.compile(r\"\\.(?:keys|values|items)\\(\\) *\\+ *\")"},{"line_number":46,"context_line":"list_add_dict_keys \u003d re.compile(r\"\\+ *.+\\.(?:keys|values|items)\\(\\)\")"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"def _regex_for_level(level, hint):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_446a161c","line":46,"range":{"start_line":46,"start_character":38,"end_line":46,"end_character":67},"updated":"2016-01-27 00:54:20.000000000","message":"It matches correct patterns: list(dict.keys()).","commit_id":"553ddccc21bcb746c4a7c1c384334183e25ed57d"},{"author":{"_account_id":8686,"name":"Wang Bo","email":"bo.wang@easystack.cn","username":"wangbo"},"change_message_id":"06dccfe2091e90322294e63a3208676f1e681b5c","unresolved":false,"context_lines":[{"line_number":43,"context_line":"_all_hints \u003d set(_all_log_levels.values())"},{"line_number":44,"context_line":"mutable_default_args \u003d re.compile(r\"^\\s*def .+\\((.+\u003d\\{\\}|.+\u003d\\[\\])\")"},{"line_number":45,"context_line":"dict_keys_add_list \u003d re.compile(r\"\\.(?:keys|values|items)\\(\\) *\\+ *\")"},{"line_number":46,"context_line":"list_add_dict_keys \u003d re.compile(r\"\\+ *.+\\.(?:keys|values|items)\\(\\)\")"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"def _regex_for_level(level, hint):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_83b55bd1","line":46,"range":{"start_line":46,"start_character":38,"end_line":46,"end_character":67},"in_reply_to":"9a68dd71_446a161c","updated":"2016-01-27 07:26:26.000000000","message":"Thanks for review.\n\nresolve it in patch set 5.","commit_id":"553ddccc21bcb746c4a7c1c384334183e25ed57d"}]}