)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"a48c95463e384b86525765ff07ac66d3377f930f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"do not create namespace if snat is disabled"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"do not create qrouter/snat namespaces on snat host if snat is"},{"line_number":10,"context_line":"disabled."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If7f2176ef81fb4a767f530e1bbe87669458bd45b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a68dd71_b0f4c75a","line":9,"range":{"start_line":9,"start_character":14,"end_line":9,"end_character":21},"updated":"2016-01-25 13:39:25.000000000","message":"I don\u0027t think qrouter namespace should be removed. It may be used by other port, like lbaas.","commit_id":"56349a302fde3161564ae78543505c71ecd4e49d"},{"author":{"_account_id":14154,"name":"Takanori Miyagishi","email":"miyagishi.t@jp.fujitsu.com","username":"takanorimiyagishi"},"change_message_id":"e276b0684a4de0ff4109d7d9ba3b576bccf7dadb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"do not create namespace if snat is disabled"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"do not create qrouter/snat namespaces on snat host if snat is"},{"line_number":10,"context_line":"disabled."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If7f2176ef81fb4a767f530e1bbe87669458bd45b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a5ae5dd_1dc73597","line":9,"range":{"start_line":9,"start_character":14,"end_line":9,"end_character":21},"in_reply_to":"9a68dd71_b0f4c75a","updated":"2016-02-05 12:21:41.000000000","message":"I added a new setting for enable/disable this patch\u0027s change.\nIf you want to use lbaas and others, you can keep the bahavior of l3-agent as until now by the setting to True.","commit_id":"56349a302fde3161564ae78543505c71ecd4e49d"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"5a3ca69dc29e3354972d96e4556ff9b150fea3c1","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add a setting of l3_agent.ini to skip create qrouter/snat"},{"line_number":10,"context_line":"namespaces on snat host if snat is disabled."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If7f2176ef81fb4a767f530e1bbe87669458bd45b"},{"line_number":13,"context_line":"Closes-Bug: #1518296"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a5de9d1_b70a5d77","line":11,"updated":"2016-02-02 05:23:45.000000000","message":"We need DocImpact tag here.","commit_id":"8a4814a74216027174a6150c2cfcd712882b3de8"},{"author":{"_account_id":14154,"name":"Takanori Miyagishi","email":"miyagishi.t@jp.fujitsu.com","username":"takanorimiyagishi"},"change_message_id":"b874cbb52edb5e67bfb355973f0ef02a3f7601c8","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add a setting of l3_agent.ini to skip create qrouter/snat"},{"line_number":10,"context_line":"namespaces on snat host if snat is disabled."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If7f2176ef81fb4a767f530e1bbe87669458bd45b"},{"line_number":13,"context_line":"Closes-Bug: #1518296"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a5ae5dd_1d4e553b","line":11,"in_reply_to":"7a5de9d1_b70a5d77","updated":"2016-02-05 12:23:05.000000000","message":"I will add the tag.","commit_id":"8a4814a74216027174a6150c2cfcd712882b3de8"}],"neutron/agent/l3/config.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"5a3ca69dc29e3354972d96e4556ff9b150fea3c1","unresolved":false,"context_lines":[{"line_number":100,"context_line":"               help\u003d_(\u0027Iptables mangle mark used to mark ingress from \u0027"},{"line_number":101,"context_line":"                      \u0027external network. This mark will be masked with \u0027"},{"line_number":102,"context_line":"                      \u00270xffff so that only the lower 16 bits will be used.\u0027)),"},{"line_number":103,"context_line":"    cfg.BoolOpt(\u0027allow_external_packet_if_snat_disabled\u0027, default\u003dTrue,"},{"line_number":104,"context_line":"                help\u003d_(\u0027Allow packets flow on external network when \u0027"},{"line_number":105,"context_line":"                       \u0027the value of enable_snat that is contained in \u0027"},{"line_number":106,"context_line":"                       \u0027external_gateway_info of router is False.\u0027)),"},{"line_number":107,"context_line":"]"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"OPTS +\u003d config.EXT_NET_BRIDGE_OPTS"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_f72d35fe","line":106,"range":{"start_line":103,"start_character":4,"end_line":106,"end_character":69},"updated":"2016-02-02 05:23:45.000000000","message":"This config prevents creating namespace, doesn\u0027t it? I guess that users cannot get it from the option name and help.","commit_id":"8a4814a74216027174a6150c2cfcd712882b3de8"},{"author":{"_account_id":14154,"name":"Takanori Miyagishi","email":"miyagishi.t@jp.fujitsu.com","username":"takanorimiyagishi"},"change_message_id":"b874cbb52edb5e67bfb355973f0ef02a3f7601c8","unresolved":false,"context_lines":[{"line_number":100,"context_line":"               help\u003d_(\u0027Iptables mangle mark used to mark ingress from \u0027"},{"line_number":101,"context_line":"                      \u0027external network. This mark will be masked with \u0027"},{"line_number":102,"context_line":"                      \u00270xffff so that only the lower 16 bits will be used.\u0027)),"},{"line_number":103,"context_line":"    cfg.BoolOpt(\u0027allow_external_packet_if_snat_disabled\u0027, default\u003dTrue,"},{"line_number":104,"context_line":"                help\u003d_(\u0027Allow packets flow on external network when \u0027"},{"line_number":105,"context_line":"                       \u0027the value of enable_snat that is contained in \u0027"},{"line_number":106,"context_line":"                       \u0027external_gateway_info of router is False.\u0027)),"},{"line_number":107,"context_line":"]"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"OPTS +\u003d config.EXT_NET_BRIDGE_OPTS"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_3df9d1c7","line":106,"range":{"start_line":103,"start_character":4,"end_line":106,"end_character":69},"in_reply_to":"7a5de9d1_f72d35fe","updated":"2016-02-05 12:23:05.000000000","message":"Your understanding is correct. I will change the option\u0027s help.","commit_id":"8a4814a74216027174a6150c2cfcd712882b3de8"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"f3a4981d10fa40103dbeb4bb8081511e35848445","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                       \u0027external_gateway_info of router is False. \u0027"},{"line_number":107,"context_line":"                       \u0027If the value of this setting is set as \"False\", \u0027"},{"line_number":108,"context_line":"                       \u0027it will prevent create qrouter/snat namespaces \u0027"},{"line_number":109,"context_line":"                       \u0027on SNAT host.\u0027)),"},{"line_number":110,"context_line":"]"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"OPTS +\u003d config.EXT_NET_BRIDGE_OPTS"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_4376d6a4","line":109,"updated":"2016-02-29 03:26:35.000000000","message":"This makes no sense to me.","commit_id":"2c13b58e94aeaae1f5725f8be62cbab34b518711"},{"author":{"_account_id":14154,"name":"Takanori Miyagishi","email":"miyagishi.t@jp.fujitsu.com","username":"takanorimiyagishi"},"change_message_id":"2b25c52b4ab4d3d8c7cf3629112309d612aee654","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                       \u0027external_gateway_info of router is False. \u0027"},{"line_number":107,"context_line":"                       \u0027If the value of this setting is set as \"False\", \u0027"},{"line_number":108,"context_line":"                       \u0027it will prevent create qrouter/snat namespaces \u0027"},{"line_number":109,"context_line":"                       \u0027on SNAT host.\u0027)),"},{"line_number":110,"context_line":"]"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"OPTS +\u003d config.EXT_NET_BRIDGE_OPTS"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_89ae3d7f","line":109,"in_reply_to":"9aed3d3a_4376d6a4","updated":"2016-02-29 05:51:56.000000000","message":"I added this option for maintain compatible with current implement.","commit_id":"2c13b58e94aeaae1f5725f8be62cbab34b518711"}],"neutron/agent/l3/router_info.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"5a3ca69dc29e3354972d96e4556ff9b150fea3c1","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        if not self._router:"},{"line_number":92,"context_line":"            return"},{"line_number":93,"context_line":"        # enable_snat by default if it wasn\u0027t specified by plugin"},{"line_number":94,"context_line":"        default_snat \u003d l3_gwmode.L3_NAT_dbonly_mixin._get_enable_snat(None)"},{"line_number":95,"context_line":"        self._snat_enabled \u003d self._router.get(\u0027enable_snat\u0027, default_snat)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def get_internal_device_name(self, port_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_17957131","line":94,"range":{"start_line":94,"start_character":8,"end_line":94,"end_character":75},"updated":"2016-02-02 05:23:45.000000000","message":"I feel strange that agent reads db and I\u0027m not sure what for?","commit_id":"8a4814a74216027174a6150c2cfcd712882b3de8"},{"author":{"_account_id":14154,"name":"Takanori Miyagishi","email":"miyagishi.t@jp.fujitsu.com","username":"takanorimiyagishi"},"change_message_id":"b874cbb52edb5e67bfb355973f0ef02a3f7601c8","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        if not self._router:"},{"line_number":92,"context_line":"            return"},{"line_number":93,"context_line":"        # enable_snat by default if it wasn\u0027t specified by plugin"},{"line_number":94,"context_line":"        default_snat \u003d l3_gwmode.L3_NAT_dbonly_mixin._get_enable_snat(None)"},{"line_number":95,"context_line":"        self._snat_enabled \u003d self._router.get(\u0027enable_snat\u0027, default_snat)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def get_internal_device_name(self, port_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_fdd6d9ef","line":94,"range":{"start_line":94,"start_character":8,"end_line":94,"end_character":75},"in_reply_to":"7a5de9d1_17957131","updated":"2016-02-05 12:23:05.000000000","message":"For current implementation, it will not reflects the value of \"enable_snat_by_default\" that set in neutron.conf. So I changed this lines by get the setting\u0027s value.\nHowever, as you commented, this way is not good. I will fix the procedure.","commit_id":"8a4814a74216027174a6150c2cfcd712882b3de8"}]}
