)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"980c657605da2e9dd86d59a29cba267e0285e242","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Contains a bit of refactoring to make that happen:"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- validate_allocation_pools is already calle during update"},{"line_number":18,"context_line":"subnet workflow in update_subnet method, so just removing it;"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- reworked update_db_subnet workflow;"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a5ae5dd_0ba25399","line":17,"range":{"start_line":17,"start_character":39,"end_line":17,"end_character":44},"updated":"2016-02-08 06:34:17.000000000","message":"called","commit_id":"2fc48a25be301628c9d4daef24604582bac6478f"},{"author":{"_account_id":13768,"name":"Pavel Bondar","email":"pbondar@infoblox.com","username":"pavel_bondar"},"change_message_id":"4755c77c4690041b8e3574226621058b6b1474a2","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Contains a bit of refactoring to make that happen:"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- validate_allocation_pools is already calle during update"},{"line_number":18,"context_line":"subnet workflow in update_subnet method, so just removing it;"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- reworked update_db_subnet workflow;"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a5ae5dd_37e68d15","line":17,"range":{"start_line":17,"start_character":39,"end_line":17,"end_character":44},"in_reply_to":"5a5ae5dd_0ba25399","updated":"2016-02-08 10:37:56.000000000","message":"will fix","commit_id":"2fc48a25be301628c9d4daef24604582bac6478f"}],"neutron/db/ipam_pluggable_backend.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"980c657605da2e9dd86d59a29cba267e0285e242","unresolved":false,"context_lines":[{"line_number":357,"context_line":"            context, id, s, old_pools)"},{"line_number":358,"context_line":"        ipam_driver \u003d driver.Pool.get_instance(None, context)"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"        if \u0027allocation_pools\u0027 not in subnet:"},{"line_number":361,"context_line":"            subnet_copy[\u0027allocation_pools\u0027] \u003d old_pools"},{"line_number":362,"context_line":"        self._ipam_update_allocation_pools(context, ipam_driver, subnet_copy)"},{"line_number":363,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_4bea8b75","line":360,"updated":"2016-02-08 06:34:17.000000000","message":"can you explain this condition?","commit_id":"2fc48a25be301628c9d4daef24604582bac6478f"},{"author":{"_account_id":13768,"name":"Pavel Bondar","email":"pbondar@infoblox.com","username":"pavel_bondar"},"change_message_id":"4755c77c4690041b8e3574226621058b6b1474a2","unresolved":false,"context_lines":[{"line_number":357,"context_line":"            context, id, s, old_pools)"},{"line_number":358,"context_line":"        ipam_driver \u003d driver.Pool.get_instance(None, context)"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"        if \u0027allocation_pools\u0027 not in subnet:"},{"line_number":361,"context_line":"            subnet_copy[\u0027allocation_pools\u0027] \u003d old_pools"},{"line_number":362,"context_line":"        self._ipam_update_allocation_pools(context, ipam_driver, subnet_copy)"},{"line_number":363,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_34da0be9","line":360,"in_reply_to":"5a5ae5dd_4bea8b75","updated":"2016-02-08 10:37:56.000000000","message":"Thanks for pointing to this check, looks like mistake here.\nI was going to check \u0027allocation_pools\u0027 in \u0027subnet_copy\u0027 and set it to old pools if user doesn\u0027t provide new \u0027allocation_pools\u0027.\nIn this case driver would be called with allocation_pools, new or old, depending on user input.\nWill fix within next patchset.","commit_id":"2fc48a25be301628c9d4daef24604582bac6478f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b6e62838c0fb55a405b44af80874af59acec828f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import copy"},{"line_number":17,"context_line":"import netaddr"},{"line_number":18,"context_line":"from oslo_db import exception as db_exc"},{"line_number":19,"context_line":"from oslo_log import log as logging"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_021f6708","line":16,"updated":"2016-04-07 12:32:49.000000000","message":"copy should be in its own section it is not third party","commit_id":"6865086c7ed617d40ca7d14e3630a3bbe9481588"},{"author":{"_account_id":13768,"name":"Pavel Bondar","email":"pbondar@infoblox.com","username":"pavel_bondar"},"change_message_id":"5e67a2354fd8bdaa161a316ba5a26aa0e8690500","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import copy"},{"line_number":17,"context_line":"import netaddr"},{"line_number":18,"context_line":"from oslo_db import exception as db_exc"},{"line_number":19,"context_line":"from oslo_log import log as logging"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_c7757c64","line":16,"in_reply_to":"9a061dce_021f6708","updated":"2016-04-07 13:28:30.000000000","message":"fixed in PS5","commit_id":"6865086c7ed617d40ca7d14e3630a3bbe9481588"}]}