)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f6a0592e4380b5c44e64601fa33751f6f5934407","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Hong Hui Xiao \u003cxiaohhui@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-02-03 20:46:18 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Funcional test for address scope"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add some functional test for address scope"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bae84128_2b04a9be","line":7,"updated":"2016-02-19 19:21:51.000000000","message":"nit: Functional","commit_id":"407f4d4283838a4e0e1c7602793ce945569e18e6"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"c7e04c70ccc7cfc1a3abe6c0b9e72fc20d9743d4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Hong Hui Xiao \u003cxiaohhui@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-02-03 20:46:18 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Funcional test for address scope"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add some functional test for address scope"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bae84128_7fabe8d6","line":7,"in_reply_to":"bae84128_2b04a9be","updated":"2016-02-21 02:02:37.000000000","message":"thx and done","commit_id":"407f4d4283838a4e0e1c7602793ce945569e18e6"}],"neutron/tests/functional/agent/l3/test_legacy_router.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"b7101afe3ac79d333caf5fafe5800ed78c389af9","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        self.addCleanup(netcat.stop_processes)"},{"line_number":229,"context_line":"        self.assertTrue(netcat.test_connectivity())"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    def _test_connection_address_scope(self, same_address_scope):"},{"line_number":232,"context_line":"        router_info \u003d self.generate_router_info(enable_ha\u003dFalse,"},{"line_number":233,"context_line":"                                                num_internal_ports\u003d2)"},{"line_number":234,"context_line":"        address_scope1 \u003d {l3_constants.IP_VERSION_4: \u0027scope1\u0027}"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_7fda6aeb","line":231,"range":{"start_line":231,"start_character":45,"end_line":231,"end_character":63},"updated":"2016-01-26 11:45:43.000000000","message":"Instead of passing a boolean here -- which can be slightly difficult from a code readability standpoint -- how about we just leave it to the caller to create address_scopes1/2 and pass them as parameters.  Then, the caller who wants the two to be the same just passes in the same one twice.","commit_id":"14d9bb9189763c67c3b8e4a21d15afe8cacda0b7"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"80c3e72ce2cd7b9006f281b558a902836294f966","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        self.addCleanup(netcat.stop_processes)"},{"line_number":229,"context_line":"        self.assertTrue(netcat.test_connectivity())"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    def _test_connection_address_scope(self, same_address_scope):"},{"line_number":232,"context_line":"        router_info \u003d self.generate_router_info(enable_ha\u003dFalse,"},{"line_number":233,"context_line":"                                                num_internal_ports\u003d2)"},{"line_number":234,"context_line":"        address_scope1 \u003d {l3_constants.IP_VERSION_4: \u0027scope1\u0027}"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_566c349c","line":231,"range":{"start_line":231,"start_character":45,"end_line":231,"end_character":63},"in_reply_to":"9a68dd71_7fda6aeb","updated":"2016-02-03 08:46:02.000000000","message":"Done","commit_id":"14d9bb9189763c67c3b8e4a21d15afe8cacda0b7"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"b7101afe3ac79d333caf5fafe5800ed78c389af9","unresolved":false,"context_lines":[{"line_number":260,"context_line":"                br_int,"},{"line_number":261,"context_line":"                net_helpers.increment_ip_cidr(router_ip_cidr2),"},{"line_number":262,"context_line":"                router_ip2))"},{"line_number":263,"context_line":"        if same_address_scope:"},{"line_number":264,"context_line":"            src_machine.assert_ping(dst_machine.ip)"},{"line_number":265,"context_line":"            dst_machine.assert_ping(src_machine.ip)"},{"line_number":266,"context_line":"        else:"},{"line_number":267,"context_line":"            src_machine.assert_no_ping(dst_machine.ip)"},{"line_number":268,"context_line":"            dst_machine.assert_no_ping(src_machine.ip)"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    def test_connection_from_same_address_scope(self):"},{"line_number":271,"context_line":"        self._test_connection_address_scope(True)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_ff109aad","line":268,"range":{"start_line":263,"start_character":8,"end_line":268,"end_character":54},"updated":"2016-01-26 11:45:43.000000000","message":"nit:  This code probably should just move out to the caller.","commit_id":"14d9bb9189763c67c3b8e4a21d15afe8cacda0b7"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"80c3e72ce2cd7b9006f281b558a902836294f966","unresolved":false,"context_lines":[{"line_number":260,"context_line":"                br_int,"},{"line_number":261,"context_line":"                net_helpers.increment_ip_cidr(router_ip_cidr2),"},{"line_number":262,"context_line":"                router_ip2))"},{"line_number":263,"context_line":"        if same_address_scope:"},{"line_number":264,"context_line":"            src_machine.assert_ping(dst_machine.ip)"},{"line_number":265,"context_line":"            dst_machine.assert_ping(src_machine.ip)"},{"line_number":266,"context_line":"        else:"},{"line_number":267,"context_line":"            src_machine.assert_no_ping(dst_machine.ip)"},{"line_number":268,"context_line":"            dst_machine.assert_no_ping(src_machine.ip)"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    def test_connection_from_same_address_scope(self):"},{"line_number":271,"context_line":"        self._test_connection_address_scope(True)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_16055cc1","line":268,"range":{"start_line":263,"start_character":8,"end_line":268,"end_character":54},"in_reply_to":"9a68dd71_ff109aad","updated":"2016-02-03 08:46:02.000000000","message":"Done","commit_id":"14d9bb9189763c67c3b8e4a21d15afe8cacda0b7"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"b7101afe3ac79d333caf5fafe5800ed78c389af9","unresolved":false,"context_lines":[{"line_number":268,"context_line":"            dst_machine.assert_no_ping(src_machine.ip)"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    def test_connection_from_same_address_scope(self):"},{"line_number":271,"context_line":"        self._test_connection_address_scope(True)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    def test_connection_from_diff_address_scope(self):"},{"line_number":274,"context_line":"        self._test_connection_address_scope(False)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_ffec1a94","line":271,"range":{"start_line":271,"start_character":44,"end_line":271,"end_character":48},"updated":"2016-01-26 11:45:43.000000000","message":"nit: Passing a boolean here makes this code just a little harder to read that needs to be because it forces the reader to go look at the method declaration to even guess at what the param value means.","commit_id":"14d9bb9189763c67c3b8e4a21d15afe8cacda0b7"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"80c3e72ce2cd7b9006f281b558a902836294f966","unresolved":false,"context_lines":[{"line_number":268,"context_line":"            dst_machine.assert_no_ping(src_machine.ip)"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    def test_connection_from_same_address_scope(self):"},{"line_number":271,"context_line":"        self._test_connection_address_scope(True)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    def test_connection_from_diff_address_scope(self):"},{"line_number":274,"context_line":"        self._test_connection_address_scope(False)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_360ad8d3","line":271,"range":{"start_line":271,"start_character":44,"end_line":271,"end_character":48},"in_reply_to":"9a68dd71_ffec1a94","updated":"2016-02-03 08:46:02.000000000","message":"Done","commit_id":"14d9bb9189763c67c3b8e4a21d15afe8cacda0b7"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"285cc32b501b7195a6735e213de66d0e4efe1585","unresolved":false,"context_lines":[{"line_number":293,"context_line":"        router_ip_diff_scope \u003d router_ip_cidr_diff_scope.partition(\u0027/\u0027)[0]"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        br_int \u003d framework.get_ovs_bridge("},{"line_number":296,"context_line":"            self.agent.conf.ovs_integration_bridge)"},{"line_number":297,"context_line":"        src_machine, machine_same_scope \u003d self.useFixture("},{"line_number":298,"context_line":"            machine_fixtures.PeerMachines("},{"line_number":299,"context_line":"                br_int,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_ebf2256f","line":296,"range":{"start_line":296,"start_character":12,"end_line":296,"end_character":16},"updated":"2016-02-03 00:38:00.000000000","message":"can\u0027t you just write a helper function till this to avoid repeatable code in both functions _test_connection_address_scope and test_fip_connection_for_address_scope ? It is fine this way as well. I\u0027ll reverse my vote if others said this is ok","commit_id":"df5bdbe4bf6a1fa32e44f679269d7d3fcc6d1db7"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"26a1f80fae2b63b596f0d72e8ca6e2eb96c1129c","unresolved":false,"context_lines":[{"line_number":293,"context_line":"        router_ip_diff_scope \u003d router_ip_cidr_diff_scope.partition(\u0027/\u0027)[0]"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        br_int \u003d framework.get_ovs_bridge("},{"line_number":296,"context_line":"            self.agent.conf.ovs_integration_bridge)"},{"line_number":297,"context_line":"        src_machine, machine_same_scope \u003d self.useFixture("},{"line_number":298,"context_line":"            machine_fixtures.PeerMachines("},{"line_number":299,"context_line":"                br_int,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_76aa9072","line":296,"range":{"start_line":296,"start_character":12,"end_line":296,"end_character":16},"in_reply_to":"5a5ae5dd_ebf2256f","updated":"2016-02-03 08:52:29.000000000","message":"Thanks for the comment, it is done in the latest version.","commit_id":"df5bdbe4bf6a1fa32e44f679269d7d3fcc6d1db7"}]}