)]}'
{"neutron/db/l3_agentschedulers_db.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"94d2f885966d8a15abb99a1154ce2ac672fc3ac1","unresolved":false,"context_lines":[{"line_number":453,"context_line":"                    active, l3_agent)]"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"    def check_dvr_serviceable_ports_on_host("},{"line_number":456,"context_line":"            self, context, host, subnet_ids, except_port\u003dNone):"},{"line_number":457,"context_line":"        \"\"\"Check for existence of dvr serviceable ports on host"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        :param context: request context"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_1afcad3d","side":"PARENT","line":456,"range":{"start_line":456,"start_character":45,"end_line":456,"end_character":61},"updated":"2016-01-27 11:16:15.000000000","message":"I\u0027m glad you\u0027re removing this.  I felt a bit funny about it when it first went in.","commit_id":"562b67392fce0deaae825144088552e4ef97f19f"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"78abb62025ac7cfef374713bc7e7c8901d0ae0fb","unresolved":false,"context_lines":[{"line_number":453,"context_line":"                    active, l3_agent)]"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"    def check_dvr_serviceable_ports_on_host("},{"line_number":456,"context_line":"            self, context, host, subnet_ids, except_port\u003dNone):"},{"line_number":457,"context_line":"        \"\"\"Check for existence of dvr serviceable ports on host"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        :param context: request context"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_37e5f7a7","side":"PARENT","line":456,"range":{"start_line":456,"start_character":45,"end_line":456,"end_character":61},"in_reply_to":"7a5de9d1_1afcad3d","updated":"2016-01-27 13:59:51.000000000","message":"yeah, it came from another method which I combined into this one to remove duplication https://review.openstack.org/#/c/255374","commit_id":"562b67392fce0deaae825144088552e4ef97f19f"}],"neutron/db/l3_dvrscheduler_db.py":[{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"6663470d642c23a83f6a41551459f410bcaefdf6","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        router_ids \u003d self.get_dvr_routers_by_subnet_ids(admin_context,"},{"line_number":173,"context_line":"                                                        subnet_ids)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        if not router_ids:"},{"line_number":176,"context_line":"            LOG.debug(\u0027No DVR routers for this DVR port %(port)s \u0027"},{"line_number":177,"context_line":"                      \u0027on host %(host)s\u0027, {\u0027port\u0027: deleted_port[\u0027id\u0027],"},{"line_number":178,"context_line":"                                           \u0027host\u0027: port_host})"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_cd570225","line":175,"range":{"start_line":175,"start_character":25,"end_line":175,"end_character":26},"updated":"2016-01-27 06:32:17.000000000","message":"At this point, you are not sure if the deleted port was a \u0027dvr service port\u0027 or not.\nSince the logic has changed in the ml2 plugin.","commit_id":"9f733813c2fd2ba84d37173a68ff7f9b873b125c"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"886aeeb7714bd5a6886df63ff8b1e2dc0fc1f3a8","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        router_ids \u003d self.get_dvr_routers_by_subnet_ids(admin_context,"},{"line_number":173,"context_line":"                                                        subnet_ids)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        if not router_ids:"},{"line_number":176,"context_line":"            LOG.debug(\u0027No DVR routers for this DVR port %(port)s \u0027"},{"line_number":177,"context_line":"                      \u0027on host %(host)s\u0027, {\u0027port\u0027: deleted_port[\u0027id\u0027],"},{"line_number":178,"context_line":"                                           \u0027host\u0027: port_host})"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_953fcc24","line":175,"range":{"start_line":175,"start_character":25,"end_line":175,"end_character":26},"in_reply_to":"9a68dd71_cd570225","updated":"2016-01-27 09:02:56.000000000","message":"right, that should be checked here, thanks","commit_id":"9f733813c2fd2ba84d37173a68ff7f9b873b125c"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"dd3c6fada975e203a0e9a05b1532ad575f20f6bb","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            context, router_ids, port_host)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def get_dvr_routers_by_subnet_ids(self, context, subnet_ids):"},{"line_number":134,"context_line":"        \"\"\"Gets the dvr routers on vmport subnets.\"\"\""},{"line_number":135,"context_line":"        if not subnet_ids:"},{"line_number":136,"context_line":"            return set()"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a5de9d1_c3f33b09","line":134,"updated":"2016-01-28 17:40:35.000000000","message":"This docstring need be updated.","commit_id":"b32888498573c54d8ead104cb11a9a4f9ca912ae"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"c662010375fa8402d8244f366c9bc128f338aa8c","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            context, router_ids, port_host)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def get_dvr_routers_by_subnet_ids(self, context, subnet_ids):"},{"line_number":134,"context_line":"        \"\"\"Gets the dvr routers on vmport subnets.\"\"\""},{"line_number":135,"context_line":"        if not subnet_ids:"},{"line_number":136,"context_line":"            return set()"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a5de9d1_57a62554","line":134,"in_reply_to":"7a5de9d1_c3f33b09","updated":"2016-01-28 18:48:36.000000000","message":"Done","commit_id":"b32888498573c54d8ead104cb11a9a4f9ca912ae"}]}
