)]}'
{"neutron/db/l3_dvr_db.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"d40ef6e92287e95feb01e3905e760a7cb94a3920","unresolved":false,"context_lines":[{"line_number":675,"context_line":"                   \u0027device_owner\u0027: [l3_const.DEVICE_OWNER_DVR_INTERFACE]}"},{"line_number":676,"context_line":"        router_id \u003d None"},{"line_number":677,"context_line":"        ports \u003d self._core_plugin.get_ports(context, filters\u003dfilters)"},{"line_number":678,"context_line":"        for port in ports:"},{"line_number":679,"context_line":"            router_id \u003d port[\u0027device_id\u0027]"},{"line_number":680,"context_line":"            break"},{"line_number":681,"context_line":"        arp_table \u003d {\u0027ip_address\u0027: ip_address,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_00f733d4","line":678,"updated":"2016-01-28 01:48:28.000000000","message":"You can\u0027t have two DVR routers connected to the same subnet? (I see that the old code also made this assumption).","commit_id":"a9ef61483ee6b55d49af30b59d427e16ead10971"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"d40ef6e92287e95feb01e3905e760a7cb94a3920","unresolved":false,"context_lines":[{"line_number":677,"context_line":"        ports \u003d self._core_plugin.get_ports(context, filters\u003dfilters)"},{"line_number":678,"context_line":"        for port in ports:"},{"line_number":679,"context_line":"            router_id \u003d port[\u0027device_id\u0027]"},{"line_number":680,"context_line":"            break"},{"line_number":681,"context_line":"        arp_table \u003d {\u0027ip_address\u0027: ip_address,"},{"line_number":682,"context_line":"                     \u0027mac_address\u0027: mac_address,"},{"line_number":683,"context_line":"                     \u0027subnet_id\u0027: subnet}"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_a09f3f5e","line":680,"updated":"2016-01-28 01:48:28.000000000","message":"This could be changed to:\n\n  router_id \u003d next(port[\u0027device_id\u0027] for port in ports, None)\n\nOr:\n\nif ports:\n  router_id \u003d ports[0][\u0027device_id\u0027]","commit_id":"a9ef61483ee6b55d49af30b59d427e16ead10971"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"3b9baa3247558d7e72e228971cc79f1b697cb856","unresolved":false,"context_lines":[{"line_number":677,"context_line":"        ports \u003d self._core_plugin.get_ports(context, filters\u003dfilters)"},{"line_number":678,"context_line":"        for port in ports:"},{"line_number":679,"context_line":"            router_id \u003d port[\u0027device_id\u0027]"},{"line_number":680,"context_line":"            break"},{"line_number":681,"context_line":"        arp_table \u003d {\u0027ip_address\u0027: ip_address,"},{"line_number":682,"context_line":"                     \u0027mac_address\u0027: mac_address,"},{"line_number":683,"context_line":"                     \u0027subnet_id\u0027: subnet}"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_11c9a078","line":680,"in_reply_to":"7a5de9d1_a09f3f5e","updated":"2016-01-28 17:13:29.000000000","message":"will fix it.\nMakes sense.","commit_id":"a9ef61483ee6b55d49af30b59d427e16ead10971"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"d40ef6e92287e95feb01e3905e760a7cb94a3920","unresolved":false,"context_lines":[{"line_number":678,"context_line":"        for port in ports:"},{"line_number":679,"context_line":"            router_id \u003d port[\u0027device_id\u0027]"},{"line_number":680,"context_line":"            break"},{"line_number":681,"context_line":"        arp_table \u003d {\u0027ip_address\u0027: ip_address,"},{"line_number":682,"context_line":"                     \u0027mac_address\u0027: mac_address,"},{"line_number":683,"context_line":"                     \u0027subnet_id\u0027: subnet}"},{"line_number":684,"context_line":"        if router_id is not None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_40876b0f","line":681,"updated":"2016-01-28 01:48:28.000000000","message":"I\u0027d probably short circuit and insert:\n\nif not router_id:\n  return","commit_id":"a9ef61483ee6b55d49af30b59d427e16ead10971"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"3b9baa3247558d7e72e228971cc79f1b697cb856","unresolved":false,"context_lines":[{"line_number":678,"context_line":"        for port in ports:"},{"line_number":679,"context_line":"            router_id \u003d port[\u0027device_id\u0027]"},{"line_number":680,"context_line":"            break"},{"line_number":681,"context_line":"        arp_table \u003d {\u0027ip_address\u0027: ip_address,"},{"line_number":682,"context_line":"                     \u0027mac_address\u0027: mac_address,"},{"line_number":683,"context_line":"                     \u0027subnet_id\u0027: subnet}"},{"line_number":684,"context_line":"        if router_id is not None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_b1ae8c96","line":681,"in_reply_to":"7a5de9d1_40876b0f","updated":"2016-01-28 17:13:29.000000000","message":"will fix it.","commit_id":"a9ef61483ee6b55d49af30b59d427e16ead10971"}],"neutron/tests/unit/db/test_l3_dvr_db.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"d40ef6e92287e95feb01e3905e760a7cb94a3920","unresolved":false,"context_lines":[{"line_number":532,"context_line":"        router_dict \u003d {\u0027name\u0027: \u0027test_router\u0027, \u0027admin_state_up\u0027: True,"},{"line_number":533,"context_line":"                       \u0027distributed\u0027: True}"},{"line_number":534,"context_line":"        router \u003d self._create_router(router_dict)"},{"line_number":535,"context_line":"        with mock.patch.object(manager.NeutronManager, \u0027get_plugin\u0027) as gp,\\"},{"line_number":536,"context_line":"                mock.patch.object(self.mixin, \u0027_get_router\u0027) as grtr:"},{"line_number":537,"context_line":"            plugin \u003d mock.Mock()"},{"line_number":538,"context_line":"            l3_notify \u003d self.mixin.l3_rpc_notifier \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_80bfa3cf","line":535,"updated":"2016-01-28 01:48:28.000000000","message":"It doesn\u0027t really matter but IMO you can remove this mock and the assertions on lines 562 and 567. You don\u0027t have to test that get_router isn\u0027t called, you just have to make sure the updated method\u0027s test still makes sense. Since you changed an internal implementation detail, the test still makes sense, and theoretically a good test wouldn\u0027t need to be updated at all. The method still accepts the same parameters with the same output.","commit_id":"a9ef61483ee6b55d49af30b59d427e16ead10971"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"3b9baa3247558d7e72e228971cc79f1b697cb856","unresolved":false,"context_lines":[{"line_number":532,"context_line":"        router_dict \u003d {\u0027name\u0027: \u0027test_router\u0027, \u0027admin_state_up\u0027: True,"},{"line_number":533,"context_line":"                       \u0027distributed\u0027: True}"},{"line_number":534,"context_line":"        router \u003d self._create_router(router_dict)"},{"line_number":535,"context_line":"        with mock.patch.object(manager.NeutronManager, \u0027get_plugin\u0027) as gp,\\"},{"line_number":536,"context_line":"                mock.patch.object(self.mixin, \u0027_get_router\u0027) as grtr:"},{"line_number":537,"context_line":"            plugin \u003d mock.Mock()"},{"line_number":538,"context_line":"            l3_notify \u003d self.mixin.l3_rpc_notifier \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_319b7c74","line":535,"in_reply_to":"7a5de9d1_80bfa3cf","updated":"2016-01-28 17:13:29.000000000","message":"will remove the check.","commit_id":"a9ef61483ee6b55d49af30b59d427e16ead10971"}]}
