)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"f8ee6780f194338f9d258923ffcc021b0d0b95f1","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"For example, if this configuration is set to \u0027/tmp\u0027."},{"line_number":13,"context_line":"The code checks dir \u0027/tmp\u0027 if exists. This is wrong."},{"line_number":14,"context_line":"The right way is to check \u0027/tmp + [network_id]\u0027 is exists."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I0e060ca7c84f38bb0ccd55ac16da5446a3d015c5"},{"line_number":17,"context_line":"Closes-Bug: #1538386"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7a5de9d1_84c3bb88","line":14,"updated":"2016-01-30 11:55:21.000000000","message":"s/is exists/existence/","commit_id":"d5088df1a17364fc170af8d376c858cf1e470faa"},{"author":{"_account_id":11347,"name":"Rui Zang","email":"rui.zang@yandex.com","username":"rzang"},"change_message_id":"d9506eea7f43db46a31b4b1bcf9e9191b4210f75","unresolved":false,"context_lines":[{"line_number":10,"context_line":"named \u0027dnsmasq_base_log_dir\u0027."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"For example, if this configuration is set to \u0027/tmp\u0027."},{"line_number":13,"context_line":"The code checks dir \u0027/tmp\u0027 if exists. This is wrong."},{"line_number":14,"context_line":"The right way is to check \u0027/tmp + [network_id]\u0027 existence."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I0e060ca7c84f38bb0ccd55ac16da5446a3d015c5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"5a5ae5dd_b6970447","line":13,"updated":"2016-02-06 02:24:10.000000000","message":"Nit: the code checks whether dir \u0027/tmp\u0027 exists.","commit_id":"8ae32a6681ad9187e1394b9c633a6eb43df40342"},{"author":{"_account_id":11347,"name":"Rui Zang","email":"rui.zang@yandex.com","username":"rzang"},"change_message_id":"d9506eea7f43db46a31b4b1bcf9e9191b4210f75","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"For example, if this configuration is set to \u0027/tmp\u0027."},{"line_number":13,"context_line":"The code checks dir \u0027/tmp\u0027 if exists. This is wrong."},{"line_number":14,"context_line":"The right way is to check \u0027/tmp + [network_id]\u0027 existence."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I0e060ca7c84f38bb0ccd55ac16da5446a3d015c5"},{"line_number":17,"context_line":"Closes-Bug: #1538386"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"5a5ae5dd_f67fbc14","line":14,"updated":"2016-02-06 02:24:10.000000000","message":"Nit: ... is to check the existence of \u0027/tmp\u0027 + ...\n\nAnyway, the commit message wording needs some polishing","commit_id":"8ae32a6681ad9187e1394b9c633a6eb43df40342"}],"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"ce6095cecc7c1b724b321711aae0abcb6c85856c","unresolved":false,"context_lines":[{"line_number":402,"context_line":"                    self.network.id)"},{"line_number":403,"context_line":"                if not os.path.exists(log_dir):"},{"line_number":404,"context_line":"                    os.makedirs(log_dir)"},{"line_number":405,"context_line":"                log_filename \u003d os.path.join("},{"line_number":406,"context_line":"                    self.conf.dnsmasq_base_log_dir,"},{"line_number":407,"context_line":"                    self.network.id, \u0027dhcp_dns_log\u0027)"},{"line_number":408,"context_line":"                cmd.append(\u0027--log-queries\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_f48f33ca","line":405,"updated":"2016-01-27 04:06:55.000000000","message":"this could be\n\nlog_filename \u003d os.path.join(\n       log_dir, \u0027dhcp_dns_log\u0027)\n\nto save some code duplicate","commit_id":"1c4a795bfe41378cd21f1351ee6d6a6f3bbcbd69"},{"author":{"_account_id":14562,"name":"Zhi Chang","email":"changzhi2@lenovo.com","username":"changzhi"},"change_message_id":"d8d8019911771ed7f64554df75e045b9b753a947","unresolved":false,"context_lines":[{"line_number":402,"context_line":"                    self.network.id)"},{"line_number":403,"context_line":"                if not os.path.exists(log_dir):"},{"line_number":404,"context_line":"                    os.makedirs(log_dir)"},{"line_number":405,"context_line":"                log_filename \u003d os.path.join("},{"line_number":406,"context_line":"                    self.conf.dnsmasq_base_log_dir,"},{"line_number":407,"context_line":"                    self.network.id, \u0027dhcp_dns_log\u0027)"},{"line_number":408,"context_line":"                cmd.append(\u0027--log-queries\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_977359b4","line":405,"in_reply_to":"9a68dd71_f48f33ca","updated":"2016-01-27 04:17:09.000000000","message":"agree","commit_id":"1c4a795bfe41378cd21f1351ee6d6a6f3bbcbd69"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"ce6095cecc7c1b724b321711aae0abcb6c85856c","unresolved":false,"context_lines":[{"line_number":410,"context_line":"                cmd.append(\u0027--log-facility\u003d%s\u0027 % log_filename)"},{"line_number":411,"context_line":"            except OSError:"},{"line_number":412,"context_line":"                LOG.error(_LE(\u0027Error while create dnsmasq base log dir: %s\u0027),"},{"line_number":413,"context_line":"                    self.conf.dnsmasq_base_log_dir)"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"        return cmd"},{"line_number":416,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_b44e9b94","line":413,"range":{"start_line":413,"start_character":20,"end_line":413,"end_character":50},"updated":"2016-01-27 04:06:55.000000000","message":"this might need to be changed to log_dir to suit the log.","commit_id":"1c4a795bfe41378cd21f1351ee6d6a6f3bbcbd69"},{"author":{"_account_id":14562,"name":"Zhi Chang","email":"changzhi2@lenovo.com","username":"changzhi"},"change_message_id":"d8d8019911771ed7f64554df75e045b9b753a947","unresolved":false,"context_lines":[{"line_number":410,"context_line":"                cmd.append(\u0027--log-facility\u003d%s\u0027 % log_filename)"},{"line_number":411,"context_line":"            except OSError:"},{"line_number":412,"context_line":"                LOG.error(_LE(\u0027Error while create dnsmasq base log dir: %s\u0027),"},{"line_number":413,"context_line":"                    self.conf.dnsmasq_base_log_dir)"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"        return cmd"},{"line_number":416,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_b778dd90","line":413,"range":{"start_line":413,"start_character":20,"end_line":413,"end_character":50},"in_reply_to":"9a68dd71_b44e9b94","updated":"2016-01-27 04:17:09.000000000","message":"ok","commit_id":"1c4a795bfe41378cd21f1351ee6d6a6f3bbcbd69"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f3ea274bfc7ef3d5a32f4307e17050d0b0b0a354","unresolved":false,"context_lines":[{"line_number":397,"context_line":""},{"line_number":398,"context_line":"        if self.conf.dnsmasq_base_log_dir:"},{"line_number":399,"context_line":"            try:"},{"line_number":400,"context_line":"                log_dir \u003d os.path.join("},{"line_number":401,"context_line":"                    self.conf.dnsmasq_base_log_dir,"},{"line_number":402,"context_line":"                    self.network.id)"},{"line_number":403,"context_line":"                if not os.path.exists(log_dir):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_b22f8bf5","line":400,"updated":"2016-01-27 05:36:41.000000000","message":"sorry for nit piking but lines 400-402 need not be in the try","commit_id":"1669d1db0c7bea9da993c892d05ed2dc215ea0d7"},{"author":{"_account_id":14562,"name":"Zhi Chang","email":"changzhi2@lenovo.com","username":"changzhi"},"change_message_id":"da6650257c3228f232697cbd464f32df26ff17f3","unresolved":false,"context_lines":[{"line_number":397,"context_line":""},{"line_number":398,"context_line":"        if self.conf.dnsmasq_base_log_dir:"},{"line_number":399,"context_line":"            try:"},{"line_number":400,"context_line":"                log_dir \u003d os.path.join("},{"line_number":401,"context_line":"                    self.conf.dnsmasq_base_log_dir,"},{"line_number":402,"context_line":"                    self.network.id)"},{"line_number":403,"context_line":"                if not os.path.exists(log_dir):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_4df23208","line":400,"in_reply_to":"9a68dd71_b22f8bf5","updated":"2016-01-27 05:58:52.000000000","message":"ok","commit_id":"1669d1db0c7bea9da993c892d05ed2dc215ea0d7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"bbbbf123130859818e9f17354dbf251ed5a7ba7a","unresolved":false,"context_lines":[{"line_number":402,"context_line":"            try:"},{"line_number":403,"context_line":"                if not os.path.exists(log_dir):"},{"line_number":404,"context_line":"                    os.makedirs(log_dir)"},{"line_number":405,"context_line":"                log_filename \u003d os.path.join("},{"line_number":406,"context_line":"                    log_dir, \u0027dhcp_dns_log\u0027)"},{"line_number":407,"context_line":"                cmd.append(\u0027--log-queries\u0027)"},{"line_number":408,"context_line":"                cmd.append(\u0027--log-dhcp\u0027)"},{"line_number":409,"context_line":"                cmd.append(\u0027--log-facility\u003d%s\u0027 % log_filename)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a5de9d1_6b615c04","line":406,"range":{"start_line":405,"start_character":16,"end_line":406,"end_character":44},"updated":"2016-02-02 07:50:01.000000000","message":"This can be one-line.","commit_id":"059f4d6cc78dbb25d7e5e594bfb1cdf2321758e8"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"bbbbf123130859818e9f17354dbf251ed5a7ba7a","unresolved":false,"context_lines":[{"line_number":406,"context_line":"                    log_dir, \u0027dhcp_dns_log\u0027)"},{"line_number":407,"context_line":"                cmd.append(\u0027--log-queries\u0027)"},{"line_number":408,"context_line":"                cmd.append(\u0027--log-dhcp\u0027)"},{"line_number":409,"context_line":"                cmd.append(\u0027--log-facility\u003d%s\u0027 % log_filename)"},{"line_number":410,"context_line":"            except OSError:"},{"line_number":411,"context_line":"                LOG.error(_LE(\u0027Error while create dnsmasq log dir: %s\u0027),"},{"line_number":412,"context_line":"                    log_dir)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a5de9d1_ab42f465","line":409,"updated":"2016-02-02 07:50:01.000000000","message":"Why do you move L.405-408 into the inside of try clause?\nIt looks unnecessary to be placed here.","commit_id":"059f4d6cc78dbb25d7e5e594bfb1cdf2321758e8"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"bbbbf123130859818e9f17354dbf251ed5a7ba7a","unresolved":false,"context_lines":[{"line_number":409,"context_line":"                cmd.append(\u0027--log-facility\u003d%s\u0027 % log_filename)"},{"line_number":410,"context_line":"            except OSError:"},{"line_number":411,"context_line":"                LOG.error(_LE(\u0027Error while create dnsmasq log dir: %s\u0027),"},{"line_number":412,"context_line":"                    log_dir)"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"        return cmd"},{"line_number":415,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"7a5de9d1_0b0a288a","line":412,"updated":"2016-02-02 07:50:01.000000000","message":"wrong indent level?","commit_id":"059f4d6cc78dbb25d7e5e594bfb1cdf2321758e8"}],"neutron/tests/unit/agent/linux/test_dhcp.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"f8ee6780f194338f9d258923ffcc021b0d0b95f1","unresolved":false,"context_lines":[{"line_number":1118,"context_line":"                          \u0027--domain\u003dopenstacklocal\u0027])"},{"line_number":1119,"context_line":""},{"line_number":1120,"context_line":"    def test_spawn_cfg_enable_dnsmasq_log(self):"},{"line_number":1121,"context_line":"        self.conf.set_override(\u0027dnsmasq_base_log_dir\u0027, \u0027/dhcp\u0027)"},{"line_number":1122,"context_line":"        network \u003d FakeV4Network()"},{"line_number":1123,"context_line":"        dhcp_dns_log \u003d \\"},{"line_number":1124,"context_line":"            \u0027/dhcp/aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa/dhcp_dns_log\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_446703b7","line":1121,"range":{"start_line":1121,"start_character":57,"end_line":1121,"end_character":61},"updated":"2016-01-30 11:55:21.000000000","message":"useless change?","commit_id":"d5088df1a17364fc170af8d376c858cf1e470faa"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"f46da8d721f7f0559f70e9dc0596a84facd77682","unresolved":false,"context_lines":[{"line_number":1119,"context_line":""},{"line_number":1120,"context_line":"    def test_spawn_cfg_enable_dnsmasq_log(self):"},{"line_number":1121,"context_line":"        self.conf.set_override(\u0027dnsmasq_base_log_dir\u0027, \u0027/tmp\u0027)"},{"line_number":1122,"context_line":"        self.conf.dhcp_confs \u003d \u0027/tmp\u0027"},{"line_number":1123,"context_line":"        network \u003d FakeV4Network()"},{"line_number":1124,"context_line":"        dhcp_dns_log \u003d \\"},{"line_number":1125,"context_line":"            \u0027/tmp/aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa/dhcp_dns_log\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a5de9d1_1a2de6a7","line":1122,"range":{"start_line":1122,"start_character":8,"end_line":1122,"end_character":37},"updated":"2016-01-30 16:47:25.000000000","message":"Is this related to the issue?","commit_id":"71163816ea9be9d4b723837aac6ef2e79c9ae4ed"},{"author":{"_account_id":14562,"name":"Zhi Chang","email":"changzhi2@lenovo.com","username":"changzhi"},"change_message_id":"b68121a8cf7ec29b5ab48d25a344f3692c552c53","unresolved":false,"context_lines":[{"line_number":1119,"context_line":""},{"line_number":1120,"context_line":"    def test_spawn_cfg_enable_dnsmasq_log(self):"},{"line_number":1121,"context_line":"        self.conf.set_override(\u0027dnsmasq_base_log_dir\u0027, \u0027/tmp\u0027)"},{"line_number":1122,"context_line":"        self.conf.dhcp_confs \u003d \u0027/tmp\u0027"},{"line_number":1123,"context_line":"        network \u003d FakeV4Network()"},{"line_number":1124,"context_line":"        dhcp_dns_log \u003d \\"},{"line_number":1125,"context_line":"            \u0027/tmp/aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa/dhcp_dns_log\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a5de9d1_a85005d5","line":1122,"range":{"start_line":1122,"start_character":8,"end_line":1122,"end_character":37},"in_reply_to":"7a5de9d1_1a2de6a7","updated":"2016-01-31 02:04:12.000000000","message":"thx for your reply. It is just for this unit test more clearly","commit_id":"71163816ea9be9d4b723837aac6ef2e79c9ae4ed"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"f46da8d721f7f0559f70e9dc0596a84facd77682","unresolved":false,"context_lines":[{"line_number":1125,"context_line":"            \u0027/tmp/aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa/dhcp_dns_log\u0027"},{"line_number":1126,"context_line":""},{"line_number":1127,"context_line":"        lp \u003d LocalChild(self.conf, FakeV4Network())"},{"line_number":1128,"context_line":"        self.assertEqual(lp.get_conf_file_name(\u0027dhcp_dns_log\u0027), dhcp_dns_log)"},{"line_number":1129,"context_line":"        self._test_spawn([\u0027--conf-file\u003d\u0027,"},{"line_number":1130,"context_line":"                          \u0027--domain\u003dopenstacklocal\u0027,"},{"line_number":1131,"context_line":"                          \u0027--log-queries\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a5de9d1_5a603e01","line":1128,"range":{"start_line":1128,"start_character":8,"end_line":1128,"end_character":77},"updated":"2016-01-30 16:47:25.000000000","message":"It\u0027s better to use the pattern \"self.assertEqual(expected, observed)\".","commit_id":"71163816ea9be9d4b723837aac6ef2e79c9ae4ed"},{"author":{"_account_id":14562,"name":"Zhi Chang","email":"changzhi2@lenovo.com","username":"changzhi"},"change_message_id":"780caa7c6a3281e25431c9a8551b0d2438435c9c","unresolved":false,"context_lines":[{"line_number":1125,"context_line":"            \u0027/tmp/aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa/dhcp_dns_log\u0027"},{"line_number":1126,"context_line":""},{"line_number":1127,"context_line":"        lp \u003d LocalChild(self.conf, FakeV4Network())"},{"line_number":1128,"context_line":"        self.assertEqual(lp.get_conf_file_name(\u0027dhcp_dns_log\u0027), dhcp_dns_log)"},{"line_number":1129,"context_line":"        self._test_spawn([\u0027--conf-file\u003d\u0027,"},{"line_number":1130,"context_line":"                          \u0027--domain\u003dopenstacklocal\u0027,"},{"line_number":1131,"context_line":"                          \u0027--log-queries\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a5de9d1_a8fa3a73","line":1128,"range":{"start_line":1128,"start_character":8,"end_line":1128,"end_character":77},"in_reply_to":"7a5de9d1_1c5b9bf7","updated":"2016-02-01 02:16:57.000000000","message":"Done","commit_id":"71163816ea9be9d4b723837aac6ef2e79c9ae4ed"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"7d86d43ae8f59847cc53c683de9fb820663d3cee","unresolved":false,"context_lines":[{"line_number":1125,"context_line":"            \u0027/tmp/aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa/dhcp_dns_log\u0027"},{"line_number":1126,"context_line":""},{"line_number":1127,"context_line":"        lp \u003d LocalChild(self.conf, FakeV4Network())"},{"line_number":1128,"context_line":"        self.assertEqual(lp.get_conf_file_name(\u0027dhcp_dns_log\u0027), dhcp_dns_log)"},{"line_number":1129,"context_line":"        self._test_spawn([\u0027--conf-file\u003d\u0027,"},{"line_number":1130,"context_line":"                          \u0027--domain\u003dopenstacklocal\u0027,"},{"line_number":1131,"context_line":"                          \u0027--log-queries\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a5de9d1_1c5b9bf7","line":1128,"range":{"start_line":1128,"start_character":8,"end_line":1128,"end_character":77},"in_reply_to":"7a5de9d1_486071a5","updated":"2016-01-31 12:15:53.000000000","message":"Yes, dhcp_dns_log should be expected value.","commit_id":"71163816ea9be9d4b723837aac6ef2e79c9ae4ed"},{"author":{"_account_id":14562,"name":"Zhi Chang","email":"changzhi2@lenovo.com","username":"changzhi"},"change_message_id":"b68121a8cf7ec29b5ab48d25a344f3692c552c53","unresolved":false,"context_lines":[{"line_number":1125,"context_line":"            \u0027/tmp/aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa/dhcp_dns_log\u0027"},{"line_number":1126,"context_line":""},{"line_number":1127,"context_line":"        lp \u003d LocalChild(self.conf, FakeV4Network())"},{"line_number":1128,"context_line":"        self.assertEqual(lp.get_conf_file_name(\u0027dhcp_dns_log\u0027), dhcp_dns_log)"},{"line_number":1129,"context_line":"        self._test_spawn([\u0027--conf-file\u003d\u0027,"},{"line_number":1130,"context_line":"                          \u0027--domain\u003dopenstacklocal\u0027,"},{"line_number":1131,"context_line":"                          \u0027--log-queries\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a5de9d1_486071a5","line":1128,"range":{"start_line":1128,"start_character":8,"end_line":1128,"end_character":77},"in_reply_to":"7a5de9d1_5a603e01","updated":"2016-01-31 02:04:12.000000000","message":"Should like this?\n\n    self.assertEqual(dhcp_dns_log, lp.get_conf_file_name(\u0027dhcp_dns_log\u0027) )","commit_id":"71163816ea9be9d4b723837aac6ef2e79c9ae4ed"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"9e37ab86320a275ab0aa506f9a3c25e3ec4d5275","unresolved":false,"context_lines":[{"line_number":1119,"context_line":""},{"line_number":1120,"context_line":"    def test_spawn_cfg_enable_dnsmasq_log(self):"},{"line_number":1121,"context_line":"        self.conf.set_override(\u0027dnsmasq_base_log_dir\u0027, \u0027/tmp\u0027)"},{"line_number":1122,"context_line":"        self.conf.dhcp_confs \u003d \u0027/tmp\u0027"},{"line_number":1123,"context_line":"        network \u003d FakeV4Network()"},{"line_number":1124,"context_line":"        dhcp_dns_log \u003d \\"},{"line_number":1125,"context_line":"            \u0027/tmp/aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa/dhcp_dns_log\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_8853be38","line":1122,"updated":"2016-02-01 02:43:07.000000000","message":"This is irrelative with \"dnsmasq_base_log_dir\"","commit_id":"c40ddeaad3a6954e3d17366ac0c1f80392b5156d"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"9e37ab86320a275ab0aa506f9a3c25e3ec4d5275","unresolved":false,"context_lines":[{"line_number":1124,"context_line":"        dhcp_dns_log \u003d \\"},{"line_number":1125,"context_line":"            \u0027/tmp/aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa/dhcp_dns_log\u0027"},{"line_number":1126,"context_line":""},{"line_number":1127,"context_line":"        lp \u003d LocalChild(self.conf, FakeV4Network())"},{"line_number":1128,"context_line":"        self.assertEqual(dhcp_dns_log, lp.get_conf_file_name(\u0027dhcp_dns_log\u0027))"},{"line_number":1129,"context_line":"        self._test_spawn([\u0027--conf-file\u003d\u0027,"},{"line_number":1130,"context_line":"                          \u0027--domain\u003dopenstacklocal\u0027,"},{"line_number":1131,"context_line":"                          \u0027--log-queries\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_6856822b","line":1128,"range":{"start_line":1127,"start_character":0,"end_line":1128,"end_character":77},"updated":"2016-02-01 02:43:07.000000000","message":"This is meaningless here. get_conf_file_name is for files under \"self.conf.dhcp_confs\". But you can set \"dnsmasq_base_log_dir\" to another path. I think that is why you set \"self.conf.dhcp_confs\" equals to \"dnsmasq_base_log_dir\".\n\nTry my next comment.","commit_id":"c40ddeaad3a6954e3d17366ac0c1f80392b5156d"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"9e37ab86320a275ab0aa506f9a3c25e3ec4d5275","unresolved":false,"context_lines":[{"line_number":1131,"context_line":"                          \u0027--log-queries\u0027,"},{"line_number":1132,"context_line":"                          \u0027--log-dhcp\u0027,"},{"line_number":1133,"context_line":"                          (\u0027--log-facility\u003d%s\u0027 % dhcp_dns_log)],"},{"line_number":1134,"context_line":"                         network)"},{"line_number":1135,"context_line":""},{"line_number":1136,"context_line":"    def test_spawn_cfg_no_local_resolv(self):"},{"line_number":1137,"context_line":"        self.conf.set_override(\u0027dnsmasq_local_resolv\u0027, False)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_284c0a9d","line":1134,"updated":"2016-02-01 02:43:07.000000000","message":"Try to use the following test here.\n        self.makedirs.assert_called_with(os.path.join(\n            \u0027/tmp\u0027, network.id))","commit_id":"c40ddeaad3a6954e3d17366ac0c1f80392b5156d"},{"author":{"_account_id":14562,"name":"Zhi Chang","email":"changzhi2@lenovo.com","username":"changzhi"},"change_message_id":"7b1b6220f0c8a5231a8d97c3165e70df4c766057","unresolved":false,"context_lines":[{"line_number":1131,"context_line":"                          \u0027--log-queries\u0027,"},{"line_number":1132,"context_line":"                          \u0027--log-dhcp\u0027,"},{"line_number":1133,"context_line":"                          (\u0027--log-facility\u003d%s\u0027 % dhcp_dns_log)],"},{"line_number":1134,"context_line":"                         network)"},{"line_number":1135,"context_line":""},{"line_number":1136,"context_line":"    def test_spawn_cfg_no_local_resolv(self):"},{"line_number":1137,"context_line":"        self.conf.set_override(\u0027dnsmasq_local_resolv\u0027, False)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_c340b736","line":1134,"in_reply_to":"7a5de9d1_284c0a9d","updated":"2016-02-01 02:49:27.000000000","message":"good suggestion","commit_id":"c40ddeaad3a6954e3d17366ac0c1f80392b5156d"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"3262a688dc562d814f21b75409f59663d252039a","unresolved":false,"context_lines":[{"line_number":1123,"context_line":"        dhcp_dns_log \u003d \\"},{"line_number":1124,"context_line":"            \u0027/tmp/aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa/dhcp_dns_log\u0027"},{"line_number":1125,"context_line":""},{"line_number":1126,"context_line":"        self.makedirs.assert_called_with(os.path.join("},{"line_number":1127,"context_line":"            \u0027/tmp\u0027, network.id))"},{"line_number":1128,"context_line":"        self._test_spawn([\u0027--conf-file\u003d\u0027,"},{"line_number":1129,"context_line":"                          \u0027--domain\u003dopenstacklocal\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a5de9d1_9e56985a","line":1126,"updated":"2016-02-01 04:58:34.000000000","message":"The assert will success only after _test_spawn. That is why I added the comment after _test_spawn in last PS...","commit_id":"8d411ed625bcae1d4f66fe9209aa4063c0f3e53e"},{"author":{"_account_id":14562,"name":"Zhi Chang","email":"changzhi2@lenovo.com","username":"changzhi"},"change_message_id":"e71756d04e3c4687adc679ccfc64138e9c39164e","unresolved":false,"context_lines":[{"line_number":1123,"context_line":"        dhcp_dns_log \u003d \\"},{"line_number":1124,"context_line":"            \u0027/tmp/aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa/dhcp_dns_log\u0027"},{"line_number":1125,"context_line":""},{"line_number":1126,"context_line":"        self.makedirs.assert_called_with(os.path.join("},{"line_number":1127,"context_line":"            \u0027/tmp\u0027, network.id))"},{"line_number":1128,"context_line":"        self._test_spawn([\u0027--conf-file\u003d\u0027,"},{"line_number":1129,"context_line":"                          \u0027--domain\u003dopenstacklocal\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a5de9d1_9e0e9839","line":1126,"in_reply_to":"7a5de9d1_9e56985a","updated":"2016-02-01 05:22:02.000000000","message":"ok. thx you","commit_id":"8d411ed625bcae1d4f66fe9209aa4063c0f3e53e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"bbbbf123130859818e9f17354dbf251ed5a7ba7a","unresolved":false,"context_lines":[{"line_number":1129,"context_line":"                          \u0027--log-dhcp\u0027,"},{"line_number":1130,"context_line":"                          (\u0027--log-facility\u003d%s\u0027 % dhcp_dns_log)],"},{"line_number":1131,"context_line":"                         network)"},{"line_number":1132,"context_line":"        self.makedirs.assert_called_with(os.path.join("},{"line_number":1133,"context_line":"            \u0027/tmp\u0027, network.id))"},{"line_number":1134,"context_line":""},{"line_number":1135,"context_line":"    def test_spawn_cfg_no_local_resolv(self):"},{"line_number":1136,"context_line":"        self.conf.set_override(\u0027dnsmasq_local_resolv\u0027, False)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a5de9d1_4b7b40be","line":1133,"range":{"start_line":1132,"start_character":8,"end_line":1133,"end_character":32},"updated":"2016-02-02 07:50:01.000000000","message":"This can be one-line.","commit_id":"059f4d6cc78dbb25d7e5e594bfb1cdf2321758e8"}]}