)]}'
{"neutron/plugins/ml2/drivers/l2pop/rpc_manager/l2population_rpc.py":[{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"33e7db2d52fb3324be3fbba55a7e72c458973047","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                        \u0027before\u0027: [ [\u003cmac\u003e, \u003cip\u003e], ... ],"},{"line_number":71,"context_line":"                        \u0027after\u0027 : [ [\u003cmac\u003e, \u003cip\u003e], ... ],"},{"line_number":72,"context_line":"                    },"},{"line_number":73,"context_line":"                    \u0027\u003cagent2-IP\u003e\u0027: {"},{"line_number":74,"context_line":"                        \u0027before\u0027: ..."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        :returns: Deep copy with [\u003cmac\u003e, \u003cip\u003e] converted to PortInfo"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a5de9d1_94f2e904","line":73,"updated":"2016-02-01 12:16:42.000000000","message":"only one agent_ip in \u0027chg_ip\u0027 structure.","commit_id":"8dcf39aae7a099e01bd322891526c134e87e6b1b"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"33e7db2d52fb3324be3fbba55a7e72c458973047","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        :returns: Deep copy with [\u003cmac\u003e, \u003cip\u003e] converted to PortInfo"},{"line_number":77,"context_line":"        \"\"\""},{"line_number":78,"context_line":"        unmarshalled \u003d dict(fdb_entries)"},{"line_number":79,"context_line":"        chg_ip_nets \u003d [net.values()"},{"line_number":80,"context_line":"                       for net in unmarshalled.get(\u0027chg_ip\u0027, {}).values()]"},{"line_number":81,"context_line":"        for agent in itertools.chain.from_iterable(chg_ip_nets):"},{"line_number":82,"context_line":"            for when in (\u0027before\u0027, \u0027after\u0027):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a5de9d1_d9a41cbb","line":79,"updated":"2016-02-01 12:16:42.000000000","message":"There will be only(and always) one network_id in chg_ip and also only one(and always) agent_ip inside network_id. Please see [1]. So no need to iterate for multiple networks and multiple agents.\n\n   \n[1] https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/l2pop/mech_driver.py#L88","commit_id":"8dcf39aae7a099e01bd322891526c134e87e6b1b"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"5934ace43927e0c98b0e3374f2a611594ef302fc","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        :returns: Deep copy with [\u003cmac\u003e, \u003cip\u003e] converted to PortInfo"},{"line_number":77,"context_line":"        \"\"\""},{"line_number":78,"context_line":"        unmarshalled \u003d dict(fdb_entries)"},{"line_number":79,"context_line":"        chg_ip_nets \u003d [net.values()"},{"line_number":80,"context_line":"                       for net in unmarshalled.get(\u0027chg_ip\u0027, {}).values()]"},{"line_number":81,"context_line":"        for agent in itertools.chain.from_iterable(chg_ip_nets):"},{"line_number":82,"context_line":"            for when in (\u0027before\u0027, \u0027after\u0027):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a5de9d1_ddcf0854","line":79,"in_reply_to":"7a5de9d1_d9a41cbb","updated":"2016-02-01 22:27:05.000000000","message":"This is making assumptions about the caller. We don\u0027t want to break if something else wants to use l2pop for updating info.","commit_id":"8dcf39aae7a099e01bd322891526c134e87e6b1b"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"823f60c77bded1d8b9c6f5cd20c3d29dd3b48a4f","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        chg_ip_nets \u003d [net.values()"},{"line_number":80,"context_line":"                       for net in unmarshalled.get(\u0027chg_ip\u0027, {}).values()]"},{"line_number":81,"context_line":"        for agent in itertools.chain.from_iterable(chg_ip_nets):"},{"line_number":82,"context_line":"            for when in (\u0027before\u0027, \u0027after\u0027):"},{"line_number":83,"context_line":"                if when in agent:"},{"line_number":84,"context_line":"                    agent[when] \u003d [l2pop_rpc.PortInfo(*pi)"},{"line_number":85,"context_line":"                                   for pi in agent[when]]"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_95f623d6","line":82,"range":{"start_line":82,"start_character":12,"end_line":82,"end_character":43},"updated":"2016-02-09 22:06:58.000000000","message":"Is this taking avoiding code duplication too far?  ;)","commit_id":"8dcf39aae7a099e01bd322891526c134e87e6b1b"}],"neutron/tests/unit/plugins/ml2/drivers/l2pop/test_mech_driver.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8b670ea3feb3b59194214c56d47378c67c4ec91e","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        self.assertEqual((\u0027fa:16:3e:ff:8c:0f\u0027, \u002710.0.0.6\u0027), agt1[\u0027before\u0027][0])"},{"line_number":148,"context_line":"        self.assertEqual((\u0027fa:16:3e:ff:8c:0f\u0027, \u002710.0.0.7\u0027), agt1[\u0027after\u0027][0])"},{"line_number":149,"context_line":"        agt2 \u003d entries[\u0027foouuid\u0027][\u0027192.168.0.2\u0027]"},{"line_number":150,"context_line":"        self.assertIsInstance(agt2[\u0027before\u0027][0], l2pop_rpc.PortInfo)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def test__marshall_fdb_entries(self):"},{"line_number":153,"context_line":"        entries \u003d {\u0027foouuid\u0027: {"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_94485b5d","line":150,"updated":"2016-01-27 17:09:03.000000000","message":"missing assert for mac, 10.0.0.8 here, I can add it","commit_id":"75323e69093b7755f7e9ee9b4dedaa3473d135a8"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"33e7db2d52fb3324be3fbba55a7e72c458973047","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            \u0027ports\u0027: {\u0027192.168.0.10\u0027: [[\u002700:00:00:00:00:00\u0027, \u00270.0.0.0\u0027],"},{"line_number":129,"context_line":"                                       [\u0027fa:16:3e:ff:8c:0f\u0027, \u002710.0.0.6\u0027]]},"},{"line_number":130,"context_line":"            \u0027network_type\u0027: \u0027vxlan\u0027}}"},{"line_number":131,"context_line":"        entries[\u0027chg_ip\u0027] \u003d {"},{"line_number":132,"context_line":"            \u0027foouuid\u0027: {"},{"line_number":133,"context_line":"                \u0027192.168.0.1\u0027: {\u0027before\u0027: [[\u0027fa:16:3e:ff:8c:0f\u0027, \u002710.0.0.6\u0027]],"},{"line_number":134,"context_line":"                                \u0027after\u0027: [[\u0027fa:16:3e:ff:8c:0f\u0027, \u002710.0.0.7\u0027]]},"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a5de9d1_b4a7e509","line":131,"updated":"2016-02-01 12:16:42.000000000","message":"fdb_entries will never have \u0027chg_ip\u0027 and \u0027ports\u0027 together at same time\nfdb_entries dict for update is completely different from that used for add/delete. \n\nfdb_entries for add and delete\n\nfdb_entries \u003d {netid: {\n           \u0027segment_id\u0027: ,\n            \u0027ports\u0027: {agent_ip1: []},\n            \u0027network_type\u0027: \u0027vxlan\u0027}}\nfdb_entries for update\nfdb_entries \u003d { \u0027chg_ip\u0027: {\n                 netid\u0027: {\n                    agent1-IP: {\n                        \u0027before\u0027: [ [\u003cmac\u003e, \u003cip\u003e], ... ],\n                        \u0027after\u0027 : [ [\u003cmac\u003e, \u003cip\u003e], ... ],\n                    }\n                   }\n                 }\nSo we need different test case test__unmarshall_fdb_entries_for_update to handle fdb_entries for update. \n\n\nIf we want to use same test case then then we can we have separate fdb_entries and _unmarshall_fdb_entries called twice, once for each of the fdb_entries like\nfdb_entries_add \u003d {netid: {\n           \u0027segment_id\u0027: ,\n            \u0027ports\u0027: {agent_ip1: []},\n            \u0027network_type\u0027: \u0027vxlan\u0027}} \nentries \u003d mixin._unmarshall_fdb_entries(fdb_entries_add)\n                \nfdb_entries_update \u003d { \u0027chg_ip\u0027: {\n                 netid\u0027: {\n                    agent1-IP: {\n                        \u0027before\u0027: [ [\u003cmac\u003e, \u003cip\u003e], ... ],\n                        \u0027after\u0027 : [ [\u003cmac\u003e, \u003cip\u003e], ... ],\n                    }\n                   }\n                 }\nentries \u003d mixin._unmarshall_fdb_entries(fdb_entries_update)","commit_id":"8dcf39aae7a099e01bd322891526c134e87e6b1b"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"5934ace43927e0c98b0e3374f2a611594ef302fc","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            \u0027ports\u0027: {\u0027192.168.0.10\u0027: [[\u002700:00:00:00:00:00\u0027, \u00270.0.0.0\u0027],"},{"line_number":129,"context_line":"                                       [\u0027fa:16:3e:ff:8c:0f\u0027, \u002710.0.0.6\u0027]]},"},{"line_number":130,"context_line":"            \u0027network_type\u0027: \u0027vxlan\u0027}}"},{"line_number":131,"context_line":"        entries[\u0027chg_ip\u0027] \u003d {"},{"line_number":132,"context_line":"            \u0027foouuid\u0027: {"},{"line_number":133,"context_line":"                \u0027192.168.0.1\u0027: {\u0027before\u0027: [[\u0027fa:16:3e:ff:8c:0f\u0027, \u002710.0.0.6\u0027]],"},{"line_number":134,"context_line":"                                \u0027after\u0027: [[\u0027fa:16:3e:ff:8c:0f\u0027, \u002710.0.0.7\u0027]]},"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a5de9d1_7d4854cc","line":131,"in_reply_to":"7a5de9d1_b4a7e509","updated":"2016-02-01 22:27:05.000000000","message":"Again, this is making assumptions about the payloads. I would rather be compatible with anything that could emit these messages than have branching inside something that is supposed to be one type of notification message.","commit_id":"8dcf39aae7a099e01bd322891526c134e87e6b1b"}]}
