)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"10121ec4b354b34d68bface6b25a614e8e02c48f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Port Extra Dhcp Opt to OVO"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch portes extra dhcp opt object to Oslo VersionedObjects."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I45b54b80d994f7e7f06128f73256b94675db97b2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5a5ae5dd_d93f1ab2","line":10,"updated":"2016-02-08 16:21:22.000000000","message":"Update commit message to include the RFE bug.","commit_id":"cb434acd936b8e9537fca809f09a19e10b85814c"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"de838553f9558bff4eb980fc95f9e5a80b6760ec","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Port Extra Dhcp Opt to OVO"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch portes extra dhcp opt object to Oslo VersionedObjects."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I45b54b80d994f7e7f06128f73256b94675db97b2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3a57f1b5_bacc4036","line":10,"in_reply_to":"5a5ae5dd_d93f1ab2","updated":"2016-02-10 16:27:25.000000000","message":"Updated.","commit_id":"cb434acd936b8e9537fca809f09a19e10b85814c"}],"neutron/db/api.py":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"830170eca49b31e9f9ec0ff46cc998f58f3c9eb0","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"def create_object(context, model, values):"},{"line_number":107,"context_line":"    with context.session.begin(subtransactions\u003dTrue):"},{"line_number":108,"context_line":"        if \u0027id\u0027 not in values and hasattr(model, \u0027id\u0027):"},{"line_number":109,"context_line":"            values[\u0027id\u0027] \u003d uuidutils.generate_uuid()"},{"line_number":110,"context_line":"        db_obj \u003d model(**values)"},{"line_number":111,"context_line":"        context.session.add(db_obj)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_58e61fb1","line":108,"updated":"2016-01-29 18:23:44.000000000","message":"you\u0027ll see this fix was merged upstream already :)","commit_id":"a6312d2651f4af8d5a01cc4af4629bef29ce550a"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"21e03c64b44823b3c817668db6de5272dd06268a","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"def create_object(context, model, values):"},{"line_number":107,"context_line":"    with context.session.begin(subtransactions\u003dTrue):"},{"line_number":108,"context_line":"        if \u0027id\u0027 not in values and hasattr(model, \u0027id\u0027):"},{"line_number":109,"context_line":"            values[\u0027id\u0027] \u003d uuidutils.generate_uuid()"},{"line_number":110,"context_line":"        db_obj \u003d model(**values)"},{"line_number":111,"context_line":"        context.session.add(db_obj)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_a9d6a04c","line":108,"in_reply_to":"7a5de9d1_58e61fb1","updated":"2016-02-01 16:20:32.000000000","message":"Great, thanks for this. :)","commit_id":"a6312d2651f4af8d5a01cc4af4629bef29ce550a"}],"neutron/db/extradhcpopt_db.py":[{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"2826049dffa0ada32795245bc837abc4a4685361","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                                             extra_dhcp_opts):"},{"line_number":39,"context_line":"        if not extra_dhcp_opts:"},{"line_number":40,"context_line":"            return port"},{"line_number":41,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":42,"context_line":"            for dopt in extra_dhcp_opts:"},{"line_number":43,"context_line":"                if self._is_valid_opt_value(dopt[\u0027opt_name\u0027],"},{"line_number":44,"context_line":"                                            dopt[\u0027opt_value\u0027]):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_58351844","line":41,"updated":"2016-01-28 10:56:05.000000000","message":"If you are using OVO, the session here may be deleted. That\u0027s my understanding.","commit_id":"e9e0fc965e6f86b9b9e60aca74f4ed304150af78"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"971cd54a6b62b85343b99725123fe52590afc9a0","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                                             extra_dhcp_opts):"},{"line_number":39,"context_line":"        if not extra_dhcp_opts:"},{"line_number":40,"context_line":"            return port"},{"line_number":41,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":42,"context_line":"            for dopt in extra_dhcp_opts:"},{"line_number":43,"context_line":"                if self._is_valid_opt_value(dopt[\u0027opt_name\u0027],"},{"line_number":44,"context_line":"                                            dopt[\u0027opt_value\u0027]):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_0ede7311","line":41,"in_reply_to":"7a5de9d1_58351844","updated":"2016-01-28 12:23:06.000000000","message":"Nice, thanks. Removed.","commit_id":"e9e0fc965e6f86b9b9e60aca74f4ed304150af78"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"2826049dffa0ada32795245bc837abc4a4685361","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                                context, port_id\u003did)"},{"line_number":75,"context_line":"            # if there are currently no dhcp_options associated to"},{"line_number":76,"context_line":"            # this port, Then just insert the new ones and be done."},{"line_number":77,"context_line":"            with context.session.begin(subtransactions\u003dTrue):"},{"line_number":78,"context_line":"                for upd_rec in dopts:"},{"line_number":79,"context_line":"                    for opt in opts:"},{"line_number":80,"context_line":"                        if (opt[\u0027opt_name\u0027] \u003d\u003d upd_rec[\u0027opt_name\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_13146142","line":77,"updated":"2016-01-28 10:56:05.000000000","message":"ditto line 41","commit_id":"e9e0fc965e6f86b9b9e60aca74f4ed304150af78"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"971cd54a6b62b85343b99725123fe52590afc9a0","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                                context, port_id\u003did)"},{"line_number":75,"context_line":"            # if there are currently no dhcp_options associated to"},{"line_number":76,"context_line":"            # this port, Then just insert the new ones and be done."},{"line_number":77,"context_line":"            with context.session.begin(subtransactions\u003dTrue):"},{"line_number":78,"context_line":"                for upd_rec in dopts:"},{"line_number":79,"context_line":"                    for opt in opts:"},{"line_number":80,"context_line":"                        if (opt[\u0027opt_name\u0027] \u003d\u003d upd_rec[\u0027opt_name\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_ce35bb46","line":77,"in_reply_to":"7a5de9d1_13146142","updated":"2016-01-28 12:23:06.000000000","message":"Deleted.","commit_id":"e9e0fc965e6f86b9b9e60aca74f4ed304150af78"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"2826049dffa0ada32795245bc837abc4a4685361","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            with context.session.begin(subtransactions\u003dTrue):"},{"line_number":78,"context_line":"                for upd_rec in dopts:"},{"line_number":79,"context_line":"                    for opt in opts:"},{"line_number":80,"context_line":"                        if (opt[\u0027opt_name\u0027] \u003d\u003d upd_rec[\u0027opt_name\u0027]"},{"line_number":81,"context_line":"                                and opt[\u0027ip_version\u0027] \u003d\u003d upd_rec.get("},{"line_number":82,"context_line":"                                    \u0027ip_version\u0027, 4)):"},{"line_number":83,"context_line":"                            # to handle deleting of a opt from the port."}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_d3f1e9ce","line":80,"updated":"2016-01-28 10:56:05.000000000","message":"We can access opt[\u0027opt_name\u0027] like opt.opt_name since it is OVO. The same for the rest of params in opt object","commit_id":"e9e0fc965e6f86b9b9e60aca74f4ed304150af78"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"971cd54a6b62b85343b99725123fe52590afc9a0","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            with context.session.begin(subtransactions\u003dTrue):"},{"line_number":78,"context_line":"                for upd_rec in dopts:"},{"line_number":79,"context_line":"                    for opt in opts:"},{"line_number":80,"context_line":"                        if (opt[\u0027opt_name\u0027] \u003d\u003d upd_rec[\u0027opt_name\u0027]"},{"line_number":81,"context_line":"                                and opt[\u0027ip_version\u0027] \u003d\u003d upd_rec.get("},{"line_number":82,"context_line":"                                    \u0027ip_version\u0027, 4)):"},{"line_number":83,"context_line":"                            # to handle deleting of a opt from the port."}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_6e54c720","line":80,"in_reply_to":"7a5de9d1_d3f1e9ce","updated":"2016-01-28 12:23:06.000000000","message":"Sure. I did most of it but must have missed the if statement.","commit_id":"e9e0fc965e6f86b9b9e60aca74f4ed304150af78"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"10121ec4b354b34d68bface6b25a614e8e02c48f","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    def _get_port_extra_dhcp_opts_binding(self, context, port_id):"},{"line_number":59,"context_line":"        opts \u003d obj_extra_dhcp.ExtraDhcpOpt.get_objects("},{"line_number":60,"context_line":"                            context, port_id\u003dport_id)"},{"line_number":61,"context_line":"        return [{\u0027opt_name\u0027: opt.opt_name, \u0027opt_value\u0027: opt.opt_value,"},{"line_number":62,"context_line":"                 \u0027ip_version\u0027: opt.ip_version}"},{"line_number":63,"context_line":"               for opt in opts]"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5ae5dd_59efaa1d","line":61,"updated":"2016-02-08 16:21:22.000000000","message":"can we return the object list instead of list of dicts?","commit_id":"cb434acd936b8e9537fca809f09a19e10b85814c"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"0bb488a00a3ad311833a5de2632c2ffec211489c","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    def _get_port_extra_dhcp_opts_binding(self, context, port_id):"},{"line_number":59,"context_line":"        opts \u003d obj_extra_dhcp.ExtraDhcpOpt.get_objects("},{"line_number":60,"context_line":"                            context, port_id\u003dport_id)"},{"line_number":61,"context_line":"        return [{\u0027opt_name\u0027: opt.opt_name, \u0027opt_value\u0027: opt.opt_value,"},{"line_number":62,"context_line":"                 \u0027ip_version\u0027: opt.ip_version}"},{"line_number":63,"context_line":"               for opt in opts]"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a57f1b5_83f2b504","line":61,"in_reply_to":"3a57f1b5_1fa7ffaa","updated":"2016-02-12 20:32:16.000000000","message":"Ok, will roll back the change and add TODO for the moment until we have he serializing in place.","commit_id":"cb434acd936b8e9537fca809f09a19e10b85814c"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"64382934c62363a2a9750b040d152cd5e685bcab","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    def _get_port_extra_dhcp_opts_binding(self, context, port_id):"},{"line_number":59,"context_line":"        opts \u003d obj_extra_dhcp.ExtraDhcpOpt.get_objects("},{"line_number":60,"context_line":"                            context, port_id\u003dport_id)"},{"line_number":61,"context_line":"        return [{\u0027opt_name\u0027: opt.opt_name, \u0027opt_value\u0027: opt.opt_value,"},{"line_number":62,"context_line":"                 \u0027ip_version\u0027: opt.ip_version}"},{"line_number":63,"context_line":"               for opt in opts]"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a57f1b5_df6ba783","line":61,"in_reply_to":"3a57f1b5_ba4f6091","updated":"2016-02-12 17:52:18.000000000","message":"yes because if you return objects here at line 55 those objects will be in port[edo_ext.EXTRADHCPOPTS] and the current code doesn\u0027t know how to serialize objects. The ultimate goal here is to move the serialization/deserialization out of this files into the objects. For example the port object should take care of loading the extra_dhcp_opt so we won\u0027t need to call methods like _process_port_create_extra_dhcp_opts . I am starting thinking that we might need a branch for us to keep working. We can\u0027t merge stuff in progress into master.","commit_id":"cb434acd936b8e9537fca809f09a19e10b85814c"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"f4d4edfb2a8b3d20c6e3c53fe6a37cd50861def8","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    def _get_port_extra_dhcp_opts_binding(self, context, port_id):"},{"line_number":59,"context_line":"        opts \u003d obj_extra_dhcp.ExtraDhcpOpt.get_objects("},{"line_number":60,"context_line":"                            context, port_id\u003dport_id)"},{"line_number":61,"context_line":"        return [{\u0027opt_name\u0027: opt.opt_name, \u0027opt_value\u0027: opt.opt_value,"},{"line_number":62,"context_line":"                 \u0027ip_version\u0027: opt.ip_version}"},{"line_number":63,"context_line":"               for opt in opts]"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a57f1b5_1fa7ffaa","line":61,"in_reply_to":"3a57f1b5_df6ba783","updated":"2016-02-12 17:57:39.000000000","message":"For now I think it\u0027s OK to leave a TODO...we can discuss during the upgrade meeting what\u0027s the best strategy to start moving things forward","commit_id":"cb434acd936b8e9537fca809f09a19e10b85814c"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"0bb488a00a3ad311833a5de2632c2ffec211489c","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    def _get_port_extra_dhcp_opts_binding(self, context, port_id):"},{"line_number":59,"context_line":"        opts \u003d obj_extra_dhcp.ExtraDhcpOpt.get_objects("},{"line_number":60,"context_line":"                            context, port_id\u003dport_id)"},{"line_number":61,"context_line":"        return [{\u0027opt_name\u0027: opt.opt_name, \u0027opt_value\u0027: opt.opt_value,"},{"line_number":62,"context_line":"                 \u0027ip_version\u0027: opt.ip_version}"},{"line_number":63,"context_line":"               for opt in opts]"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a57f1b5_63ae99e7","line":61,"in_reply_to":"3a57f1b5_df6ba783","updated":"2016-02-12 20:32:16.000000000","message":"Ok, thanks for the feedback. I seemed to miss that it port was containing the extra_dhcp_opt object. This would make sense then that it would be unable to marshall and unmarshall the object.","commit_id":"cb434acd936b8e9537fca809f09a19e10b85814c"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"de838553f9558bff4eb980fc95f9e5a80b6760ec","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    def _get_port_extra_dhcp_opts_binding(self, context, port_id):"},{"line_number":59,"context_line":"        opts \u003d obj_extra_dhcp.ExtraDhcpOpt.get_objects("},{"line_number":60,"context_line":"                            context, port_id\u003dport_id)"},{"line_number":61,"context_line":"        return [{\u0027opt_name\u0027: opt.opt_name, \u0027opt_value\u0027: opt.opt_value,"},{"line_number":62,"context_line":"                 \u0027ip_version\u0027: opt.ip_version}"},{"line_number":63,"context_line":"               for opt in opts]"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a57f1b5_ba4f6091","line":61,"in_reply_to":"5a5ae5dd_59efaa1d","updated":"2016-02-10 16:27:25.000000000","message":"I have added code to return as objects. I am however getting errors in unit tests (neutron.tests.unit.plugins.ml2.test_plugin.DHCPOptsTestCase.) as follows:\nFile \"neutron/tests/unit/extensions/test_extra_dhcp_opt.py\", line 64, in _check_opts\n        name \u003d opt[\u0027opt_name\u0027]\n    TypeError: string indices must be integers\n\nThe type being returned is a String. Adding the code change so reviewers can run locally to help identify the issue.","commit_id":"cb434acd936b8e9537fca809f09a19e10b85814c"}],"neutron/objects/port/extensions/extra_dhcp_opt.py":[{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"2826049dffa0ada32795245bc837abc4a4685361","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    db_model \u003d models.ExtraDhcpOpt"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    fields \u003d {"},{"line_number":28,"context_line":"         \u0027port_id\u0027: obj_fields.UUIDField(),"},{"line_number":29,"context_line":"         \u0027opt_name\u0027: obj_fields.StringField(nullable\u003dFalse),"},{"line_number":30,"context_line":"         \u0027opt_value\u0027: obj_fields.Field(obj_fields.String(), nullable\u003dFalse),"},{"line_number":31,"context_line":"         \u0027ip_version\u0027: obj_fields.IntegerField(nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_f32c25ad","line":28,"updated":"2016-01-28 10:56:05.000000000","message":"port_id should be nullable\u003dFalse","commit_id":"e9e0fc965e6f86b9b9e60aca74f4ed304150af78"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"971cd54a6b62b85343b99725123fe52590afc9a0","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    db_model \u003d models.ExtraDhcpOpt"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    fields \u003d {"},{"line_number":28,"context_line":"         \u0027port_id\u0027: obj_fields.UUIDField(),"},{"line_number":29,"context_line":"         \u0027opt_name\u0027: obj_fields.StringField(nullable\u003dFalse),"},{"line_number":30,"context_line":"         \u0027opt_value\u0027: obj_fields.Field(obj_fields.String(), nullable\u003dFalse),"},{"line_number":31,"context_line":"         \u0027ip_version\u0027: obj_fields.IntegerField(nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_f15ada29","line":28,"in_reply_to":"7a5de9d1_f32c25ad","updated":"2016-01-28 12:23:06.000000000","message":"Added.","commit_id":"e9e0fc965e6f86b9b9e60aca74f4ed304150af78"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"2826049dffa0ada32795245bc837abc4a4685361","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    fields \u003d {"},{"line_number":28,"context_line":"         \u0027port_id\u0027: obj_fields.UUIDField(),"},{"line_number":29,"context_line":"         \u0027opt_name\u0027: obj_fields.StringField(nullable\u003dFalse),"},{"line_number":30,"context_line":"         \u0027opt_value\u0027: obj_fields.Field(obj_fields.String(), nullable\u003dFalse),"},{"line_number":31,"context_line":"         \u0027ip_version\u0027: obj_fields.IntegerField(nullable\u003dFalse),"},{"line_number":32,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_13a461a4","line":30,"updated":"2016-01-28 10:56:05.000000000","message":"why this line is different than the one above?\nIt can be simply: obj_fields.StringField(nullable\u003dFalse)","commit_id":"e9e0fc965e6f86b9b9e60aca74f4ed304150af78"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"971cd54a6b62b85343b99725123fe52590afc9a0","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    fields \u003d {"},{"line_number":28,"context_line":"         \u0027port_id\u0027: obj_fields.UUIDField(),"},{"line_number":29,"context_line":"         \u0027opt_name\u0027: obj_fields.StringField(nullable\u003dFalse),"},{"line_number":30,"context_line":"         \u0027opt_value\u0027: obj_fields.Field(obj_fields.String(), nullable\u003dFalse),"},{"line_number":31,"context_line":"         \u0027ip_version\u0027: obj_fields.IntegerField(nullable\u003dFalse),"},{"line_number":32,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_f1717aa9","line":30,"in_reply_to":"7a5de9d1_13a461a4","updated":"2016-01-28 12:23:06.000000000","message":"Sure. I was just playing around with format to test an issue and must have forgot to undo the change. Thanks.","commit_id":"e9e0fc965e6f86b9b9e60aca74f4ed304150af78"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"2826049dffa0ada32795245bc837abc4a4685361","unresolved":false,"context_lines":[{"line_number":28,"context_line":"         \u0027port_id\u0027: obj_fields.UUIDField(),"},{"line_number":29,"context_line":"         \u0027opt_name\u0027: obj_fields.StringField(nullable\u003dFalse),"},{"line_number":30,"context_line":"         \u0027opt_value\u0027: obj_fields.Field(obj_fields.String(), nullable\u003dFalse),"},{"line_number":31,"context_line":"         \u0027ip_version\u0027: obj_fields.IntegerField(nullable\u003dFalse),"},{"line_number":32,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_b31d4d75","line":31,"updated":"2016-01-28 10:56:05.000000000","message":"The ip_version should be an enum of 2 values: 4 and 6.\nYou can take a look at my implemetation of IPVersionEnumField at: https://review.openstack.org/#/c/264273/8/neutron/objects/subnet.py","commit_id":"e9e0fc965e6f86b9b9e60aca74f4ed304150af78"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"971cd54a6b62b85343b99725123fe52590afc9a0","unresolved":false,"context_lines":[{"line_number":28,"context_line":"         \u0027port_id\u0027: obj_fields.UUIDField(),"},{"line_number":29,"context_line":"         \u0027opt_name\u0027: obj_fields.StringField(nullable\u003dFalse),"},{"line_number":30,"context_line":"         \u0027opt_value\u0027: obj_fields.Field(obj_fields.String(), nullable\u003dFalse),"},{"line_number":31,"context_line":"         \u0027ip_version\u0027: obj_fields.IntegerField(nullable\u003dFalse),"},{"line_number":32,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_5404fcbe","line":31,"in_reply_to":"7a5de9d1_b31d4d75","updated":"2016-01-28 12:23:06.000000000","message":"Nice enums. I will add them here for the moment and put a TODO in so that eventually we have it in common code so that all ovo objects can use them from one place.","commit_id":"e9e0fc965e6f86b9b9e60aca74f4ed304150af78"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"6af7fee470bd33cde1e149470d7e40da941f4865","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# TODO(mhickey) These enums should be picked up from common so can"},{"line_number":21,"context_line":"# be used by the other ovo objects. Refer to other patch [1]"},{"line_number":22,"context_line":"# [1]  https://review.openstack.org/#/c/264273/"},{"line_number":23,"context_line":"class IPVersionEnum(obj_fields.Enum):"},{"line_number":24,"context_line":"    \"\"\"IP version integer enum"},{"line_number":25,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_a8214f4f","line":22,"updated":"2016-01-28 13:22:30.000000000","message":"I have added the enums as separate PS: https://review.openstack.org/#/c/273517/","commit_id":"a6312d2651f4af8d5a01cc4af4629bef29ce550a"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"21e03c64b44823b3c817668db6de5272dd06268a","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# TODO(mhickey) These enums should be picked up from common so can"},{"line_number":21,"context_line":"# be used by the other ovo objects. Refer to other patch [1]"},{"line_number":22,"context_line":"# [1]  https://review.openstack.org/#/c/264273/"},{"line_number":23,"context_line":"class IPVersionEnum(obj_fields.Enum):"},{"line_number":24,"context_line":"    \"\"\"IP version integer enum"},{"line_number":25,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_a90b00d5","line":22,"in_reply_to":"7a5de9d1_1ea64fae","updated":"2016-02-01 16:20:32.000000000","message":"I am going to hold back on the enum for now until we discuss the patch to introduce. Reverting back to an Integer for the moment.","commit_id":"a6312d2651f4af8d5a01cc4af4629bef29ce550a"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"830170eca49b31e9f9ec0ff46cc998f58f3c9eb0","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# TODO(mhickey) These enums should be picked up from common so can"},{"line_number":21,"context_line":"# be used by the other ovo objects. Refer to other patch [1]"},{"line_number":22,"context_line":"# [1]  https://review.openstack.org/#/c/264273/"},{"line_number":23,"context_line":"class IPVersionEnum(obj_fields.Enum):"},{"line_number":24,"context_line":"    \"\"\"IP version integer enum"},{"line_number":25,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_1ea64fae","line":22,"in_reply_to":"7a5de9d1_a8214f4f","updated":"2016-01-29 18:23:44.000000000","message":"Artur tbh I prefer this way, less overheard, 2 classed instead of 4 :P","commit_id":"a6312d2651f4af8d5a01cc4af4629bef29ce550a"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"830170eca49b31e9f9ec0ff46cc998f58f3c9eb0","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    db_model \u003d models.ExtraDhcpOpt"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    fields \u003d {"},{"line_number":53,"context_line":"         \u0027port_id\u0027: obj_fields.UUIDField(nullable\u003dFalse),"},{"line_number":54,"context_line":"         \u0027opt_name\u0027: obj_fields.StringField(nullable\u003dFalse),"},{"line_number":55,"context_line":"         \u0027opt_value\u0027: obj_fields.StringField(nullable\u003dFalse),"},{"line_number":56,"context_line":"         \u0027ip_version\u0027: IPVersionEnumField(nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_beda9b4a","line":53,"updated":"2016-01-29 18:23:44.000000000","message":"nullable is false by default","commit_id":"a6312d2651f4af8d5a01cc4af4629bef29ce550a"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"21e03c64b44823b3c817668db6de5272dd06268a","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    db_model \u003d models.ExtraDhcpOpt"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    fields \u003d {"},{"line_number":53,"context_line":"         \u0027port_id\u0027: obj_fields.UUIDField(nullable\u003dFalse),"},{"line_number":54,"context_line":"         \u0027opt_name\u0027: obj_fields.StringField(nullable\u003dFalse),"},{"line_number":55,"context_line":"         \u0027opt_value\u0027: obj_fields.StringField(nullable\u003dFalse),"},{"line_number":56,"context_line":"         \u0027ip_version\u0027: IPVersionEnumField(nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_09fd74b3","line":53,"in_reply_to":"7a5de9d1_beda9b4a","updated":"2016-02-01 16:20:32.000000000","message":"Ok, thanks. Updated.","commit_id":"a6312d2651f4af8d5a01cc4af4629bef29ce550a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f6331507962f6f5392c954fe38164994d3b9e19f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"         \u0027ip_version\u0027: obj_fields.IntegerField(),"},{"line_number":33,"context_line":"    }"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    fields_no_update \u003d [\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":12,"id":"1af94dfe_7c7db51b","line":35,"updated":"2016-03-16 12:24:19.000000000","message":"Should it now be claimed as primary key, and it will get into fields_no_update with your patch for preventing update for primary keys?","commit_id":"67b65535b352e26e1f9d1e462fce2797f7888c84"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"594bb9130b55b0418c69e274df9bd073574fa71c","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    fields \u003d {"},{"line_number":28,"context_line":"         \u0027id\u0027: obj_fields.UUIDField(),"},{"line_number":29,"context_line":"         \u0027port_id\u0027: obj_fields.UUIDField(),"},{"line_number":30,"context_line":"         \u0027opt_name\u0027: obj_fields.StringField(),"},{"line_number":31,"context_line":"         \u0027opt_value\u0027: obj_fields.StringField(),"},{"line_number":32,"context_line":"         \u0027ip_version\u0027: obj_fields.IntegerField(),"},{"line_number":33,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":13,"id":"1af94dfe_47a02191","line":30,"updated":"2016-03-15 13:55:44.000000000","message":"any reason why this is not a list of name:values?","commit_id":"cfcc6b94e114cc31c88b55b27cc7bf79b6511b89"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"3726fe1a3d9772647be8d007fe78104b909c8cff","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    fields \u003d {"},{"line_number":28,"context_line":"         \u0027id\u0027: obj_fields.UUIDField(),"},{"line_number":29,"context_line":"         \u0027port_id\u0027: obj_fields.UUIDField(),"},{"line_number":30,"context_line":"         \u0027opt_name\u0027: obj_fields.StringField(),"},{"line_number":31,"context_line":"         \u0027opt_value\u0027: obj_fields.StringField(),"},{"line_number":32,"context_line":"         \u0027ip_version\u0027: obj_fields.IntegerField(),"},{"line_number":33,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":13,"id":"1af94dfe_8e699e8e","line":30,"in_reply_to":"1af94dfe_47a02191","updated":"2016-03-15 15:25:05.000000000","message":"Not sure what you mean? Can you elaborate pls.?","commit_id":"cfcc6b94e114cc31c88b55b27cc7bf79b6511b89"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7889969568bf4a9641b6bb3841a9f52dc014bd08","unresolved":false,"context_lines":[{"line_number":32,"context_line":"         \u0027ip_version\u0027: obj_fields.IntegerField(),"},{"line_number":33,"context_line":"    }"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    fields_no_update \u003d [\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":17,"id":"1af94dfe_dc15e99b","line":35,"updated":"2016-03-16 12:25:43.000000000","message":"Shouldn\u0027t it be primary key?","commit_id":"09bd0f5c6818e41457e417719783c26cd6a8288c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1b006165274b53e891be65477a162c8f06240f77","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    fields \u003d {"},{"line_number":28,"context_line":"         \u0027id\u0027: obj_fields.UUIDField(),"},{"line_number":29,"context_line":"         \u0027port_id\u0027: obj_fields.UUIDField(),"},{"line_number":30,"context_line":"         \u0027opt_name\u0027: obj_fields.StringField(),"},{"line_number":31,"context_line":"         \u0027opt_value\u0027: obj_fields.StringField(),"},{"line_number":32,"context_line":"         \u0027ip_version\u0027: obj_fields.IntegerField(),"},{"line_number":33,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":23,"id":"fa0719c6_2bbb2374","line":30,"updated":"2016-03-21 09:05:05.000000000","message":"what if there are multiple options. Will this mean an object per option configured?","commit_id":"ecde8a9ddbbb226683d3718ee6cd13004c33c3a7"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"51d7a254414eda0b759dda10347dd07a9878fc2e","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    fields \u003d {"},{"line_number":28,"context_line":"         \u0027id\u0027: obj_fields.UUIDField(),"},{"line_number":29,"context_line":"         \u0027port_id\u0027: obj_fields.UUIDField(),"},{"line_number":30,"context_line":"         \u0027opt_name\u0027: obj_fields.StringField(),"},{"line_number":31,"context_line":"         \u0027opt_value\u0027: obj_fields.StringField(),"},{"line_number":32,"context_line":"         \u0027ip_version\u0027: obj_fields.IntegerField(),"},{"line_number":33,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":23,"id":"fa0719c6_32ba6fe2","line":30,"in_reply_to":"fa0719c6_2bbb2374","updated":"2016-03-21 11:36:31.000000000","message":"opt_name is a string field in the model...it\u0027s not possible to have multiple opt_name.","commit_id":"ecde8a9ddbbb226683d3718ee6cd13004c33c3a7"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"968329a6924424b63a76972afc242b143ec4636e","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    fields \u003d {"},{"line_number":28,"context_line":"         \u0027id\u0027: obj_fields.UUIDField(),"},{"line_number":29,"context_line":"         \u0027port_id\u0027: obj_fields.UUIDField(),"},{"line_number":30,"context_line":"         \u0027opt_name\u0027: obj_fields.StringField(),"},{"line_number":31,"context_line":"         \u0027opt_value\u0027: obj_fields.StringField(),"},{"line_number":32,"context_line":"         \u0027ip_version\u0027: obj_fields.IntegerField(),"},{"line_number":33,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":23,"id":"fa0719c6_c55b1d86","line":30,"in_reply_to":"fa0719c6_32ba6fe2","updated":"2016-03-22 17:03:56.000000000","message":"Yes, object per option.","commit_id":"ecde8a9ddbbb226683d3718ee6cd13004c33c3a7"}],"neutron/tests/unit/objects/port/extensions/test_extra_dhcp_opt.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"9d609861e1a2d75c33aa7ac17101bb9c639206c1","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                               return_value\u003ddict(self.fake_extra_dhcp_opt)) \\"},{"line_number":48,"context_line":"            as get_object_mock:"},{"line_number":49,"context_line":"            test_obj \u003d self._test_class.get_by_id(self.context, id\u003d\u0027fake_id\u0027)"},{"line_number":50,"context_line":"            self.assertEqual(str(test_obj.opt_name),"},{"line_number":51,"context_line":"                             self.fake_extra_dhcp_opt[\u0027opt_name\u0027])"},{"line_number":52,"context_line":"            self.assertEqual(str(test_obj.opt_value),"},{"line_number":53,"context_line":"                             self.fake_extra_dhcp_opt[\u0027opt_value\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a5de9d1_d1161a4b","line":50,"updated":"2016-02-01 19:14:01.000000000","message":"nit: Asserts should be (expected, actual)","commit_id":"9b11431b42b8dad871f6c3a268e56a8c3771b242"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"e4070edfee309a723c176f0d4e721fa34582e530","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                               return_value\u003ddict(self.fake_extra_dhcp_opt)) \\"},{"line_number":48,"context_line":"            as get_object_mock:"},{"line_number":49,"context_line":"            test_obj \u003d self._test_class.get_by_id(self.context, id\u003d\u0027fake_id\u0027)"},{"line_number":50,"context_line":"            self.assertEqual(str(test_obj.opt_name),"},{"line_number":51,"context_line":"                             self.fake_extra_dhcp_opt[\u0027opt_name\u0027])"},{"line_number":52,"context_line":"            self.assertEqual(str(test_obj.opt_value),"},{"line_number":53,"context_line":"                             self.fake_extra_dhcp_opt[\u0027opt_value\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a5de9d1_4237b3fe","line":50,"in_reply_to":"7a5de9d1_d1161a4b","updated":"2016-02-01 22:09:51.000000000","message":"Thanks for seeing this Paul. Updated.","commit_id":"9b11431b42b8dad871f6c3a268e56a8c3771b242"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"7d8e778b21aaa3cb670951ee32de51341d74c7a5","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from neutron.objects.port.extensions import extra_dhcp_opt"},{"line_number":18,"context_line":"from neutron.tests.unit.objects import test_base as obj_test_base"},{"line_number":19,"context_line":"from neutron.tests.unit import testlib_api"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class ExtraDhcpOptDbObjectTestCase(obj_test_base.BaseDbObjectTestCase,"},{"line_number":23,"context_line":"                                   testlib_api.SqlTestCase):"}],"source_content_type":"text/x-python","patch_set":9,"id":"9aed3d3a_5a3883a0","line":20,"updated":"2016-02-28 10:07:02.000000000","message":"You should also add the tests inheriting from BaseObjectIfaceTestCase","commit_id":"683584535da9ab4e3fecba2df91792a6c27aa0b4"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"597d871914df89fa390e863b1fa579d7518a7f65","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from neutron.objects.port.extensions import extra_dhcp_opt"},{"line_number":18,"context_line":"from neutron.tests.unit.objects import test_base as obj_test_base"},{"line_number":19,"context_line":"from neutron.tests.unit import testlib_api"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class ExtraDhcpOptDbObjectTestCase(obj_test_base.BaseDbObjectTestCase,"},{"line_number":23,"context_line":"                                   testlib_api.SqlTestCase):"}],"source_content_type":"text/x-python","patch_set":9,"id":"7af24918_22a2dbae","line":20,"in_reply_to":"9aed3d3a_5a3883a0","updated":"2016-03-02 15:53:21.000000000","message":"ok, added.","commit_id":"683584535da9ab4e3fecba2df91792a6c27aa0b4"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"7d8e778b21aaa3cb670951ee32de51341d74c7a5","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        self.db_obj[\u0027id\u0027] \u003d \u0027fake_id\u0027"},{"line_number":34,"context_line":"        for obj in self.db_objs:"},{"line_number":35,"context_line":"            obj[\u0027port_id\u0027] \u003d self._port[\u0027id\u0027]"},{"line_number":36,"context_line":"            obj[\u0027id\u0027] \u003d \u0027fake_id\u0027"},{"line_number":37,"context_line":"        self.fake_extra_dhcp_opt \u003d {"},{"line_number":38,"context_line":"            \u0027id\u0027: \u0027fake_id\u0027,"},{"line_number":39,"context_line":"            \u0027port_id\u0027: self._port[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":9,"id":"9aed3d3a_da97738e","line":36,"updated":"2016-02-28 10:07:02.000000000","message":"why do you need this line? the \u0027id\u0027 should be set already in self.db_objs","commit_id":"683584535da9ab4e3fecba2df91792a6c27aa0b4"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"00015c99927c2a5fd9b4cf36a21458dd95274f3c","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        self.db_obj[\u0027id\u0027] \u003d \u0027fake_id\u0027"},{"line_number":34,"context_line":"        for obj in self.db_objs:"},{"line_number":35,"context_line":"            obj[\u0027port_id\u0027] \u003d self._port[\u0027id\u0027]"},{"line_number":36,"context_line":"            obj[\u0027id\u0027] \u003d \u0027fake_id\u0027"},{"line_number":37,"context_line":"        self.fake_extra_dhcp_opt \u003d {"},{"line_number":38,"context_line":"            \u0027id\u0027: \u0027fake_id\u0027,"},{"line_number":39,"context_line":"            \u0027port_id\u0027: self._port[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":9,"id":"5aef4532_ad02923c","line":36,"in_reply_to":"7af24918_a9bb5de4","updated":"2016-03-07 15:56:35.000000000","message":"Issue resolved in patch 11.","commit_id":"683584535da9ab4e3fecba2df91792a6c27aa0b4"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"597d871914df89fa390e863b1fa579d7518a7f65","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        self.db_obj[\u0027id\u0027] \u003d \u0027fake_id\u0027"},{"line_number":34,"context_line":"        for obj in self.db_objs:"},{"line_number":35,"context_line":"            obj[\u0027port_id\u0027] \u003d self._port[\u0027id\u0027]"},{"line_number":36,"context_line":"            obj[\u0027id\u0027] \u003d \u0027fake_id\u0027"},{"line_number":37,"context_line":"        self.fake_extra_dhcp_opt \u003d {"},{"line_number":38,"context_line":"            \u0027id\u0027: \u0027fake_id\u0027,"},{"line_number":39,"context_line":"            \u0027port_id\u0027: self._port[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":9,"id":"7af24918_a9bb5de4","line":36,"in_reply_to":"9aed3d3a_da97738e","updated":"2016-03-02 15:53:21.000000000","message":"If I don\u0027t set it, the following test fails:\nneutron.tests.unit.objects.port.extensions.test_extra_dhcp_opt.ExtraDhcpOptDbObjectTestCase.test_get_by_id_create_update_delete\n\nThe error returned is:\nFile \"neutron/db/api.py\", line 118, in _safe_get_object\n        raise n_exc.ObjectNotFound(id\u003did)\n    neutron_lib.exceptions.ObjectNotFound: Object 41ff703e-33e6-48d4-ba25-a225c668b194 not found.","commit_id":"683584535da9ab4e3fecba2df91792a6c27aa0b4"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"7d8e778b21aaa3cb670951ee32de51341d74c7a5","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            \u0027ip_version\u0027: 4,"},{"line_number":43,"context_line":"        }"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def test_get_by_id(self):"},{"line_number":46,"context_line":"        with mock.patch.object(db_api, \u0027get_object\u0027,"},{"line_number":47,"context_line":"                               return_value\u003ddict(self.fake_extra_dhcp_opt)) \\"},{"line_number":48,"context_line":"            as get_object_mock:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9aed3d3a_fa5197d9","line":45,"updated":"2016-02-28 10:07:02.000000000","message":"I don\u0027t think you need to override all these methods. Tests should pass without overriding them :)","commit_id":"683584535da9ab4e3fecba2df91792a6c27aa0b4"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"00015c99927c2a5fd9b4cf36a21458dd95274f3c","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            \u0027ip_version\u0027: 4,"},{"line_number":43,"context_line":"        }"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def test_get_by_id(self):"},{"line_number":46,"context_line":"        with mock.patch.object(db_api, \u0027get_object\u0027,"},{"line_number":47,"context_line":"                               return_value\u003ddict(self.fake_extra_dhcp_opt)) \\"},{"line_number":48,"context_line":"            as get_object_mock:"}],"source_content_type":"text/x-python","patch_set":9,"id":"5aef4532_0d9aa614","line":45,"in_reply_to":"7af24918_a996bded","updated":"2016-03-07 15:56:35.000000000","message":"Issue resolved in patch 11.","commit_id":"683584535da9ab4e3fecba2df91792a6c27aa0b4"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"597d871914df89fa390e863b1fa579d7518a7f65","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            \u0027ip_version\u0027: 4,"},{"line_number":43,"context_line":"        }"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def test_get_by_id(self):"},{"line_number":46,"context_line":"        with mock.patch.object(db_api, \u0027get_object\u0027,"},{"line_number":47,"context_line":"                               return_value\u003ddict(self.fake_extra_dhcp_opt)) \\"},{"line_number":48,"context_line":"            as get_object_mock:"}],"source_content_type":"text/x-python","patch_set":9,"id":"7af24918_a996bded","line":45,"in_reply_to":"9aed3d3a_21a62053","updated":"2016-03-02 15:53:21.000000000","message":"Replied above.","commit_id":"683584535da9ab4e3fecba2df91792a6c27aa0b4"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"597d871914df89fa390e863b1fa579d7518a7f65","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            \u0027ip_version\u0027: 4,"},{"line_number":43,"context_line":"        }"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def test_get_by_id(self):"},{"line_number":46,"context_line":"        with mock.patch.object(db_api, \u0027get_object\u0027,"},{"line_number":47,"context_line":"                               return_value\u003ddict(self.fake_extra_dhcp_opt)) \\"},{"line_number":48,"context_line":"            as get_object_mock:"}],"source_content_type":"text/x-python","patch_set":9,"id":"7af24918_89f2e16d","line":45,"in_reply_to":"9aed3d3a_fa5197d9","updated":"2016-03-02 15:53:21.000000000","message":"Sure, agreed. Its probably throwback from previously trying to get it to work. Removed now.\n\nI have however to override as I get the following error:\nFile \"/opt/stack/neutron/.tox/py27/local/lib/python2.7/site-packages/six.py\", line 718, in raise_from\n        raise value\n    AssertionError: Expected call: update_object(\u003cneutron.context.Context object at 0x7f2f33b16d90\u003e, \u003cclass \u0027neutron.db.extradhcpopt_db.ExtraDhcpOpt\u0027\u003e, \u0027fake_id\u0027, {\u0027ip_version\u0027: 546, \u0027id\u0027: \u0027fake_id\u0027, \u0027port_id\u0027: \u00272b14ec19-983f-48ae-8019-54e2ee5a601f\u0027, \u0027opt_name\u0027: \u0027yuikxqrewb\u0027, \u0027opt_value\u0027: \u0027hfsezutgld\u0027}, key\u003d\u0027id\u0027)\n    Actual call: update_object(\u003cneutron.context.Context object at 0x7f2f33b16d90\u003e, \u003cclass \u0027neutron.db.extradhcpopt_db.ExtraDhcpOpt\u0027\u003e, \u0027fake_id\u0027, {\u0027ip_version\u0027: 546, \u0027port_id\u0027: \u00272b14ec19-983f-48ae-8019-54e2ee5a601f\u0027, \u0027opt_name\u0027: \u0027yuikxqrewb\u0027, \u0027opt_value\u0027: \u0027hfsezutgld\u0027}, key\u003d\u0027id\u0027)\n\n\nThe actual call seems to be missing the \u0027id\u0027 field. Not sure how to set it though. Any feedback welcome.","commit_id":"683584535da9ab4e3fecba2df91792a6c27aa0b4"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ae1201ae5ad97678c3683cc6b8f3dc3d73a1fefa","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            \u0027ip_version\u0027: 4,"},{"line_number":43,"context_line":"        }"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def test_get_by_id(self):"},{"line_number":46,"context_line":"        with mock.patch.object(db_api, \u0027get_object\u0027,"},{"line_number":47,"context_line":"                               return_value\u003ddict(self.fake_extra_dhcp_opt)) \\"},{"line_number":48,"context_line":"            as get_object_mock:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9aed3d3a_21a62053","line":45,"in_reply_to":"9aed3d3a_fa5197d9","updated":"2016-02-29 10:48:09.000000000","message":"Yes. The assumption is that you should make sure existing test cases pass; plus you can add more object specific cases if needed.","commit_id":"683584535da9ab4e3fecba2df91792a6c27aa0b4"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"6622d9066f71537fdb29797e91e45b8b1bf006d1","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        self._create_test_port(self._network)"},{"line_number":34,"context_line":"        for obj in self.db_objs:"},{"line_number":35,"context_line":"            obj[\u0027port_id\u0027] \u003d self._port[\u0027id\u0027]"},{"line_number":36,"context_line":"            obj[\u0027id\u0027] \u003d \u0027fake_id\u0027"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @mock.patch.object(db_api, \u0027update_object\u0027)"},{"line_number":39,"context_line":"    def test_update_changes(self, update_mock):"}],"source_content_type":"text/x-python","patch_set":10,"id":"7af24918_92f4855b","line":36,"updated":"2016-03-03 13:03:46.000000000","message":"We can use \u0027real\u0027 UUID for this one, can be generated:\nfrom oslo_utils import uuidutils\nuuidutils.generate_uuid()\nIt was recently a patch removing the \u0027fake_id\u0027 and using the real UUID instead.","commit_id":"eed7ac6481d3e6d479bdfd5c8944a03aacf2a727"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"847cf58a5bcf8de7153fe570f8a220bf05c1977b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        self._create_test_port(self._network)"},{"line_number":34,"context_line":"        for obj in self.db_objs:"},{"line_number":35,"context_line":"            obj[\u0027port_id\u0027] \u003d self._port[\u0027id\u0027]"},{"line_number":36,"context_line":"            obj[\u0027id\u0027] \u003d \u0027fake_id\u0027"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @mock.patch.object(db_api, \u0027update_object\u0027)"},{"line_number":39,"context_line":"    def test_update_changes(self, update_mock):"}],"source_content_type":"text/x-python","patch_set":10,"id":"5aef4532_cd555e1e","line":36,"in_reply_to":"7af24918_92f4855b","updated":"2016-03-07 15:55:39.000000000","message":"Great, thanks for the \"heads up\". Updated to take account of it.","commit_id":"eed7ac6481d3e6d479bdfd5c8944a03aacf2a727"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"2cbe6042255f6a9e6869da1cc47f51853510211f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        self._create_test_network()"},{"line_number":33,"context_line":"        self._create_test_port(self._network)"},{"line_number":34,"context_line":"        for obj in self.db_objs:"},{"line_number":35,"context_line":"            obj[\u0027port_id\u0027] \u003d self._port[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":13,"id":"1af94dfe_c48c2f38","line":35,"updated":"2016-03-15 13:45:04.000000000","message":"After modify_fields_to/from_db was added, we have to add in test classes setUp() method assigning the id to second structure that is:\n\nfor obj in self.obj_fields:\n    obj[\u0027port_id\u0027] \u003d self._port[\u0027id\u0027]\n\nhttps://github.com/openstack/neutron/blob/master/neutron/tests/unit/objects/test_base.py#L167","commit_id":"cfcc6b94e114cc31c88b55b27cc7bf79b6511b89"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"3726fe1a3d9772647be8d007fe78104b909c8cff","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        self._create_test_network()"},{"line_number":33,"context_line":"        self._create_test_port(self._network)"},{"line_number":34,"context_line":"        for obj in self.db_objs:"},{"line_number":35,"context_line":"            obj[\u0027port_id\u0027] \u003d self._port[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":13,"id":"1af94dfe_2e44ca72","line":35,"in_reply_to":"1af94dfe_c48c2f38","updated":"2016-03-15 15:25:05.000000000","message":"Thanks for \"heads up\" Artur. Updated.","commit_id":"cfcc6b94e114cc31c88b55b27cc7bf79b6511b89"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"dc54af00af84166cd15decb94b0020c84203bcbe","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        for obj in self.db_objs:"},{"line_number":35,"context_line":"            obj[\u0027port_id\u0027] \u003d self._port[\u0027id\u0027]"},{"line_number":36,"context_line":"        for obj in self.obj_fields:"},{"line_number":37,"context_line":"                obj[\u0027port_id\u0027] \u003d self._port[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":19,"id":"1af94dfe_867307e7","line":37,"updated":"2016-03-16 15:08:42.000000000","message":"problem with indentation ?","commit_id":"a40809f9f905f8a1743a7655b200bfd0bc09b7d6"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"ed871b485acc8654e6e9e8fb85548aabd6b0147a","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        for obj in self.db_objs:"},{"line_number":35,"context_line":"            obj[\u0027port_id\u0027] \u003d self._port[\u0027id\u0027]"},{"line_number":36,"context_line":"        for obj in self.obj_fields:"},{"line_number":37,"context_line":"                obj[\u0027port_id\u0027] \u003d self._port[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":19,"id":"1af94dfe_8b302b03","line":37,"in_reply_to":"1af94dfe_867307e7","updated":"2016-03-16 16:01:15.000000000","message":"Yep, updated.","commit_id":"a40809f9f905f8a1743a7655b200bfd0bc09b7d6"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"18d53a699b0004316db2cc495270b5c76b728dc8","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def setUp(self):"},{"line_number":30,"context_line":"        super(ExtraDhcpOptDbObjectTestCase, self).setUp()"},{"line_number":31,"context_line":"        self.context \u003d context.get_admin_context()"},{"line_number":32,"context_line":"        self._create_test_network()"},{"line_number":33,"context_line":"        self._create_test_port(self._network)"},{"line_number":34,"context_line":"        for obj in self.db_objs:"}],"source_content_type":"text/x-python","patch_set":21,"id":"1af94dfe_9822c9a1","line":31,"updated":"2016-03-18 13:56:19.000000000","message":"do we really need admin context?","commit_id":"7447c91bd4e1521beae50d9f10df66ee1ff73862"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e3db0ce0a4548083b396760d031215769ded9426","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def setUp(self):"},{"line_number":30,"context_line":"        super(ExtraDhcpOptDbObjectTestCase, self).setUp()"},{"line_number":31,"context_line":"        self.context \u003d context.get_admin_context()"},{"line_number":32,"context_line":"        self._create_test_network()"},{"line_number":33,"context_line":"        self._create_test_port(self._network)"},{"line_number":34,"context_line":"        for obj in self.db_objs:"}],"source_content_type":"text/x-python","patch_set":21,"id":"1af94dfe_d4236b54","line":31,"in_reply_to":"1af94dfe_9822c9a1","updated":"2016-03-18 19:20:53.000000000","message":"Done","commit_id":"7447c91bd4e1521beae50d9f10df66ee1ff73862"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"b81c6af286dd7b511c6b617731ee6c4a7724bf4f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        super(ExtraDhcpOptDbObjectTestCase, self).setUp()"},{"line_number":30,"context_line":"        self._create_test_network()"},{"line_number":31,"context_line":"        self._create_test_port(self._network)"},{"line_number":32,"context_line":"        for obj in self.db_objs:"},{"line_number":33,"context_line":"            obj[\u0027port_id\u0027] \u003d self._port[\u0027id\u0027]"},{"line_number":34,"context_line":"        for obj in self.obj_fields:"},{"line_number":35,"context_line":"            obj[\u0027port_id\u0027] \u003d self._port[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":23,"id":"fa0719c6_4bb497f1","line":32,"updated":"2016-03-21 08:58:12.000000000","message":"Small nit in case of new patch needed:\n\nfor obj in itertools.chain(self.db_objs, self.obj_fields):\n    obj[\u0027port_id\u0027] \u003d self._port.id","commit_id":"ecde8a9ddbbb226683d3718ee6cd13004c33c3a7"}]}
