)]}'
{"neutron/objects/common_types.py":[{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"be0523cc541f2741c867d8b32adf4edab502a74f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 OpenStack Foundation"},{"line_number":2,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_cb3da2bc","line":1,"range":{"start_line":1,"start_character":27,"end_line":1,"end_character":37},"updated":"2016-01-28 14:18:19.000000000","message":"Not sure this is necessary?","commit_id":"95604cc01be62bcd1d3cb0269c414103a2d1adce"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"573bbc70f24076d8b231e166ffd335ac97aaa9f4","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class IPVersionEnum(obj_fields.Enum):"},{"line_number":20,"context_line":"    \"\"\"IP version integer enum"},{"line_number":21,"context_line":"    \"\"\""},{"line_number":22,"context_line":"    def __init__(self, **kwargs):"},{"line_number":23,"context_line":"        super(IPVersionEnum, self).__init__(valid_values\u003d[4, 6], **kwargs)"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_a8ab7688","line":21,"range":{"start_line":21,"start_character":4,"end_line":21,"end_character":7},"updated":"2016-01-28 19:39:31.000000000","message":"nit: could put on previous line. Here and L43.","commit_id":"95604cc01be62bcd1d3cb0269c414103a2d1adce"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"d65f28a2b9f8a5d2e6a8101553c1646624d3d01e","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class IPVersionEnum(obj_fields.Enum):"},{"line_number":20,"context_line":"    \"\"\"IP version integer enum"},{"line_number":21,"context_line":"    \"\"\""},{"line_number":22,"context_line":"    def __init__(self, **kwargs):"},{"line_number":23,"context_line":"        super(IPVersionEnum, self).__init__(valid_values\u003d[4, 6], **kwargs)"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_383cb5c7","line":21,"range":{"start_line":21,"start_character":4,"end_line":21,"end_character":7},"in_reply_to":"7a5de9d1_a8ab7688","updated":"2016-01-28 20:39:03.000000000","message":"Done","commit_id":"95604cc01be62bcd1d3cb0269c414103a2d1adce"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"75cfa5632d0295ef3d6317c59acd4338f438dc6e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from neutron.common import constants"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class IPVersionEnum(obj_fields.Enum):"},{"line_number":20,"context_line":"    \"\"\"IP version integer enum\"\"\""},{"line_number":21,"context_line":"    def __init__(self, **kwargs):"},{"line_number":22,"context_line":"        super(IPVersionEnum, self).__init__(valid_values\u003d[4, 6], **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_78867bdc","line":19,"updated":"2016-01-29 17:29:49.000000000","message":"as commented on your other patch this seems an overkill. In the end it\u0027s an Integer field whose values can be only 4 and 6. I am OK if you want to add a validation method for that but I really don\u0027t see the point of having all these classes. I think it will make marshalling/unmarshalling more complicated without a good reason. Let\u0027s hear what other think.","commit_id":"3b86e91e5f5bfcb3aa9cd0b7c38d8bbe2a4a4560"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1fdef401e9d5101bd42c8d47eee137922222209f","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from neutron.common import constants"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class IPVersionEnum(obj_fields.Enum):"},{"line_number":20,"context_line":"    \"\"\"IP version integer enum\"\"\""},{"line_number":21,"context_line":"    def __init__(self, **kwargs):"},{"line_number":22,"context_line":"        super(IPVersionEnum, self).__init__(valid_values\u003d[4, 6], **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_537dcb6c","line":19,"in_reply_to":"7a5de9d1_78867bdc","updated":"2016-02-04 16:33:42.000000000","message":"I personally prefer object format to be as strict as possible. But if you feel strong about the version enum, ok, let\u0027s skip it.\n\nI am pretty strong that we should have the mode enum. It may catch some actual mistakes later in the run.","commit_id":"3b86e91e5f5bfcb3aa9cd0b7c38d8bbe2a4a4560"}],"neutron/tests/unit/objects/test_common_types.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1fdef401e9d5101bd42c8d47eee137922222209f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":12,"context_line":"#    under the License."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"from oslo_versionedobjects.tests import test_fields"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron.objects import common_types"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_33484f2d","line":14,"updated":"2016-02-04 16:33:42.000000000","message":"I suspect the module is not part of the library API. We may need to have our own test class for that.","commit_id":"3b86e91e5f5bfcb3aa9cd0b7c38d8bbe2a4a4560"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1fdef401e9d5101bd42c8d47eee137922222209f","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from neutron.objects import common_types"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class IPVersionEnumFieldTest(test_fields.TestField):"},{"line_number":20,"context_line":"    def setUp(self):"},{"line_number":21,"context_line":"        super(IPVersionEnumFieldTest, self).setUp()"},{"line_number":22,"context_line":"        self.field \u003d common_types.IPVersionEnumField()"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_f3e39731","line":19,"updated":"2016-02-04 16:33:42.000000000","message":"I don\u0027t see a test for mode field.","commit_id":"3b86e91e5f5bfcb3aa9cd0b7c38d8bbe2a4a4560"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"6e2e6cab78d4985b4a8ed044c10ddaa4c306a952","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from neutron.objects import common_types"},{"line_number":18,"context_line":"from neutron.tests import base as test_base"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class FakeFieldType(fields.FieldType):"},{"line_number":22,"context_line":"    def coerce(self, obj, attr, value):"},{"line_number":23,"context_line":"        return \u0027*%s*\u0027 % value"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_0399cf7b","line":20,"updated":"2016-02-08 12:07:03.000000000","message":"no need to copy/paste, we can import what we need from oslo versionedobjects test_fields, right?","commit_id":"37e89dad9e1a2d2d5dbcc3e728982d876727a896"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"1808ecdad414f2a026d4f21a9d73577b674c08aa","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from neutron.objects import common_types"},{"line_number":18,"context_line":"from neutron.tests import base as test_base"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class FakeFieldType(fields.FieldType):"},{"line_number":22,"context_line":"    def coerce(self, obj, attr, value):"},{"line_number":23,"context_line":"        return \u0027*%s*\u0027 % value"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_5ecc7eba","line":20,"in_reply_to":"5a5ae5dd_0399cf7b","updated":"2016-02-08 12:12:47.000000000","message":"I have imported the from oslo_versionedobjects.tests import test_fields in PS2 and Ihar commented that we can write our own base test class...","commit_id":"37e89dad9e1a2d2d5dbcc3e728982d876727a896"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c7343cab8a5fcbd3778159ad85ceab4ab88b2c60","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from neutron.objects import common_types"},{"line_number":18,"context_line":"from neutron.tests import base as test_base"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class FakeFieldType(fields.FieldType):"},{"line_number":22,"context_line":"    def coerce(self, obj, attr, value):"},{"line_number":23,"context_line":"        return \u0027*%s*\u0027 % value"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_84daa415","line":20,"in_reply_to":"5a5ae5dd_5ecc7eba","updated":"2016-02-08 13:20:53.000000000","message":"Yeah, the problem I guess is that test_base is not guaranteed to behave the same way in the future. Unless we get appropriate reassurance from oslo team that it will stay stable, we should duplicate the code here.","commit_id":"37e89dad9e1a2d2d5dbcc3e728982d876727a896"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c7343cab8a5fcbd3778159ad85ceab4ab88b2c60","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        self.to_primitive_values \u003d [(\u0027foo\u0027, \u0027!foo!\u0027)]"},{"line_number":39,"context_line":"        self.from_primitive_values \u003d [(\u0027!foo!\u0027, \u0027foo\u0027)]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def test_coerce_good_values(self):"},{"line_number":42,"context_line":"        for in_val, out_val in self.coerce_good_values:"},{"line_number":43,"context_line":"            self.assertEqual(out_val, self.field.coerce(\u0027obj\u0027, \u0027attr\u0027, in_val))"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_6418c8d3","line":41,"updated":"2016-02-08 13:20:53.000000000","message":"I don\u0027t think we need test cases that target oslo.versionedobjects library. The only thing we need to validate is the custom field type we introduce in neutron. So please make TestField a non-test class, and mix it in the class that targets the custom field.","commit_id":"37e89dad9e1a2d2d5dbcc3e728982d876727a896"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"31c6f47a10bc6e2c3bad0817cc22ac53401a2cfa","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        self.to_primitive_values \u003d [(\u0027foo\u0027, \u0027!foo!\u0027)]"},{"line_number":39,"context_line":"        self.from_primitive_values \u003d [(\u0027!foo!\u0027, \u0027foo\u0027)]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def test_coerce_good_values(self):"},{"line_number":42,"context_line":"        for in_val, out_val in self.coerce_good_values:"},{"line_number":43,"context_line":"            self.assertEqual(out_val, self.field.coerce(\u0027obj\u0027, \u0027attr\u0027, in_val))"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_3525e5ad","line":41,"in_reply_to":"5a5ae5dd_6418c8d3","updated":"2016-02-09 09:33:34.000000000","message":"Done","commit_id":"37e89dad9e1a2d2d5dbcc3e728982d876727a896"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"6e2e6cab78d4985b4a8ed044c10ddaa4c306a952","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        self.coerce_good_values \u003d [(mode, mode)"},{"line_number":72,"context_line":"                                   for mode in constants.IPV6_MODES]"},{"line_number":73,"context_line":"        self.coerce_bad_values \u003d [\u00276\u0027, 4, \u0027type\u0027, \u0027slaacc\u0027]"},{"line_number":74,"context_line":"        self.to_primitive_values \u003d self.coerce_good_values[0:1]"},{"line_number":75,"context_line":"        self.from_primitive_values \u003d self.coerce_good_values[0:1]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def test_stringify(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_633d23dc","line":74,"updated":"2016-02-08 12:07:03.000000000","message":"why checking only one mode? why [0:1] ?","commit_id":"37e89dad9e1a2d2d5dbcc3e728982d876727a896"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"31c6f47a10bc6e2c3bad0817cc22ac53401a2cfa","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        self.coerce_good_values \u003d [(mode, mode)"},{"line_number":72,"context_line":"                                   for mode in constants.IPV6_MODES]"},{"line_number":73,"context_line":"        self.coerce_bad_values \u003d [\u00276\u0027, 4, \u0027type\u0027, \u0027slaacc\u0027]"},{"line_number":74,"context_line":"        self.to_primitive_values \u003d self.coerce_good_values[0:1]"},{"line_number":75,"context_line":"        self.from_primitive_values \u003d self.coerce_good_values[0:1]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def test_stringify(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_b539d5da","line":74,"in_reply_to":"5a5ae5dd_3e40a206","updated":"2016-02-09 09:33:34.000000000","message":"Done","commit_id":"37e89dad9e1a2d2d5dbcc3e728982d876727a896"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"1808ecdad414f2a026d4f21a9d73577b674c08aa","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        self.coerce_good_values \u003d [(mode, mode)"},{"line_number":72,"context_line":"                                   for mode in constants.IPV6_MODES]"},{"line_number":73,"context_line":"        self.coerce_bad_values \u003d [\u00276\u0027, 4, \u0027type\u0027, \u0027slaacc\u0027]"},{"line_number":74,"context_line":"        self.to_primitive_values \u003d self.coerce_good_values[0:1]"},{"line_number":75,"context_line":"        self.from_primitive_values \u003d self.coerce_good_values[0:1]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def test_stringify(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_3e40a206","line":74,"in_reply_to":"5a5ae5dd_633d23dc","updated":"2016-02-08 12:12:47.000000000","message":"Copy paste from oslo lib tests.","commit_id":"37e89dad9e1a2d2d5dbcc3e728982d876727a896"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"6e2e6cab78d4985b4a8ed044c10ddaa4c306a952","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        self.from_primitive_values \u003d self.coerce_good_values[0:1]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def test_stringify(self):"},{"line_number":78,"context_line":"        self.assertEqual(\"\u0027%s\u0027\" % constants.IPV6_MODES[0],"},{"line_number":79,"context_line":"                         self.field.stringify(constants.IPV6_MODES[0]))"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def test_stringify_invalid(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_436ca707","line":78,"updated":"2016-02-08 12:07:03.000000000","message":"you could verify all the modes :)","commit_id":"37e89dad9e1a2d2d5dbcc3e728982d876727a896"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"1808ecdad414f2a026d4f21a9d73577b674c08aa","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        self.from_primitive_values \u003d self.coerce_good_values[0:1]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def test_stringify(self):"},{"line_number":78,"context_line":"        self.assertEqual(\"\u0027%s\u0027\" % constants.IPV6_MODES[0],"},{"line_number":79,"context_line":"                         self.field.stringify(constants.IPV6_MODES[0]))"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def test_stringify_invalid(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_be5492c9","line":78,"in_reply_to":"5a5ae5dd_436ca707","updated":"2016-02-08 12:12:47.000000000","message":"Can do :)","commit_id":"37e89dad9e1a2d2d5dbcc3e728982d876727a896"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"31c6f47a10bc6e2c3bad0817cc22ac53401a2cfa","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        self.from_primitive_values \u003d self.coerce_good_values[0:1]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def test_stringify(self):"},{"line_number":78,"context_line":"        self.assertEqual(\"\u0027%s\u0027\" % constants.IPV6_MODES[0],"},{"line_number":79,"context_line":"                         self.field.stringify(constants.IPV6_MODES[0]))"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def test_stringify_invalid(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_75335df7","line":78,"in_reply_to":"5a5ae5dd_47026e0b","updated":"2016-02-09 09:33:34.000000000","message":"Done","commit_id":"37e89dad9e1a2d2d5dbcc3e728982d876727a896"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c7343cab8a5fcbd3778159ad85ceab4ab88b2c60","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        self.from_primitive_values \u003d self.coerce_good_values[0:1]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def test_stringify(self):"},{"line_number":78,"context_line":"        self.assertEqual(\"\u0027%s\u0027\" % constants.IPV6_MODES[0],"},{"line_number":79,"context_line":"                         self.field.stringify(constants.IPV6_MODES[0]))"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def test_stringify_invalid(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_47026e0b","line":78,"in_reply_to":"5a5ae5dd_be5492c9","updated":"2016-02-08 13:20:53.000000000","message":"Yeah. And I think you could just rewrite base class test_stringify to validate each self.coerce_good_values entry, in that way you avoid overloading of the test method here.","commit_id":"37e89dad9e1a2d2d5dbcc3e728982d876727a896"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c7343cab8a5fcbd3778159ad85ceab4ab88b2c60","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                         self.field.stringify(constants.IPV6_MODES[0]))"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def test_stringify_invalid(self):"},{"line_number":82,"context_line":"        self.assertRaises(ValueError, self.field.stringify, \u0027slaacc\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_0708f626","line":82,"updated":"2016-02-08 13:20:53.000000000","message":"Should it belong to the base test class, and use bad_values?","commit_id":"37e89dad9e1a2d2d5dbcc3e728982d876727a896"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"31c6f47a10bc6e2c3bad0817cc22ac53401a2cfa","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                         self.field.stringify(constants.IPV6_MODES[0]))"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def test_stringify_invalid(self):"},{"line_number":82,"context_line":"        self.assertRaises(ValueError, self.field.stringify, \u0027slaacc\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_953059ea","line":82,"in_reply_to":"5a5ae5dd_0708f626","updated":"2016-02-09 09:33:34.000000000","message":"Done","commit_id":"37e89dad9e1a2d2d5dbcc3e728982d876727a896"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"93a714615e66512fb42953a01a9bff2ce7d71787","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from neutron.tests import base as test_base"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class TestField(object):"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def test_coerce_good_values(self):"},{"line_number":22,"context_line":"        for in_val, out_val in self.coerce_good_values:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_10ec778e","line":19,"updated":"2016-02-09 10:08:41.000000000","message":"FYI I talked to oslo team about reusing their testing code, and they confirmed we should not rely on it, and if there is some code to reuse, we should work with them on getting a testing fixture in their library, then use it.\n\nHere we are mostly interested in test cases themselves, not some setup code, so I don\u0027t see much we can do to reuse the code.\n\nWith that in mind, I think it\u0027s fine to copy paste some testing code into neutron tree.","commit_id":"38a436a3eb3879078f848cc7b68942f174d9bb11"}]}
