)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f70bdd29873358f0779a4d058fcf106224bd6e2e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dina Belova \u003cdbelova@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-02-02 17:19:13 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[DRAFT][WIP][DO NOT MERGE] Add OSprofiler support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Depends-On: I6fe7800ce65d2df200c5853851f43e1da40948ae"},{"line_number":10,"context_line":"Closes-Bug: #1335640"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5a5ae5dd_0e912b47","line":7,"updated":"2016-02-05 18:14:22.000000000","message":"Patch [1], looks less intrusive than this one, can you elaborate on the why? \n\n[1] https://review.openstack.org/#/c/254703/\n\nBtw this needs a DocImpact and a release note.","commit_id":"166151f1aa9bf6da3de5320341db0058d514ab58"},{"author":{"_account_id":18485,"name":"Haim Daniel","email":"hdaniel@redhat.com","username":"hdaniel"},"change_message_id":"100cce57b175a110a4a8974c1073bc75f0168b68","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add OSprofiler support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Add osprofiler wsgi middleware. This middleware is used for 2 things:"},{"line_number":10,"context_line":"  1) It checks that person who want to trace is trusted and knows"},{"line_number":11,"context_line":"     secret HMAC key."},{"line_number":12,"context_line":"  2) It start tracing in case of proper trace headers"},{"line_number":13,"context_line":"     and add first wsgi trace point, with info about HTTP request"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"ba0121b8_34888922","line":10,"range":{"start_line":10,"start_character":31,"end_line":10,"end_character":35},"updated":"2016-03-29 11:29:42.000000000","message":"s/want/wants","commit_id":"a5ae849f5d2691cd24c92346ac048f5b02b0ef39"},{"author":{"_account_id":18485,"name":"Haim Daniel","email":"hdaniel@redhat.com","username":"hdaniel"},"change_message_id":"100cce57b175a110a4a8974c1073bc75f0168b68","unresolved":false,"context_lines":[{"line_number":9,"context_line":"* Add osprofiler wsgi middleware. This middleware is used for 2 things:"},{"line_number":10,"context_line":"  1) It checks that person who want to trace is trusted and knows"},{"line_number":11,"context_line":"     secret HMAC key."},{"line_number":12,"context_line":"  2) It start tracing in case of proper trace headers"},{"line_number":13,"context_line":"     and add first wsgi trace point, with info about HTTP request"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"* Add initialization of osprofiler at start of serivce"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"ba0121b8_74820102","line":12,"range":{"start_line":12,"start_character":8,"end_line":12,"end_character":13},"updated":"2016-03-29 11:29:42.000000000","message":"s/start/starts","commit_id":"a5ae849f5d2691cd24c92346ac048f5b02b0ef39"},{"author":{"_account_id":18485,"name":"Haim Daniel","email":"hdaniel@redhat.com","username":"hdaniel"},"change_message_id":"100cce57b175a110a4a8974c1073bc75f0168b68","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  1) It checks that person who want to trace is trusted and knows"},{"line_number":11,"context_line":"     secret HMAC key."},{"line_number":12,"context_line":"  2) It start tracing in case of proper trace headers"},{"line_number":13,"context_line":"     and add first wsgi trace point, with info about HTTP request"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"* Add initialization of osprofiler at start of serivce"},{"line_number":16,"context_line":"  Currently that includes oslo.messaging notifer instance creation"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"ba0121b8_f476113d","line":13,"range":{"start_line":13,"start_character":9,"end_line":13,"end_character":12},"updated":"2016-03-29 11:29:42.000000000","message":"s/add/adds","commit_id":"a5ae849f5d2691cd24c92346ac048f5b02b0ef39"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ac736e369602ef137ce7b877fd4edba079da389f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  2) It starts tracing in case of proper trace headers"},{"line_number":13,"context_line":"     and adds first wsgi trace point, with info about HTTP request"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"* Add initialization of osprofiler at start of serivce"},{"line_number":16,"context_line":"  Currently that includes oslo.messaging notifer instance creation"},{"line_number":17,"context_line":"  to send Ceilometer backend notifications."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"1a122d0e_952d37ab","line":15,"range":{"start_line":15,"start_character":47,"end_line":15,"end_character":54},"updated":"2016-04-30 21:02:09.000000000","message":"typo","commit_id":"7b1c386a1fad037b8835a707fb5e671c87249bf8"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"fa0e9eb09db1bea68606e4140fda0079f1c6f4c2","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  2) It starts tracing in case of proper trace headers"},{"line_number":13,"context_line":"     and adds first wsgi trace point, with info about HTTP request"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"* Add initialization of osprofiler at start of serivce"},{"line_number":16,"context_line":"  Currently that includes oslo.messaging notifer instance creation"},{"line_number":17,"context_line":"  to send Ceilometer backend notifications."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"1a122d0e_503a8d35","line":15,"range":{"start_line":15,"start_character":47,"end_line":15,"end_character":54},"in_reply_to":"1a122d0e_952d37ab","updated":"2016-04-30 23:32:54.000000000","message":"Done","commit_id":"7b1c386a1fad037b8835a707fb5e671c87249bf8"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ac736e369602ef137ce7b877fd4edba079da389f","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Neutron client change: Ic11796889075b2a0e589b70398fc4d4ed6f3ef7c"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Depends-On: I5102eb46a7a377eca31375a0d64951ba1fdd035d"},{"line_number":22,"context_line":"Closes-Bug: #1335640"},{"line_number":23,"context_line":"Change-Id: I7fa2ad57dc5763ce72cba6945ebcadef2188e8bd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"1a122d0e_752a1b92","line":22,"updated":"2016-04-30 21:02:09.000000000","message":"please add DocImpact and APIImpact","commit_id":"7b1c386a1fad037b8835a707fb5e671c87249bf8"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"fa0e9eb09db1bea68606e4140fda0079f1c6f4c2","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Neutron client change: Ic11796889075b2a0e589b70398fc4d4ed6f3ef7c"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Depends-On: I5102eb46a7a377eca31375a0d64951ba1fdd035d"},{"line_number":22,"context_line":"Closes-Bug: #1335640"},{"line_number":23,"context_line":"Change-Id: I7fa2ad57dc5763ce72cba6945ebcadef2188e8bd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"1a122d0e_b047a1bb","line":22,"in_reply_to":"1a122d0e_752a1b92","updated":"2016-04-30 23:32:54.000000000","message":"Done","commit_id":"7b1c386a1fad037b8835a707fb5e671c87249bf8"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"17f70d966e4b03e548d05b86ed2265fb0f133815","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Depends-On: I5102eb46a7a377eca31375a0d64951ba1fdd035d"},{"line_number":22,"context_line":"Closes-Bug: #1335640"},{"line_number":23,"context_line":"DocImpact"},{"line_number":24,"context_line":"APIImpact"},{"line_number":25,"context_line":"Change-Id: I7fa2ad57dc5763ce72cba6945ebcadef2188e8bd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"1a122d0e_a2a07b91","line":23,"updated":"2016-05-04 23:53:50.000000000","message":"this needs a description, e.g.\n\nDocImpact This feature is gonna rock because I said so.","commit_id":"c95fe2d9ec7fe9493f38aad29afc08d4bd09ce31"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"55b111bdffbccc58e6158ecd86060c5b155e4303","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Depends-On: I5102eb46a7a377eca31375a0d64951ba1fdd035d"},{"line_number":22,"context_line":"Closes-Bug: #1335640"},{"line_number":23,"context_line":"DocImpact"},{"line_number":24,"context_line":"APIImpact"},{"line_number":25,"context_line":"Change-Id: I7fa2ad57dc5763ce72cba6945ebcadef2188e8bd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"dab17558_aaf6dad4","line":23,"in_reply_to":"1a122d0e_a2a07b91","updated":"2016-05-06 18:02:22.000000000","message":"Done","commit_id":"c95fe2d9ec7fe9493f38aad29afc08d4bd09ce31"}],"etc/api-paste.ini":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"17f70d966e4b03e548d05b86ed2265fb0f133815","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[composite:neutronapi_v2_0]"},{"line_number":7,"context_line":"use \u003d call:neutron.auth:pipeline_factory"},{"line_number":8,"context_line":"noauth \u003d cors request_id catch_errors osprofiler extensions neutronapiapp_v2_0"},{"line_number":9,"context_line":"keystone \u003d cors request_id catch_errors osprofiler authtoken keystonecontext extensions neutronapiapp_v2_0"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"[filter:request_id]"}],"source_content_type":"text/x-properties","patch_set":16,"id":"1a122d0e_02aa0f71","line":8,"updated":"2016-05-04 23:53:50.000000000","message":"do we really want to add this in the pipeline by default?","commit_id":"c95fe2d9ec7fe9493f38aad29afc08d4bd09ce31"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"55b111bdffbccc58e6158ecd86060c5b155e4303","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[composite:neutronapi_v2_0]"},{"line_number":7,"context_line":"use \u003d call:neutron.auth:pipeline_factory"},{"line_number":8,"context_line":"noauth \u003d cors request_id catch_errors osprofiler extensions neutronapiapp_v2_0"},{"line_number":9,"context_line":"keystone \u003d cors request_id catch_errors osprofiler authtoken keystonecontext extensions neutronapiapp_v2_0"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"[filter:request_id]"}],"source_content_type":"text/x-properties","patch_set":16,"id":"dab17558_4ad3ee38","line":8,"in_reply_to":"1a122d0e_02aa0f71","updated":"2016-05-06 18:02:22.000000000","message":"I agree that we may not want it in the default pipeline, but I\u0027m unsure how to get it in the pipeline that is used by the gate...","commit_id":"c95fe2d9ec7fe9493f38aad29afc08d4bd09ce31"}],"neutron/common/profiler.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ac736e369602ef137ce7b877fd4edba079da389f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import logging"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from oslo_config import cfg"},{"line_number":16,"context_line":"import oslo_messaging"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a122d0e_15100759","line":13,"updated":"2016-04-30 21:02:09.000000000","message":"why not using the oslo logging?","commit_id":"7b1c386a1fad037b8835a707fb5e671c87249bf8"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"fa0e9eb09db1bea68606e4140fda0079f1c6f4c2","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import logging"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from oslo_config import cfg"},{"line_number":16,"context_line":"import oslo_messaging"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a122d0e_904425b8","line":13,"in_reply_to":"1a122d0e_15100759","updated":"2016-04-30 23:32:54.000000000","message":"will change - the last patchset was to fix merge conflicts and not address changes in coding style","commit_id":"7b1c386a1fad037b8835a707fb5e671c87249bf8"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ac736e369602ef137ce7b877fd4edba079da389f","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import osprofiler.web"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from neutron.i18n import _LI"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"CONF \u003d cfg.CONF"},{"line_number":25,"context_line":"profiler_opts.set_defaults(CONF)"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a122d0e_d515ef4c","line":22,"updated":"2016-04-30 21:02:09.000000000","message":"no need to the extra new line here","commit_id":"7b1c386a1fad037b8835a707fb5e671c87249bf8"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"fa0e9eb09db1bea68606e4140fda0079f1c6f4c2","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import osprofiler.web"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from neutron.i18n import _LI"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"CONF \u003d cfg.CONF"},{"line_number":25,"context_line":"profiler_opts.set_defaults(CONF)"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a122d0e_d014dda0","line":22,"in_reply_to":"1a122d0e_d515ef4c","updated":"2016-04-30 23:32:54.000000000","message":"Done","commit_id":"7b1c386a1fad037b8835a707fb5e671c87249bf8"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ac736e369602ef137ce7b877fd4edba079da389f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                     \"Traces provided from the profiler \""},{"line_number":45,"context_line":"                     \"can only be subscribed to using the same HMAC keys that \""},{"line_number":46,"context_line":"                     \"are configured in Neutron\u0027s configuration file \""},{"line_number":47,"context_line":"                     \"under the [profiler] section. \\n To disable OSprofiler \""},{"line_number":48,"context_line":"                     \"set in /etc/keystone/keystone.conf:\\n\""},{"line_number":49,"context_line":"                     \"[profiler]\\n\""},{"line_number":50,"context_line":"                     \"enabled\u003dfalse\"))"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a122d0e_550a7f28","line":47,"range":{"start_line":47,"start_character":51,"end_line":47,"end_character":52},"updated":"2016-04-30 21:02:09.000000000","message":"nit - remove the space here","commit_id":"7b1c386a1fad037b8835a707fb5e671c87249bf8"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"fa0e9eb09db1bea68606e4140fda0079f1c6f4c2","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                     \"Traces provided from the profiler \""},{"line_number":45,"context_line":"                     \"can only be subscribed to using the same HMAC keys that \""},{"line_number":46,"context_line":"                     \"are configured in Neutron\u0027s configuration file \""},{"line_number":47,"context_line":"                     \"under the [profiler] section. \\n To disable OSprofiler \""},{"line_number":48,"context_line":"                     \"set in /etc/keystone/keystone.conf:\\n\""},{"line_number":49,"context_line":"                     \"[profiler]\\n\""},{"line_number":50,"context_line":"                     \"enabled\u003dfalse\"))"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a122d0e_100f7589","line":47,"range":{"start_line":47,"start_character":51,"end_line":47,"end_character":52},"in_reply_to":"1a122d0e_550a7f28","updated":"2016-04-30 23:32:54.000000000","message":"Done","commit_id":"7b1c386a1fad037b8835a707fb5e671c87249bf8"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"39f2f2cc0062b90d0acfd9ae71004cdd8c31c479","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                     \"can only be subscribed to using the same HMAC keys that \""},{"line_number":44,"context_line":"                     \"are configured in Neutron\u0027s configuration file \""},{"line_number":45,"context_line":"                     \"under the [profiler] section.\\n To disable OSprofiler \""},{"line_number":46,"context_line":"                     \"set in /etc/keystone/keystone.conf:\\n\""},{"line_number":47,"context_line":"                     \"[profiler]\\n\""},{"line_number":48,"context_line":"                     \"enabled\u003dfalse\"))"}],"source_content_type":"text/x-python","patch_set":27,"id":"bab6814e_a3d96d59","line":46,"updated":"2016-05-20 15:39:35.000000000","message":"Hi, I think there is a small typo here; should it be /etc/neutron/neutron.conf ? Thanks.","commit_id":"d26fa50c81590d65d2bf8b0092cabaef9885a9b5"}],"neutron/common/rpc.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"2c596f8849d03bcb488eb3ac2bb375cad12230ef","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                \"base_id\": prof.get_base_id(),"},{"line_number":143,"context_line":"                \"parent_id\": prof.get_id()"},{"line_number":144,"context_line":"            }"},{"line_number":145,"context_line":"            _context.update({\"trace_info\": trace_info})"},{"line_number":146,"context_line":"        return _context"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def deserialize_context(self, ctxt):"}],"source_content_type":"text/x-python","patch_set":10,"id":"bae84128_f9dbb419","line":145,"updated":"2016-02-19 21:39:41.000000000","message":"use:\n\n _context[\u0027trace_info\u0027] \u003d trace_info","commit_id":"a5ae849f5d2691cd24c92346ac048f5b02b0ef39"}],"neutron/plugins/ml2/drivers/agent/_common_agent.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"96558d1cc90e12e9f90b114b656b1d46f3ae910c","unresolved":false,"context_lines":[{"line_number":40,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"@profiler.trace_cls(\"rpc\")"},{"line_number":44,"context_line":"class CommonAgentLoop(service.Service):"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def __init__(self, manager, polling_interval,"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_02732f4f","line":43,"updated":"2016-05-04 23:52:35.000000000","message":"I see you add these to a bunch of agent modules, what about L3, DHCP and Metadata?","commit_id":"c95fe2d9ec7fe9493f38aad29afc08d4bd09ce31"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"55b111bdffbccc58e6158ecd86060c5b155e4303","unresolved":false,"context_lines":[{"line_number":40,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"@profiler.trace_cls(\"rpc\")"},{"line_number":44,"context_line":"class CommonAgentLoop(service.Service):"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def __init__(self, manager, polling_interval,"}],"source_content_type":"text/x-python","patch_set":16,"id":"dab17558_8a0f96e0","line":43,"in_reply_to":"1a122d0e_02732f4f","updated":"2016-05-06 18:02:22.000000000","message":"good point will do along with the rebase","commit_id":"c95fe2d9ec7fe9493f38aad29afc08d4bd09ce31"}],"neutron/tests/contrib/gate_hook.sh":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"3450453685b3dc982eedef569ad895578e01d37d","unresolved":false,"context_lines":[{"line_number":61,"context_line":"\"api\"|\"api-pecan\"|\"full-pecan\"|\"dsvm-scenario\")"},{"line_number":62,"context_line":"    load_rc_hook api_extensions"},{"line_number":63,"context_line":"    load_rc_hook qos"},{"line_number":64,"context_line":"    load_rc_hook osprofiler"},{"line_number":65,"context_line":"    if [[ \"$VENV\" \u003d~ \"pecan\" ]]; then"},{"line_number":66,"context_line":"        load_conf_hook pecan"},{"line_number":67,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":18,"id":"dab17558_4a1be51b","line":64,"updated":"2016-05-06 22:07:30.000000000","message":"git add ?\n\nhttp://logs.openstack.org/51/273951/18/check/gate-neutron-dsvm-api/dba274f/console.html#_2016-05-06_19_00_28_615","commit_id":"e32f848ddcb4db95e31985c83d728d57a95ffdbf"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"d1f5ded324bdc2d4e51f76ba5e8892f1cb46e8c6","unresolved":false,"context_lines":[{"line_number":61,"context_line":"\"api\"|\"api-pecan\"|\"full-pecan\"|\"dsvm-scenario\")"},{"line_number":62,"context_line":"    load_rc_hook api_extensions"},{"line_number":63,"context_line":"    load_rc_hook qos"},{"line_number":64,"context_line":"    load_rc_hook osprofiler"},{"line_number":65,"context_line":"    if [[ \"$VENV\" \u003d~ \"pecan\" ]]; then"},{"line_number":66,"context_line":"        load_conf_hook pecan"},{"line_number":67,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":18,"id":"dab17558_fa3a66cc","line":64,"in_reply_to":"dab17558_4a1be51b","updated":"2016-05-07 00:50:53.000000000","message":"Yeah, I wasn\u0027t thinking - I\u0027ll add something and since I\u0027m still not at 100% I expect it will be wrong again","commit_id":"e32f848ddcb4db95e31985c83d728d57a95ffdbf"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"bd8b732af380c98684ca22adc8ec197432f8f32a","unresolved":false,"context_lines":[{"line_number":61,"context_line":"\"api\"|\"api-pecan\"|\"full-pecan\"|\"dsvm-scenario\")"},{"line_number":62,"context_line":"    load_rc_hook api_extensions"},{"line_number":63,"context_line":"    load_rc_hook qos"},{"line_number":64,"context_line":"    load_rc_hook osprofiler"},{"line_number":65,"context_line":"    if [[ \"$VENV\" \u003d~ \"pecan\" ]]; then"},{"line_number":66,"context_line":"        load_conf_hook pecan"},{"line_number":67,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":19,"id":"dab17558_7a05d6c0","line":64,"updated":"2016-05-07 01:05:24.000000000","message":"when load_rc_hook is executed the content of osprofiler will go straight into localrc so as you tried it won\u0027t work.","commit_id":"0b22a2aa86f430d4d59093c28a5fe5d9a4ba227f"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"0386697040aa0ee793ec50dbc8eb65e14a410efc","unresolved":false,"context_lines":[{"line_number":61,"context_line":"\"api\"|\"api-pecan\"|\"full-pecan\"|\"dsvm-scenario\")"},{"line_number":62,"context_line":"    load_rc_hook api_extensions"},{"line_number":63,"context_line":"    load_rc_hook qos"},{"line_number":64,"context_line":"    load_rc_hook osprofiler"},{"line_number":65,"context_line":"    if [[ \"$VENV\" \u003d~ \"pecan\" ]]; then"},{"line_number":66,"context_line":"        load_conf_hook pecan"},{"line_number":67,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":19,"id":"dab17558_ddd83cf2","line":64,"in_reply_to":"dab17558_7a05d6c0","updated":"2016-05-07 02:56:28.000000000","message":"Yes - I did say I wasn\u0027t thinking too clearly...","commit_id":"0b22a2aa86f430d4d59093c28a5fe5d9a4ba227f"}],"neutron/tests/contrib/hooks/osprofiler":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"29b24c891ac091260ea967e205b2059194d5556e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[composite:neutronapi_v2_0]"},{"line_number":2,"context_line":"noauth \u003d cors request_id catch_errors osprofiler extensions neutronapiapp_v2_0"},{"line_number":3,"context_line":"keystone \u003d cors request_id catch_errors osprofiler authtoken keystonecontext extensions neutronapiapp_v2_0"},{"line_number":4,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":19,"id":"dab17558_5a3c5293","line":1,"updated":"2016-05-07 01:02:42.000000000","message":"this won\u0027t quite work, I wonder if we should try something like below so that we don\u0027t happen to test a stale pipeline (as we\u0027d be simply adding osprofiler to whatever default pipeline we get installed).\n\n iniadd /etc/neutron/api-paste composite:neutronapi_v2_0 noauth osprofiler\n\n iniadd /etc/neutron/api-paste composite:neutronapi_v2_0 keystone osprofiler","commit_id":"0b22a2aa86f430d4d59093c28a5fe5d9a4ba227f"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"0386697040aa0ee793ec50dbc8eb65e14a410efc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[composite:neutronapi_v2_0]"},{"line_number":2,"context_line":"noauth \u003d cors request_id catch_errors osprofiler extensions neutronapiapp_v2_0"},{"line_number":3,"context_line":"keystone \u003d cors request_id catch_errors osprofiler authtoken keystonecontext extensions neutronapiapp_v2_0"},{"line_number":4,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":19,"id":"dab17558_1de3e4a4","line":1,"in_reply_to":"dab17558_5a3c5293","updated":"2016-05-07 02:56:28.000000000","message":"We\u0027ll try that, but I\u0027m not 100% convinced it will do what we want...","commit_id":"0b22a2aa86f430d4d59093c28a5fe5d9a4ba227f"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2705c9c428e38c5d47c3066b4524d730f488979f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"iniadd /etc/neutron/api-paste.ini composite:neutronapi_v2_0 noauth osprofiler"},{"line_number":2,"context_line":"iniadd /etc/neutron/api-paste.ini composite:neutronapi_v2_0 keystone osprofiler"}],"source_content_type":"application/octet-stream","patch_set":22,"id":"dab17558_3d7dff6e","line":1,"updated":"2016-05-07 23:20:12.000000000","message":"doh...at the time this is evaluated api-paste.ini doesn\u0027t exist yet...\n\nI think we need to use the other type of hook and use the post-config phase.\n\n/me mumbles.","commit_id":"ba032dfefbddc6afd0202bc31c772fe141aebc35"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"7b2ae964dfc3ec3c44ae6ade04cd0f8a4f874f2c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"iniadd /etc/neutron/api-paste.ini composite:neutronapi_v2_0 noauth osprofiler"},{"line_number":2,"context_line":"iniadd /etc/neutron/api-paste.ini composite:neutronapi_v2_0 keystone osprofiler"}],"source_content_type":"application/octet-stream","patch_set":22,"id":"dab17558_7d8ae7c0","line":1,"in_reply_to":"dab17558_3d7dff6e","updated":"2016-05-08 02:17:08.000000000","message":"/me mumbles or /me grumbles\n\nI hope PS23 gets it right, otherwise, I\u0027ll try something that looks more like the pecan hook","commit_id":"ba032dfefbddc6afd0202bc31c772fe141aebc35"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a0b08cdf7c1316af75c1b34de21dbafeac361a7e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[[post-config|/etc/neutron/api-paste.ini]]"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"[composite:neutronapi_v2_0]"},{"line_number":4,"context_line":"use \u003d call:neutron.auth:pipeline_factory"}],"source_content_type":"application/octet-stream","patch_set":24,"id":"dab17558_da1e07ba","line":1,"updated":"2016-05-10 20:56:30.000000000","message":"/me makes a mental note that any changes to the pipeline must be reflected here from now on.","commit_id":"709b59627e4f906e9ad8739cd2906c3422ee50a5"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"5453f169ba275f6e912d21b0677b563ab0706b6b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"use \u003d call:neutron.auth:pipeline_factory"},{"line_number":5,"context_line":"noauth \u003d cors request_id catch_errors osprofiler extensions neutronapiapp_v2_0"},{"line_number":6,"context_line":"keystone \u003d cors request_id catch_errors osprofiler authtoken keystonecontext extensions neutronapiapp_v2_0"},{"line_number":7,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":24,"id":"dab17558_f26d2f99","line":7,"updated":"2016-05-10 01:11:15.000000000","message":"if you respin then please blow away the last empty line","commit_id":"709b59627e4f906e9ad8739cd2906c3422ee50a5"}]}
