)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"c938bc9722c709392b9cdb0cf1052d5d39cb51de","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP - Get tempest via zuul-cloner if needed and it is available"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Not sure why this isn\u0027t firing; test patch"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I70f402202f99a989ef5e95213669f4ca9f7b706f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a5de9d1_3419dcd7","line":9,"updated":"2016-01-30 07:29:28.000000000","message":"Many gerrit triggers understand the command \u0027recheck\u0027 from people recheck. It could you can use it here too.","commit_id":"941d397cfba1c2cdd9aabc6648d7fbdfda8ba61c"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"72e7c26b7d53a4370c3f7063f66c00e6d8692210","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP - Get tempest via zuul-cloner if needed and it is available"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Not sure why this isn\u0027t firing; test patch"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I70f402202f99a989ef5e95213669f4ca9f7b706f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a5de9d1_14f06066","line":9,"in_reply_to":"7a5de9d1_3419dcd7","updated":"2016-01-30 07:40:21.000000000","message":"Not what I was referring to.","commit_id":"941d397cfba1c2cdd9aabc6648d7fbdfda8ba61c"}],"tools/tox_install.sh":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"322c26fe7f043d6edb9688ec55dc94370ed90c7e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/sh"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Many of neutron\u0027s repos suffer from the problem of depending on neutron,"},{"line_number":4,"context_line":"# but it not existing on pypi. -- Well, that\u0027s the usual issue, but in"},{"line_number":5,"context_line":"# neutron\u0027s case, we want to import tempest directly for the api tests."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# This wrapper for tox\u0027s package installer will use the existing package"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7a5de9d1_13de48dd","line":4,"range":{"start_line":4,"start_character":31,"end_line":4,"end_character":33},"updated":"2016-01-29 18:00:15.000000000","message":"in this specific circumstance we\u0027re doing this for tempest :)","commit_id":"a4562d1c763fc278fea2c287cda53f523860b1ac"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"d61d39df98fc9ff2c535fef7074cd32bb0613eaa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/sh"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Many of neutron\u0027s repos suffer from the problem of depending on neutron,"},{"line_number":4,"context_line":"# but it not existing on pypi. -- Well, that\u0027s the usual issue, but in"},{"line_number":5,"context_line":"# neutron\u0027s case, we want to import tempest directly for the api tests."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# This wrapper for tox\u0027s package installer will use the existing package"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7a5de9d1_13288899","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":70},"updated":"2016-01-29 18:01:02.000000000","message":"in this specific circumstance we\u0027re doing this for tempest :)","commit_id":"f42097445350729b7ac8f07b74684711070854a7"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"42540aceb08e436a2267bd6c8779f110074ee9fc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/sh"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Many of neutron\u0027s repos suffer from the problem of depending on neutron,"},{"line_number":4,"context_line":"# but it not existing on pypi. -- Well, that\u0027s the usual issue, but in"},{"line_number":5,"context_line":"# neutron\u0027s case, we want to import tempest directly for the api tests."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# This wrapper for tox\u0027s package installer will use the existing package"}],"source_content_type":"text/x-sh","patch_set":4,"id":"7a5de9d1_9fcd56b9","line":4,"updated":"2016-01-29 21:11:17.000000000","message":"Can you try to resume this in the commit message? Can you write this in a bug in launch pad ad reference to it in the commit message? This would make this change easier to trace.","commit_id":"1f154d2d68fe0c4641c28ec16797c90f7418bd24"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"0273b3ec9ba131a0defd0dd9b7a3dabd79753d9a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/sh"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Many of neutron\u0027s repos suffer from the problem of depending on neutron,"},{"line_number":4,"context_line":"# but it not existing on pypi. -- Well, that\u0027s the usual issue, but in"},{"line_number":5,"context_line":"# neutron\u0027s case, we want to import tempest directly for the api tests."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# This wrapper for tox\u0027s package installer will use the existing package"}],"source_content_type":"text/x-sh","patch_set":4,"id":"7a5de9d1_95853508","line":4,"in_reply_to":"7a5de9d1_9fcd56b9","updated":"2016-01-29 21:52:13.000000000","message":"This was a quick follow-on using an existing method. Will put a reference to the bug from the original commit.","commit_id":"1f154d2d68fe0c4641c28ec16797c90f7418bd24"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"42540aceb08e436a2267bd6c8779f110074ee9fc","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# default:"},{"line_number":15,"context_line":"# pip install {opts} {packages}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"ZUUL_CLONER\u003d/usr/zuul-env/bin/zuul-cloner"},{"line_number":18,"context_line":"tempest_installed\u003d$(echo \"import tempest\" | python 2\u003e/dev/null ; echo $?)"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"set -e"}],"source_content_type":"text/x-sh","patch_set":4,"id":"7a5de9d1_ffe32aa2","line":17,"updated":"2016-01-29 21:11:17.000000000","message":"Is it cool cloner there in all distributions?\nPlease mind about Centos and Ubuntu at least","commit_id":"1f154d2d68fe0c4641c28ec16797c90f7418bd24"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"0273b3ec9ba131a0defd0dd9b7a3dabd79753d9a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# default:"},{"line_number":15,"context_line":"# pip install {opts} {packages}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"ZUUL_CLONER\u003d/usr/zuul-env/bin/zuul-cloner"},{"line_number":18,"context_line":"tempest_installed\u003d$(echo \"import tempest\" | python 2\u003e/dev/null ; echo $?)"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"set -e"}],"source_content_type":"text/x-sh","patch_set":4,"id":"7a5de9d1_35e00129","line":17,"in_reply_to":"7a5de9d1_ffe32aa2","updated":"2016-01-29 21:52:13.000000000","message":"zuul-cloner is an openstack infra thing; outside that, pip is used.","commit_id":"1f154d2d68fe0c4641c28ec16797c90f7418bd24"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"42540aceb08e436a2267bd6c8779f110074ee9fc","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# pip install {opts} {packages}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"ZUUL_CLONER\u003d/usr/zuul-env/bin/zuul-cloner"},{"line_number":18,"context_line":"tempest_installed\u003d$(echo \"import tempest\" | python 2\u003e/dev/null ; echo $?)"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"set -e"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"7a5de9d1_3fd462ea","line":18,"updated":"2016-01-29 21:11:17.000000000","message":"You don\u0027t need to pipe code to python. Python -c does the job. It think this is easier to read:\n\nfunction has_python_package()\n{\n    python -c \"\\\n        try:\\\n            import $1\\\n        except ImportError:\\\n            exit(1)\\\n        else:\\\n            exit(0)\"\n}\n\n\n# then user it\nif has_python_package tempest; then\n   # ...\nfi","commit_id":"1f154d2d68fe0c4641c28ec16797c90f7418bd24"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"0273b3ec9ba131a0defd0dd9b7a3dabd79753d9a","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# pip install {opts} {packages}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"ZUUL_CLONER\u003d/usr/zuul-env/bin/zuul-cloner"},{"line_number":18,"context_line":"tempest_installed\u003d$(echo \"import tempest\" | python 2\u003e/dev/null ; echo $?)"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"set -e"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"7a5de9d1_55957d3c","line":18,"in_reply_to":"7a5de9d1_3fd462ea","updated":"2016-01-29 21:52:13.000000000","message":"Note that you\u0027re giving a bash example in an sh script, but you\u0027re turning one line into 14. i don\u0027t find that easier to read, but let me see if I can tweak something in-between.","commit_id":"1f154d2d68fe0c4641c28ec16797c90f7418bd24"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"42540aceb08e436a2267bd6c8779f110074ee9fc","unresolved":false,"context_lines":[{"line_number":22,"context_line":"if [ $tempest_installed -eq 0 ]; then"},{"line_number":23,"context_line":"    echo \"Tempest already installed; using existing package\""},{"line_number":24,"context_line":"elif [ -x \"$ZUUL_CLONER\" ]; then"},{"line_number":25,"context_line":"    export ZUUL_BRANCH\u003d${ZUUL_BRANCH-$BRANCH}"},{"line_number":26,"context_line":"    cwd\u003d$(/bin/pwd)"},{"line_number":27,"context_line":"    cd /tmp"},{"line_number":28,"context_line":"    $ZUUL_CLONER --cache-dir \\"}],"source_content_type":"text/x-sh","patch_set":4,"id":"7a5de9d1_bf97f2ea","line":25,"updated":"2016-01-29 21:11:17.000000000","message":"Probably you mind\n    export ZUUL_BRANCH\u003d${ZUUL_BRANCH:-$BRANCH}","commit_id":"1f154d2d68fe0c4641c28ec16797c90f7418bd24"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"0273b3ec9ba131a0defd0dd9b7a3dabd79753d9a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"if [ $tempest_installed -eq 0 ]; then"},{"line_number":23,"context_line":"    echo \"Tempest already installed; using existing package\""},{"line_number":24,"context_line":"elif [ -x \"$ZUUL_CLONER\" ]; then"},{"line_number":25,"context_line":"    export ZUUL_BRANCH\u003d${ZUUL_BRANCH-$BRANCH}"},{"line_number":26,"context_line":"    cwd\u003d$(/bin/pwd)"},{"line_number":27,"context_line":"    cd /tmp"},{"line_number":28,"context_line":"    $ZUUL_CLONER --cache-dir \\"}],"source_content_type":"text/x-sh","patch_set":4,"id":"7a5de9d1_354ec13b","line":25,"in_reply_to":"7a5de9d1_bf97f2ea","updated":"2016-01-29 21:52:13.000000000","message":"Either syntax works, actually. Nor did I write this part, this script is copied from another repo.","commit_id":"1f154d2d68fe0c4641c28ec16797c90f7418bd24"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"42540aceb08e436a2267bd6c8779f110074ee9fc","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    echo \"Tempest already installed; using existing package\""},{"line_number":24,"context_line":"elif [ -x \"$ZUUL_CLONER\" ]; then"},{"line_number":25,"context_line":"    export ZUUL_BRANCH\u003d${ZUUL_BRANCH-$BRANCH}"},{"line_number":26,"context_line":"    cwd\u003d$(/bin/pwd)"},{"line_number":27,"context_line":"    cd /tmp"},{"line_number":28,"context_line":"    $ZUUL_CLONER --cache-dir \\"},{"line_number":29,"context_line":"        /opt/git \\"}],"source_content_type":"text/x-sh","patch_set":4,"id":"7a5de9d1_9f38f63e","line":26,"updated":"2016-01-29 21:11:17.000000000","message":"Use please pushd and popd, or run this code inside ()","commit_id":"1f154d2d68fe0c4641c28ec16797c90f7418bd24"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"0273b3ec9ba131a0defd0dd9b7a3dabd79753d9a","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    echo \"Tempest already installed; using existing package\""},{"line_number":24,"context_line":"elif [ -x \"$ZUUL_CLONER\" ]; then"},{"line_number":25,"context_line":"    export ZUUL_BRANCH\u003d${ZUUL_BRANCH-$BRANCH}"},{"line_number":26,"context_line":"    cwd\u003d$(/bin/pwd)"},{"line_number":27,"context_line":"    cd /tmp"},{"line_number":28,"context_line":"    $ZUUL_CLONER --cache-dir \\"},{"line_number":29,"context_line":"        /opt/git \\"}],"source_content_type":"text/x-sh","patch_set":4,"id":"7a5de9d1_55201d48","line":26,"in_reply_to":"7a5de9d1_9f38f63e","updated":"2016-01-29 21:52:13.000000000","message":"Skipping in favor of your idea below.","commit_id":"1f154d2d68fe0c4641c28ec16797c90f7418bd24"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"42540aceb08e436a2267bd6c8779f110074ee9fc","unresolved":false,"context_lines":[{"line_number":24,"context_line":"elif [ -x \"$ZUUL_CLONER\" ]; then"},{"line_number":25,"context_line":"    export ZUUL_BRANCH\u003d${ZUUL_BRANCH-$BRANCH}"},{"line_number":26,"context_line":"    cwd\u003d$(/bin/pwd)"},{"line_number":27,"context_line":"    cd /tmp"},{"line_number":28,"context_line":"    $ZUUL_CLONER --cache-dir \\"},{"line_number":29,"context_line":"        /opt/git \\"},{"line_number":30,"context_line":"        git://git.openstack.org \\"}],"source_content_type":"text/x-sh","patch_set":4,"id":"7a5de9d1_ff1ecab9","line":27,"updated":"2016-01-29 21:11:17.000000000","message":"The folder you are cloning into could already exists. Pleas create a temporary folder using mktmp and do it inside that folder.","commit_id":"1f154d2d68fe0c4641c28ec16797c90f7418bd24"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"0273b3ec9ba131a0defd0dd9b7a3dabd79753d9a","unresolved":false,"context_lines":[{"line_number":24,"context_line":"elif [ -x \"$ZUUL_CLONER\" ]; then"},{"line_number":25,"context_line":"    export ZUUL_BRANCH\u003d${ZUUL_BRANCH-$BRANCH}"},{"line_number":26,"context_line":"    cwd\u003d$(/bin/pwd)"},{"line_number":27,"context_line":"    cd /tmp"},{"line_number":28,"context_line":"    $ZUUL_CLONER --cache-dir \\"},{"line_number":29,"context_line":"        /opt/git \\"},{"line_number":30,"context_line":"        git://git.openstack.org \\"}],"source_content_type":"text/x-sh","patch_set":4,"id":"7a5de9d1_15686586","line":27,"in_reply_to":"7a5de9d1_ff1ecab9","updated":"2016-01-29 21:52:13.000000000","message":"Single use infra slaves; it cannot exist, and this code path is used nowhere else.","commit_id":"1f154d2d68fe0c4641c28ec16797c90f7418bd24"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"42540aceb08e436a2267bd6c8779f110074ee9fc","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        git://git.openstack.org \\"},{"line_number":31,"context_line":"        openstack/tempest"},{"line_number":32,"context_line":"    cd openstack/tempest"},{"line_number":33,"context_line":"    pip install -e ."},{"line_number":34,"context_line":"    cd \"$cwd\""},{"line_number":35,"context_line":"else"},{"line_number":36,"context_line":"    pip install -U -egit+https://git.openstack.org/openstack/tempest#egg\u003dtempest"}],"source_content_type":"text/x-sh","patch_set":4,"id":"7a5de9d1_1f4ac6ac","line":33,"updated":"2016-01-29 21:11:17.000000000","message":"Instead of changing directory replace . with the name of the directory.","commit_id":"1f154d2d68fe0c4641c28ec16797c90f7418bd24"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"0273b3ec9ba131a0defd0dd9b7a3dabd79753d9a","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        git://git.openstack.org \\"},{"line_number":31,"context_line":"        openstack/tempest"},{"line_number":32,"context_line":"    cd openstack/tempest"},{"line_number":33,"context_line":"    pip install -e ."},{"line_number":34,"context_line":"    cd \"$cwd\""},{"line_number":35,"context_line":"else"},{"line_number":36,"context_line":"    pip install -U -egit+https://git.openstack.org/openstack/tempest#egg\u003dtempest"}],"source_content_type":"text/x-sh","patch_set":4,"id":"7a5de9d1_95121508","line":33,"in_reply_to":"7a5de9d1_1f4ac6ac","updated":"2016-01-29 21:52:13.000000000","message":"Good idea.","commit_id":"1f154d2d68fe0c4641c28ec16797c90f7418bd24"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"42540aceb08e436a2267bd6c8779f110074ee9fc","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    pip install -U -egit+https://git.openstack.org/openstack/tempest#egg\u003dtempest"},{"line_number":37,"context_line":"fi"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"pip install -U $*"},{"line_number":40,"context_line":"exit $?"}],"source_content_type":"text/x-sh","patch_set":4,"id":"7a5de9d1_5fb03e8a","line":39,"updated":"2016-01-29 21:11:17.000000000","message":"-U by default?","commit_id":"1f154d2d68fe0c4641c28ec16797c90f7418bd24"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"0273b3ec9ba131a0defd0dd9b7a3dabd79753d9a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    pip install -U -egit+https://git.openstack.org/openstack/tempest#egg\u003dtempest"},{"line_number":37,"context_line":"fi"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"pip install -U $*"},{"line_number":40,"context_line":"exit $?"}],"source_content_type":"text/x-sh","patch_set":4,"id":"7a5de9d1_15ff05ab","line":39,"in_reply_to":"7a5de9d1_5fb03e8a","updated":"2016-01-29 21:52:13.000000000","message":"it\u0027s a transparent pass-through from the old code in tox.ini, which was -U.","commit_id":"1f154d2d68fe0c4641c28ec16797c90f7418bd24"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"42540aceb08e436a2267bd6c8779f110074ee9fc","unresolved":false,"context_lines":[{"line_number":37,"context_line":"fi"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"pip install -U $*"},{"line_number":40,"context_line":"exit $?"}],"source_content_type":"text/x-sh","patch_set":4,"id":"7a5de9d1_5f77ded2","line":40,"updated":"2016-01-29 21:11:17.000000000","message":"You have -e active, this shouldn\u0027t be necessary","commit_id":"1f154d2d68fe0c4641c28ec16797c90f7418bd24"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"0273b3ec9ba131a0defd0dd9b7a3dabd79753d9a","unresolved":false,"context_lines":[{"line_number":37,"context_line":"fi"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"pip install -U $*"},{"line_number":40,"context_line":"exit $?"}],"source_content_type":"text/x-sh","patch_set":4,"id":"7a5de9d1_d533ada9","line":40,"in_reply_to":"7a5de9d1_5f77ded2","updated":"2016-01-29 21:52:13.000000000","message":"Indeed.","commit_id":"1f154d2d68fe0c4641c28ec16797c90f7418bd24"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"6cdabeee7fd2a773bd3f61c4428fd9cfaaa736b6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/sh"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Many of neutron\u0027s repos suffer from the problem of depending on neutron,"},{"line_number":4,"context_line":"# but it not existing on pypi. -- Well, that\u0027s the usual issue, but in"}],"source_content_type":"text/x-sh","patch_set":5,"id":"7a5de9d1_54f01891","line":1,"updated":"2016-01-30 07:26:20.000000000","message":"/bin/sh is not the same in all systems, while /bin/bash \"probably\" is.","commit_id":"941d397cfba1c2cdd9aabc6648d7fbdfda8ba61c"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"6cdabeee7fd2a773bd3f61c4428fd9cfaaa736b6","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# pip install {opts} {packages}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"ZUUL_CLONER\u003d/usr/zuul-env/bin/zuul-cloner"},{"line_number":18,"context_line":"tempest_installed\u003d$(echo \"import tempest\" | python 2\u003e/dev/null ; echo $?)"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"set -e"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"7a5de9d1_f484a40b","line":18,"range":{"start_line":18,"start_character":44,"end_line":18,"end_character":50},"updated":"2016-01-30 07:26:20.000000000","message":"Please at least replace this part:\n\n  tempest_installed\u003d$(python -c \u0027import tempest\u0027 2\u003e /dev/null; echo $?)","commit_id":"941d397cfba1c2cdd9aabc6648d7fbdfda8ba61c"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"6cdabeee7fd2a773bd3f61c4428fd9cfaaa736b6","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        /opt/git \\"},{"line_number":28,"context_line":"        git://git.openstack.org \\"},{"line_number":29,"context_line":"        openstack/tempest"},{"line_number":30,"context_line":"    cd openstack/tempest"},{"line_number":31,"context_line":"    pip install -e openstack/tempest"},{"line_number":32,"context_line":"else"},{"line_number":33,"context_line":"    pip install -U -egit+https://git.openstack.org/openstack/tempest#egg\u003dtempest"}],"source_content_type":"text/x-sh","patch_set":5,"id":"7a5de9d1_34c1dc54","line":30,"updated":"2016-01-30 07:26:20.000000000","message":"Is zool cloner creating folder openstack/tempest inside ./openstack/tempest?","commit_id":"941d397cfba1c2cdd9aabc6648d7fbdfda8ba61c"},{"author":{"_account_id":17377,"name":"Federico Ressi","email":"federico.ressi@intel.com","username":"fressi"},"change_message_id":"6cdabeee7fd2a773bd3f61c4428fd9cfaaa736b6","unresolved":false,"context_lines":[{"line_number":34,"context_line":"fi"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"pip install -U $*"},{"line_number":37,"context_line":"exit $?"}],"source_content_type":"text/x-sh","patch_set":5,"id":"7a5de9d1_f4e904b8","line":37,"updated":"2016-01-30 07:26:20.000000000","message":"This line makes no difference: it is after the last command and -e is active","commit_id":"941d397cfba1c2cdd9aabc6648d7fbdfda8ba61c"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"32fb498183f21bbbc1d7cf4ce4ba02213045e1a0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Many of neutron\u0027s repos suffer from the problem of depending on neutron,"},{"line_number":4,"context_line":"# but it not existing on pypi. -- Well, that\u0027s the usual issue, but in"},{"line_number":5,"context_line":"# neutron\u0027s case, we want to import tempest directly for the api tests."},{"line_number":6,"context_line":""}],"source_content_type":"text/x-sh","patch_set":11,"id":"5a5ae5dd_13f66ad7","line":3,"updated":"2016-02-04 19:38:03.000000000","message":"you still missed this but ok","commit_id":"828068181c224bfd67cb6276f20e1644bcc7060c"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"32fb498183f21bbbc1d7cf4ce4ba02213045e1a0","unresolved":false,"context_lines":[{"line_number":22,"context_line":"if [ $tempest_installed -eq 0 ]; then"},{"line_number":23,"context_line":"    echo \"Tempest already installed; using existing package\""},{"line_number":24,"context_line":"elif [ -x \"$ZUUL_CLONER\" ]; then"},{"line_number":25,"context_line":"    export ZUUL_BRANCH\u003d${ZUUL_BRANCH-$BRANCH}"},{"line_number":26,"context_line":"    pushd /tmp"},{"line_number":27,"context_line":"    $ZUUL_CLONER --cache-dir \\"},{"line_number":28,"context_line":"        /opt/git \\"}],"source_content_type":"text/x-sh","patch_set":11,"id":"5a5ae5dd_93d7ba22","line":25,"updated":"2016-02-04 19:38:03.000000000","message":"Do we need this knowing that tempest is branchless? Just idle curiosity","commit_id":"828068181c224bfd67cb6276f20e1644bcc7060c"}],"tox.ini":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"1b2ce6e21290f6a80e910f1a5d3e7998f437a381","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                  constraints: {[testenv:common-constraints]install_command}"},{"line_number":31,"context_line":"                  {toxinidir}/tools/tox_install.sh {opts} {packages}"},{"line_number":32,"context_line":"deps \u003d"},{"line_number":33,"context_line":"  {[testenv]deps}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"[testenv:api-constraints]"},{"line_number":36,"context_line":"basepython \u003d {[testenv:api]basepython}"}],"source_content_type":"text/x-properties","patch_set":2,"id":"7a5de9d1_5e6cc7cf","line":33,"updated":"2016-01-29 18:05:02.000000000","message":"You can delete this now.","commit_id":"f42097445350729b7ac8f07b74684711070854a7"}]}
