)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"a2895bc0f5ac481caa9a3b9975d8b2cb94bbffb5","unresolved":false,"context_lines":[{"line_number":11,"context_line":"port."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"There is no need to check for the agent gateway port since"},{"line_number":14,"context_line":"there is no caller calling this function to get the hostid"},{"line_number":15,"context_line":"of the agent_gateway_port."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This might be a left over from the previous cycle cleanup."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a57f1b5_91f38273","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":25},"updated":"2016-02-10 09:54:40.000000000","message":"is there any caller passing non-dvr serviced port there? Do we really need this method?","commit_id":"91d6417a2af0dde14185e79e9765e2b80cd74c7a"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"5da1235c5b3a3dfabb4d3f70b09217eee126d80c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"port."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"There is no need to check for the agent gateway port since"},{"line_number":14,"context_line":"there is no caller calling this function to get the hostid"},{"line_number":15,"context_line":"of the agent_gateway_port."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This might be a left over from the previous cycle cleanup."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bae84128_4245b540","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":25},"in_reply_to":"3a57f1b5_91f38273","updated":"2016-02-24 17:21:48.000000000","message":"no.\n\nYes we still need this method.","commit_id":"91d6417a2af0dde14185e79e9765e2b80cd74c7a"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"1ddeaff573f399671ac1c5798cf544d89558886a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"port."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"There is no need to check for the agent gateway port since"},{"line_number":14,"context_line":"there is no caller calling this function to get the hostid"},{"line_number":15,"context_line":"of the agent_gateway_port."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This might be a left over from the previous cycle cleanup."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9aed3d3a_c934804b","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":25},"in_reply_to":"9aed3d3a_636becf1","updated":"2016-03-01 06:18:12.000000000","message":"Hi, Swami. \"it reduces some code duplication where we get the port details\", do you mean:\n\n  port_db \u003d port or self._core_plugin.get_port(context, port_id)\nif yes, I think it is still valid to keep this method.\n\n\nAnd to allowed-address-pair port case, would you mind to share some details, or some steps to produce that case?","commit_id":"91d6417a2af0dde14185e79e9765e2b80cd74c7a"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"5de16adfa5c01a9899c16ff68fe0a94681965d6e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"port."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"There is no need to check for the agent gateway port since"},{"line_number":14,"context_line":"there is no caller calling this function to get the hostid"},{"line_number":15,"context_line":"of the agent_gateway_port."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This might be a left over from the previous cycle cleanup."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7af24918_a2d8cff0","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":25},"in_reply_to":"9aed3d3a_c934804b","updated":"2016-03-01 20:50:09.000000000","message":"When we assign a \u0027Floating-ip\u0027 to an \u0027allowed-address-pair\u0027, the \u0027allowed-address-pair\u0027 port does not have any associated \u0027device-owner\u0027 or neither is a dvr-serviceable port.\nSo it is a valid check in here to make sure if the given port is a dvr-serviceable port or not.","commit_id":"91d6417a2af0dde14185e79e9765e2b80cd74c7a"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"011bed4ca7263554d0cb129a4d070d9912b4c9b8","unresolved":false,"context_lines":[{"line_number":11,"context_line":"port."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"There is no need to check for the agent gateway port since"},{"line_number":14,"context_line":"there is no caller calling this function to get the hostid"},{"line_number":15,"context_line":"of the agent_gateway_port."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This might be a left over from the previous cycle cleanup."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9aed3d3a_033820ee","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":25},"in_reply_to":"9aed3d3a_f5c24033","updated":"2016-02-29 19:20:39.000000000","message":"Yes I forgot to mention that there is a non-dvr allowed-address-pair port that can be associated with a fip.","commit_id":"91d6417a2af0dde14185e79e9765e2b80cd74c7a"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"51b94c2305f4e52ecce1188c84d025764ed3f29a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"port."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"There is no need to check for the agent gateway port since"},{"line_number":14,"context_line":"there is no caller calling this function to get the hostid"},{"line_number":15,"context_line":"of the agent_gateway_port."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This might be a left over from the previous cycle cleanup."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bae84128_650420c6","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":25},"in_reply_to":"bae84128_4245b540","updated":"2016-02-25 07:46:07.000000000","message":"So my question is why do we need this method if there is no callers passing non-dvr ports to it, isn\u0027t it a redundant check then?","commit_id":"91d6417a2af0dde14185e79e9765e2b80cd74c7a"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"aa12e9332bfde546e1fbe6cf1c809b7c9df94dd6","unresolved":false,"context_lines":[{"line_number":11,"context_line":"port."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"There is no need to check for the agent gateway port since"},{"line_number":14,"context_line":"there is no caller calling this function to get the hostid"},{"line_number":15,"context_line":"of the agent_gateway_port."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This might be a left over from the previous cycle cleanup."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9aed3d3a_f5c24033","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":25},"in_reply_to":"bae84128_650420c6","updated":"2016-02-29 02:19:27.000000000","message":"I agree with Oleg. All this method callers are passing it fixed port id/fixed port which associated with floatingip in DVR router case, so checking dvr serviced device_owner is redundant.","commit_id":"91d6417a2af0dde14185e79e9765e2b80cd74c7a"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"b30283f3c9d39a9b9a9157d5b8a44b503688baae","unresolved":false,"context_lines":[{"line_number":11,"context_line":"port."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"There is no need to check for the agent gateway port since"},{"line_number":14,"context_line":"there is no caller calling this function to get the hostid"},{"line_number":15,"context_line":"of the agent_gateway_port."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This might be a left over from the previous cycle cleanup."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9aed3d3a_a015ea40","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":25},"in_reply_to":"bae84128_650420c6","updated":"2016-02-29 18:54:16.000000000","message":"Oleg and ZongKai Li, this call is being called when fip association occurs or when fip_change occurs.\nWe know that there is a fixed port associated with the fip and it is part of the dvr router, but here this function is basically returning the hostid of the fixed port if it is a dvr service port.\n\nWe can argue that only the list of device owners in the dvr serviceable ports list will eventually associate a fip ( LBaaS, compute etc.,).\n\nI that case we can remove the redundant check for the \"dvr_serviceable_ports\" in here.\nBut this function is still valid since it reduces some code duplication were we get the port_details.\n\nAm I missing something here?","commit_id":"91d6417a2af0dde14185e79e9765e2b80cd74c7a"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"011bed4ca7263554d0cb129a4d070d9912b4c9b8","unresolved":false,"context_lines":[{"line_number":11,"context_line":"port."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"There is no need to check for the agent gateway port since"},{"line_number":14,"context_line":"there is no caller calling this function to get the hostid"},{"line_number":15,"context_line":"of the agent_gateway_port."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This might be a left over from the previous cycle cleanup."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9aed3d3a_636becf1","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":25},"in_reply_to":"bae84128_650420c6","updated":"2016-02-29 19:20:39.000000000","message":"There is one call that I can think of that is a non-dvr port with no device_owner that calls this function.\n\"Allowed-address-pairs\". If you assign an allowed-address-pair to a floating-ip.","commit_id":"91d6417a2af0dde14185e79e9765e2b80cd74c7a"}],"neutron/db/l3_dvr_db.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"89189d4836350d62e1efadd022376045c35b98ff","unresolved":false,"context_lines":[{"line_number":521,"context_line":"        \"\"\"Returns the portbinding host_id for dvr service port.\"\"\""},{"line_number":522,"context_line":"        port_db \u003d port or self._core_plugin.get_port(context, port_id)"},{"line_number":523,"context_line":"        device_owner \u003d port_db[\u0027device_owner\u0027] if port_db else \"\""},{"line_number":524,"context_line":"        if (n_utils.is_dvr_serviced(device_owner)):"},{"line_number":525,"context_line":"            return port_db[portbindings.HOST_ID]"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"    def _get_agent_gw_ports_exist_for_network("}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_6107f61c","line":524,"updated":"2016-02-04 02:45:16.000000000","message":"nit: you can remove the () here now","commit_id":"91d6417a2af0dde14185e79e9765e2b80cd74c7a"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"5da1235c5b3a3dfabb4d3f70b09217eee126d80c","unresolved":false,"context_lines":[{"line_number":521,"context_line":"        \"\"\"Returns the portbinding host_id for dvr service port.\"\"\""},{"line_number":522,"context_line":"        port_db \u003d port or self._core_plugin.get_port(context, port_id)"},{"line_number":523,"context_line":"        device_owner \u003d port_db[\u0027device_owner\u0027] if port_db else \"\""},{"line_number":524,"context_line":"        if (n_utils.is_dvr_serviced(device_owner)):"},{"line_number":525,"context_line":"            return port_db[portbindings.HOST_ID]"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"    def _get_agent_gw_ports_exist_for_network("}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_226b51b8","line":524,"in_reply_to":"5a5ae5dd_6107f61c","updated":"2016-02-24 17:21:48.000000000","message":"Done","commit_id":"91d6417a2af0dde14185e79e9765e2b80cd74c7a"}]}
