)]}'
{"quantum/db/agentschedulers_db.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"c9dcaf442c4d17404f513b41a45c0d670f822239","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        if active is not None:"},{"line_number":78,"context_line":"            query \u003d (query.filter(agents_db.Agent.admin_state_up \u003d\u003d active))"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        is_down \u003d agents_db.AgentDbMixin.is_agent_down"},{"line_number":81,"context_line":"        return ["},{"line_number":82,"context_line":"            binding.dhcp_agent"},{"line_number":83,"context_line":"            for binding in query"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Ftts%3D","line":80,"updated":"2013-04-26 15:13:51.000000000","message":"the change looks a little bit tricky, probably should be simplified. But I\u0027m ok with that until someone else finds this tricky too :)","commit_id":"e7abbe413df92ae95e5354bd3d0366c0f6bb504c"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"5af61cfcba09a604a39d39483e082f7d273ecc42","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        if active is not None:"},{"line_number":78,"context_line":"            query \u003d (query.filter(agents_db.Agent.admin_state_up \u003d\u003d active))"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        is_down \u003d agents_db.AgentDbMixin.is_agent_down"},{"line_number":81,"context_line":"        return ["},{"line_number":82,"context_line":"            binding.dhcp_agent"},{"line_number":83,"context_line":"            for binding in query"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fr2g%3D","line":80,"in_reply_to":"AAAAOn%2F%2FtBA%3D","updated":"2013-04-29 07:25:40.000000000","message":"I\u0027ve made it more clear in the new patch set.","commit_id":"e7abbe413df92ae95e5354bd3d0366c0f6bb504c"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":77,"context_line":"        if active is not None:"},{"line_number":78,"context_line":"            query \u003d (query.filter(agents_db.Agent.admin_state_up \u003d\u003d active))"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        is_down \u003d agents_db.AgentDbMixin.is_agent_down"},{"line_number":81,"context_line":"        return ["},{"line_number":82,"context_line":"            binding.dhcp_agent"},{"line_number":83,"context_line":"            for binding in query"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FtBA%3D","line":80,"in_reply_to":"AAAAOn%2F%2FtXQ%3D","updated":"2013-04-26 21:41:36.000000000","message":"May be we should use helper function such as is_attribute_set.\nis_down is function, so I prefere is_down_func","commit_id":"e7abbe413df92ae95e5354bd3d0366c0f6bb504c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":77,"context_line":"        if active is not None:"},{"line_number":78,"context_line":"            query \u003d (query.filter(agents_db.Agent.admin_state_up \u003d\u003d active))"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        is_down \u003d agents_db.AgentDbMixin.is_agent_down"},{"line_number":81,"context_line":"        return ["},{"line_number":82,"context_line":"            binding.dhcp_agent"},{"line_number":83,"context_line":"            for binding in query"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FtXQ%3D","line":80,"in_reply_to":"AAAAOn%2F%2Ftts%3D","updated":"2013-04-26 18:18:24.000000000","message":"I felt a little tricky too. I am not sure it is same as Oleg\u0027s.\n\nThe point I felt so is L.84. \"active is None\" is not easy to understand to me at a glance. \"active is None\" means disabling filter by admin_state_up value, i.e. returns all. If we have better name instead of \"active\", the logic becomes easire to understand without changing the code itself.","commit_id":"e7abbe413df92ae95e5354bd3d0366c0f6bb504c"}],"quantum/plugins/openvswitch/ovs_db_v2.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":352,"context_line":"        raise q_exc.PortNotFound(port_id\u003dport_id)"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"def get_tunnel_endpoints():"},{"line_number":356,"context_line":"    session \u003d db.get_session()"},{"line_number":357,"context_line":"    tunnels \u003d session.query(ovs_models_v2.TunnelEndpoint)"},{"line_number":358,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FsQw%3D","line":355,"updated":"2013-04-28 05:48:13.000000000","message":"At the moment there is no test case for this method. Can you please add one. I was a bit concerned that the change did not treat the exception.","commit_id":"e7abbe413df92ae95e5354bd3d0366c0f6bb504c"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"5af61cfcba09a604a39d39483e082f7d273ecc42","unresolved":false,"context_lines":[{"line_number":352,"context_line":"        raise q_exc.PortNotFound(port_id\u003dport_id)"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"def get_tunnel_endpoints():"},{"line_number":356,"context_line":"    session \u003d db.get_session()"},{"line_number":357,"context_line":"    tunnels \u003d session.query(ovs_models_v2.TunnelEndpoint)"},{"line_number":358,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FsPw%3D","line":355,"in_reply_to":"AAAAOn%2F%2FsQw%3D","updated":"2013-04-29 07:25:40.000000000","message":"Garry, the truth is that all() can\u0027t raise a NoResultFound exception, so this except statement was completely useless.\n\nI\u0027m going to fix this and all similar issues by uploading a patch for this bug https://bugs.launchpad.net/quantum/+bug/1173131.","commit_id":"e7abbe413df92ae95e5354bd3d0366c0f6bb504c"}]}
