)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"bfcb7352bc1725ddc798d2bbe0fa25e2188d4626","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"OVS acceleration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: #1627987"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I77650be5f04775a72e2bdf694f93988825a84b72"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"ba5201f7_05999d1f","line":9,"updated":"2017-01-03 15:39:05.000000000","message":"developer and user documentation, plus release notes would be highly appreciated for this one.","commit_id":"515821e169509be3d6dcfded54b4a4ab26e89426"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"59a231e630a2405b3b50c6da693e0a82357808a8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"HW offload support for openvswitch"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch allow OVS mech driver to bind direct (SR-IOV) port."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: #1627987"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"ba2be162_6b487288","line":9,"updated":"2017-03-01 22:04:27.000000000","message":"Can you add some more details here?","commit_id":"8a591d394cd4c39f81bd54c34c89e666955ae592"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"4afc745d86a03a817affd9c44ce2bb90b992f4ad","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch allow OVS mech driver to bind direct (SR-IOV) port."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: #1627987"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I77650be5f04775a72e2bdf694f93988825a84b72"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"1a430d35_cc4d67c5","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":20},"updated":"2017-02-09 02:00:57.000000000","message":"I think that this feature needs other patches too(e.g. agent side) so it\u0027s better to use \"Partial-Bug: #1627987\".","commit_id":"8a591d394cd4c39f81bd54c34c89e666955ae592"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"662e8262525eb2fb08d6e92dc97fc2ef01a3e42e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"HW offload support for openvswitch"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In Kerenl 4.8 we intreduce TC HW offloads framework"},{"line_number":10,"context_line":"for SR-IOV VF  which allow to configure the NIC. [1]"},{"line_number":11,"context_line":"The OVS patces which allow to use the TC framework in kenrel."},{"line_number":12,"context_line":"to offload ovs datapath rules. [2]"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"3a1ff146_b482b350","line":9,"range":{"start_line":9,"start_character":3,"end_line":9,"end_character":9},"updated":"2017-03-16 11:27:46.000000000","message":"Kernel","commit_id":"70bb5157beff879ded54b9250e7087072204f949"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"662e8262525eb2fb08d6e92dc97fc2ef01a3e42e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"HW offload support for openvswitch"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In Kerenl 4.8 we intreduce TC HW offloads framework"},{"line_number":10,"context_line":"for SR-IOV VF  which allow to configure the NIC. [1]"},{"line_number":11,"context_line":"The OVS patces which allow to use the TC framework in kenrel."},{"line_number":12,"context_line":"to offload ovs datapath rules. [2]"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"3a1ff146_3497a391","line":9,"range":{"start_line":9,"start_character":17,"end_line":9,"end_character":26},"updated":"2017-03-16 11:27:46.000000000","message":"introduced","commit_id":"70bb5157beff879ded54b9250e7087072204f949"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"18f91c486fd76e8e51e66c068f00d139f656bb39","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"HW offload support for openvswitch"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In Kerenl 4.8 we intreduce TC HW offloads framework"},{"line_number":10,"context_line":"for SR-IOV VF  which allow to configure the NIC. [1]"},{"line_number":11,"context_line":"The OVS patces which allow to use the TC framework in kenrel."},{"line_number":12,"context_line":"to offload ovs datapath rules. [2]"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"3a1ff146_6f6dc897","line":9,"range":{"start_line":9,"start_character":17,"end_line":9,"end_character":26},"in_reply_to":"3a1ff146_3497a391","updated":"2017-03-16 14:34:17.000000000","message":"Done","commit_id":"70bb5157beff879ded54b9250e7087072204f949"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"18f91c486fd76e8e51e66c068f00d139f656bb39","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"HW offload support for openvswitch"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In Kerenl 4.8 we intreduce TC HW offloads framework"},{"line_number":10,"context_line":"for SR-IOV VF  which allow to configure the NIC. [1]"},{"line_number":11,"context_line":"The OVS patces which allow to use the TC framework in kenrel."},{"line_number":12,"context_line":"to offload ovs datapath rules. [2]"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"3a1ff146_af0500c3","line":9,"range":{"start_line":9,"start_character":3,"end_line":9,"end_character":9},"in_reply_to":"3a1ff146_b482b350","updated":"2017-03-16 14:34:17.000000000","message":"Done","commit_id":"70bb5157beff879ded54b9250e7087072204f949"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"662e8262525eb2fb08d6e92dc97fc2ef01a3e42e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"HW offload support for openvswitch"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In Kerenl 4.8 we intreduce TC HW offloads framework"},{"line_number":10,"context_line":"for SR-IOV VF  which allow to configure the NIC. [1]"},{"line_number":11,"context_line":"The OVS patces which allow to use the TC framework in kenrel."},{"line_number":12,"context_line":"to offload ovs datapath rules. [2]"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"3a1ff146_b4e9d31c","line":10,"range":{"start_line":10,"start_character":13,"end_line":10,"end_character":14},"updated":"2017-03-16 11:27:46.000000000","message":"remove space","commit_id":"70bb5157beff879ded54b9250e7087072204f949"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"18f91c486fd76e8e51e66c068f00d139f656bb39","unresolved":false,"context_lines":[{"line_number":7,"context_line":"HW offload support for openvswitch"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In Kerenl 4.8 we intreduce TC HW offloads framework"},{"line_number":10,"context_line":"for SR-IOV VF  which allow to configure the NIC. [1]"},{"line_number":11,"context_line":"The OVS patces which allow to use the TC framework in kenrel."},{"line_number":12,"context_line":"to offload ovs datapath rules. [2]"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"3a1ff146_ef261867","line":10,"range":{"start_line":10,"start_character":13,"end_line":10,"end_character":14},"in_reply_to":"3a1ff146_b4e9d31c","updated":"2017-03-16 14:34:17.000000000","message":"Done","commit_id":"70bb5157beff879ded54b9250e7087072204f949"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"662e8262525eb2fb08d6e92dc97fc2ef01a3e42e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In Kerenl 4.8 we intreduce TC HW offloads framework"},{"line_number":10,"context_line":"for SR-IOV VF  which allow to configure the NIC. [1]"},{"line_number":11,"context_line":"The OVS patces which allow to use the TC framework in kenrel."},{"line_number":12,"context_line":"to offload ovs datapath rules. [2]"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch allow OVS mech driver to bind direct (SR-IOV) port."},{"line_number":15,"context_line":"This will allow to offload the ovs flows using tc to the SR-IOV NIC"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"3a1ff146_74567bd3","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":34},"updated":"2017-03-16 11:27:46.000000000","message":"Can you rephrase it? Like \"these are the OVS patches to....\" or \"reference to OVS patches to....\"","commit_id":"70bb5157beff879ded54b9250e7087072204f949"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"18f91c486fd76e8e51e66c068f00d139f656bb39","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In Kerenl 4.8 we intreduce TC HW offloads framework"},{"line_number":10,"context_line":"for SR-IOV VF  which allow to configure the NIC. [1]"},{"line_number":11,"context_line":"The OVS patces which allow to use the TC framework in kenrel."},{"line_number":12,"context_line":"to offload ovs datapath rules. [2]"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch allow OVS mech driver to bind direct (SR-IOV) port."},{"line_number":15,"context_line":"This will allow to offload the ovs flows using tc to the SR-IOV NIC"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"3a1ff146_af88a023","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":34},"in_reply_to":"3a1ff146_74567bd3","updated":"2017-03-16 14:34:17.000000000","message":"Done","commit_id":"70bb5157beff879ded54b9250e7087072204f949"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"662e8262525eb2fb08d6e92dc97fc2ef01a3e42e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"to offload ovs datapath rules. [2]"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch allow OVS mech driver to bind direct (SR-IOV) port."},{"line_number":15,"context_line":"This will allow to offload the ovs flows using tc to the SR-IOV NIC"},{"line_number":16,"context_line":"and gain accelerate OVS."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1] http://netdevconf.org/1.2/papers/efraim-gerlitz-sriov-ovs-final.pdf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"3a1ff146_746d9b97","line":15,"range":{"start_line":15,"start_character":31,"end_line":15,"end_character":34},"updated":"2017-03-16 11:27:46.000000000","message":"In capital letters, to be consistent.","commit_id":"70bb5157beff879ded54b9250e7087072204f949"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"18f91c486fd76e8e51e66c068f00d139f656bb39","unresolved":false,"context_lines":[{"line_number":12,"context_line":"to offload ovs datapath rules. [2]"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch allow OVS mech driver to bind direct (SR-IOV) port."},{"line_number":15,"context_line":"This will allow to offload the ovs flows using tc to the SR-IOV NIC"},{"line_number":16,"context_line":"and gain accelerate OVS."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1] http://netdevconf.org/1.2/papers/efraim-gerlitz-sriov-ovs-final.pdf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"3a1ff146_2f7d901c","line":15,"range":{"start_line":15,"start_character":31,"end_line":15,"end_character":34},"in_reply_to":"3a1ff146_746d9b97","updated":"2017-03-16 14:34:17.000000000","message":"Done","commit_id":"70bb5157beff879ded54b9250e7087072204f949"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"662e8262525eb2fb08d6e92dc97fc2ef01a3e42e","unresolved":false,"context_lines":[{"line_number":18,"context_line":"[1] http://netdevconf.org/1.2/papers/efraim-gerlitz-sriov-ovs-final.pdf"},{"line_number":19,"context_line":"[2] https://patchwork.ozlabs.org/patch/738176/"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-Bug: #1627987"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I77650be5f04775a72e2bdf694f93988825a84b72"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"3a1ff146_54ab3fd6","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":20},"updated":"2017-03-16 11:27:46.000000000","message":"As Hirofumi said in PS11, this should be Partial-Bug","commit_id":"70bb5157beff879ded54b9250e7087072204f949"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"18f91c486fd76e8e51e66c068f00d139f656bb39","unresolved":false,"context_lines":[{"line_number":18,"context_line":"[1] http://netdevconf.org/1.2/papers/efraim-gerlitz-sriov-ovs-final.pdf"},{"line_number":19,"context_line":"[2] https://patchwork.ozlabs.org/patch/738176/"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-Bug: #1627987"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I77650be5f04775a72e2bdf694f93988825a84b72"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"3a1ff146_8f720448","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":20},"in_reply_to":"3a1ff146_54ab3fd6","updated":"2017-03-16 14:34:17.000000000","message":"Done","commit_id":"70bb5157beff879ded54b9250e7087072204f949"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"cf5588c0f06b872ee2f765065586e227523a844b","unresolved":false,"context_lines":[{"line_number":18,"context_line":"[1] https://linux.die.net/man/8/tc"},{"line_number":19,"context_line":"[2] http://netdevconf.org/1.2/papers/efraim-gerlitz-sriov-ovs-final.pdf"},{"line_number":20,"context_line":"[3] https://mail.openvswitch.org/pipermail/ovs-dev/2017-April/330606.html"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Partial-Bug: #1627987"},{"line_number":23,"context_line":"Depends-On: I41c0a44ebe5e886c689de9fbd7fadb9cb549dc68"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"3f1d235d_5531b8eb","line":21,"updated":"2017-07-03 19:51:48.000000000","message":"the change definitely needs a release note.\n\nAlso add DocImpact here so that we can document the new feature.\n\nWe should also have agent side included in the patch.","commit_id":"e84012eeb688d0ba59feaca9f753158ed53a4e10"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3604d966399f67a6aba8a126c666c1b4ea0b9b47","unresolved":false,"context_lines":[{"line_number":18,"context_line":"[1] https://linux.die.net/man/8/tc"},{"line_number":19,"context_line":"[2] http://netdevconf.org/1.2/papers/efraim-gerlitz-sriov-ovs-final.pdf"},{"line_number":20,"context_line":"[3] https://mail.openvswitch.org/pipermail/ovs-dev/2017-April/330606.html"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Partial-Bug: #1627987"},{"line_number":23,"context_line":"Depends-On: I41c0a44ebe5e886c689de9fbd7fadb9cb549dc68"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"3f1d235d_f500c469","line":21,"in_reply_to":"3f1d235d_5531b8eb","updated":"2017-07-03 19:55:30.000000000","message":"Sorry, disregard the last sentence, afaiu there is no need for an agent side change here because the representor device will behave identically from the PoV of the agent.","commit_id":"e84012eeb688d0ba59feaca9f753158ed53a4e10"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"505de4ee4659b12b0d6099c372587ea1505767fc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Moshe Levi \u003cmoshele@mellanox.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-07-06 07:45:52 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"hardware offload support for openvswitch"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In Kernel 4.8 we introduced Traffic Control (TC see [1]) hardware offloads"},{"line_number":10,"context_line":"framework for SR-IOV VFs which allows us to configure the NIC [2]."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"3f1d235d_7ab66a8c","line":7,"updated":"2017-07-06 21:57:44.000000000","message":"this patch reminds of [1]. Shouldn\u0027t we add a new value to [2]?\n\n[1] https://review.openstack.org/#/c/237264/19/neutron/plugins/ml2/drivers/openvswitch/agent/common/config.py\n[2] https://review.openstack.org/#/c/237264/19/neutron/plugins/ml2/drivers/openvswitch/agent/common/config.py@56","commit_id":"9beb13e0af7c3725ea6a23c4ff4fa0787223694a"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"57945c9846a8d2a0c856ad8911bf7f9198c62160","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Moshe Levi \u003cmoshele@mellanox.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-07-06 07:45:52 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"hardware offload support for openvswitch"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In Kernel 4.8 we introduced Traffic Control (TC see [1]) hardware offloads"},{"line_number":10,"context_line":"framework for SR-IOV VFs which allows us to configure the NIC [2]."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"3f1d235d_2d6c3ecc","line":7,"in_reply_to":"3f1d235d_7ab66a8c","updated":"2017-07-06 22:07:07.000000000","message":"sorry I meant:\n\nhttps://review.openstack.org/#/c/237264/19/neutron/plugins/ml2/drivers/openvswitch/agent/common/config.py@52","commit_id":"9beb13e0af7c3725ea6a23c4ff4fa0787223694a"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"505de4ee4659b12b0d6099c372587ea1505767fc","unresolved":false,"context_lines":[{"line_number":19,"context_line":"[2] http://netdevconf.org/1.2/papers/efraim-gerlitz-sriov-ovs-final.pdf"},{"line_number":20,"context_line":"[3] https://mail.openvswitch.org/pipermail/ovs-dev/2017-April/330606.html"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"DocImpact"},{"line_number":23,"context_line":"Partial-Bug: #1627987"},{"line_number":24,"context_line":"Depends-On: I41c0a44ebe5e886c689de9fbd7fadb9cb549dc68"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"3f1d235d_9a9a6611","line":22,"updated":"2017-07-06 21:57:44.000000000","message":"DocImpact takes one line description:\n\nDocImpact: Add SR-IOV offload support for OVS mech driver","commit_id":"9beb13e0af7c3725ea6a23c4ff4fa0787223694a"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"0cba79124f02356dc905e8886dda9972094c9ba7","unresolved":false,"context_lines":[{"line_number":19,"context_line":"[2] http://netdevconf.org/1.2/papers/efraim-gerlitz-sriov-ovs-final.pdf"},{"line_number":20,"context_line":"[3] https://mail.openvswitch.org/pipermail/ovs-dev/2017-April/330606.html"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"DocImpact"},{"line_number":23,"context_line":"Partial-Bug: #1627987"},{"line_number":24,"context_line":"Depends-On: I41c0a44ebe5e886c689de9fbd7fadb9cb549dc68"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"3f1d235d_615e8f46","line":22,"in_reply_to":"3f1d235d_9a9a6611","updated":"2017-07-09 08:34:17.000000000","message":"Done","commit_id":"9beb13e0af7c3725ea6a23c4ff4fa0787223694a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f6971da623720f7b089c94a3f0705e1932192aa5","unresolved":false,"context_lines":[{"line_number":19,"context_line":"[2] http://netdevconf.org/1.2/papers/efraim-gerlitz-sriov-ovs-final.pdf"},{"line_number":20,"context_line":"[3] https://mail.openvswitch.org/pipermail/ovs-dev/2017-April/330606.html"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"DocImpact: Add SR-IOV offload support for OVS mech driver"},{"line_number":23,"context_line":"Partial-Bug: #1627987"},{"line_number":24,"context_line":"Depends-On: I41c0a44ebe5e886c689de9fbd7fadb9cb549dc68"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"1f1a1f67_74a6cf55","line":22,"updated":"2017-07-17 16:18:54.000000000","message":"This change should depend on the patch that bumps the minimal version of neutron-lib to the one that includes the new vif type. Alternatively, you can just duplicate the literal value in the patch (with a todo comment to switch over to neutron-lib when it\u0027s released).","commit_id":"aeafecc2ef64023bd6c0243051a21f8e20b75644"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"28d38f640f4bdb9bbc91e7b9a0baa49f983ea5f5","unresolved":false,"context_lines":[{"line_number":22,"context_line":"DocImpact: Add SR-IOV offload support for OVS mech driver"},{"line_number":23,"context_line":"Partial-Bug: #1627987"},{"line_number":24,"context_line":"Depends-On: I41c0a44ebe5e886c689de9fbd7fadb9cb549dc68"},{"line_number":25,"context_line":"Depends-On: I19541b99bb4915170871018b9f7d41fcb37e214f"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Change-Id: I77650be5f04775a72e2bdf694f93988825a84b72"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":25,"id":"1f1a1f67_d762170a","line":25,"updated":"2017-07-18 18:39:22.000000000","message":"I think there is no official release that includes the new VIF type yet; we have the request up for review though: https://review.openstack.org/#/c/484475/ (note that you should NOT depends-on it because the dependency chain won\u0027t give you the intended version of the library in the gate; instead we should wait for the release and then update global requirements, and depends-on this openstack/requirements patch).","commit_id":"9ec9941f0d1a3163682ae0aa5489402f9aff3c1d"}],"neutron/plugins/ml2/drivers/openvswitch/mech_driver/mech_openvswitch.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"cf5588c0f06b872ee2f765065586e227523a844b","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            constants.AGENT_TYPE_OVS,"},{"line_number":55,"context_line":"            portbindings.VIF_TYPE_OVS,"},{"line_number":56,"context_line":"            vif_details, supported_vnic_types\u003d[portbindings.VNIC_NORMAL,"},{"line_number":57,"context_line":"                                               portbindings.VNIC_DIRECT])"},{"line_number":58,"context_line":"        ovs_qos_driver.register()"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def get_allowed_network_types(self, agent):"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f1d235d_55fe58ae","line":57,"updated":"2017-07-03 19:51:48.000000000","message":"a bit of explanation as to why we want to support those ports with ovs driver and not sriov one could help future readers","commit_id":"e84012eeb688d0ba59feaca9f753158ed53a4e10"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"4c3215dc92272ab987d0ab9a18476255ddae760b","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            constants.AGENT_TYPE_OVS,"},{"line_number":55,"context_line":"            portbindings.VIF_TYPE_OVS,"},{"line_number":56,"context_line":"            vif_details, supported_vnic_types\u003d[portbindings.VNIC_NORMAL,"},{"line_number":57,"context_line":"                                               portbindings.VNIC_DIRECT])"},{"line_number":58,"context_line":"        ovs_qos_driver.register()"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def get_allowed_network_types(self, agent):"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f1d235d_4d9368fb","line":57,"in_reply_to":"3f1d235d_55fe58ae","updated":"2017-07-04 13:33:22.000000000","message":"Done","commit_id":"e84012eeb688d0ba59feaca9f753158ed53a4e10"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"59e0ce195f85d770afe249cd4560ab0f8fa61b29","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        # to offload the OVS flows using tc to the SR-IOV NIC."},{"line_number":77,"context_line":"        # We are using OVS mechanism driver because the openvswitch (\u003e\u003d2.8.0)"},{"line_number":78,"context_line":"        # support hardware offload via tc and that allow us to manage the VF by"},{"line_number":79,"context_line":"        # OpenFlow control plain using representor net-device."},{"line_number":80,"context_line":"        if vnic_type \u003d\u003d portbindings.VNIC_DIRECT:"},{"line_number":81,"context_line":"            return portbindings.VIF_TYPE_OVS_ACCELERATION"},{"line_number":82,"context_line":"        caps \u003d agent[\u0027configurations\u0027].get(\u0027ovs_capabilities\u0027, {})"}],"source_content_type":"text/x-python","patch_set":20,"id":"3f1d235d_8f3edb88","line":79,"range":{"start_line":79,"start_character":27,"end_line":79,"end_character":32},"updated":"2017-07-05 19:14:32.000000000","message":"plane","commit_id":"c62e8e7f6e5c10611e88a76a3c35b6a5130bc614"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"026d5bc1a4b50cc7ab3af260f2e0e4adf4894474","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        # to offload the OVS flows using tc to the SR-IOV NIC."},{"line_number":77,"context_line":"        # We are using OVS mechanism driver because the openvswitch (\u003e\u003d2.8.0)"},{"line_number":78,"context_line":"        # support hardware offload via tc and that allow us to manage the VF by"},{"line_number":79,"context_line":"        # OpenFlow control plain using representor net-device."},{"line_number":80,"context_line":"        if vnic_type \u003d\u003d portbindings.VNIC_DIRECT:"},{"line_number":81,"context_line":"            return portbindings.VIF_TYPE_OVS_ACCELERATION"},{"line_number":82,"context_line":"        caps \u003d agent[\u0027configurations\u0027].get(\u0027ovs_capabilities\u0027, {})"}],"source_content_type":"text/x-python","patch_set":20,"id":"3f1d235d_f533d260","line":79,"range":{"start_line":79,"start_character":27,"end_line":79,"end_character":32},"in_reply_to":"3f1d235d_8f3edb88","updated":"2017-07-06 05:02:36.000000000","message":"Done","commit_id":"c62e8e7f6e5c10611e88a76a3c35b6a5130bc614"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3e71362b641073703f0b0b30cce216cf1d2ccf98","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            agent[\u0027configurations\u0027].get(\u0027datapath_type\u0027) \u003d\u003d"},{"line_number":87,"context_line":"            a_const.OVS_DATAPATH_NETDEV):"},{"line_number":88,"context_line":"            return portbindings.VIF_TYPE_VHOST_USER"},{"line_number":89,"context_line":"        return self.vif_type"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def get_vhost_mode(self, iface_types):"},{"line_number":92,"context_line":"        # NOTE(sean-k-mooney): this function converts the ovs vhost user"}],"source_content_type":"text/x-python","patch_set":29,"id":"1f1a1f67_18498a5f","line":89,"updated":"2017-07-20 18:45:20.000000000","message":"won\u0027t this line be enough now? do we still need the lines 80-81?","commit_id":"838ac986ab58d8e6bac30b8132f9a34948f699b7"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"3d33e0ad1afc51782e1bda8e436357da2a973a5b","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            agent[\u0027configurations\u0027].get(\u0027datapath_type\u0027) \u003d\u003d"},{"line_number":87,"context_line":"            a_const.OVS_DATAPATH_NETDEV):"},{"line_number":88,"context_line":"            return portbindings.VIF_TYPE_VHOST_USER"},{"line_number":89,"context_line":"        return self.vif_type"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def get_vhost_mode(self, iface_types):"},{"line_number":92,"context_line":"        # NOTE(sean-k-mooney): this function converts the ovs vhost user"}],"source_content_type":"text/x-python","patch_set":29,"id":"1f1a1f67_b392b94a","line":89,"in_reply_to":"1f1a1f67_18498a5f","updated":"2017-07-20 19:28:17.000000000","message":"yes, I think you are right, I will fix it. so you want me to remove all 73,80-81 and move the comment to Line 56","commit_id":"838ac986ab58d8e6bac30b8132f9a34948f699b7"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"11e490a4868dae1a121d48e19eeec9de0633fc49","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            agent[\u0027configurations\u0027].get(\u0027datapath_type\u0027) \u003d\u003d"},{"line_number":87,"context_line":"            a_const.OVS_DATAPATH_NETDEV):"},{"line_number":88,"context_line":"            return portbindings.VIF_TYPE_VHOST_USER"},{"line_number":89,"context_line":"        return self.vif_type"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def get_vhost_mode(self, iface_types):"},{"line_number":92,"context_line":"        # NOTE(sean-k-mooney): this function converts the ovs vhost user"}],"source_content_type":"text/x-python","patch_set":29,"id":"1f1a1f67_f3c0312d","line":89,"in_reply_to":"1f1a1f67_b392b94a","updated":"2017-07-20 19:30:14.000000000","message":"Yes, probably. I think it will also affect the unit test changes you have here.","commit_id":"838ac986ab58d8e6bac30b8132f9a34948f699b7"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"caaf392d7625ad177d0457ae19d75a6d9b99b008","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            agent[\u0027configurations\u0027].get(\u0027datapath_type\u0027) \u003d\u003d"},{"line_number":87,"context_line":"            a_const.OVS_DATAPATH_NETDEV):"},{"line_number":88,"context_line":"            return portbindings.VIF_TYPE_VHOST_USER"},{"line_number":89,"context_line":"        return self.vif_type"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def get_vhost_mode(self, iface_types):"},{"line_number":92,"context_line":"        # NOTE(sean-k-mooney): this function converts the ovs vhost user"}],"source_content_type":"text/x-python","patch_set":29,"id":"1f1a1f67_17895825","line":89,"in_reply_to":"1f1a1f67_f3c0312d","updated":"2017-07-20 20:04:17.000000000","message":"Done","commit_id":"838ac986ab58d8e6bac30b8132f9a34948f699b7"}],"neutron/tests/unit/plugins/ml2/drivers/openvswitch/mech_driver/test_mech_openvswitch.py":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"59a231e630a2405b3b50c6da693e0a82357808a8","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        self.assertEqual(portbindings.VIF_TYPE_VHOST_USER, result)"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"        result \u003d self.driver.get_vif_type(self.AGENT_SYSTEM, context)"},{"line_number":244,"context_line":"        self.assertEqual(portbindings.VIF_TYPE_OVS, result)"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba2be162_ab08aa2e","line":244,"updated":"2017-03-01 22:04:27.000000000","message":"Should not we check that we can get VIF_TYPE_OVS_ACCELERATION?","commit_id":"8a591d394cd4c39f81bd54c34c89e666955ae592"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"662e8262525eb2fb08d6e92dc97fc2ef01a3e42e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a1ff146_143f07d7","line":1,"updated":"2017-03-16 11:27:46.000000000","message":"You should consider adding your own class, extending OpenvswitchMechanismBaseTestCase, and testing when you add a vnic_type\u003ddirect port","commit_id":"70bb5157beff879ded54b9250e7087072204f949"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"18f91c486fd76e8e51e66c068f00d139f656bb39","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a1ff146_ef99b86f","line":1,"in_reply_to":"3a1ff146_143f07d7","updated":"2017-03-16 14:34:17.000000000","message":"Done","commit_id":"70bb5157beff879ded54b9250e7087072204f949"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b2ea765e1e7c908d7139588b9f1cbc516f2b6d49","unresolved":false,"context_lines":[{"line_number":242,"context_line":""},{"line_number":243,"context_line":"        result \u003d self.driver.get_vif_type(self.AGENT_SYSTEM, context)"},{"line_number":244,"context_line":"        self.assertEqual(portbindings.VIF_TYPE_OVS, result)"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"class OpenvswitchMechanismSRIOVTestCase(OpenvswitchMechanismBaseTestCase):"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    VIF_TYPE \u003d portbindings.VIF_TYPE_OVS_ACCELERATION"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a1ced50_6900c1ab","line":245,"updated":"2017-03-16 16:44:25.000000000","message":"I think you need two empty lines...","commit_id":"bbe687974f58e5dc56425f00842b8a52642db522"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"cf5588c0f06b872ee2f765065586e227523a844b","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                    \u0027configurations\u0027: SYSTEM_CONFIGS,"},{"line_number":215,"context_line":"                    \u0027host\u0027: \u0027host\u0027}"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    def _make_port_ctx(self, agents):"},{"line_number":218,"context_line":"        segments \u003d [{api.ID: \u0027local_segment_id\u0027, api.NETWORK_TYPE: \u0027local\u0027}]"},{"line_number":219,"context_line":"        return base.FakePortContext(self.AGENT_TYPE, agents, segments,"},{"line_number":220,"context_line":"                                    vnic_type\u003dself.VNIC_TYPE)"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f1d235d_f23b3ae8","line":217,"updated":"2017-07-03 19:51:48.000000000","message":"strictly speaking there is no reason for this change (or changes in all existing test cases below).","commit_id":"e84012eeb688d0ba59feaca9f753158ed53a4e10"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"4c3215dc92272ab987d0ab9a18476255ddae760b","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                    \u0027configurations\u0027: SYSTEM_CONFIGS,"},{"line_number":215,"context_line":"                    \u0027host\u0027: \u0027host\u0027}"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    def _make_port_ctx(self, agents):"},{"line_number":218,"context_line":"        segments \u003d [{api.ID: \u0027local_segment_id\u0027, api.NETWORK_TYPE: \u0027local\u0027}]"},{"line_number":219,"context_line":"        return base.FakePortContext(self.AGENT_TYPE, agents, segments,"},{"line_number":220,"context_line":"                                    vnic_type\u003dself.VNIC_TYPE)"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f1d235d_1ec5945b","line":217,"in_reply_to":"3f1d235d_f23b3ae8","updated":"2017-07-04 13:33:22.000000000","message":"we need this change because the get_vif_type need a real context now to get the port_type. The change in the test_get_vif_tye is incorrect \nit should be\nresult \u003d self.driver.get_vif_type(context, self.AGENT, None)","commit_id":"e84012eeb688d0ba59feaca9f753158ed53a4e10"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"cf5588c0f06b872ee2f765065586e227523a844b","unresolved":false,"context_lines":[{"line_number":246,"context_line":""},{"line_number":247,"context_line":"class OpenvswitchMechanismSRIOVTestCase(OpenvswitchMechanismBaseTestCase):"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    VIF_TYPE \u003d portbindings.VIF_TYPE_OVS_ACCELERATION"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    def _make_port_ctx(self, agents):"},{"line_number":252,"context_line":"        segments \u003d [{api.ID: \u0027local_segment_id\u0027, api.NETWORK_TYPE: \u0027local\u0027}]"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f1d235d_1267d627","line":249,"updated":"2017-07-03 19:51:48.000000000","message":"nit: no reason to keep it here as a class attribute, just move it in-place into the single test case you have.","commit_id":"e84012eeb688d0ba59feaca9f753158ed53a4e10"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"4c3215dc92272ab987d0ab9a18476255ddae760b","unresolved":false,"context_lines":[{"line_number":246,"context_line":""},{"line_number":247,"context_line":"class OpenvswitchMechanismSRIOVTestCase(OpenvswitchMechanismBaseTestCase):"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    VIF_TYPE \u003d portbindings.VIF_TYPE_OVS_ACCELERATION"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    def _make_port_ctx(self, agents):"},{"line_number":252,"context_line":"        segments \u003d [{api.ID: \u0027local_segment_id\u0027, api.NETWORK_TYPE: \u0027local\u0027}]"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f1d235d_fe0538c3","line":249,"in_reply_to":"3f1d235d_1267d627","updated":"2017-07-04 13:33:22.000000000","message":"Done","commit_id":"e84012eeb688d0ba59feaca9f753158ed53a4e10"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"cf5588c0f06b872ee2f765065586e227523a844b","unresolved":false,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    def test_get_vif_type(self):"},{"line_number":257,"context_line":"        context \u003d self._make_port_ctx(self.AGENTS)"},{"line_number":258,"context_line":"        result \u003d self.driver.get_vif_type(self.AGENTS, context)"},{"line_number":259,"context_line":"        self.assertEqual(self.VIF_TYPE, result)"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f1d235d_b204a24b","line":258,"range":{"start_line":258,"start_character":46,"end_line":258,"end_character":53},"updated":"2017-07-03 19:51:48.000000000","message":"get_vif_type receives a single agent config, not a list. It works for you here because you short-circuit the logic in get_vif_type for the driver, but it\u0027s still worth fixing the test case to reflect proper arguments.","commit_id":"e84012eeb688d0ba59feaca9f753158ed53a4e10"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"4c3215dc92272ab987d0ab9a18476255ddae760b","unresolved":false,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    def test_get_vif_type(self):"},{"line_number":257,"context_line":"        context \u003d self._make_port_ctx(self.AGENTS)"},{"line_number":258,"context_line":"        result \u003d self.driver.get_vif_type(self.AGENTS, context)"},{"line_number":259,"context_line":"        self.assertEqual(self.VIF_TYPE, result)"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f1d235d_dea4bcbb","line":258,"range":{"start_line":258,"start_character":46,"end_line":258,"end_character":53},"in_reply_to":"3f1d235d_b204a24b","updated":"2017-07-04 13:33:22.000000000","message":"Done","commit_id":"e84012eeb688d0ba59feaca9f753158ed53a4e10"}],"releasenotes/notes/ovs_hardware_offload_support-798d3896ab2c4b1d.yaml":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"59e0ce195f85d770afe249cd4560ab0f8fa61b29","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    The OpenVSwitch mechanism driver now supports hardware offload via SR-IOV"},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - The OpenVSwitch mechanism driver now allows binding DIRECT (SR-IOV) port."},{"line_number":6,"context_line":"    Using OpenVSwitch 2.8.0 and Kernel 4.8 allows to control the SR-IOV VF"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3f1d235d_0f6beb84","line":3,"range":{"start_line":3,"start_character":8,"end_line":3,"end_character":19},"updated":"2017-07-05 19:14:32.000000000","message":"You either call it via stevedore alias (\u0027openvswitch\u0027) or as the project is called (\u0027Open vSwitch\u0027). here and below.","commit_id":"c62e8e7f6e5c10611e88a76a3c35b6a5130bc614"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"59e0ce195f85d770afe249cd4560ab0f8fa61b29","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    The OpenVSwitch mechanism driver now supports hardware offload via SR-IOV"},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - The OpenVSwitch mechanism driver now allows binding DIRECT (SR-IOV) port."},{"line_number":6,"context_line":"    Using OpenVSwitch 2.8.0 and Kernel 4.8 allows to control the SR-IOV VF"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3f1d235d_cf0613cf","line":3,"range":{"start_line":3,"start_character":76,"end_line":3,"end_character":77},"updated":"2017-07-05 19:14:32.000000000","message":"probably a trailing dot is needed","commit_id":"c62e8e7f6e5c10611e88a76a3c35b6a5130bc614"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"026d5bc1a4b50cc7ab3af260f2e0e4adf4894474","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    The OpenVSwitch mechanism driver now supports hardware offload via SR-IOV"},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - The OpenVSwitch mechanism driver now allows binding DIRECT (SR-IOV) port."},{"line_number":6,"context_line":"    Using OpenVSwitch 2.8.0 and Kernel 4.8 allows to control the SR-IOV VF"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3f1d235d_f50cf294","line":3,"range":{"start_line":3,"start_character":8,"end_line":3,"end_character":19},"in_reply_to":"3f1d235d_0f6beb84","updated":"2017-07-06 05:02:36.000000000","message":"Done","commit_id":"c62e8e7f6e5c10611e88a76a3c35b6a5130bc614"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"026d5bc1a4b50cc7ab3af260f2e0e4adf4894474","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    The OpenVSwitch mechanism driver now supports hardware offload via SR-IOV"},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - The OpenVSwitch mechanism driver now allows binding DIRECT (SR-IOV) port."},{"line_number":6,"context_line":"    Using OpenVSwitch 2.8.0 and Kernel 4.8 allows to control the SR-IOV VF"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3f1d235d_151aceca","line":3,"range":{"start_line":3,"start_character":76,"end_line":3,"end_character":77},"in_reply_to":"3f1d235d_cf0613cf","updated":"2017-07-06 05:02:36.000000000","message":"Done","commit_id":"c62e8e7f6e5c10611e88a76a3c35b6a5130bc614"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"59e0ce195f85d770afe249cd4560ab0f8fa61b29","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    The OpenVSwitch mechanism driver now supports hardware offload via SR-IOV"},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - The OpenVSwitch mechanism driver now allows binding DIRECT (SR-IOV) port."},{"line_number":6,"context_line":"    Using OpenVSwitch 2.8.0 and Kernel 4.8 allows to control the SR-IOV VF"},{"line_number":7,"context_line":"    via openflow control plain and gain accelerate OVS."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3f1d235d_4ffa03bd","line":5,"range":{"start_line":5,"start_character":72,"end_line":5,"end_character":76},"updated":"2017-07-05 19:14:32.000000000","message":"-\u003e ports","commit_id":"c62e8e7f6e5c10611e88a76a3c35b6a5130bc614"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"59e0ce195f85d770afe249cd4560ab0f8fa61b29","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    The OpenVSwitch mechanism driver now supports hardware offload via SR-IOV"},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - The OpenVSwitch mechanism driver now allows binding DIRECT (SR-IOV) port."},{"line_number":6,"context_line":"    Using OpenVSwitch 2.8.0 and Kernel 4.8 allows to control the SR-IOV VF"},{"line_number":7,"context_line":"    via openflow control plain and gain accelerate OVS."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3f1d235d_8f0c9bec","line":5,"range":{"start_line":5,"start_character":56,"end_line":5,"end_character":62},"updated":"2017-07-05 19:14:32.000000000","message":"why all caps? is it a common way of wording it?","commit_id":"c62e8e7f6e5c10611e88a76a3c35b6a5130bc614"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"026d5bc1a4b50cc7ab3af260f2e0e4adf4894474","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    The OpenVSwitch mechanism driver now supports hardware offload via SR-IOV"},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - The OpenVSwitch mechanism driver now allows binding DIRECT (SR-IOV) port."},{"line_number":6,"context_line":"    Using OpenVSwitch 2.8.0 and Kernel 4.8 allows to control the SR-IOV VF"},{"line_number":7,"context_line":"    via openflow control plain and gain accelerate OVS."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3f1d235d_7520e2f7","line":5,"range":{"start_line":5,"start_character":72,"end_line":5,"end_character":76},"in_reply_to":"3f1d235d_4ffa03bd","updated":"2017-07-06 05:02:36.000000000","message":"Done","commit_id":"c62e8e7f6e5c10611e88a76a3c35b6a5130bc614"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"026d5bc1a4b50cc7ab3af260f2e0e4adf4894474","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    The OpenVSwitch mechanism driver now supports hardware offload via SR-IOV"},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - The OpenVSwitch mechanism driver now allows binding DIRECT (SR-IOV) port."},{"line_number":6,"context_line":"    Using OpenVSwitch 2.8.0 and Kernel 4.8 allows to control the SR-IOV VF"},{"line_number":7,"context_line":"    via openflow control plain and gain accelerate OVS."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3f1d235d_551ba6c8","line":5,"range":{"start_line":5,"start_character":56,"end_line":5,"end_character":62},"in_reply_to":"3f1d235d_8f0c9bec","updated":"2017-07-06 05:02:36.000000000","message":"Done","commit_id":"c62e8e7f6e5c10611e88a76a3c35b6a5130bc614"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"59e0ce195f85d770afe249cd4560ab0f8fa61b29","unresolved":false,"context_lines":[{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - The OpenVSwitch mechanism driver now allows binding DIRECT (SR-IOV) port."},{"line_number":6,"context_line":"    Using OpenVSwitch 2.8.0 and Kernel 4.8 allows to control the SR-IOV VF"},{"line_number":7,"context_line":"    via openflow control plain and gain accelerate OVS."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3f1d235d_2f20e747","line":7,"range":{"start_line":7,"start_character":51,"end_line":7,"end_character":54},"updated":"2017-07-05 19:14:32.000000000","message":"-\u003e virtual switch? Open vSwitch?","commit_id":"c62e8e7f6e5c10611e88a76a3c35b6a5130bc614"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"59e0ce195f85d770afe249cd4560ab0f8fa61b29","unresolved":false,"context_lines":[{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - The OpenVSwitch mechanism driver now allows binding DIRECT (SR-IOV) port."},{"line_number":6,"context_line":"    Using OpenVSwitch 2.8.0 and Kernel 4.8 allows to control the SR-IOV VF"},{"line_number":7,"context_line":"    via openflow control plain and gain accelerate OVS."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3f1d235d_effc2fb6","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":16},"updated":"2017-07-05 19:14:32.000000000","message":"I think it\u0027s OpenFlow","commit_id":"c62e8e7f6e5c10611e88a76a3c35b6a5130bc614"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"59e0ce195f85d770afe249cd4560ab0f8fa61b29","unresolved":false,"context_lines":[{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - The OpenVSwitch mechanism driver now allows binding DIRECT (SR-IOV) port."},{"line_number":6,"context_line":"    Using OpenVSwitch 2.8.0 and Kernel 4.8 allows to control the SR-IOV VF"},{"line_number":7,"context_line":"    via openflow control plain and gain accelerate OVS."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3f1d235d_6f2a5f2c","line":7,"range":{"start_line":7,"start_character":40,"end_line":7,"end_character":50},"updated":"2017-07-05 19:14:32.000000000","message":"accelerated","commit_id":"c62e8e7f6e5c10611e88a76a3c35b6a5130bc614"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"59e0ce195f85d770afe249cd4560ab0f8fa61b29","unresolved":false,"context_lines":[{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - The OpenVSwitch mechanism driver now allows binding DIRECT (SR-IOV) port."},{"line_number":6,"context_line":"    Using OpenVSwitch 2.8.0 and Kernel 4.8 allows to control the SR-IOV VF"},{"line_number":7,"context_line":"    via openflow control plain and gain accelerate OVS."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3f1d235d_cf2f333d","line":7,"range":{"start_line":7,"start_character":25,"end_line":7,"end_character":30},"updated":"2017-07-05 19:14:32.000000000","message":"plane","commit_id":"c62e8e7f6e5c10611e88a76a3c35b6a5130bc614"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"026d5bc1a4b50cc7ab3af260f2e0e4adf4894474","unresolved":false,"context_lines":[{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - The OpenVSwitch mechanism driver now allows binding DIRECT (SR-IOV) port."},{"line_number":6,"context_line":"    Using OpenVSwitch 2.8.0 and Kernel 4.8 allows to control the SR-IOV VF"},{"line_number":7,"context_line":"    via openflow control plain and gain accelerate OVS."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3f1d235d_b56f9a29","line":7,"range":{"start_line":7,"start_character":51,"end_line":7,"end_character":54},"in_reply_to":"3f1d235d_2f20e747","updated":"2017-07-06 05:02:36.000000000","message":"Done","commit_id":"c62e8e7f6e5c10611e88a76a3c35b6a5130bc614"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"026d5bc1a4b50cc7ab3af260f2e0e4adf4894474","unresolved":false,"context_lines":[{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - The OpenVSwitch mechanism driver now allows binding DIRECT (SR-IOV) port."},{"line_number":6,"context_line":"    Using OpenVSwitch 2.8.0 and Kernel 4.8 allows to control the SR-IOV VF"},{"line_number":7,"context_line":"    via openflow control plain and gain accelerate OVS."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3f1d235d_d58456d5","line":7,"range":{"start_line":7,"start_character":25,"end_line":7,"end_character":30},"in_reply_to":"3f1d235d_cf2f333d","updated":"2017-07-06 05:02:36.000000000","message":"Done","commit_id":"c62e8e7f6e5c10611e88a76a3c35b6a5130bc614"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"026d5bc1a4b50cc7ab3af260f2e0e4adf4894474","unresolved":false,"context_lines":[{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - The OpenVSwitch mechanism driver now allows binding DIRECT (SR-IOV) port."},{"line_number":6,"context_line":"    Using OpenVSwitch 2.8.0 and Kernel 4.8 allows to control the SR-IOV VF"},{"line_number":7,"context_line":"    via openflow control plain and gain accelerate OVS."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3f1d235d_f58192c4","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":16},"in_reply_to":"3f1d235d_effc2fb6","updated":"2017-07-06 05:02:36.000000000","message":"Done","commit_id":"c62e8e7f6e5c10611e88a76a3c35b6a5130bc614"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f6971da623720f7b089c94a3f0705e1932192aa5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    The openvswitch mechanism driver now supports hardware offload via SR-IOV."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - The openvswitch mechanism driver now allows binding direct (SR-IOV) ports."},{"line_number":6,"context_line":"    Using openvswitch 2.8.0 and Kernel 4.8 allows to control the SR-IOV VF"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"1f1a1f67_14cf9b29","line":3,"range":{"start_line":3,"start_character":8,"end_line":3,"end_character":19},"updated":"2017-07-17 16:18:54.000000000","message":"names of drivers are usually quoted like ``openvswitch`` so that they are italic in the html result","commit_id":"aeafecc2ef64023bd6c0243051a21f8e20b75644"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f6971da623720f7b089c94a3f0705e1932192aa5","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    The openvswitch mechanism driver now supports hardware offload via SR-IOV."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - The openvswitch mechanism driver now allows binding direct (SR-IOV) ports."},{"line_number":6,"context_line":"    Using openvswitch 2.8.0 and Kernel 4.8 allows to control the SR-IOV VF"},{"line_number":7,"context_line":"    via OpenFlow control plane and gain accelerated Open vSwitch."}],"source_content_type":"text/x-yaml","patch_set":24,"id":"1f1a1f67_f4d3ffd3","line":5,"range":{"start_line":5,"start_character":8,"end_line":5,"end_character":19},"updated":"2017-07-17 16:18:54.000000000","message":"ditto","commit_id":"aeafecc2ef64023bd6c0243051a21f8e20b75644"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f6971da623720f7b089c94a3f0705e1932192aa5","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    The openvswitch mechanism driver now supports hardware offload via SR-IOV."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - The openvswitch mechanism driver now allows binding direct (SR-IOV) ports."},{"line_number":6,"context_line":"    Using openvswitch 2.8.0 and Kernel 4.8 allows to control the SR-IOV VF"},{"line_number":7,"context_line":"    via OpenFlow control plane and gain accelerated Open vSwitch."}],"source_content_type":"text/x-yaml","patch_set":24,"id":"1f1a1f67_74dfefd5","line":6,"range":{"start_line":6,"start_character":32,"end_line":6,"end_character":38},"updated":"2017-07-17 16:18:54.000000000","message":"I guess you mean \u0027Linux kernel\u0027 (because mech_openvswitch may be used with Windows too)","commit_id":"aeafecc2ef64023bd6c0243051a21f8e20b75644"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f6971da623720f7b089c94a3f0705e1932192aa5","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    The openvswitch mechanism driver now supports hardware offload via SR-IOV."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - The openvswitch mechanism driver now allows binding direct (SR-IOV) ports."},{"line_number":6,"context_line":"    Using openvswitch 2.8.0 and Kernel 4.8 allows to control the SR-IOV VF"},{"line_number":7,"context_line":"    via OpenFlow control plane and gain accelerated Open vSwitch."}],"source_content_type":"text/x-yaml","patch_set":24,"id":"1f1a1f67_b4d907f4","line":6,"range":{"start_line":6,"start_character":10,"end_line":6,"end_character":21},"updated":"2017-07-17 16:18:54.000000000","message":"the software name is \u0027Open vSwitch\u0027","commit_id":"aeafecc2ef64023bd6c0243051a21f8e20b75644"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"28d38f640f4bdb9bbc91e7b9a0baa49f983ea5f5","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    The ``openvswitch`` mechanism driver now supports hardware offload via SR-IOV."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - The ``openvswitch`` mechanism driver now allows binding direct (SR-IOV) ports."},{"line_number":6,"context_line":"    Using ``openvswitch`` 2.8.0 and \u0027Linux Kernel\u0027 4.8 allows to control the SR-IOV VF"},{"line_number":7,"context_line":"    via OpenFlow control plane and gain accelerated \u0027Open vSwitch\u0027."}],"source_content_type":"text/x-yaml","patch_set":25,"id":"1f1a1f67_97fc9f3e","line":6,"range":{"start_line":6,"start_character":43,"end_line":6,"end_character":49},"updated":"2017-07-18 18:39:22.000000000","message":"-\u003e kernel (lower case)","commit_id":"9ec9941f0d1a3163682ae0aa5489402f9aff3c1d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"28d38f640f4bdb9bbc91e7b9a0baa49f983ea5f5","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    The ``openvswitch`` mechanism driver now supports hardware offload via SR-IOV."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - The ``openvswitch`` mechanism driver now allows binding direct (SR-IOV) ports."},{"line_number":6,"context_line":"    Using ``openvswitch`` 2.8.0 and \u0027Linux Kernel\u0027 4.8 allows to control the SR-IOV VF"},{"line_number":7,"context_line":"    via OpenFlow control plane and gain accelerated \u0027Open vSwitch\u0027."}],"source_content_type":"text/x-yaml","patch_set":25,"id":"1f1a1f67_b701db3a","line":6,"range":{"start_line":6,"start_character":36,"end_line":6,"end_character":37},"updated":"2017-07-18 18:39:22.000000000","message":"I don\u0027t think quotes are needed here, it\u0027s not a name of a movie","commit_id":"9ec9941f0d1a3163682ae0aa5489402f9aff3c1d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"28d38f640f4bdb9bbc91e7b9a0baa49f983ea5f5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - The ``openvswitch`` mechanism driver now allows binding direct (SR-IOV) ports."},{"line_number":6,"context_line":"    Using ``openvswitch`` 2.8.0 and \u0027Linux Kernel\u0027 4.8 allows to control the SR-IOV VF"},{"line_number":7,"context_line":"    via OpenFlow control plane and gain accelerated \u0027Open vSwitch\u0027."}],"source_content_type":"text/x-yaml","patch_set":25,"id":"1f1a1f67_97aa5f16","line":7,"range":{"start_line":7,"start_character":52,"end_line":7,"end_character":53},"updated":"2017-07-18 18:39:22.000000000","message":"There are no single quotes in human facing texts. Also, it\u0027s not a movie neither a book. I think it should have no quotes. If you want to clarify it\u0027s a name of a project, capital letters are fine, but you can use `` `` if you feel like.","commit_id":"9ec9941f0d1a3163682ae0aa5489402f9aff3c1d"}]}