)]}'
{"neutron/db/securitygroups_db.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"45cceed955e8b3718e5bd565a89592ce3a27d2e5","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from neutron.extensions import securitygroup as ext_sg"},{"line_number":34,"context_line":"from neutron.objects import base as obj_base"},{"line_number":35,"context_line":"from neutron.objects.port.extensions import (securitygroups"},{"line_number":36,"context_line":"                                             as obj_securitygroup)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a57f1b5_297817c4","line":36,"updated":"2016-02-10 15:04:52.000000000","message":"Why not use securitygroup (or security_group)?\n\nNot sure there is a lot of value adding the prefix (or suffix on the variables). Kinda feels like Hungarian notation.","commit_id":"1bddaf8b0f17a069dee0561510ca1124d05b0bdb"},{"author":{"_account_id":9178,"name":"Sayali Lunkad","email":"sayali.lunkad@suse.com","username":"sayalilunkad"},"change_message_id":"69b4742454c7b4a7d5406771b2fdaeeacc139ef0","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from neutron.extensions import securitygroup as ext_sg"},{"line_number":34,"context_line":"from neutron.objects import base as obj_base"},{"line_number":35,"context_line":"from neutron.objects.port.extensions import (securitygroups"},{"line_number":36,"context_line":"                                             as obj_securitygroup)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_018b41c4","line":36,"in_reply_to":"3a57f1b5_297817c4","updated":"2016-02-16 16:53:59.000000000","message":"I think obj_securitygroup helps to highlight the fact that we are using oslo objects here. I was just following what was done in the other patches for the ovo port.","commit_id":"1bddaf8b0f17a069dee0561510ca1124d05b0bdb"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"a9da94ba79dfcb89fc34a2345c7d236956fdaaa2","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        with db_api.autonested_transaction(context.session):"},{"line_number":85,"context_line":"            security_group_obj \u003d obj_securitygroup.SecurityGroup("},{"line_number":86,"context_line":"                context,"},{"line_number":87,"context_line":"                id\u003ds.get(\u0027id\u0027) or (uuidutils.generate_uuid()),"},{"line_number":88,"context_line":"                description\u003ds[\u0027description\u0027],"},{"line_number":89,"context_line":"                tenant_id\u003dtenant_id,"},{"line_number":90,"context_line":"                name\u003ds[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_d60606cd","line":87,"updated":"2016-02-17 15:36:06.000000000","message":"no need to generate an id if you are using the object :)","commit_id":"90b0525229dcd9fb932b1eeb72ae7c349b74fdeb"},{"author":{"_account_id":9178,"name":"Sayali Lunkad","email":"sayali.lunkad@suse.com","username":"sayalilunkad"},"change_message_id":"5e66171bd05487750cfe03cb5b4e22c628a43c97","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        with db_api.autonested_transaction(context.session):"},{"line_number":85,"context_line":"            security_group_obj \u003d obj_securitygroup.SecurityGroup("},{"line_number":86,"context_line":"                context,"},{"line_number":87,"context_line":"                id\u003ds.get(\u0027id\u0027) or (uuidutils.generate_uuid()),"},{"line_number":88,"context_line":"                description\u003ds[\u0027description\u0027],"},{"line_number":89,"context_line":"                tenant_id\u003dtenant_id,"},{"line_number":90,"context_line":"                name\u003ds[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_8fd6184d","line":87,"in_reply_to":"dae33548_d60606cd","updated":"2016-02-17 16:38:50.000000000","message":"Done","commit_id":"90b0525229dcd9fb932b1eeb72ae7c349b74fdeb"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"a9da94ba79dfcb89fc34a2345c7d236956fdaaa2","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                name\u003ds[\u0027name\u0027])"},{"line_number":91,"context_line":"            security_group_obj.create_object()"},{"line_number":92,"context_line":"            if default_sg:"},{"line_number":93,"context_line":"                default_security_group_obj \\"},{"line_number":94,"context_line":"                    \u003d obj_securitygroup.DefaultSecurityGroup("},{"line_number":95,"context_line":"                        security_group\u003dsecurity_group_obj,"},{"line_number":96,"context_line":"                        tenant_id\u003dsecurity_group_obj[\u0027tenant_id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_f6286a35","line":93,"updated":"2016-02-17 15:36:06.000000000","message":"nit, we don\u0027t use \u0027\\\u0027 for multi lines, we prefer to use parenthesis.","commit_id":"90b0525229dcd9fb932b1eeb72ae7c349b74fdeb"},{"author":{"_account_id":9178,"name":"Sayali Lunkad","email":"sayali.lunkad@suse.com","username":"sayalilunkad"},"change_message_id":"5e66171bd05487750cfe03cb5b4e22c628a43c97","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                name\u003ds[\u0027name\u0027])"},{"line_number":91,"context_line":"            security_group_obj.create_object()"},{"line_number":92,"context_line":"            if default_sg:"},{"line_number":93,"context_line":"                default_security_group_obj \\"},{"line_number":94,"context_line":"                    \u003d obj_securitygroup.DefaultSecurityGroup("},{"line_number":95,"context_line":"                        security_group\u003dsecurity_group_obj,"},{"line_number":96,"context_line":"                        tenant_id\u003dsecurity_group_obj[\u0027tenant_id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_2fc6ec99","line":93,"in_reply_to":"dae33548_f6286a35","updated":"2016-02-17 16:38:50.000000000","message":"Done","commit_id":"90b0525229dcd9fb932b1eeb72ae7c349b74fdeb"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"a9da94ba79dfcb89fc34a2345c7d236956fdaaa2","unresolved":false,"context_lines":[{"line_number":182,"context_line":"            raise ext_sg.SecurityGroupNotFound(id\u003did)"},{"line_number":183,"context_line":"        return sg"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    def _get_security_group_objs(self, context, id):"},{"line_number":186,"context_line":"        sg \u003d obj_securitygroup.SecurityGroupRule.get_objects("},{"line_number":187,"context_line":"            context, security_group_id\u003did)"},{"line_number":188,"context_line":"        return sg"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_47123e58","line":185,"updated":"2016-02-17 15:36:06.000000000","message":"I wonder if we really need this method...we could simply use _get_security_group","commit_id":"90b0525229dcd9fb932b1eeb72ae7c349b74fdeb"},{"author":{"_account_id":9178,"name":"Sayali Lunkad","email":"sayali.lunkad@suse.com","username":"sayalilunkad"},"change_message_id":"5e66171bd05487750cfe03cb5b4e22c628a43c97","unresolved":false,"context_lines":[{"line_number":182,"context_line":"            raise ext_sg.SecurityGroupNotFound(id\u003did)"},{"line_number":183,"context_line":"        return sg"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    def _get_security_group_objs(self, context, id):"},{"line_number":186,"context_line":"        sg \u003d obj_securitygroup.SecurityGroupRule.get_objects("},{"line_number":187,"context_line":"            context, security_group_id\u003did)"},{"line_number":188,"context_line":"        return sg"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_f99cd60f","line":185,"in_reply_to":"dae33548_47123e58","updated":"2016-02-17 16:38:50.000000000","message":"I thought maybe following this discussion it might be needed but I am fine not adding a new method as of now.\nhttps://review.openstack.org/#/c/268274/9..11/neutron/db/allowedaddresspairs_db.py","commit_id":"90b0525229dcd9fb932b1eeb72ae7c349b74fdeb"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"a9da94ba79dfcb89fc34a2345c7d236956fdaaa2","unresolved":false,"context_lines":[{"line_number":210,"context_line":"                              events.PRECOMMIT_DELETE,"},{"line_number":211,"context_line":"                              exc_cls\u003dext_sg.SecurityGroupInUse, id\u003did,"},{"line_number":212,"context_line":"                              **kwargs)"},{"line_number":213,"context_line":"        sg.delete_object()"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        kwargs.pop(\u0027security_group\u0027)"},{"line_number":216,"context_line":"        registry.notify(resources.SECURITY_GROUP, events.AFTER_DELETE, self,"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_47951e85","line":213,"updated":"2016-02-17 15:36:06.000000000","message":"it should be sg.delete()","commit_id":"90b0525229dcd9fb932b1eeb72ae7c349b74fdeb"},{"author":{"_account_id":9178,"name":"Sayali Lunkad","email":"sayali.lunkad@suse.com","username":"sayalilunkad"},"change_message_id":"5e66171bd05487750cfe03cb5b4e22c628a43c97","unresolved":false,"context_lines":[{"line_number":210,"context_line":"                              events.PRECOMMIT_DELETE,"},{"line_number":211,"context_line":"                              exc_cls\u003dext_sg.SecurityGroupInUse, id\u003did,"},{"line_number":212,"context_line":"                              **kwargs)"},{"line_number":213,"context_line":"        sg.delete_object()"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        kwargs.pop(\u0027security_group\u0027)"},{"line_number":216,"context_line":"        registry.notify(resources.SECURITY_GROUP, events.AFTER_DELETE, self,"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_af383ca1","line":213,"in_reply_to":"dae33548_47951e85","updated":"2016-02-17 16:38:50.000000000","message":"Done","commit_id":"90b0525229dcd9fb932b1eeb72ae7c349b74fdeb"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"a9da94ba79dfcb89fc34a2345c7d236956fdaaa2","unresolved":false,"context_lines":[{"line_number":234,"context_line":"                    resources.SECURITY_GROUP,"},{"line_number":235,"context_line":"                    events.PRECOMMIT_UPDATE,"},{"line_number":236,"context_line":"                    exc_cls\u003dext_sg.SecurityGroupConflict, **kwargs)"},{"line_number":237,"context_line":"        sg.update_object(s)"},{"line_number":238,"context_line":"        sg_dict \u003d self._make_security_group_dict(sg)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        kwargs[\u0027security_group\u0027] \u003d sg_dict"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_e7d1d258","line":237,"updated":"2016-02-17 15:36:06.000000000","message":"it should be sg.update() ...","commit_id":"90b0525229dcd9fb932b1eeb72ae7c349b74fdeb"},{"author":{"_account_id":9178,"name":"Sayali Lunkad","email":"sayali.lunkad@suse.com","username":"sayalilunkad"},"change_message_id":"5e66171bd05487750cfe03cb5b4e22c628a43c97","unresolved":false,"context_lines":[{"line_number":234,"context_line":"                    resources.SECURITY_GROUP,"},{"line_number":235,"context_line":"                    events.PRECOMMIT_UPDATE,"},{"line_number":236,"context_line":"                    exc_cls\u003dext_sg.SecurityGroupConflict, **kwargs)"},{"line_number":237,"context_line":"        sg.update_object(s)"},{"line_number":238,"context_line":"        sg_dict \u003d self._make_security_group_dict(sg)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        kwargs[\u0027security_group\u0027] \u003d sg_dict"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_8f3d7891","line":237,"in_reply_to":"dae33548_e7d1d258","updated":"2016-02-17 16:38:50.000000000","message":"Done","commit_id":"90b0525229dcd9fb932b1eeb72ae7c349b74fdeb"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"a9da94ba79dfcb89fc34a2345c7d236956fdaaa2","unresolved":false,"context_lines":[{"line_number":260,"context_line":"                                            security_group_id):"},{"line_number":261,"context_line":"        db \u003d obj_securitygroup.SecurityGroupPortBinding("},{"line_number":262,"context_line":"            port_id\u003dport_id, security_group_id\u003dsecurity_group_id)"},{"line_number":263,"context_line":"        db.create_object()"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    def _get_port_security_group_bindings(self, context,"},{"line_number":266,"context_line":"                                          filters\u003dNone, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_e738b2a2","line":263,"updated":"2016-02-17 15:36:06.000000000","message":"mmm create? create_object doesn\u0027t exists","commit_id":"90b0525229dcd9fb932b1eeb72ae7c349b74fdeb"},{"author":{"_account_id":9178,"name":"Sayali Lunkad","email":"sayali.lunkad@suse.com","username":"sayalilunkad"},"change_message_id":"5e66171bd05487750cfe03cb5b4e22c628a43c97","unresolved":false,"context_lines":[{"line_number":260,"context_line":"                                            security_group_id):"},{"line_number":261,"context_line":"        db \u003d obj_securitygroup.SecurityGroupPortBinding("},{"line_number":262,"context_line":"            port_id\u003dport_id, security_group_id\u003dsecurity_group_id)"},{"line_number":263,"context_line":"        db.create_object()"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    def _get_port_security_group_bindings(self, context,"},{"line_number":266,"context_line":"                                          filters\u003dNone, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_ef3ec489","line":263,"in_reply_to":"dae33548_e738b2a2","updated":"2016-02-17 16:38:50.000000000","message":"Done","commit_id":"90b0525229dcd9fb932b1eeb72ae7c349b74fdeb"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"a9da94ba79dfcb89fc34a2345c7d236956fdaaa2","unresolved":false,"context_lines":[{"line_number":329,"context_line":"            port_range_min\u003drule_dict[\u0027port_range_min\u0027],"},{"line_number":330,"context_line":"            port_range_max\u003drule_dict[\u0027port_range_max\u0027],"},{"line_number":331,"context_line":"            remote_ip_prefix\u003drule_dict.get(\u0027remote_ip_prefix\u0027))"},{"line_number":332,"context_line":"        db.create_object()"},{"line_number":333,"context_line":"        self._registry_notify(resources.SECURITY_GROUP_RULE,"},{"line_number":334,"context_line":"                              events.PRECOMMIT_CREATE,"},{"line_number":335,"context_line":"                              exc_cls\u003dext_sg.SecurityGroupConflict, **kwargs)"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_e75f12e3","line":332,"updated":"2016-02-17 15:36:06.000000000","message":"ditto","commit_id":"90b0525229dcd9fb932b1eeb72ae7c349b74fdeb"},{"author":{"_account_id":9178,"name":"Sayali Lunkad","email":"sayali.lunkad@suse.com","username":"sayalilunkad"},"change_message_id":"5e66171bd05487750cfe03cb5b4e22c628a43c97","unresolved":false,"context_lines":[{"line_number":329,"context_line":"            port_range_min\u003drule_dict[\u0027port_range_min\u0027],"},{"line_number":330,"context_line":"            port_range_max\u003drule_dict[\u0027port_range_max\u0027],"},{"line_number":331,"context_line":"            remote_ip_prefix\u003drule_dict.get(\u0027remote_ip_prefix\u0027))"},{"line_number":332,"context_line":"        db.create_object()"},{"line_number":333,"context_line":"        self._registry_notify(resources.SECURITY_GROUP_RULE,"},{"line_number":334,"context_line":"                              events.PRECOMMIT_CREATE,"},{"line_number":335,"context_line":"                              exc_cls\u003dext_sg.SecurityGroupConflict, **kwargs)"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_cf430012","line":332,"in_reply_to":"dae33548_e75f12e3","updated":"2016-02-17 16:38:50.000000000","message":"Done","commit_id":"90b0525229dcd9fb932b1eeb72ae7c349b74fdeb"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"834369e0c7e9e86bb354e90d2da014cba1bbe8ae","unresolved":false,"context_lines":[{"line_number":604,"context_line":"        # Make no more than two attempts"},{"line_number":605,"context_line":"        for attempts in (1, 2):"},{"line_number":606,"context_line":"            try:"},{"line_number":607,"context_line":"                default_group \\"},{"line_number":608,"context_line":"                    \u003d obj_securitygroup.DefaultSecurityGroup.get_objects("},{"line_number":609,"context_line":"                        context, tenant_id\u003dtenant_id)"},{"line_number":610,"context_line":"                return default_group[\u0027security_group_id\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_fc0e898a","line":607,"updated":"2016-02-17 15:52:03.000000000","message":"Use parens versus backslashes for continuation.","commit_id":"90b0525229dcd9fb932b1eeb72ae7c349b74fdeb"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"a9da94ba79dfcb89fc34a2345c7d236956fdaaa2","unresolved":false,"context_lines":[{"line_number":604,"context_line":"        # Make no more than two attempts"},{"line_number":605,"context_line":"        for attempts in (1, 2):"},{"line_number":606,"context_line":"            try:"},{"line_number":607,"context_line":"                default_group \\"},{"line_number":608,"context_line":"                    \u003d obj_securitygroup.DefaultSecurityGroup.get_objects("},{"line_number":609,"context_line":"                        context, tenant_id\u003dtenant_id)"},{"line_number":610,"context_line":"                return default_group[\u0027security_group_id\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_0712f608","line":607,"updated":"2016-02-17 15:36:06.000000000","message":"ditto","commit_id":"90b0525229dcd9fb932b1eeb72ae7c349b74fdeb"},{"author":{"_account_id":9178,"name":"Sayali Lunkad","email":"sayali.lunkad@suse.com","username":"sayalilunkad"},"change_message_id":"5e66171bd05487750cfe03cb5b4e22c628a43c97","unresolved":false,"context_lines":[{"line_number":604,"context_line":"        # Make no more than two attempts"},{"line_number":605,"context_line":"        for attempts in (1, 2):"},{"line_number":606,"context_line":"            try:"},{"line_number":607,"context_line":"                default_group \\"},{"line_number":608,"context_line":"                    \u003d obj_securitygroup.DefaultSecurityGroup.get_objects("},{"line_number":609,"context_line":"                        context, tenant_id\u003dtenant_id)"},{"line_number":610,"context_line":"                return default_group[\u0027security_group_id\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_0f4a0826","line":607,"in_reply_to":"dae33548_fc0e898a","updated":"2016-02-17 16:38:50.000000000","message":"Done","commit_id":"90b0525229dcd9fb932b1eeb72ae7c349b74fdeb"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"e2f0bd2587feb4eb94fa224d5d88deab9a6935c9","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                name\u003ds[\u0027name\u0027])"},{"line_number":90,"context_line":"            security_group_obj.create()"},{"line_number":91,"context_line":"            if default_sg:"},{"line_number":92,"context_line":"                default_security_group_obj \u003d ("},{"line_number":93,"context_line":"                    obj_securitygroup.DefaultSecurityGroup("},{"line_number":94,"context_line":"                        security_group\u003dsecurity_group_obj,"},{"line_number":95,"context_line":"                        tenant_id\u003dsecurity_group_obj[\u0027tenant_id\u0027]))"}],"source_content_type":"text/x-python","patch_set":11,"id":"1aa78d24_e46457e6","line":92,"updated":"2016-07-05 15:38:08.000000000","message":"here you want to use the is_default field of the object","commit_id":"a810c4e46388e5be878853923ee2aaf455fae753"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"ad0f4f0d45d56ee7ef0883700024dd820cc1e7d6","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                name\u003ds[\u0027name\u0027])"},{"line_number":90,"context_line":"            security_group_obj.create()"},{"line_number":91,"context_line":"            if default_sg:"},{"line_number":92,"context_line":"                default_security_group_obj \u003d ("},{"line_number":93,"context_line":"                    obj_securitygroup.DefaultSecurityGroup("},{"line_number":94,"context_line":"                        security_group\u003dsecurity_group_obj,"},{"line_number":95,"context_line":"                        tenant_id\u003dsecurity_group_obj[\u0027tenant_id\u0027]))"}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_1f6e2d96","line":92,"in_reply_to":"1aa78d24_e46457e6","updated":"2016-07-19 09:54:33.000000000","message":"I do not think that is-default from SG object should be used here. We can use the DefaultSecurityGroup object here, and remove the is-default from SG object.","commit_id":"a810c4e46388e5be878853923ee2aaf455fae753"},{"author":{"_account_id":9178,"name":"Sayali Lunkad","email":"sayali.lunkad@suse.com","username":"sayalilunkad"},"change_message_id":"ec4bb59d64457f55567336753e18441b76a314dd","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                name\u003ds[\u0027name\u0027])"},{"line_number":90,"context_line":"            security_group_obj.create()"},{"line_number":91,"context_line":"            if default_sg:"},{"line_number":92,"context_line":"                default_security_group_obj \u003d ("},{"line_number":93,"context_line":"                    obj_securitygroup.DefaultSecurityGroup("},{"line_number":94,"context_line":"                        security_group\u003dsecurity_group_obj,"},{"line_number":95,"context_line":"                        tenant_id\u003dsecurity_group_obj[\u0027tenant_id\u0027]))"}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_687dedb0","line":92,"in_reply_to":"dada55a8_1f6e2d96","updated":"2016-07-19 11:10:45.000000000","message":"I agree with Artur. I don\u0027t see how is_default will be useful here. The condition is already been taken care of in line 80.","commit_id":"a810c4e46388e5be878853923ee2aaf455fae753"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"df69b6654d88c80a6f9ca66af75f3251062bc98e","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                name\u003ds[\u0027name\u0027])"},{"line_number":90,"context_line":"            security_group_obj.create()"},{"line_number":91,"context_line":"            if default_sg:"},{"line_number":92,"context_line":"                default_security_group_obj \u003d ("},{"line_number":93,"context_line":"                    obj_securitygroup.DefaultSecurityGroup("},{"line_number":94,"context_line":"                        security_group\u003dsecurity_group_obj,"},{"line_number":95,"context_line":"                        tenant_id\u003dsecurity_group_obj[\u0027tenant_id\u0027]))"}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_1f754063","line":92,"in_reply_to":"dada55a8_687dedb0","updated":"2016-07-20 14:25:56.000000000","message":"What I meant here is that since we have objects you could simply do:\n\nsecurity_group_obj \u003d obj_securitygroup.SecurityGroup(\n                context,\n                id,\n                description\u003ds[\u0027description\u0027],\n                tenant_id\u003dtenant_id,\n                name\u003ds[\u0027name\u0027],\n                is_default\u003ddefault_sg)\n\nPeople we still need the is_default attribute, how would you otherwise check if a sec group is the default one? In my mind the DefaultSecurityGroup object should be only used internally in the SecurityGroup object, outside we should use only the is_default field. The way this tables were designed it\u0027s confusing, let\u0027s try to simplify the usage with the ovo not to copy the same behavior.","commit_id":"a810c4e46388e5be878853923ee2aaf455fae753"}],"neutron/objects/port/extensions/securitygroups.py":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"a9da94ba79dfcb89fc34a2345c7d236956fdaaa2","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    db_model \u003d models.SecurityGroup"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    primary_key \u003d \u0027sg_id\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    fields_no_update \u003d [\u0027sg_id\u0027]"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_b6f4225b","line":27,"updated":"2016-02-17 15:36:06.000000000","message":"I think it\u0027s \u0027id\u0027, isn\u0027t it?","commit_id":"90b0525229dcd9fb932b1eeb72ae7c349b74fdeb"},{"author":{"_account_id":9178,"name":"Sayali Lunkad","email":"sayali.lunkad@suse.com","username":"sayalilunkad"},"change_message_id":"5e66171bd05487750cfe03cb5b4e22c628a43c97","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    db_model \u003d models.SecurityGroup"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    primary_key \u003d \u0027sg_id\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    fields_no_update \u003d [\u0027sg_id\u0027]"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_ef79a483","line":27,"in_reply_to":"dae33548_b6f4225b","updated":"2016-02-17 16:38:50.000000000","message":"Done","commit_id":"90b0525229dcd9fb932b1eeb72ae7c349b74fdeb"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"a9da94ba79dfcb89fc34a2345c7d236956fdaaa2","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    fields_no_update \u003d [\u0027sg_id\u0027]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    fields \u003d {"},{"line_number":32,"context_line":"        \u0027sg_id\u0027: obj_feilds.UUIDField(),"},{"line_number":33,"context_line":"        \u0027name\u0027: obj_fields.StringField(),"},{"line_number":34,"context_line":"        \u0027description\u0027: obj_fields.StringField(),"},{"line_number":35,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_5604b648","line":32,"updated":"2016-02-17 15:36:06.000000000","message":"ditto","commit_id":"90b0525229dcd9fb932b1eeb72ae7c349b74fdeb"},{"author":{"_account_id":9178,"name":"Sayali Lunkad","email":"sayali.lunkad@suse.com","username":"sayalilunkad"},"change_message_id":"5e66171bd05487750cfe03cb5b4e22c628a43c97","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    fields_no_update \u003d [\u0027sg_id\u0027]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    fields \u003d {"},{"line_number":32,"context_line":"        \u0027sg_id\u0027: obj_feilds.UUIDField(),"},{"line_number":33,"context_line":"        \u0027name\u0027: obj_fields.StringField(),"},{"line_number":34,"context_line":"        \u0027description\u0027: obj_fields.StringField(),"},{"line_number":35,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_0f95e885","line":32,"in_reply_to":"dae33548_5604b648","updated":"2016-02-17 16:38:50.000000000","message":"Done","commit_id":"90b0525229dcd9fb932b1eeb72ae7c349b74fdeb"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"a9da94ba79dfcb89fc34a2345c7d236956fdaaa2","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    db_model \u003d models.DefaultSecurityGroup"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    primary_key \u003d \u0027tenant_id\u0027"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    fields_no_update \u003d [\u0027tenant_id\u0027, \u0027security_group_id\u0027]"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_362492c3","line":45,"updated":"2016-02-17 15:36:06.000000000","message":"once https://review.openstack.org/#/c/275790/ merges we will be able to handle composite keys, that\u0027s the case here, please add a TODO, security_group_id is also a primary key","commit_id":"90b0525229dcd9fb932b1eeb72ae7c349b74fdeb"},{"author":{"_account_id":9178,"name":"Sayali Lunkad","email":"sayali.lunkad@suse.com","username":"sayalilunkad"},"change_message_id":"5e66171bd05487750cfe03cb5b4e22c628a43c97","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    db_model \u003d models.DefaultSecurityGroup"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    primary_key \u003d \u0027tenant_id\u0027"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    fields_no_update \u003d [\u0027tenant_id\u0027, \u0027security_group_id\u0027]"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_6f8e347a","line":45,"in_reply_to":"dae33548_362492c3","updated":"2016-02-17 16:38:50.000000000","message":"Done","commit_id":"90b0525229dcd9fb932b1eeb72ae7c349b74fdeb"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"a9da94ba79dfcb89fc34a2345c7d236956fdaaa2","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    db_model \u003d models.SecurityGroupPortBinding"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    primary_key \u003d \u0027port_id\u0027"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    fields_no_update \u003d [\u0027port_id\u0027, \u0027security_group_id\u0027]"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_96047e18","line":62,"updated":"2016-02-17 15:36:06.000000000","message":"ditto","commit_id":"90b0525229dcd9fb932b1eeb72ae7c349b74fdeb"},{"author":{"_account_id":9178,"name":"Sayali Lunkad","email":"sayali.lunkad@suse.com","username":"sayalilunkad"},"change_message_id":"5e66171bd05487750cfe03cb5b4e22c628a43c97","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    db_model \u003d models.SecurityGroupPortBinding"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    primary_key \u003d \u0027port_id\u0027"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    fields_no_update \u003d [\u0027port_id\u0027, \u0027security_group_id\u0027]"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_4f8b7068","line":62,"in_reply_to":"dae33548_96047e18","updated":"2016-02-17 16:38:50.000000000","message":"Done","commit_id":"90b0525229dcd9fb932b1eeb72ae7c349b74fdeb"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"a9da94ba79dfcb89fc34a2345c7d236956fdaaa2","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    db_model \u003d models.SecurityGroupRule"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    primary_key \u003d \u0027security_group_id\u0027"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    fields_no_update \u003d [\u0027security_group_id\u0027, \u0027remote_group_id\u0027]"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_41122e58","line":79,"updated":"2016-02-17 15:36:06.000000000","message":"ditto","commit_id":"90b0525229dcd9fb932b1eeb72ae7c349b74fdeb"},{"author":{"_account_id":9178,"name":"Sayali Lunkad","email":"sayali.lunkad@suse.com","username":"sayalilunkad"},"change_message_id":"5e66171bd05487750cfe03cb5b4e22c628a43c97","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    db_model \u003d models.SecurityGroupRule"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    primary_key \u003d \u0027security_group_id\u0027"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    fields_no_update \u003d [\u0027security_group_id\u0027, \u0027remote_group_id\u0027]"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_afeafc0c","line":79,"in_reply_to":"dae33548_41122e58","updated":"2016-02-17 16:38:50.000000000","message":"Done","commit_id":"90b0525229dcd9fb932b1eeb72ae7c349b74fdeb"}],"neutron/tests/unit/objects/port/extensions/test_securitygroups.py":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"a9da94ba79dfcb89fc34a2345c7d236956fdaaa2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_27b29a06","line":1,"updated":"2016-02-17 15:36:06.000000000","message":"for the tests you can do something similar to [1]\n\n[1] https://review.openstack.org/#/c/268274/11/neutron/tests/unit/objects/port/extensions/test_allowedaddresspairs.py","commit_id":"90b0525229dcd9fb932b1eeb72ae7c349b74fdeb"}]}
