)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"13b275a7c9a7b0b7b455fcd20ea1fac1086d6dc7","unresolved":false,"context_lines":[{"line_number":12,"context_line":"are duplicated."},{"line_number":13,"context_line":"The goal of this patch is to solve these problems."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I262973126e8ca5af2b20a3a5bc35dea4251c0a78"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a5ae5dd_c142cead","line":15,"updated":"2016-02-08 12:59:53.000000000","message":"I would like to backport the fix to Liberty once it\u0027s merged in M. Can you create a bug to track it?","commit_id":"f433f638d7f8daf06a0b1da9b6c89de73af7b0e8"}],"neutron/plugins/ml2/drivers/mech_agent.py":[{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"e14b0a8e870f738a5c8fccef040cd92e3df19afe","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                LOG.warning(_LW(\"Refusing to bind port %(pid)s to dead agent: \""},{"line_number":78,"context_line":"                                \"%(agent)s\"),"},{"line_number":79,"context_line":"                            {\u0027pid\u0027: context.current[\u0027id\u0027], \u0027agent\u0027: agent})"},{"line_number":80,"context_line":"        LOG.info(_LI(\"Port %(pid)s on network %(network)s not bound using \""},{"line_number":81,"context_line":"                     \"using agents %(agents)s on host %(host)s\"),"},{"line_number":82,"context_line":"                 {\u0027pid\u0027: context.current[\u0027id\u0027],"},{"line_number":83,"context_line":"                  \u0027network\u0027: context.network.current[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"dae33548_47cdd064","line":80,"range":{"start_line":80,"start_character":73,"end_line":80,"end_character":74},"updated":"2016-02-18 18:15:45.000000000","message":"nit: using twice","commit_id":"fca1645da3e87f2a3a1e26962358505ff7129840"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"1abe42c30b4aa50dc22b3b07ee50b7f0889103e2","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                LOG.warning(_LW(\"Refusing to bind port %(pid)s to dead agent: \""},{"line_number":78,"context_line":"                                \"%(agent)s\"),"},{"line_number":79,"context_line":"                            {\u0027pid\u0027: context.current[\u0027id\u0027], \u0027agent\u0027: agent})"},{"line_number":80,"context_line":"        LOG.info(_LI(\"Port %(pid)s on network %(network)s not bound using \""},{"line_number":81,"context_line":"                     \"using agents %(agents)s on host %(host)s\"),"},{"line_number":82,"context_line":"                 {\u0027pid\u0027: context.current[\u0027id\u0027],"},{"line_number":83,"context_line":"                  \u0027network\u0027: context.network.current[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aed3d3a_4013ac66","line":80,"range":{"start_line":80,"start_character":73,"end_line":80,"end_character":74},"in_reply_to":"dae33548_47cdd064","updated":"2016-02-26 15:20:49.000000000","message":"Done","commit_id":"fca1645da3e87f2a3a1e26962358505ff7129840"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"bfac1789426d9486b6c6b88fc4b74e7289f206df","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                LOG.warning(_LW(\"Refusing to bind port %(pid)s to dead agent: \""},{"line_number":78,"context_line":"                                \"%(agent)s\"),"},{"line_number":79,"context_line":"                            {\u0027pid\u0027: context.current[\u0027id\u0027], \u0027agent\u0027: agent})"},{"line_number":80,"context_line":"        LOG.info(_LI(\"Port %(pid)s on network %(network)s not bound using \""},{"line_number":81,"context_line":"                     \"agents %(agents)s on host %(host)s\"),"},{"line_number":82,"context_line":"                 {\u0027pid\u0027: context.current[\u0027id\u0027],"},{"line_number":83,"context_line":"                  \u0027network\u0027: context.network.current[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"9aed3d3a_0bd4251e","line":80,"updated":"2016-02-26 15:27:42.000000000","message":"is there any way we can move this logic up into the manager so it\u0027s only logged if all of the drivers fail to bind a port?","commit_id":"21d6993c1e860b2749b3563ed1870418de544327"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"12e955200a42c245f9e7cfe7c981b7030c6aae59","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                LOG.warning(_LW(\"Refusing to bind port %(pid)s to dead agent: \""},{"line_number":78,"context_line":"                                \"%(agent)s\"),"},{"line_number":79,"context_line":"                            {\u0027pid\u0027: context.current[\u0027id\u0027], \u0027agent\u0027: agent})"},{"line_number":80,"context_line":"        LOG.info(_LI(\"Port %(pid)s on network %(network)s not bound using \""},{"line_number":81,"context_line":"                     \"agents %(agents)s on host %(host)s\"),"},{"line_number":82,"context_line":"                 {\u0027pid\u0027: context.current[\u0027id\u0027],"},{"line_number":83,"context_line":"                  \u0027network\u0027: context.network.current[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_2d1df90f","line":80,"in_reply_to":"9aed3d3a_0bd4251e","updated":"2016-03-01 13:03:12.000000000","message":"Actually there\u0027s already a log entry in the manager. I have remember I\u0027ve only put this to verify if agents is empty, let me modify it, thanks!","commit_id":"21d6993c1e860b2749b3563ed1870418de544327"}],"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"9a2b9d0ea66524ca428cb3c7efe953761be1e8b5","unresolved":false,"context_lines":[{"line_number":1463,"context_line":"                                          details[\u0027network_id\u0027])"},{"line_number":1464,"context_line":"                self.ext_manager.handle_port(self.context, details)"},{"line_number":1465,"context_line":"            else:"},{"line_number":1466,"context_line":"                LOG.warn("},{"line_number":1467,"context_line":"                    _LW(\"Device %s not defined on plugin or binding failed\"),"},{"line_number":1468,"context_line":"                    device)"},{"line_number":1469,"context_line":"                if (port and port.ofport !\u003d -1):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a57f1b5_6287ccd7","line":1466,"updated":"2016-02-11 12:39:45.000000000","message":"please use log.warning instread. log.warn is meant to be deprecated. there is a patch with a hacking rule https://review.openstack.org/278277","commit_id":"a02be3644a9942e805445b355c7d6730f302a8b7"}],"neutron/plugins/ml2/managers.py":[{"author":{"_account_id":11347,"name":"Rui Zang","email":"rui.zang@yandex.com","username":"rzang"},"change_message_id":"1fe316b5f2cd106c4e5204f6117ccf4a476736eb","unresolved":false,"context_lines":[{"line_number":748,"context_line":"                LOG.exception(_LE(\"Mechanism driver %s failed in \""},{"line_number":749,"context_line":"                                  \"bind_port\"),"},{"line_number":750,"context_line":"                              driver.name)"},{"line_number":751,"context_line":"        LOG.error(_LE(\"Failed to bind port %(port)s on host %(host)s\"),"},{"line_number":752,"context_line":"                  {\u0027port\u0027: context.current[\u0027id\u0027],"},{"line_number":753,"context_line":"                   \u0027host\u0027: binding.host})"},{"line_number":754,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_411e3560","side":"PARENT","line":751,"updated":"2016-02-05 06:49:09.000000000","message":"I do not think it is a good idea to regard this logging as duplication and remove it.  _bind_port_level() is nested, it is called inside itself for multiple levels.\nIMHO, this logging should be kept, maybe change the to debug level, and add binding level information to the logs.","commit_id":"b80d77ddfee55115c866747957e8448d2615bb60"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"7e518a27f56d83b419fbb7aac0a6a8bf5f2eb64f","unresolved":false,"context_lines":[{"line_number":748,"context_line":"                LOG.exception(_LE(\"Mechanism driver %s failed in \""},{"line_number":749,"context_line":"                                  \"bind_port\"),"},{"line_number":750,"context_line":"                              driver.name)"},{"line_number":751,"context_line":"        LOG.error(_LE(\"Failed to bind port %(port)s on host %(host)s\"),"},{"line_number":752,"context_line":"                  {\u0027port\u0027: context.current[\u0027id\u0027],"},{"line_number":753,"context_line":"                   \u0027host\u0027: binding.host})"},{"line_number":754,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_e9b11602","side":"PARENT","line":751,"in_reply_to":"5a5ae5dd_411e3560","updated":"2016-02-06 10:34:23.000000000","message":"Look at line 690. bind_port calls this method and print a message if this method returns False, so this message is duplicated EVERY time","commit_id":"b80d77ddfee55115c866747957e8448d2615bb60"},{"author":{"_account_id":11347,"name":"Rui Zang","email":"rui.zang@yandex.com","username":"rzang"},"change_message_id":"34a7f1cbbe4417e2536cb0ac7842f8a77e4d2a3d","unresolved":false,"context_lines":[{"line_number":748,"context_line":"                LOG.exception(_LE(\"Mechanism driver %s failed in \""},{"line_number":749,"context_line":"                                  \"bind_port\"),"},{"line_number":750,"context_line":"                              driver.name)"},{"line_number":751,"context_line":"        LOG.error(_LE(\"Failed to bind port %(port)s on host %(host)s\"),"},{"line_number":752,"context_line":"                  {\u0027port\u0027: context.current[\u0027id\u0027],"},{"line_number":753,"context_line":"                   \u0027host\u0027: binding.host})"},{"line_number":754,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_e7eb36af","side":"PARENT","line":751,"in_reply_to":"5a5ae5dd_e9b11602","updated":"2016-02-14 01:51:52.000000000","message":"I do not think you got my point. In multiple levels binding scenario, I would like to see an error log telling me at which LEVEL the binding fails. \nMy suggestion is to adding binding LEVEL information to this logging instead of remove it.\n\nL690 only logs once, but L751 logs for every binding level.","commit_id":"b80d77ddfee55115c866747957e8448d2615bb60"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"ea3a70687a88c521a723615d666f8e380cca41dd","unresolved":false,"context_lines":[{"line_number":748,"context_line":"                LOG.exception(_LE(\"Mechanism driver %s failed in \""},{"line_number":749,"context_line":"                                  \"bind_port\"),"},{"line_number":750,"context_line":"                              driver.name)"},{"line_number":751,"context_line":"        LOG.error(_LE(\"Failed to bind port %(port)s on host %(host)s\"),"},{"line_number":752,"context_line":"                  {\u0027port\u0027: context.current[\u0027id\u0027],"},{"line_number":753,"context_line":"                   \u0027host\u0027: binding.host})"},{"line_number":754,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_bca673be","side":"PARENT","line":751,"in_reply_to":"dae33548_e7eb36af","updated":"2016-02-18 17:55:06.000000000","message":"I see, have a look at next PS please...","commit_id":"b80d77ddfee55115c866747957e8448d2615bb60"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"351398a3daed3f8790e5aef3589bf74f2ef48519","unresolved":false,"context_lines":[{"line_number":734,"context_line":"                                                 next_segments):"},{"line_number":735,"context_line":"                            return True"},{"line_number":736,"context_line":"                        else:"},{"line_number":737,"context_line":"                            LOG.warning(_LW(\"Failed to bing port %(port)s on \""},{"line_number":738,"context_line":"                                            \"host %(host)s at level %(lvl)s\"),"},{"line_number":739,"context_line":"                                        {\u0027port\u0027: context.current[\u0027id\u0027],"},{"line_number":740,"context_line":"                                         \u0027host\u0027: context.host,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7af24918_cf06ff1f","line":737,"range":{"start_line":737,"start_character":55,"end_line":737,"end_character":59},"updated":"2016-03-01 14:56:06.000000000","message":"bind","commit_id":"d7901bc0e1f0ed7892af1e86047357cbc8e3c559"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"8eb9177817171649697bbb2f6009cd7aa62187ed","unresolved":false,"context_lines":[{"line_number":734,"context_line":"                                                 next_segments):"},{"line_number":735,"context_line":"                            return True"},{"line_number":736,"context_line":"                        else:"},{"line_number":737,"context_line":"                            LOG.warning(_LW(\"Failed to bing port %(port)s on \""},{"line_number":738,"context_line":"                                            \"host %(host)s at level %(lvl)s\"),"},{"line_number":739,"context_line":"                                        {\u0027port\u0027: context.current[\u0027id\u0027],"},{"line_number":740,"context_line":"                                         \u0027host\u0027: context.host,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7af24918_8dab1f1d","line":737,"range":{"start_line":737,"start_character":55,"end_line":737,"end_character":59},"in_reply_to":"7af24918_cf06ff1f","updated":"2016-03-02 11:55:19.000000000","message":"doh","commit_id":"d7901bc0e1f0ed7892af1e86047357cbc8e3c559"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ee4f4524552d0f214ec12273936f09be4439fa02","unresolved":false,"context_lines":[{"line_number":750,"context_line":"                              driver.name)"},{"line_number":751,"context_line":"        LOG.error(_LE(\"Failed to bind port %(port)s on host %(host)s\"),"},{"line_number":752,"context_line":"                  {\u0027port\u0027: context.current[\u0027id\u0027],"},{"line_number":753,"context_line":"                   \u0027host\u0027: binding.host})"},{"line_number":754,"context_line":""},{"line_number":755,"context_line":"    def _check_driver_to_bind(self, driver, segments_to_bind, binding_levels):"},{"line_number":756,"context_line":"        # To prevent a possible binding loop, don\u0027t try to bind with"}],"source_content_type":"text/x-python","patch_set":10,"id":"7af24918_601faa5f","side":"PARENT","line":753,"updated":"2016-03-02 15:10:02.000000000","message":"(question) Can we safely delete this logging?\nI think it is okay for most cases, but there are some corner case.\n\n- when _check_driver_to_bind return False for all drivers.\n- context._new_bound_segment is empty (we use \u0027if\u0027 at L.723, so I am afraid there might be a case where it is empty)\n\nI don\u0027t follow the whole logic now, so these might never happen.","commit_id":"b9ef98b4f7f56c0be3007cbc735bec7f87576c5a"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"e13dcaa147c941f40bae6ce3c504b4c02f6f805e","unresolved":false,"context_lines":[{"line_number":750,"context_line":"                              driver.name)"},{"line_number":751,"context_line":"        LOG.error(_LE(\"Failed to bind port %(port)s on host %(host)s\"),"},{"line_number":752,"context_line":"                  {\u0027port\u0027: context.current[\u0027id\u0027],"},{"line_number":753,"context_line":"                   \u0027host\u0027: binding.host})"},{"line_number":754,"context_line":""},{"line_number":755,"context_line":"    def _check_driver_to_bind(self, driver, segments_to_bind, binding_levels):"},{"line_number":756,"context_line":"        # To prevent a possible binding loop, don\u0027t try to bind with"}],"source_content_type":"text/x-python","patch_set":10,"id":"7af24918_e0705d42","side":"PARENT","line":753,"in_reply_to":"7af24918_601faa5f","updated":"2016-03-04 07:20:48.000000000","message":"by introducing the warning at line 737 it seems like all branches are covered.","commit_id":"b9ef98b4f7f56c0be3007cbc735bec7f87576c5a"}],"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"b2de69ef3f21279651abb43fc7835cdecda9780b","unresolved":false,"context_lines":[{"line_number":1436,"context_line":"                           filter(models_v2.Port.id.startswith(port_id))."},{"line_number":1437,"context_line":"                           one())"},{"line_number":1438,"context_line":"            except sa_exc.NoResultFound:"},{"line_number":1439,"context_line":"                LOG.info(_LI(\"No ports have port_id starting with %s\"),"},{"line_number":1440,"context_line":"                         port_id)"},{"line_number":1441,"context_line":"                return"},{"line_number":1442,"context_line":"            except sa_exc.MultipleResultsFound:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_dc24a8c7","line":1439,"updated":"2016-02-09 15:38:43.000000000","message":"Why not use LOG.error for this exception message?","commit_id":"9fcc2a0ef656f31355b5d6e3d34bce827f213515"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"2aff82912319621549bd6199d8174d18cd51f7d1","unresolved":false,"context_lines":[{"line_number":1436,"context_line":"                           filter(models_v2.Port.id.startswith(port_id))."},{"line_number":1437,"context_line":"                           one())"},{"line_number":1438,"context_line":"            except sa_exc.NoResultFound:"},{"line_number":1439,"context_line":"                LOG.info(_LI(\"No ports have port_id starting with %s\"),"},{"line_number":1440,"context_line":"                         port_id)"},{"line_number":1441,"context_line":"                return"},{"line_number":1442,"context_line":"            except sa_exc.MultipleResultsFound:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a57f1b5_a9888723","line":1439,"in_reply_to":"5a5ae5dd_dc24a8c7","updated":"2016-02-10 15:04:21.000000000","message":"because the port might have been deleted concurrently, in that case it\u0027s not an error","commit_id":"9fcc2a0ef656f31355b5d6e3d34bce827f213515"}],"neutron/plugins/ml2/rpc.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"b2de69ef3f21279651abb43fc7835cdecda9780b","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                                                     host,"},{"line_number":77,"context_line":"                                                     cached_networks)"},{"line_number":78,"context_line":"        if not port_context:"},{"line_number":79,"context_line":"            LOG.warning(_LW(\"Device %(device)s requested by agent \""},{"line_number":80,"context_line":"                            \"%(agent_id)s not found in database\"),"},{"line_number":81,"context_line":"                        {\u0027device\u0027: device, \u0027agent_id\u0027: agent_id})"},{"line_number":82,"context_line":"            return {\u0027device\u0027: device}"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_177bfb7c","side":"PARENT","line":79,"updated":"2016-02-09 15:38:43.000000000","message":"I\u0027m not sure if removing this warning message should be fine, because it\u0027ll make hard to troubleshoot it.","commit_id":"eee37a86a5ee797263d66353e6e923f6e0e57fe2"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"2aff82912319621549bd6199d8174d18cd51f7d1","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                                                     host,"},{"line_number":77,"context_line":"                                                     cached_networks)"},{"line_number":78,"context_line":"        if not port_context:"},{"line_number":79,"context_line":"            LOG.warning(_LW(\"Device %(device)s requested by agent \""},{"line_number":80,"context_line":"                            \"%(agent_id)s not found in database\"),"},{"line_number":81,"context_line":"                        {\u0027device\u0027: device, \u0027agent_id\u0027: agent_id})"},{"line_number":82,"context_line":"            return {\u0027device\u0027: device}"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a57f1b5_c9bb83c3","side":"PARENT","line":79,"in_reply_to":"5a5ae5dd_177bfb7c","updated":"2016-02-10 15:04:21.000000000","message":"it won\u0027t be harder since get_bound_port_context or the methods that are called by it will print a log message, see for example managers.py line 690","commit_id":"eee37a86a5ee797263d66353e6e923f6e0e57fe2"}],"neutron/tests/unit/plugins/ml2/test_port_binding.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"2f9f9fdb7876f678fa0c07a3e71a42f0818a0cdc","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                           status\u003dNone, network_type\u003d\u0027local\u0027):"},{"line_number":63,"context_line":"        mac_address \u003d \u0027aa:aa:aa:aa:aa:aa\u0027"},{"line_number":64,"context_line":"        host_arg \u003d {portbindings.HOST_ID: host,"},{"line_number":65,"context_line":"                    #portbindings.VNIC_TYPE: portbindings.VNIC_NORMAL,"},{"line_number":66,"context_line":"                    \u0027mac_address\u0027: mac_address}"},{"line_number":67,"context_line":"        with self.port(name\u003d\u0027name\u0027, arg_list\u003d(portbindings.HOST_ID,),"},{"line_number":68,"context_line":"                       **host_arg) as port:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_cc9ae861","line":65,"range":{"start_line":65,"start_character":0,"end_line":65,"end_character":70},"updated":"2016-02-08 21:31:54.000000000","message":"Seems to be a WIP change","commit_id":"f433f638d7f8daf06a0b1da9b6c89de73af7b0e8"}]}
