)]}'
{"neutron/db/api.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"c30812efa0aba6696ff55a3612c4706100771379","unresolved":false,"context_lines":[{"line_number":29,"context_line":"_FACADE \u003d None"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"MAX_RETRIES \u003d 10"},{"line_number":32,"context_line":"is_deadlock \u003d lambda e: isinstance(e, db_exc.DBDeadlock)"},{"line_number":33,"context_line":"is_deadlock_or_duplicate_key \u003d lambda e: isinstance("},{"line_number":34,"context_line":"    e, db_exc.DBDeadlock) or isinstance(e, db_exc.DBDuplicateEntry)"},{"line_number":35,"context_line":"retry_db_errors \u003d oslo_db_api.wrap_db_retry("}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_b9ce5e81","line":32,"range":{"start_line":32,"start_character":24,"end_line":32,"end_character":34},"updated":"2016-02-19 15:29:40.000000000","message":"Why not changing is_deadlock implementation? Indeed is_deadlock returns False for postgres HA deadlocks.","commit_id":"8be83ebf23de16d4958f12b3e2262a5c84137f31"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"d25c74a181eee64697f12f590d5cf5ca06d500e9","unresolved":false,"context_lines":[{"line_number":29,"context_line":"_FACADE \u003d None"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"MAX_RETRIES \u003d 10"},{"line_number":32,"context_line":"is_deadlock \u003d lambda e: isinstance(e, db_exc.DBDeadlock)"},{"line_number":33,"context_line":"is_deadlock_or_duplicate_key \u003d lambda e: isinstance("},{"line_number":34,"context_line":"    e, db_exc.DBDeadlock) or isinstance(e, db_exc.DBDuplicateEntry)"},{"line_number":35,"context_line":"retry_db_errors \u003d oslo_db_api.wrap_db_retry("}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_dcd2575b","line":32,"range":{"start_line":32,"start_character":24,"end_line":32,"end_character":34},"in_reply_to":"bae84128_b9ce5e81","updated":"2016-02-24 14:50:51.000000000","message":"I don\u0027t want to do that because DBDuplicateEntry can be return even if there\u0027s no deadlock but just a duplicate entry and I don\u0027t want to retry the operation in that case","commit_id":"8be83ebf23de16d4958f12b3e2262a5c84137f31"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"c30812efa0aba6696ff55a3612c4706100771379","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"MAX_RETRIES \u003d 10"},{"line_number":32,"context_line":"is_deadlock \u003d lambda e: isinstance(e, db_exc.DBDeadlock)"},{"line_number":33,"context_line":"is_deadlock_or_duplicate_key \u003d lambda e: isinstance("},{"line_number":34,"context_line":"    e, db_exc.DBDeadlock) or isinstance(e, db_exc.DBDuplicateEntry)"},{"line_number":35,"context_line":"retry_db_errors \u003d oslo_db_api.wrap_db_retry("},{"line_number":36,"context_line":"    max_retries\u003dMAX_RETRIES,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_b9ddbe72","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":28},"updated":"2016-02-19 15:29:40.000000000","message":"you can use directly:\n\n isinstance(x, (db_exc.DBDeadlock, db_ex...))","commit_id":"8be83ebf23de16d4958f12b3e2262a5c84137f31"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"d25c74a181eee64697f12f590d5cf5ca06d500e9","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"MAX_RETRIES \u003d 10"},{"line_number":32,"context_line":"is_deadlock \u003d lambda e: isinstance(e, db_exc.DBDeadlock)"},{"line_number":33,"context_line":"is_deadlock_or_duplicate_key \u003d lambda e: isinstance("},{"line_number":34,"context_line":"    e, db_exc.DBDeadlock) or isinstance(e, db_exc.DBDuplicateEntry)"},{"line_number":35,"context_line":"retry_db_errors \u003d oslo_db_api.wrap_db_retry("},{"line_number":36,"context_line":"    max_retries\u003dMAX_RETRIES,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_3cc26385","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":28},"in_reply_to":"bae84128_b9ddbe72","updated":"2016-02-24 14:50:51.000000000","message":"Done","commit_id":"8be83ebf23de16d4958f12b3e2262a5c84137f31"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"add9a1a70a832066d6681b2c280fe2664a06874a","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"MAX_RETRIES \u003d 10"},{"line_number":32,"context_line":"is_deadlock \u003d lambda e: isinstance(e, db_exc.DBDeadlock)"},{"line_number":33,"context_line":"is_deadlock_or_duplicate_key \u003d lambda e: isinstance("},{"line_number":34,"context_line":"    e, (db_exc.DBDeadlock, db_exc.DBDuplicateEntry))"},{"line_number":35,"context_line":"retry_db_errors \u003d oslo_db_api.wrap_db_retry("},{"line_number":36,"context_line":"    max_retries\u003dMAX_RETRIES,"},{"line_number":37,"context_line":"    retry_on_request\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_00d2d95b","line":34,"range":{"start_line":33,"start_character":0,"end_line":34,"end_character":52},"updated":"2016-04-14 19:04:09.000000000","message":"Nit: make this a regular method rather than a lambda.","commit_id":"f52b031d7df9a0abe9cf474d0051a435bfd0777f"}]}