)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"766713927611e00dc6ecf77cf6a76116b836fb1d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Stops update_network() from using bad attributes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently update_network() has no checks for ensuring the network"},{"line_number":10,"context_line":"variable is  not updated with invalid parameters. This was causing"},{"line_number":11,"context_line":"certain update commands  to fail (such as updating dns_domain). The"},{"line_number":12,"context_line":"actual update to dns_domain is  handled elsewhere, but this function"},{"line_number":13,"context_line":"was also trying to process it and causing  an error."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a57f1b5_399c1369","line":10,"updated":"2016-02-09 19:30:52.000000000","message":"I think you have a problem with the commit message. I think that what you want to say here is that currently the update_network method in db_base_plugin_v2 will attempt to update the network table with attributes that belong to a network but are stored in a separate table and are supposed to be updated by a ML2 extension after update_network in db_base_plugin_v2 is executed","commit_id":"373031749d4e22095e553f7183e5a9cd59957bf5"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"5637de6e96895fc49c4e20cc196c0c5e2078b5fe","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Stops update_network() from using bad attributes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently update_network() has no checks for ensuring the network"},{"line_number":10,"context_line":"variable is  not updated with invalid parameters. This was causing"},{"line_number":11,"context_line":"certain update commands  to fail (such as updating dns_domain). The"},{"line_number":12,"context_line":"actual update to dns_domain is  handled elsewhere, but this function"},{"line_number":13,"context_line":"was also trying to process it and causing  an error."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dae33548_0eeaf8ab","line":10,"in_reply_to":"3a57f1b5_399c1369","updated":"2016-02-17 23:17:34.000000000","message":"Done","commit_id":"373031749d4e22095e553f7183e5a9cd59957bf5"}],"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"766713927611e00dc6ecf77cf6a76116b836fb1d","unresolved":false,"context_lines":[{"line_number":353,"context_line":"                elif not update_shared and entry:"},{"line_number":354,"context_line":"                    context.session.delete(entry)"},{"line_number":355,"context_line":"                    context.session.expire(network, [\u0027rbac_entries\u0027])"},{"line_number":356,"context_line":"            network.update(self._filter_non_model_columns(n, models_v2.Network))"},{"line_number":357,"context_line":"        return self._make_network_dict(network, context\u003dcontext)"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    def delete_network(self, context, id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a57f1b5_19c4b73e","line":356,"updated":"2016-02-09 19:30:52.000000000","message":"I would add a comment in the code here that to solve the problem described in the commit message (and also in the Launchpad bug) this is the solution you have found so far. Ask if anyone knows another solution","commit_id":"373031749d4e22095e553f7183e5a9cd59957bf5"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"5637de6e96895fc49c4e20cc196c0c5e2078b5fe","unresolved":false,"context_lines":[{"line_number":353,"context_line":"                elif not update_shared and entry:"},{"line_number":354,"context_line":"                    context.session.delete(entry)"},{"line_number":355,"context_line":"                    context.session.expire(network, [\u0027rbac_entries\u0027])"},{"line_number":356,"context_line":"            network.update(self._filter_non_model_columns(n, models_v2.Network))"},{"line_number":357,"context_line":"        return self._make_network_dict(network, context\u003dcontext)"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    def delete_network(self, context, id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_aeab0c74","line":356,"in_reply_to":"3a57f1b5_19c4b73e","updated":"2016-02-17 23:17:34.000000000","message":"Done","commit_id":"373031749d4e22095e553f7183e5a9cd59957bf5"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"f18cc1b63d9cedff89eaba131175fcec61cc86c3","unresolved":false,"context_lines":[{"line_number":353,"context_line":"                elif not update_shared and entry:"},{"line_number":354,"context_line":"                    context.session.delete(entry)"},{"line_number":355,"context_line":"                    context.session.expire(network, [\u0027rbac_entries\u0027])"},{"line_number":356,"context_line":"            network.update(self._filter_non_model_columns(n, models_v2.Network))"},{"line_number":357,"context_line":"        return self._make_network_dict(network, context\u003dcontext)"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    def delete_network(self, context, id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a57f1b5_391df3bd","line":356,"in_reply_to":"3a57f1b5_19c4b73e","updated":"2016-02-09 19:33:24.000000000","message":"You also need to break this line. It is longer than 79 columns. That is why you are failing the constraints job in Jenkins","commit_id":"373031749d4e22095e553f7183e5a9cd59957bf5"},{"author":{"_account_id":7244,"name":"Victor Howard","email":"victor.r.howard@gmail.com","username":"vichoward"},"change_message_id":"13e94cb81c5b0186fbffca4d713a0c912ec9186e","unresolved":false,"context_lines":[{"line_number":353,"context_line":"                elif not update_shared and entry:"},{"line_number":354,"context_line":"                    context.session.delete(entry)"},{"line_number":355,"context_line":"                    context.session.expire(network, [\u0027rbac_entries\u0027])"},{"line_number":356,"context_line":"            network.update(self._filter_non_model_columns(n, models_v2.Network))"},{"line_number":357,"context_line":"        return self._make_network_dict(network, context\u003dcontext)"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    def delete_network(self, context, id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a57f1b5_a434574a","line":356,"in_reply_to":"3a57f1b5_391df3bd","updated":"2016-02-09 21:08:42.000000000","message":"+1","commit_id":"373031749d4e22095e553f7183e5a9cd59957bf5"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"5637de6e96895fc49c4e20cc196c0c5e2078b5fe","unresolved":false,"context_lines":[{"line_number":353,"context_line":"                elif not update_shared and entry:"},{"line_number":354,"context_line":"                    context.session.delete(entry)"},{"line_number":355,"context_line":"                    context.session.expire(network, [\u0027rbac_entries\u0027])"},{"line_number":356,"context_line":"            network.update(self._filter_non_model_columns(n, models_v2.Network))"},{"line_number":357,"context_line":"        return self._make_network_dict(network, context\u003dcontext)"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    def delete_network(self, context, id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_8ea8c878","line":356,"in_reply_to":"3a57f1b5_391df3bd","updated":"2016-02-17 23:17:34.000000000","message":"Done","commit_id":"373031749d4e22095e553f7183e5a9cd59957bf5"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"5637de6e96895fc49c4e20cc196c0c5e2078b5fe","unresolved":false,"context_lines":[{"line_number":353,"context_line":"                elif not update_shared and entry:"},{"line_number":354,"context_line":"                    context.session.delete(entry)"},{"line_number":355,"context_line":"                    context.session.expire(network, [\u0027rbac_entries\u0027])"},{"line_number":356,"context_line":"            network.update(self._filter_non_model_columns(n, models_v2.Network))"},{"line_number":357,"context_line":"        return self._make_network_dict(network, context\u003dcontext)"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    def delete_network(self, context, id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_cebc90bd","line":356,"in_reply_to":"3a57f1b5_a434574a","updated":"2016-02-17 23:17:34.000000000","message":"Done","commit_id":"373031749d4e22095e553f7183e5a9cd59957bf5"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"1b8590c2ca135ae72ac9255724b75c9dbeba3e9e","unresolved":false,"context_lines":[{"line_number":356,"context_line":"            # The filter call solves the problem of attempting to update"},{"line_number":357,"context_line":"            # a network with parameters that it doesn\u0027t care about here,"},{"line_number":358,"context_line":"            # which could result in an error. If anyone knows a better"},{"line_number":359,"context_line":"            # solution to this problem, I\u0027d love to hear it!"},{"line_number":360,"context_line":"            network.update(self._filter_non_model_columns(n,"},{"line_number":361,"context_line":"                                                          models_v2.Network))"},{"line_number":362,"context_line":"        return self._make_network_dict(network, context\u003dcontext)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_d17a6e23","line":359,"updated":"2016-02-23 21:39:29.000000000","message":"Now that we have an agreement that this is a real bug that needs to be addressed, I would modify this comment to reflect better what is being done. I would do something like:\n\"The filter call removes attributes from the body we got from the API that belong logically to network resources but are stored in other DB tables by extensions\"","commit_id":"ded034e539c5b8509e3da8232adecdd4d7347f32"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"76c43fd7bd2d371aab760880fe341b2fd4d9bb0f","unresolved":false,"context_lines":[{"line_number":356,"context_line":"            # The filter call solves the problem of attempting to update"},{"line_number":357,"context_line":"            # a network with parameters that it doesn\u0027t care about here,"},{"line_number":358,"context_line":"            # which could result in an error. If anyone knows a better"},{"line_number":359,"context_line":"            # solution to this problem, I\u0027d love to hear it!"},{"line_number":360,"context_line":"            network.update(self._filter_non_model_columns(n,"},{"line_number":361,"context_line":"                                                          models_v2.Network))"},{"line_number":362,"context_line":"        return self._make_network_dict(network, context\u003dcontext)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_3cb9f12e","line":359,"in_reply_to":"bae84128_d17a6e23","updated":"2016-02-23 21:53:03.000000000","message":"Done","commit_id":"ded034e539c5b8509e3da8232adecdd4d7347f32"}],"neutron/tests/unit/extensions/test_dns.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"70f9238e639fe04e48fc774ed8a7f43c938a222c","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        ext_mgr \u003d DnsExtensionManager()"},{"line_number":58,"context_line":"        super(DnsExtensionTestCase, self).setUp(plugin\u003dplugin, ext_mgr\u003dext_mgr)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def _create_network(self, fmt, name, admin_state_up,"},{"line_number":61,"context_line":"                        arg_list\u003dNone, set_context\u003dFalse, tenant_id\u003dNone,"},{"line_number":62,"context_line":"                        **kwargs):"},{"line_number":63,"context_line":"        tenant_id \u003d tenant_id or self._tenant_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_ea04467f","line":60,"range":{"start_line":60,"start_character":4,"end_line":60,"end_character":23},"updated":"2016-02-22 05:33:49.000000000","message":"Where is this method used?","commit_id":"e9e50d007ad0a4d1bb5855c0d77856e34d2faeab"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"e695ccdaaf749e1bc158d98e8b2fd8f1ccbe466b","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        ext_mgr \u003d DnsExtensionManager()"},{"line_number":58,"context_line":"        super(DnsExtensionTestCase, self).setUp(plugin\u003dplugin, ext_mgr\u003dext_mgr)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def _create_network(self, fmt, name, admin_state_up,"},{"line_number":61,"context_line":"                        arg_list\u003dNone, set_context\u003dFalse, tenant_id\u003dNone,"},{"line_number":62,"context_line":"                        **kwargs):"},{"line_number":63,"context_line":"        tenant_id \u003d tenant_id or self._tenant_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_e12d36a9","line":60,"range":{"start_line":60,"start_character":4,"end_line":60,"end_character":23},"in_reply_to":"bae84128_d6da92e7","updated":"2016-02-23 16:01:06.000000000","message":"Agreed, those are much better solutions. I\u0027ve implemented the former now.","commit_id":"e9e50d007ad0a4d1bb5855c0d77856e34d2faeab"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"475bb73a398566751806476f415ae4011e25b73b","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        ext_mgr \u003d DnsExtensionManager()"},{"line_number":58,"context_line":"        super(DnsExtensionTestCase, self).setUp(plugin\u003dplugin, ext_mgr\u003dext_mgr)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def _create_network(self, fmt, name, admin_state_up,"},{"line_number":61,"context_line":"                        arg_list\u003dNone, set_context\u003dFalse, tenant_id\u003dNone,"},{"line_number":62,"context_line":"                        **kwargs):"},{"line_number":63,"context_line":"        tenant_id \u003d tenant_id or self._tenant_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_d6da92e7","line":60,"range":{"start_line":60,"start_character":4,"end_line":60,"end_character":23},"in_reply_to":"bae84128_dab01746","updated":"2016-02-23 06:11:39.000000000","message":"Why did you re-create most duplicated code? For example, you can override a part of the method like [1] OR you can use arg_list like [2].\n\n[1]: https://github.com/openstack/neutron/blob/master/neutron/tests/unit/extensions/test_external_net.py#L48-L56\n[2]: https://github.com/openstack/neutron/blob/master/neutron/tests/unit/extensions/test_portsecurity.py#L182","commit_id":"e9e50d007ad0a4d1bb5855c0d77856e34d2faeab"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"9aba59082d0a64c25f8d1fd5b2baf600f73130fc","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        ext_mgr \u003d DnsExtensionManager()"},{"line_number":58,"context_line":"        super(DnsExtensionTestCase, self).setUp(plugin\u003dplugin, ext_mgr\u003dext_mgr)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def _create_network(self, fmt, name, admin_state_up,"},{"line_number":61,"context_line":"                        arg_list\u003dNone, set_context\u003dFalse, tenant_id\u003dNone,"},{"line_number":62,"context_line":"                        **kwargs):"},{"line_number":63,"context_line":"        tenant_id \u003d tenant_id or self._tenant_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_dab01746","line":60,"range":{"start_line":60,"start_character":4,"end_line":60,"end_character":23},"in_reply_to":"bae84128_ea04467f","updated":"2016-02-22 15:38:18.000000000","message":"_create_network() is called in line 501 by the self.network() method. It looks like that calls the _make_network() method in test_db_base_plugin_v2.py, which in turn calls _create_network()","commit_id":"e9e50d007ad0a4d1bb5855c0d77856e34d2faeab"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"475bb73a398566751806476f415ae4011e25b73b","unresolved":false,"context_lines":[{"line_number":505,"context_line":"                                          network[\u0027network\u0027][\u0027id\u0027])"},{"line_number":506,"context_line":"            res \u003d req.get_response(self.api)"},{"line_number":507,"context_line":"            self.assertEqual(200, res.status_code)"},{"line_number":508,"context_line":"            self.assertFalse(\u0027dns_domain\u0027 in"},{"line_number":509,"context_line":"                             self.deserialize(self.fmt, res)[\u0027network\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_56f5e254","line":508,"range":{"start_line":508,"start_character":17,"end_line":508,"end_character":28},"updated":"2016-02-23 06:11:39.000000000","message":"It\u0027s better to use assertNotIn().","commit_id":"e9e50d007ad0a4d1bb5855c0d77856e34d2faeab"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"e695ccdaaf749e1bc158d98e8b2fd8f1ccbe466b","unresolved":false,"context_lines":[{"line_number":505,"context_line":"                                          network[\u0027network\u0027][\u0027id\u0027])"},{"line_number":506,"context_line":"            res \u003d req.get_response(self.api)"},{"line_number":507,"context_line":"            self.assertEqual(200, res.status_code)"},{"line_number":508,"context_line":"            self.assertFalse(\u0027dns_domain\u0027 in"},{"line_number":509,"context_line":"                             self.deserialize(self.fmt, res)[\u0027network\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_011f7a6c","line":508,"range":{"start_line":508,"start_character":17,"end_line":508,"end_character":28},"in_reply_to":"bae84128_56f5e254","updated":"2016-02-23 16:01:06.000000000","message":"Done","commit_id":"e9e50d007ad0a4d1bb5855c0d77856e34d2faeab"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"2d429037091417a175ea2f57ad45a4190fea576b","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    def _create_network(self, fmt, name, admin_state_up,"},{"line_number":61,"context_line":"                        arg_list\u003dNone, set_context\u003dFalse, tenant_id\u003dNone,"},{"line_number":62,"context_line":"                        **kwargs):"},{"line_number":63,"context_line":"        if (arg_list is list):"},{"line_number":64,"context_line":"            arg_list.append(\u0027dns_domain\u0027)"},{"line_number":65,"context_line":"        else:"},{"line_number":66,"context_line":"            arg_list \u003d (\u0027dns_domain\u0027,)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_1924f45b","line":63,"range":{"start_line":63,"start_character":8,"end_line":63,"end_character":30},"updated":"2016-02-24 02:50:59.000000000","message":"Is \"if type(arg_list) is list\" what you want?\n\nHowever, who passes arg_list as list?","commit_id":"5d3eba786adf3de82de256091bfc506c211160aa"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"3ec4e67416afc84dd4333a1d5c92367be80107db","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    def _create_network(self, fmt, name, admin_state_up,"},{"line_number":61,"context_line":"                        arg_list\u003dNone, set_context\u003dFalse, tenant_id\u003dNone,"},{"line_number":62,"context_line":"                        **kwargs):"},{"line_number":63,"context_line":"        if (arg_list is list):"},{"line_number":64,"context_line":"            arg_list.append(\u0027dns_domain\u0027)"},{"line_number":65,"context_line":"        else:"},{"line_number":66,"context_line":"            arg_list \u003d (\u0027dns_domain\u0027,)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_ec55e2f9","line":63,"range":{"start_line":63,"start_character":8,"end_line":63,"end_character":30},"in_reply_to":"bae84128_1924f45b","updated":"2016-02-24 17:15:39.000000000","message":"The intention was to make sure that it was actually populated, so I\u0027ve changed it to test if not None.\n\nHowever, you raise a good point. I don\u0027t actually know what type arg_list is supposed to be, as I\u0027m mostly finding it as None in the cases I\u0027m looking at (sometimes a tuple). I\u0027m changing append to the + operator, as I believe that should behave correctly for any list-like type that arg_list could be.","commit_id":"5d3eba786adf3de82de256091bfc506c211160aa"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"2d429037091417a175ea2f57ad45a4190fea576b","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        if (arg_list is list):"},{"line_number":64,"context_line":"            arg_list.append(\u0027dns_domain\u0027)"},{"line_number":65,"context_line":"        else:"},{"line_number":66,"context_line":"            arg_list \u003d (\u0027dns_domain\u0027,)"},{"line_number":67,"context_line":"        return super(DnsExtensionTestCase,"},{"line_number":68,"context_line":"                     self)._create_network(fmt, name, admin_state_up,"},{"line_number":69,"context_line":"                                           arg_list\u003darg_list,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_99b924cf","line":66,"range":{"start_line":66,"start_character":12,"end_line":66,"end_character":38},"updated":"2016-02-24 02:50:59.000000000","message":"This overrides the arg_list which caller passed. We should add \"dns_domain\" to arg_list not override.","commit_id":"5d3eba786adf3de82de256091bfc506c211160aa"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"3ec4e67416afc84dd4333a1d5c92367be80107db","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        if (arg_list is list):"},{"line_number":64,"context_line":"            arg_list.append(\u0027dns_domain\u0027)"},{"line_number":65,"context_line":"        else:"},{"line_number":66,"context_line":"            arg_list \u003d (\u0027dns_domain\u0027,)"},{"line_number":67,"context_line":"        return super(DnsExtensionTestCase,"},{"line_number":68,"context_line":"                     self)._create_network(fmt, name, admin_state_up,"},{"line_number":69,"context_line":"                                           arg_list\u003darg_list,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_cc273e61","line":66,"range":{"start_line":66,"start_character":12,"end_line":66,"end_character":38},"in_reply_to":"bae84128_99b924cf","updated":"2016-02-24 17:15:39.000000000","message":"Like I mentioned above, this line was supposed to only run if arg_list was empty, and any append-like operations would fail because one operand would be of type None. I\u0027ve updated this section to read clearer and hopefully be a more robust test.","commit_id":"5d3eba786adf3de82de256091bfc506c211160aa"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"27cb7064ec42e122f650bbd44ab41f7d94e1be48","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                        arg_list\u003dNone, set_context\u003dFalse, tenant_id\u003dNone,"},{"line_number":62,"context_line":"                        **kwargs):"},{"line_number":63,"context_line":"        new_arg_list \u003d (\u0027dns_domain\u0027,)"},{"line_number":64,"context_line":"        if (arg_list is not None):"},{"line_number":65,"context_line":"            new_arg_list \u003d arg_list + new_arg_list"},{"line_number":66,"context_line":"        return super(DnsExtensionTestCase,"},{"line_number":67,"context_line":"                     self)._create_network(fmt, name, admin_state_up,"}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_fe4d649a","line":64,"range":{"start_line":64,"start_character":11,"end_line":64,"end_character":33},"updated":"2016-02-25 05:48:50.000000000","message":"nit: The bracket is unnecessary. It\u0027s better to remove it like \"if arg_list is not None:\".","commit_id":"1384101a665572bc8c12deeb32f7c99ffea9f02f"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"4541f7d2f738911b1aa0922918e58312034428e3","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                        arg_list\u003dNone, set_context\u003dFalse, tenant_id\u003dNone,"},{"line_number":62,"context_line":"                        **kwargs):"},{"line_number":63,"context_line":"        new_arg_list \u003d (\u0027dns_domain\u0027,)"},{"line_number":64,"context_line":"        if (arg_list is not None):"},{"line_number":65,"context_line":"            new_arg_list \u003d arg_list + new_arg_list"},{"line_number":66,"context_line":"        return super(DnsExtensionTestCase,"},{"line_number":67,"context_line":"                     self)._create_network(fmt, name, admin_state_up,"}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_a49d715b","line":64,"range":{"start_line":64,"start_character":11,"end_line":64,"end_character":33},"in_reply_to":"bae84128_fe4d649a","updated":"2016-02-25 14:57:40.000000000","message":"Done","commit_id":"1384101a665572bc8c12deeb32f7c99ffea9f02f"}]}
