)]}'
{"quantum/api/api_common.py":[{"author":{"_account_id":191,"name":"Trey Morris","email":"trey.morris@rackspace.com","username":"tr3buchet"},"unresolved":false,"context_lines":[{"line_number":90,"context_line":"            try:"},{"line_number":91,"context_line":"                return func(*args, **kwargs)"},{"line_number":92,"context_line":"            except Exception as e:"},{"line_number":93,"context_line":"                if errors is not None and type(e) in errors:"},{"line_number":94,"context_line":"                    raise faults.QuantumHTTPError(e)"},{"line_number":95,"context_line":"                # otherwise just re-raise"},{"line_number":96,"context_line":"                raise"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAD3%2F%2F%2B3c%3D","line":93,"updated":"2012-01-11 21:25:48.000000000","message":"could just be\nif errors and type(e) in errors:","commit_id":"4572e6500ace4996f63fb12f09808346e87f9551"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"d002978fc964d2bfbe8af8084b121a0a122cbb1d","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            try:"},{"line_number":91,"context_line":"                return func(*args, **kwargs)"},{"line_number":92,"context_line":"            except Exception as e:"},{"line_number":93,"context_line":"                if errors is not None and type(e) in errors:"},{"line_number":94,"context_line":"                    raise faults.QuantumHTTPError(e)"},{"line_number":95,"context_line":"                # otherwise just re-raise"},{"line_number":96,"context_line":"                raise"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAD3%2F%2F%2By0%3D","line":93,"in_reply_to":"AAAAD3%2F%2F%2B3c%3D","updated":"2012-01-11 23:50:22.000000000","message":"I wanted to respect what the original author intended. I think changing that way could change the logic.","commit_id":"4572e6500ace4996f63fb12f09808346e87f9551"}],"quantum/extensions/_pprofiles.py":[{"author":{"_account_id":191,"name":"Trey Morris","email":"trey.morris@rackspace.com","username":"tr3buchet"},"unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def _build_detail(self, portprofile_data):"},{"line_number":53,"context_line":"        \"\"\"Return a detailed info of a portprofile.\"\"\""},{"line_number":54,"context_line":"        if (portprofile_data[\u0027assignment\u0027] is None):"},{"line_number":55,"context_line":"            return dict(portprofile\u003ddict(id\u003dportprofile_data[\u0027profile_id\u0027],"},{"line_number":56,"context_line":"                                name\u003dportprofile_data[\u0027profile_name\u0027],"},{"line_number":57,"context_line":"                                qos_name\u003dportprofile_data[\u0027qos_name\u0027]))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAD3%2F%2F%2B28%3D","line":54,"updated":"2012-01-11 21:25:48.000000000","message":"drop the ()","commit_id":"4572e6500ace4996f63fb12f09808346e87f9551"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"d002978fc964d2bfbe8af8084b121a0a122cbb1d","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def _build_detail(self, portprofile_data):"},{"line_number":53,"context_line":"        \"\"\"Return a detailed info of a portprofile.\"\"\""},{"line_number":54,"context_line":"        if (portprofile_data[\u0027assignment\u0027] is None):"},{"line_number":55,"context_line":"            return dict(portprofile\u003ddict(id\u003dportprofile_data[\u0027profile_id\u0027],"},{"line_number":56,"context_line":"                                name\u003dportprofile_data[\u0027profile_name\u0027],"},{"line_number":57,"context_line":"                                qos_name\u003dportprofile_data[\u0027qos_name\u0027]))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAD3%2F%2F%2Bys%3D","line":54,"in_reply_to":"AAAAD3%2F%2F%2B28%3D","updated":"2012-01-11 23:50:22.000000000","message":"yes I think it would be better without the parenthesis.\n\nI\u0027ll do that in another clean up in regard to wrapping parenthesis on long lines and removing them like in this case.","commit_id":"4572e6500ace4996f63fb12f09808346e87f9551"}],"quantum/plugins/cisco/tests/unit/test_database.py":[{"author":{"_account_id":1918,"name":"François Charlier","email":"francois.charlier@redhat.com","username":"francois-charlier"},"change_message_id":"9e21ad4fa854dfb0f7edb217e0b54abb4b4ea597","unresolved":false,"context_lines":[{"line_number":1063,"context_line":"        self.assertTrue(len(vlanids) \u003e 0)"},{"line_number":1064,"context_line":"        vlanid \u003d l2network_db.reserve_vlanid()"},{"line_number":1065,"context_line":"        used \u003d l2network_db.is_vlanid_used(vlanid)"},{"line_number":1066,"context_line":"        self.assertTrue(not not used)"},{"line_number":1067,"context_line":"        used \u003d l2network_db.release_vlanid(vlanid)"},{"line_number":1068,"context_line":"        self.assertTrue(not used)"},{"line_number":1069,"context_line":"        #counting on default teardown here to clear db"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAADH%2F%2F%2BrI%3D","line":1066,"updated":"2012-01-04 11:59:57.000000000","message":"why not \u0027self.assertTrue(used)\u0027 ?","commit_id":"ec8fe2e3f88413b29d91c20d32e633ce45e7813d"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"d002978fc964d2bfbe8af8084b121a0a122cbb1d","unresolved":false,"context_lines":[{"line_number":1063,"context_line":"        self.assertTrue(len(vlanids) \u003e 0)"},{"line_number":1064,"context_line":"        vlanid \u003d l2network_db.reserve_vlanid()"},{"line_number":1065,"context_line":"        used \u003d l2network_db.is_vlanid_used(vlanid)"},{"line_number":1066,"context_line":"        self.assertTrue(not not used)"},{"line_number":1067,"context_line":"        used \u003d l2network_db.release_vlanid(vlanid)"},{"line_number":1068,"context_line":"        self.assertTrue(not used)"},{"line_number":1069,"context_line":"        #counting on default teardown here to clear db"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAADH%2F%2F%2Bqw%3D","line":1066,"in_reply_to":"AAAADH%2F%2F%2BrI%3D","updated":"2012-01-04 12:10:16.000000000","message":"well the original code wanted used to be evaluated to True or False I think.\n\nTherefore I also evaluated used before being asserted to True.\n\nHowever, looking at the code of assertTrue, no need.\n\ndef assertTrue(self, expr, msg\u003dNone):\n        \"\"\"Check that the expression is true.\"\"\"\n        if not expr:\n            msg \u003d self._formatMessage(msg, \"%s is not true\" % safe_repr(expr))\n            raise self.failureException(msg)\n\nI\u0027ll fix this.","commit_id":"ec8fe2e3f88413b29d91c20d32e633ce45e7813d"},{"author":{"_account_id":1918,"name":"François Charlier","email":"francois.charlier@redhat.com","username":"francois-charlier"},"change_message_id":"9e21ad4fa854dfb0f7edb217e0b54abb4b4ea597","unresolved":false,"context_lines":[{"line_number":1065,"context_line":"        used \u003d l2network_db.is_vlanid_used(vlanid)"},{"line_number":1066,"context_line":"        self.assertTrue(not not used)"},{"line_number":1067,"context_line":"        used \u003d l2network_db.release_vlanid(vlanid)"},{"line_number":1068,"context_line":"        self.assertTrue(not used)"},{"line_number":1069,"context_line":"        #counting on default teardown here to clear db"},{"line_number":1070,"context_line":""},{"line_number":1071,"context_line":"    def teardown_network(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAADH%2F%2F%2BrE%3D","line":1068,"updated":"2012-01-04 11:59:57.000000000","message":"why not \u0027self.assertFalse(used)\u0027 ?","commit_id":"ec8fe2e3f88413b29d91c20d32e633ce45e7813d"}]}