)]}'
{"quantum/plugins/openvswitch/agent/ovs_quantum_agent.py":[{"author":{"_account_id":385,"name":"Jason Kölker","email":"jason@koelker.net","username":"jason-koelker"},"change_message_id":"733d6fb821f9db643ee6697f9b3da20a741a1350","unresolved":false,"context_lines":[{"line_number":474,"context_line":"        lvm \u003d self.local_vlan_map[net_uuid]"},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"        try:"},{"line_number":477,"context_line":"            vif_port \u003d lvm.vif_ports.pop(vif_id)"},{"line_number":478,"context_line":"            self.tun_br.delete_flows(tun_id\u003dlvm.segmentation_id,"},{"line_number":479,"context_line":"                                     dl_dst\u003dvif_port.vif_mac)"},{"line_number":480,"context_line":"        except KeyError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FpqM%3D","line":477,"updated":"2013-04-30 16:14:18.000000000","message":"You can specify None as the default:\n    \n    vif_port \u003d lvm.vif_ports.pop(vif_id, None)\n\nWhich has the benefit of not halting execution of greenthreads as the exception is raised","commit_id":"ed58a5a717935aae40dea8083601dfdc51169655"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"49d6d3a7fa27e100d152186e1645a452f439c8fa","unresolved":false,"context_lines":[{"line_number":474,"context_line":"        lvm \u003d self.local_vlan_map[net_uuid]"},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"        try:"},{"line_number":477,"context_line":"            vif_port \u003d lvm.vif_ports.pop(vif_id)"},{"line_number":478,"context_line":"            self.tun_br.delete_flows(tun_id\u003dlvm.segmentation_id,"},{"line_number":479,"context_line":"                                     dl_dst\u003dvif_port.vif_mac)"},{"line_number":480,"context_line":"        except KeyError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FphU%3D","line":477,"in_reply_to":"AAAAOn%2F%2FpqM%3D","updated":"2013-04-30 17:00:49.000000000","message":"Done","commit_id":"ed58a5a717935aae40dea8083601dfdc51169655"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"1fe92b528d942b56127d6cad664a75edc8082a0b","unresolved":false,"context_lines":[{"line_number":473,"context_line":"            return"},{"line_number":474,"context_line":"        lvm \u003d self.local_vlan_map[net_uuid]"},{"line_number":475,"context_line":"        if vif_id in lvm.vif_ports:"},{"line_number":476,"context_line":"            if lvm.network_type \u003d\u003d \u0027gre\u0027 and self.enable_tunneling:"},{"line_number":477,"context_line":"                # remove inbound unicast flow"},{"line_number":478,"context_line":"                self.tun_br.delete_flows(tun_id\u003dlvm.segmentation_id,"},{"line_number":479,"context_line":"                                         dl_dst\u003dlvm.vif_ports[vif_id].vif_mac)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FoWE%3D","side":"PARENT","line":476,"updated":"2013-05-01 06:22:32.000000000","message":"I think we still need this line.","commit_id":"58d13eb3517c0e0c9f30fe811aac70edb00f2468"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":473,"context_line":"            return"},{"line_number":474,"context_line":"        lvm \u003d self.local_vlan_map[net_uuid]"},{"line_number":475,"context_line":"        if vif_id in lvm.vif_ports:"},{"line_number":476,"context_line":"            if lvm.network_type \u003d\u003d \u0027gre\u0027 and self.enable_tunneling:"},{"line_number":477,"context_line":"                # remove inbound unicast flow"},{"line_number":478,"context_line":"                self.tun_br.delete_flows(tun_id\u003dlvm.segmentation_id,"},{"line_number":479,"context_line":"                                         dl_dst\u003dlvm.vif_ports[vif_id].vif_mac)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FoVs%3D","side":"PARENT","line":476,"in_reply_to":"AAAAOn%2F%2FoWE%3D","updated":"2013-05-01 06:24:30.000000000","message":"Done","commit_id":"58d13eb3517c0e0c9f30fe811aac70edb00f2468"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"1fe92b528d942b56127d6cad664a75edc8082a0b","unresolved":false,"context_lines":[{"line_number":474,"context_line":"        lvm \u003d self.local_vlan_map[net_uuid]"},{"line_number":475,"context_line":"        if vif_id in lvm.vif_ports:"},{"line_number":476,"context_line":"            if lvm.network_type \u003d\u003d \u0027gre\u0027 and self.enable_tunneling:"},{"line_number":477,"context_line":"                # remove inbound unicast flow"},{"line_number":478,"context_line":"                self.tun_br.delete_flows(tun_id\u003dlvm.segmentation_id,"},{"line_number":479,"context_line":"                                         dl_dst\u003dlvm.vif_ports[vif_id].vif_mac)"},{"line_number":480,"context_line":"            del lvm.vif_ports[vif_id]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FoWQ%3D","side":"PARENT","line":477,"updated":"2013-05-01 06:22:32.000000000","message":"imo this comment is useful","commit_id":"58d13eb3517c0e0c9f30fe811aac70edb00f2468"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":474,"context_line":"        lvm \u003d self.local_vlan_map[net_uuid]"},{"line_number":475,"context_line":"        if vif_id in lvm.vif_ports:"},{"line_number":476,"context_line":"            if lvm.network_type \u003d\u003d \u0027gre\u0027 and self.enable_tunneling:"},{"line_number":477,"context_line":"                # remove inbound unicast flow"},{"line_number":478,"context_line":"                self.tun_br.delete_flows(tun_id\u003dlvm.segmentation_id,"},{"line_number":479,"context_line":"                                         dl_dst\u003dlvm.vif_ports[vif_id].vif_mac)"},{"line_number":480,"context_line":"            del lvm.vif_ports[vif_id]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FoVo%3D","side":"PARENT","line":477,"in_reply_to":"AAAAOn%2F%2FoWQ%3D","updated":"2013-05-01 06:24:30.000000000","message":"Done","commit_id":"58d13eb3517c0e0c9f30fe811aac70edb00f2468"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"1fe92b528d942b56127d6cad664a75edc8082a0b","unresolved":false,"context_lines":[{"line_number":479,"context_line":"                                         dl_dst\u003dlvm.vif_ports[vif_id].vif_mac)"},{"line_number":480,"context_line":"            del lvm.vif_ports[vif_id]"},{"line_number":481,"context_line":"        else:"},{"line_number":482,"context_line":"            LOG.info(_(\u0027port_unbound: vif_id %s not in local_vlan_map\u0027),"},{"line_number":483,"context_line":"                     vif_id)"},{"line_number":484,"context_line":""},{"line_number":485,"context_line":"        if not lvm.vif_ports:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FoWM%3D","side":"PARENT","line":482,"updated":"2013-05-01 06:22:32.000000000","message":"why not leave this log statement?","commit_id":"58d13eb3517c0e0c9f30fe811aac70edb00f2468"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":479,"context_line":"                                         dl_dst\u003dlvm.vif_ports[vif_id].vif_mac)"},{"line_number":480,"context_line":"            del lvm.vif_ports[vif_id]"},{"line_number":481,"context_line":"        else:"},{"line_number":482,"context_line":"            LOG.info(_(\u0027port_unbound: vif_id %s not in local_vlan_map\u0027),"},{"line_number":483,"context_line":"                     vif_id)"},{"line_number":484,"context_line":""},{"line_number":485,"context_line":"        if not lvm.vif_ports:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FoVk%3D","side":"PARENT","line":482,"in_reply_to":"AAAAOn%2F%2FoWM%3D","updated":"2013-05-01 06:24:30.000000000","message":"Done","commit_id":"58d13eb3517c0e0c9f30fe811aac70edb00f2468"}]}