)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"3b4fa10f635dde74745d5807097023c9d66112c8","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Neutron resources with tag filter."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"APIImpact"},{"line_number":13,"context_line":"DocImpact: allow the user to get network resources with tag filter"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I1e5b25fea268e188cc9620c72b3c71004b197512"},{"line_number":16,"context_line":"Implements: blueprint add-tags-to-core-resources"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"bae84128_83aa4e83","line":13,"updated":"2016-02-24 05:32:33.000000000","message":"I wouldn\u0027t file another doc bug, this can be documented with the bug that\u0027s automatically filed in the parent patch.","commit_id":"e230a0f257cae49425bd180305dcfd6ac145bd4e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"771b22022f1917d875d3656e5152944c53be2093","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Neutron resources with tag filter."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"APIImpact"},{"line_number":13,"context_line":"DocImpact: allow the user to get network resources with tag filter"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I1e5b25fea268e188cc9620c72b3c71004b197512"},{"line_number":16,"context_line":"Implements: blueprint add-tags-to-core-resources"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9aed3d3a_16720a11","line":13,"in_reply_to":"bae84128_83aa4e83","updated":"2016-03-01 02:59:27.000000000","message":"Done","commit_id":"e230a0f257cae49425bd180305dcfd6ac145bd4e"}],"neutron/db/common_db_mixin.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3a7e00b6409d990c3a46e13b248caa76434fef01","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"                if result_filter:"},{"line_number":254,"context_line":"                    query \u003d result_filter(query, filters)"},{"line_number":255,"context_line":"            query \u003d tag_db.apply_tag_filters(query, model, filters)"},{"line_number":256,"context_line":"        return query"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    def _apply_dict_extend_functions(self, resource_type,"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_36f5f3ca","line":255,"updated":"2016-02-22 07:45:21.000000000","message":"can\u0027t we use register_model_query_hook instead of adding this directly?","commit_id":"2f346dfa42020d5eec17758888225c0cf73bee79"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"0b9706c4613c08e05b2551deefe6b0d7f7919633","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"                if result_filter:"},{"line_number":254,"context_line":"                    query \u003d result_filter(query, filters)"},{"line_number":255,"context_line":"            query \u003d tag_db.apply_tag_filters(query, model, filters)"},{"line_number":256,"context_line":"        return query"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    def _apply_dict_extend_functions(self, resource_type,"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_1c725b49","line":255,"in_reply_to":"bae84128_36f5f3ca","updated":"2016-02-23 07:09:32.000000000","message":"Done","commit_id":"2f346dfa42020d5eec17758888225c0cf73bee79"}],"neutron/db/tag_db.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"212b308180573dfd9017a6120e888df1f7359202","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def apply_tag_filters(model, query, filters):"},{"line_number":41,"context_line":"    \"\"\"Apply tag filters"},{"line_number":42,"context_line":"    There are four types of filter:"},{"line_number":43,"context_line":"    `tags` -- One or more strings that will be used to filter results"},{"line_number":44,"context_line":"            in an AND expression: T1 AND T2"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_a0adc8ea","line":41,"updated":"2016-02-24 07:13:56.000000000","message":"blank line here","commit_id":"e230a0f257cae49425bd180305dcfd6ac145bd4e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"771b22022f1917d875d3656e5152944c53be2093","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def apply_tag_filters(model, query, filters):"},{"line_number":41,"context_line":"    \"\"\"Apply tag filters"},{"line_number":42,"context_line":"    There are four types of filter:"},{"line_number":43,"context_line":"    `tags` -- One or more strings that will be used to filter results"},{"line_number":44,"context_line":"            in an AND expression: T1 AND T2"}],"source_content_type":"text/x-python","patch_set":9,"id":"9aed3d3a_d66b821c","line":41,"in_reply_to":"bae84128_a0adc8ea","updated":"2016-03-01 02:59:27.000000000","message":"Done","commit_id":"e230a0f257cae49425bd180305dcfd6ac145bd4e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"169ed27cd73fc29162c3959aa787f2a01f205e50","unresolved":false,"context_lines":[{"line_number":33,"context_line":"def _get_tag_list(tag_strings):"},{"line_number":34,"context_line":"    tags \u003d set()"},{"line_number":35,"context_line":"    for tag_str in tag_strings:"},{"line_number":36,"context_line":"        tags |\u003d set(tag_str.split(\u0027,\u0027))"},{"line_number":37,"context_line":"    return list(tags)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9aed3d3a_b33d2bdf","line":36,"updated":"2016-03-01 05:20:46.000000000","message":"I think it is a problem.\n\nWe can set a tag like \u0027green,red,blue\u0027 (\u003c--- one tag).\nHowever, we cannot filter resources with a tag \u0027green,red,blue\u0027.\n\n- http://paste.openstack.org/show/488690/  (not-tags)\n- http://paste.openstack.org/show/488691/ (tags)\n\nGET http://172.16.18.46:9696/v2.0/networks.json?tags\u003dgreen%2Cred%2Cblue\u0026tags\u003dpurple\n\nwas sent, but it seems it is interpreted as tags\u003d[green, red, blue, purple]. As a result, no resource was fetched.\n\nAny idea?","commit_id":"81d2f28fe5f5ba2e0ba99906048496fa4379f284"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1a8e5bdb823ceb6945ebbc57e0318f4306579cf3","unresolved":false,"context_lines":[{"line_number":33,"context_line":"def _get_tag_list(tag_strings):"},{"line_number":34,"context_line":"    tags \u003d set()"},{"line_number":35,"context_line":"    for tag_str in tag_strings:"},{"line_number":36,"context_line":"        tags |\u003d set(tag_str.split(\u0027,\u0027))"},{"line_number":37,"context_line":"    return list(tags)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9aed3d3a_fcbdbb02","line":36,"in_reply_to":"9aed3d3a_449a176f","updated":"2016-03-01 08:38:39.000000000","message":"It seems I just hit a corner case.\n\nOn a second thought, you are right. I think it is a reasonable assumption that a tag name contains no comma.\n\nIf we pass a query filed by tags\u003dred\u0026tags\u003dblue stye,\nwe can distinguish a tag name with a comma.\nOn the other hand, if we use tags\u003dred,blue style, there is no way to distinguish a tag name with a comma.","commit_id":"81d2f28fe5f5ba2e0ba99906048496fa4379f284"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"0750bfcf5bb49c4fa752606151399b1841ef49ad","unresolved":false,"context_lines":[{"line_number":33,"context_line":"def _get_tag_list(tag_strings):"},{"line_number":34,"context_line":"    tags \u003d set()"},{"line_number":35,"context_line":"    for tag_str in tag_strings:"},{"line_number":36,"context_line":"        tags |\u003d set(tag_str.split(\u0027,\u0027))"},{"line_number":37,"context_line":"    return list(tags)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9aed3d3a_449a176f","line":36,"in_reply_to":"9aed3d3a_b33d2bdf","updated":"2016-03-01 06:40:10.000000000","message":"Woops. I didn\u0027t consider tag name including commas. However, tags filters are defined in spec so that users use commas in the URL. Can we know whether the comma is a part of name or not?","commit_id":"81d2f28fe5f5ba2e0ba99906048496fa4379f284"}],"neutron/extensions/tag.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3a7e00b6409d990c3a46e13b248caa76434fef01","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    message \u003d _(\"Tag %(tag)s already exists.\")"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"class TagLimitExceed(exceptions.BadRequest):"},{"line_number":61,"context_line":"    message \u003d _(\"Tag limit exceed.\")"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_76c01b2b","line":60,"range":{"start_line":60,"start_character":14,"end_line":60,"end_character":20},"updated":"2016-02-22 07:45:21.000000000","message":"Exceed -\u003e Exceeded","commit_id":"2f346dfa42020d5eec17758888225c0cf73bee79"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"0b9706c4613c08e05b2551deefe6b0d7f7919633","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    message \u003d _(\"Tag %(tag)s already exists.\")"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"class TagLimitExceed(exceptions.BadRequest):"},{"line_number":61,"context_line":"    message \u003d _(\"Tag limit exceed.\")"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_688009c1","line":60,"range":{"start_line":60,"start_character":14,"end_line":60,"end_character":20},"in_reply_to":"bae84128_76c01b2b","updated":"2016-02-23 07:09:32.000000000","message":"Done","commit_id":"2f346dfa42020d5eec17758888225c0cf73bee79"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3a7e00b6409d990c3a46e13b248caa76434fef01","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"class TagLimitExceed(exceptions.BadRequest):"},{"line_number":61,"context_line":"    message \u003d _(\"Tag limit exceed.\")"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"def get_parent_resource_and_id(kwargs):"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_b6e0e3cd","line":61,"updated":"2016-02-22 07:45:21.000000000","message":"ditto","commit_id":"2f346dfa42020d5eec17758888225c0cf73bee79"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"0b9706c4613c08e05b2551deefe6b0d7f7919633","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"class TagLimitExceed(exceptions.BadRequest):"},{"line_number":61,"context_line":"    message \u003d _(\"Tag limit exceed.\")"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"def get_parent_resource_and_id(kwargs):"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_c88155c5","line":61,"in_reply_to":"bae84128_b6e0e3cd","updated":"2016-02-23 07:09:32.000000000","message":"Done","commit_id":"2f346dfa42020d5eec17758888225c0cf73bee79"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3a7e00b6409d990c3a46e13b248caa76434fef01","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"tag_opts \u003d ["},{"line_number":89,"context_line":"    cfg.IntOpt(\u0027tag_resource_limit\u0027, default\u003d5,"},{"line_number":90,"context_line":"               help\u003d_(\u0027Number of tags allowed per resource.\u0027))"},{"line_number":91,"context_line":"]"},{"line_number":92,"context_line":"cfg.CONF.register_opts(tag_opts)"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_761c9bc1","line":89,"updated":"2016-02-22 07:45:21.000000000","message":"how about \u0027max_tags_per_resource\u0027?","commit_id":"2f346dfa42020d5eec17758888225c0cf73bee79"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"0b9706c4613c08e05b2551deefe6b0d7f7919633","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"tag_opts \u003d ["},{"line_number":89,"context_line":"    cfg.IntOpt(\u0027tag_resource_limit\u0027, default\u003d5,"},{"line_number":90,"context_line":"               help\u003d_(\u0027Number of tags allowed per resource.\u0027))"},{"line_number":91,"context_line":"]"},{"line_number":92,"context_line":"cfg.CONF.register_opts(tag_opts)"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_28e1e19a","line":89,"in_reply_to":"bae84128_761c9bc1","updated":"2016-02-23 07:09:32.000000000","message":"Done","commit_id":"2f346dfa42020d5eec17758888225c0cf73bee79"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3a7e00b6409d990c3a46e13b248caa76434fef01","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    cfg.IntOpt(\u0027tag_resource_limit\u0027, default\u003d5,"},{"line_number":90,"context_line":"               help\u003d_(\u0027Number of tags allowed per resource.\u0027))"},{"line_number":91,"context_line":"]"},{"line_number":92,"context_line":"cfg.CONF.register_opts(tag_opts)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"class TagController(object):"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_160d4f90","line":92,"updated":"2016-02-22 07:45:21.000000000","message":"group\u003d\u0027tag\u0027?\n\nIt is a service plugin related configuration.\nI think it is good to use [tag] group.","commit_id":"2f346dfa42020d5eec17758888225c0cf73bee79"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"0b9706c4613c08e05b2551deefe6b0d7f7919633","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    cfg.IntOpt(\u0027tag_resource_limit\u0027, default\u003d5,"},{"line_number":90,"context_line":"               help\u003d_(\u0027Number of tags allowed per resource.\u0027))"},{"line_number":91,"context_line":"]"},{"line_number":92,"context_line":"cfg.CONF.register_opts(tag_opts)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"class TagController(object):"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_88f0ed68","line":92,"in_reply_to":"bae84128_160d4f90","updated":"2016-02-23 07:09:32.000000000","message":"Done","commit_id":"2f346dfa42020d5eec17758888225c0cf73bee79"}],"neutron/services/tag/tag_plugin.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3a7e00b6409d990c3a46e13b248caa76434fef01","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        res \u003d self._get_resource(context, resource, resource_id)"},{"line_number":77,"context_line":"        new_tags \u003d set(body[\u0027tags\u0027])"},{"line_number":78,"context_line":"        if len(new_tags) \u003e cfg.CONF.tag_resource_limit:"},{"line_number":79,"context_line":"            raise tag_ext.TagLimitExceed()"},{"line_number":80,"context_line":"        old_tags \u003d {tag_db.tag for tag_db in res.standard_attr.tags}"},{"line_number":81,"context_line":"        tags_added \u003d new_tags - old_tags"},{"line_number":82,"context_line":"        tags_removed \u003d old_tags - new_tags"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_b663c340","line":79,"updated":"2016-02-22 07:45:21.000000000","message":"Filtering and limit are different completely.\nHow about moving \u0027limit\u0027 to the base patch?","commit_id":"2f346dfa42020d5eec17758888225c0cf73bee79"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"0b9706c4613c08e05b2551deefe6b0d7f7919633","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        res \u003d self._get_resource(context, resource, resource_id)"},{"line_number":77,"context_line":"        new_tags \u003d set(body[\u0027tags\u0027])"},{"line_number":78,"context_line":"        if len(new_tags) \u003e cfg.CONF.tag_resource_limit:"},{"line_number":79,"context_line":"            raise tag_ext.TagLimitExceed()"},{"line_number":80,"context_line":"        old_tags \u003d {tag_db.tag for tag_db in res.standard_attr.tags}"},{"line_number":81,"context_line":"        tags_added \u003d new_tags - old_tags"},{"line_number":82,"context_line":"        tags_removed \u003d old_tags - new_tags"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_e85d3948","line":79,"in_reply_to":"bae84128_b663c340","updated":"2016-02-23 07:09:32.000000000","message":"I thought base patch is huge so I divided. However, I will follow your suggestion.","commit_id":"2f346dfa42020d5eec17758888225c0cf73bee79"}],"neutron/tests/unit/extensions/test_tag.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3a7e00b6409d990c3a46e13b248caa76434fef01","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            res \u003d self._put_tag(net_id, \u0027blue\u0027)"},{"line_number":115,"context_line":"            self.assertEqual(409, res.status_int)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def test_put_tag_exeed_limit(self):"},{"line_number":118,"context_line":"        cfg.CONF.set_override(\u0027tag_resource_limit\u0027, 2)"},{"line_number":119,"context_line":"        with self.network() as net:"},{"line_number":120,"context_line":"            net_id \u003d net[\u0027network\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_f6d42bbe","line":117,"range":{"start_line":117,"start_character":21,"end_line":117,"end_character":26},"updated":"2016-02-22 07:45:21.000000000","message":"-\u003e exceed","commit_id":"2f346dfa42020d5eec17758888225c0cf73bee79"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"0b9706c4613c08e05b2551deefe6b0d7f7919633","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            res \u003d self._put_tag(net_id, \u0027blue\u0027)"},{"line_number":115,"context_line":"            self.assertEqual(409, res.status_int)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def test_put_tag_exeed_limit(self):"},{"line_number":118,"context_line":"        cfg.CONF.set_override(\u0027tag_resource_limit\u0027, 2)"},{"line_number":119,"context_line":"        with self.network() as net:"},{"line_number":120,"context_line":"            net_id \u003d net[\u0027network\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_cbf14f03","line":117,"range":{"start_line":117,"start_character":21,"end_line":117,"end_character":26},"in_reply_to":"bae84128_f6d42bbe","updated":"2016-02-23 07:09:32.000000000","message":"Done","commit_id":"2f346dfa42020d5eec17758888225c0cf73bee79"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3a7e00b6409d990c3a46e13b248caa76434fef01","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            self.assertEqual(200, res.status_int)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"            res \u003d self._put_tag(net_id, \u0027blue\u0027)"},{"line_number":125,"context_line":"            self.assertEqual(400, res.status_int)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def test_put_tags(self):"},{"line_number":128,"context_line":"        with self.network() as net:"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_568a37c0","line":125,"updated":"2016-02-22 07:45:21.000000000","message":"In addition to this, I would like to see a test for putting three tags in a first request.","commit_id":"2f346dfa42020d5eec17758888225c0cf73bee79"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"0b9706c4613c08e05b2551deefe6b0d7f7919633","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            self.assertEqual(200, res.status_int)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"            res \u003d self._put_tag(net_id, \u0027blue\u0027)"},{"line_number":125,"context_line":"            self.assertEqual(400, res.status_int)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def test_put_tags(self):"},{"line_number":128,"context_line":"        with self.network() as net:"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_8bebc712","line":125,"in_reply_to":"bae84128_568a37c0","updated":"2016-02-23 07:09:32.000000000","message":"Done","commit_id":"2f346dfa42020d5eec17758888225c0cf73bee79"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3a7e00b6409d990c3a46e13b248caa76434fef01","unresolved":false,"context_lines":[{"line_number":143,"context_line":"            self.assertEqual(200, res.status_int)"},{"line_number":144,"context_line":"            tags \u003d self._get_resource_tags(net_id)"},{"line_number":145,"context_line":"            self._assertEqualTags([\u0027blue\u0027, \u0027red\u0027], tags)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def test_put_tags_exeed_limit(self):"},{"line_number":148,"context_line":"        cfg.CONF.set_override(\u0027tag_resource_limit\u0027, 2)"},{"line_number":149,"context_line":"        with self.network() as net:"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_b6f1036d","line":146,"updated":"2016-02-22 07:45:21.000000000","message":"duplicated to L.117?","commit_id":"2f346dfa42020d5eec17758888225c0cf73bee79"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"0b9706c4613c08e05b2551deefe6b0d7f7919633","unresolved":false,"context_lines":[{"line_number":143,"context_line":"            self.assertEqual(200, res.status_int)"},{"line_number":144,"context_line":"            tags \u003d self._get_resource_tags(net_id)"},{"line_number":145,"context_line":"            self._assertEqualTags([\u0027blue\u0027, \u0027red\u0027], tags)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def test_put_tags_exeed_limit(self):"},{"line_number":148,"context_line":"        cfg.CONF.set_override(\u0027tag_resource_limit\u0027, 2)"},{"line_number":149,"context_line":"        with self.network() as net:"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_eb409336","line":146,"in_reply_to":"bae84128_b6f1036d","updated":"2016-02-23 07:09:32.000000000","message":"No, they are different. L117 tests a case PUT with tag included in URI in the other hand this tests a case PUT with tag included in body.","commit_id":"2f346dfa42020d5eec17758888225c0cf73bee79"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3a7e00b6409d990c3a46e13b248caa76434fef01","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            tags \u003d self._get_resource_tags(net_id)"},{"line_number":145,"context_line":"            self._assertEqualTags([\u0027blue\u0027, \u0027red\u0027], tags)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def test_put_tags_exeed_limit(self):"},{"line_number":148,"context_line":"        cfg.CONF.set_override(\u0027tag_resource_limit\u0027, 2)"},{"line_number":149,"context_line":"        with self.network() as net:"},{"line_number":150,"context_line":"            net_id \u003d net[\u0027network\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_16d26fd2","line":147,"range":{"start_line":147,"start_character":22,"end_line":147,"end_character":27},"updated":"2016-02-22 07:45:21.000000000","message":"-\u003e exceed","commit_id":"2f346dfa42020d5eec17758888225c0cf73bee79"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"0b9706c4613c08e05b2551deefe6b0d7f7919633","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            tags \u003d self._get_resource_tags(net_id)"},{"line_number":145,"context_line":"            self._assertEqualTags([\u0027blue\u0027, \u0027red\u0027], tags)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def test_put_tags_exeed_limit(self):"},{"line_number":148,"context_line":"        cfg.CONF.set_override(\u0027tag_resource_limit\u0027, 2)"},{"line_number":149,"context_line":"        with self.network() as net:"},{"line_number":150,"context_line":"            net_id \u003d net[\u0027network\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_ebdc1375","line":147,"range":{"start_line":147,"start_character":22,"end_line":147,"end_character":27},"in_reply_to":"bae84128_16d26fd2","updated":"2016-02-23 07:09:32.000000000","message":"Done","commit_id":"2f346dfa42020d5eec17758888225c0cf73bee79"}],"releasenotes/notes/add-tags-to-core-resources-b05330a129900609.yaml":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"3b4fa10f635dde74745d5807097023c9d66112c8","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  - Users can set tags on their network resources."},{"line_number":6,"context_line":"  - The number of tags is limited by configuration option"},{"line_number":7,"context_line":"    \u0027max_tags_per_resource\u0027."},{"line_number":8,"context_line":"  - Tags can be get the resource with tag filters. The filters are \u0027tags\u0027,"},{"line_number":9,"context_line":"    \u0027tags-any\u0027, \u0027not-tags\u0027 and \u0027not-tags-any\u0027."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"bae84128_e3707a42","line":8,"updated":"2016-02-24 05:32:33.000000000","message":"retrieved? That said, I tried this using the client and it didn\u0027t work for me :(","commit_id":"e230a0f257cae49425bd180305dcfd6ac145bd4e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"771b22022f1917d875d3656e5152944c53be2093","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  - Users can set tags on their network resources."},{"line_number":6,"context_line":"  - The number of tags is limited by configuration option"},{"line_number":7,"context_line":"    \u0027max_tags_per_resource\u0027."},{"line_number":8,"context_line":"  - Tags can be get the resource with tag filters. The filters are \u0027tags\u0027,"},{"line_number":9,"context_line":"    \u0027tags-any\u0027, \u0027not-tags\u0027 and \u0027not-tags-any\u0027."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9aed3d3a_567f72df","line":8,"in_reply_to":"bae84128_7481befa","updated":"2016-03-01 02:59:27.000000000","message":"CLI works fine now.","commit_id":"e230a0f257cae49425bd180305dcfd6ac145bd4e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"212b308180573dfd9017a6120e888df1f7359202","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  - Users can set tags on their network resources."},{"line_number":6,"context_line":"  - The number of tags is limited by configuration option"},{"line_number":7,"context_line":"    \u0027max_tags_per_resource\u0027."},{"line_number":8,"context_line":"  - Tags can be get the resource with tag filters. The filters are \u0027tags\u0027,"},{"line_number":9,"context_line":"    \u0027tags-any\u0027, \u0027not-tags\u0027 and \u0027not-tags-any\u0027."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"bae84128_d4eb6ada","line":8,"in_reply_to":"bae84128_e3707a42","updated":"2016-02-24 07:13:56.000000000","message":"I tested the patch calling API directly and it seems to work as expected.\n\nWhat command line did you use?\nNeutron CLI converts hyphens in unknown options to underscore, so \"neutron net-list --tags-any red,blue\" does not work.","commit_id":"e230a0f257cae49425bd180305dcfd6ac145bd4e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8e801f38bb1742742a7a7d16ccf52e56f88ec973","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  - Users can set tags on their network resources."},{"line_number":6,"context_line":"  - The number of tags is limited by configuration option"},{"line_number":7,"context_line":"    \u0027max_tags_per_resource\u0027."},{"line_number":8,"context_line":"  - Tags can be get the resource with tag filters. The filters are \u0027tags\u0027,"},{"line_number":9,"context_line":"    \u0027tags-any\u0027, \u0027not-tags\u0027 and \u0027not-tags-any\u0027."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"bae84128_7481befa","line":8,"in_reply_to":"bae84128_e3707a42","updated":"2016-02-24 18:11:58.000000000","message":"The first sentence can be reworded.\n\n  Networks can be filtered by tags.","commit_id":"e230a0f257cae49425bd180305dcfd6ac145bd4e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"169ed27cd73fc29162c3959aa787f2a01f205e50","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    Add tag mechanism for network resources"},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - Users can set tags on their network resources."},{"line_number":6,"context_line":"  - Networks can be filtered by tags. The filters are \u0027tags\u0027, \u0027tags-any\u0027,"},{"line_number":7,"context_line":"    \u0027not-tags\u0027 and \u0027not-tags-any\u0027."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9aed3d3a_33011b07","line":6,"range":{"start_line":6,"start_character":42,"end_line":6,"end_character":50},"updated":"2016-03-01 05:20:46.000000000","message":"Hpw about \"The supported filter types are ...\"?","commit_id":"81d2f28fe5f5ba2e0ba99906048496fa4379f284"}]}
