)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"d52583acd69f0bac0c52589ff50d48fd69789d71","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gary Kotton \u003cgkotton@vmware.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-02-18 06:47:39 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Using LOG.warning replace LOG.warn"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Python 3 deprecated the logger.warn method, see:"},{"line_number":10,"context_line":"https://docs.python.org/3/library/logging.html#logging.warning"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"bae84128_d798dbc2","line":7,"updated":"2016-02-22 22:22:52.000000000","message":"I would prefer: Use LOG.warning instead of LOG.warn","commit_id":"261a3cac5831261860d8f4e4a1f54928e22afac2"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"d52583acd69f0bac0c52589ff50d48fd69789d71","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Python 3 deprecated the logger.warn method, see:"},{"line_number":10,"context_line":"https://docs.python.org/3/library/logging.html#logging.warning"},{"line_number":11,"context_line":"so we prefer to use warning to avoid DeprecationWarning."},{"line_number":12,"context_line":"Closes-Bugs: #1529913"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Icc01ce5fbd10880440cf75a2e0833394783464a0"},{"line_number":15,"context_line":"Co-Authored-By: Gary Kotton \u003cgkotton@vmware.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"bae84128_f75d1f16","line":12,"updated":"2016-02-22 22:22:52.000000000","message":"It should be:\n\n Closes-Bug: #...","commit_id":"261a3cac5831261860d8f4e4a1f54928e22afac2"}],"HACKING.rst":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"9fffc71ccd59d336d236fc506227d0f72fde9360","unresolved":false,"context_lines":[{"line_number":24,"context_line":"- [N331] Detect wrong usage with assertTrue(isinstance())."},{"line_number":25,"context_line":"- [N332] Use assertEqual(expected_http_code, observed_http_code) instead of"},{"line_number":26,"context_line":"         assertEqual(observed_http_code, expected_http_code)."},{"line_number":27,"context_line":"- [N333] Validate that LOG.warning messages."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Creating Unit Tests"},{"line_number":30,"context_line":"-------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a57f1b5_77827654","line":27,"range":{"start_line":27,"start_character":9,"end_line":27,"end_character":43},"updated":"2016-02-10 10:09:20.000000000","message":"what does it mean?","commit_id":"51e237786c454d9270464009b910cd4c2425791b"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"f55e524de947985239fd009814fe69190cf8559b","unresolved":false,"context_lines":[{"line_number":24,"context_line":"- [N331] Detect wrong usage with assertTrue(isinstance())."},{"line_number":25,"context_line":"- [N332] Use assertEqual(expected_http_code, observed_http_code) instead of"},{"line_number":26,"context_line":"         assertEqual(observed_http_code, expected_http_code)."},{"line_number":27,"context_line":"- [N333] Validate that LOG.warning messages."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Creating Unit Tests"},{"line_number":30,"context_line":"-------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a57f1b5_a51d15bf","line":27,"range":{"start_line":27,"start_character":9,"end_line":27,"end_character":43},"in_reply_to":"3a57f1b5_77827654","updated":"2016-02-10 11:57:55.000000000","message":"How about \"Use LOG.warning instead of LOG.warn\"?","commit_id":"51e237786c454d9270464009b910cd4c2425791b"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"ec816c1a28ffc63e3d592a226fe1c985471a72a8","unresolved":false,"context_lines":[{"line_number":24,"context_line":"- [N331] Detect wrong usage with assertTrue(isinstance())."},{"line_number":25,"context_line":"- [N332] Use assertEqual(expected_http_code, observed_http_code) instead of"},{"line_number":26,"context_line":"         assertEqual(observed_http_code, expected_http_code)."},{"line_number":27,"context_line":"- [N333] Validate that LOG.warning is used instead of LOG.warn. The latter"},{"line_number":28,"context_line":"  is deprecated."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Creating Unit Tests"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a57f1b5_65c15de4","line":27,"updated":"2016-02-10 12:15:03.000000000","message":"How about \"Use LOG.warning instead of LOG.warn\"? This will look consistent with other existing errors (L22, L25)","commit_id":"c4ccf89b7eb4d232c6005fee9d29a818af425739"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"6167625552df3766166b27bc3b548ba00dbf74bb","unresolved":false,"context_lines":[{"line_number":24,"context_line":"- [N331] Detect wrong usage with assertTrue(isinstance())."},{"line_number":25,"context_line":"- [N332] Use assertEqual(expected_http_code, observed_http_code) instead of"},{"line_number":26,"context_line":"         assertEqual(observed_http_code, expected_http_code)."},{"line_number":27,"context_line":"- [N333] Validate that LOG.warning is used instead of LOG.warn. The latter"},{"line_number":28,"context_line":"  is deprecated."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Creating Unit Tests"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a57f1b5_55e636b5","line":27,"in_reply_to":"3a57f1b5_65c15de4","updated":"2016-02-10 18:46:22.000000000","message":"Done","commit_id":"c4ccf89b7eb4d232c6005fee9d29a818af425739"}],"neutron/agent/dhcp/agent.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"5ef30add9e7cc54bdef3e48a5b4ab245b729805b","unresolved":false,"context_lines":[{"line_number":586,"context_line":"                self.schedule_resync(\"Agent has just been revived\")"},{"line_number":587,"context_line":"        except AttributeError:"},{"line_number":588,"context_line":"            # This means the server does not support report_state"},{"line_number":589,"context_line":"            LOG.warning(_LW(\"Neutron server does not support state report.\""},{"line_number":590,"context_line":"                            \" State report for this agent will be disabled.\"))"},{"line_number":591,"context_line":"            self.heartbeat.stop()"},{"line_number":592,"context_line":"            self.run()"}],"source_content_type":"text/x-python","patch_set":8,"id":"dae33548_023e64d9","line":589,"updated":"2016-02-17 16:01:40.000000000","message":"nit: Would be put space at end of line, versus start of next line. Easier to read, and consistent with other logs in file.","commit_id":"918428f401d67988db6bddce69ac24339196cce5"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f074e03cc4fb0fdcc61e83a9f39edbf9fc69d1fa","unresolved":false,"context_lines":[{"line_number":586,"context_line":"                self.schedule_resync(\"Agent has just been revived\")"},{"line_number":587,"context_line":"        except AttributeError:"},{"line_number":588,"context_line":"            # This means the server does not support report_state"},{"line_number":589,"context_line":"            LOG.warning(_LW(\"Neutron server does not support state report.\""},{"line_number":590,"context_line":"                            \" State report for this agent will be disabled.\"))"},{"line_number":591,"context_line":"            self.heartbeat.stop()"},{"line_number":592,"context_line":"            self.run()"}],"source_content_type":"text/x-python","patch_set":8,"id":"dae33548_65d655f2","line":589,"in_reply_to":"dae33548_023e64d9","updated":"2016-02-17 17:17:35.000000000","message":"Done","commit_id":"918428f401d67988db6bddce69ac24339196cce5"}],"neutron/hacking/checks.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"9fffc71ccd59d336d236fc506227d0f72fde9360","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    msg \u003d \"N320: Log messages require translation hints!\""},{"line_number":73,"context_line":"    if log_translation_hint.match(logical_line):"},{"line_number":74,"context_line":"        yield (0, msg)"},{"line_number":75,"context_line":"    msg \u003d \"N333: Use LOG.warning due to compatibility with py3\""},{"line_number":76,"context_line":"    if log_warn.match(logical_line):"},{"line_number":77,"context_line":"        yield (0, msg)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"def use_jsonutils(logical_line, filename):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a57f1b5_f7af46e1","line":77,"range":{"start_line":75,"start_character":4,"end_line":77,"end_character":22},"updated":"2016-02-10 10:09:20.000000000","message":"should be a separate check, not part of validate_log_translations IMO","commit_id":"51e237786c454d9270464009b910cd4c2425791b"}],"neutron/services/metering/agents/metering_agent.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"5ef30add9e7cc54bdef3e48a5b4ab245b729805b","unresolved":false,"context_lines":[{"line_number":277,"context_line":"        except AttributeError:"},{"line_number":278,"context_line":"            # This means the server does not support report_state"},{"line_number":279,"context_line":"            LOG.warning(_LW(\"Neutron server does not support state report.\""},{"line_number":280,"context_line":"                            \" State report for this agent will be disabled.\"))"},{"line_number":281,"context_line":"            self.heartbeat.stop()"},{"line_number":282,"context_line":"            return"},{"line_number":283,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":8,"id":"dae33548_5615d1e2","line":280,"updated":"2016-02-17 16:01:40.000000000","message":"ditto on space at end of previous line.","commit_id":"918428f401d67988db6bddce69ac24339196cce5"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f074e03cc4fb0fdcc61e83a9f39edbf9fc69d1fa","unresolved":false,"context_lines":[{"line_number":277,"context_line":"        except AttributeError:"},{"line_number":278,"context_line":"            # This means the server does not support report_state"},{"line_number":279,"context_line":"            LOG.warning(_LW(\"Neutron server does not support state report.\""},{"line_number":280,"context_line":"                            \" State report for this agent will be disabled.\"))"},{"line_number":281,"context_line":"            self.heartbeat.stop()"},{"line_number":282,"context_line":"            return"},{"line_number":283,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":8,"id":"dae33548_c513e1b6","line":280,"in_reply_to":"dae33548_5615d1e2","updated":"2016-02-17 17:17:35.000000000","message":"Done","commit_id":"918428f401d67988db6bddce69ac24339196cce5"}]}
