)]}'
{"neutron/common/exceptions.py":[{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"12fc65a4fb6877c63766627a62391fdad8c92729","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    message \u003d _(\"Policy configuration policy.json could not be found.\")"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class TrunkNotFound(e.NotFound):"},{"line_number":52,"context_line":"    message \u003d _(\"Trunk %(trunk_id)s could not be found.\")"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_8644631b","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":32},"updated":"2016-02-23 01:05:10.000000000","message":"https://review.openstack.org/#/c/281723/1 adds these exceptiosn in extension/trunk.py. Might want to sync up and place them in one file","commit_id":"2502ddcfae6e6cec7e7d4a62d37eb8f73fe06cb1"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"26a687f6ae039d4b84ccb30bf65d6306d28edd76","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"class DuplicateSubportRequest(e.BadRequest):"},{"line_number":60,"context_line":"    message \u003d _(\"Unable to create subport on trunk %(trunk_id)s. Segment \""},{"line_number":61,"context_line":"                \"id %(segment_id)s and type %(segment_type)s already in \""},{"line_number":62,"context_line":"                \"use.\")"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_f5c2e551","line":61,"range":{"start_line":61,"start_character":60,"end_line":61,"end_character":68},"updated":"2016-02-24 10:51:27.000000000","message":"are already","commit_id":"2502ddcfae6e6cec7e7d4a62d37eb8f73fe06cb1"}],"neutron/db/trunk_ports/api.py":[{"author":{"_account_id":20082,"name":"JianGang Weng","email":"weng.jiangang@zte.com.cn","username":"wengjiangang"},"change_message_id":"9264d8618e9c8b5e65ab0fa1ec89ff9034b50eaf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"dae33548_3262bed8","updated":"2016-02-18 01:55:10.000000000","message":"I think we should add another 4 API for:\nlist trunks\nshow trunk\nlist subports\nshow subport","commit_id":"3fee657028495e2bb46d51dcf177fb8a110d9ebe"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"dad36c414c7b3464bcc745f5cae7d982bd267390","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    # an attached device."},{"line_number":28,"context_line":"    try:"},{"line_number":29,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":30,"context_line":"            obj \u003d models.Trunk(port_id\u003dtrunk_port_id,"},{"line_number":31,"context_line":"                               name\u003dname)"},{"line_number":32,"context_line":"            context.session.add(obj)"},{"line_number":33,"context_line":"            return obj"}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_8b4892b4","line":30,"updated":"2016-02-24 12:22:44.000000000","message":"all over the files using \"obj\" is a bit confusing, it makes me think that you are dealing with oslo versionedobjects but it\u0027s not the case. Maybe \"trunk\" would be better here","commit_id":"2502ddcfae6e6cec7e7d4a62d37eb8f73fe06cb1"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"dad36c414c7b3464bcc745f5cae7d982bd267390","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def delete_trunk(context, trunk_id):"},{"line_number":42,"context_line":"    try:"},{"line_number":43,"context_line":"        db.delete_object(context, models.Trunk, trunk_id)"},{"line_number":44,"context_line":"    except n_exc.ObjectNotFound:"},{"line_number":45,"context_line":"        raise n_exc.TrunkNotFound(trunk_id\u003dtrunk_id)"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_6b426eaf","line":43,"updated":"2016-02-24 12:22:44.000000000","message":"this method is meant to be used with oslo versionedobject and I don\u0027t think it\u0027s the case here","commit_id":"2502ddcfae6e6cec7e7d4a62d37eb8f73fe06cb1"}],"neutron/tests/unit/db/trunk_ports/test_api.py":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"dad36c414c7b3464bcc745f5cae7d982bd267390","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from neutron.tests import base"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class TestTrunkPortAPI(base.BaseTestCase):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def setUp(self):"},{"line_number":31,"context_line":"        super(TestTrunkPortAPI, self).setUp()"}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_4e94d889","line":28,"updated":"2016-02-24 12:22:44.000000000","message":"how about inheriting from testlib_api.SqlTestCase so that you don\u0027t need all these mocks and can check that data are correctly written and retrieved from the DB?","commit_id":"2502ddcfae6e6cec7e7d4a62d37eb8f73fe06cb1"}]}