)]}'
{"etc/neutron/plugins/openvswitch/ovs_neutron_plugin.ini":[{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"f242d641cdb7f3079609cecc57e65704dc062cd7","unresolved":false,"context_lines":[{"line_number":83,"context_line":"# bridge_mappings \u003d"},{"line_number":84,"context_line":"# Example: bridge_mappings \u003d physnet1:br-eth1"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"# (IntOpt) This is the MTU size of veth interfaces."},{"line_number":87,"context_line":"# Do not change unless you have a good reason to."},{"line_number":88,"context_line":"# The default MTU size of veth interfaces is 1500."},{"line_number":89,"context_line":"# veth_mtu \u003d"}],"source_content_type":"text/x-properties","patch_set":15,"id":"AAAAQn%2F%2FxkA%3D","line":86,"updated":"2013-07-23 13:53:39.000000000","message":"Shouldn\u0027t this be in the agent section since the agent is the entity creating the veth ports? This also will make more sense in the context of ML2, where the ML2 plugin will be run and the OVS agent will run on the hosts.","commit_id":"1bd0059d73654f9d3a7d62ce4f007cc6eaa837b4"}],"etc/quantum/plugins/openvswitch/ovs_quantum_plugin.ini":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":99,"context_line":"# In some environments where a packet could be dropped when a VLAN tag"},{"line_number":100,"context_line":"# (4 bytes) is added to the packet, you need to increase the MTU size of"},{"line_number":101,"context_line":"# veth interfaces to 1504 bytes. This is because, with tagging used for"},{"line_number":102,"context_line":"# both \u0027flat\u0027 and \u0027vlan\u0027 network type, the packet size becomes 1504 bytes."},{"line_number":103,"context_line":"# Default: veth_mtu \u003d 1500"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"[AGENT]"}],"source_content_type":"text/x-properties","patch_set":7,"id":"AAAAPH%2F%2FeBA%3D","line":102,"updated":"2013-06-03 07:36:12.000000000","message":"Most time, packet size * refers to IP packet size, the VLAN tag is in Ether Frame head. am I right?","commit_id":"eb7650dab099ddb092d51c89983ef58eb927bf20"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"8140c64b8d29274a3b0b71867ed69d8477f14816","unresolved":false,"context_lines":[{"line_number":100,"context_line":"# (4 bytes) is added to the packet, you need to increase the MTU size of"},{"line_number":101,"context_line":"# veth interfaces to 1504 bytes. This is because, with tagging used for"},{"line_number":102,"context_line":"# both \u0027flat\u0027 and \u0027vlan\u0027 network type, the packet size becomes 1504 bytes."},{"line_number":103,"context_line":"# Default: veth_mtu \u003d 1500"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"[AGENT]"},{"line_number":106,"context_line":"# Agent\u0027s polling interval in seconds"}],"source_content_type":"text/x-properties","patch_set":7,"id":"AAAAPH%2F%2FebM%3D","line":103,"updated":"2013-06-02 21:07:07.000000000","message":"I would stick to just the first two lines of this description, followed by # Example: veth_mtu \u003d 1504","commit_id":"eb7650dab099ddb092d51c89983ef58eb927bf20"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":100,"context_line":"# (4 bytes) is added to the packet, you need to increase the MTU size of"},{"line_number":101,"context_line":"# veth interfaces to 1504 bytes. This is because, with tagging used for"},{"line_number":102,"context_line":"# both \u0027flat\u0027 and \u0027vlan\u0027 network type, the packet size becomes 1504 bytes."},{"line_number":103,"context_line":"# Default: veth_mtu \u003d 1500"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"[AGENT]"},{"line_number":106,"context_line":"# Agent\u0027s polling interval in seconds"}],"source_content_type":"text/x-properties","patch_set":7,"id":"AAAAPH%2F%2FeAw%3D","line":103,"updated":"2013-06-03 07:36:12.000000000","message":"also remove Default:\n\njust # veth_mtu \u003d\n\nthis patch needs rebasing.","commit_id":"eb7650dab099ddb092d51c89983ef58eb927bf20"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"8140c64b8d29274a3b0b71867ed69d8477f14816","unresolved":false,"context_lines":[{"line_number":98,"context_line":"# (IntOpt) This is the MTU size of veth interfaces."},{"line_number":99,"context_line":"# Do not change unless you have a good reason to."},{"line_number":100,"context_line":"# The default MTU size of veth interfaces is 1500."},{"line_number":101,"context_line":"# Default: veth_mtu \u003d"},{"line_number":102,"context_line":"# Example: veth_mtu \u003d 1504"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"[AGENT]"}],"source_content_type":"text/x-properties","patch_set":8,"id":"AAAAPH%2F%2FdA0%3D","line":101,"updated":"2013-06-03 16:41:23.000000000","message":"The correct way to document default values is to not prefix with \"Default:\". See bug 1185712.","commit_id":"d3fa4b7b04e655b95c6a684c25369a10c8a5a3b6"}],"neutron/plugins/openvswitch/common/config.py":[{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"f242d641cdb7f3079609cecc57e65704dc062cd7","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    cfg.StrOpt(\u0027tunnel_type\u0027, default\u003d\u0027\u0027,"},{"line_number":57,"context_line":"               help\u003d_(\"The type of tunnels to use when utilizing tunnels, \""},{"line_number":58,"context_line":"                      \"either \u0027gre\u0027 or \u0027vxlan\u0027\")),"},{"line_number":59,"context_line":"    cfg.IntOpt(\u0027veth_mtu\u0027, default\u003dNone,"},{"line_number":60,"context_line":"               help\u003d_(\"MTU size of veth interfaces\")),"},{"line_number":61,"context_line":"]"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAQn%2F%2Fxjw%3D","line":59,"updated":"2013-07-23 13:53:39.000000000","message":"Move to the agent section of configuration.","commit_id":"1bd0059d73654f9d3a7d62ce4f007cc6eaa837b4"}],"neutron/tests/unit/openvswitch/test_ovs_tunnel.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"6eac5e7beb99ce85462bc2c26138666a08edaded","unresolved":false,"context_lines":[{"line_number":416,"context_line":"        self.mox.VerifyAll()"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"class TunnelTestWithMTU(base.BaseTestCase):"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"    def setUp(self):"},{"line_number":422,"context_line":"        super(TunnelTestWithMTU, self).setUp()"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAQn%2F%2F7BM%3D","line":419,"updated":"2013-07-19 03:24:59.000000000","message":"You should make a common base class for both tests instead of copying a very long constructor.","commit_id":"fa88359d60c7ba9d978bcb2a3f8b357a3ed8c0d4"}],"quantum/plugins/openvswitch/agent/ovs_quantum_agent.py":[{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"365cdd2a072441c40cf921286a6b1939b523c74b","unresolved":false,"context_lines":[{"line_number":592,"context_line":"            phys_veth.link.set_up()"},{"line_number":593,"context_line":""},{"line_number":594,"context_line":"            # with tagging used for both \u0027flat\u0027 and \u0027vlan\u0027 network type,"},{"line_number":595,"context_line":"            # the default MTU size of veth interfaces should be 1504."},{"line_number":596,"context_line":"            int_veth.link.set_mtu(self.veth_mtu)"},{"line_number":597,"context_line":"            phys_veth.link.set_mtu(self.veth_mtu)"},{"line_number":598,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FmDU%3D","line":595,"updated":"2013-05-02 14:58:28.000000000","message":"Just a minor nit, it may make sense to move this comment up to where you define DEFAULT_VETH_MTU since you are referencing the 1504 value here.","commit_id":"8ece8df09b25fa399d75c797b961e95aadb5bafa"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"8908110497b179f02d034ecd7af67074897dd8de","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        :param root_helper: utility to use when running shell cmds."},{"line_number":168,"context_line":"        :param polling_interval: interval (secs) to poll DB."},{"line_number":169,"context_line":"        :param enable_tunneling: if True enable GRE networks."},{"line_number":170,"context_line":"        \u0027\u0027\u0027"},{"line_number":171,"context_line":"        self.veth_mtu \u003d veth_mtu"},{"line_number":172,"context_line":"        self.root_helper \u003d root_helper"},{"line_number":173,"context_line":"        self.available_local_vlans \u003d set("}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fbpk%3D","line":170,"updated":"2013-05-09 20:54:40.000000000","message":"nit: please add the description for \"veth_mtu\" here","commit_id":"5d1ed1e924d2f5cceebceb9bedf28e5b444f9792"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"8908110497b179f02d034ecd7af67074897dd8de","unresolved":false,"context_lines":[{"line_number":593,"context_line":"            phys_veth.link.set_up()"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"            int_veth.link.set_mtu(self.veth_mtu)"},{"line_number":596,"context_line":"            phys_veth.link.set_mtu(self.veth_mtu)"},{"line_number":597,"context_line":""},{"line_number":598,"context_line":"    def update_ports(self, registered_ports):"},{"line_number":599,"context_line":"        ports \u003d self.int_br.get_vif_port_set()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FbpQ%3D","line":596,"updated":"2013-05-09 20:54:40.000000000","message":"question: could the mtu config be done before lines 595-596?","commit_id":"5d1ed1e924d2f5cceebceb9bedf28e5b444f9792"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"c35709d16aad2d099ce5328fcd167a866b736d8a","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    # With tagging used for both \u0027flat\u0027 and \u0027vlan\u0027 network type,"},{"line_number":149,"context_line":"    # the default MTU size of veth interfaces should be 1504."},{"line_number":150,"context_line":"    DEFAULT_VETH_MTU \u003d 1504"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    # history"},{"line_number":153,"context_line":"    #   1.0 Initial version"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOn%2F%2FXxo%3D","line":150,"updated":"2013-05-13 10:50:47.000000000","message":"no need to define constant here since we are using configure.","commit_id":"49eb510b14717f0cbdd4844bda8e5da369501fa6"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"cf3999b909ab3ceaa8388cc7342d020ca8bf62c8","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    #   1.1 Support Security Group RPC"},{"line_number":155,"context_line":"    RPC_API_VERSION \u003d \u00271.1\u0027"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def __init__(self, integ_br, tun_br, local_ip,"},{"line_number":158,"context_line":"                 bridge_mappings, root_helper,"},{"line_number":159,"context_line":"                 polling_interval, enable_tunneling,"},{"line_number":160,"context_line":"                 veth_mtu\u003dDEFAULT_VETH_MTU):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOn%2F%2FYio%3D","line":157,"updated":"2013-05-12 05:05:55.000000000","message":"Maybe I am just too tired - but I did not see the veth_mtu being set from the configuration value.\n\nThis should be set at the creation of the dictionary at:\nhttps://github.com/openstack/quantum/blob/master/quantum/plugins/openvswitch/agent/ovs_quantum_agent.py#L746\n\nThe new value veth_mtu is missing","commit_id":"49eb510b14717f0cbdd4844bda8e5da369501fa6"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"8140c64b8d29274a3b0b71867ed69d8477f14816","unresolved":false,"context_lines":[{"line_number":589,"context_line":"            # enable veth to pass traffic"},{"line_number":590,"context_line":"            int_veth.link.set_up()"},{"line_number":591,"context_line":"            phys_veth.link.set_up()"},{"line_number":592,"context_line":""},{"line_number":593,"context_line":"            # set up mtu size for veth interfaces"},{"line_number":594,"context_line":"            int_veth.link.set_mtu(self.veth_mtu)"},{"line_number":595,"context_line":"            phys_veth.link.set_mtu(self.veth_mtu)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPH%2F%2FebI%3D","line":592,"updated":"2013-06-02 21:07:07.000000000","message":"Setting the MTU should be done only under the condition:\n\n    if self.veth_mtu:","commit_id":"eb7650dab099ddb092d51c89983ef58eb927bf20"}],"quantum/plugins/openvswitch/common/config.py":[{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"8908110497b179f02d034ecd7af67074897dd8de","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    cfg.ListOpt(\u0027tunnel_id_ranges\u0027,"},{"line_number":53,"context_line":"                default\u003dDEFAULT_TUNNEL_RANGES,"},{"line_number":54,"context_line":"                help\u003d_(\"List of \u003ctun_min\u003e:\u003ctun_max\u003e\")),"},{"line_number":55,"context_line":"    cfg.IntOpt(\u0027veth_mtu\u0027, default\u003d1504),"},{"line_number":56,"context_line":"]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"agent_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fbn0%3D","line":55,"updated":"2013-05-09 20:54:40.000000000","message":"we are reading this value but I dont see the new variable in:\novs_quantum_plumgin.ini\nAm I missing something?","commit_id":"5d1ed1e924d2f5cceebceb9bedf28e5b444f9792"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"cf3999b909ab3ceaa8388cc7342d020ca8bf62c8","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    cfg.ListOpt(\u0027tunnel_id_ranges\u0027,"},{"line_number":53,"context_line":"                default\u003dDEFAULT_TUNNEL_RANGES,"},{"line_number":54,"context_line":"                help\u003d_(\"List of \u003ctun_min\u003e:\u003ctun_max\u003e\")),"},{"line_number":55,"context_line":"    cfg.IntOpt(\u0027veth_mtu\u0027, default\u003d1504),"},{"line_number":56,"context_line":"]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"agent_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOn%2F%2FYis%3D","line":55,"updated":"2013-05-12 05:05:55.000000000","message":"Please add the help field with a short explanation.","commit_id":"49eb510b14717f0cbdd4844bda8e5da369501fa6"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"8140c64b8d29274a3b0b71867ed69d8477f14816","unresolved":false,"context_lines":[{"line_number":23,"context_line":"DEFAULT_BRIDGE_MAPPINGS \u003d []"},{"line_number":24,"context_line":"DEFAULT_VLAN_RANGES \u003d []"},{"line_number":25,"context_line":"DEFAULT_TUNNEL_RANGES \u003d []"},{"line_number":26,"context_line":"DEFAULT_VETH_MTU \u003d 1500"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"ovs_opts \u003d ["},{"line_number":29,"context_line":"    cfg.StrOpt(\u0027integration_bridge\u0027, default\u003d\u0027br-int\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPH%2F%2FebE%3D","line":26,"updated":"2013-06-02 21:07:07.000000000","message":"Remove this.","commit_id":"eb7650dab099ddb092d51c89983ef58eb927bf20"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"8140c64b8d29274a3b0b71867ed69d8477f14816","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    cfg.ListOpt(\u0027tunnel_id_ranges\u0027,"},{"line_number":54,"context_line":"                default\u003dDEFAULT_TUNNEL_RANGES,"},{"line_number":55,"context_line":"                help\u003d_(\"List of \u003ctun_min\u003e:\u003ctun_max\u003e\")),"},{"line_number":56,"context_line":"    cfg.IntOpt(\u0027veth_mtu\u0027, default\u003dDEFAULT_VETH_MTU,"},{"line_number":57,"context_line":"               help\u003d_(\"MTU size of veth interfaces\")),"},{"line_number":58,"context_line":"]"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPH%2F%2FebA%3D","line":56,"updated":"2013-06-02 21:07:07.000000000","message":"default\u003dNone","commit_id":"eb7650dab099ddb092d51c89983ef58eb927bf20"}],"quantum/tests/unit/openvswitch/test_ovs_defaults.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"8140c64b8d29274a3b0b71867ed69d8477f14816","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        self.assertEqual(0, len(cfg.CONF.OVS.bridge_mappings))"},{"line_number":32,"context_line":"        self.assertEqual(0, len(cfg.CONF.OVS.network_vlan_ranges))"},{"line_number":33,"context_line":"        self.assertEqual(0, len(cfg.CONF.OVS.tunnel_id_ranges))"},{"line_number":34,"context_line":"        self.assertEqual(1500, cfg.CONF.OVS.veth_mtu)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPH%2F%2Fea8%3D","line":34,"updated":"2013-06-02 21:07:07.000000000","message":"None","commit_id":"eb7650dab099ddb092d51c89983ef58eb927bf20"}]}