)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"2870e93ddb17abfaad16ddf1a91d874e514800c9","unresolved":false,"context_lines":[{"line_number":21,"context_line":"contract (backward compat of the subnet-create command), and b) it"},{"line_number":22,"context_line":"leads to ambiguity of the API."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"This patch restores the semantic of the subnet_create API where it is"},{"line_number":25,"context_line":"mandatory to specify CIDR/IP version regardless of the conditions"},{"line_number":26,"context_line":"under which the request is issued. On the other hand, associating"},{"line_number":27,"context_line":"subnets to subnet pools will have to be more prescriptive, and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"dae33548_b89196f3","line":24,"range":{"start_line":24,"start_character":24,"end_line":24,"end_character":32},"updated":"2016-02-17 22:39:00.000000000","message":"I am sure to understand what this patch \"restores\": we have to specify a cidr even when a default subnet-pool is defined? when a subnet-pool is provided in subnet-create?\n\nPerhaps an example could help to understand current/new behaviors.\n\nEDIT: cidr or a subnetpool is required in subnet-create even if a default subnet pool is defined (according to updated tests)a","commit_id":"d38aeade9db7169955b4524a5fc8d814067dec15"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"9c378944a8944e5d201ace475bd32926649bbabb","unresolved":false,"context_lines":[{"line_number":21,"context_line":"contract (backward compat of the subnet-create command), and b) it"},{"line_number":22,"context_line":"leads to ambiguity of the API."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"This patch restores the semantic of the subnet_create API where it is"},{"line_number":25,"context_line":"mandatory to specify CIDR/IP version regardless of the conditions"},{"line_number":26,"context_line":"under which the request is issued. On the other hand, associating"},{"line_number":27,"context_line":"subnets to subnet pools will have to be more prescriptive, and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"dae33548_7329bfe5","line":24,"range":{"start_line":24,"start_character":24,"end_line":24,"end_character":32},"in_reply_to":"dae33548_78999cc3","updated":"2016-02-18 16:48:09.000000000","message":"There is an implicit assumption here that this is in the context of when no subnet pool is specified.  I got it but I can see how it could easily be missed.  But, I\u0027m not concerned about this.  As long as we get it correct in the docs correctly, I\u0027m not sure a respin is necessary.  This has DocImpact and so we will follow up with docs changes.","commit_id":"d38aeade9db7169955b4524a5fc8d814067dec15"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"8f3adf62856f046f1e51b9fc2c3d15b1bef57571","unresolved":false,"context_lines":[{"line_number":21,"context_line":"contract (backward compat of the subnet-create command), and b) it"},{"line_number":22,"context_line":"leads to ambiguity of the API."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"This patch restores the semantic of the subnet_create API where it is"},{"line_number":25,"context_line":"mandatory to specify CIDR/IP version regardless of the conditions"},{"line_number":26,"context_line":"under which the request is issued. On the other hand, associating"},{"line_number":27,"context_line":"subnets to subnet pools will have to be more prescriptive, and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"dae33548_78999cc3","line":24,"range":{"start_line":24,"start_character":24,"end_line":24,"end_character":32},"in_reply_to":"dae33548_b89196f3","updated":"2016-02-18 16:24:13.000000000","message":"A cidr must be specified, unless a subnetpool is explicitly specified. I can rephrase to make it clear.","commit_id":"d38aeade9db7169955b4524a5fc8d814067dec15"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"889dc2566d061174989e5b16494a9c3225e48022","unresolved":false,"context_lines":[{"line_number":21,"context_line":"contract (backward compat of the subnet-create command), and b) it"},{"line_number":22,"context_line":"leads to ambiguity of the API."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"This patch restores the semantic of the subnet_create API where it is"},{"line_number":25,"context_line":"mandatory to specify CIDR/IP version regardless of the conditions"},{"line_number":26,"context_line":"under which the request is issued. On the other hand, associating"},{"line_number":27,"context_line":"subnets to subnet pools will have to be more prescriptive, and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"dae33548_d32c3d9b","line":24,"range":{"start_line":24,"start_character":24,"end_line":24,"end_character":32},"in_reply_to":"dae33548_b89196f3","updated":"2016-02-17 22:41:46.000000000","message":"Oups, you should read:\n\n I am NOT sure ...","commit_id":"d38aeade9db7169955b4524a5fc8d814067dec15"}],"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"b844724dcd072020c73dce0e1ab26d9388e11b8b","unresolved":false,"context_lines":[{"line_number":601,"context_line":"        \"\"\""},{"line_number":602,"context_line":"        subnetpool_id \u003d subnet.get(\u0027subnetpool_id\u0027,"},{"line_number":603,"context_line":"                                   attributes.ATTR_NOT_SPECIFIED)"},{"line_number":604,"context_line":"        cidr \u003d subnet.get(\u0027cidr\u0027)"},{"line_number":605,"context_line":"        if subnetpool_id !\u003d attributes.ATTR_NOT_SPECIFIED:"},{"line_number":606,"context_line":"            return subnetpool_id"},{"line_number":607,"context_line":"        elif not attributes.is_attr_set(cidr):"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_9d584934","line":604,"updated":"2016-02-16 21:03:26.000000000","message":"In my local copy, I have the following code for this method which is equivalent and much simpler:\n\n        subnetpool_id \u003d subnet.get(\u0027subnetpool_id\u0027,\n                                   attributes.ATTR_NOT_SPECIFIED)\n        if subnetpool_id !\u003d attributes.ATTR_NOT_SPECIFIED:\n            return subnetpool_id\n\n        cidr \u003d subnet.get(\u0027cidr\u0027)\n        if not attributes.is_attr_set(cidr):\n            # TODO(carl_baldwin): allow requests asking for \u0027default\u0027 pools\n            msg \u003d _(\u0027a subnetpool must be specified in the absence of a cidr\u0027)\n            raise n_exc.BadRequest(resource\u003d\u0027subnets\u0027, msg\u003dmsg)\n        return","commit_id":"e169fec17ca72e3edf077373b8beb050949ff16c"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"c05ab39471ad10bebb13a7902c2afbff1fd8d2a6","unresolved":false,"context_lines":[{"line_number":604,"context_line":"        cidr \u003d subnet.get(\u0027cidr\u0027)"},{"line_number":605,"context_line":"        if subnetpool_id !\u003d attributes.ATTR_NOT_SPECIFIED:"},{"line_number":606,"context_line":"            return subnetpool_id"},{"line_number":607,"context_line":"        elif not attributes.is_attr_set(cidr):"},{"line_number":608,"context_line":"            # TODO(carl_baldwin): allow requests asking for \u0027default\u0027 pools"},{"line_number":609,"context_line":"            msg \u003d _(\u0027a subnetpool must be specified in the absence of a cidr\u0027)"},{"line_number":610,"context_line":"            raise n_exc.BadRequest(resource\u003d\u0027subnets\u0027, msg\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_729db458","line":607,"range":{"start_line":607,"start_character":8,"end_line":607,"end_character":10},"updated":"2016-02-16 20:54:24.000000000","message":"nit:  This isn\u0027t really part of the change.  With the \"return\" statement on L606 elif isn\u0027t necessary and just forces you to move the assignment of cidr to L604 like you\u0027ve done.","commit_id":"e169fec17ca72e3edf077373b8beb050949ff16c"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"c05ab39471ad10bebb13a7902c2afbff1fd8d2a6","unresolved":false,"context_lines":[{"line_number":610,"context_line":"            raise n_exc.BadRequest(resource\u003d\u0027subnets\u0027, msg\u003dmsg)"},{"line_number":611,"context_line":"        elif attributes.is_attr_set(cidr):"},{"line_number":612,"context_line":"            return"},{"line_number":613,"context_line":"        else:"},{"line_number":614,"context_line":"            ip_version \u003d subnet.get(\u0027ip_version\u0027)"},{"line_number":615,"context_line":"            if not attributes.is_attr_set(ip_version):"},{"line_number":616,"context_line":"                msg \u003d _(\u0027ip_version must be specified in the absence of \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_521350b8","line":613,"range":{"start_line":613,"start_character":8,"end_line":613,"end_character":12},"updated":"2016-02-16 20:54:24.000000000","message":"This is dead code, no?","commit_id":"e169fec17ca72e3edf077373b8beb050949ff16c"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"c05ab39471ad10bebb13a7902c2afbff1fd8d2a6","unresolved":false,"context_lines":[{"line_number":616,"context_line":"                msg \u003d _(\u0027ip_version must be specified in the absence of \u0027"},{"line_number":617,"context_line":"                        \u0027cidr and subnetpool_id\u0027)"},{"line_number":618,"context_line":"                raise n_exc.BadRequest(resource\u003d\u0027subnets\u0027, msg\u003dmsg)"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"        if ip_version \u003d\u003d 6 and cfg.CONF.ipv6_pd_enabled:"},{"line_number":621,"context_line":"            return constants.IPV6_PD_POOL_ID"},{"line_number":622,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_f21c24c3","line":619,"updated":"2016-02-16 20:54:24.000000000","message":"On L610 we raise BadRequest in cidr is not set.  On L612, we return if cidr is set.  So, the rest of this code is unreachable or dead code.","commit_id":"e169fec17ca72e3edf077373b8beb050949ff16c"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e674769182471da1ac82bd6238275b317ba51026","unresolved":false,"context_lines":[{"line_number":604,"context_line":"        if subnetpool_id !\u003d attributes.ATTR_NOT_SPECIFIED:"},{"line_number":605,"context_line":"            return subnetpool_id"},{"line_number":606,"context_line":""},{"line_number":607,"context_line":"        cidr \u003d subnet.get(\u0027cidr\u0027)"},{"line_number":608,"context_line":"        if not attributes.is_attr_set(cidr):"},{"line_number":609,"context_line":"            # TODO(carl_baldwin): allow requests asking for \u0027default\u0027 pools"},{"line_number":610,"context_line":"            msg \u003d _(\u0027a subnetpool must be specified in the absence of a cidr\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"dae33548_5defe186","line":607,"updated":"2016-02-16 21:19:01.000000000","message":"I hope you don\u0027t mind me posting this over yours.  If you compare this to PS5 you\u0027ll see all the code that I removed.  It is all dead because either L610 and L612 in PS5 will get hit.  The rest of the method cannot be reached.","commit_id":"53d64e2fb1c79bb89ffb753af11ba55c1f09245f"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"58aea3ea4e5a6c58650031878fdc4d4a8752b946","unresolved":false,"context_lines":[{"line_number":614,"context_line":"            subnet[\u0027subnet\u0027][\u0027cidr\u0027] \u003d \u0027%s/%s\u0027 % (net.network, net.prefixlen)"},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"        subnetpool_id \u003d self._get_subnetpool_id(context, s)"},{"line_number":617,"context_line":"        if not subnetpool_id and not has_cidr:"},{"line_number":618,"context_line":"            # TODO(carl_baldwin): allow requests asking for \u0027default\u0027 pools"},{"line_number":619,"context_line":"            msg \u003d _(\u0027a subnetpool must be specified in the absence of a cidr\u0027)"},{"line_number":620,"context_line":"            raise n_exc.BadRequest(resource\u003d\u0027subnets\u0027, msg\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_25c3d6ee","line":617,"updated":"2016-02-17 04:52:18.000000000","message":"Yes, this makes a lot more sense here than where it was before.","commit_id":"d38aeade9db7169955b4524a5fc8d814067dec15"}]}
