)]}'
{"neutron/hacking/checks.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"7fe7bc797c161ac3b88889ae30696d3c1382dd30","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            return"},{"line_number":122,"context_line":"        uncased_line \u003d logical_line.lower().replace(\u0027_\u0027, \u0027\u0027)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        if list(filter(lambda x: x in uncased_line,"},{"line_number":125,"context_line":"                       [\u0027.assertcalledonce\u0027, \u0027.calledoncewith\u0027])):"},{"line_number":126,"context_line":"            msg \u003d (\"N322: Possible use of no-op mock method. \""},{"line_number":127,"context_line":"                   \"please use assert_called_once_with.\")"},{"line_number":128,"context_line":"            yield (0, msg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_443d65ba","line":125,"range":{"start_line":124,"start_character":11,"end_line":125,"end_character":65},"updated":"2016-02-16 13:34:46.000000000","message":"Combination of list() and filter() and lambda seems complex. Why don\u0027t [x for x in [\u0027.assertcalledonce\u0027, \u0027.calledoncewith\u0027] if x in uncased_line]?\n\n\nAnd also I like to define [\u0027.assertcalledonce\u0027, \u0027.calledoncewith\u0027] as a variable before. For example the following?\n\n\n check_calls\u003d[\u0027.assertcalledonce\u0027, \u0027.calledoncewith\u0027]\n if [x for x in check_calls if x in uncased_line]:","commit_id":"eea1139728baca0cb85afd987fe68287930debd2"},{"author":{"_account_id":8686,"name":"Wang Bo","email":"bo.wang@easystack.cn","username":"wangbo"},"change_message_id":"6e1e14ef3d2099837944445cf308bd38976e1a08","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            return"},{"line_number":122,"context_line":"        uncased_line \u003d logical_line.lower().replace(\u0027_\u0027, \u0027\u0027)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        if list(filter(lambda x: x in uncased_line,"},{"line_number":125,"context_line":"                       [\u0027.assertcalledonce\u0027, \u0027.calledoncewith\u0027])):"},{"line_number":126,"context_line":"            msg \u003d (\"N322: Possible use of no-op mock method. \""},{"line_number":127,"context_line":"                   \"please use assert_called_once_with.\")"},{"line_number":128,"context_line":"            yield (0, msg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_7fff54aa","line":125,"range":{"start_line":124,"start_character":11,"end_line":125,"end_character":65},"in_reply_to":"dae33548_443d65ba","updated":"2016-02-16 13:49:16.000000000","message":"Thanks for your comments. It\u0027s really clear and easy to read than my current code.\n\nDone as your comments in patch set 5.","commit_id":"eea1139728baca0cb85afd987fe68287930debd2"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"cce7d8b53403b7b0f7385d028c9cee9aec35b7e4","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        uncased_line \u003d logical_line.lower().replace(\u0027_\u0027, \u0027\u0027)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        check_calls \u003d [\u0027.assertcalledonce\u0027, \u0027.calledoncewith\u0027]"},{"line_number":125,"context_line":"        if [x for x in check_calls if x in uncased_line]:"},{"line_number":126,"context_line":"            msg \u003d (\"N322: Possible use of no-op mock method. \""},{"line_number":127,"context_line":"                   \"please use assert_called_once_with.\")"},{"line_number":128,"context_line":"            yield (0, msg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_fefec136","line":125,"updated":"2016-02-16 15:28:13.000000000","message":"An even more Pythonic way to express your intent is to use \u0027any\u0027 instead of a list:\n\nif any(x for x in check_calls if x in uncased_line):\n    ...","commit_id":"19106445cd6b18090b1259d3a0a49ce3ce15c4e3"},{"author":{"_account_id":8686,"name":"Wang Bo","email":"bo.wang@easystack.cn","username":"wangbo"},"change_message_id":"1093da83756a705936142d88a16f608e6d738d7b","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        uncased_line \u003d logical_line.lower().replace(\u0027_\u0027, \u0027\u0027)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        check_calls \u003d [\u0027.assertcalledonce\u0027, \u0027.calledoncewith\u0027]"},{"line_number":125,"context_line":"        if [x for x in check_calls if x in uncased_line]:"},{"line_number":126,"context_line":"            msg \u003d (\"N322: Possible use of no-op mock method. \""},{"line_number":127,"context_line":"                   \"please use assert_called_once_with.\")"},{"line_number":128,"context_line":"            yield (0, msg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_499c5569","line":125,"in_reply_to":"dae33548_fefec136","updated":"2016-02-16 15:39:14.000000000","message":"yes, you are right.\n\nDone in patch set 6.","commit_id":"19106445cd6b18090b1259d3a0a49ce3ce15c4e3"}],"neutron/tests/unit/agent/dhcp/test_agent.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b75a7c10fc1f8d0a52dbf2b870c1c054c885dbc3","unresolved":false,"context_lines":[{"line_number":1490,"context_line":"            uuid5.return_value \u003d \u00271ae5f96c-c527-5079-82ea-371a01645457\u0027"},{"line_number":1491,"context_line":""},{"line_number":1492,"context_line":"            dh \u003d dhcp.DeviceManager(cfg.CONF, None)"},{"line_number":1493,"context_line":"            uuid5.assert_called_once_with(uuid.NAMESPACE_DNS, cfg.CONF.host)"},{"line_number":1494,"context_line":"            self.assertEqual(dh.get_device_id(fake_net), expected)"},{"line_number":1495,"context_line":""},{"line_number":1496,"context_line":"    def test_update(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_d9ffbc32","line":1493,"updated":"2016-02-16 00:26:00.000000000","message":"py27 and py34 are supposedly failing here... \nEvidently, I cannot find any documentation for called_once_with , because it was just a mock function ( as per the bug)\nIt may be possible that earlier there was no call made for uuid5, and due to the mock function, no error was reported, but now with assert_called_once_with , the error has been highlighted( which may be a good thing in the hindsight)\n\nCan you look into it once, maybe there are more changes than expected","commit_id":"17765e728d4ad4fb021383b77ff5dbe01bfccb9e"},{"author":{"_account_id":8686,"name":"Wang Bo","email":"bo.wang@easystack.cn","username":"wangbo"},"change_message_id":"f5e0daecf160aedffa5c7a904be0c68202358ec4","unresolved":false,"context_lines":[{"line_number":1490,"context_line":"            uuid5.return_value \u003d \u00271ae5f96c-c527-5079-82ea-371a01645457\u0027"},{"line_number":1491,"context_line":""},{"line_number":1492,"context_line":"            dh \u003d dhcp.DeviceManager(cfg.CONF, None)"},{"line_number":1493,"context_line":"            uuid5.assert_called_once_with(uuid.NAMESPACE_DNS, cfg.CONF.host)"},{"line_number":1494,"context_line":"            self.assertEqual(dh.get_device_id(fake_net), expected)"},{"line_number":1495,"context_line":""},{"line_number":1496,"context_line":"    def test_update(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_28864b13","line":1493,"in_reply_to":"dae33548_d9ffbc32","updated":"2016-02-16 05:22:16.000000000","message":"thanks for review.\n\nFix this in patch set 3.","commit_id":"17765e728d4ad4fb021383b77ff5dbe01bfccb9e"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"2428dd6c3c719bd0a000c52be8d9f78a32b97924","unresolved":false,"context_lines":[{"line_number":1490,"context_line":"            uuid5.return_value \u003d \u00271ae5f96c-c527-5079-82ea-371a01645457\u0027"},{"line_number":1491,"context_line":""},{"line_number":1492,"context_line":"            dh \u003d dhcp.DeviceManager(cfg.CONF, None)"},{"line_number":1493,"context_line":"            uuid5.called_once_with(uuid.NAMESPACE_DNS, cfg.CONF.host)"},{"line_number":1494,"context_line":"            self.assertEqual(dh.get_device_id(fake_net), expected)"},{"line_number":1495,"context_line":""},{"line_number":1496,"context_line":"    def test_update(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"dae33548_119ffdb4","side":"PARENT","line":1493,"range":{"start_line":1493,"start_character":18,"end_line":1493,"end_character":34},"updated":"2016-02-17 01:00:16.000000000","message":"This is the ugliest part about mock.  This is one of the reasons I never trust a test or assertion that I write that I haven\u0027t seen fail properly.  I have no doubt the original author never saw this fail.  Just wrote it and forgot about it.","commit_id":"33eec87d7822c0915bd45f2c9d2de0b6dc455771"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"2428dd6c3c719bd0a000c52be8d9f78a32b97924","unresolved":false,"context_lines":[{"line_number":1490,"context_line":"            uuid5.return_value \u003d \u00271ae5f96c-c527-5079-82ea-371a01645457\u0027"},{"line_number":1491,"context_line":""},{"line_number":1492,"context_line":"            dh \u003d dhcp.DeviceManager(cfg.CONF, None)"},{"line_number":1493,"context_line":"            device_id \u003d dh.get_device_id(fake_net)"},{"line_number":1494,"context_line":"            uuid5.assert_called_once_with(uuid.NAMESPACE_DNS, cfg.CONF.host)"},{"line_number":1495,"context_line":"            self.assertEqual(device_id, expected)"},{"line_number":1496,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"dae33548_51a985de","line":1493,"range":{"start_line":1493,"start_character":12,"end_line":1493,"end_character":21},"updated":"2016-02-17 01:00:16.000000000","message":"Why are you making this change too?","commit_id":"d61c9d8ceb20c03cee4c297f7a6b315ff0344a97"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"1c6e2a6ab61bc2bec0219df0eafd4d673835f38c","unresolved":false,"context_lines":[{"line_number":1490,"context_line":"            uuid5.return_value \u003d \u00271ae5f96c-c527-5079-82ea-371a01645457\u0027"},{"line_number":1491,"context_line":""},{"line_number":1492,"context_line":"            dh \u003d dhcp.DeviceManager(cfg.CONF, None)"},{"line_number":1493,"context_line":"            device_id \u003d dh.get_device_id(fake_net)"},{"line_number":1494,"context_line":"            uuid5.assert_called_once_with(uuid.NAMESPACE_DNS, cfg.CONF.host)"},{"line_number":1495,"context_line":"            self.assertEqual(device_id, expected)"},{"line_number":1496,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"dae33548_bd5348e1","line":1493,"range":{"start_line":1493,"start_character":12,"end_line":1493,"end_character":21},"in_reply_to":"dae33548_51a985de","updated":"2016-02-17 21:55:18.000000000","message":"+1 out of change scope ... it doesn\u0027t help to understand the change","commit_id":"d61c9d8ceb20c03cee4c297f7a6b315ff0344a97"},{"author":{"_account_id":8686,"name":"Wang Bo","email":"bo.wang@easystack.cn","username":"wangbo"},"change_message_id":"a157ccd3cad4156b594134f5f7a1f85bd0751301","unresolved":false,"context_lines":[{"line_number":1490,"context_line":"            uuid5.return_value \u003d \u00271ae5f96c-c527-5079-82ea-371a01645457\u0027"},{"line_number":1491,"context_line":""},{"line_number":1492,"context_line":"            dh \u003d dhcp.DeviceManager(cfg.CONF, None)"},{"line_number":1493,"context_line":"            device_id \u003d dh.get_device_id(fake_net)"},{"line_number":1494,"context_line":"            uuid5.assert_called_once_with(uuid.NAMESPACE_DNS, cfg.CONF.host)"},{"line_number":1495,"context_line":"            self.assertEqual(device_id, expected)"},{"line_number":1496,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"dae33548_98e929ba","line":1493,"range":{"start_line":1493,"start_character":12,"end_line":1493,"end_character":21},"in_reply_to":"dae33548_51a985de","updated":"2016-02-18 03:34:20.000000000","message":"dh.get_device_id(fake_net) will call uuid5 so we should move this before uuid5.assert_called_once_with(). Otherwise this test will fail.\n\nother solution is: \nself.assertEqual(dh.get_device_id(fake_net), expected)\nuuid5.assert_called_once_with(uuid.NAMESPACE_DNS, cfg.CONF.host)\n\nhow do you think it?","commit_id":"d61c9d8ceb20c03cee4c297f7a6b315ff0344a97"},{"author":{"_account_id":8686,"name":"Wang Bo","email":"bo.wang@easystack.cn","username":"wangbo"},"change_message_id":"a157ccd3cad4156b594134f5f7a1f85bd0751301","unresolved":false,"context_lines":[{"line_number":1490,"context_line":"            uuid5.return_value \u003d \u00271ae5f96c-c527-5079-82ea-371a01645457\u0027"},{"line_number":1491,"context_line":""},{"line_number":1492,"context_line":"            dh \u003d dhcp.DeviceManager(cfg.CONF, None)"},{"line_number":1493,"context_line":"            device_id \u003d dh.get_device_id(fake_net)"},{"line_number":1494,"context_line":"            uuid5.assert_called_once_with(uuid.NAMESPACE_DNS, cfg.CONF.host)"},{"line_number":1495,"context_line":"            self.assertEqual(device_id, expected)"},{"line_number":1496,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"dae33548_7815459a","line":1493,"range":{"start_line":1493,"start_character":12,"end_line":1493,"end_character":21},"in_reply_to":"dae33548_bd5348e1","updated":"2016-02-18 03:34:20.000000000","message":"dh.get_device_id(fake_net) will call uuid5 so we should move this before uuid5.assert_called_once_with(). Otherwise this test will fail.\n\nother solution is: \nself.assertEqual(dh.get_device_id(fake_net), expected)\nuuid5.assert_called_once_with(uuid.NAMESPACE_DNS, cfg.CONF.host)\n\nhow do you think it?","commit_id":"d61c9d8ceb20c03cee4c297f7a6b315ff0344a97"}],"neutron/tests/unit/agent/metadata/test_agent.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"2428dd6c3c719bd0a000c52be8d9f78a32b97924","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                                  ) as mock_get_router_networks:"},{"line_number":206,"context_line":"            ports \u003d self.handler._get_ports(remote_address,"},{"line_number":207,"context_line":"                                            router_id\u003drouter_id)"},{"line_number":208,"context_line":"            mock_get_ip_addr.assert_called_once_with(remote_address, networks)"},{"line_number":209,"context_line":"            mock_get_router_networks.assert_called_once_with(router_id)"},{"line_number":210,"context_line":"            self.assertEqual(expected, ports)"},{"line_number":211,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"dae33548_d18c7581","line":208,"range":{"start_line":208,"start_character":12,"end_line":208,"end_character":28},"updated":"2016-02-17 01:00:16.000000000","message":"Is there a particular reason that you swapped the order of these assertions?","commit_id":"d61c9d8ceb20c03cee4c297f7a6b315ff0344a97"},{"author":{"_account_id":8686,"name":"Wang Bo","email":"bo.wang@easystack.cn","username":"wangbo"},"change_message_id":"a157ccd3cad4156b594134f5f7a1f85bd0751301","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                                  ) as mock_get_router_networks:"},{"line_number":206,"context_line":"            ports \u003d self.handler._get_ports(remote_address,"},{"line_number":207,"context_line":"                                            router_id\u003drouter_id)"},{"line_number":208,"context_line":"            mock_get_ip_addr.assert_called_once_with(remote_address, networks)"},{"line_number":209,"context_line":"            mock_get_router_networks.assert_called_once_with(router_id)"},{"line_number":210,"context_line":"            self.assertEqual(expected, ports)"},{"line_number":211,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"dae33548_f8b31596","line":208,"range":{"start_line":208,"start_character":12,"end_line":208,"end_character":28},"in_reply_to":"dae33548_d18c7581","updated":"2016-02-18 03:34:20.000000000","message":"Do this because the mock order in with statments above: \"mock_get_ip_addr\" first then \"mock_get_router_networks\".\n\nresume the order in patch set 7.","commit_id":"d61c9d8ceb20c03cee4c297f7a6b315ff0344a97"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"2428dd6c3c719bd0a000c52be8d9f78a32b97924","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            ports \u003d self.handler._get_ports(remote_address,"},{"line_number":207,"context_line":"                                            router_id\u003drouter_id)"},{"line_number":208,"context_line":"            mock_get_ip_addr.assert_called_once_with(remote_address, networks)"},{"line_number":209,"context_line":"            mock_get_router_networks.assert_called_once_with(router_id)"},{"line_number":210,"context_line":"            self.assertEqual(expected, ports)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    def test_get_ports_no_id(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"dae33548_51806546","line":209,"range":{"start_line":209,"start_character":0,"end_line":209,"end_character":4},"updated":"2016-02-17 01:00:16.000000000","message":"Again, you\u0027re fixing stuff that shouldn\u0027t be fixed with this patch set.","commit_id":"d61c9d8ceb20c03cee4c297f7a6b315ff0344a97"},{"author":{"_account_id":8686,"name":"Wang Bo","email":"bo.wang@easystack.cn","username":"wangbo"},"change_message_id":"a157ccd3cad4156b594134f5f7a1f85bd0751301","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            ports \u003d self.handler._get_ports(remote_address,"},{"line_number":207,"context_line":"                                            router_id\u003drouter_id)"},{"line_number":208,"context_line":"            mock_get_ip_addr.assert_called_once_with(remote_address, networks)"},{"line_number":209,"context_line":"            mock_get_router_networks.assert_called_once_with(router_id)"},{"line_number":210,"context_line":"            self.assertEqual(expected, ports)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    def test_get_ports_no_id(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"dae33548_d87571cb","line":209,"range":{"start_line":209,"start_character":0,"end_line":209,"end_character":4},"in_reply_to":"dae33548_51806546","updated":"2016-02-18 03:34:20.000000000","message":"resume the order back in patch set 7.","commit_id":"d61c9d8ceb20c03cee4c297f7a6b315ff0344a97"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"6ee193d5ca4903644fb5b8fe9ae498e2b7c8ed0c","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            ports \u003d self.handler._get_ports(remote_address,"},{"line_number":207,"context_line":"                                            router_id\u003drouter_id)"},{"line_number":208,"context_line":"            mock_get_router_networks.assert_called_once_with(router_id)"},{"line_number":209,"context_line":"            mock_get_ip_addr.assert_called_once_with(remote_address, networks)"},{"line_number":210,"context_line":"            self.assertEqual(expected, ports)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    def test_get_ports_no_id(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"dae33548_64161b4d","line":209,"range":{"start_line":209,"start_character":0,"end_line":209,"end_character":4},"updated":"2016-02-18 15:24:29.000000000","message":"Please, please try to avoid gratuitous whitespace changes.  This line and the next line shouldn\u0027t need to be changed.","commit_id":"fd0ed209d214c2a4f825eda9dd0b97234f75875a"}]}
