)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"598caff55df99c967376fcae6db521729ea73788","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Assaf Muller \u003camuller@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-02-15 17:06:50 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Delete 220~ API tests from Neutron"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"TESTING.rst explains the criteria. For review purposes only,"},{"line_number":10,"context_line":"I wrote down the list as I see it. Once I get a high level concensus"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dae33548_1338dc9f","line":7,"updated":"2016-02-16 06:03:28.000000000","message":"Please change this to \u0027Propose deletion of ...\u0027\n\nTook me a while to understand what exactly what was going on here","commit_id":"5791d6fe8556debc715f4a54a2e2883966dd77b2"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"598caff55df99c967376fcae6db521729ea73788","unresolved":false,"context_lines":[{"line_number":9,"context_line":"TESTING.rst explains the criteria. For review purposes only,"},{"line_number":10,"context_line":"I wrote down the list as I see it. Once I get a high level concensus"},{"line_number":11,"context_line":"on the broad strokes of the big picture I\u0027ll propose a patchset"},{"line_number":12,"context_line":"that actually deletes the tests from the Neutron tree."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Follow up steps are detailed here:"},{"line_number":15,"context_line":"https://etherpad.openstack.org/p/neutron-tempest-defork"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dae33548_934cec43","line":12,"updated":"2016-02-16 06:03:28.000000000","message":"Do these tests exist in tempest?\n\nWhy remove them? Who runs them?","commit_id":"5791d6fe8556debc715f4a54a2e2883966dd77b2"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"c08390e94b8cb33dc82e0170b7b67b415989d740","unresolved":false,"context_lines":[{"line_number":18,"context_line":"I verified that every test removed here actually exists in that list."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Here\u0027s a list of tests modified after the fork:"},{"line_number":21,"context_line":"https://etherpad.openstack.org/p/neutron-tempest-defork-tempest-tests"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"The list is also maintained in TESTING.rst. After this patch merges"},{"line_number":24,"context_line":"I\u0027ll have to make sure all of those tests are updated in Tempest,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"5aef4532_77752762","line":21,"updated":"2016-03-10 20:35:23.000000000","message":"Wrong link! This is the correct link: https://etherpad.openstack.org/p/neutron-tempest-defork-patches-since-initial-sync, will fix.","commit_id":"73a97505917cf828d81b699ebdf69721af02b228"}],"TESTING.rst":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"96dbe8e4f51dc3e7118b7804440cc503d8ee5153","unresolved":false,"context_lines":[{"line_number":298,"context_line":"* Router"},{"line_number":299,"context_line":"* Floating IP"},{"line_number":300,"context_line":"* Quota"},{"line_number":301,"context_line":"* Agent scheduling"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"This is excluding extensions to these resources (For example: Extra DHCP"},{"line_number":304,"context_line":"options to subnets, or snat_gateway mode to routers) that are either not"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dae33548_68cdf35c","line":301,"updated":"2016-02-16 05:30:29.000000000","message":"will the Neutron team have any kind of oversight on these tests? We want to make sure that tests aren\u0027t added or changed to depend on plugin-specific implementation behavior.","commit_id":"5791d6fe8556debc715f4a54a2e2883966dd77b2"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"5d6f5af9196fe1ea0ef0064cbcca316533bd8580","unresolved":false,"context_lines":[{"line_number":298,"context_line":"* Router"},{"line_number":299,"context_line":"* Floating IP"},{"line_number":300,"context_line":"* Quota"},{"line_number":301,"context_line":"* Agent scheduling"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"This is excluding extensions to these resources (For example: Extra DHCP"},{"line_number":304,"context_line":"options to subnets, or snat_gateway mode to routers) that are either not"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dae33548_0ae891b3","line":301,"in_reply_to":"dae33548_68cdf35c","updated":"2016-02-16 10:34:39.000000000","message":"This is also my concern. Once API tests are removed from Neutron and into Tempest it will be harder to enforce adding API tests along with new features. I think there should some kind of mechanism that makes sure this enforcement is as easy and as clear as possible.","commit_id":"5791d6fe8556debc715f4a54a2e2883966dd77b2"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"dc02e82cd9328a5486f8ad263d59e77161ee6231","unresolved":false,"context_lines":[{"line_number":302,"context_line":""},{"line_number":303,"context_line":"This is excluding extensions to these resources (For example: Extra DHCP"},{"line_number":304,"context_line":"options to subnets, or snat_gateway mode to routers) that are either not"},{"line_number":305,"context_line":"commonly used or are not ubiquitous across Neutron plugins / ML2 drivers."},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"Tests to new resources should be contributed to the Neutron repository. If a"},{"line_number":308,"context_line":"new resource is then regarded as an integral part of Neutron, the tests should"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dae33548_3e1e8e63","line":305,"updated":"2016-02-15 23:04:41.000000000","message":"The criterion is vague, but that does not matter imho as long as there\u0027s an agreement on what goes in tempest and what goes in neutron.\n\nWhile I might not personally agree with splitting API tests in 2 repositories, the proposed division makes sense.","commit_id":"5791d6fe8556debc715f4a54a2e2883966dd77b2"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"96dbe8e4f51dc3e7118b7804440cc503d8ee5153","unresolved":false,"context_lines":[{"line_number":302,"context_line":""},{"line_number":303,"context_line":"This is excluding extensions to these resources (For example: Extra DHCP"},{"line_number":304,"context_line":"options to subnets, or snat_gateway mode to routers) that are either not"},{"line_number":305,"context_line":"commonly used or are not ubiquitous across Neutron plugins / ML2 drivers."},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"Tests to new resources should be contributed to the Neutron repository. If a"},{"line_number":308,"context_line":"new resource is then regarded as an integral part of Neutron, the tests should"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dae33548_c8dcff14","line":305,"updated":"2016-02-16 05:30:29.000000000","message":"agents are not ubiquitious across Neutron plugins either. Also, subnetpools are a core resource now so they should probably be included in the list above.","commit_id":"5791d6fe8556debc715f4a54a2e2883966dd77b2"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"dc02e82cd9328a5486f8ad263d59e77161ee6231","unresolved":false,"context_lines":[{"line_number":304,"context_line":"options to subnets, or snat_gateway mode to routers) that are either not"},{"line_number":305,"context_line":"commonly used or are not ubiquitous across Neutron plugins / ML2 drivers."},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"Tests to new resources should be contributed to the Neutron repository. If a"},{"line_number":308,"context_line":"new resource is then regarded as an integral part of Neutron, the tests should"},{"line_number":309,"context_line":"be contributed to Tempest and subsequently deleted from Neutron."},{"line_number":310,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"dae33548_be20de9c","line":307,"range":{"start_line":307,"start_character":6,"end_line":307,"end_character":8},"updated":"2016-02-15 23:04:41.000000000","message":"shouldn\u0027t it be \"for\"? (just asking don\u0027t bother fixing)","commit_id":"5791d6fe8556debc715f4a54a2e2883966dd77b2"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"598caff55df99c967376fcae6db521729ea73788","unresolved":false,"context_lines":[{"line_number":304,"context_line":"options to subnets, or snat_gateway mode to routers) that are either not"},{"line_number":305,"context_line":"commonly used or are not ubiquitous across Neutron plugins / ML2 drivers."},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"Tests to new resources should be contributed to the Neutron repository. If a"},{"line_number":308,"context_line":"new resource is then regarded as an integral part of Neutron, the tests should"},{"line_number":309,"context_line":"be contributed to Tempest and subsequently deleted from Neutron."},{"line_number":310,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"dae33548_739208a1","line":307,"range":{"start_line":307,"start_character":6,"end_line":307,"end_character":8},"in_reply_to":"dae33548_be20de9c","updated":"2016-02-16 06:03:28.000000000","message":"Yes, this should be \u0027for\u0027","commit_id":"5791d6fe8556debc715f4a54a2e2883966dd77b2"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"a3a8e4e1bbba7d313e43a40a27a6bfb50cca49fb","unresolved":false,"context_lines":[{"line_number":306,"context_line":""},{"line_number":307,"context_line":"Tests to new resources should be contributed to the Neutron repository. If a"},{"line_number":308,"context_line":"new resource is then regarded as an integral part of Neutron, the tests should"},{"line_number":309,"context_line":"be contributed to Tempest and subsequently deleted from Neutron."},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"WIP WIP WIP, this list will NOT be maintained here, but is here only for review purposes."},{"line_number":312,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"dae33548_7562d4ae","line":309,"updated":"2016-02-16 14:34:25.000000000","message":"Is it easy to run the tests in Neutron against external plugin repos?  Is anyone doing that yet?","commit_id":"5791d6fe8556debc715f4a54a2e2883966dd77b2"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"dc02e82cd9328a5486f8ad263d59e77161ee6231","unresolved":false,"context_lines":[{"line_number":331,"context_line":"    admin.test_floating_ips_admin_actions.FloatingIPAdminTestJSON.test_list_floating_ips_from_admin_and_nonadmin"},{"line_number":332,"context_line":"    admin.test_l3_agent_scheduler.L3AgentSchedulerTestJSON.test_add_list_remove_router_on_l3_agent"},{"line_number":333,"context_line":"    admin.test_l3_agent_scheduler.L3AgentSchedulerTestJSON.test_list_routers_on_l3_agent"},{"line_number":334,"context_line":"    admin.test_quotas.QuotasTest.test_quotas"},{"line_number":335,"context_line":"    test_dhcp_ipv6.NetworksTestDHCPv6.test_dhcp_stateful"},{"line_number":336,"context_line":"    test_dhcp_ipv6.NetworksTestDHCPv6.test_dhcp_stateful_fixedips"},{"line_number":337,"context_line":"    test_dhcp_ipv6.NetworksTestDHCPv6.test_dhcp_stateful_fixedips_duplicate"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dae33548_be573e01","line":334,"updated":"2016-02-15 23:04:41.000000000","message":"I was working with Kevin recently and we noted that we pretty much completely lack API tests for quota mgmt btw","commit_id":"5791d6fe8556debc715f4a54a2e2883966dd77b2"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"dc02e82cd9328a5486f8ad263d59e77161ee6231","unresolved":false,"context_lines":[{"line_number":533,"context_line":"    test_security_groups_negative.NegativeSecGroupTest.test_create_security_group_rule_with_remote_ip_and_group"},{"line_number":534,"context_line":"    test_security_groups_negative.NegativeSecGroupTest.test_delete_non_existent_security_group"},{"line_number":535,"context_line":"    test_security_groups_negative.NegativeSecGroupTest.test_show_non_existent_security_group"},{"line_number":536,"context_line":"    test_security_groups_negative.NegativeSecGroupTest.test_show_non_existent_security_group_rule"},{"line_number":537,"context_line":""},{"line_number":538,"context_line":"Tests that should be deleted from Tempest and remain only in Neutron:"},{"line_number":539,"context_line":" ::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dae33548_feaf06e1","line":536,"updated":"2016-02-15 23:04:41.000000000","message":"considering the effort being made around subnetpools/address scopes etc, I\u0027d move the subnetpools in tempest right now.","commit_id":"5791d6fe8556debc715f4a54a2e2883966dd77b2"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"dc02e82cd9328a5486f8ad263d59e77161ee6231","unresolved":false,"context_lines":[{"line_number":552,"context_line":"    test_allowed_address_pair.AllowedAddressPairTestJSON.test_create_list_port_with_address_pair"},{"line_number":553,"context_line":"    test_allowed_address_pair.AllowedAddressPairTestJSON.test_update_port_with_address_pair"},{"line_number":554,"context_line":"    test_allowed_address_pair.AllowedAddressPairTestJSON.test_update_port_with_cidr_address_pair"},{"line_number":555,"context_line":"    test_allowed_address_pair.AllowedAddressPairTestJSON.test_update_port_with_multiple_ip_mac_address_pair"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"    test_metering_extensions.MeteringIpV6TestJSON.test_create_delete_metering_label_rule_with_filters"},{"line_number":558,"context_line":"    test_metering_extensions.MeteringIpV6TestJSON.test_create_delete_metering_label_with_filters"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dae33548_5e79d292","line":555,"updated":"2016-02-15 23:04:41.000000000","message":"I think this extension could actually meet the criterion.\nWhat do you reckon?","commit_id":"5791d6fe8556debc715f4a54a2e2883966dd77b2"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"1748a266918779ca869b580b71bb669915e21134","unresolved":false,"context_lines":[{"line_number":289,"context_line":"was eliminated at a later date, and a criterion formed for inclusion of tests"},{"line_number":290,"context_line":"in to the Tempest repository."},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"API tests that belong to Tempest deal with base Neutron resources:"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"* Port"},{"line_number":295,"context_line":"* Network"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dae33548_086a3eb3","line":292,"range":{"start_line":292,"start_character":33,"end_line":292,"end_character":65},"updated":"2016-02-16 18:09:16.000000000","message":"I think the tempest tests are a *subset* of the base resource tests, from what I\u0027ve heard.","commit_id":"e2600a32e6c77de4a9695a2d74b3c2a0334afdba"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"37330d96f2ee137b23b71360083162ba42719591","unresolved":false,"context_lines":[{"line_number":289,"context_line":"was eliminated at a later date, and a criterion formed for inclusion of tests"},{"line_number":290,"context_line":"in to the Tempest repository."},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"API tests that belong to Tempest deal with base Neutron resources:"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"* Port"},{"line_number":295,"context_line":"* Network"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dae33548_324e8c96","line":292,"range":{"start_line":292,"start_character":33,"end_line":292,"end_character":65},"in_reply_to":"dae33548_086a3eb3","updated":"2016-02-16 20:59:21.000000000","message":"Done","commit_id":"e2600a32e6c77de4a9695a2d74b3c2a0334afdba"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"c0876cf977d4cdd344c269079b7ace09d01a2c65","unresolved":false,"context_lines":[{"line_number":287,"context_line":"neutron/tests/api was copied from the Tempest project. At the time, there was"},{"line_number":288,"context_line":"an overlap of tests between the Tempest and Neutron repositories. This overlap"},{"line_number":289,"context_line":"was eliminated at a later date, and a criterion formed for inclusion of tests"},{"line_number":290,"context_line":"in to the Tempest repository."},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"API tests that belong to Tempest deal with a subset of Neutron\u0027s resources:"},{"line_number":293,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"dae33548_c84f2d69","line":290,"updated":"2016-02-18 19:09:13.000000000","message":"can you reference the criterion here?","commit_id":"6001f70691eab89bf78fe0248554f322ee34842b"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"08ed00efe374ce18c601864289dfc9c62b0d0734","unresolved":false,"context_lines":[{"line_number":287,"context_line":"neutron/tests/api was copied from the Tempest project. At the time, there was"},{"line_number":288,"context_line":"an overlap of tests between the Tempest and Neutron repositories. This overlap"},{"line_number":289,"context_line":"was eliminated at a later date, and a criterion formed for inclusion of tests"},{"line_number":290,"context_line":"in to the Tempest repository."},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"API tests that belong to Tempest deal with a subset of Neutron\u0027s resources:"},{"line_number":293,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"dae33548_e86e71fe","line":290,"in_reply_to":"dae33548_c84f2d69","updated":"2016-02-18 19:26:17.000000000","message":"It\u0027s outlined in the following lines.","commit_id":"6001f70691eab89bf78fe0248554f322ee34842b"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"c0876cf977d4cdd344c269079b7ace09d01a2c65","unresolved":false,"context_lines":[{"line_number":297,"context_line":"* Security group"},{"line_number":298,"context_line":"* Router"},{"line_number":299,"context_line":"* Floating IP"},{"line_number":300,"context_line":"* Quota"},{"line_number":301,"context_line":"* Agent scheduling"},{"line_number":302,"context_line":"* Subnet pools"},{"line_number":303,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"dae33548_4844bd48","line":300,"updated":"2016-02-18 19:09:13.000000000","message":"I\u0027d be tempted to move quota too. iirc your etherpad mentioned of keeping in Tempest a set of basic tests for core resources: ports, networks, subnets, routers, floating ips, secgroups.","commit_id":"6001f70691eab89bf78fe0248554f322ee34842b"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"08ed00efe374ce18c601864289dfc9c62b0d0734","unresolved":false,"context_lines":[{"line_number":297,"context_line":"* Security group"},{"line_number":298,"context_line":"* Router"},{"line_number":299,"context_line":"* Floating IP"},{"line_number":300,"context_line":"* Quota"},{"line_number":301,"context_line":"* Agent scheduling"},{"line_number":302,"context_line":"* Subnet pools"},{"line_number":303,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"dae33548_8880858c","line":300,"in_reply_to":"dae33548_4844bd48","updated":"2016-02-18 19:26:17.000000000","message":"After more thinking I think quotas are universal to Neutron plugins and belong in Tempest itself. No?","commit_id":"6001f70691eab89bf78fe0248554f322ee34842b"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"c0876cf977d4cdd344c269079b7ace09d01a2c65","unresolved":false,"context_lines":[{"line_number":298,"context_line":"* Router"},{"line_number":299,"context_line":"* Floating IP"},{"line_number":300,"context_line":"* Quota"},{"line_number":301,"context_line":"* Agent scheduling"},{"line_number":302,"context_line":"* Subnet pools"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"This is excluding extensions to these resources (For example: Extra DHCP"}],"source_content_type":"text/x-rst","patch_set":4,"id":"dae33548_4d704f0b","line":301,"updated":"2016-02-18 19:09:13.000000000","message":"I actually regarded agent tests (base, dhcp and l3) as something non-tempest related, in the end you may have backends that do not rely on the agent extension at all and they can still provide cloud network services like dhcp, and l3.","commit_id":"6001f70691eab89bf78fe0248554f322ee34842b"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"08ed00efe374ce18c601864289dfc9c62b0d0734","unresolved":false,"context_lines":[{"line_number":298,"context_line":"* Router"},{"line_number":299,"context_line":"* Floating IP"},{"line_number":300,"context_line":"* Quota"},{"line_number":301,"context_line":"* Agent scheduling"},{"line_number":302,"context_line":"* Subnet pools"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"This is excluding extensions to these resources (For example: Extra DHCP"}],"source_content_type":"text/x-rst","patch_set":4,"id":"dae33548_a81d8974","line":301,"in_reply_to":"dae33548_4d704f0b","updated":"2016-02-18 19:26:17.000000000","message":"Ah ha, now we go in to a separate debate: Should the reference implementation given special treatment (Like it does in the Neutron repo: It\u0027s in-repo while everything else is out). Clearly the agent tests are not universal across Neutron plugins, but they\u0027re used by the reference implementation. Should those tests stay in Tempest? That is beyond me.\n\nOne thing I\u0027d like to stress - In the Neutron community, we\u0027re free to delete or add whatever tests we want. We cannot dictate what tests should stay in Tempest, but we can make educated suggestions. Ultimately the Tempest community will decide what stays or goes in Tempest. Right now, I\u0027m (Trying to) concern myself with what stays in Neutron, so the question of: Should agent-scheduling tests remain in Tempest is of less concern to me today, in this patch, but will be more interesting to me tomorrow.","commit_id":"6001f70691eab89bf78fe0248554f322ee34842b"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"a547594af40381e5d78694532f09ab73eaf7af6a","unresolved":false,"context_lines":[{"line_number":306,"context_line":"commonly used or are not ubiquitous across Neutron plugins / ML2 drivers."},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"Tests for new resources should be contributed to the Neutron repository. If a"},{"line_number":309,"context_line":"new resource is then regarded as an integral part of Neutron, the tests should"},{"line_number":310,"context_line":"be contributed to Tempest and subsequently deleted from Neutron."},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"WIP WIP WIP, this list will NOT be maintained here, but is here only for review purposes."}],"source_content_type":"text/x-rst","patch_set":4,"id":"dae33548_1d38743c","line":309,"range":{"start_line":309,"start_character":36,"end_line":309,"end_character":44},"updated":"2016-02-17 22:07:08.000000000","message":"integral? Is it related to neutron core resources/APIs?","commit_id":"6001f70691eab89bf78fe0248554f322ee34842b"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"08ed00efe374ce18c601864289dfc9c62b0d0734","unresolved":false,"context_lines":[{"line_number":306,"context_line":"commonly used or are not ubiquitous across Neutron plugins / ML2 drivers."},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"Tests for new resources should be contributed to the Neutron repository. If a"},{"line_number":309,"context_line":"new resource is then regarded as an integral part of Neutron, the tests should"},{"line_number":310,"context_line":"be contributed to Tempest and subsequently deleted from Neutron."},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"WIP WIP WIP, this list will NOT be maintained here, but is here only for review purposes."}],"source_content_type":"text/x-rst","patch_set":4,"id":"dae33548_fc075615","line":309,"range":{"start_line":309,"start_character":36,"end_line":309,"end_character":44},"in_reply_to":"dae33548_1d38743c","updated":"2016-02-18 19:26:17.000000000","message":"Yes. Any suggestions how to make the phrasing clearer?","commit_id":"6001f70691eab89bf78fe0248554f322ee34842b"},{"author":{"_account_id":18894,"name":"Toni Freger","email":"tfreger@redhat.com"},"change_message_id":"da00b13404db097845ed2f4b1465ebca7c007aed","unresolved":false,"context_lines":[{"line_number":289,"context_line":"was then eliminated by carving out a subset of resources that belong to"},{"line_number":290,"context_line":"Tempest, with the rest in Neutron."},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"API tests that belong to Tempest deal with a subset of Neutron\u0027s resources:"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"* Port"},{"line_number":295,"context_line":"* Network"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bae84128_85ce84b2","line":292,"updated":"2016-02-25 07:47:10.000000000","message":"Should be API and scenario tests. Not just API.","commit_id":"14d803162c9646821b6d27947b94731d8318419e"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56605352901a4f2ba3e7664a7baaa6be1ca11f74","unresolved":false,"context_lines":[{"line_number":289,"context_line":"was then eliminated by carving out a subset of resources that belong to"},{"line_number":290,"context_line":"Tempest, with the rest in Neutron."},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"API tests that belong to Tempest deal with a subset of Neutron\u0027s resources:"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"* Port"},{"line_number":295,"context_line":"* Network"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aed3d3a_d7c057e3","line":292,"in_reply_to":"bae84128_85ce84b2","updated":"2016-02-25 20:42:30.000000000","message":"I think we should consider scenario tests in another pass.","commit_id":"14d803162c9646821b6d27947b94731d8318419e"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"3956b4796aa3c2d144bef4711c2c190188100a00","unresolved":false,"context_lines":[{"line_number":292,"context_line":"was then eliminated by carving out a subset of resources that belong to"},{"line_number":293,"context_line":"Tempest, with the rest in Neutron."},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"API tests that belong to Tempest deal with a subset of Neutron\u0027s resources:"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"* Port"},{"line_number":298,"context_line":"* Network"}],"source_content_type":"text/x-rst","patch_set":9,"id":"7af24918_a502bdb2","line":295,"updated":"2016-03-04 19:42:51.000000000","message":"after discussing this with mtreinish [1], it might be worth emphasizing why we chose these resources over others, and I\u0027d say that those are the resources you can\u0027t live without do to basic instance internetworking/connectivity/security. Sure, more could be added, but this is the bare minimum.\n\n[1] http://eavesdrop.openstack.org/irclogs/%23openstack-neutron/%23openstack-neutron.2016-03-04.log.html#t2016-03-04T19:27:21","commit_id":"73a97505917cf828d81b699ebdf69721af02b228"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"c08390e94b8cb33dc82e0170b7b67b415989d740","unresolved":false,"context_lines":[{"line_number":292,"context_line":"was then eliminated by carving out a subset of resources that belong to"},{"line_number":293,"context_line":"Tempest, with the rest in Neutron."},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"API tests that belong to Tempest deal with a subset of Neutron\u0027s resources:"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"* Port"},{"line_number":298,"context_line":"* Network"}],"source_content_type":"text/x-rst","patch_set":9,"id":"5aef4532_3d389dd2","line":295,"in_reply_to":"7af24918_a502bdb2","updated":"2016-03-10 20:35:23.000000000","message":"Done","commit_id":"73a97505917cf828d81b699ebdf69721af02b228"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"3956b4796aa3c2d144bef4711c2c190188100a00","unresolved":false,"context_lines":[{"line_number":312,"context_line":"Tests that should be synced from Neutron to Tempest, then deleted from Neutron:"},{"line_number":313,"context_line":"::"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    test_floating_ips_admin_actions.FloatingIPAdminTestJSON.test_associate_floating_ip_with_port_from_another_tenant"},{"line_number":316,"context_line":"    test_floating_ips_admin_actions.FloatingIPAdminTestJSON.test_create_floatingip_with_specified_ip_address"},{"line_number":317,"context_line":"    test_floating_ips_negative.FloatingIPNegativeTestJSON.test_associate_floatingip_with_port_with_floatingip"},{"line_number":318,"context_line":"    test_security_groups_negative.NegativeSecGroupTest.test_create_security_group_rule_with_invalid_ports"}],"source_content_type":"text/x-rst","patch_set":9,"id":"7af24918_a5c75d63","line":315,"updated":"2016-03-04 19:42:51.000000000","message":"another point raised was perhaps that this is more etherpad material, but if you want more control over how this gets edited I am ok with leaving this as is assumed it\u0027s gonna go away at some point.","commit_id":"73a97505917cf828d81b699ebdf69721af02b228"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"c08390e94b8cb33dc82e0170b7b67b415989d740","unresolved":false,"context_lines":[{"line_number":312,"context_line":"Tests that should be synced from Neutron to Tempest, then deleted from Neutron:"},{"line_number":313,"context_line":"::"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    test_floating_ips_admin_actions.FloatingIPAdminTestJSON.test_associate_floating_ip_with_port_from_another_tenant"},{"line_number":316,"context_line":"    test_floating_ips_admin_actions.FloatingIPAdminTestJSON.test_create_floatingip_with_specified_ip_address"},{"line_number":317,"context_line":"    test_floating_ips_negative.FloatingIPNegativeTestJSON.test_associate_floatingip_with_port_with_floatingip"},{"line_number":318,"context_line":"    test_security_groups_negative.NegativeSecGroupTest.test_create_security_group_rule_with_invalid_ports"}],"source_content_type":"text/x-rst","patch_set":9,"id":"5aef4532_babb13c3","line":315,"in_reply_to":"7af24918_a5c75d63","updated":"2016-03-10 20:35:23.000000000","message":"Updated and moved to https://etherpad.openstack.org/p/neutron-tempest-defork. I\u0027m not looking for control :)","commit_id":"73a97505917cf828d81b699ebdf69721af02b228"}],"neutron/tests/api/admin/test_external_network_extension.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d1f68f4d776c9b9ddf8a5bf6997b08f768e50242","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        self.subnets.remove(subnet)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"class ExternalNetworksRBACTestJSON(base.BaseAdminNetworkTest):"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027alt\u0027, \u0027admin\u0027]"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_018801c4","side":"PARENT","line":133,"updated":"2016-03-03 21:21:27.000000000","message":"Do we really intend to delete the test? It\u0027s not in tempest right now, and it seems to cover very specific neutron feature (RBAC).","commit_id":"f94ad5abbe9a526036f432c5324884e31f3e65af"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"7bd1ec07baeef1971dca09fc85f3d9a5510e2044","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        self.subnets.remove(subnet)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"class ExternalNetworksRBACTestJSON(base.BaseAdminNetworkTest):"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027alt\u0027, \u0027admin\u0027]"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_da171f43","side":"PARENT","line":133,"in_reply_to":"7af24918_018801c4","updated":"2016-03-03 22:48:08.000000000","message":"This was added after my initial pass, so I ended up deleting it. For the next patchset I checked that every single test that I removed actually exists in Tempest.","commit_id":"f94ad5abbe9a526036f432c5324884e31f3e65af"}],"neutron/tests/api/test_dhcp_ipv6.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"58f767d2bff79880931f117b270e00f1b81c76d4","unresolved":false,"context_lines":[{"line_number":27,"context_line":"class NetworksTestDHCPv6(base.BaseNetworkTest):"},{"line_number":28,"context_line":"    _ip_version \u003d 6"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    \"\"\" Test DHCPv6 specific features using SLAAC, stateless and"},{"line_number":31,"context_line":"    stateful settings for subnets. Also it shall check dual-stack"},{"line_number":32,"context_line":"    functionality (IPv4 + IPv6 together)."},{"line_number":33,"context_line":"    The tests include:"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_5d7029a4","line":30,"updated":"2016-03-03 23:13:49.000000000","message":"This doc is no longer relevant.","commit_id":"a0160b1027a00996372be972862a815634552b09"}],"neutron/tests/api/test_floating_ips_negative.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"58f767d2bff79880931f117b270e00f1b81c76d4","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class FloatingIPNegativeTestJSON(base.BaseNetworkTest):"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    \"\"\""},{"line_number":30,"context_line":"    Test the following negative  operations for floating ips:"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        Create floatingip with a port that is unreachable to external network"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_1d886170","line":29,"updated":"2016-03-03 23:13:49.000000000","message":"No longer relevant. It\u0027s just one test now.","commit_id":"a0160b1027a00996372be972862a815634552b09"}],"neutron/tests/api/test_networks.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"766cd6676117b3019634983915b1229370eb298e","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    Neutron:"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        list tenant\u0027s networks"},{"line_number":31,"context_line":"        show a tenant"},{"line_number":32,"context_line":"        show a tenant network details"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    v2.0 of the Neutron API is assumed."}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_7a824bc9","line":31,"updated":"2016-03-03 23:00:55.000000000","message":"Oops...","commit_id":"a0160b1027a00996372be972862a815634552b09"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7ced7d101c0e7c7e721021a261ffb28dc415d66a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"CONF \u003d config.CONF"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class NetworksTestJSON(base.BaseNetworkTest):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    \"\"\""},{"line_number":27,"context_line":"    Tests the following operations in the Neutron API using the REST client for"}],"source_content_type":"text/x-python","patch_set":9,"id":"7af24918_8b397944","line":24,"updated":"2016-03-06 02:01:12.000000000","message":"we found a race-y test in here:\n\nhttps://review.openstack.org/#/c/288957/","commit_id":"73a97505917cf828d81b699ebdf69721af02b228"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"c08390e94b8cb33dc82e0170b7b67b415989d740","unresolved":false,"context_lines":[{"line_number":21,"context_line":"CONF \u003d config.CONF"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class NetworksTestJSON(base.BaseNetworkTest):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    \"\"\""},{"line_number":27,"context_line":"    Tests the following operations in the Neutron API using the REST client for"}],"source_content_type":"text/x-python","patch_set":9,"id":"5aef4532_5a576f57","line":24,"in_reply_to":"7af24918_8b397944","updated":"2016-03-10 20:35:23.000000000","message":"Done","commit_id":"73a97505917cf828d81b699ebdf69721af02b228"}],"neutron/tests/api/test_routers.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"7bd1ec07baeef1971dca09fc85f3d9a5510e2044","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":83,"context_line":"    @test.idempotent_id(\u0027e54dd3a3-4352-4921-b09d-44369ae17397\u0027)"},{"line_number":84,"context_line":"    def test_create_router_setting_tenant_id(self):"},{"line_number":85,"context_line":"        # Test creating router from admin user setting tenant_id."},{"line_number":86,"context_line":"        test_tenant \u003d data_utils.rand_name(\u0027test_tenant_\u0027)"},{"line_number":87,"context_line":"        test_description \u003d data_utils.rand_name(\u0027desc_\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_f44af253","side":"PARENT","line":84,"updated":"2016-03-03 22:48:08.000000000","message":"This exists in Tempest as test_create_router_setting_project_id (tenant-\u003eproject)","commit_id":"f94ad5abbe9a526036f432c5324884e31f3e65af"}],"neutron/tests/api/test_routers_negative.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"766cd6676117b3019634983915b1229370eb298e","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    _ip_version \u003d 6"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"class DvrRoutersNegativeTest(base.BaseRouterTest):"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    @classmethod"},{"line_number":119,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_1acd0731","side":"PARENT","line":116,"updated":"2016-03-03 23:00:55.000000000","message":"This shouldn\u0027t be removed.","commit_id":"f94ad5abbe9a526036f432c5324884e31f3e65af"}],"neutron/tests/api/test_security_groups_negative.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d1f68f4d776c9b9ddf8a5bf6997b08f768e50242","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        # Create rule for icmp protocol with invalid ports"},{"line_number":150,"context_line":"        states \u003d [(1, 256, \u0027Invalid value for ICMP code\u0027),"},{"line_number":151,"context_line":"                  (-1, 25, \u0027Invalid value\u0027),"},{"line_number":152,"context_line":"                  (None, 6, \u0027ICMP type (port-range-min) is missing\u0027),"},{"line_number":153,"context_line":"                  (300, 1, \u0027Invalid value for ICMP type\u0027)]"},{"line_number":154,"context_line":"        for pmin, pmax, msg in states:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_5cdb121b","side":"PARENT","line":151,"updated":"2016-03-03 21:21:27.000000000","message":"This check is not present in tempest suite.","commit_id":"f94ad5abbe9a526036f432c5324884e31f3e65af"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"7bd1ec07baeef1971dca09fc85f3d9a5510e2044","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        # Create rule for icmp protocol with invalid ports"},{"line_number":150,"context_line":"        states \u003d [(1, 256, \u0027Invalid value for ICMP code\u0027),"},{"line_number":151,"context_line":"                  (-1, 25, \u0027Invalid value\u0027),"},{"line_number":152,"context_line":"                  (None, 6, \u0027ICMP type (port-range-min) is missing\u0027),"},{"line_number":153,"context_line":"                  (300, 1, \u0027Invalid value for ICMP type\u0027)]"},{"line_number":154,"context_line":"        for pmin, pmax, msg in states:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_ba3df3c5","side":"PARENT","line":151,"in_reply_to":"7af24918_5cdb121b","updated":"2016-03-03 22:48:08.000000000","message":"Good catch, I somehow missed it here https://etherpad.openstack.org/p/neutron-tempest-defork-patches-since-initial-sync","commit_id":"f94ad5abbe9a526036f432c5324884e31f3e65af"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"58f767d2bff79880931f117b270e00f1b81c76d4","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"class NegativeSecGroupIPv6Test(NegativeSecGroupTest):"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    _ip_version \u003d 6"},{"line_number":80,"context_line":"    _tenant_network_cidr \u003d CONF.network.tenant_network_v6_cidr"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_7ae7ebab","line":78,"updated":"2016-03-03 23:13:49.000000000","message":"Eek, unneeded whitespace change! *Holds a cross and hisses*","commit_id":"a0160b1027a00996372be972862a815634552b09"}]}