)]}'
{"neutron/db/securitygroups_db.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"4e5c5d36dbd271dd1a67a04397b1d78015a01c44","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            registry.notify(res, event, self, **kwargs)"},{"line_number":131,"context_line":"        except exceptions.CallbackFailure as e:"},{"line_number":132,"context_line":"            if exc_cls:"},{"line_number":133,"context_line":"                reason \u003d _(\u0027cannot perform %(event)s due to %(reason)s\u0027) % {"},{"line_number":134,"context_line":"                           \u0027event\u0027: event, \u0027reason\u0027: e}"},{"line_number":135,"context_line":"                raise exc_cls(reason\u003dreason, id\u003did)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def create_security_group(self, context, security_group, default_sg\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_d18f87ca","line":134,"range":{"start_line":133,"start_character":25,"end_line":134,"end_character":55},"updated":"2016-02-16 09:23:19.000000000","message":"should event and reason be translated as well? Consider:\n _(\u0027cannot perform %(event)s due to %(reason)s\u0027 % {\u0027event\u0027: event, \u0027reason\u0027: e})","commit_id":"d8fda6b7d605a96707c69f32d9a8973f3d487ef7"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"e5d249931ca2017f977ba432dd788a1acd8a7f42","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            registry.notify(res, event, self, **kwargs)"},{"line_number":131,"context_line":"        except exceptions.CallbackFailure as e:"},{"line_number":132,"context_line":"            if exc_cls:"},{"line_number":133,"context_line":"                reason \u003d _(\u0027cannot perform %(event)s due to %(reason)s\u0027) % {"},{"line_number":134,"context_line":"                           \u0027event\u0027: event, \u0027reason\u0027: e}"},{"line_number":135,"context_line":"                raise exc_cls(reason\u003dreason, id\u003did)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def create_security_group(self, context, security_group, default_sg\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_7145db6e","line":134,"range":{"start_line":133,"start_character":25,"end_line":134,"end_character":55},"in_reply_to":"dae33548_d18f87ca","updated":"2016-02-16 09:25:41.000000000","message":"Done","commit_id":"d8fda6b7d605a96707c69f32d9a8973f3d487ef7"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"0644e09a20cc15f377474880ecad89a24764e9ac","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            registry.notify(res, event, self, **kwargs)"},{"line_number":131,"context_line":"        except exceptions.CallbackFailure as e:"},{"line_number":132,"context_line":"            if exc_cls:"},{"line_number":133,"context_line":"                reason \u003d _(\u0027cannot perform %(event)s due to %(reason)s\u0027) % {"},{"line_number":134,"context_line":"                           \u0027event\u0027: event, \u0027reason\u0027: e}"},{"line_number":135,"context_line":"                raise exc_cls(reason\u003dreason, id\u003did)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def create_security_group(self, context, security_group, default_sg\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_32559ec5","line":134,"range":{"start_line":133,"start_character":25,"end_line":134,"end_character":55},"in_reply_to":"dae33548_d18f87ca","updated":"2016-02-18 01:56:41.000000000","message":"I tried but there will be a H702 pep8 error\n\n\n  /opt/stack/neutron$ /opt/stack/neutron/.tox/pep8/bin/flake8 \n./neutron/db/securitygroups_db.py:133:73: H702  Formatting operation should be outside of localization method call\n                reason \u003d _(\u0027cannot perform %(event)s due to %(reason)s\u0027 % {\n                                                                        ^\nERROR: InvocationError: \u0027/opt/stack/neutron/.tox/pep8/bin/flake8\u0027","commit_id":"d8fda6b7d605a96707c69f32d9a8973f3d487ef7"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"07c71f35c4d4db05297f6280075dc091a74aceb9","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            registry.notify(res, event, self, **kwargs)"},{"line_number":131,"context_line":"        except exceptions.CallbackFailure as e:"},{"line_number":132,"context_line":"            if exc_cls:"},{"line_number":133,"context_line":"                reason \u003d (_(\u0027cannot perform %(event)s due to %(reason)s\u0027)) % {"},{"line_number":134,"context_line":"                           \u0027event\u0027: event, \u0027reason\u0027: e}"},{"line_number":135,"context_line":"                raise exc_cls(reason\u003dreason, id\u003did)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def create_security_group(self, context, security_group, default_sg\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_ebf6988d","line":134,"range":{"start_line":133,"start_character":25,"end_line":134,"end_character":55},"updated":"2016-02-18 06:58:24.000000000","message":"You might want just the following.\n\nreason \u003d (_(\u0027cannot perform %(event)s due to %(reason)s\u0027), {\u0027event\u0027: event, \u0027reason\u0027: e})\n\nOR\n\nreason \u003d (_(\u0027cannot perform %(event)s due to %(reason)s\u0027) % {\u0027event\u0027: event, \u0027reason\u0027: e})","commit_id":"7c5220c1b66f0ae44d3074adf199b56068646983"}]}
