)]}'
{"quantum/plugins/__init__.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"e5f6de9471c91e521a9de78f761de5fd97fbd7e0","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import sys"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# only try this if nicira is the configured plugin"},{"line_number":21,"context_line":"# fixes bug 1175750"},{"line_number":22,"context_line":"try:"},{"line_number":23,"context_line":"    from quantum.plugins import nicira"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FldQ%3D","line":21,"updated":"2013-05-02 20:41:41.000000000","message":"this comment shouldn\u0027t be here, please only put this info in the commit message.","commit_id":"e670e856bcc2f793a4db6519223639b84fe9ccf1"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"94b374be4a73ecc57ac49bc10f27dd64a1dafefd","unresolved":false,"context_lines":[{"line_number":27,"context_line":"except ImportError:"},{"line_number":28,"context_line":"    import logging"},{"line_number":29,"context_line":"    LOG \u003d logging.getLogger(__name__)"},{"line_number":30,"context_line":"    LOG.warning(\u0027The Quantum Nicira plugin is not installed.\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Flb4%3D","line":30,"updated":"2013-05-02 20:56:29.000000000","message":"To me this is more of an info level message.  Is there a reason it needs to be a warning?","commit_id":"19e5fc8229a5fa18215600f2d798cadd78ffb90c"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import sys"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# only try this if nicira is the configured plugin"},{"line_number":21,"context_line":"try:"},{"line_number":22,"context_line":"    from quantum.plugins import nicira"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FlKg%3D","line":20,"updated":"2013-05-03 01:45:20.000000000","message":"This is a backwards compatibility shim, so I think we should keep this simple.\n\ntry:\n    from quantum.plugins import nicira\n    sys.modules[\u0027quantum.plugins.nicira.nicira_nvp_plugin\u0027] \u003d nicira\nexcept ImportError:\n    pass","commit_id":"0abe93ebebd8a443890532639de3578ec9d463a5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import sys"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# only try this if nicira is the configured plugin"},{"line_number":21,"context_line":"try:"},{"line_number":22,"context_line":"    from quantum.plugins import nicira"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FlI4%3D","line":20,"in_reply_to":"AAAAOn%2F%2FlKg%3D","updated":"2013-05-03 02:17:48.000000000","message":"Done","commit_id":"0abe93ebebd8a443890532639de3578ec9d463a5"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# only try this if nicira is the configured plugin"},{"line_number":21,"context_line":"try:"},{"line_number":22,"context_line":"    from quantum.plugins import nicira"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    # Provide a mapping for the nicira_nvp_plugin package to ensure"},{"line_number":25,"context_line":"    # backwards compatibility for configuration."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FlP0%3D","line":22,"updated":"2013-05-02 23:11:01.000000000","message":"This is not really being call when nicira plugin is configured, this patch is just catching the exception","commit_id":"0abe93ebebd8a443890532639de3578ec9d463a5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# only try this if nicira is the configured plugin"},{"line_number":21,"context_line":"try:"},{"line_number":22,"context_line":"    from quantum.plugins import nicira"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    # Provide a mapping for the nicira_nvp_plugin package to ensure"},{"line_number":25,"context_line":"    # backwards compatibility for configuration."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FlI0%3D","line":22,"in_reply_to":"AAAAOn%2F%2FlJI%3D","updated":"2013-05-03 02:17:48.000000000","message":"I\u0027ll remove the logging and just pass in the ImportError block.  I will also change the comment so that it points out we are going to catch the exception in case nicira isn\u0027t the configured plugin, but I think it\u0027s useful to comment on why I\u0027m trying to catch an import error (the case being that I don\u0027t have nicira configured as my plugin).","commit_id":"0abe93ebebd8a443890532639de3578ec9d463a5"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# only try this if nicira is the configured plugin"},{"line_number":21,"context_line":"try:"},{"line_number":22,"context_line":"    from quantum.plugins import nicira"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    # Provide a mapping for the nicira_nvp_plugin package to ensure"},{"line_number":25,"context_line":"    # backwards compatibility for configuration."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FlJI%3D","line":22,"in_reply_to":"AAAAOn%2F%2FlOA%3D","updated":"2013-05-03 02:10:51.000000000","message":"Mark\u0027s suggestion is a good idea, and yes the comment is misleading, please remove it.","commit_id":"0abe93ebebd8a443890532639de3578ec9d463a5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# only try this if nicira is the configured plugin"},{"line_number":21,"context_line":"try:"},{"line_number":22,"context_line":"    from quantum.plugins import nicira"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    # Provide a mapping for the nicira_nvp_plugin package to ensure"},{"line_number":25,"context_line":"    # backwards compatibility for configuration."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FlOA%3D","line":22,"in_reply_to":"AAAAOn%2F%2FlP0%3D","updated":"2013-05-02 23:59:46.000000000","message":"Do you mean the comment on line 20 is misleading?  I could see that since I\u0027m not checking any configurations to see if nicira is being used as the quantum plugin, so you\u0027re right, it is just to catch the exception in the case you\u0027re not using the nicira plugin (which was my case, I\u0027m using the openvswitch plugin).\n\nDo you suggest I change the comment or was there something more?","commit_id":"0abe93ebebd8a443890532639de3578ec9d463a5"}]}