)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"855eaaf9aadf94f6b694b7c38e096670226d5578","unresolved":false,"context_lines":[{"line_number":12,"context_line":"previous testcases."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ice2141628adc2d6175c650ff8296bed8a76a6ad5"},{"line_number":15,"context_line":"Closes-bug:#1546422"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bae84128_7c167d56","line":15,"updated":"2016-02-25 06:30:43.000000000","message":"can you explain how it\u0027s related to the bug?","commit_id":"7162182414d2b464a3622bebf6717f5d015f2c00"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"194e44427d0a463b59cd397b1f4b1d57a266cc29","unresolved":false,"context_lines":[{"line_number":12,"context_line":"previous testcases."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ice2141628adc2d6175c650ff8296bed8a76a6ad5"},{"line_number":15,"context_line":"Closes-bug:#1546422"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bae84128_6bb991ec","line":15,"in_reply_to":"bae84128_7c167d56","updated":"2016-02-25 08:35:02.000000000","message":"hi yamamoto, sync_from_callback in networking-odl will reraise the error return from sendjson, but because notify in ./neutron/callbacks/manager.py ingnored this error, CI don\u0027t find it and the tempest test case passed.\n\nI will add it into commit info.","commit_id":"7162182414d2b464a3622bebf6717f5d015f2c00"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"7d66cb1c88f61fab61ae16b65da6815e7d1fb7c2","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, only exception raised for callback registered for BEFORE_ and"},{"line_number":10,"context_line":"PRECOMMIT_ events, but not for AFTER_ event. It will cover some error"},{"line_number":11,"context_line":"inside the AFTER_ callback."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"For example, sync_from_callback in networking-odl will re-raise the error"},{"line_number":14,"context_line":"from HTTP request to ODL. But the exception will not be returned back to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7af24918_0bbb85e6","line":11,"updated":"2016-03-02 08:22:45.000000000","message":"you need to update devref.","commit_id":"d1171fec333ed7b3f5f8c7b9284f3143de17dd9a"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"17f2dbeba82d086582d76566dc911a96001edf9b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, only exception raised for callback registered for BEFORE_ and"},{"line_number":10,"context_line":"PRECOMMIT_ events, but not for AFTER_ event. It will cover some error"},{"line_number":11,"context_line":"inside the AFTER_ callback."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"For example, sync_from_callback in networking-odl will re-raise the error"},{"line_number":14,"context_line":"from HTTP request to ODL. But the exception will not be returned back to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7af24918_45f1636a","line":11,"in_reply_to":"7af24918_0bbb85e6","updated":"2016-03-04 07:06:09.000000000","message":"Done","commit_id":"d1171fec333ed7b3f5f8c7b9284f3143de17dd9a"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"7d66cb1c88f61fab61ae16b65da6815e7d1fb7c2","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"For example, sync_from_callback in networking-odl will re-raise the error"},{"line_number":14,"context_line":"from HTTP request to ODL. But the exception will not be returned back to"},{"line_number":15,"context_line":"user which make tempest testcases passed finally."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ice2141628adc2d6175c650ff8296bed8a76a6ad5"},{"line_number":18,"context_line":"Closes-bug:#1546422"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7af24918_abed31f1","line":15,"updated":"2016-03-02 08:22:45.000000000","message":"have you confirmed the other existing users are ok with this change?","commit_id":"d1171fec333ed7b3f5f8c7b9284f3143de17dd9a"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"17f2dbeba82d086582d76566dc911a96001edf9b","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"For example, sync_from_callback in networking-odl will re-raise the error"},{"line_number":14,"context_line":"from HTTP request to ODL. But the exception will not be returned back to"},{"line_number":15,"context_line":"user which make tempest testcases passed finally."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ice2141628adc2d6175c650ff8296bed8a76a6ad5"},{"line_number":18,"context_line":"Closes-bug:#1546422"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7af24918_004bc959","line":15,"in_reply_to":"7af24918_abed31f1","updated":"2016-03-04 07:06:09.000000000","message":"have not, should I mail to the neutron-dev to get advice?","commit_id":"d1171fec333ed7b3f5f8c7b9284f3143de17dd9a"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"e0fc3abf96e02aa67afab6738a2d3eb1b159089d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, only exception raised for callback registered for BEFORE_ and"},{"line_number":10,"context_line":"PRECOMMIT_ events, but not for AFTER_ event. It will cover some error"},{"line_number":11,"context_line":"inside the AFTER_ callback."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"For example, sync_from_callback in networking-odl will re-raise the error"},{"line_number":14,"context_line":"from HTTP request to ODL. But the exception will not be returned back to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5a18252c_4bf19700","line":11,"updated":"2016-04-14 17:45:39.000000000","message":"this is part of the callback contract. If you need to raise in the AFTER phase, why can\u0027t you in the BEFORE phase?","commit_id":"692cbe566748c382c8ef48d9c0806cacaab53bc8"}],"neutron/tests/unit/agent/l3/test_agent.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"7d66cb1c88f61fab61ae16b65da6815e7d1fb7c2","unresolved":false,"context_lines":[{"line_number":1963,"context_line":"                                                      ext_net_call_failed\u003dTrue)"},{"line_number":1964,"context_line":""},{"line_number":1965,"context_line":"    def _test_process_routers_update_router_deleted(self, error\u003dFalse):"},{"line_number":1966,"context_line":"        with mock.patch.object(pd, \u0027remove_router\u0027) as mock_remove_router:"},{"line_number":1967,"context_line":"            agent \u003d l3_agent.L3NATAgent(HOSTNAME, self.conf)"},{"line_number":1968,"context_line":"            agent._queue \u003d mock.Mock()"},{"line_number":1969,"context_line":"            update \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_2b13e10e","line":1966,"updated":"2016-03-02 08:22:45.000000000","message":"how is this related?","commit_id":"d1171fec333ed7b3f5f8c7b9284f3143de17dd9a"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"17f2dbeba82d086582d76566dc911a96001edf9b","unresolved":false,"context_lines":[{"line_number":1963,"context_line":"                                                      ext_net_call_failed\u003dTrue)"},{"line_number":1964,"context_line":""},{"line_number":1965,"context_line":"    def _test_process_routers_update_router_deleted(self, error\u003dFalse):"},{"line_number":1966,"context_line":"        with mock.patch.object(pd, \u0027remove_router\u0027) as mock_remove_router:"},{"line_number":1967,"context_line":"            agent \u003d l3_agent.L3NATAgent(HOSTNAME, self.conf)"},{"line_number":1968,"context_line":"            agent._queue \u003d mock.Mock()"},{"line_number":1969,"context_line":"            update \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_45ca031c","line":1966,"in_reply_to":"7af24918_2b13e10e","updated":"2016-03-04 07:06:09.000000000","message":"it\u0027s a bug covered, I think it\u0027s another proof that we need stop the interception of the exception.\n\nin this testcase, we just call router_update here (no create), then there is none exist value exception in remove_router of ./neutron/agent/linux/pd.py","commit_id":"d1171fec333ed7b3f5f8c7b9284f3143de17dd9a"}]}
