)]}'
{"neutron/pecan_wsgi/hooks/notifier.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"9f91681af08ad379e914abea3df8a256a91d2d62","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        event \u003d \u0027%s.%s.end\u0027 % (resource_name, action)"},{"line_number":136,"context_line":"        if action \u003d\u003d \u0027delete\u0027:"},{"line_number":137,"context_line":"            if state.response.status_int \u003e 300:"},{"line_number":138,"context_line":"                # don\u0027t notify when unsuccessful"},{"line_number":139,"context_line":"                # NOTE(kevinbenton): we may want to be more strict with the"},{"line_number":140,"context_line":"                # response codes"},{"line_number":141,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_c600eb68","line":138,"updated":"2016-02-18 07:27:12.000000000","message":"only for delete? what if create or update fail?","commit_id":"5999a4c71509fb60ca2ad819e1b0e38f98efb64e"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"9f91681af08ad379e914abea3df8a256a91d2d62","unresolved":false,"context_lines":[{"line_number":143,"context_line":"            payload \u003d {resource_name + \u0027_id\u0027: resource_id}"},{"line_number":144,"context_line":"        elif action in (\u0027create\u0027, \u0027update\u0027):"},{"line_number":145,"context_line":"            if not resources:"},{"line_number":146,"context_line":"                # create/update did not complete so no notification"},{"line_number":147,"context_line":"                return"},{"line_number":148,"context_line":"            if len(resources) \u003e 1:"},{"line_number":149,"context_line":"                payload \u003d {collection_name: resources}"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_c60e2b8b","line":146,"updated":"2016-02-18 07:27:12.000000000","message":"oh this would catch if it failed, verify if i\u0027m wrong","commit_id":"5999a4c71509fb60ca2ad819e1b0e38f98efb64e"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"953f3ef503327fa9e1785cf311e235af42c40319","unresolved":false,"context_lines":[{"line_number":143,"context_line":"            payload \u003d {resource_name + \u0027_id\u0027: resource_id}"},{"line_number":144,"context_line":"        elif action in (\u0027create\u0027, \u0027update\u0027):"},{"line_number":145,"context_line":"            if not resources:"},{"line_number":146,"context_line":"                # create/update did not complete so no notification"},{"line_number":147,"context_line":"                return"},{"line_number":148,"context_line":"            if len(resources) \u003e 1:"},{"line_number":149,"context_line":"                payload \u003d {collection_name: resources}"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_9d3d8d2d","line":146,"updated":"2016-02-18 09:30:26.000000000","message":"yep, this will catch any create/update failures","commit_id":"5999a4c71509fb60ca2ad819e1b0e38f98efb64e"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"89430efe86557c3da4a981a9ff0a451c22d0d7e2","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            # than the population of the object ID being operated on"},{"line_number":73,"context_line":"            payload \u003d state.request.json.copy()"},{"line_number":74,"context_line":"            if action \u003d\u003d \u0027update\u0027:"},{"line_number":75,"context_line":"                payload[\u0027id\u0027] \u003d state.request.context.get(\u0027resource_id\u0027)"},{"line_number":76,"context_line":"        elif action \u003d\u003d \u0027delete\u0027:"},{"line_number":77,"context_line":"            resource_id \u003d state.request.context.get(\u0027resource_id\u0027)"},{"line_number":78,"context_line":"            payload \u003d {resource + \u0027_id\u0027: resource_id}"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_98255bc4","line":75,"updated":"2016-02-19 14:10:41.000000000","message":"I was under the impression that the resource name was in the payload sent to the notifier.\n\ne.g.: {\u0027network\u0027: {\u0027name\u0027: \u0027meh\u0027, \u0027id\u0027: \u0027evenmoremeh\u0027}}","commit_id":"22021fba96bd913ab05e2f8c41825b386bc7591c"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"132b1d6ebb69754ecc325cc7809da1e4b9944678","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            # than the population of the object ID being operated on"},{"line_number":73,"context_line":"            payload \u003d state.request.json.copy()"},{"line_number":74,"context_line":"            if action \u003d\u003d \u0027update\u0027:"},{"line_number":75,"context_line":"                payload[\u0027id\u0027] \u003d state.request.context.get(\u0027resource_id\u0027)"},{"line_number":76,"context_line":"        elif action \u003d\u003d \u0027delete\u0027:"},{"line_number":77,"context_line":"            resource_id \u003d state.request.context.get(\u0027resource_id\u0027)"},{"line_number":78,"context_line":"            payload \u003d {resource + \u0027_id\u0027: resource_id}"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_c8fd91b2","line":75,"updated":"2016-03-01 09:55:00.000000000","message":"that only seems to be the case on \u0027.end\u0027. The start just seems to be the passed in bodies.\n\nhttps://github.com/openstack/neutron/blob/b9ef98b4f7f56c0be3007cbc735bec7f87576c5a/neutron/api/v2/base.py#L406-L409\n\nhttps://github.com/openstack/neutron/blob/b9ef98b4f7f56c0be3007cbc735bec7f87576c5a/neutron/api/v2/base.py#L576-L579\n\nhttps://github.com/openstack/neutron/blob/b9ef98b4f7f56c0be3007cbc735bec7f87576c5a/neutron/api/v2/base.py#L529-L532","commit_id":"22021fba96bd913ab05e2f8c41825b386bc7591c"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"132b1d6ebb69754ecc325cc7809da1e4b9944678","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        if action \u003d\u003d \u0027delete\u0027:"},{"line_number":137,"context_line":"            if state.response.status_int \u003e 300:"},{"line_number":138,"context_line":"                # don\u0027t notify when unsuccessful"},{"line_number":139,"context_line":"                # NOTE(kevinbenton): we may want to be more strict with the"},{"line_number":140,"context_line":"                # response codes"},{"line_number":141,"context_line":"                return"},{"line_number":142,"context_line":"            resource_id \u003d state.request.context.get(\u0027resource_id\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_282fdd3f","line":139,"updated":"2016-03-01 09:55:00.000000000","message":"This still seemed to be called in the delete case. I was sort of surprised by this as well...\n\nIf you remove this, test_bad_delete_doesnt_emit_end will fail.","commit_id":"22021fba96bd913ab05e2f8c41825b386bc7591c"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"89430efe86557c3da4a981a9ff0a451c22d0d7e2","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        if action \u003d\u003d \u0027delete\u0027:"},{"line_number":137,"context_line":"            if state.response.status_int \u003e 300:"},{"line_number":138,"context_line":"                # don\u0027t notify when unsuccessful"},{"line_number":139,"context_line":"                # NOTE(kevinbenton): we may want to be more strict with the"},{"line_number":140,"context_line":"                # response codes"},{"line_number":141,"context_line":"                return"},{"line_number":142,"context_line":"            resource_id \u003d state.request.context.get(\u0027resource_id\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_5babcd89","line":139,"updated":"2016-02-19 14:10:41.000000000","message":"what do you reckon of my comment at line 83?\nI was thinking that in any failure case the plugin would raise.\n\nIn that case the after hook is not executed at all, from what I gathered.","commit_id":"22021fba96bd913ab05e2f8c41825b386bc7591c"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"bd423ca333f0738c6b2fe8023eecd044d1508922","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from neutron.api.rpc.agentnotifiers import dhcp_rpc_agent_api"},{"line_number":22,"context_line":"from neutron.common import constants"},{"line_number":23,"context_line":"from neutron.common import rpc as n_rpc"},{"line_number":24,"context_line":"from neutron import manager"},{"line_number":25,"context_line":"from neutron.pecan_wsgi import constants as pecan_constants"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_b0fe6269","line":23,"updated":"2016-03-07 18:31:26.000000000","message":"why aliasing to n_rpc?\na copy/paste thing?","commit_id":"cabc492b27632f4cd701e8a10997189be0c4e649"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"64a8c51acd59caa6fed21ba3bb4ff1260182ba73","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from neutron.api.rpc.agentnotifiers import dhcp_rpc_agent_api"},{"line_number":22,"context_line":"from neutron.common import constants"},{"line_number":23,"context_line":"from neutron.common import rpc as n_rpc"},{"line_number":24,"context_line":"from neutron import manager"},{"line_number":25,"context_line":"from neutron.pecan_wsgi import constants as pecan_constants"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_27648ce2","line":23,"updated":"2016-03-09 00:49:48.000000000","message":"yea","commit_id":"cabc492b27632f4cd701e8a10997189be0c4e649"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"64a8c51acd59caa6fed21ba3bb4ff1260182ba73","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            LOG.debug(\"Sending DHCP agent notification for: %s\", item)"},{"line_number":61,"context_line":"            dhcp_agent_notifier.notify(context, item, notifier_method)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def before(self, state):"},{"line_number":64,"context_line":"        if state.request.method not in (\u0027POST\u0027, \u0027PUT\u0027, \u0027DELETE\u0027):"},{"line_number":65,"context_line":"            return"},{"line_number":66,"context_line":"        resource \u003d state.request.context.get(\u0027resource\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_075fd00e","line":63,"updated":"2016-03-09 00:49:48.000000000","message":"Aren\u0027t the hooks already processed in a stack fashion like that?\n\nFeel free to update it if you have time.","commit_id":"cabc492b27632f4cd701e8a10997189be0c4e649"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"ddd4064f3612e66845029087036ce4fdc96f65fd","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            LOG.debug(\"Sending DHCP agent notification for: %s\", item)"},{"line_number":61,"context_line":"            dhcp_agent_notifier.notify(context, item, notifier_method)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def before(self, state):"},{"line_number":64,"context_line":"        if state.request.method not in (\u0027POST\u0027, \u0027PUT\u0027, \u0027DELETE\u0027):"},{"line_number":65,"context_line":"            return"},{"line_number":66,"context_line":"        resource \u003d state.request.context.get(\u0027resource\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_0f944789","line":63,"updated":"2016-03-07 22:03:39.000000000","message":"I did unfortunately shift the priorities in the DHCP notification patch....\nand the consequence here is that this notification will also be sent to requests which will then not be authorized.\n\nwith your permission, I\u0027d gladly take care of this.\nI think I will stage the notification hooks - doing the before part after policy enforcement and the after part before the policy enforcement hook.","commit_id":"cabc492b27632f4cd701e8a10997189be0c4e649"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"2be3fe6f68b478c2224e6b219e55d3ec993495d8","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            LOG.debug(\"Sending DHCP agent notification for: %s\", item)"},{"line_number":61,"context_line":"            dhcp_agent_notifier.notify(context, item, notifier_method)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def before(self, state):"},{"line_number":64,"context_line":"        if state.request.method not in (\u0027POST\u0027, \u0027PUT\u0027, \u0027DELETE\u0027):"},{"line_number":65,"context_line":"            return"},{"line_number":66,"context_line":"        resource \u003d state.request.context.get(\u0027resource\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_8959535d","line":63,"in_reply_to":"5aef4532_0f944789","updated":"2016-03-08 14:23:17.000000000","message":"I found out that also the old framework sends notifications for requests which are then not authorized... I\u0027d like to fix that however","commit_id":"cabc492b27632f4cd701e8a10997189be0c4e649"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"64a8c51acd59caa6fed21ba3bb4ff1260182ba73","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            # than the population of the object ID being operated on"},{"line_number":74,"context_line":"            payload \u003d state.request.json.copy()"},{"line_number":75,"context_line":"            if action \u003d\u003d \u0027update\u0027:"},{"line_number":76,"context_line":"                payload[\u0027id\u0027] \u003d state.request.context.get(\u0027resource_id\u0027)"},{"line_number":77,"context_line":"        elif action \u003d\u003d \u0027delete\u0027:"},{"line_number":78,"context_line":"            resource_id \u003d state.request.context.get(\u0027resource_id\u0027)"},{"line_number":79,"context_line":"            payload \u003d {resource + \u0027_id\u0027: resource_id}"}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_679cd4c0","line":76,"updated":"2016-03-09 00:49:48.000000000","message":"Yeah, this code as realized how unreliable our current notifications are :)","commit_id":"cabc492b27632f4cd701e8a10997189be0c4e649"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"bd423ca333f0738c6b2fe8023eecd044d1508922","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            # than the population of the object ID being operated on"},{"line_number":74,"context_line":"            payload \u003d state.request.json.copy()"},{"line_number":75,"context_line":"            if action \u003d\u003d \u0027update\u0027:"},{"line_number":76,"context_line":"                payload[\u0027id\u0027] \u003d state.request.context.get(\u0027resource_id\u0027)"},{"line_number":77,"context_line":"        elif action \u003d\u003d \u0027delete\u0027:"},{"line_number":78,"context_line":"            resource_id \u003d state.request.context.get(\u0027resource_id\u0027)"},{"line_number":79,"context_line":"            payload \u003d {resource + \u0027_id\u0027: resource_id}"}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_70c7ba12","line":76,"updated":"2016-03-07 18:31:26.000000000","message":"todo - for me and you... check if this will trigger .start notification also for non-existent resources (ie: stuff that ends up in a 404). I don\u0027t think the current wsgi framework sends them, and neither the pecan one should","commit_id":"cabc492b27632f4cd701e8a10997189be0c4e649"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"2be3fe6f68b478c2224e6b219e55d3ec993495d8","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            # than the population of the object ID being operated on"},{"line_number":74,"context_line":"            payload \u003d state.request.json.copy()"},{"line_number":75,"context_line":"            if action \u003d\u003d \u0027update\u0027:"},{"line_number":76,"context_line":"                payload[\u0027id\u0027] \u003d state.request.context.get(\u0027resource_id\u0027)"},{"line_number":77,"context_line":"        elif action \u003d\u003d \u0027delete\u0027:"},{"line_number":78,"context_line":"            resource_id \u003d state.request.context.get(\u0027resource_id\u0027)"},{"line_number":79,"context_line":"            payload \u003d {resource + \u0027_id\u0027: resource_id}"}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_096ee300","line":76,"in_reply_to":"5aef4532_70c7ba12","updated":"2016-03-08 14:23:17.000000000","message":"Oh the current framework sends the notification no matter what","commit_id":"cabc492b27632f4cd701e8a10997189be0c4e649"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"64a8c51acd59caa6fed21ba3bb4ff1260182ba73","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        event \u003d \u0027%s.%s.end\u0027 % (resource_name, action)"},{"line_number":139,"context_line":"        if action \u003d\u003d \u0027delete\u0027:"},{"line_number":140,"context_line":"            if state.response.status_int \u003e 300:"},{"line_number":141,"context_line":"                # don\u0027t notify when unsuccessful"},{"line_number":142,"context_line":"                # NOTE(kevinbenton): we may want to be more strict with the"},{"line_number":143,"context_line":"                # response codes"}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_479f18b4","line":140,"updated":"2016-03-09 00:49:48.000000000","message":"Off by one error!","commit_id":"cabc492b27632f4cd701e8a10997189be0c4e649"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"bd423ca333f0738c6b2fe8023eecd044d1508922","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        event \u003d \u0027%s.%s.end\u0027 % (resource_name, action)"},{"line_number":139,"context_line":"        if action \u003d\u003d \u0027delete\u0027:"},{"line_number":140,"context_line":"            if state.response.status_int \u003e 300:"},{"line_number":141,"context_line":"                # don\u0027t notify when unsuccessful"},{"line_number":142,"context_line":"                # NOTE(kevinbenton): we may want to be more strict with the"},{"line_number":143,"context_line":"                # response codes"}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_90ed268e","line":140,"updated":"2016-03-07 18:31:26.000000000","message":"shall we consider 300 successful?","commit_id":"cabc492b27632f4cd701e8a10997189be0c4e649"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"64a8c51acd59caa6fed21ba3bb4ff1260182ba73","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            if state.response.status_int \u003e 300:"},{"line_number":141,"context_line":"                # don\u0027t notify when unsuccessful"},{"line_number":142,"context_line":"                # NOTE(kevinbenton): we may want to be more strict with the"},{"line_number":143,"context_line":"                # response codes"},{"line_number":144,"context_line":"                return"},{"line_number":145,"context_line":"            resource_id \u003d state.request.context.get(\u0027resource_id\u0027)"},{"line_number":146,"context_line":"            payload \u003d {resource_name + \u0027_id\u0027: resource_id}"}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_a7a6dc0d","line":143,"updated":"2016-03-09 00:49:48.000000000","message":"I don\u0027t know. I was being vague and non-committal for a reason :)","commit_id":"cabc492b27632f4cd701e8a10997189be0c4e649"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"bd423ca333f0738c6b2fe8023eecd044d1508922","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            if state.response.status_int \u003e 300:"},{"line_number":141,"context_line":"                # don\u0027t notify when unsuccessful"},{"line_number":142,"context_line":"                # NOTE(kevinbenton): we may want to be more strict with the"},{"line_number":143,"context_line":"                # response codes"},{"line_number":144,"context_line":"                return"},{"line_number":145,"context_line":"            resource_id \u003d state.request.context.get(\u0027resource_id\u0027)"},{"line_number":146,"context_line":"            payload \u003d {resource_name + \u0027_id\u0027: resource_id}"}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_109116f1","line":143,"updated":"2016-03-07 18:31:26.000000000","message":"what kind of strictness would you like to enforce?","commit_id":"cabc492b27632f4cd701e8a10997189be0c4e649"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"d82999db3647039e7ab56d9e33dda5428159d5c3","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        event \u003d \u0027%s.%s.end\u0027 % (resource_name, action)"},{"line_number":139,"context_line":"        if action \u003d\u003d \u0027delete\u0027:"},{"line_number":140,"context_line":"            if state.response.status_int \u003e 300:"},{"line_number":141,"context_line":"                # don\u0027t notify when unsuccessful"},{"line_number":142,"context_line":"                # NOTE(kevinbenton): we may want to be more strict with the"},{"line_number":143,"context_line":"                # response codes"}],"source_content_type":"text/x-python","patch_set":10,"id":"3afc51ec_600ec335","line":140,"range":{"start_line":140,"start_character":41,"end_line":140,"end_character":47},"updated":"2016-03-12 05:11:37.000000000","message":"any reason this wasn\u0027t addressed in a previous comment?","commit_id":"e433c2870a2a5a0ec18ae0ffe4d4866915da231a"}],"neutron/pecan_wsgi/hooks/translation.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"89430efe86557c3da4a981a9ff0a451c22d0d7e2","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        # leaked unexpected exception, convert to boring old 500 error and"},{"line_number":37,"context_line":"        # hide message from user in case it contained sensitive details"},{"line_number":38,"context_line":"        LOG.exception(_LE(\"An unexpected exception was caught: %s\"), e)"},{"line_number":39,"context_line":"        return webob.exc.HTTPInternalServerError("},{"line_number":40,"context_line":"            _(\"An unexpected internal error occurred.\"))"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_bbb6593b","line":39,"updated":"2016-02-19 14:10:41.000000000","message":"by any chance, was this also the reason for which tracebacks were being returned in the API response body in case of errors?","commit_id":"22021fba96bd913ab05e2f8c41825b386bc7591c"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"132b1d6ebb69754ecc325cc7809da1e4b9944678","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        # leaked unexpected exception, convert to boring old 500 error and"},{"line_number":37,"context_line":"        # hide message from user in case it contained sensitive details"},{"line_number":38,"context_line":"        LOG.exception(_LE(\"An unexpected exception was caught: %s\"), e)"},{"line_number":39,"context_line":"        return webob.exc.HTTPInternalServerError("},{"line_number":40,"context_line":"            _(\"An unexpected internal error occurred.\"))"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_e80215b3","line":39,"updated":"2016-03-01 09:55:00.000000000","message":"yes","commit_id":"22021fba96bd913ab05e2f8c41825b386bc7591c"}],"neutron/tests/functional/pecan_wsgi/test_hooks.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"9f91681af08ad379e914abea3df8a256a91d2d62","unresolved":false,"context_lines":[{"line_number":329,"context_line":"    def setUp(self):"},{"line_number":330,"context_line":"        patcher \u003d mock.patch(\u0027neutron.pecan_wsgi.hooks.notifier.NotifierHook.\u0027"},{"line_number":331,"context_line":"                             \u0027_notifier\u0027)"},{"line_number":332,"context_line":"        self.mock_notifier \u003d patcher.start().info"},{"line_number":333,"context_line":"        super(TestMetricsNotifierHook, self).setUp()"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"    def test_post_put_delete_triggers_notification(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_a698471d","line":332,"updated":"2016-02-18 07:27:12.000000000","message":"same comments as prior patch about needing to call patcher.stop()","commit_id":"5999a4c71509fb60ca2ad819e1b0e38f98efb64e"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"953f3ef503327fa9e1785cf311e235af42c40319","unresolved":false,"context_lines":[{"line_number":329,"context_line":"    def setUp(self):"},{"line_number":330,"context_line":"        patcher \u003d mock.patch(\u0027neutron.pecan_wsgi.hooks.notifier.NotifierHook.\u0027"},{"line_number":331,"context_line":"                             \u0027_notifier\u0027)"},{"line_number":332,"context_line":"        self.mock_notifier \u003d patcher.start().info"},{"line_number":333,"context_line":"        super(TestMetricsNotifierHook, self).setUp()"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"    def test_post_put_delete_triggers_notification(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_bd4211ac","line":332,"updated":"2016-02-18 09:30:26.000000000","message":"same rebuttal :)\n\nhttps://github.com/openstack/neutron/blob/1d0aadb6fcf40048e899df6688bda98744c2a999/neutron/tests/base.py#L150","commit_id":"5999a4c71509fb60ca2ad819e1b0e38f98efb64e"}]}
