)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"unresolved":false,"context_lines":[{"line_number":7,"context_line":"Make the metadata namespace proxy transparent"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Refactor the namespace proxy to make it transparent for all http requests"},{"line_number":10,"context_line":"and responses that pass throw, so that they are forwarded as there were made"},{"line_number":11,"context_line":"by their original source, which will allow us to support any upcoming changes"},{"line_number":12,"context_line":"in the metadata service with minimal changes from the quantum part."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"AAAATn%2F9oFM%3D","line":10,"updated":"2013-12-09 15:40:00.000000000","message":"I think this is probably what you mean:\n\ns/throw/through/\ns/as there/as if they/","commit_id":"1c0b9a2daa68bf76a30ea7c759080d459537dd47"},{"author":{"_account_id":7073,"name":"mouad benchchaoui","email":"m.benchchaoui@x-ion.de","username":"mouad"},"change_message_id":"923c6c68b7aad0a567349005bfc7e654171169ad","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Make the metadata namespace proxy transparent"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Refactor the namespace proxy to make it transparent for all http requests"},{"line_number":10,"context_line":"and responses that pass throw, so that they are forwarded as there were made"},{"line_number":11,"context_line":"by their original source, which will allow us to support any upcoming changes"},{"line_number":12,"context_line":"in the metadata service with minimal changes from the quantum part."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"AAAATn%2F9ilk%3D","line":10,"in_reply_to":"AAAATn%2F9oFM%3D","updated":"2013-12-10 14:24:40.000000000","message":"Done","commit_id":"1c0b9a2daa68bf76a30ea7c759080d459537dd47"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Refactor the namespace proxy to make it transparent for all http requests"},{"line_number":10,"context_line":"and responses that pass throw, so that they are forwarded as there were made"},{"line_number":11,"context_line":"by their original source, which will allow us to support any upcoming changes"},{"line_number":12,"context_line":"in the metadata service with minimal changes from the quantum part."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: LP#1175955"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"AAAATn%2F9oE8%3D","line":11,"updated":"2013-12-09 15:40:00.000000000","message":"New sentence after source.  (e.g. ... original source.  This will allow...)","commit_id":"1c0b9a2daa68bf76a30ea7c759080d459537dd47"},{"author":{"_account_id":7073,"name":"mouad benchchaoui","email":"m.benchchaoui@x-ion.de","username":"mouad"},"change_message_id":"923c6c68b7aad0a567349005bfc7e654171169ad","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Refactor the namespace proxy to make it transparent for all http requests"},{"line_number":10,"context_line":"and responses that pass throw, so that they are forwarded as there were made"},{"line_number":11,"context_line":"by their original source, which will allow us to support any upcoming changes"},{"line_number":12,"context_line":"in the metadata service with minimal changes from the quantum part."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: LP#1175955"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"AAAATn%2F9ils%3D","line":11,"in_reply_to":"AAAATn%2F9oE8%3D","updated":"2013-12-10 14:24:40.000000000","message":"Done","commit_id":"1c0b9a2daa68bf76a30ea7c759080d459537dd47"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"unresolved":false,"context_lines":[{"line_number":11,"context_line":"by their original source. This will allow us to support any upcoming changes"},{"line_number":12,"context_line":"in the metadata service with minimal changes from the Neutron part."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: LP#1175954"},{"line_number":15,"context_line":"Change-Id: Iedf3ebb86e342bd8699fca45fc2a934d2ea31730"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"AAAATn%2F8seA%3D","line":14,"updated":"2013-12-23 03:51:12.000000000","message":"why it is not the link ?  pls refer the following link to check, thus we can obtain more background to better review this patch.\nhttps://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"b0a006116419623f12a5e92f3db0f2dbdb11e814"}],"neutron/agent/metadata/agent.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"unresolved":false,"context_lines":[{"line_number":146,"context_line":"        http \u003d httplib2.Http()"},{"line_number":147,"context_line":"        try:"},{"line_number":148,"context_line":"            resp, body \u003d http.request("},{"line_number":149,"context_line":"                url, method\u003dreq.method, body\u003dreq.body, headers\u003dheaders)"},{"line_number":150,"context_line":"        except socket.error as ex:"},{"line_number":151,"context_line":"            msg \u003d _(\u0027Connection to metadata api failed: %s\u0027) % ex"},{"line_number":152,"context_line":"            LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F9oBs%3D","line":149,"updated":"2013-12-09 15:40:00.000000000","message":"We lose logging here of the customized log messages.  For example, the hint that a 403 is normally received when shared secrets do not match seems like it might be useful.  Could we keep the specialized logging while still achieving your goal?  Do you think it is worth it?","commit_id":"1c0b9a2daa68bf76a30ea7c759080d459537dd47"},{"author":{"_account_id":7073,"name":"mouad benchchaoui","email":"m.benchchaoui@x-ion.de","username":"mouad"},"change_message_id":"923c6c68b7aad0a567349005bfc7e654171169ad","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        http \u003d httplib2.Http()"},{"line_number":147,"context_line":"        try:"},{"line_number":148,"context_line":"            resp, body \u003d http.request("},{"line_number":149,"context_line":"                url, method\u003dreq.method, body\u003dreq.body, headers\u003dheaders)"},{"line_number":150,"context_line":"        except socket.error as ex:"},{"line_number":151,"context_line":"            msg \u003d _(\u0027Connection to metadata api failed: %s\u0027) % ex"},{"line_number":152,"context_line":"            LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F8%2FqA%3D","line":149,"in_reply_to":"AAAATn%2F9b0E%3D","updated":"2013-12-17 22:31:37.000000000","message":"I may have been thinking about this the wrong way, if the metadata-agent is the one signing request so it probably in his right (thinking about the developer) to know wether metadata-api accept his request and if not why it didn\u0027t. So i will put back the log for http forbidden case.","commit_id":"1c0b9a2daa68bf76a30ea7c759080d459537dd47"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"unresolved":false,"context_lines":[{"line_number":146,"context_line":"        http \u003d httplib2.Http()"},{"line_number":147,"context_line":"        try:"},{"line_number":148,"context_line":"            resp, body \u003d http.request("},{"line_number":149,"context_line":"                url, method\u003dreq.method, body\u003dreq.body, headers\u003dheaders)"},{"line_number":150,"context_line":"        except socket.error as ex:"},{"line_number":151,"context_line":"            msg \u003d _(\u0027Connection to metadata api failed: %s\u0027) % ex"},{"line_number":152,"context_line":"            LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F9b0E%3D","line":149,"in_reply_to":"AAAATn%2F9iMY%3D","updated":"2013-12-11 15:06:11.000000000","message":"You may have a point.  The wording leaves something to be desired.  Developer insight can be valuable in some situations.  The bigger question is whether it is valuable to log errors at this point even if it is something more generic.  Do we lose a valuable debugging and triage tool here?","commit_id":"1c0b9a2daa68bf76a30ea7c759080d459537dd47"},{"author":{"_account_id":7073,"name":"mouad benchchaoui","email":"m.benchchaoui@x-ion.de","username":"mouad"},"change_message_id":"923c6c68b7aad0a567349005bfc7e654171169ad","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        http \u003d httplib2.Http()"},{"line_number":147,"context_line":"        try:"},{"line_number":148,"context_line":"            resp, body \u003d http.request("},{"line_number":149,"context_line":"                url, method\u003dreq.method, body\u003dreq.body, headers\u003dheaders)"},{"line_number":150,"context_line":"        except socket.error as ex:"},{"line_number":151,"context_line":"            msg \u003d _(\u0027Connection to metadata api failed: %s\u0027) % ex"},{"line_number":152,"context_line":"            LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F9iMY%3D","line":149,"in_reply_to":"AAAATn%2F9oBs%3D","updated":"2013-12-10 14:24:40.000000000","message":"One thing that i didn\u0027t like about this log is when it\u0027s say \"This response usually occurs ...\", mark the word \"usually\", because how can the metadata agent know why nova metadata api return 403 ? Of course he can\u0027t but the developer that wrote this **at that time** knew why nova metadata is returning 403 b/c at that time it was shared secrets not matching, but how about future change that support new authentication ways (just thinking out loud here :)) ? How can we not forget to change it ?\n\nDoes this make sense to you ? If not i am very happy to be persuaded otherwise.","commit_id":"1c0b9a2daa68bf76a30ea7c759080d459537dd47"}],"neutron/agent/metadata/namespace_proxy.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9164ea02e780a2345225e5e168903df7e63c561c","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    \"\"\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def __init__(self, network_id\u003dNone, router_id\u003dNone):"},{"line_number":59,"context_line":"        self.proxy_headers \u003d {}"},{"line_number":60,"context_line":"        if router_id:"},{"line_number":61,"context_line":"            self.proxy_headers[\u0027X-Neutron-Router-ID\u0027] \u003d router_id"},{"line_number":62,"context_line":"        elif network_id:"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F%2BWB8%3D","line":59,"updated":"2013-12-05 09:23:06.000000000","message":"There is no benefit of creating a dictionary here which is then cloned on each request.  This should remain in its previous place.","commit_id":"1c0b9a2daa68bf76a30ea7c759080d459537dd47"},{"author":{"_account_id":7073,"name":"mouad benchchaoui","email":"m.benchchaoui@x-ion.de","username":"mouad"},"change_message_id":"923c6c68b7aad0a567349005bfc7e654171169ad","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    \"\"\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def __init__(self, network_id\u003dNone, router_id\u003dNone):"},{"line_number":59,"context_line":"        self.proxy_headers \u003d {}"},{"line_number":60,"context_line":"        if router_id:"},{"line_number":61,"context_line":"            self.proxy_headers[\u0027X-Neutron-Router-ID\u0027] \u003d router_id"},{"line_number":62,"context_line":"        elif network_id:"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F92NE%3D","line":59,"in_reply_to":"AAAATn%2F%2BWB8%3D","updated":"2013-12-05 11:21:18.000000000","message":"The benefit is readability, doesn\u0027t this approach seem more readable for you ? For me it does b/c of this two reasons:\n\n1- IMHO doing the same \"if else\" that yield the same result each time _proxy_request is called !! that this sound reasonable to you ? For me it doesn\u0027t. \n\n2- In term of OOO don\u0027t you think that the headers that the proxy append to the original headers should be in fact an instance variable of the ProxyHandler ? \n\nBut i don\u0027t mind changing it if this required to get this patch accepted.\n\nThoughts ?","commit_id":"1c0b9a2daa68bf76a30ea7c759080d459537dd47"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"unresolved":false,"context_lines":[{"line_number":76,"context_line":"                    \u0027Please try your request again.\u0027)"},{"line_number":77,"context_line":"            return webob.exc.HTTPInternalServerError(explanation\u003dunicode(msg))"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def _proxy_request(self, req):"},{"line_number":80,"context_line":"        headers \u003d dict(req.headers)"},{"line_number":81,"context_line":"        headers.update(self.proxy_headers)"},{"line_number":82,"context_line":"        headers[\u0027X-Forwarded-For\u0027] \u003d req.remote_addr"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F9n38%3D","line":79,"updated":"2013-12-09 15:40:00.000000000","message":"Consider the following link before you make this refactor.  (principle of least knowledge)\n\nhttp://en.wikipedia.org/wiki/Law_of_Demeter\n\nIn this case, I tend to like what you\u0027ve done here.  The method is named _proxy_request and so it makes sense to take a request as an argument rather than all of the individual parts.  So, +1 from on this change but others may feel differently.","commit_id":"1c0b9a2daa68bf76a30ea7c759080d459537dd47"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"unresolved":false,"context_lines":[{"line_number":76,"context_line":"                    \u0027Please try your request again.\u0027)"},{"line_number":77,"context_line":"            return webob.exc.HTTPInternalServerError(explanation\u003dunicode(msg))"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def _proxy_request(self, req):"},{"line_number":80,"context_line":"        headers \u003d dict(req.headers)"},{"line_number":81,"context_line":"        headers.update(self.proxy_headers)"},{"line_number":82,"context_line":"        headers[\u0027X-Forwarded-For\u0027] \u003d req.remote_addr"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F9bzw%3D","line":79,"in_reply_to":"AAAATn%2F9iRE%3D","updated":"2013-12-11 15:06:11.000000000","message":"Yeah, I\u0027m sold.","commit_id":"1c0b9a2daa68bf76a30ea7c759080d459537dd47"},{"author":{"_account_id":7073,"name":"mouad benchchaoui","email":"m.benchchaoui@x-ion.de","username":"mouad"},"change_message_id":"923c6c68b7aad0a567349005bfc7e654171169ad","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                    \u0027Please try your request again.\u0027)"},{"line_number":77,"context_line":"            return webob.exc.HTTPInternalServerError(explanation\u003dunicode(msg))"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def _proxy_request(self, req):"},{"line_number":80,"context_line":"        headers \u003d dict(req.headers)"},{"line_number":81,"context_line":"        headers.update(self.proxy_headers)"},{"line_number":82,"context_line":"        headers[\u0027X-Forwarded-For\u0027] \u003d req.remote_addr"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F9iRE%3D","line":79,"in_reply_to":"AAAATn%2F9n38%3D","updated":"2013-12-10 14:24:40.000000000","message":"IMHO i don\u0027t see it as a violating the least knowledge principle b/c proxy_request is for internal usage only (i.e. leading underscore).","commit_id":"1c0b9a2daa68bf76a30ea7c759080d459537dd47"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"unresolved":false,"context_lines":[{"line_number":96,"context_line":"                method\u003dreq.method,"},{"line_number":97,"context_line":"                headers\u003dheaders,"},{"line_number":98,"context_line":"                body\u003dreq.body,"},{"line_number":99,"context_line":"                connection_type\u003dUnixDomainHTTPConnection)"},{"line_number":100,"context_line":"        except socket.error as ex:"},{"line_number":101,"context_line":"            msg \u003d _(\u0027Connection to metadata agent failed: %s\u0027) % ex"},{"line_number":102,"context_line":"            LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F9n2A%3D","line":99,"updated":"2013-12-09 15:40:00.000000000","message":"Same comment about losing log messages.  Is it useful to have log messages produced in the proxy to debug errors coming from the metadata server?  I\u0027m on the fence.  I suppose one could just go read the log on the metadata server itself to get the same information.","commit_id":"1c0b9a2daa68bf76a30ea7c759080d459537dd47"},{"author":{"_account_id":7073,"name":"mouad benchchaoui","email":"m.benchchaoui@x-ion.de","username":"mouad"},"change_message_id":"923c6c68b7aad0a567349005bfc7e654171169ad","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                method\u003dreq.method,"},{"line_number":97,"context_line":"                headers\u003dheaders,"},{"line_number":98,"context_line":"                body\u003dreq.body,"},{"line_number":99,"context_line":"                connection_type\u003dUnixDomainHTTPConnection)"},{"line_number":100,"context_line":"        except socket.error as ex:"},{"line_number":101,"context_line":"            msg \u003d _(\u0027Connection to metadata agent failed: %s\u0027) % ex"},{"line_number":102,"context_line":"            LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F9iT8%3D","line":99,"in_reply_to":"AAAATn%2F9n2A%3D","updated":"2013-12-10 14:24:40.000000000","message":"This is one of the things that i am trying to argue in this patch:\n\n* Nova metadata service responsibility is to authenticate requests (among other thing).\n* Neutron metadata agent responsibility is to sign request.\n* Neutron namespace proxy responsibility is to proxy request from metadata agent to VM\n\nHaving the same log here and in the nova metadata api seem to me as an unwanted duplication of code  and responsibility \u003d\u003e https://en.wikipedia.org/wiki/Single_responsibility_principle.\n\nAnother thing to take in consideration is that in namespace enabled neutron you end up with a proxy log per namespace, so  IMHO it\u0027s really impractical to hunt down this kind of log entries in this logs.\n\nAs for real use case, now thinking for my self, if i got in VM console log, \"request to metadata api returning \u003e\u003d 400\", well my first instinct is to check the metadata api (trivial right) so why do we need logs here at all ? Unless it\u0027s the proxy or the metadata agent that failed (internal exception).\n\nThoughts ?","commit_id":"1c0b9a2daa68bf76a30ea7c759080d459537dd47"}],"neutron/tests/unit/test_metadata_agent.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":234,"context_line":"        for method in (\u0027GET\u0027, \u0027POST\u0027, \u0027PUT\u0027, \u0027DELETE\u0027):"},{"line_number":235,"context_line":"            # For each HTTP status code that could be returned by the metadata"},{"line_number":236,"context_line":"            # api the agent should just forward it."},{"line_number":237,"context_line":"            for status in range(200, 600):"},{"line_number":238,"context_line":"                resp \u003d self._proxy_request_test_helper(status, method)"},{"line_number":239,"context_line":"                self.assertEqual(status, resp.status_code)"},{"line_number":240,"context_line":"                self.assertEqual(\u0027body\u0027, resp.body)"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAUX%2F%2BfuU%3D","line":237,"updated":"2014-02-20 21:22:03.000000000","message":"Is is really necessary to run 1600 implicit tests?","commit_id":"5e35423a240727e1cfb8b1ab94f9f09918685c18"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"cebe662aa4e417ac4c0d185eaa24565c951d735d","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        for method in (\u0027GET\u0027, \u0027POST\u0027, \u0027PUT\u0027, \u0027DELETE\u0027):"},{"line_number":235,"context_line":"            # For each HTTP status code that could be returned by the metadata"},{"line_number":236,"context_line":"            # api the agent should just forward it."},{"line_number":237,"context_line":"            for status in range(200, 600):"},{"line_number":238,"context_line":"                resp \u003d self._proxy_request_test_helper(status, method)"},{"line_number":239,"context_line":"                self.assertEqual(status, resp.status_code)"},{"line_number":240,"context_line":"                self.assertEqual(\u0027body\u0027, resp.body)"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAUX%2F%2BZXg%3D","line":237,"in_reply_to":"AAAAUX%2F%2BZzU%3D","updated":"2014-02-21 12:42:00.000000000","message":"You can check some random (verb,port) tuples (+ standard http codes 200/40x/50x ?). It reduces implicit tests but still allows to be confident on the code behavior.","commit_id":"5e35423a240727e1cfb8b1ab94f9f09918685c18"},{"author":{"_account_id":7073,"name":"mouad benchchaoui","email":"m.benchchaoui@x-ion.de","username":"mouad"},"change_message_id":"923c6c68b7aad0a567349005bfc7e654171169ad","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        for method in (\u0027GET\u0027, \u0027POST\u0027, \u0027PUT\u0027, \u0027DELETE\u0027):"},{"line_number":235,"context_line":"            # For each HTTP status code that could be returned by the metadata"},{"line_number":236,"context_line":"            # api the agent should just forward it."},{"line_number":237,"context_line":"            for status in range(200, 600):"},{"line_number":238,"context_line":"                resp \u003d self._proxy_request_test_helper(status, method)"},{"line_number":239,"context_line":"                self.assertEqual(status, resp.status_code)"},{"line_number":240,"context_line":"                self.assertEqual(\u0027body\u0027, resp.body)"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAUX%2F%2BZzU%3D","line":237,"in_reply_to":"AAAAUX%2F%2BfuU%3D","updated":"2014-02-21 11:37:47.000000000","message":"I am not sure, do we want to make sure that the proxy is transparent concerning http methods + status code, which is what this test method is doing, or what do you have in mind ? 1600 is not that big of a number right ?","commit_id":"5e35423a240727e1cfb8b1ab94f9f09918685c18"}],"neutron/tests/unit/test_metadata_namespace_proxy.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"cebe662aa4e417ac4c0d185eaa24565c951d735d","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        for method in (\u0027GET\u0027, \u0027POST\u0027, \u0027PUT\u0027, \u0027DELETE\u0027):"},{"line_number":137,"context_line":"            # For each HTTP status code that could be returned by the metadata"},{"line_number":138,"context_line":"            # agent the proxy should just forward it."},{"line_number":139,"context_line":"            for status in range(200, 600):"},{"line_number":140,"context_line":"                resp \u003d self._proxy_request_test_helper(status, method)"},{"line_number":141,"context_line":"                self.assertEqual(resp.status_code, status)"},{"line_number":142,"context_line":"                self.assertEqual(resp.body, \u0027body\u0027)"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAUX%2F%2BZV4%3D","line":139,"updated":"2014-02-21 12:42:00.000000000","message":"same remark","commit_id":"5e35423a240727e1cfb8b1ab94f9f09918685c18"}],"quantum/agent/metadata/agent.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"042dcd2174676f3c3c41f9e9558a7681e3557839","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            else:"},{"line_number":93,"context_line":"                return webob.exc.HTTPNotFound()"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        except Exception:"},{"line_number":96,"context_line":"            LOG.exception(_(\"Unexpected error.\"))"},{"line_number":97,"context_line":"            msg \u003d _(\u0027An unknown error has occurred. \u0027"},{"line_number":98,"context_line":"                    \u0027Please try your request again.\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fkkw%3D","side":"PARENT","line":95,"updated":"2013-05-03 14:32:26.000000000","message":"Why are you removing the logging of unexpected errors?","commit_id":"8322d81661d5921a7ebc0611de68728ffb982748"},{"author":{"_account_id":7073,"name":"mouad benchchaoui","email":"m.benchchaoui@x-ion.de","username":"mouad"},"change_message_id":"3a6a90331ef12c73f1d58f011dbd52dc0ffa4dd7","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            else:"},{"line_number":93,"context_line":"                return webob.exc.HTTPNotFound()"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        except Exception:"},{"line_number":96,"context_line":"            LOG.exception(_(\"Unexpected error.\"))"},{"line_number":97,"context_line":"            msg \u003d _(\u0027An unknown error has occurred. \u0027"},{"line_number":98,"context_line":"                    \u0027Please try your request again.\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FkcU%3D","side":"PARENT","line":95,"in_reply_to":"AAAAOn%2F%2Fkkw%3D","updated":"2013-05-03 15:32:13.000000000","message":"A mistake i didn\u0027t see the LOG.exception part i was thinking that\u0027s it was done to raise 500 error instead because WSGI server do that automatically but yes it\u0027s useful, i will put it back :)","commit_id":"8322d81661d5921a7ebc0611de68728ffb982748"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":67,"context_line":"    def __init__(self, conf):"},{"line_number":68,"context_line":"        self.conf \u003d conf"},{"line_number":69,"context_line":"        self.auth_info \u003d {}"},{"line_number":70,"context_line":"        self.http \u003d httplib2.Http()"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def _get_quantum_client(self):"},{"line_number":73,"context_line":"        qclient \u003d client.Client("}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FjKU%3D","line":70,"updated":"2013-05-05 07:57:42.000000000","message":"What if this fails?","commit_id":"88423411e02051da5624f598155502b85e2038b3"},{"author":{"_account_id":7073,"name":"mouad benchchaoui","email":"m.benchchaoui@x-ion.de","username":"mouad"},"change_message_id":"3a6a90331ef12c73f1d58f011dbd52dc0ffa4dd7","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    def __init__(self, conf):"},{"line_number":68,"context_line":"        self.conf \u003d conf"},{"line_number":69,"context_line":"        self.auth_info \u003d {}"},{"line_number":70,"context_line":"        self.http \u003d httplib2.Http()"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def _get_quantum_client(self):"},{"line_number":73,"context_line":"        qclient \u003d client.Client("}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fg2Q%3D","line":70,"in_reply_to":"AAAAOn%2F%2FjKU%3D","updated":"2013-05-07 09:15:14.000000000","message":"This httplib2.Http class __init__() method doesn\u0027t do much so i don\u0027t see how it can fail ? https://code.google.com/p/httplib2/source/browse/python2/httplib2/__init__.py#1125","commit_id":"88423411e02051da5624f598155502b85e2038b3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d3f38b0ad77f1eb0fef8b79f425d3ccf7e90abca","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        if resp.status \u003d\u003d 200:"},{"line_number":146,"context_line":"            LOG.debug(str(resp))"},{"line_number":147,"context_line":"            return content"},{"line_number":148,"context_line":"        elif resp.status \u003d\u003d 403:"},{"line_number":149,"context_line":"            msg \u003d _("},{"line_number":150,"context_line":"                \u0027The remote metadata server responded with Forbidden. This \u0027"},{"line_number":151,"context_line":"                \u0027response usually occurs when shared secrets do not match.\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2FgQ8%3D","side":"PARENT","line":148,"updated":"2013-06-28 22:50:49.000000000","message":"I think losing this error message is bad idea.  We should still capture this response and warn operators of the potential problem.","commit_id":"6e0f9c1b9f5ebd0d1eb44b9d42961e3cc22fe1e6"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"1a946171c20c81f58eb2a2e9c17e3ef49cbe34d2","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        if resp.status \u003d\u003d 200:"},{"line_number":146,"context_line":"            LOG.debug(str(resp))"},{"line_number":147,"context_line":"            return content"},{"line_number":148,"context_line":"        elif resp.status \u003d\u003d 403:"},{"line_number":149,"context_line":"            msg \u003d _("},{"line_number":150,"context_line":"                \u0027The remote metadata server responded with Forbidden. This \u0027"},{"line_number":151,"context_line":"                \u0027response usually occurs when shared secrets do not match.\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2F1J0%3D","side":"PARENT","line":148,"in_reply_to":"AAAAPn%2F%2FTa0%3D","updated":"2013-07-22 15:05:50.000000000","message":"A 403 is returned when the shared secret is mismatched.  By removing the logging, you\u0027re making this harder for a deployer to triage.  I don\u0027t think the case can be made that this logging is excessive.","commit_id":"6e0f9c1b9f5ebd0d1eb44b9d42961e3cc22fe1e6"},{"author":{"_account_id":7073,"name":"mouad benchchaoui","email":"m.benchchaoui@x-ion.de","username":"mouad"},"change_message_id":"9d9af4613fb5b8c4032fb5aff8b141d9c02df06a","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        if resp.status \u003d\u003d 200:"},{"line_number":146,"context_line":"            LOG.debug(str(resp))"},{"line_number":147,"context_line":"            return content"},{"line_number":148,"context_line":"        elif resp.status \u003d\u003d 403:"},{"line_number":149,"context_line":"            msg \u003d _("},{"line_number":150,"context_line":"                \u0027The remote metadata server responded with Forbidden. This \u0027"},{"line_number":151,"context_line":"                \u0027response usually occurs when shared secrets do not match.\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2FTa0%3D","side":"PARENT","line":148,"in_reply_to":"AAAAPn%2F%2FgQ8%3D","updated":"2013-07-04 13:53:29.000000000","message":"Doesn\u0027t the metadata server log this error, if so than why re-logged it here, because IMHO this is not what the namespace proxy should do, i.e. interpreting return codes.","commit_id":"6e0f9c1b9f5ebd0d1eb44b9d42961e3cc22fe1e6"},{"author":{"_account_id":7073,"name":"mouad benchchaoui","email":"m.benchchaoui@x-ion.de","username":"mouad"},"change_message_id":"9e5fe8358536a82a76ba62ec0373cb577d81e46e","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        if resp.status \u003d\u003d 200:"},{"line_number":146,"context_line":"            LOG.debug(str(resp))"},{"line_number":147,"context_line":"            return content"},{"line_number":148,"context_line":"        elif resp.status \u003d\u003d 403:"},{"line_number":149,"context_line":"            msg \u003d _("},{"line_number":150,"context_line":"                \u0027The remote metadata server responded with Forbidden. This \u0027"},{"line_number":151,"context_line":"                \u0027response usually occurs when shared secrets do not match.\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FyBg%3D","side":"PARENT","line":148,"in_reply_to":"AAAAQn%2F%2F1J0%3D","updated":"2013-10-19 14:59:07.000000000","message":"Well there is 2 reason why i don\u0027t think it\u0027s a good idea to do this:\n\n1- This log is already logged in metadata agent: https://github.com/openstack/neutron/blob/stable/grizzly/quantum/agent/metadata/agent.py#L143, so why duplicate it ?!\n\n2- IMHO The proxy should be doing one thing and only one thing which is to proxy request and response between metadata agent and VM, interpreting return code is not part of his role.","commit_id":"6e0f9c1b9f5ebd0d1eb44b9d42961e3cc22fe1e6"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"1a946171c20c81f58eb2a2e9c17e3ef49cbe34d2","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    def __init__(self, conf):"},{"line_number":68,"context_line":"        self.conf \u003d conf"},{"line_number":69,"context_line":"        self.auth_info \u003d {}"},{"line_number":70,"context_line":"        self.http \u003d httplib2.Http()"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def _get_quantum_client(self):"},{"line_number":73,"context_line":"        qclient \u003d client.Client("}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2F1Lc%3D","line":70,"updated":"2013-07-22 15:05:50.000000000","message":"Missed this the fiirst time.  You cannot safely share this across threads.","commit_id":"5746264804e7c648246bbce01d4e0b10f0552ae1"},{"author":{"_account_id":7073,"name":"mouad benchchaoui","email":"m.benchchaoui@x-ion.de","username":"mouad"},"change_message_id":"9e5fe8358536a82a76ba62ec0373cb577d81e46e","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    def __init__(self, conf):"},{"line_number":68,"context_line":"        self.conf \u003d conf"},{"line_number":69,"context_line":"        self.auth_info \u003d {}"},{"line_number":70,"context_line":"        self.http \u003d httplib2.Http()"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def _get_quantum_client(self):"},{"line_number":73,"context_line":"        qclient \u003d client.Client("}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2FPxA%3D","line":70,"in_reply_to":"AAAAQn%2F%2F1Lc%3D","updated":"2013-10-19 14:59:07.000000000","message":"Fair enough will fix in next commit","commit_id":"5746264804e7c648246bbce01d4e0b10f0552ae1"}],"quantum/agent/metadata/namespace_proxy.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"042dcd2174676f3c3c41f9e9558a7681e3557839","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    def __call__(self, req):"},{"line_number":80,"context_line":"        LOG.debug(_(\"Original request: %s\"), req)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        headers \u003d dict(req.headers)"},{"line_number":83,"context_line":"        headers.update(self.proxy_headers)"},{"line_number":84,"context_line":"        headers[\u0027X-Forwarded-For\u0027] \u003d req.remote_addr"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FkkY%3D","line":82,"updated":"2013-05-03 14:32:26.000000000","message":"These are stripped out at the agent level.  What is the purpose of adding them to the request to throw them away on the next step?","commit_id":"88423411e02051da5624f598155502b85e2038b3"},{"author":{"_account_id":7073,"name":"mouad benchchaoui","email":"m.benchchaoui@x-ion.de","username":"mouad"},"change_message_id":"3a6a90331ef12c73f1d58f011dbd52dc0ffa4dd7","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    def __call__(self, req):"},{"line_number":80,"context_line":"        LOG.debug(_(\"Original request: %s\"), req)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        headers \u003d dict(req.headers)"},{"line_number":83,"context_line":"        headers.update(self.proxy_headers)"},{"line_number":84,"context_line":"        headers[\u0027X-Forwarded-For\u0027] \u003d req.remote_addr"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fkco%3D","line":82,"in_reply_to":"AAAAOn%2F%2FkkY%3D","updated":"2013-05-03 15:32:13.000000000","message":"The idea was for the proxy to not make any decision on what should be passed and what shouldn\u0027t, that the transparent part, but i don\u0027t know if this a good idea or not, but it doesn\u0027t hurt, i think ?","commit_id":"88423411e02051da5624f598155502b85e2038b3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d3f38b0ad77f1eb0fef8b79f425d3ccf7e90abca","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            raise ValueError(msg)"},{"line_number":69,"context_line":"        self.network_id \u003d network_id"},{"line_number":70,"context_line":"        self.router_id \u003d router_id"},{"line_number":71,"context_line":"        self.http \u003d httplib2.Http()"},{"line_number":72,"context_line":"        self.proxy_headers \u003d {}"},{"line_number":73,"context_line":"        if self.router_id:"},{"line_number":74,"context_line":"            self.proxy_headers[\u0027X-Quantum-Router-ID\u0027] \u003d self.router_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2FgQs%3D","line":71,"updated":"2013-06-28 22:50:49.000000000","message":"What\u0027s the purpose for making a shared Http() object?","commit_id":"5746264804e7c648246bbce01d4e0b10f0552ae1"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"1a946171c20c81f58eb2a2e9c17e3ef49cbe34d2","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            raise ValueError(msg)"},{"line_number":69,"context_line":"        self.network_id \u003d network_id"},{"line_number":70,"context_line":"        self.router_id \u003d router_id"},{"line_number":71,"context_line":"        self.http \u003d httplib2.Http()"},{"line_number":72,"context_line":"        self.proxy_headers \u003d {}"},{"line_number":73,"context_line":"        if self.router_id:"},{"line_number":74,"context_line":"            self.proxy_headers[\u0027X-Quantum-Router-ID\u0027] \u003d self.router_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2F1Ls%3D","line":71,"in_reply_to":"AAAAPn%2F%2FTaY%3D","updated":"2013-07-22 15:05:50.000000000","message":"we\u0027re using eventlet and you cannot safely share the http object between greentheads.  You need to use a fresh http object for each request","commit_id":"5746264804e7c648246bbce01d4e0b10f0552ae1"},{"author":{"_account_id":7073,"name":"mouad benchchaoui","email":"m.benchchaoui@x-ion.de","username":"mouad"},"change_message_id":"9d9af4613fb5b8c4032fb5aff8b141d9c02df06a","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            raise ValueError(msg)"},{"line_number":69,"context_line":"        self.network_id \u003d network_id"},{"line_number":70,"context_line":"        self.router_id \u003d router_id"},{"line_number":71,"context_line":"        self.http \u003d httplib2.Http()"},{"line_number":72,"context_line":"        self.proxy_headers \u003d {}"},{"line_number":73,"context_line":"        if self.router_id:"},{"line_number":74,"context_line":"            self.proxy_headers[\u0027X-Quantum-Router-ID\u0027] \u003d self.router_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2FTaY%3D","line":71,"in_reply_to":"AAAAPn%2F%2FgQs%3D","updated":"2013-07-04 13:53:29.000000000","message":"I don\u0027t see why not ? In the previous code the http \"client\" instance was created in each request which IMHO doesn\u0027t make sense because it\u0027s the same object !?","commit_id":"5746264804e7c648246bbce01d4e0b10f0552ae1"},{"author":{"_account_id":7073,"name":"mouad benchchaoui","email":"m.benchchaoui@x-ion.de","username":"mouad"},"change_message_id":"9e5fe8358536a82a76ba62ec0373cb577d81e46e","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            raise ValueError(msg)"},{"line_number":69,"context_line":"        self.network_id \u003d network_id"},{"line_number":70,"context_line":"        self.router_id \u003d router_id"},{"line_number":71,"context_line":"        self.http \u003d httplib2.Http()"},{"line_number":72,"context_line":"        self.proxy_headers \u003d {}"},{"line_number":73,"context_line":"        if self.router_id:"},{"line_number":74,"context_line":"            self.proxy_headers[\u0027X-Quantum-Router-ID\u0027] \u003d self.router_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FuqM%3D","line":71,"in_reply_to":"AAAAQn%2F%2F1Ls%3D","updated":"2013-10-19 14:59:07.000000000","message":"Fair enough will fix in next commit","commit_id":"5746264804e7c648246bbce01d4e0b10f0552ae1"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d3f38b0ad77f1eb0fef8b79f425d3ccf7e90abca","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        self.router_id \u003d router_id"},{"line_number":71,"context_line":"        self.http \u003d httplib2.Http()"},{"line_number":72,"context_line":"        self.proxy_headers \u003d {}"},{"line_number":73,"context_line":"        if self.router_id:"},{"line_number":74,"context_line":"            self.proxy_headers[\u0027X-Quantum-Router-ID\u0027] \u003d self.router_id"},{"line_number":75,"context_line":"        else:"},{"line_number":76,"context_line":"            self.proxy_headers[\u0027X-Quantum-Network-ID\u0027] \u003d self.network_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2FgQo%3D","line":73,"updated":"2013-06-28 22:50:49.000000000","message":"What\u0027s the benefit for storing this in the init?  Duplicating a dict via update is more expensive than the existing if statement to add a key.","commit_id":"5746264804e7c648246bbce01d4e0b10f0552ae1"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"1a946171c20c81f58eb2a2e9c17e3ef49cbe34d2","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        self.router_id \u003d router_id"},{"line_number":71,"context_line":"        self.http \u003d httplib2.Http()"},{"line_number":72,"context_line":"        self.proxy_headers \u003d {}"},{"line_number":73,"context_line":"        if self.router_id:"},{"line_number":74,"context_line":"            self.proxy_headers[\u0027X-Quantum-Router-ID\u0027] \u003d self.router_id"},{"line_number":75,"context_line":"        else:"},{"line_number":76,"context_line":"            self.proxy_headers[\u0027X-Quantum-Network-ID\u0027] \u003d self.network_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2F1OQ%3D","line":73,"in_reply_to":"AAAAPn%2F%2FTZI%3D","updated":"2013-07-22 15:05:50.000000000","message":"Proxy headers is only used in one method, so storing this in an instance variable doesn\u0027t add anything.","commit_id":"5746264804e7c648246bbce01d4e0b10f0552ae1"},{"author":{"_account_id":7073,"name":"mouad benchchaoui","email":"m.benchchaoui@x-ion.de","username":"mouad"},"change_message_id":"9d9af4613fb5b8c4032fb5aff8b141d9c02df06a","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        self.router_id \u003d router_id"},{"line_number":71,"context_line":"        self.http \u003d httplib2.Http()"},{"line_number":72,"context_line":"        self.proxy_headers \u003d {}"},{"line_number":73,"context_line":"        if self.router_id:"},{"line_number":74,"context_line":"            self.proxy_headers[\u0027X-Quantum-Router-ID\u0027] \u003d self.router_id"},{"line_number":75,"context_line":"        else:"},{"line_number":76,"context_line":"            self.proxy_headers[\u0027X-Quantum-Network-ID\u0027] \u003d self.network_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2FTZI%3D","line":73,"in_reply_to":"AAAAPn%2F%2FgQo%3D","updated":"2013-07-04 13:53:29.000000000","message":"Because this is where instance attribute should be create :), as for \"update being more expensive ...\" isn\u0027t this a micro optimization ? and FWIW we can\u0027t rid of dict.update in _proxy_request if we want to forward the client (cloud-init) header too.","commit_id":"5746264804e7c648246bbce01d4e0b10f0552ae1"},{"author":{"_account_id":7073,"name":"mouad benchchaoui","email":"m.benchchaoui@x-ion.de","username":"mouad"},"change_message_id":"9e5fe8358536a82a76ba62ec0373cb577d81e46e","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        self.router_id \u003d router_id"},{"line_number":71,"context_line":"        self.http \u003d httplib2.Http()"},{"line_number":72,"context_line":"        self.proxy_headers \u003d {}"},{"line_number":73,"context_line":"        if self.router_id:"},{"line_number":74,"context_line":"            self.proxy_headers[\u0027X-Quantum-Router-ID\u0027] \u003d self.router_id"},{"line_number":75,"context_line":"        else:"},{"line_number":76,"context_line":"            self.proxy_headers[\u0027X-Quantum-Network-ID\u0027] \u003d self.network_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2FPw4%3D","line":73,"in_reply_to":"AAAAQn%2F%2F1OQ%3D","updated":"2013-10-19 14:59:07.000000000","message":"The question to ask, is where this variable belong to ? is it an instance variable or no ? IMHO i believe this is an instance variable that\u0027s why i putted it here, hope this make sense to you :)","commit_id":"5746264804e7c648246bbce01d4e0b10f0552ae1"}]}
