)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"da928fea4b7f946aff020c54eb1a9bc9a3ab4a13","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ritesh Anand \u003critesh.anand@hpe.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-14 18:32:56 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Avoids logging error on OVS agent start."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When integration bridge patch ports are being setup on"},{"line_number":10,"context_line":"agent start, we should not log error on not finding"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"da0c15f0_5564dbe2","line":7,"updated":"2016-03-28 13:40:50.000000000","message":"please prefix with ml2","commit_id":"804d6d8f623dafdb0f640781553ba2b254dab665"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"a3b5f7ccdb5897cb107690d3f3d99025573e2129","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Avoids logging error on ML2 OVS agent start."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When integration bridge patch ports are being setup on"},{"line_number":10,"context_line":"agent start, we should not log error on not finding"},{"line_number":11,"context_line":"db entry for the patch port type."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie619a7fd141fbaa92d39b73f77e5c8c1efc8ec48"},{"line_number":14,"context_line":"Closes-Bug: #1545058"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"ba0121b8_94b6c088","line":11,"range":{"start_line":10,"start_character":13,"end_line":11,"end_character":32},"updated":"2016-03-29 08:12:05.000000000","message":"I\u0027d like to understand more why it\u0027s not an error and why we shouldn\u0027t log it","commit_id":"2c0f3d074f1b05d29caa7fe3b6333d34ff8f2137"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"65148b1a666fc7adea5bab2625999b4b9013bdb8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Avoids logging error on ML2 OVS agent start."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When integration bridge patch ports are being setup on"},{"line_number":10,"context_line":"agent start, we should not log error on not finding"},{"line_number":11,"context_line":"db entry for the patch port type."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie619a7fd141fbaa92d39b73f77e5c8c1efc8ec48"},{"line_number":14,"context_line":"Closes-Bug: #1545058"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"ba0121b8_6d15a1e3","line":11,"range":{"start_line":10,"start_character":13,"end_line":11,"end_character":32},"in_reply_to":"ba0121b8_251f596d","updated":"2016-03-31 07:50:27.000000000","message":"Please add why agent checks interface type (- to clean up ports of wrong type if any)","commit_id":"2c0f3d074f1b05d29caa7fe3b6333d34ff8f2137"},{"author":{"_account_id":15736,"name":"Ritesh Anand","email":"tellrit@gmail.com","username":"ritesh"},"change_message_id":"d4290913acc1ecfbc5b9bd350076dad42753ca7e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Avoids logging error on ML2 OVS agent start."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When integration bridge patch ports are being setup on"},{"line_number":10,"context_line":"agent start, we should not log error on not finding"},{"line_number":11,"context_line":"db entry for the patch port type."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie619a7fd141fbaa92d39b73f77e5c8c1efc8ec48"},{"line_number":14,"context_line":"Closes-Bug: #1545058"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"ba0121b8_251f596d","line":11,"range":{"start_line":10,"start_character":13,"end_line":11,"end_character":32},"in_reply_to":"ba0121b8_94b6c088","updated":"2016-03-30 18:21:47.000000000","message":"Does \"We should not log error on not finding db entry for interface type, because\non agent start, the interface and hence the db entry does not exist yet.\" describe it better?","commit_id":"2c0f3d074f1b05d29caa7fe3b6333d34ff8f2137"}],"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"a3b5f7ccdb5897cb107690d3f3d99025573e2129","unresolved":false,"context_lines":[{"line_number":1100,"context_line":"                bridge, prefix\u003dconstants.PEER_PHYSICAL_PREFIX)"},{"line_number":1101,"context_line":"            # Interface type of port for physical and integration bridges must"},{"line_number":1102,"context_line":"            # be same, so check only one of them."},{"line_number":1103,"context_line":"            int_type \u003d self.int_br.db_get_val(\"Interface\","},{"line_number":1104,"context_line":"                int_if_name, \"type\", log_errors\u003dFalse)"},{"line_number":1105,"context_line":"            if self.use_veth_interconnection:"},{"line_number":1106,"context_line":"                # Drop ports if the interface types doesn\u0027t match the"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba0121b8_d45e7844","line":1103,"range":{"start_line":1103,"start_character":11,"end_line":1103,"end_character":20},"updated":"2016-03-29 08:12:05.000000000","message":"this will be undefined in case of error, but further logic depends on it. Don\u0027t we mask some real error here?","commit_id":"2c0f3d074f1b05d29caa7fe3b6333d34ff8f2137"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"65148b1a666fc7adea5bab2625999b4b9013bdb8","unresolved":false,"context_lines":[{"line_number":1100,"context_line":"                bridge, prefix\u003dconstants.PEER_PHYSICAL_PREFIX)"},{"line_number":1101,"context_line":"            # Interface type of port for physical and integration bridges must"},{"line_number":1102,"context_line":"            # be same, so check only one of them."},{"line_number":1103,"context_line":"            int_type \u003d self.int_br.db_get_val(\"Interface\","},{"line_number":1104,"context_line":"                int_if_name, \"type\", log_errors\u003dFalse)"},{"line_number":1105,"context_line":"            if self.use_veth_interconnection:"},{"line_number":1106,"context_line":"                # Drop ports if the interface types doesn\u0027t match the"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba0121b8_eddff137","line":1103,"range":{"start_line":1103,"start_character":11,"end_line":1103,"end_character":20},"in_reply_to":"ba0121b8_48b8a4c8","updated":"2016-03-31 07:50:27.000000000","message":"Thanks fo clarification, will you please add corresponding comment here?","commit_id":"2c0f3d074f1b05d29caa7fe3b6333d34ff8f2137"},{"author":{"_account_id":15736,"name":"Ritesh Anand","email":"tellrit@gmail.com","username":"ritesh"},"change_message_id":"d4290913acc1ecfbc5b9bd350076dad42753ca7e","unresolved":false,"context_lines":[{"line_number":1100,"context_line":"                bridge, prefix\u003dconstants.PEER_PHYSICAL_PREFIX)"},{"line_number":1101,"context_line":"            # Interface type of port for physical and integration bridges must"},{"line_number":1102,"context_line":"            # be same, so check only one of them."},{"line_number":1103,"context_line":"            int_type \u003d self.int_br.db_get_val(\"Interface\","},{"line_number":1104,"context_line":"                int_if_name, \"type\", log_errors\u003dFalse)"},{"line_number":1105,"context_line":"            if self.use_veth_interconnection:"},{"line_number":1106,"context_line":"                # Drop ports if the interface types doesn\u0027t match the"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba0121b8_48b8a4c8","line":1103,"range":{"start_line":1103,"start_character":11,"end_line":1103,"end_character":20},"in_reply_to":"ba0121b8_d45e7844","updated":"2016-03-30 18:21:47.000000000","message":"int_type is being used for cleaning up veth/patch ports in case the interface type is the wrong one than expected. So, as I understand, no cleanup will take place in case it is undefined, which does no harm; the setup will do its job just fine.","commit_id":"2c0f3d074f1b05d29caa7fe3b6333d34ff8f2137"}]}
