)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"83464653f9de9c68c7d5983d711f42408a8da18e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Pass the complete info in sg/rules db into PRECOMMIT_XXX callback"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"PRECOMMIT_XXX events\u0027 callback need completed sg info, like the sg id"},{"line_number":10,"context_line":"and its related rules for registed driver."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Co-Authored-By: Manjeet Singh Bhatia \u003cmanjeet.s.bhatia@intel.com\u003e"},{"line_number":13,"context_line":"Change-Id: I451ae5f0c2157e8fcb34095d0745c3057a8fcfe8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"bacf61ea_eb1ba219","line":10,"updated":"2016-07-28 19:04:23.000000000","message":"nit: typo registed --\u003e registered","commit_id":"442bec5d4e3edf762acb676271cf3ec56bd5294f"}],"neutron/db/securitygroups_db.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b22cc33da7adf3a2adfa84991f82d707300bdb0a","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                                      exc_cls\u003dext_sg.SecurityGroupConflict,"},{"line_number":189,"context_line":"                                      **kwargs)"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        secgroup_dict \u003d self._make_security_group_dict(security_group_db)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        kwargs[\u0027security_group\u0027] \u003d secgroup_dict"},{"line_number":194,"context_line":"        registry.notify(resources.SECURITY_GROUP, events.AFTER_CREATE, self,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_3ea40007","side":"PARENT","line":191,"updated":"2016-02-19 06:02:17.000000000","message":"this used to be out of the transaction and now you move it in. I wouldn\u0027t do this this lightly.","commit_id":"fa9d167148f4bfd9effc77623d7135f4911b630a"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"aeb932077fac36607cb80ea7fb7eab8b6a88d530","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                                      exc_cls\u003dext_sg.SecurityGroupConflict,"},{"line_number":189,"context_line":"                                      **kwargs)"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        secgroup_dict \u003d self._make_security_group_dict(security_group_db)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        kwargs[\u0027security_group\u0027] \u003d secgroup_dict"},{"line_number":194,"context_line":"        registry.notify(resources.SECURITY_GROUP, events.AFTER_CREATE, self,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_e2eb56da","side":"PARENT","line":191,"in_reply_to":"9aed3d3a_9c3d8f2d","updated":"2016-03-01 09:25:03.000000000","message":"thanks Kevin!\nBut _make_security_group_dict here only create the dict, no other extension involved. it\u0027s unlike the core resource with ML2 extension.\n\nand it need all the created info in db, not only the id.","commit_id":"fa9d167148f4bfd9effc77623d7135f4911b630a"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"8ed100903bde67f098c5515ca45faf20809952ff","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                                      exc_cls\u003dext_sg.SecurityGroupConflict,"},{"line_number":189,"context_line":"                                      **kwargs)"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        secgroup_dict \u003d self._make_security_group_dict(security_group_db)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        kwargs[\u0027security_group\u0027] \u003d secgroup_dict"},{"line_number":194,"context_line":"        registry.notify(resources.SECURITY_GROUP, events.AFTER_CREATE, self,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_3e540953","side":"PARENT","line":191,"in_reply_to":"9aed3d3a_e2eb56da","updated":"2016-03-01 10:53:09.000000000","message":"we use precommit event here, to make mech driver (\nnetworking-odl)\u0027s db tables synchronous with the neutron db. use precommit would make them in same session. So it\u0027s not only a validation point, but also need pass complete info, like id, rules into mech driver.\n\nif in the future, _make_security_group_dict will include some extension, db lookups inside this session will bring more race condition?\n\nand for \"db event hoop\", seems a choice but it could not fallback the  commit of the session, maybe need be used together the precommit which as a validation.\n\n@armax, how do you think about it?","commit_id":"fa9d167148f4bfd9effc77623d7135f4911b630a"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"a4ad3287738075f0a3b3edd6a499c7883713f006","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                                      exc_cls\u003dext_sg.SecurityGroupConflict,"},{"line_number":189,"context_line":"                                      **kwargs)"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        secgroup_dict \u003d self._make_security_group_dict(security_group_db)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        kwargs[\u0027security_group\u0027] \u003d secgroup_dict"},{"line_number":194,"context_line":"        registry.notify(resources.SECURITY_GROUP, events.AFTER_CREATE, self,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_591c7e13","side":"PARENT","line":191,"in_reply_to":"dae33548_3ea40007","updated":"2016-02-19 06:46:27.000000000","message":"moving inside would make kwargs include the full information in db, like new created id. otherwise the kwargs would lack some attr.","commit_id":"fa9d167148f4bfd9effc77623d7135f4911b630a"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"1e945f1819c3ad0a6f2487330988dc81d92d554a","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                                      exc_cls\u003dext_sg.SecurityGroupConflict,"},{"line_number":189,"context_line":"                                      **kwargs)"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        secgroup_dict \u003d self._make_security_group_dict(security_group_db)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        kwargs[\u0027security_group\u0027] \u003d secgroup_dict"},{"line_number":194,"context_line":"        registry.notify(resources.SECURITY_GROUP, events.AFTER_CREATE, self,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_9c3d8f2d","side":"PARENT","line":191,"in_reply_to":"dae33548_591c7e13","updated":"2016-03-01 08:47:45.000000000","message":"The issue is that the dict extend function can call other extension functions that may try to do DB lookups. If the point here is just to get the ID passed into the callback, just add the ID to the callback as another kwarg.","commit_id":"fa9d167148f4bfd9effc77623d7135f4911b630a"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b22cc33da7adf3a2adfa84991f82d707300bdb0a","unresolved":false,"context_lines":[{"line_number":402,"context_line":"            self._registry_notify(resources.SECURITY_GROUP_RULE,"},{"line_number":403,"context_line":"                              events.PRECOMMIT_CREATE,"},{"line_number":404,"context_line":"                              exc_cls\u003dext_sg.SecurityGroupConflict, **kwargs)"},{"line_number":405,"context_line":"        res_rule_dict \u003d self._make_security_group_rule_dict(db)"},{"line_number":406,"context_line":"        kwargs[\u0027security_group_rule\u0027] \u003d res_rule_dict"},{"line_number":407,"context_line":"        registry.notify("},{"line_number":408,"context_line":"            resources.SECURITY_GROUP_RULE, events.AFTER_CREATE, self,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_beb8102c","side":"PARENT","line":405,"updated":"2016-02-19 06:02:17.000000000","message":"ditto.","commit_id":"fa9d167148f4bfd9effc77623d7135f4911b630a"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"a196106d6a1ff15eb06fcb08678991211a0e22c3","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                                    security_group_db)"},{"line_number":189,"context_line":"                kwargs[\u0027security_group\u0027] \u003d secgroup_dict"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"                self._registry_notify(resources.SECURITY_GROUP,"},{"line_number":192,"context_line":"                                      events.PRECOMMIT_CREATE,"},{"line_number":193,"context_line":"                                      exc_cls\u003dext_sg.SecurityGroupConflict,"},{"line_number":194,"context_line":"                                      **kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_9f8cf780","line":191,"updated":"2016-03-02 06:38:09.000000000","message":"precommit for security group is triggered multiple times.\nSomething wrong.\n\nSince security group, ingress rule and egress rules are created, we  should trigger\n- one precommit event for security group\n- one precommit event for ingress rule if created\n- precommit event for egress rule for each supported_ether_type\n\nor if we want to trigger single precommit event for security group,\nthose information needs to be included in kwargs.","commit_id":"8e770518a9bf8bc3d746f7321941a7554bd2ab95"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"82863757b1da564cddfa03a19ffd64abab64c639","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                                    security_group_db)"},{"line_number":189,"context_line":"                kwargs[\u0027security_group\u0027] \u003d secgroup_dict"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"                self._registry_notify(resources.SECURITY_GROUP,"},{"line_number":192,"context_line":"                                      events.PRECOMMIT_CREATE,"},{"line_number":193,"context_line":"                                      exc_cls\u003dext_sg.SecurityGroupConflict,"},{"line_number":194,"context_line":"                                      **kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_5902790c","line":191,"in_reply_to":"7af24918_9f8cf780","updated":"2016-03-02 12:59:51.000000000","message":"I see, I will update the code.","commit_id":"8e770518a9bf8bc3d746f7321941a7554bd2ab95"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"d3f3b799f59a82548aee10ceec7e0a9cb93ac1c8","unresolved":false,"context_lines":[{"line_number":177,"context_line":"                        ethertype\u003dethertype,"},{"line_number":178,"context_line":"                        source_group\u003dsecurity_group_db)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"                self._create_sg_rule_and_notify_precommit("},{"line_number":181,"context_line":"                        None, context,"},{"line_number":182,"context_line":"                        id\u003duuidutils.generate_uuid(), tenant_id\u003dtenant_id,"},{"line_number":183,"context_line":"                        security_group\u003dsecurity_group_db,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_41e70db0","line":180,"updated":"2016-03-02 16:18:32.000000000","message":"precommit event for security group rule should be triggered after  event for security group.","commit_id":"935f29b79c8ff46ea2653cc4735a6351d9a2c9ce"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"22fedd09cf6d1538c8edaa7e8ac09041e0c8158a","unresolved":false,"context_lines":[{"line_number":177,"context_line":"                        ethertype\u003dethertype,"},{"line_number":178,"context_line":"                        source_group\u003dsecurity_group_db)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"                self._create_sg_rule_and_notify_precommit("},{"line_number":181,"context_line":"                        None, context,"},{"line_number":182,"context_line":"                        id\u003duuidutils.generate_uuid(), tenant_id\u003dtenant_id,"},{"line_number":183,"context_line":"                        security_group\u003dsecurity_group_db,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_e498c3c2","line":180,"in_reply_to":"7af24918_41e70db0","updated":"2016-03-03 02:04:45.000000000","message":"Done","commit_id":"935f29b79c8ff46ea2653cc4735a6351d9a2c9ce"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"d3f3b799f59a82548aee10ceec7e0a9cb93ac1c8","unresolved":false,"context_lines":[{"line_number":381,"context_line":"                \u0027context\u0027: context,"},{"line_number":382,"context_line":"                \u0027security_group_rule\u0027: kwargs"},{"line_number":383,"context_line":"            }"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"        db \u003d SecurityGroupRule(**kwargs)"},{"line_number":386,"context_line":"        context.session.add(db)"},{"line_number":387,"context_line":"        self._registry_notify(resources.SECURITY_GROUP_RULE,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_a187f1d5","line":384,"updated":"2016-03-02 16:18:32.000000000","message":"id for security group rule should be passed.","commit_id":"935f29b79c8ff46ea2653cc4735a6351d9a2c9ce"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"22fedd09cf6d1538c8edaa7e8ac09041e0c8158a","unresolved":false,"context_lines":[{"line_number":381,"context_line":"                \u0027context\u0027: context,"},{"line_number":382,"context_line":"                \u0027security_group_rule\u0027: kwargs"},{"line_number":383,"context_line":"            }"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"        db \u003d SecurityGroupRule(**kwargs)"},{"line_number":386,"context_line":"        context.session.add(db)"},{"line_number":387,"context_line":"        self._registry_notify(resources.SECURITY_GROUP_RULE,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_048ccf7d","line":384,"in_reply_to":"7af24918_a187f1d5","updated":"2016-03-03 02:04:45.000000000","message":"thanks, id has been included in the kwargs passed in.","commit_id":"935f29b79c8ff46ea2653cc4735a6351d9a2c9ce"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"5ea9d91501550365dfeb24c07f5ed16136c85a37","unresolved":false,"context_lines":[{"line_number":190,"context_line":"                        direction\u003d\u0027egress\u0027,"},{"line_number":191,"context_line":"                        ethertype\u003dethertype)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        secgroup_dict \u003d self._make_security_group_dict("},{"line_number":194,"context_line":"                            security_group_db)"},{"line_number":195,"context_line":"        kwargs[\u0027security_group\u0027] \u003d secgroup_dict"},{"line_number":196,"context_line":"        registry.notify(resources.SECURITY_GROUP, events.AFTER_CREATE, self,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7af24918_e35cfd4c","line":193,"updated":"2016-03-03 20:33:14.000000000","message":"nit: unnecessary code churn.","commit_id":"fb94fb69d5bca82b037d8e5d1bcab772a5529eba"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"41ed1383a5751f29a4891000d35c3999ab28b2a7","unresolved":false,"context_lines":[{"line_number":190,"context_line":"                        direction\u003d\u0027egress\u0027,"},{"line_number":191,"context_line":"                        ethertype\u003dethertype)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        secgroup_dict \u003d self._make_security_group_dict("},{"line_number":194,"context_line":"                            security_group_db)"},{"line_number":195,"context_line":"        kwargs[\u0027security_group\u0027] \u003d secgroup_dict"},{"line_number":196,"context_line":"        registry.notify(resources.SECURITY_GROUP, events.AFTER_CREATE, self,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7af24918_e9acd38d","line":193,"in_reply_to":"7af24918_e35cfd4c","updated":"2016-03-04 01:33:29.000000000","message":"Done","commit_id":"fb94fb69d5bca82b037d8e5d1bcab772a5529eba"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"f2ee048666ecfddc72718f2c4123e0b7ebc6f4cc","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            self._registry_notify(resources.SECURITY_GROUP,"},{"line_number":167,"context_line":"                                  events.PRECOMMIT_CREATE,"},{"line_number":168,"context_line":"                                  exc_cls\u003dext_sg.SecurityGroupConflict,"},{"line_number":169,"context_line":"                                  **kwargs)"},{"line_number":170,"context_line":"            if default_sg:"},{"line_number":171,"context_line":"                context.session.add(DefaultSecurityGroup("},{"line_number":172,"context_line":"                    security_group\u003dsecurity_group_db,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5aef4532_54c6769a","line":169,"updated":"2016-03-09 16:47:38.000000000","message":"this part seems independent from SG rule changes.\nhow about separating patches?","commit_id":"af6b9580abbc6f1b4bbbabeb9479d2da65bf5264"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"ae3fed60812cc7981b52571dc9fe6538bfa16cb5","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            self._registry_notify(resources.SECURITY_GROUP,"},{"line_number":167,"context_line":"                                  events.PRECOMMIT_CREATE,"},{"line_number":168,"context_line":"                                  exc_cls\u003dext_sg.SecurityGroupConflict,"},{"line_number":169,"context_line":"                                  **kwargs)"},{"line_number":170,"context_line":"            if default_sg:"},{"line_number":171,"context_line":"                context.session.add(DefaultSecurityGroup("},{"line_number":172,"context_line":"                    security_group\u003dsecurity_group_db,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5aef4532_57945443","line":169,"in_reply_to":"5aef4532_06d0e0c8","updated":"2016-03-14 09:54:45.000000000","message":"split to new patch https://review.openstack.org/#/c/291603/","commit_id":"af6b9580abbc6f1b4bbbabeb9479d2da65bf5264"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"f870bf8179eec34996f58ee552bdaef777017958","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            self._registry_notify(resources.SECURITY_GROUP,"},{"line_number":167,"context_line":"                                  events.PRECOMMIT_CREATE,"},{"line_number":168,"context_line":"                                  exc_cls\u003dext_sg.SecurityGroupConflict,"},{"line_number":169,"context_line":"                                  **kwargs)"},{"line_number":170,"context_line":"            if default_sg:"},{"line_number":171,"context_line":"                context.session.add(DefaultSecurityGroup("},{"line_number":172,"context_line":"                    security_group\u003dsecurity_group_db,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5aef4532_06d0e0c8","line":169,"in_reply_to":"5aef4532_54c6769a","updated":"2016-03-11 07:08:23.000000000","message":"OK, I will split it into two patches.","commit_id":"af6b9580abbc6f1b4bbbabeb9479d2da65bf5264"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"f2ee048666ecfddc72718f2c4123e0b7ebc6f4cc","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                if default_sg:"},{"line_number":176,"context_line":"                    # Allow intercommunication"},{"line_number":177,"context_line":"                    self._create_sg_rule_and_notify_precommit("},{"line_number":178,"context_line":"                        None, context,"},{"line_number":179,"context_line":"                        id\u003duuidutils.generate_uuid(), tenant_id\u003dtenant_id,"},{"line_number":180,"context_line":"                        security_group\u003dsecurity_group_db,"},{"line_number":181,"context_line":"                        direction\u003d\u0027ingress\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5aef4532_716744b7","line":178,"updated":"2016-03-09 16:47:38.000000000","message":"while i can understand the motivation,\ngenerating only PRECOMMIT events for these rules sounds inconsistent.","commit_id":"af6b9580abbc6f1b4bbbabeb9479d2da65bf5264"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"f870bf8179eec34996f58ee552bdaef777017958","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                if default_sg:"},{"line_number":176,"context_line":"                    # Allow intercommunication"},{"line_number":177,"context_line":"                    self._create_sg_rule_and_notify_precommit("},{"line_number":178,"context_line":"                        None, context,"},{"line_number":179,"context_line":"                        id\u003duuidutils.generate_uuid(), tenant_id\u003dtenant_id,"},{"line_number":180,"context_line":"                        security_group\u003dsecurity_group_db,"},{"line_number":181,"context_line":"                        direction\u003d\u0027ingress\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5aef4532_c69398ff","line":178,"in_reply_to":"5aef4532_716744b7","updated":"2016-03-11 07:08:23.000000000","message":"OK, I will add the other events.","commit_id":"af6b9580abbc6f1b4bbbabeb9479d2da65bf5264"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"ae3fed60812cc7981b52571dc9fe6538bfa16cb5","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                if default_sg:"},{"line_number":176,"context_line":"                    # Allow intercommunication"},{"line_number":177,"context_line":"                    self._create_sg_rule_and_notify_precommit("},{"line_number":178,"context_line":"                        None, context,"},{"line_number":179,"context_line":"                        id\u003duuidutils.generate_uuid(), tenant_id\u003dtenant_id,"},{"line_number":180,"context_line":"                        security_group\u003dsecurity_group_db,"},{"line_number":181,"context_line":"                        direction\u003d\u0027ingress\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"3afc51ec_af737a7f","line":178,"in_reply_to":"5aef4532_c69398ff","updated":"2016-03-14 09:54:45.000000000","message":"seems it\u0027s difficulty to add the BEFORE_ or AFTER_ event inside the transaction for the transaction.\n\nBut we need keep the consistency...","commit_id":"af6b9580abbc6f1b4bbbabeb9479d2da65bf5264"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"f2ee048666ecfddc72718f2c4123e0b7ebc6f4cc","unresolved":false,"context_lines":[{"line_number":422,"context_line":"            context.session.add(db)"},{"line_number":423,"context_line":"            self._registry_notify(resources.SECURITY_GROUP_RULE,"},{"line_number":424,"context_line":"                              events.PRECOMMIT_CREATE,"},{"line_number":425,"context_line":"                              exc_cls\u003dext_sg.SecurityGroupConflict, **kwargs)"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"        res_rule_dict \u003d self._make_security_group_rule_dict(db)"},{"line_number":428,"context_line":"        kwargs[\u0027security_group_rule\u0027] \u003d res_rule_dict"}],"source_content_type":"text/x-python","patch_set":8,"id":"5aef4532_3125bc08","line":425,"updated":"2016-03-09 16:47:38.000000000","message":"duplicated notification?","commit_id":"af6b9580abbc6f1b4bbbabeb9479d2da65bf5264"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"f870bf8179eec34996f58ee552bdaef777017958","unresolved":false,"context_lines":[{"line_number":422,"context_line":"            context.session.add(db)"},{"line_number":423,"context_line":"            self._registry_notify(resources.SECURITY_GROUP_RULE,"},{"line_number":424,"context_line":"                              events.PRECOMMIT_CREATE,"},{"line_number":425,"context_line":"                              exc_cls\u003dext_sg.SecurityGroupConflict, **kwargs)"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"        res_rule_dict \u003d self._make_security_group_rule_dict(db)"},{"line_number":428,"context_line":"        kwargs[\u0027security_group_rule\u0027] \u003d res_rule_dict"}],"source_content_type":"text/x-python","patch_set":8,"id":"5aef4532_e6eb3477","line":425,"in_reply_to":"5aef4532_3125bc08","updated":"2016-03-11 07:08:23.000000000","message":"Done!","commit_id":"af6b9580abbc6f1b4bbbabeb9479d2da65bf5264"},{"author":{"_account_id":20123,"name":"Saulo-Aislan","email":"sauloa@lsd.ufcg.edu.br","username":"SauloAislan"},"change_message_id":"10e15ce867ac4862572085ec568f6a44b76cfdcb","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        If default_sg is true that means we are a default security group for"},{"line_number":140,"context_line":"        a given tenant if it does not exist."},{"line_number":141,"context_line":"        \"\"\""},{"line_number":142,"context_line":"        s \u003d security_group[\u0027security_group\u0027]"},{"line_number":143,"context_line":"        kwargs \u003d {"},{"line_number":144,"context_line":"            \u0027context\u0027: context,"},{"line_number":145,"context_line":"            \u0027security_group\u0027: s,"}],"source_content_type":"text/x-python","patch_set":9,"id":"1af94dfe_7d78f38f","line":142,"range":{"start_line":142,"start_character":8,"end_line":142,"end_character":9},"updated":"2016-03-16 19:34:35.000000000","message":"You can modify the name of this variable?","commit_id":"9970937ac4e76b63d4fbd35c3cd630d7d8ab73c9"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"3788d2f76f9ccd60c4e46bc40b3fe3209da86bf4","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        If default_sg is true that means we are a default security group for"},{"line_number":140,"context_line":"        a given tenant if it does not exist."},{"line_number":141,"context_line":"        \"\"\""},{"line_number":142,"context_line":"        s \u003d security_group[\u0027security_group\u0027]"},{"line_number":143,"context_line":"        kwargs \u003d {"},{"line_number":144,"context_line":"            \u0027context\u0027: context,"},{"line_number":145,"context_line":"            \u0027security_group\u0027: s,"}],"source_content_type":"text/x-python","patch_set":9,"id":"1af94dfe_a5eb79af","line":142,"range":{"start_line":142,"start_character":8,"end_line":142,"end_character":9},"in_reply_to":"1af94dfe_7d78f38f","updated":"2016-03-17 02:53:45.000000000","message":"Done","commit_id":"9970937ac4e76b63d4fbd35c3cd630d7d8ab73c9"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"4710532dd24401d23d8abe46511ee0b96c9bdb5f","unresolved":false,"context_lines":[{"line_number":178,"context_line":"                        ethertype\u003dethertype,"},{"line_number":179,"context_line":"                        source_group\u003dsecurity_group_db)"},{"line_number":180,"context_line":"                    context.session.add(ingress_rule)"},{"line_number":181,"context_line":"                    s[\u0027security_group_rules\u0027].append(ingress_rule)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"                egress_rule \u003d SecurityGroupRule("},{"line_number":184,"context_line":"                    id\u003duuidutils.generate_uuid(), tenant_id\u003dtenant_id,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3afc51ec_98007103","line":181,"updated":"2016-03-14 15:09:10.000000000","message":"is it intended to add a db object here?","commit_id":"9970937ac4e76b63d4fbd35c3cd630d7d8ab73c9"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"b3c0dcf84aa0d0cd94229d5156434f579eaf7994","unresolved":false,"context_lines":[{"line_number":178,"context_line":"                        ethertype\u003dethertype,"},{"line_number":179,"context_line":"                        source_group\u003dsecurity_group_db)"},{"line_number":180,"context_line":"                    context.session.add(ingress_rule)"},{"line_number":181,"context_line":"                    s[\u0027security_group_rules\u0027].append(ingress_rule)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"                egress_rule \u003d SecurityGroupRule("},{"line_number":184,"context_line":"                    id\u003duuidutils.generate_uuid(), tenant_id\u003dtenant_id,"}],"source_content_type":"text/x-python","patch_set":9,"id":"1af94dfe_263b2ad3","line":181,"in_reply_to":"3afc51ec_45642721","updated":"2016-03-16 08:22:56.000000000","message":"i\u0027m not sure what\u0027s wrong with having db queries here,\nbut if it\u0027s a problem, how about adding process_extension argument to _make_security_group_rule_dict and use it to convert these rules?","commit_id":"9970937ac4e76b63d4fbd35c3cd630d7d8ab73c9"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"00e38bc28302c3147281f3a8d091530b706bc43c","unresolved":false,"context_lines":[{"line_number":178,"context_line":"                        ethertype\u003dethertype,"},{"line_number":179,"context_line":"                        source_group\u003dsecurity_group_db)"},{"line_number":180,"context_line":"                    context.session.add(ingress_rule)"},{"line_number":181,"context_line":"                    s[\u0027security_group_rules\u0027].append(ingress_rule)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"                egress_rule \u003d SecurityGroupRule("},{"line_number":184,"context_line":"                    id\u003duuidutils.generate_uuid(), tenant_id\u003dtenant_id,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3afc51ec_45642721","line":181,"in_reply_to":"3afc51ec_98007103","updated":"2016-03-15 02:04:53.000000000","message":"yes， personally I agree with that, and actually in the first patch I did what you adviced in L196, but kevin comments that maybe there is extension db query inside the _make_dict_xxx methord.\n\nhttps://review.openstack.org/#/c/281693/3/neutron/db/securitygroups_db.py\n\nbecause we can not provide complete events inside the transaction(add BEFORE_ AFTER_ here for rules creating), I think I could only pass the object within the group info.","commit_id":"9970937ac4e76b63d4fbd35c3cd630d7d8ab73c9"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"4710532dd24401d23d8abe46511ee0b96c9bdb5f","unresolved":false,"context_lines":[{"line_number":193,"context_line":"                                  exc_cls\u003dext_sg.SecurityGroupConflict,"},{"line_number":194,"context_line":"                                  **kwargs)"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        secgroup_dict \u003d self._make_security_group_dict(security_group_db)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        kwargs[\u0027security_group\u0027] \u003d secgroup_dict"},{"line_number":199,"context_line":"        registry.notify(resources.SECURITY_GROUP, events.AFTER_CREATE, self,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3afc51ec_9806b1cc","line":196,"range":{"start_line":196,"start_character":29,"end_line":196,"end_character":54},"updated":"2016-03-14 15:09:10.000000000","message":"it might be simpler to move this up a few lines and use the dict for PRECOMMIT event too.","commit_id":"9970937ac4e76b63d4fbd35c3cd630d7d8ab73c9"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"85b9766c0d228ccff0a45c538a3f5fd686345ff4","unresolved":false,"context_lines":[{"line_number":281,"context_line":"            self._registry_notify(resources.SECURITY_GROUP,"},{"line_number":282,"context_line":"                                  events.PRECOMMIT_DELETE,"},{"line_number":283,"context_line":"                                  exc_cls\u003dext_sg.SecurityGroupInUse, id\u003did,"},{"line_number":284,"context_line":"                                  **kwargs)"},{"line_number":285,"context_line":"            context.session.delete(sg)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        kwargs.pop(\u0027security_group\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1af94dfe_a69bbac8","line":284,"range":{"start_line":284,"start_character":36,"end_line":284,"end_character":42},"updated":"2016-03-16 08:24:07.000000000","message":"we may need also pass object here, to make kwargs include the sg rules info, which would be deleted by cascade deleting.","commit_id":"9970937ac4e76b63d4fbd35c3cd630d7d8ab73c9"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"03443381810414bf21293af69b76dcfc8b979437","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        If default_sg is true that means we are a default security group for"},{"line_number":140,"context_line":"        a given tenant if it does not exist."},{"line_number":141,"context_line":"        \"\"\""},{"line_number":142,"context_line":"        sg \u003d security_group[\u0027security_group\u0027]"},{"line_number":143,"context_line":"        sg[\u0027security_group_rules\u0027] \u003d []"},{"line_number":144,"context_line":"        kwargs \u003d {"},{"line_number":145,"context_line":"            \u0027context\u0027: context,"}],"source_content_type":"text/x-python","patch_set":10,"id":"da0c15f0_c64b75af","line":142,"updated":"2016-03-25 07:27:53.000000000","message":"it\u0027s better not to mix an unrelated change (s -\u003e sg)","commit_id":"ab858c390839c9db9c9413a84bee2a2f00d8e343"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"98c1fb355e1697fa6f242341a863a75e5f04caf4","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        If default_sg is true that means we are a default security group for"},{"line_number":140,"context_line":"        a given tenant if it does not exist."},{"line_number":141,"context_line":"        \"\"\""},{"line_number":142,"context_line":"        sg \u003d security_group[\u0027security_group\u0027]"},{"line_number":143,"context_line":"        sg[\u0027security_group_rules\u0027] \u003d []"},{"line_number":144,"context_line":"        kwargs \u003d {"},{"line_number":145,"context_line":"            \u0027context\u0027: context,"}],"source_content_type":"text/x-python","patch_set":10,"id":"da0c15f0_d8269767","line":142,"in_reply_to":"da0c15f0_c64b75af","updated":"2016-03-25 18:20:02.000000000","message":"+1","commit_id":"ab858c390839c9db9c9413a84bee2a2f00d8e343"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"70bb7b784b28712eb11d011913404b089ce2c81e","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        If default_sg is true that means we are a default security group for"},{"line_number":140,"context_line":"        a given tenant if it does not exist."},{"line_number":141,"context_line":"        \"\"\""},{"line_number":142,"context_line":"        sg \u003d security_group[\u0027security_group\u0027]"},{"line_number":143,"context_line":"        sg[\u0027security_group_rules\u0027] \u003d []"},{"line_number":144,"context_line":"        kwargs \u003d {"},{"line_number":145,"context_line":"            \u0027context\u0027: context,"}],"source_content_type":"text/x-python","patch_set":10,"id":"da0c15f0_7e8480d3","line":142,"in_reply_to":"da0c15f0_d8269767","updated":"2016-03-27 02:56:00.000000000","message":"Done","commit_id":"ab858c390839c9db9c9413a84bee2a2f00d8e343"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"03443381810414bf21293af69b76dcfc8b979437","unresolved":false,"context_lines":[{"line_number":411,"context_line":"                description\u003drule_dict.get(\u0027description\u0027)"},{"line_number":412,"context_line":"            )"},{"line_number":413,"context_line":"            context.session.add(db)"},{"line_number":414,"context_line":"            rule_dict[\u0027id\u0027] \u003d db[\u0027id\u0027]"},{"line_number":415,"context_line":"            self._registry_notify(resources.SECURITY_GROUP_RULE,"},{"line_number":416,"context_line":"                              events.PRECOMMIT_CREATE,"},{"line_number":417,"context_line":"                              exc_cls\u003dext_sg.SecurityGroupConflict, **kwargs)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da0c15f0_06c1ede4","line":414,"updated":"2016-03-25 07:27:53.000000000","message":"is this independent from the create_security_group change?","commit_id":"ab858c390839c9db9c9413a84bee2a2f00d8e343"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"98c1fb355e1697fa6f242341a863a75e5f04caf4","unresolved":false,"context_lines":[{"line_number":411,"context_line":"                description\u003drule_dict.get(\u0027description\u0027)"},{"line_number":412,"context_line":"            )"},{"line_number":413,"context_line":"            context.session.add(db)"},{"line_number":414,"context_line":"            rule_dict[\u0027id\u0027] \u003d db[\u0027id\u0027]"},{"line_number":415,"context_line":"            self._registry_notify(resources.SECURITY_GROUP_RULE,"},{"line_number":416,"context_line":"                              events.PRECOMMIT_CREATE,"},{"line_number":417,"context_line":"                              exc_cls\u003dext_sg.SecurityGroupConflict, **kwargs)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da0c15f0_783cab93","line":414,"in_reply_to":"da0c15f0_06c1ede4","updated":"2016-03-25 18:20:02.000000000","message":"Do we want to split this patch into two?\ni.e. security group and security group rule?\nOr should we update commit message?","commit_id":"ab858c390839c9db9c9413a84bee2a2f00d8e343"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"70bb7b784b28712eb11d011913404b089ce2c81e","unresolved":false,"context_lines":[{"line_number":411,"context_line":"                description\u003drule_dict.get(\u0027description\u0027)"},{"line_number":412,"context_line":"            )"},{"line_number":413,"context_line":"            context.session.add(db)"},{"line_number":414,"context_line":"            rule_dict[\u0027id\u0027] \u003d db[\u0027id\u0027]"},{"line_number":415,"context_line":"            self._registry_notify(resources.SECURITY_GROUP_RULE,"},{"line_number":416,"context_line":"                              events.PRECOMMIT_CREATE,"},{"line_number":417,"context_line":"                              exc_cls\u003dext_sg.SecurityGroupConflict, **kwargs)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da0c15f0_3eefa888","line":414,"in_reply_to":"da0c15f0_06c1ede4","updated":"2016-03-27 02:56:00.000000000","message":"This patch is to make right msg passed for precommit_msg, it should be for sg and rules too. I will update the commit msg.","commit_id":"ab858c390839c9db9c9413a84bee2a2f00d8e343"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"03443381810414bf21293af69b76dcfc8b979437","unresolved":false,"context_lines":[{"line_number":517,"context_line":"        return sg_id"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"    def _make_security_group_rule_dict(self, security_group_rule, fields\u003dNone,"},{"line_number":520,"context_line":"                                       process_ext\u003dTrue):"},{"line_number":521,"context_line":"        res \u003d {\u0027id\u0027: security_group_rule[\u0027id\u0027],"},{"line_number":522,"context_line":"               \u0027tenant_id\u0027: security_group_rule[\u0027tenant_id\u0027],"},{"line_number":523,"context_line":"               \u0027security_group_id\u0027: security_group_rule[\u0027security_group_id\u0027],"}],"source_content_type":"text/x-python","patch_set":10,"id":"da0c15f0_66e8a97d","line":520,"range":{"start_line":520,"start_character":39,"end_line":520,"end_character":50},"updated":"2016-03-25 07:27:53.000000000","message":"please use a consistent name.  ie. process_extensions","commit_id":"ab858c390839c9db9c9413a84bee2a2f00d8e343"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"70bb7b784b28712eb11d011913404b089ce2c81e","unresolved":false,"context_lines":[{"line_number":517,"context_line":"        return sg_id"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"    def _make_security_group_rule_dict(self, security_group_rule, fields\u003dNone,"},{"line_number":520,"context_line":"                                       process_ext\u003dTrue):"},{"line_number":521,"context_line":"        res \u003d {\u0027id\u0027: security_group_rule[\u0027id\u0027],"},{"line_number":522,"context_line":"               \u0027tenant_id\u0027: security_group_rule[\u0027tenant_id\u0027],"},{"line_number":523,"context_line":"               \u0027security_group_id\u0027: security_group_rule[\u0027security_group_id\u0027],"}],"source_content_type":"text/x-python","patch_set":10,"id":"da0c15f0_de730c14","line":520,"range":{"start_line":520,"start_character":39,"end_line":520,"end_character":50},"in_reply_to":"da0c15f0_66e8a97d","updated":"2016-03-27 02:56:00.000000000","message":"Done","commit_id":"ab858c390839c9db9c9413a84bee2a2f00d8e343"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"c2900fcc2da067d9147a4d3f90f4a11782263e85","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        a given tenant if it does not exist."},{"line_number":143,"context_line":"        \"\"\""},{"line_number":144,"context_line":"        s \u003d security_group[\u0027security_group\u0027]"},{"line_number":145,"context_line":"        s[\u0027security_group_rules\u0027] \u003d []"},{"line_number":146,"context_line":"        kwargs \u003d {"},{"line_number":147,"context_line":"            \u0027context\u0027: context,"},{"line_number":148,"context_line":"            \u0027security_group\u0027: s,"}],"source_content_type":"text/x-python","patch_set":12,"id":"1aa78d24_f3b07b45","line":145,"updated":"2016-07-11 22:28:23.000000000","message":"If we can, we should try and make a deep copy of s rather than editing it in place.","commit_id":"c2e2e2026aae7bb251a5be37a1c0418c77728912"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"2ee1cc9d1c75eb5ace479318f264f20aa020527a","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        a given tenant if it does not exist."},{"line_number":143,"context_line":"        \"\"\""},{"line_number":144,"context_line":"        s \u003d security_group[\u0027security_group\u0027]"},{"line_number":145,"context_line":"        s[\u0027security_group_rules\u0027] \u003d []"},{"line_number":146,"context_line":"        kwargs \u003d {"},{"line_number":147,"context_line":"            \u0027context\u0027: context,"},{"line_number":148,"context_line":"            \u0027security_group\u0027: s,"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_5b87acb4","line":145,"in_reply_to":"1aa78d24_f3b07b45","updated":"2016-07-27 00:56:02.000000000","message":"Done","commit_id":"c2e2e2026aae7bb251a5be37a1c0418c77728912"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"c2900fcc2da067d9147a4d3f90f4a11782263e85","unresolved":false,"context_lines":[{"line_number":413,"context_line":"                description\u003drule_dict.get(\u0027description\u0027)"},{"line_number":414,"context_line":"            )"},{"line_number":415,"context_line":"            context.session.add(db)"},{"line_number":416,"context_line":"            rule_dict[\u0027id\u0027] \u003d db[\u0027id\u0027]"},{"line_number":417,"context_line":"            self._registry_notify(resources.SECURITY_GROUP_RULE,"},{"line_number":418,"context_line":"                              events.PRECOMMIT_CREATE,"},{"line_number":419,"context_line":"                              exc_cls\u003dext_sg.SecurityGroupConflict, **kwargs)"}],"source_content_type":"text/x-python","patch_set":12,"id":"1aa78d24_33bcc305","line":416,"updated":"2016-07-11 22:28:23.000000000","message":"ditto","commit_id":"c2e2e2026aae7bb251a5be37a1c0418c77728912"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"2ee1cc9d1c75eb5ace479318f264f20aa020527a","unresolved":false,"context_lines":[{"line_number":413,"context_line":"                description\u003drule_dict.get(\u0027description\u0027)"},{"line_number":414,"context_line":"            )"},{"line_number":415,"context_line":"            context.session.add(db)"},{"line_number":416,"context_line":"            rule_dict[\u0027id\u0027] \u003d db[\u0027id\u0027]"},{"line_number":417,"context_line":"            self._registry_notify(resources.SECURITY_GROUP_RULE,"},{"line_number":418,"context_line":"                              events.PRECOMMIT_CREATE,"},{"line_number":419,"context_line":"                              exc_cls\u003dext_sg.SecurityGroupConflict, **kwargs)"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_7bb1d08e","line":416,"in_reply_to":"1aa78d24_33bcc305","updated":"2016-07-27 00:56:02.000000000","message":"this already a new dict not modifying it in place would make  no difference with deepcopy.","commit_id":"c2e2e2026aae7bb251a5be37a1c0418c77728912"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"c2900fcc2da067d9147a4d3f90f4a11782263e85","unresolved":false,"context_lines":[{"line_number":546,"context_line":"               \u0027remote_ip_prefix\u0027: security_group_rule[\u0027remote_ip_prefix\u0027],"},{"line_number":547,"context_line":"               \u0027remote_group_id\u0027: security_group_rule[\u0027remote_group_id\u0027]}"},{"line_number":548,"context_line":""},{"line_number":549,"context_line":"        if process_extensions:"},{"line_number":550,"context_line":"            self._apply_dict_extend_functions(ext_sg.SECURITYGROUPRULES, res,"},{"line_number":551,"context_line":"                                              security_group_rule)"},{"line_number":552,"context_line":"        return self._fields(res, fields)"}],"source_content_type":"text/x-python","patch_set":12,"id":"1aa78d24_73064bcf","line":549,"updated":"2016-07-11 22:28:23.000000000","message":"that\u0027s most likely altering the API response, can you elaborate on why it\u0027s necessary? It seems like this might be to hide the side effect of the shallow copy?","commit_id":"c2e2e2026aae7bb251a5be37a1c0418c77728912"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"2ee1cc9d1c75eb5ace479318f264f20aa020527a","unresolved":false,"context_lines":[{"line_number":546,"context_line":"               \u0027remote_ip_prefix\u0027: security_group_rule[\u0027remote_ip_prefix\u0027],"},{"line_number":547,"context_line":"               \u0027remote_group_id\u0027: security_group_rule[\u0027remote_group_id\u0027]}"},{"line_number":548,"context_line":""},{"line_number":549,"context_line":"        if process_extensions:"},{"line_number":550,"context_line":"            self._apply_dict_extend_functions(ext_sg.SECURITYGROUPRULES, res,"},{"line_number":551,"context_line":"                                              security_group_rule)"},{"line_number":552,"context_line":"        return self._fields(res, fields)"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_5bae8c2e","line":549,"in_reply_to":"1aa78d24_73064bcf","updated":"2016-07-27 00:56:02.000000000","message":"I reviewed it is not needed and I am gonna remove it","commit_id":"c2e2e2026aae7bb251a5be37a1c0418c77728912"},{"author":{"_account_id":22121,"name":"Ray Wang","email":"983206578@qq.com"},"change_message_id":"d22cd191277093c9bdb5cb5067b72c39a542b8d6","unresolved":false,"context_lines":[{"line_number":606,"context_line":"                              exc_cls\u003dext_sg.SecurityGroupRuleInUse, **kwargs)"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":609,"context_line":"            query \u003d self._model_query(context,"},{"line_number":610,"context_line":"                                      sg_models.SecurityGroupRule).filter("},{"line_number":611,"context_line":"                sg_models.SecurityGroupRule.id \u003d\u003d id)"},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"            self._registry_notify(resources.SECURITY_GROUP_RULE,"},{"line_number":614,"context_line":"                                  events.PRECOMMIT_DELETE,"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a8ec9b2_91054715","line":611,"range":{"start_line":609,"start_character":0,"end_line":611,"end_character":53},"updated":"2016-09-19 02:45:01.000000000","message":"could we qury by id first and assign the returned value to kwargs[\u0027security_group_rule\u0027], as function delete_security_group.","commit_id":"6a08d552b844338d68f5890645dd5804feca00f5"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"977e5465ab4cd2fc624e244a0cc3a2e928e6131f","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                sg_copy[\u0027security_group_rules\u0027].append("},{"line_number":121,"context_line":"                    self._make_security_group_rule_dict(egress_rule))"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"            self._registry_notify(resources.SECURITY_GROUP,"},{"line_number":124,"context_line":"                                  events.PRECOMMIT_CREATE,"},{"line_number":125,"context_line":"                                  exc_cls\u003dext_sg.SecurityGroupConflict,"},{"line_number":126,"context_line":"                                  **kwargs)"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa6399be_95f4ccf2","line":123,"range":{"start_line":123,"start_character":17,"end_line":123,"end_character":33},"updated":"2016-10-13 01:07:53.000000000","message":"I think there is a better way to get all security group info before precommit, just move L#128 and L#130 before L123.","commit_id":"e69da79dbc7d6b1988008d7d74fc1657f8293fde"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"f940493b739f547db3d754fe9600c70e792e82b8","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                sg_copy[\u0027security_group_rules\u0027].append("},{"line_number":121,"context_line":"                    self._make_security_group_rule_dict(egress_rule))"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"            self._registry_notify(resources.SECURITY_GROUP,"},{"line_number":124,"context_line":"                                  events.PRECOMMIT_CREATE,"},{"line_number":125,"context_line":"                                  exc_cls\u003dext_sg.SecurityGroupConflict,"},{"line_number":126,"context_line":"                                  **kwargs)"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa6399be_c6ddb871","line":123,"range":{"start_line":123,"start_character":17,"end_line":123,"end_character":33},"in_reply_to":"fa6399be_95f4ccf2","updated":"2016-10-19 20:47:38.000000000","message":"done !!","commit_id":"e69da79dbc7d6b1988008d7d74fc1657f8293fde"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"977e5465ab4cd2fc624e244a0cc3a2e928e6131f","unresolved":false,"context_lines":[{"line_number":355,"context_line":"            )"},{"line_number":356,"context_line":"            context.session.add(db)"},{"line_number":357,"context_line":"            rule_dict[\u0027id\u0027] \u003d db[\u0027id\u0027]"},{"line_number":358,"context_line":"            self._registry_notify(resources.SECURITY_GROUP_RULE,"},{"line_number":359,"context_line":"                              events.PRECOMMIT_CREATE,"},{"line_number":360,"context_line":"                              exc_cls\u003dext_sg.SecurityGroupConflict, **kwargs)"},{"line_number":361,"context_line":"        res_rule_dict \u003d self._make_security_group_rule_dict(db)"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa6399be_d54c8444","line":358,"range":{"start_line":358,"start_character":17,"end_line":358,"end_character":33},"updated":"2016-10-13 01:07:53.000000000","message":"It is better to get all the security group info before this notify, the same as create_security_group.","commit_id":"e69da79dbc7d6b1988008d7d74fc1657f8293fde"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"f940493b739f547db3d754fe9600c70e792e82b8","unresolved":false,"context_lines":[{"line_number":355,"context_line":"            )"},{"line_number":356,"context_line":"            context.session.add(db)"},{"line_number":357,"context_line":"            rule_dict[\u0027id\u0027] \u003d db[\u0027id\u0027]"},{"line_number":358,"context_line":"            self._registry_notify(resources.SECURITY_GROUP_RULE,"},{"line_number":359,"context_line":"                              events.PRECOMMIT_CREATE,"},{"line_number":360,"context_line":"                              exc_cls\u003dext_sg.SecurityGroupConflict, **kwargs)"},{"line_number":361,"context_line":"        res_rule_dict \u003d self._make_security_group_rule_dict(db)"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa6399be_865ae081","line":358,"range":{"start_line":358,"start_character":17,"end_line":358,"end_character":33},"in_reply_to":"fa6399be_d54c8444","updated":"2016-10-19 20:47:38.000000000","message":"case in which it was different, but in this it have secgroup_id, inside rule, so if needed info can be retrieved.","commit_id":"e69da79dbc7d6b1988008d7d74fc1657f8293fde"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"977e5465ab4cd2fc624e244a0cc3a2e928e6131f","unresolved":false,"context_lines":[{"line_number":625,"context_line":"                                      sg_models.SecurityGroupRule).filter("},{"line_number":626,"context_line":"                sg_models.SecurityGroupRule.id \u003d\u003d id)"},{"line_number":627,"context_line":""},{"line_number":628,"context_line":"            self._registry_notify(resources.SECURITY_GROUP_RULE,"},{"line_number":629,"context_line":"                                  events.PRECOMMIT_DELETE,"},{"line_number":630,"context_line":"                                  exc_cls\u003dext_sg.SecurityGroupRuleInUse, id\u003did,"},{"line_number":631,"context_line":"                                  **kwargs)"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa6399be_5506b4ce","line":628,"range":{"start_line":628,"start_character":17,"end_line":628,"end_character":33},"updated":"2016-10-13 01:07:53.000000000","message":"I think delete security group precommit also need the same as create security group precommit","commit_id":"e69da79dbc7d6b1988008d7d74fc1657f8293fde"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"f940493b739f547db3d754fe9600c70e792e82b8","unresolved":false,"context_lines":[{"line_number":625,"context_line":"                                      sg_models.SecurityGroupRule).filter("},{"line_number":626,"context_line":"                sg_models.SecurityGroupRule.id \u003d\u003d id)"},{"line_number":627,"context_line":""},{"line_number":628,"context_line":"            self._registry_notify(resources.SECURITY_GROUP_RULE,"},{"line_number":629,"context_line":"                                  events.PRECOMMIT_DELETE,"},{"line_number":630,"context_line":"                                  exc_cls\u003dext_sg.SecurityGroupRuleInUse, id\u003did,"},{"line_number":631,"context_line":"                                  **kwargs)"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa6399be_264af4ac","line":628,"range":{"start_line":628,"start_character":17,"end_line":628,"end_character":33},"in_reply_to":"fa6399be_5506b4ce","updated":"2016-10-19 20:47:38.000000000","message":"same here as L358","commit_id":"e69da79dbc7d6b1988008d7d74fc1657f8293fde"},{"author":{"_account_id":22121,"name":"Ray Wang","email":"983206578@qq.com"},"change_message_id":"6ba8bfdb7b56f781c5c013cec4e017268aa277f6","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        kwargs \u003d {"},{"line_number":200,"context_line":"            \u0027context\u0027: context,"},{"line_number":201,"context_line":"            \u0027security_group_id\u0027: id,"},{"line_number":202,"context_line":"            \u0027security_group\u0027: sg,"},{"line_number":203,"context_line":"        }"},{"line_number":204,"context_line":"        self._registry_notify(resources.SECURITY_GROUP, events.BEFORE_DELETE,"},{"line_number":205,"context_line":"                              exc_cls\u003dext_sg.SecurityGroupInUse, id\u003did,"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba5da102_28ee45ec","line":202,"range":{"start_line":202,"start_character":0,"end_line":202,"end_character":33},"updated":"2016-11-01 04:20:53.000000000","message":"it\u0027s better to use sg dict body instead of db model, \nsg_dict \u003d self._make_security_group_dict(sg)","commit_id":"f51406b5e9f029526ede4c60f77779c303904d61"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"7516174759ac9e54b854629d50673b6b7fe0d93c","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        kwargs \u003d {"},{"line_number":200,"context_line":"            \u0027context\u0027: context,"},{"line_number":201,"context_line":"            \u0027security_group_id\u0027: id,"},{"line_number":202,"context_line":"            \u0027security_group\u0027: sg,"},{"line_number":203,"context_line":"        }"},{"line_number":204,"context_line":"        self._registry_notify(resources.SECURITY_GROUP, events.BEFORE_DELETE,"},{"line_number":205,"context_line":"                              exc_cls\u003dext_sg.SecurityGroupInUse, id\u003did,"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba5da102_9d2443b0","line":202,"range":{"start_line":202,"start_character":0,"end_line":202,"end_character":33},"in_reply_to":"ba5da102_28ee45ec","updated":"2016-11-04 23:57:51.000000000","message":"Done","commit_id":"f51406b5e9f029526ede4c60f77779c303904d61"},{"author":{"_account_id":22121,"name":"Ray Wang","email":"983206578@qq.com"},"change_message_id":"6ba8bfdb7b56f781c5c013cec4e017268aa277f6","unresolved":false,"context_lines":[{"line_number":350,"context_line":"            self._registry_notify(resources.SECURITY_GROUP_RULE,"},{"line_number":351,"context_line":"                              events.PRECOMMIT_CREATE,"},{"line_number":352,"context_line":"                              exc_cls\u003dext_sg.SecurityGroupConflict, **kwargs)"},{"line_number":353,"context_line":"        res_rule_dict \u003d self._make_security_group_rule_dict(db)"},{"line_number":354,"context_line":"        kwargs[\u0027security_group_rule\u0027] \u003d res_rule_dict"},{"line_number":355,"context_line":"        registry.notify("},{"line_number":356,"context_line":"            resources.SECURITY_GROUP_RULE, events.AFTER_CREATE, self,"},{"line_number":357,"context_line":"            **kwargs)"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba5da102_68d75d23","line":354,"range":{"start_line":353,"start_character":0,"end_line":354,"end_character":53},"updated":"2016-11-01 04:20:53.000000000","message":"I think there is a better way to get security group rule info before precommit, just move L#353~354 before L#350.","commit_id":"f51406b5e9f029526ede4c60f77779c303904d61"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"7516174759ac9e54b854629d50673b6b7fe0d93c","unresolved":false,"context_lines":[{"line_number":350,"context_line":"            self._registry_notify(resources.SECURITY_GROUP_RULE,"},{"line_number":351,"context_line":"                              events.PRECOMMIT_CREATE,"},{"line_number":352,"context_line":"                              exc_cls\u003dext_sg.SecurityGroupConflict, **kwargs)"},{"line_number":353,"context_line":"        res_rule_dict \u003d self._make_security_group_rule_dict(db)"},{"line_number":354,"context_line":"        kwargs[\u0027security_group_rule\u0027] \u003d res_rule_dict"},{"line_number":355,"context_line":"        registry.notify("},{"line_number":356,"context_line":"            resources.SECURITY_GROUP_RULE, events.AFTER_CREATE, self,"},{"line_number":357,"context_line":"            **kwargs)"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba5da102_bd3907db","line":354,"range":{"start_line":353,"start_character":0,"end_line":354,"end_character":53},"in_reply_to":"ba5da102_68d75d23","updated":"2016-11-04 23:57:51.000000000","message":"Done","commit_id":"f51406b5e9f029526ede4c60f77779c303904d61"},{"author":{"_account_id":22121,"name":"Ray Wang","email":"983206578@qq.com"},"change_message_id":"6ba8bfdb7b56f781c5c013cec4e017268aa277f6","unresolved":false,"context_lines":[{"line_number":604,"context_line":""},{"line_number":605,"context_line":"    @db_api.retry_if_session_inactive()"},{"line_number":606,"context_line":"    def delete_security_group_rule(self, context, id):"},{"line_number":607,"context_line":"        kwargs \u003d {"},{"line_number":608,"context_line":"            \u0027context\u0027: context,"},{"line_number":609,"context_line":"            \u0027security_group_rule_id\u0027: id"},{"line_number":610,"context_line":"        }"},{"line_number":611,"context_line":"        self._registry_notify(resources.SECURITY_GROUP_RULE,"},{"line_number":612,"context_line":"                              events.BEFORE_DELETE, id\u003did,"},{"line_number":613,"context_line":"                              exc_cls\u003dext_sg.SecurityGroupRuleInUse, **kwargs)"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba5da102_88b111e4","line":610,"range":{"start_line":607,"start_character":0,"end_line":610,"end_character":9},"updated":"2016-11-01 04:20:53.000000000","message":"when deleting security group, we confirm security group exists first, \nthen pass the sg\u0027s db model into precommit callback. \nWe could do as delete_security_group, like this,\n\nsg_rule \u003d self._get_security_group_rule(context, id)\nsg_rule_dict \u003d self._make_security_group_rule_dict(sg_rule)\nkwargs \u003d {\n    \u0027context\u0027: context,\n    \u0027security_group_rule_id\u0027: id,\n    \u0027security_group_rule\u0027: sg_rule_dict\n}","commit_id":"f51406b5e9f029526ede4c60f77779c303904d61"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"7516174759ac9e54b854629d50673b6b7fe0d93c","unresolved":false,"context_lines":[{"line_number":604,"context_line":""},{"line_number":605,"context_line":"    @db_api.retry_if_session_inactive()"},{"line_number":606,"context_line":"    def delete_security_group_rule(self, context, id):"},{"line_number":607,"context_line":"        kwargs \u003d {"},{"line_number":608,"context_line":"            \u0027context\u0027: context,"},{"line_number":609,"context_line":"            \u0027security_group_rule_id\u0027: id"},{"line_number":610,"context_line":"        }"},{"line_number":611,"context_line":"        self._registry_notify(resources.SECURITY_GROUP_RULE,"},{"line_number":612,"context_line":"                              events.BEFORE_DELETE, id\u003did,"},{"line_number":613,"context_line":"                              exc_cls\u003dext_sg.SecurityGroupRuleInUse, **kwargs)"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba5da102_37e8b616","line":610,"range":{"start_line":607,"start_character":0,"end_line":610,"end_character":9},"in_reply_to":"ba5da102_88b111e4","updated":"2016-11-04 23:57:51.000000000","message":"I think sg_rule \u003d self._get_security_group_rule(context, id will extra query here and it would also cause a failure to existing sec group rule test where it trying to test with a mocked id.","commit_id":"f51406b5e9f029526ede4c60f77779c303904d61"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"110f98b785ebdc20c29897603383a782c7b790e6","unresolved":false,"context_lines":[{"line_number":240,"context_line":"            self._registry_notify("},{"line_number":241,"context_line":"                    resources.SECURITY_GROUP,"},{"line_number":242,"context_line":"                    events.PRECOMMIT_UPDATE,"},{"line_number":243,"context_line":"                    exc_cls\u003dext_sg.SecurityGroupConflict, **kwargs)"},{"line_number":244,"context_line":"            sg.update(s)"},{"line_number":245,"context_line":"        sg_dict \u003d self._make_security_group_dict(sg)"},{"line_number":246,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"5a74a57a_0398ba1a","line":243,"range":{"start_line":243,"start_character":58,"end_line":243,"end_character":66},"updated":"2016-11-30 17:47:10.000000000","message":"Here also sg should be passed.\nOtherwise callback may need to query sg with id again.","commit_id":"e82413352bdae7a906eb9c4df995d11f835fab7b"},{"author":{"_account_id":23665,"name":"Rui Wang","email":"starwangrui@gmail.com","username":"EverNine"},"change_message_id":"d8d6ae8ca402e672ffe2e45ccc443d2b9084e289","unresolved":false,"context_lines":[{"line_number":240,"context_line":"            self._registry_notify("},{"line_number":241,"context_line":"                    resources.SECURITY_GROUP,"},{"line_number":242,"context_line":"                    events.PRECOMMIT_UPDATE,"},{"line_number":243,"context_line":"                    exc_cls\u003dext_sg.SecurityGroupConflict, **kwargs)"},{"line_number":244,"context_line":"            sg.update(s)"},{"line_number":245,"context_line":"        sg_dict \u003d self._make_security_group_dict(sg)"},{"line_number":246,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"5a74a57a_25968894","line":243,"range":{"start_line":243,"start_character":58,"end_line":243,"end_character":66},"in_reply_to":"5a74a57a_0398ba1a","updated":"2016-12-01 02:57:41.000000000","message":"Done","commit_id":"e82413352bdae7a906eb9c4df995d11f835fab7b"}],"neutron/tests/unit/db/test_securitygroups_db.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"80cf99d56a3ccc795ddb82d8c0a087ed4a54def3","unresolved":false,"context_lines":[{"line_number":189,"context_line":"    def test_security_group_rule_precommit_create_event_fail(self):"},{"line_number":190,"context_line":"        registry.subscribe(fake_callback, resources.SECURITY_GROUP_RULE,"},{"line_number":191,"context_line":"                           events.PRECOMMIT_CREATE)"},{"line_number":192,"context_line":"        with mock.patch.object(self.mixin,"},{"line_number":193,"context_line":"                \u0027_create_sg_rule_and_notify_precommit\u0027):"},{"line_number":194,"context_line":"            sg_dict \u003d self.mixin.create_security_group(self.ctx, FAKE_SECGROUP)"},{"line_number":195,"context_line":"        fake_rule \u003d FAKE_SECGROUP_RULE"}],"source_content_type":"text/x-python","patch_set":6,"id":"7af24918_e67a4b23","line":192,"updated":"2016-03-03 20:45:03.000000000","message":"instead of mocking, we can reorder the line 190 and 192.","commit_id":"fb94fb69d5bca82b037d8e5d1bcab772a5529eba"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"faa3cdb33c3494a857555dc1eb738bfe91fb3e09","unresolved":false,"context_lines":[{"line_number":189,"context_line":"    def test_security_group_rule_precommit_create_event_fail(self):"},{"line_number":190,"context_line":"        registry.subscribe(fake_callback, resources.SECURITY_GROUP_RULE,"},{"line_number":191,"context_line":"                           events.PRECOMMIT_CREATE)"},{"line_number":192,"context_line":"        with mock.patch.object(self.mixin,"},{"line_number":193,"context_line":"                \u0027_create_sg_rule_and_notify_precommit\u0027):"},{"line_number":194,"context_line":"            sg_dict \u003d self.mixin.create_security_group(self.ctx, FAKE_SECGROUP)"},{"line_number":195,"context_line":"        fake_rule \u003d FAKE_SECGROUP_RULE"}],"source_content_type":"text/x-python","patch_set":6,"id":"7af24918_5ba4aeb8","line":192,"in_reply_to":"7af24918_49e987b6","updated":"2016-03-04 02:00:39.000000000","message":"this line is to make registered callback not break the rule creating inside the sg group creating.\nSo if we also detect the exception raised for sg group, the sg group would not be created for the real test which call create_security_group_rule.\n\nI will postpone the registry after the sg creating.","commit_id":"fb94fb69d5bca82b037d8e5d1bcab772a5529eba"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"41ed1383a5751f29a4891000d35c3999ab28b2a7","unresolved":false,"context_lines":[{"line_number":189,"context_line":"    def test_security_group_rule_precommit_create_event_fail(self):"},{"line_number":190,"context_line":"        registry.subscribe(fake_callback, resources.SECURITY_GROUP_RULE,"},{"line_number":191,"context_line":"                           events.PRECOMMIT_CREATE)"},{"line_number":192,"context_line":"        with mock.patch.object(self.mixin,"},{"line_number":193,"context_line":"                \u0027_create_sg_rule_and_notify_precommit\u0027):"},{"line_number":194,"context_line":"            sg_dict \u003d self.mixin.create_security_group(self.ctx, FAKE_SECGROUP)"},{"line_number":195,"context_line":"        fake_rule \u003d FAKE_SECGROUP_RULE"}],"source_content_type":"text/x-python","patch_set":6,"id":"7af24918_49e987b6","line":192,"in_reply_to":"7af24918_e67a4b23","updated":"2016-03-04 01:33:29.000000000","message":"Done","commit_id":"fb94fb69d5bca82b037d8e5d1bcab772a5529eba"}]}
