)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"cb827e43a06009e9c910a76d415b7bd1d7be80b2","unresolved":false,"context_lines":[{"line_number":12,"context_line":"fallback behavior."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"ApiImpact"},{"line_number":15,"context_line":"DocImpact"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[1] https://review.openstack.org/#/c/279378/"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bae84128_31408ca5","line":15,"updated":"2016-02-20 01:06:27.000000000","message":"this will open another bug. I am trying to shrink the list not grow it ;)\n\nSee https://bugs.launchpad.net/neutron/+bug/1547271","commit_id":"39fbd201a690504c09afcdbcdf040c8b8105e08e"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7959917afd0dfba6f0797519d543d5eaa0ce1cc6","unresolved":false,"context_lines":[{"line_number":12,"context_line":"fallback behavior."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"ApiImpact"},{"line_number":15,"context_line":"DocImpact"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[1] https://review.openstack.org/#/c/279378/"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bae84128_91f35873","line":15,"in_reply_to":"bae84128_31408ca5","updated":"2016-02-20 01:07:31.000000000","message":"Would you be okay using the same bug for documentation purposes?","commit_id":"39fbd201a690504c09afcdbcdf040c8b8105e08e"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"a80159e3e351ae3f341954994eae6f6e4a5689e1","unresolved":false,"context_lines":[{"line_number":12,"context_line":"fallback behavior."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"ApiImpact"},{"line_number":15,"context_line":"DocImpact"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[1] https://review.openstack.org/#/c/279378/"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bae84128_b569e427","line":15,"in_reply_to":"bae84128_91f35873","updated":"2016-02-22 16:01:01.000000000","message":"Yes, I can fix this up.  I didn\u0027t know you had a different strategy for this.","commit_id":"39fbd201a690504c09afcdbcdf040c8b8105e08e"}],"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"4e51548bbbfd63db8fd6d5886ee221fbb0774636","unresolved":false,"context_lines":[{"line_number":613,"context_line":"            return"},{"line_number":614,"context_line":""},{"line_number":615,"context_line":"        cidr \u003d subnet.get(\u0027cidr\u0027)"},{"line_number":616,"context_line":"        if attributes.is_attr_set(cidr):"},{"line_number":617,"context_line":"            ip_version \u003d netaddr.IPNetwork(cidr).version"},{"line_number":618,"context_line":"        else:"},{"line_number":619,"context_line":"            ip_version \u003d subnet.get(\u0027ip_version\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_705640cf","line":616,"range":{"start_line":616,"start_character":34,"end_line":616,"end_character":38},"updated":"2016-02-22 19:27:09.000000000","message":"Should this be \"attributes.is_attr_set(\u0027cidr\u0027)\" as opposed to \"attributes.is_attr_set(cidr)\"?","commit_id":"39fbd201a690504c09afcdbcdf040c8b8105e08e"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e9abd3975a6080edea16f12c156df9f751838489","unresolved":false,"context_lines":[{"line_number":613,"context_line":"            return"},{"line_number":614,"context_line":""},{"line_number":615,"context_line":"        cidr \u003d subnet.get(\u0027cidr\u0027)"},{"line_number":616,"context_line":"        if attributes.is_attr_set(cidr):"},{"line_number":617,"context_line":"            ip_version \u003d netaddr.IPNetwork(cidr).version"},{"line_number":618,"context_line":"        else:"},{"line_number":619,"context_line":"            ip_version \u003d subnet.get(\u0027ip_version\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_a1c68e97","line":616,"range":{"start_line":616,"start_character":34,"end_line":616,"end_character":38},"in_reply_to":"bae84128_705640cf","updated":"2016-02-23 15:46:00.000000000","message":"No, this is correct.  Take a look at the definition of is_attr_set and you\u0027ll see it takes a variable and not a string.  But, L615 may need to be this:\n\n  cidr \u003d subnet.get(\u0027cidr\u0027, attributes.ATTR_NOT_SPECIFIED)\n\nI\u0027ll look in to that.","commit_id":"39fbd201a690504c09afcdbcdf040c8b8105e08e"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"c2cd5b836fd1296de2b21cf11507286498bced68","unresolved":false,"context_lines":[{"line_number":613,"context_line":"            return"},{"line_number":614,"context_line":""},{"line_number":615,"context_line":"        cidr \u003d subnet.get(\u0027cidr\u0027)"},{"line_number":616,"context_line":"        if attributes.is_attr_set(cidr):"},{"line_number":617,"context_line":"            ip_version \u003d netaddr.IPNetwork(cidr).version"},{"line_number":618,"context_line":"        else:"},{"line_number":619,"context_line":"            ip_version \u003d subnet.get(\u0027ip_version\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_1153363a","line":616,"range":{"start_line":616,"start_character":34,"end_line":616,"end_character":38},"in_reply_to":"bae84128_a1c68e97","updated":"2016-02-23 21:59:07.000000000","message":"Right, this is correct.  I should know that :) I don\u0027t think L615 needs to change. is_attr_set() will treat None and ATTR_NOT_SPECIFIED the same.","commit_id":"39fbd201a690504c09afcdbcdf040c8b8105e08e"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"4e51548bbbfd63db8fd6d5886ee221fbb0774636","unresolved":false,"context_lines":[{"line_number":617,"context_line":"            ip_version \u003d netaddr.IPNetwork(cidr).version"},{"line_number":618,"context_line":"        else:"},{"line_number":619,"context_line":"            ip_version \u003d subnet.get(\u0027ip_version\u0027)"},{"line_number":620,"context_line":"            if not attributes.is_attr_set(ip_version):"},{"line_number":621,"context_line":"                msg \u003d _(\u0027ip_version must be specified in the absence of \u0027"},{"line_number":622,"context_line":"                        \u0027cidr and subnetpool_id\u0027)"},{"line_number":623,"context_line":"                raise n_exc.BadRequest(resource\u003d\u0027subnets\u0027, msg\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_90f824c5","line":620,"updated":"2016-02-22 19:27:09.000000000","message":"See comment at L616, wondering if the same applies to ip_version here.","commit_id":"39fbd201a690504c09afcdbcdf040c8b8105e08e"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e9abd3975a6080edea16f12c156df9f751838489","unresolved":false,"context_lines":[{"line_number":617,"context_line":"            ip_version \u003d netaddr.IPNetwork(cidr).version"},{"line_number":618,"context_line":"        else:"},{"line_number":619,"context_line":"            ip_version \u003d subnet.get(\u0027ip_version\u0027)"},{"line_number":620,"context_line":"            if not attributes.is_attr_set(ip_version):"},{"line_number":621,"context_line":"                msg \u003d _(\u0027ip_version must be specified in the absence of \u0027"},{"line_number":622,"context_line":"                        \u0027cidr and subnetpool_id\u0027)"},{"line_number":623,"context_line":"                raise n_exc.BadRequest(resource\u003d\u0027subnets\u0027, msg\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_e15376e0","line":620,"in_reply_to":"bae84128_90f824c5","updated":"2016-02-23 15:46:00.000000000","message":"Same reply.","commit_id":"39fbd201a690504c09afcdbcdf040c8b8105e08e"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"530ab9b2042afbd3f495b75cda020eaad7e5a4a9","unresolved":false,"context_lines":[{"line_number":601,"context_line":"                    \u0027specified\u0027)"},{"line_number":602,"context_line":"            raise n_exc.BadRequest(resource\u003d\u0027subnets\u0027, msg\u003dmsg)"},{"line_number":603,"context_line":""},{"line_number":604,"context_line":"        if subnetpool_id:"},{"line_number":605,"context_line":"            return subnetpool_id"},{"line_number":606,"context_line":""},{"line_number":607,"context_line":"        if not use_default_subnetpool:"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_ba3df7c5","line":604,"range":{"start_line":604,"start_character":11,"end_line":604,"end_character":24},"updated":"2016-02-24 03:55:35.000000000","message":"Yeah, this evaluates to True if the value is attributes.ATTR_NOT_SPECIFIED.  That\u0027s what seems to be breaking everything.  I\u0027ll fix it.","commit_id":"01727c5143164e501cff119e332f35b0bc00ed19"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a66dcbf40371da292d9177d32e125cc662352893","unresolved":false,"context_lines":[{"line_number":621,"context_line":"                        \u0027cidr and subnetpool_id\u0027)"},{"line_number":622,"context_line":"                raise n_exc.BadRequest(resource\u003d\u0027subnets\u0027, msg\u003dmsg)"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":"        if ip_version \u003d\u003d 6 and cfg.CONF.ipv6_pd_enabled:"},{"line_number":625,"context_line":"            return constants.IPV6_PD_POOL_ID"},{"line_number":626,"context_line":""},{"line_number":627,"context_line":"        subnetpool \u003d self.get_default_subnetpool(context, ip_version)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_4cfe7c39","line":624,"updated":"2016-02-24 23:03:47.000000000","message":"nit: there\u0027s a constant for IPv6","commit_id":"26e268db7923c4deb4c0de32066874b44d441042"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"55cd189d6e6bbccfb67b4c8ebfa78b8dc53e677c","unresolved":false,"context_lines":[{"line_number":621,"context_line":"                        \u0027cidr and subnetpool_id\u0027)"},{"line_number":622,"context_line":"                raise n_exc.BadRequest(resource\u003d\u0027subnets\u0027, msg\u003dmsg)"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":"        if ip_version \u003d\u003d 6 and cfg.CONF.ipv6_pd_enabled:"},{"line_number":625,"context_line":"            return constants.IPV6_PD_POOL_ID"},{"line_number":626,"context_line":""},{"line_number":627,"context_line":"        subnetpool \u003d self.get_default_subnetpool(context, ip_version)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_0140c155","line":624,"in_reply_to":"bae84128_4cfe7c39","updated":"2016-02-25 20:01:07.000000000","message":"Yeah, this code is essentially restored after being obsoleted by armax\u0027s patch [1].  I did change it a little but not too much.  So, I didn\u0027t think to clean up some of these things.  If I need to crack open this patch, I\u0027ll change it.\n\n [1] https://review.openstack.org/#/c/279378/9/neutron/db/db_base_plugin_v2.py","commit_id":"26e268db7923c4deb4c0de32066874b44d441042"}],"neutron/extensions/default_subnetpools.py":[{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"abcf8bd99a3117d0adc6a77617a3f3e69f668d86","unresolved":false,"context_lines":[{"line_number":22,"context_line":"                                   \u0027allow_put\u0027: False,"},{"line_number":23,"context_line":"                                   \u0027default\u0027: False,"},{"line_number":24,"context_line":"                                   \u0027convert_to\u0027: attributes.convert_to_boolean,"},{"line_number":25,"context_line":"                                   \u0027is_visible\u0027: False, },"},{"line_number":26,"context_line":"    },"},{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_14ff5802","line":25,"range":{"start_line":25,"start_character":57,"end_line":25,"end_character":58},"updated":"2016-02-25 22:15:40.000000000","message":"ditto","commit_id":"26e268db7923c4deb4c0de32066874b44d441042"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"abcf8bd99a3117d0adc6a77617a3f3e69f668d86","unresolved":false,"context_lines":[{"line_number":22,"context_line":"                                   \u0027allow_put\u0027: False,"},{"line_number":23,"context_line":"                                   \u0027default\u0027: False,"},{"line_number":24,"context_line":"                                   \u0027convert_to\u0027: attributes.convert_to_boolean,"},{"line_number":25,"context_line":"                                   \u0027is_visible\u0027: False, },"},{"line_number":26,"context_line":"    },"},{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_11180a84","line":25,"range":{"start_line":25,"start_character":54,"end_line":25,"end_character":55},"updated":"2016-02-25 22:15:40.000000000","message":"nit: final comma not needed","commit_id":"26e268db7923c4deb4c0de32066874b44d441042"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"1a7ce02859dba29a331f55f80eb4ef7f7f623417","unresolved":false,"context_lines":[{"line_number":22,"context_line":"                                   \u0027allow_put\u0027: False,"},{"line_number":23,"context_line":"                                   \u0027default\u0027: False,"},{"line_number":24,"context_line":"                                   \u0027convert_to\u0027: attributes.convert_to_boolean,"},{"line_number":25,"context_line":"                                   \u0027is_visible\u0027: False, },"},{"line_number":26,"context_line":"    },"},{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_d64f7dbb","line":25,"range":{"start_line":25,"start_character":57,"end_line":25,"end_character":58},"in_reply_to":"9aed3d3a_14ff5802","updated":"2016-02-26 16:57:21.000000000","message":"True, but you\u0027ll find this is done all over many of the attributes structures.  It helps if/when the data structure needs more additions.  You can add things without having to add the commas in and it makes the diff a little bit cleaner.  It is a minor thing but I prefer it this way.  I actually really like languages that allow trailing commas like this for that reason.","commit_id":"26e268db7923c4deb4c0de32066874b44d441042"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"abcf8bd99a3117d0adc6a77617a3f3e69f668d86","unresolved":false,"context_lines":[{"line_number":23,"context_line":"                                   \u0027default\u0027: False,"},{"line_number":24,"context_line":"                                   \u0027convert_to\u0027: attributes.convert_to_boolean,"},{"line_number":25,"context_line":"                                   \u0027is_visible\u0027: False, },"},{"line_number":26,"context_line":"    },"},{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_5409e02b","line":26,"range":{"start_line":26,"start_character":5,"end_line":26,"end_character":6},"updated":"2016-02-25 22:15:40.000000000","message":"ditto","commit_id":"26e268db7923c4deb4c0de32066874b44d441042"}],"releasenotes/notes/default-subnetpool-semantics-1cdc5cdde2be88c2.yaml":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"4edf36525188572d6b01f3a3627121ac3708b968","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - The subnet API now includes a new"},{"line_number":4,"context_line":"    use_default_subnetpool attribute.  This attribute can"},{"line_number":5,"context_line":"    be specified on creating a subnet in lieu of a"},{"line_number":6,"context_line":"    subnetpool_id.  The two are mutually exclusive.  If"},{"line_number":7,"context_line":"    it is specified as True, the default subnet pool for"},{"line_number":8,"context_line":"    the requested ip_version will be looked up and used."},{"line_number":9,"context_line":"    If no default exists, an error will be returned."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dae33548_046c5807","line":6,"updated":"2016-02-19 00:22:12.000000000","message":"as ugly as it may sound, another possibility would be to allow for a well known subnetpool_id, i.e. subnetpool_id\u003dDEFAULT. This would have the benefit of avoiding an extension, but as I said, it can be deemed pretty hacky!","commit_id":"58955ae96583c37241f7ecbca0b3bf503c707658"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a65aeadc1f4a7b4e499c2ce91ff1892a1f421337","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - The subnet API now includes a new"},{"line_number":4,"context_line":"    use_default_subnetpool attribute.  This attribute can"},{"line_number":5,"context_line":"    be specified on creating a subnet in lieu of a"},{"line_number":6,"context_line":"    subnetpool_id.  The two are mutually exclusive.  If"},{"line_number":7,"context_line":"    it is specified as True, the default subnet pool for"},{"line_number":8,"context_line":"    the requested ip_version will be looked up and used."},{"line_number":9,"context_line":"    If no default exists, an error will be returned."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bae84128_b1d3fc37","line":6,"in_reply_to":"bae84128_a23bbeea","updated":"2016-02-20 00:54:41.000000000","message":"ack","commit_id":"58955ae96583c37241f7ecbca0b3bf503c707658"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"6b3455d7e53cc736dd1c3bd9f733dd68f056536a","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - The subnet API now includes a new"},{"line_number":4,"context_line":"    use_default_subnetpool attribute.  This attribute can"},{"line_number":5,"context_line":"    be specified on creating a subnet in lieu of a"},{"line_number":6,"context_line":"    subnetpool_id.  The two are mutually exclusive.  If"},{"line_number":7,"context_line":"    it is specified as True, the default subnet pool for"},{"line_number":8,"context_line":"    the requested ip_version will be looked up and used."},{"line_number":9,"context_line":"    If no default exists, an error will be returned."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bae84128_a23bbeea","line":6,"in_reply_to":"dae33548_046c5807","updated":"2016-02-19 18:31:39.000000000","message":"It could save work.  I actually considered this and I decided against it because it would be yet another wart on the API.\n\nThe thing is, you write a value to an attribute which ends up getting resolved to another value internally.  For example, you send \"DEFAULT\" and when you read the field back, the value is \"c3eec829-8892-4d3b-a91c-9c6561e65aff\" or whatever.\n\nI proposed something similar when we thought about allowing people to set the gateway and allocation pools even when the cidr is unknown.  I thought they could set the gateway to something like 0.0.0.N and allocation_pools to something like 0.0.0.3 - 0.0.0.127 expecting that the server would fill in the network address.  The strongest objection to this was on the grounds that the value would end up with something other than what was written to it.\n\nIt was suggested that we add new attributes (e.g. gateway_template, allocation_pools_template) to support this use case but, in the end, we ended up deciding that it was not compelling enough to do this and we ended up not supporting the use case at all.\n\nSo, my current proposal is in harmony with that feedback.  Lesson learned.","commit_id":"58955ae96583c37241f7ecbca0b3bf503c707658"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"4edf36525188572d6b01f3a3627121ac3708b968","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    modified to set the new use_default_subnetpool"},{"line_number":21,"context_line":"    attribute when creating a subnet."},{"line_number":22,"context_line":"deprecations:"},{"line_number":23,"context_line":"  - The default_subnet_pools option is now depracated for"},{"line_number":24,"context_line":"    removal in the Newton release.  The same"},{"line_number":25,"context_line":"    functionality is now provided by setting is_default"},{"line_number":26,"context_line":"    attribute on subnetpools to True using the API or"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dae33548_c448b08d","line":23,"updated":"2016-02-19 00:22:12.000000000","message":"deprecated, and to be removed in","commit_id":"58955ae96583c37241f7ecbca0b3bf503c707658"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a65aeadc1f4a7b4e499c2ce91ff1892a1f421337","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    modified to set the new use_default_subnetpool"},{"line_number":21,"context_line":"    attribute when creating a subnet."},{"line_number":22,"context_line":"deprecations:"},{"line_number":23,"context_line":"  - The default_subnet_pools option is now depracated for"},{"line_number":24,"context_line":"    removal in the Newton release.  The same"},{"line_number":25,"context_line":"    functionality is now provided by setting is_default"},{"line_number":26,"context_line":"    attribute on subnetpools to True using the API or"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bae84128_5118b01d","line":23,"in_reply_to":"bae84128_e56830bd","updated":"2016-02-20 00:54:41.000000000","message":"none, it read better in my head. I should have prefixed my comment with nit alert:","commit_id":"58955ae96583c37241f7ecbca0b3bf503c707658"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"6b3455d7e53cc736dd1c3bd9f733dd68f056536a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    modified to set the new use_default_subnetpool"},{"line_number":21,"context_line":"    attribute when creating a subnet."},{"line_number":22,"context_line":"deprecations:"},{"line_number":23,"context_line":"  - The default_subnet_pools option is now depracated for"},{"line_number":24,"context_line":"    removal in the Newton release.  The same"},{"line_number":25,"context_line":"    functionality is now provided by setting is_default"},{"line_number":26,"context_line":"    attribute on subnetpools to True using the API or"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bae84128_e56830bd","line":23,"in_reply_to":"dae33548_c448b08d","updated":"2016-02-19 18:31:39.000000000","message":"I\u0027m happy to make that change but what\u0027s the difference?","commit_id":"58955ae96583c37241f7ecbca0b3bf503c707658"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"bb29348d1fefe58c6c85f275fe9b2105cddb332c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  - TODO Should the content of the \u0027issues\u0027 section be"},{"line_number":30,"context_line":"    here instead?"},{"line_number":31,"context_line":"other:"},{"line_number":32,"context_line":"  - TODO Or here?"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dae33548_5f1474e7","line":32,"updated":"2016-02-18 20:00:32.000000000","message":"Is this going to cover PD?","commit_id":"58955ae96583c37241f7ecbca0b3bf503c707658"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"2fe7940033d271582cc3c682b2df7ebd6c82e600","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  - TODO Should the content of the \u0027issues\u0027 section be"},{"line_number":30,"context_line":"    here instead?"},{"line_number":31,"context_line":"other:"},{"line_number":32,"context_line":"  - TODO Or here?"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dae33548_c1db8220","line":32,"in_reply_to":"dae33548_5f1474e7","updated":"2016-02-18 23:35:45.000000000","message":"By \"cover\" do you mean will PD be mentioned here in this release note?  Or, do you mean will this whole patch cover the PD use case?  If the latter, the answer is yes.  This patch will apply to the PD workflow.\n\nI could mention PD explicitly here in the release notes.  Technically they fall under \"workflows which depended on this new behavior.\"  But, it probably represents the majority of these.  So, mentioning it specifically might be a good idea.","commit_id":"58955ae96583c37241f7ecbca0b3bf503c707658"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"4e51548bbbfd63db8fd6d5886ee221fbb0774636","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    client."},{"line_number":28,"context_line":"fixes:"},{"line_number":29,"context_line":"  - TODO Should the content of the \u0027issues\u0027 section be"},{"line_number":30,"context_line":"    here instead?"},{"line_number":31,"context_line":"other:"},{"line_number":32,"context_line":"  - TODO Or here?"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bae84128_b07e0817","line":30,"updated":"2016-02-22 19:27:09.000000000","message":"After reading the \"issues\" section, that blurb does seem more appropriate under the \"fixes\" section.","commit_id":"39fbd201a690504c09afcdbcdf040c8b8105e08e"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e9abd3975a6080edea16f12c156df9f751838489","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    client."},{"line_number":28,"context_line":"fixes:"},{"line_number":29,"context_line":"  - TODO Should the content of the \u0027issues\u0027 section be"},{"line_number":30,"context_line":"    here instead?"},{"line_number":31,"context_line":"other:"},{"line_number":32,"context_line":"  - TODO Or here?"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bae84128_8171ca78","line":30,"in_reply_to":"bae84128_b07e0817","updated":"2016-02-23 15:46:00.000000000","message":"I\u0027ll figure this out in the next patch set.","commit_id":"39fbd201a690504c09afcdbcdf040c8b8105e08e"}]}