)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18485,"name":"Haim Daniel","email":"hdaniel@redhat.com","username":"hdaniel"},"change_message_id":"98472cf3fcb9a0d93f3056ce424ae28a28c86dac","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enable flag \"RECLONE\" for ovs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When user set \"RECLONE\" in local.conf, it is assume all"},{"line_number":10,"context_line":"component will be recloned."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2831f77271880c5964627673cbc0a62c211a045a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7af24918_39cb43a7","line":9,"range":{"start_line":9,"start_character":10,"end_line":9,"end_character":14},"updated":"2016-03-02 06:41:53.000000000","message":"s/set/sets","commit_id":"3f1585535308aba0180975044f50e4f832b4671f"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"3d64ce862b1800b5bf1e29f2f0b4907bd492bf9d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enable flag \"RECLONE\" for ovs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When user set \"RECLONE\" in local.conf, it is assume all"},{"line_number":10,"context_line":"component will be recloned."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2831f77271880c5964627673cbc0a62c211a045a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7af24918_ddc5e43c","line":9,"range":{"start_line":9,"start_character":10,"end_line":9,"end_character":14},"in_reply_to":"7af24918_39cb43a7","updated":"2016-03-02 08:43:54.000000000","message":"Done","commit_id":"3f1585535308aba0180975044f50e4f832b4671f"},{"author":{"_account_id":18485,"name":"Haim Daniel","email":"hdaniel@redhat.com","username":"hdaniel"},"change_message_id":"98472cf3fcb9a0d93f3056ce424ae28a28c86dac","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Enable flag \"RECLONE\" for ovs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When user set \"RECLONE\" in local.conf, it is assume all"},{"line_number":10,"context_line":"component will be recloned."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2831f77271880c5964627673cbc0a62c211a045a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7af24918_bf1bb31a","line":10,"updated":"2016-03-02 06:41:53.000000000","message":"Please add more comprehensive message. Explain what is the expected behavior as opposed to what the result is in the current code e.g. \u0027When user sets RECLONE\u003dTrue in local.conf, all components need to be cloned. This flag is not handled in the ovs script, and when the repo exists - it won\u0027t be refreshed\u0027.\nAnd IMO the commit message should state that this patch adds the support for the flag, not enabling it.","commit_id":"3f1585535308aba0180975044f50e4f832b4671f"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"3d64ce862b1800b5bf1e29f2f0b4907bd492bf9d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Enable flag \"RECLONE\" for ovs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When user set \"RECLONE\" in local.conf, it is assume all"},{"line_number":10,"context_line":"component will be recloned."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2831f77271880c5964627673cbc0a62c211a045a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7af24918_7d9f7050","line":10,"in_reply_to":"7af24918_bf1bb31a","updated":"2016-03-02 08:43:54.000000000","message":"Thanks !","commit_id":"3f1585535308aba0180975044f50e4f832b4671f"}],"devstack/lib/ovs":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"f45a23ec380178a47bf4ff022fa185f4b39a2960","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        cd $OVS_REPO_NAME"},{"line_number":56,"context_line":"        git remote set-url origin $OVS_REPO"},{"line_number":57,"context_line":"        git fetch origin"},{"line_number":58,"context_line":"        find $OVS_REPO_NAME -name \u0027*.pyc\u0027 -delete"},{"line_number":59,"context_line":"        git checkout -f origin/$OVS_BRANCH"},{"line_number":60,"context_line":"        git branch -D $OVS_BRANCH || true"},{"line_number":61,"context_line":"        git checkout -b $OVS_BRANCH"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"bae84128_ffe5fb37","line":58,"updated":"2016-02-22 21:18:43.000000000","message":"why is this needed?  Did you run into a particular problem here?  Is running \"make clean\" here instead sufficient?","commit_id":"988e4bc64845f1a182e4110c8ef65000b34c9fbf"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"72aae63709450246f64ed840901306b48cf77465","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        cd $OVS_REPO_NAME"},{"line_number":56,"context_line":"        git remote set-url origin $OVS_REPO"},{"line_number":57,"context_line":"        git fetch origin"},{"line_number":58,"context_line":"        find $OVS_REPO_NAME -name \u0027*.pyc\u0027 -delete"},{"line_number":59,"context_line":"        git checkout -f origin/$OVS_BRANCH"},{"line_number":60,"context_line":"        git branch -D $OVS_BRANCH || true"},{"line_number":61,"context_line":"        git checkout -b $OVS_BRANCH"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"bae84128_5c1835d3","line":58,"in_reply_to":"bae84128_41f085fe","updated":"2016-02-23 22:01:34.000000000","message":"OK.  That\u0027s a python project focused thing.  A more appropriate command for ovs would be \"make clean\".  That should also remove the pyc files.  If it doesn\u0027t, let me know and I\u0027ll fix ovs.","commit_id":"988e4bc64845f1a182e4110c8ef65000b34c9fbf"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"38105043ee3f4b25b093d27518b51c9d09a7d7fa","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        cd $OVS_REPO_NAME"},{"line_number":56,"context_line":"        git remote set-url origin $OVS_REPO"},{"line_number":57,"context_line":"        git fetch origin"},{"line_number":58,"context_line":"        find $OVS_REPO_NAME -name \u0027*.pyc\u0027 -delete"},{"line_number":59,"context_line":"        git checkout -f origin/$OVS_BRANCH"},{"line_number":60,"context_line":"        git branch -D $OVS_BRANCH || true"},{"line_number":61,"context_line":"        git checkout -b $OVS_BRANCH"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"bae84128_41f085fe","line":58,"in_reply_to":"bae84128_ffe5fb37","updated":"2016-02-23 01:59:54.000000000","message":"I just copied it from:\nhttps://github.com/openstack-dev/devstack/blob/master/functions-common#L525-L528","commit_id":"988e4bc64845f1a182e4110c8ef65000b34c9fbf"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"f45a23ec380178a47bf4ff022fa185f4b39a2960","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        find $OVS_REPO_NAME -name \u0027*.pyc\u0027 -delete"},{"line_number":59,"context_line":"        git checkout -f origin/$OVS_BRANCH"},{"line_number":60,"context_line":"        git branch -D $OVS_BRANCH || true"},{"line_number":61,"context_line":"        git checkout -b $OVS_BRANCH"},{"line_number":62,"context_line":"    else"},{"line_number":63,"context_line":"        cd $OVS_REPO_NAME"},{"line_number":64,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"bae84128_ff185b20","line":61,"updated":"2016-02-22 21:18:43.000000000","message":"It seems like you could remove the first checkout and replace with:\n\n    git checkout -f -b $OVS_BRANCH origin/$OVS_BRANCH\n\nand does RECLONE typically throw away local uncommitted changes like this?  I mainly just want to make sure this remains consistent.","commit_id":"988e4bc64845f1a182e4110c8ef65000b34c9fbf"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"72aae63709450246f64ed840901306b48cf77465","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        find $OVS_REPO_NAME -name \u0027*.pyc\u0027 -delete"},{"line_number":59,"context_line":"        git checkout -f origin/$OVS_BRANCH"},{"line_number":60,"context_line":"        git branch -D $OVS_BRANCH || true"},{"line_number":61,"context_line":"        git checkout -b $OVS_BRANCH"},{"line_number":62,"context_line":"    else"},{"line_number":63,"context_line":"        cd $OVS_REPO_NAME"},{"line_number":64,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"bae84128_9c859dd0","line":61,"in_reply_to":"bae84128_21bd8102","updated":"2016-02-23 22:01:34.000000000","message":"how about use those functions instead of copying the code?  It looks like you can reuse the code there..","commit_id":"988e4bc64845f1a182e4110c8ef65000b34c9fbf"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"814aa02f9e328875594a6e15a9083164216af639","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        find $OVS_REPO_NAME -name \u0027*.pyc\u0027 -delete"},{"line_number":59,"context_line":"        git checkout -f origin/$OVS_BRANCH"},{"line_number":60,"context_line":"        git branch -D $OVS_BRANCH || true"},{"line_number":61,"context_line":"        git checkout -b $OVS_BRANCH"},{"line_number":62,"context_line":"    else"},{"line_number":63,"context_line":"        cd $OVS_REPO_NAME"},{"line_number":64,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"bae84128_6888d071","line":61,"in_reply_to":"bae84128_9c859dd0","updated":"2016-02-24 00:58:14.000000000","message":"Sure ! Please check the new patch set.","commit_id":"988e4bc64845f1a182e4110c8ef65000b34c9fbf"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"38105043ee3f4b25b093d27518b51c9d09a7d7fa","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        find $OVS_REPO_NAME -name \u0027*.pyc\u0027 -delete"},{"line_number":59,"context_line":"        git checkout -f origin/$OVS_BRANCH"},{"line_number":60,"context_line":"        git branch -D $OVS_BRANCH || true"},{"line_number":61,"context_line":"        git checkout -b $OVS_BRANCH"},{"line_number":62,"context_line":"    else"},{"line_number":63,"context_line":"        cd $OVS_REPO_NAME"},{"line_number":64,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"bae84128_21bd8102","line":61,"in_reply_to":"bae84128_ff185b20","updated":"2016-02-23 01:59:54.000000000","message":"devstack do it by:\n\nhttps://github.com/openstack-dev/devstack/blob/master/functions-common#L533-L536\n\n\nI think throw away local uncommitted changes in the specific branch is acceptable for RECLONE, because if user want to save their change, they should set RECLONE\u003dFalse.\n\nIf there is a better way, I can accept it too.","commit_id":"988e4bc64845f1a182e4110c8ef65000b34c9fbf"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"aa13c99ebacd2cdf9f7a8fa841afec4353e8a4cb","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    OVS_DIR\u003d$DEST/$OVS_REPO_NAME"},{"line_number":49,"context_line":"    git_clone $OVS_REPO $OVS_DIR $OVS_BRANCH"},{"line_number":50,"context_line":"    cd $OVS_DIR"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    # TODO: Can you create package list files like you can inside devstack?"},{"line_number":53,"context_line":"    install_package autoconf automake libtool gcc patch make"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"bae84128_3c64f547","line":50,"updated":"2016-02-25 06:28:09.000000000","message":"gate jobs are expected work with ERROR_ON_CLONE\u003dTrue,\nwith which i don\u0027t think this works.\nwhile it isn\u0027t the case for functional tests, which is currently the only user of this file,\nit\u0027s better to keep this safe with ERROR_ON_CLONE\u003dTrue.","commit_id":"1281a207e1ba21392c48d7c331eb62f6333c3784"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"9c0741e30a32afd4cfe7b10d1bdb222bec6d8fb9","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    OVS_DIR\u003d$DEST/$OVS_REPO_NAME"},{"line_number":49,"context_line":"    git_clone $OVS_REPO $OVS_DIR $OVS_BRANCH"},{"line_number":50,"context_line":"    cd $OVS_DIR"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    # TODO: Can you create package list files like you can inside devstack?"},{"line_number":53,"context_line":"    install_package autoconf automake libtool gcc patch make"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"bae84128_c53d2cbd","line":50,"in_reply_to":"bae84128_221a0e18","updated":"2016-02-25 07:39:47.000000000","message":"i expect it only works for openstack-managed repositories.\n(please confirm with someone familiar with infra)","commit_id":"1281a207e1ba21392c48d7c331eb62f6333c3784"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"eecaea0f16788ec517d965c868b74b93e438cf88","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    OVS_DIR\u003d$DEST/$OVS_REPO_NAME"},{"line_number":49,"context_line":"    git_clone $OVS_REPO $OVS_DIR $OVS_BRANCH"},{"line_number":50,"context_line":"    cd $OVS_DIR"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    # TODO: Can you create package list files like you can inside devstack?"},{"line_number":53,"context_line":"    install_package autoconf automake libtool gcc patch make"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"bae84128_3fed0726","line":50,"in_reply_to":"bae84128_3c64f547","updated":"2016-02-25 06:38:47.000000000","message":"Sorry, could you explain a little more ?\nI\u0027m afraid I can not understand what you means...","commit_id":"1281a207e1ba21392c48d7c331eb62f6333c3784"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"9197f04593aa076c6bf30d7f06d1e1d6b9cc1d16","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    OVS_DIR\u003d$DEST/$OVS_REPO_NAME"},{"line_number":49,"context_line":"    git_clone $OVS_REPO $OVS_DIR $OVS_BRANCH"},{"line_number":50,"context_line":"    cd $OVS_DIR"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    # TODO: Can you create package list files like you can inside devstack?"},{"line_number":53,"context_line":"    install_package autoconf automake libtool gcc patch make"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"bae84128_ff4a7fab","line":50,"in_reply_to":"bae84128_3fed0726","updated":"2016-02-25 07:00:43.000000000","message":"this mail has an explanation of the intention of ERROR_ON_CLONE\u003dTrue.\nhttp://lists.openstack.org/pipermail/openstack-dev/2015-September/075355.html\n\nERROR_ON_CLONE check is implemented in git_clone function.","commit_id":"1281a207e1ba21392c48d7c331eb62f6333c3784"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"fc1f31444cd15ebfa667be303275ab234faeeb42","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    OVS_DIR\u003d$DEST/$OVS_REPO_NAME"},{"line_number":49,"context_line":"    git_clone $OVS_REPO $OVS_DIR $OVS_BRANCH"},{"line_number":50,"context_line":"    cd $OVS_DIR"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    # TODO: Can you create package list files like you can inside devstack?"},{"line_number":53,"context_line":"    install_package autoconf automake libtool gcc patch make"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"bae84128_5016f8a7","line":50,"in_reply_to":"bae84128_c53d2cbd","updated":"2016-02-25 08:14:21.000000000","message":"Sure ! \n\nI have send a mail to mailing list : http://lists.openstack.org/pipermail/openstack-dev/2016-February/087522.html.\n\nLet\u0027s wait a while then.","commit_id":"1281a207e1ba21392c48d7c331eb62f6333c3784"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"2e61ae6b262d959249418f15e7deb80ab1058245","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    OVS_DIR\u003d$DEST/$OVS_REPO_NAME"},{"line_number":49,"context_line":"    git_clone $OVS_REPO $OVS_DIR $OVS_BRANCH"},{"line_number":50,"context_line":"    cd $OVS_DIR"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    # TODO: Can you create package list files like you can inside devstack?"},{"line_number":53,"context_line":"    install_package autoconf automake libtool gcc patch make"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"bae84128_221a0e18","line":50,"in_reply_to":"bae84128_ff4a7fab","updated":"2016-02-25 07:21:41.000000000","message":"Thanks very much for the info !\n\nAnother question:\nWhy can\u0027t we add ovs to \\$PROJECTS variable in the job definition as the mail suggested ?","commit_id":"1281a207e1ba21392c48d7c331eb62f6333c3784"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"90cdade853e1a04574e20e0a1ed97836a9fb8d93","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    cd $DEST"},{"line_number":49,"context_line":"    if [ ! -d $OVS_REPO_NAME ] ; then"},{"line_number":50,"context_line":"        git clone $OVS_REPO"},{"line_number":51,"context_line":"        cd $OVS_REPO_NAME"},{"line_number":52,"context_line":"        git checkout $OVS_BRANCH"},{"line_number":53,"context_line":"    else"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"7af24918_0b42703e","line":50,"updated":"2016-03-02 03:11:47.000000000","message":"While you\u0027re in here and adding the use of the git_clone function below, can you add a comment here that says something like:\n\n\"We can\u0027t use git_clone here because we want to ignore ERROR_ON_CLONE\"","commit_id":"249c2b9d7dfabddf33713286564f27f0774b1f4a"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"ebc9f37e582a6165fe30693066d326b8f39d9950","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    cd $DEST"},{"line_number":49,"context_line":"    if [ ! -d $OVS_REPO_NAME ] ; then"},{"line_number":50,"context_line":"        git clone $OVS_REPO"},{"line_number":51,"context_line":"        cd $OVS_REPO_NAME"},{"line_number":52,"context_line":"        git checkout $OVS_BRANCH"},{"line_number":53,"context_line":"    else"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"7af24918_a1bb9b71","line":50,"in_reply_to":"7af24918_0b42703e","updated":"2016-03-02 04:39:15.000000000","message":"Done","commit_id":"249c2b9d7dfabddf33713286564f27f0774b1f4a"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"90cdade853e1a04574e20e0a1ed97836a9fb8d93","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        git checkout $OVS_BRANCH"},{"line_number":53,"context_line":"    else"},{"line_number":54,"context_line":"        OVS_DIR\u003d$DEST/$OVS_REPO_NAME"},{"line_number":55,"context_line":"        git_clone $OVS_REPO $OVS_DIR $OVS_BRANCH"},{"line_number":56,"context_line":"        cd $OVS_DIR"},{"line_number":57,"context_line":"    fi"},{"line_number":58,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"7af24918_0b3b90d2","line":55,"updated":"2016-03-02 03:11:47.000000000","message":"I see now ... but it\u0027s really not obvious why the git_clone function is called here.  Can you add a comment that says something like \"Even though the directory already exists, call git_clone to update it if needed based on the RECLONE option.\"","commit_id":"249c2b9d7dfabddf33713286564f27f0774b1f4a"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"ebc9f37e582a6165fe30693066d326b8f39d9950","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        git checkout $OVS_BRANCH"},{"line_number":53,"context_line":"    else"},{"line_number":54,"context_line":"        OVS_DIR\u003d$DEST/$OVS_REPO_NAME"},{"line_number":55,"context_line":"        git_clone $OVS_REPO $OVS_DIR $OVS_BRANCH"},{"line_number":56,"context_line":"        cd $OVS_DIR"},{"line_number":57,"context_line":"    fi"},{"line_number":58,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"7af24918_814adf81","line":55,"in_reply_to":"7af24918_0b3b90d2","updated":"2016-03-02 04:39:15.000000000","message":"Done","commit_id":"249c2b9d7dfabddf33713286564f27f0774b1f4a"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"014e71e5ef4d63189a29e3a47466a2393e12c018","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        cd $OVS_REPO_NAME"},{"line_number":53,"context_line":"        git checkout $OVS_BRANCH"},{"line_number":54,"context_line":"    else"},{"line_number":55,"context_line":"        OVS_DIR\u003d$DEST/$OVS_REPO_NAME"},{"line_number":56,"context_line":"        # Even though the directory already exists, call git_clone to update it"},{"line_number":57,"context_line":"        # if needed based on the RECLONE option"},{"line_number":58,"context_line":"        git_clone $OVS_REPO $OVS_DIR $OVS_BRANCH"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"5aef4532_62d51542","line":55,"range":{"start_line":55,"start_character":8,"end_line":55,"end_character":36},"updated":"2016-03-08 05:44:34.000000000","message":"It\u0027s better to move it on L16.","commit_id":"cff776ca0f34eef781aef01fac9f00412f64c1bb"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"351416750ac46ae56a2d6ae27e64378b787b99b6","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        cd $OVS_REPO_NAME"},{"line_number":53,"context_line":"        git checkout $OVS_BRANCH"},{"line_number":54,"context_line":"    else"},{"line_number":55,"context_line":"        OVS_DIR\u003d$DEST/$OVS_REPO_NAME"},{"line_number":56,"context_line":"        # Even though the directory already exists, call git_clone to update it"},{"line_number":57,"context_line":"        # if needed based on the RECLONE option"},{"line_number":58,"context_line":"        git_clone $OVS_REPO $OVS_DIR $OVS_BRANCH"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"3afc51ec_f4828051","line":55,"range":{"start_line":55,"start_character":8,"end_line":55,"end_character":36},"in_reply_to":"5aef4532_62d51542","updated":"2016-03-14 01:28:05.000000000","message":"Done","commit_id":"cff776ca0f34eef781aef01fac9f00412f64c1bb"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"014e71e5ef4d63189a29e3a47466a2393e12c018","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        git_clone $OVS_REPO $OVS_DIR $OVS_BRANCH"},{"line_number":59,"context_line":"        cd $OVS_DIR"},{"line_number":60,"context_line":"    fi"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    # TODO: Can you create package list files like you can inside devstack?"},{"line_number":63,"context_line":"    install_package autoconf automake libtool gcc patch make"},{"line_number":64,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":9,"id":"5aef4532_c27ce974","line":61,"updated":"2016-03-08 05:44:34.000000000","message":"Why not more refactoring like the following?\n\n\n    if [ ! -d $OVS_DIR ] ; then\n        # We can\u0027t use git_clone here because we want to ignore ERROR_ON_CLONE\n        cd $DEST\n        git clone $OVS_REPO\n        cd $OVS_REPO_NAME\n        git checkout $OVS_BRANCH\n    else\n        # Even though the directory already exists, call git_clone to update it\n        # if needed based on the RECLONE option\n        git_clone $OVS_REPO $OVS_DIR $OVS_BRANCH\n        cd $OVS_DIR\n    fi","commit_id":"cff776ca0f34eef781aef01fac9f00412f64c1bb"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"351416750ac46ae56a2d6ae27e64378b787b99b6","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        git_clone $OVS_REPO $OVS_DIR $OVS_BRANCH"},{"line_number":59,"context_line":"        cd $OVS_DIR"},{"line_number":60,"context_line":"    fi"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    # TODO: Can you create package list files like you can inside devstack?"},{"line_number":63,"context_line":"    install_package autoconf automake libtool gcc patch make"},{"line_number":64,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":9,"id":"3afc51ec_1480cc45","line":61,"in_reply_to":"5aef4532_c27ce974","updated":"2016-03-14 01:28:05.000000000","message":"Done","commit_id":"cff776ca0f34eef781aef01fac9f00412f64c1bb"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"0898df0581c410c404cbf54b2de6c36c23a72bd7","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        prefix\u003d\"--prefix\u003d$prefix\""},{"line_number":47,"context_line":"    fi"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    if [ ! -d $OVS_REPO_NAME ] ; then"},{"line_number":50,"context_line":"        # We can\u0027t use git_clone here because we want to ignore ERROR_ON_CLONE"},{"line_number":51,"context_line":"        cd $DEST"},{"line_number":52,"context_line":"        git clone $OVS_REPO"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"da0c15f0_e9812a91","line":49,"range":{"start_line":49,"start_character":14,"end_line":49,"end_character":28},"updated":"2016-03-25 08:02:46.000000000","message":"$OVS_DIR","commit_id":"c70a3a005eb79519bfc089a94e0ee63c82033741"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"0807d0406ea8b28b3db93317c4f39ee3c1923135","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        prefix\u003d\"--prefix\u003d$prefix\""},{"line_number":47,"context_line":"    fi"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    if [ ! -d $OVS_REPO_NAME ] ; then"},{"line_number":50,"context_line":"        # We can\u0027t use git_clone here because we want to ignore ERROR_ON_CLONE"},{"line_number":51,"context_line":"        cd $DEST"},{"line_number":52,"context_line":"        git clone $OVS_REPO"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"da0c15f0_c4736d4c","line":49,"range":{"start_line":49,"start_character":14,"end_line":49,"end_character":28},"in_reply_to":"da0c15f0_e9812a91","updated":"2016-03-25 08:17:04.000000000","message":"Thanks!\nDone !","commit_id":"c70a3a005eb79519bfc089a94e0ee63c82033741"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"506757f176360aa11b29df7cf3958440e6ee020c","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    if [ -n \"$prefix\" ]; then"},{"line_number":46,"context_line":"        prefix\u003d\"--prefix\u003d$prefix\""},{"line_number":47,"context_line":"    fi"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    if [ ! -d $OVS_DIR ] ; then"},{"line_number":50,"context_line":"        # We can\u0027t use git_clone here because we want to ignore ERROR_ON_CLONE"},{"line_number":51,"context_line":"        cd $DEST"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"da0c15f0_f8c5715b","line":48,"updated":"2016-03-25 10:46:22.000000000","message":"Question: why do you ignore ERROR_ON_CLONE only when the directory does not exist? Don\u0027t we need to ignore it for \"else\" case?\n\nIt does not make sense to me to use different ERROR_ON_CLONE for if-else.","commit_id":"4293f82d93a752dba25398c1dc985c3fa45a1c34"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"24c367aca3760c4491950ca5a5ec3d55fb17e97d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    if [ -n \"$prefix\" ]; then"},{"line_number":46,"context_line":"        prefix\u003d\"--prefix\u003d$prefix\""},{"line_number":47,"context_line":"    fi"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    if [ ! -d $OVS_DIR ] ; then"},{"line_number":50,"context_line":"        # We can\u0027t use git_clone here because we want to ignore ERROR_ON_CLONE"},{"line_number":51,"context_line":"        cd $DEST"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"ba0121b8_3a2fddf7","line":48,"in_reply_to":"da0c15f0_d850360d","updated":"2016-04-04 05:10:39.000000000","message":"I checked when ERROR_ON_CLONE is used.\nERROR_ON_CLONE is used only when the destination directory does not exist, so it looks good.","commit_id":"4293f82d93a752dba25398c1dc985c3fa45a1c34"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"38121652995880901cc26a17e13596b2e88927c7","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    if [ -n \"$prefix\" ]; then"},{"line_number":46,"context_line":"        prefix\u003d\"--prefix\u003d$prefix\""},{"line_number":47,"context_line":"    fi"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    if [ ! -d $OVS_DIR ] ; then"},{"line_number":50,"context_line":"        # We can\u0027t use git_clone here because we want to ignore ERROR_ON_CLONE"},{"line_number":51,"context_line":"        cd $DEST"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"da0c15f0_d850360d","line":48,"in_reply_to":"da0c15f0_f8c5715b","updated":"2016-03-28 01:15:20.000000000","message":"Sorry, could you explain a little more ?\nI\u0027m not sure I have really understand your question.\n\nAnyway, in function \"git_clone\", \"ERROR_ON_CLONE\" only been checked when the directory does not exist, so I think there is no \"else\" case at all.","commit_id":"4293f82d93a752dba25398c1dc985c3fa45a1c34"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"506757f176360aa11b29df7cf3958440e6ee020c","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    fi"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    if [ ! -d $OVS_DIR ] ; then"},{"line_number":50,"context_line":"        # We can\u0027t use git_clone here because we want to ignore ERROR_ON_CLONE"},{"line_number":51,"context_line":"        cd $DEST"},{"line_number":52,"context_line":"        git clone $OVS_REPO"},{"line_number":53,"context_line":"        cd $OVS_REPO_NAME"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"da0c15f0_d8ca2d4f","line":50,"range":{"start_line":50,"start_character":8,"end_line":50,"end_character":78},"updated":"2016-03-25 10:46:22.000000000","message":"Can\u0027t we override ERROR_ON_CLONE and restore it?\n\n  # \u003cgood description of the reason\u003e\n  local saved_error_on_clone\u003d$ERROR_ON_CLONE\n  ERROR_ON_CLONE\u003d\u003cTrue/False as you want\u003e\n  git_clone $OVS_REPO $OVS_DIR $OVS_BRANCH\n  ERROR_ON_CLONE\u003d$saved_error_on_clone","commit_id":"4293f82d93a752dba25398c1dc985c3fa45a1c34"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"24c367aca3760c4491950ca5a5ec3d55fb17e97d","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    fi"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    if [ ! -d $OVS_DIR ] ; then"},{"line_number":50,"context_line":"        # We can\u0027t use git_clone here because we want to ignore ERROR_ON_CLONE"},{"line_number":51,"context_line":"        cd $DEST"},{"line_number":52,"context_line":"        git clone $OVS_REPO"},{"line_number":53,"context_line":"        cd $OVS_REPO_NAME"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"ba0121b8_3ae19dd1","line":50,"range":{"start_line":50,"start_character":8,"end_line":50,"end_character":78},"in_reply_to":"da0c15f0_78692abe","updated":"2016-04-04 05:10:39.000000000","message":"Okay, though I think the situation described in the ML post does not consider cloning a git repo outside of openstack infra.\n\ngit_clone at L.58 handles all features of git_clone like OFFLINE or RECLONE, so I think it works well.","commit_id":"4293f82d93a752dba25398c1dc985c3fa45a1c34"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"38121652995880901cc26a17e13596b2e88927c7","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    fi"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    if [ ! -d $OVS_DIR ] ; then"},{"line_number":50,"context_line":"        # We can\u0027t use git_clone here because we want to ignore ERROR_ON_CLONE"},{"line_number":51,"context_line":"        cd $DEST"},{"line_number":52,"context_line":"        git clone $OVS_REPO"},{"line_number":53,"context_line":"        cd $OVS_REPO_NAME"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"da0c15f0_78692abe","line":50,"range":{"start_line":50,"start_character":8,"end_line":50,"end_character":78},"in_reply_to":"da0c15f0_d8ca2d4f","updated":"2016-03-28 01:15:20.000000000","message":"It is said in http://lists.openstack.org/pipermail/openstack-dev/2015-September/075355.html :\n\n\" It is also not acceptable to read its value and alter a program\u0027s behavior.\"\n\nSo, I think we\u0027d better not change the value.","commit_id":"4293f82d93a752dba25398c1dc985c3fa45a1c34"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"24c367aca3760c4491950ca5a5ec3d55fb17e97d","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    if [ ! -d $OVS_DIR ] ; then"},{"line_number":50,"context_line":"        # We can\u0027t use git_clone here because we want to ignore ERROR_ON_CLONE"},{"line_number":51,"context_line":"        cd $DEST"},{"line_number":52,"context_line":"        git clone $OVS_REPO"},{"line_number":53,"context_line":"        cd $OVS_REPO_NAME"},{"line_number":54,"context_line":"        git checkout $OVS_BRANCH"},{"line_number":55,"context_line":"    else"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"ba0121b8_1af2d99a","line":52,"range":{"start_line":52,"start_character":8,"end_line":52,"end_character":27},"updated":"2016-04-04 05:10:39.000000000","message":"I hope you use \u0027git_timed\u0027 instead of \u0027git\u0027 command directly.\n\nhttps://github.com/openstack-dev/devstack/blob/master/functions-common#L536","commit_id":"4293f82d93a752dba25398c1dc985c3fa45a1c34"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"42056bc698954fb3ab22fc0e9100591d33d863ef","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    if [ ! -d $OVS_DIR ] ; then"},{"line_number":50,"context_line":"        # We can\u0027t use git_clone here because we want to ignore ERROR_ON_CLONE"},{"line_number":51,"context_line":"        cd $DEST"},{"line_number":52,"context_line":"        git clone $OVS_REPO"},{"line_number":53,"context_line":"        cd $OVS_REPO_NAME"},{"line_number":54,"context_line":"        git checkout $OVS_BRANCH"},{"line_number":55,"context_line":"    else"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"7a1b2928_2548782d","line":52,"range":{"start_line":52,"start_character":8,"end_line":52,"end_character":27},"in_reply_to":"ba0121b8_1af2d99a","updated":"2016-04-11 01:43:49.000000000","message":"Done","commit_id":"4293f82d93a752dba25398c1dc985c3fa45a1c34"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"decb6686b686cad00c2698a898b18f8295b9ecd9","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        # We can\u0027t use git_clone here because we want to ignore ERROR_ON_CLONE"},{"line_number":57,"context_line":"        git_timed clone $OVS_REPO $OVS_DIR"},{"line_number":58,"context_line":"        cd $OVS_DIR"},{"line_number":59,"context_line":"        git_timed checkout $OVS_BRANCH"},{"line_number":60,"context_line":"    else"},{"line_number":61,"context_line":"        # Even though the directory already exists, call git_clone to update it"},{"line_number":62,"context_line":"        # if needed based on the RECLONE option"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"7a1b2928_6be4013b","line":59,"range":{"start_line":59,"start_character":8,"end_line":59,"end_character":17},"updated":"2016-04-11 03:55:40.000000000","message":"We don\u0027t need use git_timed here because git_timed should be used in a case which git command gets itself infinitely stuck with transient network errors or other issues with the remote end[1]. The \"git checkout\" runs in local and it doesn\u0027t access network.\n\n[1]: https://github.com/openstack-dev/devstack/blob/master/functions-common#L583-L584","commit_id":"ea4d352b15e61eaf6f52767d85d3d54b080f0e16"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"e6ac94e711c6ecd6c64b4ebf1911acb32104e3b0","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        # We can\u0027t use git_clone here because we want to ignore ERROR_ON_CLONE"},{"line_number":57,"context_line":"        git_timed clone $OVS_REPO $OVS_DIR"},{"line_number":58,"context_line":"        cd $OVS_DIR"},{"line_number":59,"context_line":"        git_timed checkout $OVS_BRANCH"},{"line_number":60,"context_line":"    else"},{"line_number":61,"context_line":"        # Even though the directory already exists, call git_clone to update it"},{"line_number":62,"context_line":"        # if needed based on the RECLONE option"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"7a1b2928_cbbb9574","line":59,"range":{"start_line":59,"start_character":8,"end_line":59,"end_character":17},"in_reply_to":"7a1b2928_6be4013b","updated":"2016-04-11 04:45:16.000000000","message":"Done","commit_id":"ea4d352b15e61eaf6f52767d85d3d54b080f0e16"}]}
